joedolson
059878b96d
Toolbar: Accessibility: Keyboard navigation for screen readers.
...
Change the admin toolbar to have `role="menu"` and support opening for screen readers. Remove screen reader only log out link and collapse duplicate profile links into one link. This is an imperfect solution to a complex problem in the adminbar, but the lack of screen reader access to submenus is a major accessibility problem, and this fix provides access, even if the mechanism is imperfect.
Screen reader log out added in [21452].
Props abletec, Cheffheid, sabernhardt, alexstine, joedolson, afercia, sparklingrobots, danieltj, swissspidy, netweb, dionysous.
Fixes #34668 , #43633 .
Built from https://develop.svn.wordpress.org/trunk@57708
git-svn-id: http://core.svn.wordpress.org/trunk@57209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 00:52:10 +00:00
whyisjake
3dd9628aae
Build/Test Tools: Enable JSDocs to be linted with ESLint.
...
As part of the [Javascript Inline Docs Initiative](https://make.wordpress.org/core/handbook/docs/inline/js/ ) this add some tooling to lint Javascript docblocks. Two new commands:
* `npm run lint:jsdoc`
* `npm run lint:jsdoc:fix`
The latter will run the linter and try to fix an possible issues automatically.
Fixes #43828 .
Props netweb, atimmer, kamataryo, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48650
git-svn-id: http://core.svn.wordpress.org/trunk@48412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 23:35:02 +00:00
Dominik Schilling
7ded6c2d2a
Administration: Remove any CSS related to Internet Explorer versions 6 – 10.
...
In WordPress 3.2 support for IE6 was dropped, IE7 followed a few versions later. With the 4.8 release, WordPress officially ended support for Internet Explorer versions 8, 9, and 10. Yet, we still have shipped CSS for the unsupported IE versions....until now! Goodbye to ie.css and star hacks!
* Removes ie.css and `ie` style handle.
* Removes IE specific class names and any related CSS.
* Drops support for IE8 and older in `wp_customize_support_script()`.
* Updates compatibility mode for CSS minification to `ie11`.
Props ayeshrajans, isabel_brison, afercia, netweb, peterwilsoncc, ocean90.
Fixes #17232 , #46015 .
Built from https://develop.svn.wordpress.org/trunk@47771
git-svn-id: http://core.svn.wordpress.org/trunk@47547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-06 20:15:07 +00:00
Sergey Biryukov
001ffe81fb
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47122
git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Andrew Ozz
eb38423e22
Fixes in `admin-bar.js`:
...
- Silence errors when a node doesn't exist similarly to jQuery.
- Add "feature testing" and fallbacks for old browsers as this may run on the front-end.
- Improve inline docs.
Props dinhtungdu, azaozz.
Fixes #47069 .
Built from https://develop.svn.wordpress.org/trunk@46883
git-svn-id: http://core.svn.wordpress.org/trunk@46683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 18:56:03 +00:00
Sergey Biryukov
ee58f3f3d3
Coding Standards: Fix WPCS and JSHint issues in [46872].
...
See #47069 .
Built from https://develop.svn.wordpress.org/trunk@46874
git-svn-id: http://core.svn.wordpress.org/trunk@46674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-10 01:34:01 +00:00
Andrew Ozz
d617011afd
Fix the admin toolbar js when jQuery is not present and replace the jQuery based hoverIntent.js with a native implementation. Introduces the "hoverintent" (no dependencies) package.
...
Props dinhtungdu, audrasjb, azaozz.
Fixes #47069 .
Built from https://develop.svn.wordpress.org/trunk@46872
git-svn-id: http://core.svn.wordpress.org/trunk@46672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-10 01:03:02 +00:00
Konstantin Obenland
071984839c
Toolbar: Check if `obj` is set before using it.
...
Props pento.
See #44526 .
Built from https://develop.svn.wordpress.org/trunk@43556
git-svn-id: http://core.svn.wordpress.org/trunk@43385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-06 19:33:28 +00:00
Konstantin Obenland
51f09ffc2a
Toolbar: Fail gracefully when adding events to non-existent elements
...
Avoids a type error when `obj` is not set.
Fixes #44526 .
Built from https://develop.svn.wordpress.org/trunk@43517
git-svn-id: http://core.svn.wordpress.org/trunk@43346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-19 22:00:25 +00:00
atimmer
bde558be2f
Docs: Add file doc `@output` annotations.
...
These annotations make it clear to the reader of a JavaScript source
where the build process outputs to. These annotations can later be
integrated in a webpack configuration. This way there is one source of
truth.
The `build` folder is omitted from the paths, because a single JS file
shouldn't not be responsible of knowing where outputs in general will
end up at. A file only knows its output location relative to the
project.
Props adamsilverstein, herregroen, omarreiss, pento.
Fixes #44361 .
Built from https://develop.svn.wordpress.org/trunk@43347
git-svn-id: http://core.svn.wordpress.org/trunk@43175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:30:15 +00:00
atimmer
ba9e0ac030
Docs: Improve JSDoc for `admin-bar.js`.
...
Change an incorrect type and description after [43332].
Props afercia.
See #43871 .
Built from https://develop.svn.wordpress.org/trunk@43341
git-svn-id: http://core.svn.wordpress.org/trunk@43169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:27:38 +00:00
atimmer
e6c02f874c
Docs: Improve JSDoc for `admin-bar.js`.
...
Props manuelaugustin, terwdan, sjardo, LisanneKluitmans.
Fixes #43871 .
Built from https://develop.svn.wordpress.org/trunk@43332
git-svn-id: http://core.svn.wordpress.org/trunk@43160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:23:53 +00:00
Konstantin Obenland
f9c88fcb5c
Toolbar: Restore scroll-to-top functionality.
...
H/t Ipstenu.
Introduced in [33056].
See #29906 .
Built from https://develop.svn.wordpress.org/trunk@33334
git-svn-id: http://core.svn.wordpress.org/trunk@33306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 20:02:24 +00:00
Helen Hou-Sandí
f85306c65a
Toolbar: Allow submenus to be closed with a second tap on touch devices.
...
Also closes submenus when the admin menu is toggled open, as it opens below and thus can be obscured.
props stephdau, seanchayes.
see #29906 .
Built from https://develop.svn.wordpress.org/trunk@33056
git-svn-id: http://core.svn.wordpress.org/trunk@33027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 03:29:25 +00:00
Helen Hou-Sandí
2636199e54
Toolbar: Search item consistency for focus state and IE8.
...
props afercia.
fixes #31322 .
Built from https://develop.svn.wordpress.org/trunk@32074
git-svn-id: http://core.svn.wordpress.org/trunk@32053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 16:08:28 +00:00
Dominik Schilling
b145025fe1
Update hoverIntent to 1.8.1.
...
props rachelbaker, jesin.
fixes #31505 .
Built from https://develop.svn.wordpress.org/trunk@31723
git-svn-id: http://core.svn.wordpress.org/trunk@31704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 17:15:27 +00:00
Sergey Biryukov
a2f9b410f8
Toolbar: Make network admin accessible via keyboard.
...
props Cheffheid.
fixes #29422 .
Built from https://develop.svn.wordpress.org/trunk@31111
git-svn-id: http://core.svn.wordpress.org/trunk@31092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 09:51:22 +00:00
Andrew Ozz
448a401f77
Make older mobile browsers and IE7 usable:
...
- Text labels in the toolbar.
- Image icons in the visual editor.
- Some IE7 structural css fixes.
Fixes #26369 .
Built from https://develop.svn.wordpress.org/trunk@26819
git-svn-id: http://core.svn.wordpress.org/trunk@26706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 02:41:10 +00:00
Matt Thomas
c31444d1be
Make toolbar dropdown submenu links tappable. See #25972 , props ninnypants.
...
Built from https://develop.svn.wordpress.org/trunk@26716
git-svn-id: http://core.svn.wordpress.org/trunk@26605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 05:28:11 +00:00
Andrew Nacin
a749e31b75
Fix JSHint errors in admin-bar.js.
...
props kadamwhite.
fixes #25970 .
Built from https://develop.svn.wordpress.org/trunk@26160
git-svn-id: http://core.svn.wordpress.org/trunk@26071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 05:51:10 +00:00
Dominik Schilling
e6ebfdff1e
hoverIntent r7. props mjbanks. fixes #23752 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-14 19:53:05 +00:00
Andrew Ozz
e9245269a7
Autosave to the browser's sessionStorage, compare this autosave to the post content on page load and let the user restore it when the data is not the same. First run, see #23220
...
git-svn-id: http://core.svn.wordpress.org/trunk@23683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-13 10:08:16 +00:00
Andrew Nacin
2301074821
Stop using deprecated jQuery API (.browser and .live). Do manual UA sniffing where still necessary. Improve selector performance by using delegated events. props ocean90. see #22975 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 18:05:28 +00:00
Andrew Ozz
cddc116653
Toolbar: sync jQuery and non-jQuery JS behaviour when there's a hash in the url, props tlovett1, fixes #22520
...
git-svn-id: http://core.svn.wordpress.org/trunk@22728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 20:45:03 +00:00
Andrew Ozz
981419d292
Make the admin menu and toolbar work well on mobile devices (take 2), props georgestephanis, fixes #20614 , fixes #22382
...
git-svn-id: http://core.svn.wordpress.org/trunk@22636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 20:14:17 +00:00
Ryan Boren
06ee370814
Pinking shears
...
git-svn-id: http://core.svn.wordpress.org/trunk@22634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 15:11:29 +00:00
Andrew Ozz
1dad05c508
Make the admin menu and toolbar work well on mobile devices, props georgestephanis, see #20614
...
git-svn-id: http://core.svn.wordpress.org/trunk@22262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-19 18:31:21 +00:00
Andrew Ozz
e8b10439bb
Accessibility shortcuts: new looks and fix for the WebKit focus bug, props lessbloat, fixes #21471
...
git-svn-id: http://core.svn.wordpress.org/trunk@22249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-16 21:26:59 +00:00
Andrew Nacin
2710bcade1
Switch to .min for compressed JS and CSS files.
...
* This moves our "development" versions from .dev.js to .js (same for css).
* The compressed version then moves from .js to .min.js (same for css).
By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.
fixes #21633 .
git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
bumpbot
1d56601e4c
Compress scripts/styles: 3.4-alpha-19847.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-06 23:31:17 +00:00
azaozz
5a1ddc6e4a
Include wp-admin-bar-secondary-* when closing non-current submenus, see #19394
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 01:07:43 +00:00
azaozz
6e11173bd4
When tabbing: on Enter open the current submenu and close other submenus if open, see #19394
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 00:43:18 +00:00
azaozz
535431029b
Fix the tabbing JS to work as described in the W3 ARIA draft: Tab to select, Enter to show submenu, Esc to close submenu, return to top menu and focus it. See #19394
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-30 01:21:38 +00:00
azaozz
580048525d
Admin bar: change the tabbing to behave as if the admin bar menus were click-to-open (Tab to select, Enter to open/close), fixes #19088
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-28 00:31:11 +00:00
koopersmith
da541dccac
Allow access to any admin bar menu level by tabbing. fixes #19088 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 21:29:33 +00:00
koopersmith
924ed5885c
Allow linkless items in the admin bar. Improve non-jQuery admin bar tabbing. fixes #19277 , #19149 , #19164 , #15519 . see #18197 , #19088 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-18 00:12:57 +00:00
koopersmith
9057e02e72
More admin bar markup improvements. Make primary and secondary submenu groups siblings (and prevent ul nesting issues). see #18197 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-14 11:05:37 +00:00
azaozz
b8f091fcbc
Fix a:focus styling and backwards tabbing, add tabindex arg for <a>, see #19088
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-07 20:38:38 +00:00
azaozz
94ef5dd13f
Support for "tabbing" through the admin bar and admin menu, fixes #19088
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-05 01:13:18 +00:00
azaozz
e4605a562e
Speed up the admin bar drop-downs a bit when using hoverIntent, props johnbillion, fixes #18299
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-30 22:31:15 +00:00
koopersmith
590868d915
Second pass, admin bar overhaul. see #18197 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-25 23:30:40 +00:00
azaozz
8ff2bbf4e5
Admin bar: fix the Shortlink menu when using jQuery, see #18299
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-01 23:33:56 +00:00
azaozz
670980920d
Admin bar: use jQuery if loaded to improve UX, fixes #18299
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-29 22:57:30 +00:00
westi
2a75d9c511
Add unique ids as well as of classes in the admin bar to make it easier for plugins to extend.
...
Ensure we escape the classname.
Fixes #16211 props koopersmith.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-13 01:34:15 +00:00
nacin
4d7ad91916
Check for a property of the object as well. props koopersmith, see #16194 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-12 06:11:18 +00:00
nacin
84369f43f9
Admin bar shortlink improvements. props koopersmith, fixes #16155 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-12 00:32:00 +00:00
ryan
770ca584d5
Expand shortlink menu when clicked. Fix displayed of shortlinks when rel shortlink is missing. Props koopersmith. fixes #16155
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-11 22:45:14 +00:00
nacin
86e44f1050
More admin bar styling improvements. Includes RTL fixes. Don't show redundant 'search' value. props ocean90, see #15308 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-11 08:54:41 +00:00
nacin
4e386b29ce
Admin bar script/style improvements. props ocean90, see #15308 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-10 18:47:21 +00:00
ryan
d4a7589502
Super admin menu hover fix. Props filosofo. fixes #15524
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-26 21:47:28 +00:00