9ed35cf902
Posts, Post Types: Change "Featured Image" post label to use sentence case: "Featured image".
...
This makes it more consistent with other UI elements in the block editor.
Props mcsf.
Fixes #49371 .
Built from https://develop.svn.wordpress.org/trunk@47194
git-svn-id: http://core.svn.wordpress.org/trunk@46994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 19:09:05 +00:00
6c1ee98e22
Tests: In `Tests_dbDelta::setUp()`, only force MyISAM database engine on MySQL versions older than 5.7.
...
Since MySQL 5.7, InnoDB engine supports `FULLTEXT` indexes, so forcing MyISAM is unnecessary.
Props xkon, joonasvanhatapio, SergeyBiryukov.
Fixes #49367 .
Built from https://develop.svn.wordpress.org/trunk@47193
git-svn-id: http://core.svn.wordpress.org/trunk@46993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 18:21:03 +00:00
02d01de6c5
Bundled Themes: Twenty Twenty Menu rendering problem Unicode (Bangla).
...
Fixes a bug where certain words break on to a second line in the primary and footer menus, in certain languages.
Props smallprogrammers, Shital Patel, mukesh27, audrasjb.
Fixes #48970 .
Built from https://develop.svn.wordpress.org/trunk@47192
git-svn-id: http://core.svn.wordpress.org/trunk@46992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 15:02:05 +00:00
0544629460
Posts, Post Types: Wrap text submitted via Quick Draft dashboard widget in the Paragraph block.
...
Props audrasjb, jeroenrotty.
Fixes #48120 .
Built from https://develop.svn.wordpress.org/trunk@47191
git-svn-id: http://core.svn.wordpress.org/trunk@46991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 08:10:05 +00:00
44288356e2
Menus: Introduce `wp_nav_menu_item_custom_fields` action that fires just before the move buttons of a nav menu item in the menu editor.
...
Props MikeSchinkel, birgire, sebastian.pisula, desrosj, helgatheviking.
Fixes #47056 . See #38904 , #18584 .
Built from https://develop.svn.wordpress.org/trunk@47190
git-svn-id: http://core.svn.wordpress.org/trunk@46990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 07:43:05 +00:00
84c43d1863
Docs: Correct type for `$item` and $args` parameters in `Walker_Nav_Menu_Checklist` and `Walker_Nav_Menu_Edit` to match the parent `Walker_Nav_Menu` class.
...
Follow-up to [38559], [45537].
See #24587 , #48303 .
Built from https://develop.svn.wordpress.org/trunk@47189
git-svn-id: http://core.svn.wordpress.org/trunk@46989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 07:25:05 +00:00
c32e05f308
Site Health: Improve focus style for accordion items on Site Health screens.
...
The new style is more consistent with other elements like `.wp-core-ui` buttons.
Props audrasjb, mensmaximus, afercia, melchoyce, Clorith.
Fixes #48578 .
Built from https://develop.svn.wordpress.org/trunk@47188
git-svn-id: http://core.svn.wordpress.org/trunk@46988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 06:43:04 +00:00
fa0563c877
Docs: Add a `@since` note for [47186].
...
See #48558 .
Built from https://develop.svn.wordpress.org/trunk@47187
git-svn-id: http://core.svn.wordpress.org/trunk@46987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 06:33:04 +00:00
4f422b028d
Taxonomy: In `register_taxonomy()`, return the registered taxonomy object on success, for consistency with `register_post_type()`.
...
Props krynes, SergeyBiryukov.
Fixes #48558 .
Built from https://develop.svn.wordpress.org/trunk@47186
git-svn-id: http://core.svn.wordpress.org/trunk@46986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 06:26:06 +00:00
b3f75c66f4
Coding Standards: Fix WPCS issue in [47184].
...
See #49344 .
Built from https://develop.svn.wordpress.org/trunk@47185
git-svn-id: http://core.svn.wordpress.org/trunk@46985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 05:03:05 +00:00
0561e81ecc
Tests: Allow `dbDelta()` tests to (mostly) run on MySQL 8.0.11+.
...
* MySQL 8.0.11 changed the `GeometryCollection` data type name to `GeomCollection`, with the latter being the preferred name.
* MySQL 8.0.17 removed support for the display width attribute for integer data types. Previously, default display width of 20 digits was used: `BIGINT(20)`.
The affected tests now check the MySQL server version and use the appropriate data types.
This leaves one unresolved failure on MySQL 8.0.17+ to be addressed in the future, caused by the same `BIGINT` display width discrepancy coming from `wp_get_db_schema()`.
Props kaggdesign, ottok, jeremyfelt, SergeyBiryukov.
Fixes #44384 , #49344 . See #49364 .
Built from https://develop.svn.wordpress.org/trunk@47184
git-svn-id: http://core.svn.wordpress.org/trunk@46984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 04:30:04 +00:00
ccdc1db0a9
Tests: Allow `wpdb::set_sql_mode()` tests to run on MySQL 8.0.11+.
...
MySQL 8.0.11 removed support for the `NO_AUTO_CREATE_USER` SQL mode, which was used in as an example of a mode compatible with WordPress.
`NO_AUTO_VALUE_ON_ZERO` is now used in the affected tests instead, which is supported on both MySQL 5.7.x and 8.0.x.
Props kaggdesign, jeremyfelt, afragen.
Fixes #44586 . See #49344 .
Built from https://develop.svn.wordpress.org/trunk@47183
git-svn-id: http://core.svn.wordpress.org/trunk@46983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 03:30:05 +00:00
e2440d55e7
Docs: Clarify that `is_page_template()` accepts a template filename, not the `Template Name` file header.
...
Props mkaz.
Fixes #49362 .
Built from https://develop.svn.wordpress.org/trunk@47182
git-svn-id: http://core.svn.wordpress.org/trunk@46982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 03:14:06 +00:00
a16f3f8f13
Posts, Post Types: Fail gracefully when checking whether a single post with an unregistered post status should be displayed in `WP_Query::get_posts()`.
...
If the post status is not registered, assume it's not public, but still allow access to users with edit permissions (same as for a protected post status, e.g. `draft`), so that they could recover orphaned content.
Add unit tests.
Follow-up to [47178].
Props roytanck, SergeyBiryukov.
Fixes #48653 .
Built from https://develop.svn.wordpress.org/trunk@47181
git-svn-id: http://core.svn.wordpress.org/trunk@46981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 01:33:05 +00:00
da6f24fba9
Posts, Post Types: Revert [47179] pending test failures investigation.
...
See #48653 .
Built from https://develop.svn.wordpress.org/trunk@47180
git-svn-id: http://core.svn.wordpress.org/trunk@46980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 23:02:09 +00:00
73a088f5b6
Posts, Post Types: Fail gracefully when checking whether the post should be displayed in `WP_Query::get_posts()` against unregistered post status.
...
If the post status is not registered, assume it's not public.
Follow-up to [47178].
Props roytanck.
See #48653 .
Built from https://develop.svn.wordpress.org/trunk@47179
git-svn-id: http://core.svn.wordpress.org/trunk@46979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 22:22:06 +00:00
46951e0b17
Posts, Post Types: Fail gracefully when checking mapped cap against unregistered post status.
...
With `map_meta_cap` enabled for a post type, the `read_post` capability for posts with a public status is supposed to be mapped to the post type's `read` capability.
When a post is left in the database after the post status is no longer present, and WP does a `read_post` check against it, a PHP notice was thrown, and the cap check always failed.
As a more graceful fallback, the cap is now mapped onto `edit_others_posts`, which allows highly privileged users to be able to access orphaned content.
A `_doing_it_wrong()` notice is also added, so that developers and site administrators are aware that the cap mapping is failing in the absence of the registered post status.
Follow-up to [34091], which introduced a similar approach to checking mapped caps against an unregistered post type.
Props roytanck, SergeyBiryukov.
Fixes #48653 .
Built from https://develop.svn.wordpress.org/trunk@47178
git-svn-id: http://core.svn.wordpress.org/trunk@46978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 22:15:08 +00:00
3882b3f567
Coding Standards: Fix WPCS issues in [47175].
...
See #49361 .
Built from https://develop.svn.wordpress.org/trunk@47177
git-svn-id: http://core.svn.wordpress.org/trunk@46977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 21:42:04 +00:00
d7e321c7c7
Block Editor: Include navigation block server logic.
...
Core did not include the navigation block PHP files.
This commit fixes the issue referred, and now the navigation block is executed on the frontend. The block still does not work as expected and throws an error during frontend execution. That problem is going to be fixed on the next WordPress package update.
This commit adds the file as it is on the npm package used.
Props gziolo.
Fixes #49348 .
Built from https://develop.svn.wordpress.org/trunk@47176
git-svn-id: http://core.svn.wordpress.org/trunk@46976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 20:16:04 +00:00
d3a9952838
Users: Pass the `$reassign` parameter to the `remove_user_from_blog` action.
...
Props Tivus.
Fixes #49361 .
Built from https://develop.svn.wordpress.org/trunk@47175
git-svn-id: http://core.svn.wordpress.org/trunk@46975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 19:43:03 +00:00
761644c636
Docs: Improve description for `add_user_to_blog()` and `remove_user_from_blog()` parameters.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47174
git-svn-id: http://core.svn.wordpress.org/trunk@46974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 19:40:06 +00:00
be057c4a1c
Users: In `remove_user_from_blog()`:
...
* Change default value of the `$blog_id` parameter to match the documented type.
* Change the type of the `$reassign` parameter for consistency with `$user_id` and `$blog_id`.
* Add documentation for the return value.
See #49361 .
Built from https://develop.svn.wordpress.org/trunk@47173
git-svn-id: http://core.svn.wordpress.org/trunk@46973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 19:36:04 +00:00
e956bbebe1
TinyMCE: Remove duplicate keys and strings from `langs/wp-langs-en.js`.
...
Props david.binda.
Fixes #49359 .
Built from https://develop.svn.wordpress.org/trunk@47172
git-svn-id: http://core.svn.wordpress.org/trunk@46972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 16:43:07 +00:00
143c6a1de8
Database: Add `ANSI` to the list of incompatible SQL modes.
...
Starting with MySQL 5.7.5, the `ANSI` mode implies `ONLY_FULL_GROUP_BY`, which is already listed in `wpdb` as incompatible per [27072].
When `ANSI` is enabled on MySQL 5.7.5+, `ONLY_FULL_GROUP_BY` remains enabled even after being "unset" by `wpdb::set_sql_mode()`.
To prevent this, the `ANSI` mode should also be listed as incompatible. It is not enabled on default MySQL installations.
Props jnylen0.
Fixes #48377 .
Built from https://develop.svn.wordpress.org/trunk@47171
git-svn-id: http://core.svn.wordpress.org/trunk@46971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 01:14:07 +00:00
c289bb59ac
Docs: Improve documentation for `WP_Dependencies`, `WP_Scripts`, and `WP_Styles` methods.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47170
git-svn-id: http://core.svn.wordpress.org/trunk@46970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-03 00:19:03 +00:00
982a6453c9
Canonical: When removing trailing punctuation from query string arguments, match the whole query var name.
...
Props daveslaughter.
Fixes #49347 .
Built from https://develop.svn.wordpress.org/trunk@47169
git-svn-id: http://core.svn.wordpress.org/trunk@46969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-03 00:14:07 +00:00
bfc5248126
Build: Copy block metadata files for dynamic blocks.
...
For dynamic blocks, there are several blocks whose metadata needs to be loaded in PHP. The attributes that are loaded via PHP are not exposed to the ReactNative components when Gutenberg loads the index.js files in the Mobile Apps. To support one master set of metadata that can be used to register in the PHP files and the Javascript files; with this patch, the block.json files are copied over with their corresponding PHP files.
Props chipsnyder and azaozz.
Fixes #49196 .
Built from https://develop.svn.wordpress.org/trunk@47168
git-svn-id: http://core.svn.wordpress.org/trunk@46968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 19:19:04 +00:00
8163215dc4
Plugins: Remove obsolete `plugin_slugs` transient from `WP_Plugins_List_Table::prepare_items()`.
...
The transient is only used in the `wp_dashboard_plugins_output()` function, which is deprecated and unused since [40607].
The function itself also sets the same transient, so it can be removed from `WP_Plugins_List_Table`.
Props aftabmuni.
Fixes #49340 .
Built from https://develop.svn.wordpress.org/trunk@47167
git-svn-id: http://core.svn.wordpress.org/trunk@46967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 15:50:04 +00:00
e79f7f71aa
REST API: Merge "not allowed to create new terms" permission error message with an existing string.
...
Follow-up to [39309], [39313].
See #38857 .
Built from https://develop.svn.wordpress.org/trunk@47166
git-svn-id: http://core.svn.wordpress.org/trunk@46966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 05:41:03 +00:00
f51b4579d5
Docs: Fix typo in a comment with `WP_DEBUG_DISPLAY` description.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47165
git-svn-id: http://core.svn.wordpress.org/trunk@46965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 05:34:05 +00:00
11fb46d4c6
Editor: Remove back-compat stub for Classic Editor's old distraction-free writing mode.
...
The original script was deprecated in [30338] and removed in [32677].
Props Presskopp, ketuchetan.
Fixes #39448 .
Built from https://develop.svn.wordpress.org/trunk@47164
git-svn-id: http://core.svn.wordpress.org/trunk@46964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 04:15:03 +00:00
9ce9450bf9
Tests: Adjust XML-RPC unit tests for [47160].
...
Follow-up to [47162].
See #40096 .
Built from https://develop.svn.wordpress.org/trunk@47163
git-svn-id: http://core.svn.wordpress.org/trunk@46963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 04:09:04 +00:00
11dc73b383
Tests: Adjust XML-RPC unit tests for [47160].
...
See #40096 .
Built from https://develop.svn.wordpress.org/trunk@47162
git-svn-id: http://core.svn.wordpress.org/trunk@46962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 03:32:04 +00:00
2f58dc5ce9
Docs: Add more specific description for `WP_Http::processResponse()` return value.
...
Props marekdedic, takeshifurusato.
Fixes #48351 .
Built from https://develop.svn.wordpress.org/trunk@47161
git-svn-id: http://core.svn.wordpress.org/trunk@46961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 03:27:05 +00:00
7e331ab235
Post Thumbnails: Make sure `get_post_thumbnail_id()` returns an integer, to match the documented return value.
...
This makes the function more consistent with `get_the_ID()` or `wp_get_post_parent_id()`, both returning an integer.
Props 0v3rth3d4wn.
Fixes #40096 .
Built from https://develop.svn.wordpress.org/trunk@47160
git-svn-id: http://core.svn.wordpress.org/trunk@46960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 03:08:04 +00:00
c94722d9bc
Docs: Improve inline comments in `wp-admin/options.php` per the documentation standards.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47159
git-svn-id: http://core.svn.wordpress.org/trunk@46959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 02:42:04 +00:00
a0f8b7003b
Administration: Include options page name in the "Options page not found" error message to provide better context for plugin developers.
...
Props tdlewis77, williampatton.
Fixes #42941 .
Built from https://develop.svn.wordpress.org/trunk@47158
git-svn-id: http://core.svn.wordpress.org/trunk@46958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 22:42:06 +00:00
8e37999368
Docs: Correct DocBlock formatting for `register_setting()`.
...
Document the full list of whitelisted option key names.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47157
git-svn-id: http://core.svn.wordpress.org/trunk@46957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 22:01:07 +00:00
deb1886078
Accessibility: Text Changes: Use sentence case for the word `Error` in various error messages, instead of all caps.
...
Using all caps should be avoided for better readability and because screen readers may pronounce all-caps words as abbreviations.
Props afercia, ryokuhi, sabernhardt, garrett-eclipse.
See #47656 , #43037 , #42945 .
Built from https://develop.svn.wordpress.org/trunk@47156
git-svn-id: http://core.svn.wordpress.org/trunk@46956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 21:38:04 +00:00
15a6accec4
Tests: Update the expected message in `test_with_draft_post()`.
...
Follow-up to [47154].
See #42945 .
Built from https://develop.svn.wordpress.org/trunk@47155
git-svn-id: http://core.svn.wordpress.org/trunk@46955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 21:13:05 +00:00
2fe7c95153
Text Changes: Capitalize error messages consistently.
...
Props Presskopp.
Fixes #42945 .
Built from https://develop.svn.wordpress.org/trunk@47154
git-svn-id: http://core.svn.wordpress.org/trunk@46954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 20:55:05 +00:00
12a6907123
Text Changes: Add missing periods to some error messages, for consistency.
...
Props Presskopp.
Fixes #42735 .
Built from https://develop.svn.wordpress.org/trunk@47153
git-svn-id: http://core.svn.wordpress.org/trunk@46953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 20:32:05 +00:00
21548ad0de
Text Changes: Add missing periods to comment status update notices, for consistency.
...
Props Presskopp.
See #42735 .
Built from https://develop.svn.wordpress.org/trunk@47152
git-svn-id: http://core.svn.wordpress.org/trunk@46952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 20:29:05 +00:00
f65bc1401a
Networks and Sites: Reduce `max-width` for user and site search inputs on Dashboard screen in Network Admin.
...
This ensures that the inputs don't push the buttons to the next line.
Props williampatton, bordoni.
Fixes #49043 .
Built from https://develop.svn.wordpress.org/trunk@47151
git-svn-id: http://core.svn.wordpress.org/trunk@46951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 17:38:03 +00:00
06979c6597
Docs: Document the addition of `$json_report_pathname` parameter to the `wp_privacy_personal_data_export_file_created` action.
...
Follow-up to [47146].
Props xkon.
Fixes #49029 .
Built from https://develop.svn.wordpress.org/trunk@47150
git-svn-id: http://core.svn.wordpress.org/trunk@46950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 04:17:05 +00:00
0aff1cf6bd
Site Health: Rename `WP_Site_Health::initialize()` introduced in [47063] to `::get_instance()`, for clarity and consistency with other core classes.
...
Use `WP_Site_Health::get_instance()` where it's needed, instead of creating multiple instances of the class.
Props afercia, xkon, Clorith, SergeyBiryukov.
See #47606 .
Built from https://develop.svn.wordpress.org/trunk@47149
git-svn-id: http://core.svn.wordpress.org/trunk@46949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 00:39:09 +00:00
3cd1514b91
Privacy: Clarify bulk action labels for personal data export and removal requests.
...
Props garrett-eclipse, xkon, shariqkhan2012, websupporter, desrosj, JoshuaWold.
Fixes #44674 .
Built from https://develop.svn.wordpress.org/trunk@47148
git-svn-id: http://core.svn.wordpress.org/trunk@46948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 03:43:05 +00:00
aef48b433b
Accessibility: Privacy: Improve the readability of the suggested text in Privacy Policy Guide.
...
Per WCAG 2.0 guidelines, big chunks of italic text should be avoided for better accessibility.
Props birgire, sabernhardt, xkon, garrett-eclipse, melchoyce, karmatosed, afercia, jepperask, SergeyBiryukov.
Fixes #44621 . See #47327 .
Built from https://develop.svn.wordpress.org/trunk@47147
git-svn-id: http://core.svn.wordpress.org/trunk@46947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 03:25:05 +00:00
39cef6947a
Privacy: Introduce a JSON file into the personal data export.
...
The produced ZIP archive will now include an `export.json` file along with the current `index.html`.
Props xkon.
Fixes #49029 . See #46424 .
Built from https://develop.svn.wordpress.org/trunk@47146
git-svn-id: http://core.svn.wordpress.org/trunk@46946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 01:36:05 +00:00
d0a0825809
Site Health: Add support for required WordPress and PHP versions to themes.
...
Follow-up to [45546] for plugins.
Props flixos90, afragen.
Fixes #44592 . See #40934 , #meta3718.
Built from https://develop.svn.wordpress.org/trunk@47145
git-svn-id: http://core.svn.wordpress.org/trunk@46945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 01:17:04 +00:00
Sergey Biryukov
ianbelanger
jorgefilipecosta
gziolo