John Blackbourn
a027edc277
Comments: The year is 2003. Permalinks are a new thing and everyone's using Blogger. It's a time when opening a modal window in JavaScript to view a section of a website is not a completely weird thing, although many users get annoyed by it. b2 has recently become WordPress, and with it comes a bunch of functionality that will become stale over the next decade, remnants of simpler times.
...
Twelve years later, after no fewer than three themes have intentionally implemented popup comments in their functionality, before being abandoned for at least the last six years, we've reached a time where we can put this era behind us. A time when we can remove comment popup functionality from WordPress.
If this breaks the internet, I'll eat my hat.
Fixes #28617
Built from https://develop.svn.wordpress.org/trunk@35848
git-svn-id: http://core.svn.wordpress.org/trunk@35812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 03:06:30 +00:00
Drew Jaynes
a4cd391d50
Docs: Move the hook doc for the `view_mode_post_types` filter to directly precede the `apply_filters()` line.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35844
git-svn-id: http://core.svn.wordpress.org/trunk@35808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-09 16:17:27 +00:00
Dominik Schilling
7551362d57
About Page: Add release video and update post embed.
...
Props camikaos, siobhan, rosso99, wonderboymusic.
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35839
git-svn-id: http://core.svn.wordpress.org/trunk@35803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 23:23:26 +00:00
Dominik Schilling
ba4a508daf
Install/Upgrade: Keep indexing bots away until a site is ready to be seen.
...
Built from https://develop.svn.wordpress.org/trunk@35837
git-svn-id: http://core.svn.wordpress.org/trunk@35801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 21:56:27 +00:00
Scott Taylor
f642373090
About Page: use ReverbNation instead of Cloudup to avoid Ad Blocker cruff with tracking pixels. Adjust the layout accordingly, and improve the layout at smaller breakpoints.
...
Props melchoyce.
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35834
git-svn-id: http://core.svn.wordpress.org/trunk@35798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 20:25:28 +00:00
Dominik Schilling
dc7ff95661
About Page: Remove three superfluous parentheses.
...
Props jaspermdegroot.
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35833
git-svn-id: http://core.svn.wordpress.org/trunk@35797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 18:15:26 +00:00
Dominik Schilling
d5475667b0
About Page: Use w.org CDN for images.
...
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35832
git-svn-id: http://core.svn.wordpress.org/trunk@35796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 17:57:26 +00:00
Michael Arestad
d23bd49fdd
Administration: Adds a height to number inputs.
...
Number inputs didn't match the height of other form elements. Now they have a height of 28px and 40px on mobile. Both align with the sizes of other elements.
Props valendesigns.
Fixes #28984 .
Built from https://develop.svn.wordpress.org/trunk@35831
git-svn-id: http://core.svn.wordpress.org/trunk@35795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 16:07:25 +00:00
Scott Taylor
1b60538074
About Page: use the source of the Make/Core Embed response instead of discovering it (or reading from the cache) every time.
...
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35826
git-svn-id: http://core.svn.wordpress.org/trunk@35790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 03:38:24 +00:00
Scott Taylor
932195771f
About Page: use `srcset` for images, also known as Recursive Dogfooding.
...
Props joemcgill.
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35825
git-svn-id: http://core.svn.wordpress.org/trunk@35789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 03:33:27 +00:00
Dominik Schilling
b3a00ca1e9
About Page: Add Cloudup embed and cache the embeds as site transients.
...
Props wonderboymusic.
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35823
git-svn-id: http://core.svn.wordpress.org/trunk@35787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 23:28:25 +00:00
Dominik Schilling
3c0c5e6ad5
List Tables: Revert [34728] and [35482].
...
Part of [34728] was already reverted in [35682], but the default values still made it impossible to set a default ordering for custom post types.
See #25493 .
See #34825 .
Built from https://develop.svn.wordpress.org/trunk@35818
git-svn-id: http://core.svn.wordpress.org/trunk@35782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 19:16:26 +00:00
Mel Choyce
b6a14367e4
About: Update image of the Twenty Sixteen red color scheme so it matches the updated scheme color.
...
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35816
git-svn-id: http://core.svn.wordpress.org/trunk@35780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 17:08:25 +00:00
Dominik Schilling
ef223adbdb
About: Sync tagline from about page with credits and freedoms.
...
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35812
git-svn-id: http://core.svn.wordpress.org/trunk@35776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 16:17:27 +00:00
Ella Iseulde Van Dorpe
657d3b50af
Make date format consistent across the admin
...
The 'date_format' and 'time_format' options shouldn't affect the backend.
See #30864
Built from https://develop.svn.wordpress.org/trunk@35811
git-svn-id: http://core.svn.wordpress.org/trunk@35775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 04:26:27 +00:00
Michael Adams
699c377856
Meta Boxes: Preserve radio inputs' state when sorting metaboxes.
...
When sorting a metabox, a clone of that metabox is created as a drag/drop "helper".
Previously, any checked radio input in the original metabox would become unchecked, when its clone "helper" was inserted into the DOM
(since only one radio within a set of radios of the same name can be checked).
Continued use of the clone helper is important so that the element being dragged isn't subject to the click and other event handlers attached to the real metabox,
so we can't just switch to dragging around the real metabox. See, for example, comment:10:ticket:16972.
Preserve the radios' state via some name attribute trickery.
Fixes #16972
Built from https://develop.svn.wordpress.org/trunk@35809
git-svn-id: http://core.svn.wordpress.org/trunk@35773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:23:49 +00:00
Helen Hou-Sandí
83795d99be
Plugins: Provide a link to searching the plugin directory when no search results are found.
...
Many new users do not know the difference between managing installed plugins and those found in the plugin directory. This helps with discoverability. The link is not provided in multisite installs because we assume that somebody with that kind of power in a network is experienced enough not to need it. This can always be reconsidered later.
props mordauk for the initial patch.
fixes #29865 .
Built from https://develop.svn.wordpress.org/trunk@35808
git-svn-id: http://core.svn.wordpress.org/trunk@35772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:23:25 +00:00
Andrea Fercia
bc7950519b
Notices: improve styling consistency of links within notices.
...
For accessibility, links inside lines or blocks of text should be always underlined.
Props walbo.
Fixes #34606 .
Built from https://develop.svn.wordpress.org/trunk@35801
git-svn-id: http://core.svn.wordpress.org/trunk@35765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:00:26 +00:00
Konstantin Kovshenin
84affbd3a9
Docs: Make "list table table tag" a bit more readable.
...
See: #34885 , r35796.
Built from https://develop.svn.wordpress.org/trunk@35797
git-svn-id: http://core.svn.wordpress.org/trunk@35761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:54:26 +00:00
Konstantin Kovshenin
919867b090
Docs: Remove some more dittography.
...
See #34885 , r35793.
Built from https://develop.svn.wordpress.org/trunk@35796
git-svn-id: http://core.svn.wordpress.org/trunk@35760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:50:25 +00:00
Jeremy Felt
714d5885d9
Te Docs: Fix te the misspelling.
...
Previously, [35793].
Fixes #34888 .
Built from https://develop.svn.wordpress.org/trunk@35794
git-svn-id: http://core.svn.wordpress.org/trunk@35758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:32:25 +00:00
Gary Pendergast
31f51e2cbb
The the Docs: Fix the the dittography
...
Sometimes, it's easy to to type the the same word twice, especially if if it's a simple word. We probably shouldn't do do do (do do do doo) it, though.
(I've excluded external libs from this change.)
Fixes #34885 .
Built from https://develop.svn.wordpress.org/trunk@35793
git-svn-id: http://core.svn.wordpress.org/trunk@35757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:23:25 +00:00
Michael Arestad
5eae357697
Administration: Improve color contrast of 'Add New' buttons.
...
This also includes improved focus styles for 'Add New'.
fixes #34876 , #34864 .
Built from https://develop.svn.wordpress.org/trunk@35791
git-svn-id: http://core.svn.wordpress.org/trunk@35755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:07:25 +00:00
Boone Gorges
714be37ea5
Show user_login in Dashboard user dropdowns.
...
User dropdowns in wp-admin have traditionally shown the users' display names.
However, this causes ambiguity when users share display names. To correct this,
we now show the unique user_login in parentheses after the display name.
The new `display_name_with_login` value for the `show` parameter of
`wp_dropdown_users()` enables this functionality. The default value of `show`
has not been changed, for backward compatibility, but all instances of
`wp_dropdown_users()` in core wp-admin have been switched.
This changeset also reduces some duplicated logic when assembling a user list
when `include_selected` is true.
Props krogsgard, boonebgorges.
Fixes #31251 .
Built from https://develop.svn.wordpress.org/trunk@35790
git-svn-id: http://core.svn.wordpress.org/trunk@35754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 20:57:26 +00:00
Rachel Baker
2cd2cb6e17
Multisite: Clarify purpose of hook from [35786] and match our naming convention.
...
`network_site_new_created_user_pending` -> `pre_network_site_new_created_user`
See #33631
Built from https://develop.svn.wordpress.org/trunk@35789
git-svn-id: http://core.svn.wordpress.org/trunk@35753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 20:32:24 +00:00
Rachel Baker
66ea0d6e1b
Multisite: Add hook before a new user is created during the creation of a new site.
...
New `network_site_new_created_user_pending` action fires before a new user will be created via the network site-new.php page.
Props mackensen
Fixes #33631
Built from https://develop.svn.wordpress.org/trunk@35786
git-svn-id: http://core.svn.wordpress.org/trunk@35750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 20:10:26 +00:00
Konstantin Obenland
2b7183c94b
Plugins: Allow long plugin names to wrap on small screens.
...
Props mapk, rickalee.
Fixes #32569 .
Built from https://develop.svn.wordpress.org/trunk@35785
git-svn-id: http://core.svn.wordpress.org/trunk@35749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 19:58:24 +00:00
Mark Jaquith
446de48b4f
About Page: Add the WordPress 4.4 tagline.
...
"Connected" because of REST API and cross-site embeds.
"Responsive" because of responsive images and under-the-hood tweaks.
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35780
git-svn-id: http://core.svn.wordpress.org/trunk@35744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 17:52:25 +00:00
Dion Hulse
70e9f5b543
Upgrader: FTP: Cleanup temporary files during FTP download failures.
...
Props ruud@joyo
Fixes #34772
Built from https://develop.svn.wordpress.org/trunk@35777
git-svn-id: http://core.svn.wordpress.org/trunk@35741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 17:07:25 +00:00
Boone Gorges
43d1ab4720
Use 'invalid_username' error code when tripping 'illegal_user_logins'.
...
This gives us better compatibility with existing errors thrown by
`sanitize_user()`, especially in Multisite, where user_login has more
restrictions on allowed characters.
Props markjaquith.
Fixes #27317 .
Built from https://develop.svn.wordpress.org/trunk@35772
git-svn-id: http://core.svn.wordpress.org/trunk@35736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 23:25:26 +00:00
Aaron Jorbin
c589ceb880
Make comment screen row actions focusable
...
In [34504], tabbing through row actions on comments that lacked links was broken. This restores the desired behavior and ensures that the row actions can be seen by no-js users.
Second Permanent Committer sign off was by WonderBoyMusic
See #15520
Fixes #34791
Props afercia, azaozz
Built from https://develop.svn.wordpress.org/trunk@35771
git-svn-id: http://core.svn.wordpress.org/trunk@35735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 23:13:24 +00:00
Drew Jaynes
ef1280f770
About page: Make strings translatable.
...
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35769
git-svn-id: http://core.svn.wordpress.org/trunk@35733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 18:09:25 +00:00
Drew Jaynes
7b20f48413
About page: Final string changes.
...
Props petya, ocean90, DrewAPicture
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35768
git-svn-id: http://core.svn.wordpress.org/trunk@35732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 17:55:28 +00:00
Drew Jaynes
65fb187505
About page: Add non-breaking spaces to "Reddit Comments" and "Speaker Deck" oEmbed provider names to prevent line wrapping between the words.
...
Props ocean90.
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35766
git-svn-id: http://core.svn.wordpress.org/trunk@35730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 16:27:25 +00:00
Drew Jaynes
3e1f22c196
About page: Fix some minor string errors and simplify URL-building for the plugin install link for capable users.
...
Props ocean90, DrewAPicture
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35765
git-svn-id: http://core.svn.wordpress.org/trunk@35729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 16:13:28 +00:00
Drew Jaynes
de586c98c4
First pass of the 4.4 about page. Adds strings (not yet translatable) and screen shots (not CDN).
...
Props wonderboymusic, markjaquith, helen, nacin, liljimmi, mordauk, melchoyce, ryelle, ocean90, DrewAPicture
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35763
git-svn-id: http://core.svn.wordpress.org/trunk@35727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 12:24:26 +00:00
Helen Hou-Sandí
2f287af8aa
Media: Avoid `rel="rel="` situations.
...
props lucymtc, swissspidy.
fixes #34826 . see #32074 .
Built from https://develop.svn.wordpress.org/trunk@35760
git-svn-id: http://core.svn.wordpress.org/trunk@35724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-03 17:17:26 +00:00
Scott Taylor
fc349932c0
Install: after [35508], the margin on the header for the Install screen is too big.
...
Props SergeyBiryukov.
Fixes #34819 .
Built from https://develop.svn.wordpress.org/trunk@35756
git-svn-id: http://core.svn.wordpress.org/trunk@35720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-01 21:02:25 +00:00
Scott Taylor
d569b9609e
Media: show Trash filter for Media list table when `MEDIA_TRASH` is true.
...
Props chacha102.
Fixes #34795 .
Built from https://develop.svn.wordpress.org/trunk@35752
git-svn-id: http://core.svn.wordpress.org/trunk@35716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-01 20:48:25 +00:00
Mark Jaquith
1a43f0b290
Do not pass FALSE as second parameter in variable class_exists() checks
...
Because these are generally plugin-provided, we want plugins to be
able to use autoloaders.
fixes #20523
Built from https://develop.svn.wordpress.org/trunk@35749
git-svn-id: http://core.svn.wordpress.org/trunk@35713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-30 04:15:27 +00:00
John Blackbourn
ec24d6e001
In a similar vein to [34133], escape the email address and IP address of comment authors to increase defence in depth.
...
Built from https://develop.svn.wordpress.org/trunk@35748
git-svn-id: http://core.svn.wordpress.org/trunk@35712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-29 02:43:24 +00:00
Dominik Schilling
9fb5c540bb
Users: Allow to create users without sending an email to the new user.
...
This adds a checkbox to `wp-admin/user-new.php` to prevent sending an email with the username and a password reset link to the new user. Restores the behavior of pre-4.3.
Fixes #33504 .
Props tharsheblows, SergeyBiryukov, DrewAPicture, ocean90.
Built from https://develop.svn.wordpress.org/trunk@35742
git-svn-id: http://core.svn.wordpress.org/trunk@35706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 22:38:29 +00:00
Helen Hou-Sandí
e24681632e
Avoid potential fatal errors after [35718].
...
While these classes are intended for admin use, there are developers out there who include `wp-admin/includes/template.php` to access them in other contexts. There is no intention to continue to support this indefinitely, but a breaking change like that would need to happen very early in a cycle and communicated loudly.
In the meantime, if you're reading this commit message and you do the above, please update your code to not do that. Thank you :)
fixes #33413 .
Built from https://develop.svn.wordpress.org/trunk@35740
git-svn-id: http://core.svn.wordpress.org/trunk@35704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 22:19:26 +00:00
Scott Taylor
79a2915a9b
Upgrade: New themes are not automatically installed on upgrade. This can still be explicitly asked for by defining `CORE_UPGRADE_SKIP_NEW_BUNDLED` as `false`.
...
In `populate_options()`, if the theme specified by `WP_DEFAULT_THEME` doesn't exist, fall back to the latest core default theme. If we can't find a core default theme, `WP_DEFAULT_THEME` is the best we can do.
Props nacin, jeremyfelt, dd32.
See #34306 .
Built from https://develop.svn.wordpress.org/trunk@35738
git-svn-id: http://core.svn.wordpress.org/trunk@35702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 21:45:25 +00:00
Dominik Schilling
7f3082491d
Passwords: Re-enable password fields before submitting the form.
...
Avoids an PHP undefined notice when creating new users.
Fixes #33699 .
Built from https://develop.svn.wordpress.org/trunk@35733
git-svn-id: http://core.svn.wordpress.org/trunk@35697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-24 21:17:27 +00:00
Sergey Biryukov
60c8e272f5
Docs: Improve DocBlock formatting for `add_menu_page()` and `add_submenu_page()` wrappers.
...
See #34360 .
Built from https://develop.svn.wordpress.org/trunk@35731
git-svn-id: http://core.svn.wordpress.org/trunk@35695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-23 17:56:26 +00:00
Helen Hou-Sandí
2cdeac7cf6
Pass the `$post` object as context to `postmeta_form_keys`.
...
see #33885 , #18979 .
Built from https://develop.svn.wordpress.org/trunk@35730
git-svn-id: http://core.svn.wordpress.org/trunk@35694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-23 17:15:29 +00:00
Gary Pendergast
d04396d0ad
Docs: Replace a reference to WP.org with WordPress.org.
...
Built from https://develop.svn.wordpress.org/trunk@35729
git-svn-id: http://core.svn.wordpress.org/trunk@35693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 22:38:26 +00:00
Andrew Ozz
91759029e9
TinyMCE: fix the regexp used to protect line breaks inside script and pre tags to match `<script>` that load external scripts.
...
Fixes #34760 .
Built from https://develop.svn.wordpress.org/trunk@35727
git-svn-id: http://core.svn.wordpress.org/trunk@35691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 19:13:28 +00:00
Sergey Biryukov
ae04eba0b6
Comments: After [35670], change the CSS class for the pending comments count back to `moderated`.
...
Fixes #34680 .
Built from https://develop.svn.wordpress.org/trunk@35726
git-svn-id: http://core.svn.wordpress.org/trunk@35690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 15:23:26 +00:00