WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
29,812 Commits 50 Branches 749 Tags 991 MiB
Commit Graph

500 Commits

Author SHA1 Message Date
Sergey Biryukov 20cfcbf86d Fix whitespace issues in [29781]. Remove a redundant comment. 
props miqrogroove.
see #29557.
Built from https://develop.svn.wordpress.org/trunk@29873


git-svn-id: http://core.svn.wordpress.org/trunk@29632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-11 02:33:18 +00:00
Scott Taylor 37a0c36d38 The joys of `wptexturize()`: 
* Revert parts of [28773] and [28727] and [29748].
* Do not crash PHP. Make the shortcode quantifier possessive to avoid backtracks.
* Reduce backtracking in long HTML comments by 100x.
* Do not ignore unclosed HTML comments.
* Do not break unregistered shortcodes, e.g. `[hello attr="value"]`.
* Do not break HTML in shortcode attributes, e.g. `[hello attr="<"]`.
* Do not match for shortcodes when there is extra whitespace, e.g. `[ hello ]`.
* Add unit tests to show #12690 was not fully resolved.
* Tested PHP 5.2.4, 5.2.13, 5.4.32, and 5.5.8.

Adds/modifies unit tests.

Props miqrogroove.
See #29557.

Built from https://develop.svn.wordpress.org/trunk@29781


git-svn-id: http://core.svn.wordpress.org/trunk@29553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-29 04:07:15 +00:00
Scott Taylor 0a848a6171 `wptexturize()` improvements: 
* Expand the `wptexturize()` RegEx to include the list of registered shortcodes.
* Avoid backtracking after `[` chars by not filtering params in registered shortcodes. This will cause escaped shortcodes and their params to become texturized if not registered.
* Registered shortcode params will never be texturized, even when escaped.
* Move all tests involving unregistered shortcodes to a new and improved unit.
* Update one test involving HTML within shortcode params.

Props miqrogroove.
See #29557.

Built from https://develop.svn.wordpress.org/trunk@29748


git-svn-id: http://core.svn.wordpress.org/trunk@29520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-17 15:14:17 +00:00
Sergey Biryukov 93903a2a81 Check for [\r\n\t ] instead of \s in sanitize_file_name() to avoid UTF-8 issues. 
props p_enrique.
fixes #26094.
Built from https://develop.svn.wordpress.org/trunk@29715


git-svn-id: http://core.svn.wordpress.org/trunk@29489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-07 08:33:16 +00:00
Andrew Nacin f7392ef917 Pinking shears. 
Built from https://develop.svn.wordpress.org/trunk@29707


git-svn-id: http://core.svn.wordpress.org/trunk@29481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-04 15:23:16 +00:00
Andrew Nacin 9db108dbe0 Allow language specified by the WPLANG constant (but not installed) to be chosen. 
fixes #29456.

Built from https://develop.svn.wordpress.org/trunk@29691


git-svn-id: http://core.svn.wordpress.org/trunk@29466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-03 08:03:16 +00:00
Drew Jaynes d33c807723 Fix some documentation typos in various core files. 
Props vlajos.
Fixes #29199.

Built from https://develop.svn.wordpress.org/trunk@29479


git-svn-id: http://core.svn.wordpress.org/trunk@29257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-13 03:56:17 +00:00
Scott Taylor 6b3251e931 wptexturize: After [28727], leverage RegeEx possessives (++) to improve performance and avoid libpcre segfaults. 
Props kovshenin.
Fixes #12690.

Built from https://develop.svn.wordpress.org/trunk@29431


git-svn-id: http://core.svn.wordpress.org/trunk@29209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 19:11:18 +00:00
Andrew Ozz 004da2f6ba Formatting: make the removal of white space around <option> greedy, see #28217. 
Built from https://develop.svn.wordpress.org/trunk@29316


git-svn-id: http://core.svn.wordpress.org/trunk@29097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-28 19:55:16 +00:00
Andrew Ozz ad0f539621 Formatting: no <p> or <br> around <option> tags in both flavours of wpautop, make "selects" easier to read in the Text editor. Fixes #28217. 
Built from https://develop.svn.wordpress.org/trunk@29315


git-svn-id: http://core.svn.wordpress.org/trunk@29096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-28 19:44:18 +00:00
Scott Taylor a14f5b97d5 In `sanitize_file_name()`, replace `%20` and `+` with dashes. Remove unnecessary code from `_wp_handle_upload()`. 
Adds unit tests.

Props ericmann.
Fixes #16330.

Built from https://develop.svn.wordpress.org/trunk@29290


git-svn-id: http://core.svn.wordpress.org/trunk@29072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-24 22:09:16 +00:00
Drew Jaynes c5a59037f1 Inline documentation cleanup for 4.0 audit. 
Various improvements:
* Adds `@see` reference for `wp_list_comments()` in 'wp_list_comments_args' filter docs, added in [28285]
* Various phpDoc tweaks for the 'run_wptexturize' filter docs, added in [28715]
* Sentence and wrapping changes for `is_https_url()`, added in [28894]
* Documents the `$args` parameter for `wp_dropdown_languages()`, added in [29007]
* Adds a period to the parameter description for `_update_posts_count_on_delete()`, added in [28835]
* Documents a global in `is_customize_preview()`, added in [28999]
* phpDoc tweaks, adds an access modifier for `wpdb::esc_like()`, added in [28711]

See #28885.

Built from https://develop.svn.wordpress.org/trunk@29163


git-svn-id: http://core.svn.wordpress.org/trunk@28947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 01:02:15 +00:00
Sergey Biryukov 8d358a16c3 Exclude a newline between delimeters from further checks in wptexturize() for better performance. 
props miqrogroove.
fixes #28724.
Built from https://develop.svn.wordpress.org/trunk@29008


git-svn-id: http://core.svn.wordpress.org/trunk@28796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-06 08:50:18 +00:00
Scott Taylor 5eb23f8e3c Optimize regexp usage in `wptexturize()` for a "3x Performance Boost." 
Props miqrogroove.
See #28724.

Built from https://develop.svn.wordpress.org/trunk@28986


git-svn-id: http://core.svn.wordpress.org/trunk@28775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-04 01:15:15 +00:00
John Blackbourn fd2d2ebb2e Correct typo in `sanitize_html_class()` docblock. 
Built from https://develop.svn.wordpress.org/trunk@28973


git-svn-id: http://core.svn.wordpress.org/trunk@28762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 16:58:16 +00:00
Sergey Biryukov c6c1f56d60 Fix texturization of quotes when enclosed by angle brackets. 
props miqrogroove.
fixes #28718.
Built from https://develop.svn.wordpress.org/trunk@28971


git-svn-id: http://core.svn.wordpress.org/trunk@28760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 16:22:14 +00:00
Scott Taylor a71d57da0a Remove obsolete comment in `wptexturize()`. 
http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2014-06-30&sort=asc#m879104

See [28831].

Built from https://develop.svn.wordpress.org/trunk@28929


git-svn-id: http://core.svn.wordpress.org/trunk@28727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 17:59:14 +00:00
Scott Taylor 9997f77d7f Use less greedy regex in `wptexturize()`. Adds unit tests. 
Props miqrogroove.
See #28564.

Built from https://develop.svn.wordpress.org/trunk@28852


git-svn-id: http://core.svn.wordpress.org/trunk@28656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 17:15:14 +00:00
Scott Taylor 8c39368644 Optimize the `wptexturize()` loop: 
* Take the ampersand pattern out of the loop for speed.
* Fix old bugs in the ampersand pattern.
* Refactor `_wptexturize_pushpop_element()` without PCRE for speed.
* Update unit tests.

Props miqrogroove.
Fixes #28623.

Built from https://develop.svn.wordpress.org/trunk@28831


git-svn-id: http://core.svn.wordpress.org/trunk@28635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-25 17:49:14 +00:00
Scott Taylor 856e5ef55e Remove `noscript` from `wpautop()`'s list of block elements. 
Props mdawaffe.
Fixes #27268.

Built from https://develop.svn.wordpress.org/trunk@28817


git-svn-id: http://core.svn.wordpress.org/trunk@28624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 00:54:17 +00:00
Sergey Biryukov 8b272f4379 Remove mbstring_binary_safe_strlen(). Use mbstring_binary_safe_encoding() and reset_mbstring_encoding() directly. 
fixes #28162.
Built from https://develop.svn.wordpress.org/trunk@28808


git-svn-id: http://core.svn.wordpress.org/trunk@28617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 22:21:15 +00:00
Sergey Biryukov 9ceb642b2a Introduce a binary-safe wrapper for strlen() and use it in seems_utf8(), utf8_uri_encode(), and wp_read_image_metadata(). 
Use binary-safe POMO_Reader::strlen() in MO::export_to_file_handle().

fixes #28162.
Built from https://develop.svn.wordpress.org/trunk@28806


git-svn-id: http://core.svn.wordpress.org/trunk@28615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-23 14:48:14 +00:00
Sergey Biryukov 64e67b0dbb Revert [28776] and use a correct variable instead. 
props miqrogroove.
fixes #28575.
Built from https://develop.svn.wordpress.org/trunk@28802


git-svn-id: http://core.svn.wordpress.org/trunk@28611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-22 22:13:16 +00:00
Sergey Biryukov ce0d1a026c Move preg_match() that should only run once out of the loop. 
props dllh.
fixes #28575.
Built from https://develop.svn.wordpress.org/trunk@28776


git-svn-id: http://core.svn.wordpress.org/trunk@28589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-19 00:01:16 +00:00
Scott Taylor b2f6e1f674 In `wptexturize()` + tests: 
* Allow well-formed HTML inside of shortcode attributes
* Restrict recursion. HTML is allowed but ignored.
* Do not allow exotic HTML comments in shortcode attributes.
* Continue to ignore the [ and ] chars if they appear in any HTML attribute.
* Update related regex patterns.
* Update unit tests.

Props miqrogroove.
Fixes #28564.

Built from https://develop.svn.wordpress.org/trunk@28773


git-svn-id: http://core.svn.wordpress.org/trunk@28586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 19:49:15 +00:00
Scott Taylor f1a15dd4fe Fix abbreviations mixed with quotes, example: `'99% of people'`. 
Add/alter unit tests.

Props miqrogroove.
Fixes #26850.

Built from https://develop.svn.wordpress.org/trunk@28765


git-svn-id: http://core.svn.wordpress.org/trunk@28578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 20:19:14 +00:00
Scott Taylor 2bac3b660f In `wptexturize()`, adjust for the treatment of abbreviated years at the end of quotations. 
Silence some unit tests that have never passed and may no longer be applicable.

Props miqrogroove.
Fixes #18549.

Built from https://develop.svn.wordpress.org/trunk@28764


git-svn-id: http://core.svn.wordpress.org/trunk@28577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 20:14:15 +00:00
Scott Taylor 3b3fb72ce3 Add unit tests to confirm that `---` is properly converted to `&#8212;` by `wptexturize()` where appropriate. 
Props miqrogroove.
Fixes #28483.

Built from https://develop.svn.wordpress.org/trunk@28763


git-svn-id: http://core.svn.wordpress.org/trunk@28576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 18:07:14 +00:00
Scott Taylor f7ac0eed90 Add Unit Tests for i18n and `wptexturize()`. Don't confuse closing single quotes and apostrophes. 
See #27426.

Built from https://develop.svn.wordpress.org/trunk@28762


git-svn-id: http://core.svn.wordpress.org/trunk@28575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 17:57:14 +00:00
Scott Taylor 337e5f7ae4 `wptexturize()` adjustments: 
* Only place an apostrophe before a number when it has exactly two digits.
* Never match '99' with the single prime pattern.
* Always assume '99' is an abbreviated year at the end of a quotation.
* Add unit tests.
* Resolves the unit test broken in [28721] for #8775.

See #26850.

Built from https://develop.svn.wordpress.org/trunk@28761


git-svn-id: http://core.svn.wordpress.org/trunk@28574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-17 17:41:15 +00:00
Scott Taylor 658170b179 In `wptexturize()`, ensure that texturization does not corrupt contents of HTML elements, HTML comments, and smartcode attributes. 
Adds a variety of unit tests/assertions.

Props miqrogroove.
Fixes #12690, #8912, #27602.

Built from https://develop.svn.wordpress.org/trunk@28727


git-svn-id: http://core.svn.wordpress.org/trunk@28541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 14:34:13 +00:00
Scott Taylor 4c067bd327 In `wptexturize()`, allow dashes before and after curly quotes. Example: This is what she said---"Wow that is cool." 
Adds unit tests.

Props adamsilverstein, miqrogroove.
Fixes #20342.

Built from https://develop.svn.wordpress.org/trunk@28726


git-svn-id: http://core.svn.wordpress.org/trunk@28540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 14:22:15 +00:00
Scott Taylor 3d3c166f11 `wptexturize()` should handle apostrophes before primes. 
Props nacin, miqrogroove.
Fixes #22823.

Built from https://develop.svn.wordpress.org/trunk@28725


git-svn-id: http://core.svn.wordpress.org/trunk@28539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 14:14:17 +00:00
Drew Jaynes 5755eaf372 Improve inline documentation for the `wp_spaces_regexp` filter. 
Fixes #27588.

Built from https://develop.svn.wordpress.org/trunk@28724


git-svn-id: http://core.svn.wordpress.org/trunk@28538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 06:46:15 +00:00
Drew Jaynes 0290f79eac Add inline documentation for the `run_wptexturize` filter. 
Props miqrogroove for the original patch.
Fixes #19550.

Built from https://develop.svn.wordpress.org/trunk@28723


git-svn-id: http://core.svn.wordpress.org/trunk@28537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 06:29:14 +00:00
Scott Taylor f8b03aa528 Fix curly quotes around numbers when applicable. 
Adds unit tests.

Props filosofo, mrmist, aliso, MikeHansenMe, miqrogroove.
Fixes #8775.

Built from https://develop.svn.wordpress.org/trunk@28721


git-svn-id: http://core.svn.wordpress.org/trunk@28535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 02:43:14 +00:00
Scott Taylor 4666c1abe2 In `wptexturize()`, don't convert C-style hexadecimals to mathematical `×`. 
Adds unit tests.

Props harrym, kurtpayne, miqrogroove.
Fixes #19308.

Built from https://develop.svn.wordpress.org/trunk@28719


git-svn-id: http://core.svn.wordpress.org/trunk@28533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 02:18:15 +00:00
Scott Taylor 12e7d6744b In `wptexturize()`, treat `&nbsp;` like whitespace when texturizing hyphens. 
Adds unit tests.

Props redsweater, miqrogroove.
Fixes #23185.

Built from https://develop.svn.wordpress.org/trunk@28718


git-svn-id: http://core.svn.wordpress.org/trunk@28532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 02:09:15 +00:00
Scott Taylor 6cb51c9ceb `smilies_init()`, treat `&nbsp;` like whitespace when converting smilies. 
Adds unit tests.

Props miqrogroove.
Fixes #27587.

Built from https://develop.svn.wordpress.org/trunk@28717


git-svn-id: http://core.svn.wordpress.org/trunk@28531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 02:03:14 +00:00
Scott Taylor 66d2144e9a Ensure that `shortcode_unautop()` treats `&nbsp;` like whitespace. 
`shortcode_unautop()` and `wptexturize()` now use `wp_spaces_regexp()` instead of raw regex.

Adds unit tests.

Props miqrogroove.
See #27588.

Built from https://develop.svn.wordpress.org/trunk@28716


git-svn-id: http://core.svn.wordpress.org/trunk@28530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 01:55:15 +00:00
Scott Taylor b4b0efe701 Add a `$run_texturize` static var to `wptexturize()` that is filterable via a new run-once filter: `'run_wptexturize'`. Allows user to disable texturization. 
Needs filter docs.

Props nacin, SergeyBiryukov.
See #19550.

Built from https://develop.svn.wordpress.org/trunk@28715


git-svn-id: http://core.svn.wordpress.org/trunk@28529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 01:46:14 +00:00
Scott Taylor 82bdc78500 `LIKE` escape sanity: 
* Deprecate `like_escape()`
* Add a method to `$wpdb`, `->esc_like()`, and add unit tests

`$wpdb::esc_like()` is not used yet. As such, many unit tests will throw `Unexpected deprecated notice for like_escape`. Subsequent commits will alleviate this.

Props miqrogroove.
See #10041.

Built from https://develop.svn.wordpress.org/trunk@28711


git-svn-id: http://core.svn.wordpress.org/trunk@28527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 00:30:15 +00:00
Scott Taylor 46f82b03e7 Add a function: `wp_spaces_regexp()`. It is not used yet. 
This function is required by a bunch of patches by miqrogroove. Needs filter docs.

Props miqrogroove.
See #27588.

Built from https://develop.svn.wordpress.org/trunk@28708


git-svn-id: http://core.svn.wordpress.org/trunk@28524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-09 19:30:14 +00:00
Sergey Biryukov c20cdfcc38 Add a filter to human_time_diff(). 
props slimndap.
fixes #27271.
Built from https://develop.svn.wordpress.org/trunk@28670


git-svn-id: http://core.svn.wordpress.org/trunk@28488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 00:39:14 +00:00
Sergey Biryukov 5c2d25aa77 Filter out empty and duplicate values in Comment Moderation and Comment Blacklist settings. 
props GaVrA.
fixes #23800.
Built from https://develop.svn.wordpress.org/trunk@28444


git-svn-id: http://core.svn.wordpress.org/trunk@28271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 11:10:14 +00:00
Andrew Nacin cfa2246cc7 Add braces to wptexturize() after [27839]. see #22692. 
Built from https://develop.svn.wordpress.org/trunk@27844


git-svn-id: http://core.svn.wordpress.org/trunk@27678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-29 09:00:15 +00:00
Andrew Nacin d04cd4147a Texturize: Massive performance improvements (~600% faster); better handling of nbsp, double, and weird spaces; 136 new unit tests. 
big props miqrogroove.
fixes #22692.

Built from https://develop.svn.wordpress.org/trunk@27839


git-svn-id: http://core.svn.wordpress.org/trunk@27673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-29 07:16:16 +00:00
Andrew Nacin 2133c89e8f Remove select and input from wpautop()'s HTML blocks list. 
props rachelbaker, DH-Shredder.
fixes #22230.

Built from https://develop.svn.wordpress.org/trunk@27761


git-svn-id: http://core.svn.wordpress.org/trunk@27598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-27 00:01:15 +00:00
Scott Taylor 0f55595472 In `sanitize_file_name()`, replace a UTF-8-encoded Unicode representation of a non-breaking space (`\u00a0` / `\xc2\xa`) with an old-fashioned space: ` `. 
Fixes #27281.


Built from https://develop.svn.wordpress.org/trunk@27617


git-svn-id: http://core.svn.wordpress.org/trunk@27460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-19 07:16:15 +00:00
John Blackbourn 184dc2bc33 `figcaption` should not be treated as a block-level element by `wpautop()`. See #25646. Props oso96_2000. 
Built from https://develop.svn.wordpress.org/trunk@27527


git-svn-id: http://core.svn.wordpress.org/trunk@27370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-13 21:51:16 +00:00
John Blackbourn 8d7f96c459 Deprecate `format_to_post()` and remove its filter. Fixes #25526. Props simonwheatley 
Built from https://develop.svn.wordpress.org/trunk@27424


git-svn-id: http://core.svn.wordpress.org/trunk@27271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-05 22:48:15 +00:00
Andrew Nacin 580b05ae5d Strip backslashes, not just forward slashes, from untrailingslashit(). 
trailingslashit() will now remove any forward or backslashes from the end of a string before appending a forward slash.

props knutsp, willmot.
fixes #22267.

Built from https://develop.svn.wordpress.org/trunk@27344


git-svn-id: http://core.svn.wordpress.org/trunk@27196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-01 21:45:15 +00:00
Andrew Nacin ad8c3f0f02 Use placeholders in strings in wp_sprintf_l() to ensure spaces are not lost in translation. 
props andy.
fixes #26651.

Built from https://develop.svn.wordpress.org/trunk@27284


git-svn-id: http://core.svn.wordpress.org/trunk@27140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-26 16:50:15 +00:00
Scott Taylor 228fc639b9 When a video shortcode has content in its body, append it as inner HTML in the resulting `<video>`. 
Reverts [27096].
Fixes #26628.
See #27016.


Built from https://develop.svn.wordpress.org/trunk@27097


git-svn-id: http://core.svn.wordpress.org/trunk@26968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-05 01:43:12 +00:00
Andrew Ozz 98cb4984c0 Consolidate handling of <object>, <audio> and <video> in wpautop() and add unit tests for them. Part props wonderboymusic, see #26864 
Built from https://develop.svn.wordpress.org/trunk@27094


git-svn-id: http://core.svn.wordpress.org/trunk@26966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-05 00:46:12 +00:00
Andrew Nacin c4e119d530 Basic unit tests and additional documentation for wp_strip_all_tags(). 
props joehoyle.
fixes #25507.

Built from https://develop.svn.wordpress.org/trunk@27042


git-svn-id: http://core.svn.wordpress.org/trunk@26916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-27 03:16:11 +00:00
Andrew Nacin 0ee1cb3046 make_clickable: When cleaning up accidental links within links, account for the tag being split by newlines. 
props dd32.
fixes #19028.

Built from https://develop.svn.wordpress.org/trunk@26974


git-svn-id: http://core.svn.wordpress.org/trunk@26853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-17 09:32:10 +00:00
Andrew Nacin d9b0e70d4a Unit tests for get_url_in_content(). Return false when no content is passed, to match the return value of no links being found. 
props mdbitz.
#26171.

Built from https://develop.svn.wordpress.org/trunk@26972


git-svn-id: http://core.svn.wordpress.org/trunk@26851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-17 07:47:10 +00:00
Ryan Boren 07c16fd23c The Pinking Shears stir from their slumber, awakened by what may seem, to those 
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!

One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.

Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.

Built from https://develop.svn.wordpress.org/trunk@26851


git-svn-id: http://core.svn.wordpress.org/trunk@26738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-11 19:49:11 +00:00
Drew Jaynes 087289b6a4 Hook docs pinking shears. 
Built from https://develop.svn.wordpress.org/trunk@26631


git-svn-id: http://core.svn.wordpress.org/trunk@26521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-04 20:03:09 +00:00
Andrew Nacin 64ff23f8f8 Remove certain accents in the Danish language. 
props tlamedia.
fixes #23907.

Built from https://develop.svn.wordpress.org/trunk@26585


git-svn-id: http://core.svn.wordpress.org/trunk@26475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-03 20:39:09 +00:00
Andrew Nacin 98215089b9 Revert [26050], stop trying to balance open HTML tags across nextpage and more tags for now. 
see #6297.

Built from https://develop.svn.wordpress.org/trunk@26557


git-svn-id: http://core.svn.wordpress.org/trunk@26448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-03 17:08:10 +00:00
Sergey Biryukov 9fa0ec4e94 Escape smiley URL in translate_smiley(). 
props simonwheatley.
fixes #25529.
Built from https://develop.svn.wordpress.org/trunk@26487


git-svn-id: http://core.svn.wordpress.org/trunk@26384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-30 22:39:10 +00:00
Sergey Biryukov b6e094c748 Correct @since values. see #25518. 
Built from https://develop.svn.wordpress.org/trunk@26486


git-svn-id: http://core.svn.wordpress.org/trunk@26383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-30 19:05:10 +00:00
Drew Jaynes 2df1989c57 Inline documentation for hooks in wp-includes/formatting.php. 
Props simonwheatley for the initial patch. Props DrewAPicture, kpdesign.
Fixes #25518.

Built from https://develop.svn.wordpress.org/trunk@26485


git-svn-id: http://core.svn.wordpress.org/trunk@26382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-30 18:36:10 +00:00
Scott Taylor dc01b08a5e Add unit tests for `links_add_target()`. Alter the patterns in `links_add_target()` and `_links_add_target()` slightly based on learnings after running tests. 
Props mdbitz.
Fixes #26164.


Built from https://develop.svn.wordpress.org/trunk@26328


git-svn-id: http://core.svn.wordpress.org/trunk@26230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-22 16:25:10 +00:00
Scott Taylor c2bc0e6836 Don't place smilies inside of pre or code tags. Don't skip smilie after a smilie with an 8 in it. Fix regular expression used for smiley translations to work when there is only one registered emoticon. 
Props solarissmoke, soulseekah, mdbitz, yonasy. ht to mdbitz for the Unit Tests and a comprehensive patch.
Fixes #16448, #20124, #25303.


Built from https://develop.svn.wordpress.org/trunk@26191


git-svn-id: http://core.svn.wordpress.org/trunk@26099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-15 02:46:10 +00:00
Sergey Biryukov 3ce6b77afd Use a simple replacement for 'wp_title' filter in capital_P_dangit(), like we do for 'the_title'. 
props nacin.
fixes #25796.
Built from https://develop.svn.wordpress.org/trunk@26122


git-svn-id: http://core.svn.wordpress.org/trunk@26034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-13 03:56:09 +00:00
Scott Taylor 2e0af4405e Make HTML tag searches for `<code>` and `<pre>` case-insensitive in `make_clickable()`. 
Props bpetty.
Fixes #23756.


Built from https://develop.svn.wordpress.org/trunk@26094


git-svn-id: http://core.svn.wordpress.org/trunk@26010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-11 21:54:10 +00:00
Scott Taylor 275f39216a Don't convert URLs inside `<pre>` and `<code>` tags when parsing string using `make_clickable()`. 
Adds Unit Tests.

Props johnjamesjacoby, helen, nacin, adamsilverstein, sirbrillig. 
Fixes #23756.


Built from https://develop.svn.wordpress.org/trunk@26052


git-svn-id: http://core.svn.wordpress.org/trunk@25977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-08 22:38:10 +00:00
Scott Taylor 734fe0f6ad Split the content to balance open tags when `<!--nextpage-->` and `<!--more.*?-->` are used. Needs filter inline docs. The 4 unit tests that were previously failing for ticket 6297 now pass. 
See #6297. 
Props devesine.


Built from https://develop.svn.wordpress.org/trunk@26050


git-svn-id: http://core.svn.wordpress.org/trunk@25975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-08 22:22:11 +00:00
Andrew Nacin d93d8b850d Reverse the order of roles in wp_dropdown_roles(). Reset to 'subscriber' when the default role is removed and when a save is invalid. 
props garyc40, wonderboymusic.
fixes #14578.

Built from https://develop.svn.wordpress.org/trunk@25695


git-svn-id: http://core.svn.wordpress.org/trunk@25610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-06 10:56:09 +00:00
Sergey Biryukov bcb43b77d0 Correct phpdoc for translate_smiley(). props toscho. fixes #25440. 
Built from https://develop.svn.wordpress.org/trunk@25646


git-svn-id: http://core.svn.wordpress.org/trunk@25563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-29 10:08:10 +00:00
Dion Hulse 8a50bf2f14 Use a better variable name in antispambot() introduced with [25055]. Props duck_ Fixes #16754 
Built from https://develop.svn.wordpress.org/trunk@25146


git-svn-id: http://core.svn.wordpress.org/trunk@25125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-28 01:47:09 +00:00
Dion Hulse 7317940591 Correct a typo in a docblock in [25055]. Props buffler. See #16754 
Built from https://develop.svn.wordpress.org/trunk@25058


git-svn-id: http://core.svn.wordpress.org/trunk@25044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-20 07:10:09 +00:00
Dion Hulse 47c82e1c83 Remove some PHP4-ness from the antispambot() function, and update it to match some modern coding standards. Props hakre and crrobi01 for initial patches. Fixes #16754 
Built from https://develop.svn.wordpress.org/trunk@25055


git-svn-id: http://core.svn.wordpress.org/trunk@25041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-20 06:08:09 +00:00
Dion Hulse 2da772855e Simplify _deep_replace() by removing it's obscure looping and replacement checking logic, and instead, using the PHP5 $count parameter of str_replace(). Props hakre. Fixes #16903 
Built from https://develop.svn.wordpress.org/trunk@25054


git-svn-id: http://core.svn.wordpress.org/trunk@25040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-20 05:57:10 +00:00
Andrew Nacin 8ee6d136de Adjust esc_sql()'s @param documentation to reflect that it allows for arrays. props scribu, fixes #22573. 
git-svn-id: http://core.svn.wordpress.org/trunk@24986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-05 22:11:30 +00:00
Andrew Nacin 3b4f3dea29 Deprecate wpdb::escape() in favor of wpdb::prepare() and esc_sql(). fixes #24774. 
git-svn-id: http://core.svn.wordpress.org/trunk@24718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-16 17:44:42 +00:00
Andrew Nacin 7690d7fbeb Move get_url_in_content() out of post-formats.php. see #24202. 
git-svn-id: http://core.svn.wordpress.org/trunk@24683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-12 19:38:37 +00:00
Andrew Nacin bfb3b89672 Skip protocol checking in esc_url() when we are dealing with a relative URL. Prevents munging of colons in paths and query strings, when present in a protocol-relative URL. 
props SergeyBiryukov.
fixes #21974.



git-svn-id: http://core.svn.wordpress.org/trunk@24642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-10 13:45:22 +00:00
Andrew Nacin 720f37c374 Expand human_time_diff() from minutes/hours/days to also include weeks/months/years. Fix off-by-one issue. 
props SergeyBiryukov, westi.
fixes #9272.



git-svn-id: http://core.svn.wordpress.org/trunk@24582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-08 13:00:34 +00:00
Sergey Biryukov 58c364947f PHPDoc fixes and additions. fixes #24616. 
git-svn-id: http://core.svn.wordpress.org/trunk@24490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-21 12:45:11 +00:00
Andrew Nacin d80469f8a5 Fix storage of illegal_names. Add an upgrade routine to fix bad values. 
props SergeyBiryukov.
see #23418.
for trunk.



git-svn-id: http://core.svn.wordpress.org/trunk@24448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-19 22:06:42 +00:00
Mark Jaquith 74c6071b9d Improve regular expressions by using a backreference to match right quote of quote pair when matching attributes. 
props kovshenin. see #24225.

git-svn-id: http://core.svn.wordpress.org/trunk@24241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-10 22:54:33 +00:00
Sergey Biryukov 74638ccb5a Fix typos in phpdoc. props TheLastCicada. fixes #24302. 
git-svn-id: http://core.svn.wordpress.org/trunk@24229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-10 01:39:30 +00:00
Sergey Biryukov 415a5c60da * Pass ellipsis as a parameter to wp_html_excerpt() instead of appending it manually. 
* Consolidate the logic to avoid appending ellipsis if the entire string is shown.
* Show ellipsis after truncated filenames and post titles.

props solarissmoke, bpetty, SergeyBiryukov. fixes #11446.

git-svn-id: http://core.svn.wordpress.org/trunk@24214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-09 00:22:02 +00:00
Sergey Biryukov 57c10eadbb Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714. 
git-svn-id: http://core.svn.wordpress.org/trunk@24207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-08 21:27:31 +00:00
Andrew Nacin 3139a0451e Variables passed by reference do not need to be set first. 
props kovshenin.
see #24222.



git-svn-id: http://core.svn.wordpress.org/trunk@24129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-29 14:48:31 +00:00
Andrew Nacin f1aeebf00b Improve the performance of backslashit() by avoiding regular expressions. backslashit() is used heavily in date_i18n(). 
props jbutkus.
fixes #22286.



git-svn-id: http://core.svn.wordpress.org/trunk@24051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-22 20:01:57 +00:00
Sergey Biryukov d454a9c86b Remove duplicate array key. props tivnet. fixes #24021. 
git-svn-id: http://core.svn.wordpress.org/trunk@23948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-10 15:55:53 +00:00
Peter Westwood 072cccd0e4 Formatting: Pass the blog charset to htmlspecialchars so that we don't eat non-UTF8 strings in PHP 5.4 
Fixes #23688


git-svn-id: http://core.svn.wordpress.org/trunk@23685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-13 15:24:38 +00:00
Andrew Nacin 2ca0cdcdfe Properly handle timezones in get_date_from_gmt() rather than relying on the implicit gmt_offset. This offset is only good for the current time, rather than the passed time, which causes problems when converting a DST date when DST is not in effect, or vice versa. 
Update get_gmt_from_date() to make these functions match in formatting, as they are complementary and just reverse a few operations.

props scholesmafia
Tests: [1233/tests]

fixes #20328.



git-svn-id: http://core.svn.wordpress.org/trunk@23618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-05 16:14:14 +00:00
Ryan Boren 15a06a35ab Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes(). 
see #WP21767


git-svn-id: http://core.svn.wordpress.org/trunk@23591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-03 16:30:38 +00:00
Ryan Boren 53f9496a2f Introduce wp_slash() and wp_unslash(). This will be used to cleanup the myriad calls to addslashes*, add_magic_quotes, stripslashes*. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:34:48 +00:00
Ryan Boren 43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:28:40 +00:00
Andrew Nacin b88b1c1f53 Move revisions/autosave and post format functions from wp-includes/post.php into revision.php and post-formats.php. 
git-svn-id: http://core.svn.wordpress.org/trunk@23466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-21 21:24:34 +00:00
Helen Hou-Sandí 6d49a9cc8c Output fallbacks / theme compat for post format metadata. 
* Currently handles link, quote, image, gallery, audio, and video formats.
* `add_theme_support()` for a given post format is now an indicator that the theme handles format-specific metadata.
* If no support for a given format is defined, fallback output will be generated and hooked onto the_content if a post has metadata for that format.
* Fallbacks attempt to be smart about not duplicating data already appearing in the post content itself. Gallery is particularly liberal, looking for any instance of the gallery shortcode in the content, not just an exact match to the gallery shortcode defined in the format-specific meta.
* Compat output defaults to being wrapped in a `div` with a class of `post-format-content`.

Theme authors: please test and evaluate, keeping in mind that the goal is to support user expectations of not losing format-specific data they've entered in the admin when viewing the front-end of their site.

props wonderboymusic, beaulebens, helen. see #23347.


git-svn-id: http://core.svn.wordpress.org/trunk@23450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-18 19:22:58 +00:00
Sergey Biryukov 8fb830eeda Fix typos in phpdoc. props markmcwilliams. fixes #23481. 
git-svn-id: http://core.svn.wordpress.org/trunk@23434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-15 18:59:56 +00:00
Ryan Boren cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00