Sergey Biryukov
f32831bf6d
Taxonomy: Correct the initial value for `WP_Taxonomy::$labels` to match `get_taxonomy_labels()` return type.
...
Improve documentation for consistency with `WP_Post_Type::$labels`.
Props alpipego.
Fixes #48681 .
Built from https://develop.svn.wordpress.org/trunk@46743
git-svn-id: http://core.svn.wordpress.org/trunk@46543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 07:58:59 +00:00
Sergey Biryukov
5aa3a51264
Docs: Update broken source code link in `WP_Filesystem_SSH2` class.
...
Props mryoga, finchps.
Fixes #48467 .
Built from https://develop.svn.wordpress.org/trunk@46742
git-svn-id: http://core.svn.wordpress.org/trunk@46542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 16:16:02 +00:00
Sergey Biryukov
96e163473e
Docs: Update broken source code link in `imgAreaSelect` jQuery plugin.
...
Props mryoga, finchps.
See #48467 .
Built from https://develop.svn.wordpress.org/trunk@46741
git-svn-id: http://core.svn.wordpress.org/trunk@46541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 16:14:03 +00:00
Sergey Biryukov
0d8e11db06
Docs: Replace Codex URLs with corresponding HelpHub articles in `wp-config-sample.php`.
...
Props sebastienserre.
Fixes #48680 .
Built from https://develop.svn.wordpress.org/trunk@46740
git-svn-id: http://core.svn.wordpress.org/trunk@46540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 11:11:04 +00:00
Sergey Biryukov
418db0297e
Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages.
...
Props garrett-eclipse.
Fixes #48676 .
Built from https://develop.svn.wordpress.org/trunk@46739
git-svn-id: http://core.svn.wordpress.org/trunk@46539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 07:43:01 +00:00
Sergey Biryukov
927aa4b44c
Docs: Fix typo in `wp_credits_section_title()` description.
...
Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards.
Props hareesh-pillai.
Fixes #48674 .
Built from https://develop.svn.wordpress.org/trunk@46738
git-svn-id: http://core.svn.wordpress.org/trunk@46538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-16 21:04:01 +00:00
Sergey Biryukov
0f90f6a739
Editor: Pass `$editor_id` parameter to `tiny_mce_plugins`, `mce_external_plugins`, and `mce_external_languages` filters, for consistency with `teeny_mce_plugins`.
...
Document the `classic-block` value passed to various editor filters in `wp_tinymce_inline_scripts()`.
Add missing `@since` entries for the existing `$editor_id` parameter in various filters.
Props djp424, johnbillion, SergeyBiryukov.
Fixes #48441 .
Built from https://develop.svn.wordpress.org/trunk@46737
git-svn-id: http://core.svn.wordpress.org/trunk@46537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-16 16:36:02 +00:00
Sergey Biryukov
9bf98c307b
Security: Add WordPress 5.3.x to the "Supported Versions" section of GitHub Security Policy.
...
Props imath.
Fixes #48667 . See #48521 .
Built from https://develop.svn.wordpress.org/trunk@46736
git-svn-id: http://core.svn.wordpress.org/trunk@46536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-16 11:19:03 +00:00
whyisjake
a761a23464
Security: Add a GitHub Security Policy.
...
As part of more responsible security disclosure, we are adding a security policy to GitHub.
Fixes #48521 .
Props whyisjake, ayeshrajans.
Built from https://develop.svn.wordpress.org/trunk@46735
git-svn-id: http://core.svn.wordpress.org/trunk@46535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-15 23:46:01 +00:00
whyisjake
ba7170de9c
Toolbar: Properly escape the onclick attribute.
...
The onclick attribute was being escaped twice, once with `esc_js` and again with `esc_attr`.
Fixes #48117 .
Props tmatsuur, dinhtungdu.
Built from https://develop.svn.wordpress.org/trunk@46734
git-svn-id: http://core.svn.wordpress.org/trunk@46534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-15 23:24:02 +00:00
Sergey Biryukov
3a735ec87a
Docs: Improve a comment about `$doing_wp_cron` global in `wp-cron.php`.
...
Props chinteshprajapati, subrataemfluence, nielslange.
Fixes #46104 .
Built from https://develop.svn.wordpress.org/trunk@46733
git-svn-id: http://core.svn.wordpress.org/trunk@46533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-15 08:59:01 +00:00
Sergey Biryukov
4ec53dc54c
Docs: Remove incorrect `@return` tags.
...
Props diddledan.
Fixes #48613 , #48614 .
Built from https://develop.svn.wordpress.org/trunk@46732
git-svn-id: http://core.svn.wordpress.org/trunk@46532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-14 09:57:03 +00:00
Sergey Biryukov
04ba6a1d8f
Docs: Correct parameter type for `$item` in `WP_REST_Terms_Controller::prepare_item_for_response()`.
...
Props diddledan, TimothyBlynJacobs.
Fixes #48616 .
Built from https://develop.svn.wordpress.org/trunk@46731
git-svn-id: http://core.svn.wordpress.org/trunk@46531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-14 08:55:02 +00:00
Sergey Biryukov
d4cec569fe
Docs: Fix typo in `@return` value for `PO::trim_quotes()`.
...
Props diddledan.
Fixes #48572 .
Built from https://develop.svn.wordpress.org/trunk@46730
git-svn-id: http://core.svn.wordpress.org/trunk@46530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-13 13:45:02 +00:00
John Blackbourn
3def77672d
Docs: Correct some invalid hook docblocks.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46729
git-svn-id: http://core.svn.wordpress.org/trunk@46529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 22:42:02 +00:00
Sergey Biryukov
6ceb0279af
Help/About: Move images to the CDN.
...
Props ryelle.
Fixes #47708 .
Built from https://develop.svn.wordpress.org/trunk@46724
git-svn-id: http://core.svn.wordpress.org/trunk@46524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 18:30:03 +00:00
Sergey Biryukov
3696fadc2d
Bundled Themes: Update Twenty Twenty.
...
This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see fa8c3fc...a9e73ab
.
Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110 , #48386 , #48450 , #48505 , #48557 .
Fixes #48571 .
Built from https://develop.svn.wordpress.org/trunk@46722
git-svn-id: http://core.svn.wordpress.org/trunk@46522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 18:24:03 +00:00
Sergey Biryukov
7ce88a02cd
Bundled Themes: Update copyright year in `readme.txt` for Twenty Twelve and Twenty Twenty.
...
Follow-up to [46719].
See #48566 .
Built from https://develop.svn.wordpress.org/trunk@46720
git-svn-id: http://core.svn.wordpress.org/trunk@46520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 17:51:02 +00:00
Sergey Biryukov
7de0113520
Bundled Themes: Update copyright year in `readme.txt`.
...
Add a unit test to ensure the year stays up to date.
Props dkarfa, SergeyBiryukov.
Fixes #48566 .
Built from https://develop.svn.wordpress.org/trunk@46719
git-svn-id: http://core.svn.wordpress.org/trunk@46519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 17:36:02 +00:00
Sergey Biryukov
46c8d07046
Bundled Themes: Update Twenty Twenty.
...
* Add `.has-background` excluding condition to wide and full group-blocks.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see 162edc0...fa8c3fc
.
Props allancole, karmatosed.
See #48110 , #48386 , #48450 , #48505 .
Fixes #48557 .
Built from https://develop.svn.wordpress.org/trunk@46715
git-svn-id: http://core.svn.wordpress.org/trunk@46515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 02:06:01 +00:00
Sergey Biryukov
01685e57be
Bundled Themes: Update Twenty Twenty.
...
* Add a11y-friendly default text-colors when selecting a background-color.
* Remove margins for the group block when a background-color is set.
* Excluding pullquote block from width resize rules.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see ab5fa23...162edc0
.
Props allancole, karmatosed.
See #48110 , #48386 , #48450 , #48505 .
Fixes #48557 .
Built from https://develop.svn.wordpress.org/trunk@46713
git-svn-id: http://core.svn.wordpress.org/trunk@46513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 01:44:02 +00:00
Sergey Biryukov
128147ccd5
Twenty Twenty: Make CSS adjustments to account for the latest editor changes and ensure that group blocks work in expected ways.
...
Props williampatton, allancole, karmatosed, pierlo, joen, ianbelanger.
Fixes #48557 .
Built from https://develop.svn.wordpress.org/trunk@46711
git-svn-id: http://core.svn.wordpress.org/trunk@46511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 20:56:02 +00:00
Sergey Biryukov
2265c36568
Help/About: Update the 5.3 About page.
...
* Remove extra padding on the Credits tab.
Previously [46556], [46572], [46616], [46705].
Props ryelle.
See #47708 .
Built from https://develop.svn.wordpress.org/trunk@46709
git-svn-id: http://core.svn.wordpress.org/trunk@46509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 20:45:04 +00:00
whyisjake
5f5ab66a6b
Tests: Fix a typo in an inline comment.
...
Fix a regression from [46568].
Props david.binda.
See #48312 .
Built from https://develop.svn.wordpress.org/trunk@46707
git-svn-id: http://core.svn.wordpress.org/trunk@46507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 18:50:04 +00:00
Sergey Biryukov
ba249d8951
Help/About: Update the 5.3 About page.
...
* Remove the SVG from the upper right corner.
* Make sure admin notices that should be hidden stay hidden.
* Address a11y issues with contrast.
* Fix an issue with the active nav tab hover.
* Prevent names on the credits from breaking out of the box.
* Update two strings with a more accurate information.
Previously [46556], [46572], [46616].
Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov.
See #47708 .
Built from https://develop.svn.wordpress.org/trunk@46705
git-svn-id: http://core.svn.wordpress.org/trunk@46505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 16:07:03 +00:00
Sergey Biryukov
1fceddf46b
Script Loader: In `wp_default_packages_inline_scripts()`, make sure the root URL middleware is registered before using the media middleware.
...
This allows for requests to retry post-processing large images using the `post-process` REST API endpoint to work as expected.
Props azaozz, mikeschroder, TimothyBlynJacobs, epiqueras, johnbillion, youknowriad.
Fixes #48542 .
Built from https://develop.svn.wordpress.org/trunk@46703
git-svn-id: http://core.svn.wordpress.org/trunk@46503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 15:10:02 +00:00
Sergey Biryukov
9fa094ea50
Twenty Twenty: Fix WPCS issue in [46701].
...
See #48557 .
Built from https://develop.svn.wordpress.org/trunk@46702
git-svn-id: http://core.svn.wordpress.org/trunk@46502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 12:59:00 +00:00
Sergey Biryukov
f29206f73c
Bundled Themes: Update Twenty Twenty.
...
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see c267289...898792b
.
Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07.
See #48110 , #48386 , #48450 , #48505 .
Fixes #48557 .
Built from https://develop.svn.wordpress.org/trunk@46701
git-svn-id: http://core.svn.wordpress.org/trunk@46501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 12:29:01 +00:00
Sergey Biryukov
6c4b808137
Comments: Check if comment form element exists before adding a key handler to detect the cmd/ctrl-enter key press.
...
Follow-up to [45790].
Props raamdev.
Fixes #48543 . See #41545 .
Built from https://develop.svn.wordpress.org/trunk@46700
git-svn-id: http://core.svn.wordpress.org/trunk@46500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 11:51:03 +00:00
Sergey Biryukov
f67b1a6385
Customize: Remove the deprecated `-precomposed` suffix from `apple-touch-icon` link in `wp_site_icon()`.
...
Props mukto90, khag7.
Fixes #48555 .
Built from https://develop.svn.wordpress.org/trunk@46698
git-svn-id: http://core.svn.wordpress.org/trunk@46498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 10:00:01 +00:00
Sergey Biryukov
323e25b2bc
Networks and Sites: Pass the `$blog_id` parameter to the `newblog_notify_siteadmin` filter.
...
Props mukto90, virgodesign.
Fixes #48554 .
Built from https://develop.svn.wordpress.org/trunk@46697
git-svn-id: http://core.svn.wordpress.org/trunk@46497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 09:53:02 +00:00
Sergey Biryukov
3d623995a8
Docs: In various `@return` tags, list the expected type first, instead of `WP_Error`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46696
git-svn-id: http://core.svn.wordpress.org/trunk@46496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 02:43:03 +00:00
Sergey Biryukov
82dfb2d151
Docs: Miscellaneous docblock corrections in `wp-admin/includes/plugin.php`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46695
git-svn-id: http://core.svn.wordpress.org/trunk@46495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 00:05:01 +00:00
Sergey Biryukov
2af39e45cb
Docs: Improve documentation for `deactivate_plugins()` and `activate_plugins()`.
...
Props marekdedic, spenserhale, SergeyBiryukov.
Fixes #48352 .
Built from https://develop.svn.wordpress.org/trunk@46694
git-svn-id: http://core.svn.wordpress.org/trunk@46494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-10 23:05:03 +00:00
Sergey Biryukov
7b6d73a9ff
Tests: Don't skip the tests intended for Multisite when running on single site, add them to the `ms-required` group instead.
...
See #43438 .
Built from https://develop.svn.wordpress.org/trunk@46693
git-svn-id: http://core.svn.wordpress.org/trunk@46493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-10 01:55:02 +00:00
Sergey Biryukov
adf35e9217
Coding Standards: Fix WPCS issue in [46690].
...
See #41880 .
Built from https://develop.svn.wordpress.org/trunk@46692
git-svn-id: http://core.svn.wordpress.org/trunk@46492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-10 01:45:02 +00:00
Sergey Biryukov
b0ddfb2435
Docs: Move the `@link` tag for Customize API in `WP_Customize_Manager::add_setting()` and `WP_Customize_Setting` to a more appropriate place.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46691
git-svn-id: http://core.svn.wordpress.org/trunk@46491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-10 01:43:02 +00:00
Sergey Biryukov
5fb34a0a1c
Docs: Improve documentation for `WP_Http` per the documentation standards.
...
Props hareesh-pillai, adnan.limdi, isabel_brison.
Fixes #41880 .
Built from https://develop.svn.wordpress.org/trunk@46690
git-svn-id: http://core.svn.wordpress.org/trunk@46490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-10 01:18:02 +00:00
Sergey Biryukov
4d8a0a8b33
Docs: Use 3-digit, x.x.x style semantic versioning for `$version` argument in `do_action_deprecated()` and `apply_filters_deprecated()` calls.
...
Props jrf.
Fixes #48255 .
Built from https://develop.svn.wordpress.org/trunk@46689
git-svn-id: http://core.svn.wordpress.org/trunk@46489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 13:57:03 +00:00
Sergey Biryukov
6ed1a7b615
Docs: Correct the documentation placement for `wp_print_styles` and `shortcode_atts_{$shortcode}` hooks.
...
Props jrf.
See #48255 .
Built from https://develop.svn.wordpress.org/trunk@46688
git-svn-id: http://core.svn.wordpress.org/trunk@46488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 13:43:01 +00:00
Sergey Biryukov
0e79d4d101
Coding Standards: Fix WPCS issue in [46684].
...
See #48255 .
Built from https://develop.svn.wordpress.org/trunk@46687
git-svn-id: http://core.svn.wordpress.org/trunk@46487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 13:33:02 +00:00
Sergey Biryukov
81490ddbb1
Coding Standards: Revert the change to `wp-includes/class-wp-xmlrpc-server.php` in [46684] to investigate unit test failures.
...
See #48255 .
Built from https://develop.svn.wordpress.org/trunk@46686
git-svn-id: http://core.svn.wordpress.org/trunk@46486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 13:31:01 +00:00
Sergey Biryukov
1f816ad18d
Docs: Use the `{@see ...}` tag for the replacement in `@deprecated` tags, so that Developer Reference could automatically link to the replacement.
...
Props jrf.
See #48255 .
Built from https://develop.svn.wordpress.org/trunk@46685
git-svn-id: http://core.svn.wordpress.org/trunk@46485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 13:05:02 +00:00
Sergey Biryukov
f60094679f
Coding Standards: Consistently use `do_action_deprecated()` and `apply_filters_deprecated()` for deprecated hooks.
...
Props jrf.
See #48255 .
Built from https://develop.svn.wordpress.org/trunk@46684
git-svn-id: http://core.svn.wordpress.org/trunk@46484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 12:59:03 +00:00
Sergey Biryukov
5c094564a7
Test: Don't skip the tests intended for single site when running on Multisite, add them to the `ms-excluded` group instead.
...
See #39776 , #45747 .
Built from https://develop.svn.wordpress.org/trunk@46683
git-svn-id: http://core.svn.wordpress.org/trunk@46483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 03:46:02 +00:00
Sergey Biryukov
c8f6d05c64
Tests: Skip `test_readme()` if the HTTP request to `secure.php.net` or `dev.mysql.com` failed on timeout.
...
Move `skipTestOnTimeout()` to `WP_UnitTestCase_Base` to avoid duplication.
See #44613 .
Built from https://develop.svn.wordpress.org/trunk@46682
git-svn-id: http://core.svn.wordpress.org/trunk@46482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 03:38:00 +00:00
Sergey Biryukov
ba21b391f6
Docs: Correct some inconsistencies in comments with Dashicon class references in `wp-admin/css/customize-widgets.css`.
...
Prepend all class name references with `dashicons-` for clarity.
Props 1naveengiri, marcio-zebedeu, hareesh-pillai, SergeyBiryukov.
Fixes #48417 .
Built from https://develop.svn.wordpress.org/trunk@46681
git-svn-id: http://core.svn.wordpress.org/trunk@46481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 00:03:02 +00:00
Sergey Biryukov
15a4289c8d
Docs: Correct description for `$recursive` parameter of `::chmod()` and `::delete()` methods in `WP_Filesystem` implementations.
...
Props skithund.
Fixes #48422 .
Built from https://develop.svn.wordpress.org/trunk@46679
git-svn-id: http://core.svn.wordpress.org/trunk@46479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-08 22:56:02 +00:00
John Blackbourn
84a1922e18
Toolbar: Un-deprecate the `WP_Admin_Bar::add_menu()` method.
...
This is only a wrapper for the `add_node()` method, but it's in widespread use both in core until [46642] and in thousands of plugins and themes. Deprecating it would have made sense when #19647 was originally opened but that's no longer the case.
Props whyisjake
Fixes #19647
Built from https://develop.svn.wordpress.org/trunk@46678
git-svn-id: http://core.svn.wordpress.org/trunk@46478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-08 13:19:04 +00:00
Andrew Ozz
60c2966222
Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in `wp_get_missing_image_subsizes()`. Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold.
...
Props desrosj, azaozz.
Fixes #48518 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46677
git-svn-id: http://core.svn.wordpress.org/trunk@46477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-07 18:51:02 +00:00