Sergey Biryukov
e8c4b8c8e7
Docs: Add an entry for `$pagenow` global in `WP_Customize_Manager::setup_theme()`.
...
Props mt8.biz.
Fixes #40297 .
Built from https://develop.svn.wordpress.org/trunk@40349
git-svn-id: http://core.svn.wordpress.org/trunk@40256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-29 11:41:46 +00:00
Sergey Biryukov
633ce094a1
Taxonomy: Fix typo in `$aria_checked` variable name in `Walker_Category_Checklist::start_el()`.
...
Props dhanendran.
Fixes #40295 .
Built from https://develop.svn.wordpress.org/trunk@40348
git-svn-id: http://core.svn.wordpress.org/trunk@40255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-29 11:22:47 +00:00
Jeremy Felt
1c6111f3bb
Multisite: Remove unused `site-lookup` global cache group.
...
The `site-lookup` group was introduced in WPMU, but never actually used in WordPress core.
Props johnjamesjacoby.
Fixes #38725 .
Built from https://develop.svn.wordpress.org/trunk@40347
git-svn-id: http://core.svn.wordpress.org/trunk@40254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-28 21:08:47 +00:00
Jeremy Felt
0e7e0aa4bc
Multisite: Respect `$_wp_suspend_cache_invalidation` when clearing network and site caches.
...
Props johnjamesjacoby.
Fixes #40028 .
Built from https://develop.svn.wordpress.org/trunk@40346
git-svn-id: http://core.svn.wordpress.org/trunk@40253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-28 19:36:49 +00:00
Jeremy Felt
6530f5f5f2
Multisite: Allow falsy properties to be cached in `site-details`.
...
In previous iterations of `WP_Site`, there was concern that not all properties would be available when storing a site's details in cache. When introduced in [37918], an `ms_loaded` check was added to address this concern. Any properties that are still `false` after `ms_loaded` really are `false` and can be cached as such.
Props flixos90.
Fixes #40247 .
Built from https://develop.svn.wordpress.org/trunk@40344
git-svn-id: http://core.svn.wordpress.org/trunk@40251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-28 02:32:44 +00:00
Jeremy Felt
fa5f2d1fa2
Tests: Add missing global cache groups.
...
Add `useremail`, `userslugs`, `networks`, `sites`, and `site-details` as global cache groups when added with unit tests. This aligns the list with the core default.
Fixes #40283 .
Built from https://develop.svn.wordpress.org/trunk@40343
git-svn-id: http://core.svn.wordpress.org/trunk@40250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-28 01:46:45 +00:00
Jeremy Felt
b61ddd8035
Tests: Clarify zero path segment tests for `get_network_by_path()`.
...
The set of assertions in this data provider intend to test a 0 path segment configuration rather than the use of paths.
Fixes #37217 .
Built from https://develop.svn.wordpress.org/trunk@40342
git-svn-id: http://core.svn.wordpress.org/trunk@40249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-28 01:25:48 +00:00
Jeremy Felt
94dbb2e8d8
Tests: Consolidate logic used to skip API fixture generation.
...
This checks for `is_multisite()` and the minimum PHP version in the same block and removes two `echo` statements previously used to indicate generation had been skipped.
Fixes #40041 .
Built from https://develop.svn.wordpress.org/trunk@40341
git-svn-id: http://core.svn.wordpress.org/trunk@40248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-27 21:05:44 +00:00
Jeremy Felt
f940beae2b
Multisite: Add `lang_id` support to `WP_Site_Query`.
...
Sites can now be queried by `lang_id`, `lang__in`, and `lang__not_in`.
Props ocean90.
Fixes #40196 .
Built from https://develop.svn.wordpress.org/trunk@40340
git-svn-id: http://core.svn.wordpress.org/trunk@40247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-27 19:48:52 +00:00
Jeremy Felt
36aa674859
Tests: Use utf8mb4 max index length when creating keys.
...
In [31349], core `varchar` column key lengths were changed from 255 to 191 to support the 767 byte index size limit on standard utf8mb4 MySQL installs. This changes the DB schema tests to match.
Props caseypatrickdriscoll, clarinetlord.
Fixes #35958 .
Built from https://develop.svn.wordpress.org/trunk@40339
git-svn-id: http://core.svn.wordpress.org/trunk@40246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-27 19:34:53 +00:00
Pascal Birchler
db5a65eb5e
Themes: Fix incorrect annotation for `__clear_multi_author_cache()` function.
...
Props flixos90.
See #40063 .
Fixes #40262 .
Built from https://develop.svn.wordpress.org/trunk@40334
git-svn-id: http://core.svn.wordpress.org/trunk@40241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-25 15:47:42 +00:00
Pascal Birchler
6216c997ba
Multisite: After [40305], rename `clean_site_details_cache()` method as it's not really private.
...
See #40063 .
Built from https://develop.svn.wordpress.org/trunk@40333
git-svn-id: http://core.svn.wordpress.org/trunk@40240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-25 15:31:43 +00:00
Weston Ruter
8256ecfecb
Customize: Improve i18n for strings in hidden widget area notices.
...
Amends [40312].
Props westonruter, ocean90, swissspidy, SergeyBiryukov, michelleweber for copywriting.
See #33567 , #33052 .
Fixes #39087 .
Built from https://develop.svn.wordpress.org/trunk@40330
git-svn-id: http://core.svn.wordpress.org/trunk@40237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-24 22:03:42 +00:00
Pascal Birchler
0d42f8549c
REST API: Use `get_gmt_from_date()` when preparing a draft post for response.
...
This prevents wrong dates when dealing with DST, see [40115] and [40284].
Props nerrad.
Fixes #40136 .
Built from https://develop.svn.wordpress.org/trunk@40324
git-svn-id: http://core.svn.wordpress.org/trunk@40231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-24 17:32:46 +00:00
John Blackbourn
37a638ae8a
Users: Don't push the current user's role to the top of the list in `wp_dropdown_roles()`.
...
This brings consistency to the order in which roles are displayed in the `Roles` dropdown when editing users.
Props bor0
Fixes #40162
Built from https://develop.svn.wordpress.org/trunk@40323
git-svn-id: http://core.svn.wordpress.org/trunk@40230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-24 14:53:46 +00:00
Sergey Biryukov
6e5e29c5bf
Docs: Correct default value in `@param` entry for the `$num_words` parameter of `wp_trim_words` filter.
...
Props redrambles.
Fixes #40248 .
Built from https://develop.svn.wordpress.org/trunk@40322
git-svn-id: http://core.svn.wordpress.org/trunk@40229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-24 00:58:41 +00:00
John Blackbourn
3a4b5afa49
Login and Registration: Avoid a potentially incorrect value for the cookie hash on multisite installations that don't have a value in the `siteurl` network option.
...
This reverts [38619].
See #34084
Fixes #39497
Built from https://develop.svn.wordpress.org/trunk@40320
git-svn-id: http://core.svn.wordpress.org/trunk@40227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-23 19:01:42 +00:00
Weston Ruter
e78707aad4
Customize: Prevent client-side validation from being cleared when no corresponding server-side validation is present.
...
See #36944 .
Fixes #39770 .
Built from https://develop.svn.wordpress.org/trunk@40319
git-svn-id: http://core.svn.wordpress.org/trunk@40226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-23 18:12:44 +00:00
Weston Ruter
5aec57b209
Customize: Fix navigation of site in preview on IE11.
...
Addresses issue in IE11 where the default port number of `:80` is unexpectedly included on `link.host` for links dynamically created by scripts.
Props westonruter, afercia for testing.
See #38409 .
Fixes #40198 .
Built from https://develop.svn.wordpress.org/trunk@40318
git-svn-id: http://core.svn.wordpress.org/trunk@40225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-23 17:25:43 +00:00
Felix Arntz
6b5169739f
Multisite: Add further unit tests for `get_blog_details()`.
...
These tests verify that the returned site object is iterable and contains the expected properties.
See #40228 , #40180 .
Built from https://develop.svn.wordpress.org/trunk@40317
git-svn-id: http://core.svn.wordpress.org/trunk@40224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-23 17:14:43 +00:00
Weston Ruter
c78f903a7b
Customize: Fix selective refresh when customizing the 404 template.
...
Overrides the 404 status during partial refresh requests to serve back 200 so that the request is not deemed a failure and invoke the fallback behavior (full refresh).
See #27355 .
Fixes #40018 .
Built from https://develop.svn.wordpress.org/trunk@40316
git-svn-id: http://core.svn.wordpress.org/trunk@40223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-23 16:57:43 +00:00
Sergey Biryukov
090901009b
Twenty Seventeen: Declare jQuery as a dependency for `navigation.js`.
...
Props chesio.
Fixes #40224 .
Built from https://develop.svn.wordpress.org/trunk@40315
git-svn-id: http://core.svn.wordpress.org/trunk@40222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-23 16:22:44 +00:00
Weston Ruter
80bb51634a
Customize: Harden `site_icon` control template to account for when `full` image size is missing.
...
Props aussieguy123, westonruter.
See #36749 .
Fixes #40010 .
Built from https://develop.svn.wordpress.org/trunk@40314
git-svn-id: http://core.svn.wordpress.org/trunk@40221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-23 06:13:44 +00:00
Weston Ruter
84ed6f665f
Customize: Prevent links to `customize.php` from being generated which have query vars from `wp_removable_query_args()` present.
...
Props dlh.
See #23367 , #32692 .
Fixes #31850 .
Built from https://develop.svn.wordpress.org/trunk@40313
git-svn-id: http://core.svn.wordpress.org/trunk@40220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 23:04:42 +00:00
Weston Ruter
085b50b20d
Customize: Show notice in Widgets panel when there are additional widget areas not rendered in preview.
...
This extends the existing behavior which only showed a message only when there were no widget areas rendered in the preview. The number of non-rendered widget areas is indicated. Also removes needles deletion of `wp.customize.Widgets.data.l10n` property which hindered plugins.
See #33567 , #33052 .
Fixes #39087 .
Built from https://develop.svn.wordpress.org/trunk@40312
git-svn-id: http://core.svn.wordpress.org/trunk@40219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 19:03:45 +00:00
Sergey Biryukov
f44fe7f5fe
Twenty Seventeen: Use `esc_attr_e()` for translatable strings in HTML attributes.
...
Props bor0.
Fixes #40216 .
Built from https://develop.svn.wordpress.org/trunk@40311
git-svn-id: http://core.svn.wordpress.org/trunk@40218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 03:52:41 +00:00
Sergey Biryukov
6a2b38ca6c
Docs: Add description for `$mode` global in `WP_MS_Sites_List_Table` and `WP_MS_Users_List_Table`.
...
Fixes #40208 .
Built from https://develop.svn.wordpress.org/trunk@40310
git-svn-id: http://core.svn.wordpress.org/trunk@40217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 03:48:42 +00:00
Sergey Biryukov
0b7148ebbb
Docs: Add description for `$mode` global in `WP_Media_List_Table` and `WP_Posts_List_Table`.
...
See #40208 .
Built from https://develop.svn.wordpress.org/trunk@40309
git-svn-id: http://core.svn.wordpress.org/trunk@40216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 03:47:07 +00:00
Sergey Biryukov
e51bc5fb6b
Docs: Add missing `@global` entry for list table view mode in `WP_Screen::render_view_mode()`.
...
Props priyankabehera155.
See #40208 .
Built from https://develop.svn.wordpress.org/trunk@40308
git-svn-id: http://core.svn.wordpress.org/trunk@40215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 03:46:28 +00:00
Sergey Biryukov
127a2c9998
Docs: Add missing `@global` entry for list table view mode in `wp_ajax_inline_save()`.
...
Props priyankabehera155.
See #40208 .
Built from https://develop.svn.wordpress.org/trunk@40307
git-svn-id: http://core.svn.wordpress.org/trunk@40214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-22 03:45:45 +00:00
Rachel Baker
f78ceb362e
REST API: Confirm the parent post object of an attachment exists in `WP_REST_Posts_Controller::check_read_permission()`.
...
Avoid a PHP Error when attempting to embed the parent post of an attachment, when the parent post ID is invalid. Instead check if the parent post object exists before checking the read permission for the parent post.
Props GhostToast.
Fixes #39881 .
Built from https://develop.svn.wordpress.org/trunk@40306
git-svn-id: http://core.svn.wordpress.org/trunk@40213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-20 04:30:46 +00:00
Felix Arntz
cde6126923
Multisite: Handle sites cache invalidation more granularly for option updates.
...
Previously `update_blog_option()` would trigger an invalidation of that site's entire cache although these changes did not affect the content of these caches. Furthermore changes to the special options `blogname`, `siteurl` and `post_count` should not invalidate the entire cache of that site, but only their respective site details cache. The option `home` now has the same behavior as it also belongs to the site details, but did not invalidate the cache at all previously.
Several new unit tests confirm these changes work as expected.
Fixes #40063 .
Built from https://develop.svn.wordpress.org/trunk@40305
git-svn-id: http://core.svn.wordpress.org/trunk@40212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-19 16:22:45 +00:00
Weston Ruter
e69b9b244c
Customize: Fix failure to collapse expanded sections and panels that become deactivated.
...
Improve jsdoc for `onChangeActive` function. Restores fix from [34557] which got dropped in [38648].
Props dlh, westonruter.
See #34391 , #33509 .
Fixes #39430 .
Built from https://develop.svn.wordpress.org/trunk@40304
git-svn-id: http://core.svn.wordpress.org/trunk@40211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-19 00:04:43 +00:00
Pascal Birchler
280bfe7933
Taxonomy: Add missing REST API properties to `WP_Taxonomy` class.
...
Props danielbachhuber.
Fixes #39987 .
Built from https://develop.svn.wordpress.org/trunk@40303
git-svn-id: http://core.svn.wordpress.org/trunk@40210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-18 15:25:43 +00:00
Pascal Birchler
9ebebe5d25
Posts, Post Types: Add missing REST API properties to `WP_Post_Type` class.
...
Props danielbachhuber.
Fixes #39986 .
Built from https://develop.svn.wordpress.org/trunk@40302
git-svn-id: http://core.svn.wordpress.org/trunk@40209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-18 15:17:45 +00:00
Rachel Baker
503d42fe6b
Themes: Add filter for excluding directories from being scanned for template files.
...
Exclude 'node_modules' directories from paths searched in `WP_Theme::scandir()`. Introduces the `theme_scandir_exclusions` filter to allow sites to exclude any other paths like `bower_components` or `vendor` from being searched for template files.
Props lukasbesch, dd32, swisspidy, rachelbaker.
Fixes #38292 .
Built from https://develop.svn.wordpress.org/trunk@40301
git-svn-id: http://core.svn.wordpress.org/trunk@40208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-18 03:54:41 +00:00
Weston Ruter
fc631ffa00
Customize: Trailingslash the home nav menu item URL in starter content.
...
This prevents an additional 301 redirect when clicking on the nav menu item, and it also prevents a scenario where the auth cookie may not be passed and cause an authentication error when navigating in the customizer.
Props dlh, swissspidy.
Fixes #40112 .
Built from https://develop.svn.wordpress.org/trunk@40300
git-svn-id: http://core.svn.wordpress.org/trunk@40207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-18 03:23:44 +00:00
Sergey Biryukov
9f4bbcdb78
Docs: Fix typo in `wp_parse_url()` and `_get_component_from_parsed_url_array()` docblocks.
...
Props naomicbush.
Fixes #40190 .
Built from https://develop.svn.wordpress.org/trunk@40299
git-svn-id: http://core.svn.wordpress.org/trunk@40206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-17 19:02:40 +00:00
Drew Jaynes
c1030f3b94
Docs: Add a missing return description for `get_post_taxonomies()`.
...
h/t deeptiboddapati.
See #39130 .
Built from https://develop.svn.wordpress.org/trunk@40298
git-svn-id: http://core.svn.wordpress.org/trunk@40205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-17 17:27:41 +00:00
Pascal Birchler
3e189479a7
List Tables: Hide 'Empty Trash' and 'Empty Spam' buttons when view is already empty.
...
Props ivantedja, Presskopp, printsachen1, Jaydeep Rami, mathieuhays, cazm.
Fixes #38341 .
Built from https://develop.svn.wordpress.org/trunk@40297
git-svn-id: http://core.svn.wordpress.org/trunk@40204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-17 16:54:42 +00:00
Pascal Birchler
62061bab56
Multisite: Ensure first page/post/comment content is not empty when setting up a new site.
...
This prevents creating page without any content when the options are populated with an empty string.
Props shadyvb.
Fixes #40036 .
Built from https://develop.svn.wordpress.org/trunk@40296
git-svn-id: http://core.svn.wordpress.org/trunk@40203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-17 15:49:42 +00:00
Felix Arntz
2295ed8031
Multisite: Remove restriction of minimum site name length in `wpmu_validate_blog_signup()`.
...
It is sometimes desirable to support shorter site names than 4 characters, therefore that restriction should be removed. It is still possible to manually enforce it by using the `wpmu_validate_blog_signup` filter.
As a result of this change, another `is_super_admin()` call gets removed which affects the ongoing efforts of working on a network-wide role system.
Props milindmore22.
Fixes #39676 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@40295
git-svn-id: http://core.svn.wordpress.org/trunk@40202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-17 14:36:43 +00:00
Felix Arntz
8e71ca0f94
Multisite: Provide unit tests for `wpmu_validate_blog_signup()`.
...
See #39676 .
Built from https://develop.svn.wordpress.org/trunk@40294
git-svn-id: http://core.svn.wordpress.org/trunk@40201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-17 14:15:44 +00:00
Boone Gorges
72e14046c7
Improve querying for terms with falsey names and slugs.
...
Prior to [38677], `get_term_by()` would always return false if
an empty string were passed as the queried 'name' or 'slug'. The
refactor to use `get_terms()` broke this behavior; inappropriately
imprecise `empty()` checks caused the 'name' or 'slug' clause to be
discarded altogether when fetching terms, resulting in an incorrect
term being returned from the function.
We fix the regression by special-casing truly empty values passed
to `get_term_by()`, and ensuring that `WP_Term_Query` is properly
able to handle `0` and `'0'` term queries.
Props sstoqnov.
Fixes #21760 .
Built from https://develop.svn.wordpress.org/trunk@40293
git-svn-id: http://core.svn.wordpress.org/trunk@40200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-16 02:04:43 +00:00
Boone Gorges
1e05730f2d
Streamline `get_terms()` parameter documentation.
...
Since 4.6, `get_terms()` has been a wrapper for `WP_Term_Query`.
Full parameter documentation lives with the class, and
`get_terms()` should reference rather than duplicate it.
Props shashwatmittal.
Fixes #37075 .
Built from https://develop.svn.wordpress.org/trunk@40292
git-svn-id: http://core.svn.wordpress.org/trunk@40199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-16 01:35:45 +00:00
Boone Gorges
d4350bc065
Fix the formatting of `$taxonomies` parameter of `'wp_get_object_terms'` filter.
...
[38667] changed the way that the filter parameters are built. That
changeset didn't fully account for the pre-4.7 format of `$taxonomies`.
Props ig_communitysites.
Fixes #40154 .
Built from https://develop.svn.wordpress.org/trunk@40290
git-svn-id: http://core.svn.wordpress.org/trunk@40197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-14 18:42:43 +00:00
James Nylen
d92e1fb1e4
REST API: Fix DST handling in a test.
...
The time chosen for `test_empty_post_date_gmt_shimmed_using_post_date` falls within US daylight savings time. This may cause the test to fail depending on whether the current locale has DST.
The fix is to specify a numeric `gmt_offset` rather than a `timezone_string`.
Unprops jnylen0.
Fixes #40136 .
Built from https://develop.svn.wordpress.org/trunk@40284
git-svn-id: http://core.svn.wordpress.org/trunk@40196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-13 15:07:45 +00:00
Andrew Ozz
7d34efea8d
Improve wording of the AYS warning when permanently deleting uploads, tags, posts.
...
Props dllh, gma992.
Fixes #39712 for trunk.
Built from https://develop.svn.wordpress.org/trunk@40283
git-svn-id: http://core.svn.wordpress.org/trunk@40195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-11 19:33:43 +00:00
Sergey Biryukov
e9f73b06b6
Docs: Correct the description for `wp.updates.deleteTheme`.
...
Props MattyRob.
Fixes #40110 .
Built from https://develop.svn.wordpress.org/trunk@40279
git-svn-id: http://core.svn.wordpress.org/trunk@40194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-11 16:13:46 +00:00
Boone Gorges
43208263a0
Tests: Use `assertSame()` for `WP_Query` 'orderby' tests.
...
`assertEqualSets()` ignores order, so isn't much good for testing 'orderby'.
See #38034 .
Built from https://develop.svn.wordpress.org/trunk@40278
git-svn-id: http://core.svn.wordpress.org/trunk@40193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-03-11 03:08:48 +00:00