Aaron Jorbin
940b403576
Remove Debugging code introduced in [37146]
...
Built from https://develop.svn.wordpress.org/branches/4.4@37147
git-svn-id: http://core.svn.wordpress.org/branches/4.4@37114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:56:28 +00:00
Aaron Jorbin
9e1133b642
Add Nonce to updating wporg_favorites user meta field
...
Merges [37145] to the 4.4 branch
Built from https://develop.svn.wordpress.org/branches/4.4@37146
git-svn-id: http://core.svn.wordpress.org/branches/4.4@37113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:41:26 +00:00
Nikolay Bachiyski
fc416c81fe
Add nonce to AJAX action for script compression setting
...
Merges [37143] to the 4.4 branch
Built from https://develop.svn.wordpress.org/branches/4.4@37144
git-svn-id: http://core.svn.wordpress.org/branches/4.4@37111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:31:28 +00:00
Dominik Schilling
98b994303e
Media: In `wp_read_image_metadata()` make sure that IPTC keywords are UTF8 encoded.
...
Prevents missing `_wp_attachment_metadata` when an image contains keywords with latin extended characters.
Merges [36429] to the 4.4 branch.
See #35316 .
Built from https://develop.svn.wordpress.org/branches/4.4@36430
git-svn-id: http://core.svn.wordpress.org/branches/4.4@36397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-01 14:58:28 +00:00
Dion Hulse
ced6b063a3
List Tables: When a user has hidden all columns, do not override that with the `default_hidden_columns` filter.
...
Merges [36154] to the 4.4 branch.
Props Compute, jorbin, voldemortensen.
Fixes #35057 .
Built from https://develop.svn.wordpress.org/branches/4.4@36155
git-svn-id: http://core.svn.wordpress.org/branches/4.4@36121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-02 04:45:22 +00:00
Dion Hulse
ac6b8ae319
Admin: Restore the "Show advanced menu properties" checkboxes IDs.
...
These checkboxes are used on the Menus screen options and the Customizer Menus options.
Their IDs were removed in [34991] but they're needed to get the checkboxes to be saved
via AJAX. Also, avoids a useless AJAX call.
Merge [36137] to the 4.4 branch.
Props afercia.
Fixes #35112 .
Built from https://develop.svn.wordpress.org/branches/4.4@36145
git-svn-id: http://core.svn.wordpress.org/branches/4.4@36111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-02 03:34:21 +00:00
Dion Hulse
b894426307
Help Tab Order should be based on the Priority Argument
...
[34370] made the order that tabs are returned respect the order they are added, however it broke the respect of priority. By using a ksort instead of a sort, we can restore that default behavior. This adjusts the unit tests so that both order added and priority are tested.
Merges [36089] to the 4.4 branch.
Props meitar, swissspidy, jorbin
Fixes #35215 . See #33941 .
Built from https://develop.svn.wordpress.org/branches/4.4@36104
git-svn-id: http://core.svn.wordpress.org/branches/4.4@36069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-27 02:14:22 +00:00
Dion Hulse
a44134a96d
Filesystem: Revert [33648] and [34733] unfortunately these have caused issues for some servers, while fixing it for others.
...
See #28013
Fixes #34976 for the 4.4 branch
Fixes #34976 for the 4.4 branch
Built from https://develop.svn.wordpress.org/branches/4.4@35945
git-svn-id: http://core.svn.wordpress.org/branches/4.4@35909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 02:37:26 +00:00
Dominik Schilling
41f0bf0bc1
List Tables: Revert [34728] and [35482].
...
Part of [34728] was already reverted in [35682], but the default values still made it impossible to set a default ordering for custom post types.
Merge of [35818] for the 4.4 branch.
See #25493 .
Fixes #34825 .
Built from https://develop.svn.wordpress.org/branches/4.4@35819
git-svn-id: http://core.svn.wordpress.org/branches/4.4@35783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 20:08:26 +00:00
Boone Gorges
43d1ab4720
Use 'invalid_username' error code when tripping 'illegal_user_logins'.
...
This gives us better compatibility with existing errors thrown by
`sanitize_user()`, especially in Multisite, where user_login has more
restrictions on allowed characters.
Props markjaquith.
Fixes #27317 .
Built from https://develop.svn.wordpress.org/trunk@35772
git-svn-id: http://core.svn.wordpress.org/trunk@35736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-04 23:25:26 +00:00
Helen Hou-Sandí
2f287af8aa
Media: Avoid `rel="rel="` situations.
...
props lucymtc, swissspidy.
fixes #34826 . see #32074 .
Built from https://develop.svn.wordpress.org/trunk@35760
git-svn-id: http://core.svn.wordpress.org/trunk@35724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-03 17:17:26 +00:00
Scott Taylor
d569b9609e
Media: show Trash filter for Media list table when `MEDIA_TRASH` is true.
...
Props chacha102.
Fixes #34795 .
Built from https://develop.svn.wordpress.org/trunk@35752
git-svn-id: http://core.svn.wordpress.org/trunk@35716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-01 20:48:25 +00:00
Mark Jaquith
1a43f0b290
Do not pass FALSE as second parameter in variable class_exists() checks
...
Because these are generally plugin-provided, we want plugins to be
able to use autoloaders.
fixes #20523
Built from https://develop.svn.wordpress.org/trunk@35749
git-svn-id: http://core.svn.wordpress.org/trunk@35713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-30 04:15:27 +00:00
John Blackbourn
ec24d6e001
In a similar vein to [34133], escape the email address and IP address of comment authors to increase defence in depth.
...
Built from https://develop.svn.wordpress.org/trunk@35748
git-svn-id: http://core.svn.wordpress.org/trunk@35712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-29 02:43:24 +00:00
Dominik Schilling
9fb5c540bb
Users: Allow to create users without sending an email to the new user.
...
This adds a checkbox to `wp-admin/user-new.php` to prevent sending an email with the username and a password reset link to the new user. Restores the behavior of pre-4.3.
Fixes #33504 .
Props tharsheblows, SergeyBiryukov, DrewAPicture, ocean90.
Built from https://develop.svn.wordpress.org/trunk@35742
git-svn-id: http://core.svn.wordpress.org/trunk@35706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 22:38:29 +00:00
Helen Hou-Sandí
e24681632e
Avoid potential fatal errors after [35718].
...
While these classes are intended for admin use, there are developers out there who include `wp-admin/includes/template.php` to access them in other contexts. There is no intention to continue to support this indefinitely, but a breaking change like that would need to happen very early in a cycle and communicated loudly.
In the meantime, if you're reading this commit message and you do the above, please update your code to not do that. Thank you :)
fixes #33413 .
Built from https://develop.svn.wordpress.org/trunk@35740
git-svn-id: http://core.svn.wordpress.org/trunk@35704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 22:19:26 +00:00
Scott Taylor
79a2915a9b
Upgrade: New themes are not automatically installed on upgrade. This can still be explicitly asked for by defining `CORE_UPGRADE_SKIP_NEW_BUNDLED` as `false`.
...
In `populate_options()`, if the theme specified by `WP_DEFAULT_THEME` doesn't exist, fall back to the latest core default theme. If we can't find a core default theme, `WP_DEFAULT_THEME` is the best we can do.
Props nacin, jeremyfelt, dd32.
See #34306 .
Built from https://develop.svn.wordpress.org/trunk@35738
git-svn-id: http://core.svn.wordpress.org/trunk@35702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 21:45:25 +00:00
Sergey Biryukov
60c8e272f5
Docs: Improve DocBlock formatting for `add_menu_page()` and `add_submenu_page()` wrappers.
...
See #34360 .
Built from https://develop.svn.wordpress.org/trunk@35731
git-svn-id: http://core.svn.wordpress.org/trunk@35695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-23 17:56:26 +00:00
Helen Hou-Sandí
2cdeac7cf6
Pass the `$post` object as context to `postmeta_form_keys`.
...
see #33885 , #18979 .
Built from https://develop.svn.wordpress.org/trunk@35730
git-svn-id: http://core.svn.wordpress.org/trunk@35694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-23 17:15:29 +00:00
Gary Pendergast
d04396d0ad
Docs: Replace a reference to WP.org with WordPress.org.
...
Built from https://develop.svn.wordpress.org/trunk@35729
git-svn-id: http://core.svn.wordpress.org/trunk@35693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 22:38:26 +00:00
Sergey Biryukov
ae04eba0b6
Comments: After [35670], change the CSS class for the pending comments count back to `moderated`.
...
Fixes #34680 .
Built from https://develop.svn.wordpress.org/trunk@35726
git-svn-id: http://core.svn.wordpress.org/trunk@35690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 15:23:26 +00:00
Sergey Biryukov
bc1e479fd0
After [35718], update the location of some files in `This filter is documented in` docs.
...
Partially reverts [33954].
Fixes #33413 .
Built from https://develop.svn.wordpress.org/trunk@35725
git-svn-id: http://core.svn.wordpress.org/trunk@35689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 03:51:28 +00:00
Andrew Nacin
1579e45d41
Simplify the include graph after work to split out classes.
...
see #33413 . More details there.
Built from https://develop.svn.wordpress.org/trunk@35718
git-svn-id: http://core.svn.wordpress.org/trunk@35682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 07:24:30 +00:00
Helen Hou-Sandí
e549e56f02
Custom fields: Allow for short-circuiting the meta key dropdown.
...
Adds the `postmeta_form_keys` filter which allows for a potentially expensive query against postmeta to be avoided.
props ericmann, tollmanz, nacin.
see #33885 .
Built from https://develop.svn.wordpress.org/trunk@35717
git-svn-id: http://core.svn.wordpress.org/trunk@35681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 06:16:50 +00:00
Boone Gorges
f173cdfb18
On 4.4 upgrade, remove the unused 'add_users' cap from all roles.
...
Fixes #16719 .
Built from https://develop.svn.wordpress.org/trunk@35701
git-svn-id: http://core.svn.wordpress.org/trunk@35665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 03:53:28 +00:00
Scott Taylor
a99f7baa5a
List Tables: Fix PHP error notice when `$columns` is `null`
...
Use of `register_column_headers()` and `print_column_headers()` creates a `_WP_List_Table_Compat` without any columns. When the List Table object doesn't have any columns, there's naturally no primary column.
Props danielbachhuber.
Fixes #34148 .
Built from https://develop.svn.wordpress.org/trunk@35698
git-svn-id: http://core.svn.wordpress.org/trunk@35662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 23:01:26 +00:00
Aaron Jorbin
e8d8e79371
Revert [34291] bringing back my-hacks
...
Keeping myhacks support is a small price to pay for not breaking people's sites. Even if it is very very very few sites, breaking sites isn't something that should be encouraged. Even with 10 years of deprecation notices.
https://core.trac.wordpress.org/ticket/33741#comment:18 outlines all the ways that the hack_file and my-hacks options can be setup and thus all the ways that the removal of those options could break sites.
Fixes #33741 .
Built from https://develop.svn.wordpress.org/trunk@35688
git-svn-id: http://core.svn.wordpress.org/trunk@35652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:49:26 +00:00
Dominik Schilling
c25efe2d52
Revert [35336] and [35337].
...
See #28344 .
Built from https://develop.svn.wordpress.org/trunk@35685
git-svn-id: http://core.svn.wordpress.org/trunk@35649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:30:25 +00:00
Scott Taylor
19834a4c21
List Tables: After [35622] and [34271], improve pagination logic when queries are altered.
...
Props bradyvercher.
Fixes #29870 .
Built from https://develop.svn.wordpress.org/trunk@35683
git-svn-id: http://core.svn.wordpress.org/trunk@35647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:25:26 +00:00
Scott Taylor
af0498989c
List Tables: After [34728], don't try to infer `orderby` from query params.
...
List tables are really good.
Props cklosows.
Fixes #25493 .
Built from https://develop.svn.wordpress.org/trunk@35682
git-svn-id: http://core.svn.wordpress.org/trunk@35646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:19:26 +00:00
Scott Taylor
f2e9e98fa6
Media: in `media_send_to_editor()`, use `wp_json_encode()` instead of `addslashes()`.
...
Props TobiasBg.
Fixes #22135 .
Built from https://develop.svn.wordpress.org/trunk@35677
git-svn-id: http://core.svn.wordpress.org/trunk@35641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:40:27 +00:00
Scott Taylor
838592c1ba
List Tables: because we can never eradicate the existence of globals, ensure that `$comment` is hoisted into the global space inside `WP_Comments_List_Table::single_row()`.
...
Fixes #34654 .
Built from https://develop.svn.wordpress.org/trunk@35674
git-svn-id: http://core.svn.wordpress.org/trunk@35638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:05:30 +00:00
Sergey Biryukov
bc41f44158
I18N: After [34424], replace the placeholder with comments count after `translate_nooped_plural()` runs, not before.
...
Props hnle.
Fixes #34680 .
Built from https://develop.svn.wordpress.org/trunk@35670
git-svn-id: http://core.svn.wordpress.org/trunk@35634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 18:04:28 +00:00
Drew Jaynes
283b7d0a66
Plugins: Rename the `delete_plugin` action hook (introduced in [35094]) to `deleted_plugin` as it fires ''following'' a plugin deletion attempt.
...
Further, introduce a new `delete_plugin` action hook, to be fired ''before'' a plugin deletion attempt. Both changes bring parity with other such transactional hooks in core that fire before and after certain actions, including on plugin activation/deactivation and install/uninstall, among others.
Props johnjamesjacoby.
Fixes #26904 .
Built from https://develop.svn.wordpress.org/trunk@35669
git-svn-id: http://core.svn.wordpress.org/trunk@35633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:58:26 +00:00
Sergey Biryukov
0d4cf36199
I18N: Remove `<a>` tag from translatable string in `wp-admin/includes/class-wp-comments-list-table.php`.
...
Props ramiy.
Fixes #34686 .
Built from https://develop.svn.wordpress.org/trunk@35666
git-svn-id: http://core.svn.wordpress.org/trunk@35630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:34:27 +00:00
Sergey Biryukov
5539193dd0
I18N: Add translator comments for strings in `wp-admin/includes/class-wp-filesystem-ftpsockets.php`.
...
Fixes #34684 .
Built from https://develop.svn.wordpress.org/trunk@35664
git-svn-id: http://core.svn.wordpress.org/trunk@35628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:23:29 +00:00
Sergey Biryukov
a7c5161db1
I18N: Add translator comments for strings in `wp-admin/includes/class-wp-filesystem-ftpext.php`.
...
See #34684 .
Built from https://develop.svn.wordpress.org/trunk@35663
git-svn-id: http://core.svn.wordpress.org/trunk@35627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:22:27 +00:00
Sergey Biryukov
0237fadd3a
I18N: Add translator comments for strings in `wp-admin/includes/class-wp-filesystem-base.php`.
...
See #34684 .
Built from https://develop.svn.wordpress.org/trunk@35662
git-svn-id: http://core.svn.wordpress.org/trunk@35626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:21:26 +00:00
Sergey Biryukov
6b94d7c89c
I18N: Add translator comments for strings in `wp-admin/includes/class-wp-filesystem-ssh2.php`.
...
Props ramiy.
See #34684 .
Built from https://develop.svn.wordpress.org/trunk@35661
git-svn-id: http://core.svn.wordpress.org/trunk@35625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:18:40 +00:00
Dominik Schilling
99f4fc4404
Themes: Check if the browse view is set in `wp_ajax_query_themes()` to avoid a PHP notice when searching for new themes.
...
Introduced in [35527].
See #34206 .
Built from https://develop.svn.wordpress.org/trunk@35646
git-svn-id: http://core.svn.wordpress.org/trunk@35610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 19:47:54 +00:00
Dion Hulse
42ff945649
Decrease the chances that `wp_tempnam()` will conflict with an existing file by suffixing a random ID to the generated filename.
...
This also switches from using `touch()` to using `fopen( $file, 'x')` to ensure that we're the process creating the file.
Fixes #34562
Built from https://develop.svn.wordpress.org/trunk@35644
git-svn-id: http://core.svn.wordpress.org/trunk@35608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 05:33:25 +00:00
Dion Hulse
be94558c46
Upgrader: Pass the `$args['hook_extra']` context to the `upgrader_source_selection` filter.
...
Props afragen
Fixes #34696
Built from https://develop.svn.wordpress.org/trunk@35642
git-svn-id: http://core.svn.wordpress.org/trunk@35606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 02:47:25 +00:00
Dominik Schilling
40b303069a
Schema: Increase length of `user_pass` and `user_activation_key` fields to 255.
...
Props grvrulz and Miglosh for testing.
Fixes #33904 .
Built from https://develop.svn.wordpress.org/trunk@35638
git-svn-id: http://core.svn.wordpress.org/trunk@35602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-15 14:19:28 +00:00
Helen Hou-Sandí
ae9e173082
Buttons: Standardize on `.button-link` for link-like buttons.
...
This serves as both a reset and some basic styling. The class name also aligns with parallel components in other popular projects.
props paulwilde for the initial patch.
fixes #34242 .
Built from https://develop.svn.wordpress.org/trunk@35636
git-svn-id: http://core.svn.wordpress.org/trunk@35600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-13 15:47:27 +00:00
Sergey Biryukov
95c55ca251
Cast `'illegal_user_logins'` filter result to array.
...
See #27317 .
Built from https://develop.svn.wordpress.org/trunk@35630
git-svn-id: http://core.svn.wordpress.org/trunk@35594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 16:34:27 +00:00
Sergey Biryukov
b08ae1d60b
Users: After [35189], make `'illegal_user_logins'` check case-insensitive.
...
Props juliobox.
Fixes #27317 .
Built from https://develop.svn.wordpress.org/trunk@35629
git-svn-id: http://core.svn.wordpress.org/trunk@35593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 16:30:28 +00:00
Scott Taylor
128a9c3acd
List Tables: after [34271], account for searches when calculating pagination.
...
Fixes #29870 .
Built from https://develop.svn.wordpress.org/trunk@35622
git-svn-id: http://core.svn.wordpress.org/trunk@35586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 23:14:26 +00:00
Dominik Schilling
1f15d30396
Upgrade: Revert [34543] because of incomplete and incorrect functionality.
...
See #33932 .
Fixes #34434 .
Built from https://develop.svn.wordpress.org/trunk@35619
git-svn-id: http://core.svn.wordpress.org/trunk@35583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 22:46:26 +00:00
Sergey Biryukov
db8c89cccb
Remove non-translatable HTML code from the first post content in `populate_network()` and `wp_install_defaults()`.
...
Add translator comment.
Props ramiy.
Fixes #34619 .
Built from https://develop.svn.wordpress.org/trunk@35614
git-svn-id: http://core.svn.wordpress.org/trunk@35578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 20:55:26 +00:00
Andrea Fercia
62e236b3c6
Accessibility: Improve form labels and descriptions for the Tags meta box in the Edit Post screen.
...
Fixes #34627 .
Built from https://develop.svn.wordpress.org/trunk@35609
git-svn-id: http://core.svn.wordpress.org/trunk@35573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 15:24:29 +00:00