Scott Taylor
194932fd6b
Add a `private` field to `WP_Posts_List_Table`, `$is_trash`.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31165
git-svn-id: http://core.svn.wordpress.org/trunk@31146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:22:22 +00:00
Scott Taylor
71f9bc3f42
Add a `private` field to `WP_Plugin_Install_List_Table`, `$error`.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31164
git-svn-id: http://core.svn.wordpress.org/trunk@31145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:19:22 +00:00
Scott Taylor
91312e71cd
In lieu of refactoring, add a `private` field to `WP_MS_Themes_List_Table`, `$has_items`. Ideally, this class would overload `->has_items()` and not set a `private` field.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31163
git-svn-id: http://core.svn.wordpress.org/trunk@31144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:17:22 +00:00
Scott Taylor
86c0f63739
Add 2 `private` fields to `WP_Media_List_Table`, `$detached` and `$is_trash`.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31162
git-svn-id: http://core.svn.wordpress.org/trunk@31143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:08:21 +00:00
Scott Taylor
df09597a65
After [31146], properly declare `$user_can` as a `private` field in `WP_Comments_List_Table`.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31161
git-svn-id: http://core.svn.wordpress.org/trunk@31142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:02:24 +00:00
Dion Hulse
af92025162
More concise documentation for wp_install_maybe_enable_pretty_permalinks()
...
See #6481 . Props ericlewis.
Built from https://develop.svn.wordpress.org/trunk@31160
git-svn-id: http://core.svn.wordpress.org/trunk@31141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 04:33:23 +00:00
Dion Hulse
a114d0929b
The new wp_install_maybe_enable_pretty_permalinks() function doesn't need to be pluggable.
...
See #6481 . Props nacin, valendesigns
Built from https://develop.svn.wordpress.org/trunk@31159
git-svn-id: http://core.svn.wordpress.org/trunk@31140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 04:31:23 +00:00
Jeremy Felt
40bcb404a3
Update `home` and `siteurl` after path slashes are validated in `update_blog_details()`
...
When editing a site, if `home` and `siteurl` are checked to be updated along with a site's domain and path, they should receive the results of any modifications in `update_blog_details()` rather than trusting the POST data.
Previously, it was possible to save a value without a leading slash on the path, causing an invalid URL to be stored.
Props earnjam.
Fixes #30417 .
Built from https://develop.svn.wordpress.org/trunk@31156
git-svn-id: http://core.svn.wordpress.org/trunk@31137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 01:57:23 +00:00
Scott Taylor
e6fc90f973
In `WP_List_Table`, only call magic method internals again whitelists of properties and methods, `$compat_fields` and `$compat_methods`.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31146
git-svn-id: http://core.svn.wordpress.org/trunk@31127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 22:20:22 +00:00
Scott Taylor
2749e46178
In `WP_Filesystem_Base`, make the only `private` member, `$cache`, `public` and remove magic methods. `$cache` was always `public` until [28487], has been essentially `public` via a magic method since.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31145
git-svn-id: http://core.svn.wordpress.org/trunk@31126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 22:04:22 +00:00
Boone Gorges
5c0ddb8602
Default `$parent` in `category_exists()` should default to null rather than 0.
...
[29863] made the corresponding change in `term_exists()`. Failure to change the
default value in `category_exists()` meant that an unspecified value for
`$parent` would limit results to top-level categories.
Includes unit tests and corrected function documentation.
Props hissy.
Fixes #30975 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31140
git-svn-id: http://core.svn.wordpress.org/trunk@31121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 01:26:27 +00:00
Scott Taylor
a56d920454
In `Custom_Image_Header`:
...
* In [28481], `$admin_header_callback` and `$admin_image_div_callback` were set to `private` based on their erroneous `@param` values
* `$admin_header_callback` and `$admin_image_div_callback` are used as hook callbacks - as such, they must be `public`
* In [28521] and [28524], magic methods were added for back-compat
* Currently, there are 4 properties marked `private`: `$uploaded_headers`, `$default_headers`, `$page`, and `$updated` - `$page` and `$uploaded_headers` are never used and `$updated` was added by me in [30187] during 4.1. `$default_headers` does not necessarily need to be `private`
Set `$admin_header_callback` and `$admin_image_div_callback` to `public`.
Remove the `$page` property - it duplicated the `$page` local var and is referenced/used nowhere.
Remove the `$uploaded_headers` property - it is used nowhere and is dead code.
Set `$default_headers` to `public`.
Remove the magic methods - they were beyond overkill and rendered moot by the above changes.
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31134
git-svn-id: http://core.svn.wordpress.org/trunk@31115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 22:11:22 +00:00
Scott Taylor
61f5cc459e
In `Custom_Background`:
...
* In [28481], `$admin_header_callback` and `$admin_image_div_callback` were set to `private` based on their erroneous `@param` value
* `$admin_header_callback` and `$admin_image_div_callback` are used as hook callbacks - as such, they must be `public`
* In [28521] and [28524], magic methods were added for back-compat
* Currently, there are 2 properties marked `private`, `$page` and `$updated` - `$page` is never used and `$updated` was added by me in [30186] during 4.1
Set `$admin_header_callback` and `$admin_image_div_callback` to `public`.
Remove the `$page` property - it duplicated the `$page` local var and is referenced/used nowhere.
Remove the magic methods - they were beyond overkill and rendered moot by the above changes.
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31133
git-svn-id: http://core.svn.wordpress.org/trunk@31114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 21:59:22 +00:00
Scott Taylor
56d6682461
In `edit-form-advanced.php`:
...
* `get_permalink( $post_ID )` can return `false`, set it to a variable and check it
* Using the variable allows us to replace 11 separate calls to `get_permalink( $post_ID )` in the file
* These notices were triggered by the potential for `false` to be passed to `esc_url()`
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31131
git-svn-id: http://core.svn.wordpress.org/trunk@31112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 21:21:22 +00:00
Scott Taylor
a6d6ba957b
`get_header_image()` can return `false`. In `Custom_Image_Header->step_1()`, check the value before setting the `background-image` portion of the `style` attribute. Setting the the URL to empty string will cause the current request to be set as the source of the background image.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31130
git-svn-id: http://core.svn.wordpress.org/trunk@31111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 21:08:22 +00:00
Scott Taylor
aaae4e9df0
Since `get_theme_mod()` returns `false` on failure, `$background_image_thumb` can be set to it and checked instead of calling `get_background_image()` 3 times in `Custom_Background->admin_page()`.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31129
git-svn-id: http://core.svn.wordpress.org/trunk@31110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 20:44:22 +00:00
Scott Taylor
2b6b7c0235
Declare `$action` as a global in `wp-admin/comment.php`.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31128
git-svn-id: http://core.svn.wordpress.org/trunk@31109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 20:42:24 +00:00
Scott Taylor
5547115dc2
Fix some `@param` docs that have chars too close them.
...
Add `@property` annotations to `WP_User` and `WP_Post`.
Remove erroneous `@param`s from image editor class methods.
Officially add the property `$_column_headers` to `WP_List_Table`.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31127
git-svn-id: http://core.svn.wordpress.org/trunk@31108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 06:57:22 +00:00
Scott Taylor
0a511680f4
Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Constructors do not have meaningful return values, anything that is returned from here is discarded.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31126
git-svn-id: http://core.svn.wordpress.org/trunk@31107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 06:54:23 +00:00
Scott Taylor
da99d29a59
Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31125
git-svn-id: http://core.svn.wordpress.org/trunk@31106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 06:13:22 +00:00
Scott Taylor
1b3f91f500
Declare `$wp_version`, `$required_php_version`, and `$required_mysql_version` as globals in install and upgrade admin files.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31124
git-svn-id: http://core.svn.wordpress.org/trunk@31105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:57:22 +00:00
Scott Taylor
1bac6fb886
In `wp-admin/includes/revision.php`, `$post->modified` is a coding error. It should be `$post->post_modified`.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31123
git-svn-id: http://core.svn.wordpress.org/trunk@31104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:50:22 +00:00
Scott Taylor
d6ce5dd553
`WP_Upgrader` will take any "skin" that is passed to it, and set `->skin` via composition. The default type of `->skin` is `WP_Upgrader_Skin`, which doesn't have methods declared for `->bulk_header()` and `->bulk_footer()`. Add noop methods to `WP_Upgrader_Skin`.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31122
git-svn-id: http://core.svn.wordpress.org/trunk@31103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:42:22 +00:00
Scott Taylor
84867b3e9c
Admin globals:
...
* Declare `$wp_importers` as a global in `admin.php`
* Declare `$post_type`, `$post_type_object`, and `$post` as globals where applicable
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31121
git-svn-id: http://core.svn.wordpress.org/trunk@31102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:29:22 +00:00
Scott Taylor
afd09f1f04
In `wp_ajax_upload_attachment()`, `wp_check_filetype_and_ext()` doesn't need a 3rd param - it already defaults to `null`. Passing `false` would fail a strict check
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31119
git-svn-id: http://core.svn.wordpress.org/trunk@31100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 04:55:25 +00:00
Andrew Ozz
3324fb71f6
TinyMCE editor-expand: when kitchensink is off hide the statusbar on loading, and when the editor is shorter then the viewport. Props avryl, fixes #30961 .
...
Built from https://develop.svn.wordpress.org/trunk@31118
git-svn-id: http://core.svn.wordpress.org/trunk@31099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 01:32:26 +00:00
Scott Taylor
709698a579
In `Custom_Background` and `Custom_Header`:
...
* In `->init()`, don't check `current_user_can()` since `add_theme_page()` will return `false` immediately if the cap check fails.
* Bail if `add_theme_page()` returns `false`
* `wp_check_filetype_and_ext()` doesn't need a 3rd param, it already defaults to `null`. Passing `false` would fail a strict check.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31116
git-svn-id: http://core.svn.wordpress.org/trunk@31097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 21:07:22 +00:00
Sergey Biryukov
7b04e6d4f4
Add variable type for sync_category_tag_slugs() parameters.
...
props tillkruess.
fixes #30718 .
Built from https://develop.svn.wordpress.org/trunk@31113
git-svn-id: http://core.svn.wordpress.org/trunk@31094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 11:19:22 +00:00
Sergey Biryukov
e214fce67f
Use localized format for Last Updated date in plugin details modal, for consistency with [31055].
...
see #30717 .
Built from https://develop.svn.wordpress.org/trunk@31110
git-svn-id: http://core.svn.wordpress.org/trunk@31091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 06:21:22 +00:00
Sergey Biryukov
d5d0b367ab
Improve documentation for media_handle_upload().
...
props ericlewis.
fixes #30962 .
Built from https://develop.svn.wordpress.org/trunk@31109
git-svn-id: http://core.svn.wordpress.org/trunk@31090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 05:05:23 +00:00
Scott Taylor
8ee598169f
After [31105], don't ditch the `isset()` calls for BC. Declare `$page_hook` as `null` so it is initialized for all execution paths but will still fail `isset()` checks.
...
Fixes #30958 .
Built from https://develop.svn.wordpress.org/trunk@31106
git-svn-id: http://core.svn.wordpress.org/trunk@31087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 22:52:22 +00:00
Scott Taylor
60e1dd409b
Properly declare `$hook_suffix`, `$plugin_page`, `$typenow`, and `$taxnow` as globals in `wp-admin/admin.php`.
...
Fixes #30958 .
Built from https://develop.svn.wordpress.org/trunk@31105
git-svn-id: http://core.svn.wordpress.org/trunk@31086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 22:15:24 +00:00
Scott Taylor
e4b6265c7a
Overriding methods should do more than simply call the same method in the super class.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31101
git-svn-id: http://core.svn.wordpress.org/trunk@31082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:20:22 +00:00
Scott Taylor
4a1ad9acec
Jump statements should not be followed by other statements (there were 5 lingering).
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31100
git-svn-id: http://core.svn.wordpress.org/trunk@31081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:15:22 +00:00
Scott Taylor
4feecb922c
Use `&&` instead of `and` in the 3 places where `and` was used.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31099
git-svn-id: http://core.svn.wordpress.org/trunk@31080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:12:22 +00:00
Helen Hou-Sandí
bc7cc3bb12
Collapse additional avatar settings if avatars are disabled.
...
props markjaquith, krogsgard, valendesigns.
fixes #30168 .
Built from https://develop.svn.wordpress.org/trunk@31095
git-svn-id: http://core.svn.wordpress.org/trunk@31076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 17:01:24 +00:00
Scott Taylor
383a5c6c24
In `wp-includes/plugin.php`, collapse 3 `else-newline-tab-if` statements.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31091
git-svn-id: http://core.svn.wordpress.org/trunk@31072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:13:24 +00:00
Scott Taylor
60b0cd7943
The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.
...
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31090
git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:05:25 +00:00
Dion Hulse
a4ed093250
Enable Pretty Permalinks for new sites during install if the server supports it.
...
See #6481 , Props valendesigns, DrewAPicture & ericlewis
Built from https://develop.svn.wordpress.org/trunk@31089
git-svn-id: http://core.svn.wordpress.org/trunk@31070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:47:23 +00:00
Scott Taylor
ac4e67b82e
Perl-style comments should not be used
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31079
git-svn-id: http://core.svn.wordpress.org/trunk@31060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:52:24 +00:00
Scott Taylor
e029005847
Access Modifiers:
...
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31078
git-svn-id: http://core.svn.wordpress.org/trunk@31059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:44:23 +00:00
Scott Taylor
ff98cfcf45
Pinking Shears.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31077
git-svn-id: http://core.svn.wordpress.org/trunk@31058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:03:23 +00:00
Sergey Biryukov
9b0e279e82
In dashboard activity widget, display a front-end link if the user cannot edit the post.
...
props UaMV, DrewAPicture.
fixes #29025 .
Built from https://develop.svn.wordpress.org/trunk@31075
git-svn-id: http://core.svn.wordpress.org/trunk@31056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 00:26:22 +00:00
Sergey Biryukov
f2b5ac8ef1
Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices.
...
props ocean90.
fixes #30827 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31074
git-svn-id: http://core.svn.wordpress.org/trunk@31055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:43:24 +00:00
Sergey Biryukov
f601e45055
TinyMCE: Remove dashicon-no-alt.png, unused since [30694].
...
props kpdesign, MattyRob.
fixes #30791 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31073
git-svn-id: http://core.svn.wordpress.org/trunk@31054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:32:22 +00:00
Sergey Biryukov
da4a8f56f5
Theme install: Display an appropriate string if theme has not been rated yet.
...
props kevdotbadger, valendesigns.
fixes #28147 .
Built from https://develop.svn.wordpress.org/trunk@31072
git-svn-id: http://core.svn.wordpress.org/trunk@31053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:17:22 +00:00
Andrew Ozz
00ff6675a2
Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167 .
...
Built from https://develop.svn.wordpress.org/trunk@31070
git-svn-id: http://core.svn.wordpress.org/trunk@31051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 22:48:22 +00:00
Sergey Biryukov
1c9e1836ac
Remove obsolete help sentence on Edit User screen.
...
fixes #30750 .
Built from https://develop.svn.wordpress.org/trunk@31067
git-svn-id: http://core.svn.wordpress.org/trunk@31048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 08:23:23 +00:00
Dominik Schilling
56981c7143
Customizer: Send JSON success for `customize_save` and allow response to be filtered.
...
props westonruter.
fixes #29098 .
Built from https://develop.svn.wordpress.org/trunk@31062
git-svn-id: http://core.svn.wordpress.org/trunk@31043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 21:47:23 +00:00
Sergey Biryukov
483e7a36d7
Use localized format for Last Updated date on Add Plugins screen.
...
props tyxla.
fixes #30717 .
Built from https://develop.svn.wordpress.org/trunk@31055
git-svn-id: http://core.svn.wordpress.org/trunk@31036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 01:03:23 +00:00
Sergey Biryukov
291de9cac1
Themes: Fix position of admin notice with .notice class.
...
fixes #30895 .
Built from https://develop.svn.wordpress.org/trunk@31054
git-svn-id: http://core.svn.wordpress.org/trunk@31035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 20:06:23 +00:00
Sergey Biryukov
1541bc1537
Pass comment author name and comment ID to 'get_comment_author_link' filter on Edit Comment screen, for consistency with [30092].
...
props tyxla.
fixes #30894 .
Built from https://develop.svn.wordpress.org/trunk@31053
git-svn-id: http://core.svn.wordpress.org/trunk@31034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 19:10:23 +00:00
Scott Taylor
a9302b2e36
If `IMAGE_EDIT_OVERWRITE` is defined as `true`, ensure that multiple edits to the same image does not result in the file being deleted (updating the meta fails because the old and new paths are identical).
...
Props hew.
Fixes #30394 .
Built from https://develop.svn.wordpress.org/trunk@31043
git-svn-id: http://core.svn.wordpress.org/trunk@31024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 02:52:24 +00:00
Scott Taylor
f79eb196df
Improve the handling of comma-separated mime-types in `wp_match_mime_types()`, particularly as pertains to the mime-type selector on the Media list table screen.
...
Props mdgl.
Fixes #30788 .
Built from https://develop.svn.wordpress.org/trunk@31042
git-svn-id: http://core.svn.wordpress.org/trunk@31023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 02:32:22 +00:00
Scott Taylor
ada7442b9e
After [31037], ensure that the library is passed as a map to the Media Grid instance. Remove useless query vars.
...
Fixes #30584 .
Built from https://develop.svn.wordpress.org/trunk@31041
git-svn-id: http://core.svn.wordpress.org/trunk@31022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 02:07:23 +00:00
Scott Taylor
c5f9a7c26a
Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library.
...
Fixes #30584 .
Built from https://develop.svn.wordpress.org/trunk@31037
git-svn-id: http://core.svn.wordpress.org/trunk@31018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 08:24:22 +00:00
Scott Taylor
190165cb32
Use the `'not_found'` label when there are no items for a taxonomy in the terms list table.
...
Props SergeyBiryukov.
Fixes #30586 .
Built from https://develop.svn.wordpress.org/trunk@31035
git-svn-id: http://core.svn.wordpress.org/trunk@31016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 06:20:21 +00:00
Scott Taylor
af0e5cc851
Inline `<script>`s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need `CDATA` comments.
...
Props tw2113 for the initial patch.
See #18788 .
Built from https://develop.svn.wordpress.org/trunk@31034
git-svn-id: http://core.svn.wordpress.org/trunk@31015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 05:46:25 +00:00
Scott Taylor
618c5b4333
When outputting JS with a `Content-Type` header:
...
`text/javascript` is obsolete, `application/x-javascript` was experimental. `application/javascript` is the recommended type per RFC 4329.
Props sergej.mueller.
Fixes #29196 .
Built from https://develop.svn.wordpress.org/trunk@31029
git-svn-id: http://core.svn.wordpress.org/trunk@31010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 02:57:21 +00:00
Andrew Ozz
e0189c3686
Move the (recently added) `.notice` admin notices below the first H2, same as the `.updated` and `.error` notices. Props sippis, fixes #30885 .
...
Built from https://develop.svn.wordpress.org/trunk@31023
git-svn-id: http://core.svn.wordpress.org/trunk@31004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-02 18:52:23 +00:00
Scott Taylor
5e4941023b
`WP_List_Table`'s constructor registers an `'admin_footer'` callback when AJAX is enabled. As such, if you create multiple instances of the class, you get multiple JS blobs on the page when the callbacks fire. Extra instances get made when `wp_comment_reply()` invokes the class constructor without checking for the existing instance via the `$wp_list_table` global.
...
We shall check the `$wp_list_table` global in `wp_comment_reply()`.
Props sorich87.
Fixes #17413 .
Built from https://develop.svn.wordpress.org/trunk@31019
git-svn-id: http://core.svn.wordpress.org/trunk@31000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-01 19:55:35 +00:00
Scott Taylor
952a5c9971
Support chromeless Vimeo via MEjs:
...
* Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops!
* Add `Froogaloop` to `js/mediaelement` scripts for Vimeo
* Check for Vimeo in the same locations that YouTube is checked
* Dynamically load Froogaloop script in admin when editing a TinyMCE view
* Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream):
6f9a78e008/src/js/me-shim.js (L631)
Fixes #29267 .
Built from https://develop.svn.wordpress.org/trunk@31016
git-svn-id: http://core.svn.wordpress.org/trunk@30997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 20:41:24 +00:00
Aaron Jorbin
7ea306dd9d
Set the type attribute of the buttons for logging out of all sessions to buttons
...
By not setting this attribute, the buttons default to submit and as the first
submit button on the page, it causes pressing the enter key to log you out of
all sessions. This change restores the pre 4.1 behavior where pressing enter
while focused on a form field submits the form.
props ocean90
fixes #30871 for trunk
Built from https://develop.svn.wordpress.org/trunk@31010
git-svn-id: http://core.svn.wordpress.org/trunk@30991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 17:33:24 +00:00
Andrew Nacin
bc60e63518
Use correct function name in docs for get_plugin_data().
...
props eliorivero.
fixes #30699 .
Built from https://develop.svn.wordpress.org/trunk@31008
git-svn-id: http://core.svn.wordpress.org/trunk@30989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 08:08:22 +00:00
Boone Gorges
95dba4c8c0
When no plugins are active, return an empty array from `validate_active_plugins()`.
...
This creates parity with the behavior of the function when plugins *are* active,
but none are invalid. It also makes it possible to write unit tests for the
function.
Props sgrant.
Fixes #30860 .
Built from https://develop.svn.wordpress.org/trunk@31003
git-svn-id: http://core.svn.wordpress.org/trunk@30984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-30 19:31:22 +00:00
Boone Gorges
8572a07a25
Fix incorrect `@since` tag introduced in [30998].
...
Props dimadin.
See #25853 .
Built from https://develop.svn.wordpress.org/trunk@30999
git-svn-id: http://core.svn.wordpress.org/trunk@30981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-29 17:18:22 +00:00
Boone Gorges
25e625b9b0
Apply 'taxonomy_parent_dropdown_args' filter when editing terms.
...
Added in WP 3.7 [25123], the 'taxonomy_parent_dropdown_args' filter affected
only the term creation interface. This changeset introduces parity by ensuring
that it is applied when editing terms as well.
The new `$context` parameter indicates whether the filter is being applied in
a 'new' or 'edit' context.
Props TimothyBlynJacobs, DrewAPicture.
Fixes #29853 .
Built from https://develop.svn.wordpress.org/trunk@30998
git-svn-id: http://core.svn.wordpress.org/trunk@30980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-29 15:27:22 +00:00
Dominik Schilling
14abcecf81
Customizer: Use correct event variable when moving widgets to another widget area.
...
Fixes "ReferenceError: event is not defined error." in Firefox.
props tywayne.
fixes #30818 .
Built from https://develop.svn.wordpress.org/trunk@30992
git-svn-id: http://core.svn.wordpress.org/trunk@30974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-23 17:24:24 +00:00
Dominik Schilling
93605deef5
Customizer: Improve IE 8 compatibility.
...
* Use square bracket notation for `default` keywords.
* Use Underscores `indexOf` for arrays.
props westonruter, ocean90.
fixes #30781 for trunk.
Built from https://develop.svn.wordpress.org/trunk@30991
git-svn-id: http://core.svn.wordpress.org/trunk@30973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-23 17:05:26 +00:00
Scott Taylor
bc1341628f
Comment List Tables:
...
* Declare `$extra_items` property
* Since `->get_column_info()` overrides its parent's method, it doesn't need to set `_column_headers`, which is an undeclared property that is only used for caching the lookup after the first run in the parent class, which isn't called in the child class.
* `$_args` in `WP_List_Table` has to be `protected` for `WP_Post_Comments_List_Table` to legally access it. `$_args` is awkward as is and should probably be only available via a getter.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30984
git-svn-id: http://core.svn.wordpress.org/trunk@30970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 23:27:25 +00:00
Scott Taylor
786caa4d55
Correct the `@param` docs for arguments that are truthy/falsey.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30983
git-svn-id: http://core.svn.wordpress.org/trunk@30969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 23:04:23 +00:00
Scott Taylor
5eb5afac34
For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30982
git-svn-id: http://core.svn.wordpress.org/trunk@30968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 22:47:22 +00:00
Scott Taylor
2dbd0d0a8f
In `image_size_input_fields()`:
...
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30981
git-svn-id: http://core.svn.wordpress.org/trunk@30967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 22:19:24 +00:00
Scott Taylor
f19bec8754
In `wp_import_handle_upload()`:
...
`$file` was essentially getting declared/overwritten 3 times. In lieu of this, return an array containing the error immediately instead of doing a short-circuit array key assignment on error. Rename the local variable to `$upload` and use its properties instead of creating 3 new local vars, one of which stomped the array.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30980
git-svn-id: http://core.svn.wordpress.org/trunk@30966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 21:10:24 +00:00
Scott Taylor
42f5acd869
Improve some docs for `@param`. Remove an unneeded `$wpdb` global import.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30979
git-svn-id: http://core.svn.wordpress.org/trunk@30965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 20:56:22 +00:00
Scott Taylor
574fabf2bc
Improve some `wp-admin/includes/class-wp-filesystem-*.php` docs for `@param`.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30978
git-svn-id: http://core.svn.wordpress.org/trunk@30964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 20:40:23 +00:00
Andrew Ozz
6bde00ec42
Editor: when switching editor-expand off for the first time use the default editor height. Props avryl, fixes #30760 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@30977
git-svn-id: http://core.svn.wordpress.org/trunk@30963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 19:33:23 +00:00
Andrew Nacin
a814ef7bcc
About page: CDN images.
...
Built from https://develop.svn.wordpress.org/trunk@30971
git-svn-id: http://core.svn.wordpress.org/trunk@30958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-18 17:55:22 +00:00
Helen Hou-Sandí
e9d3be4d99
Ensure inline code examples stay LTR, punctuation and all.
...
props alex-ye.
see #30748 .
Built from https://develop.svn.wordpress.org/trunk@30952
git-svn-id: http://core.svn.wordpress.org/trunk@30940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-17 16:22:22 +00:00
Helen Hou-Sandí
b25e4524fc
About page: Don't allow tab text to wrap.
...
Some language, browser, and OS combinations (notably Arabic, Chrome, and Windows) were wrapping.
see #30743 .
Built from https://develop.svn.wordpress.org/trunk@30951
git-svn-id: http://core.svn.wordpress.org/trunk@30939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-17 16:02:22 +00:00
Dominik Schilling
626af35acb
About: Fix the WordPress badge.
...
`css-clean` (minifies our CSS) has an issue when using multiple backgrounds and background position together. Instead of relying on browser support for multiple backgrounds to display the WP logo as SVG, use the `.svg` CSS class.
see #30735 .
Built from https://develop.svn.wordpress.org/trunk@30946
git-svn-id: http://core.svn.wordpress.org/trunk@30935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 22:54:21 +00:00
Dominik Schilling
eccd5a5eda
Pass locale to wordpress.org theme/plugin API.
...
In the future this will be used to return localized plugin/theme info.
see #30735 .
Built from https://develop.svn.wordpress.org/trunk@30944
git-svn-id: http://core.svn.wordpress.org/trunk@30933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 22:39:22 +00:00
Andrew Nacin
72083f67cd
Last about page string. props celloexpressions. fixes #30435 .
...
Built from https://develop.svn.wordpress.org/trunk@30929
git-svn-id: http://core.svn.wordpress.org/trunk@30918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 21:27:22 +00:00
John Blackbourn
b43470397d
Make the DFW paragraph on the About page narrower to mitigate an orphan in Firefox.
...
See #30435
Props melchoyce
Built from https://develop.svn.wordpress.org/trunk@30921
git-svn-id: http://core.svn.wordpress.org/trunk@30910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 20:02:23 +00:00
John Blackbourn
9592b26cbe
Move a `<code>` tag out of a localised string on the About page.
...
Props pavelevap
See #30435
Built from https://develop.svn.wordpress.org/trunk@30903
git-svn-id: http://core.svn.wordpress.org/trunk@30893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 14:04:22 +00:00
Andrew Nacin
8c3027c3c7
Call it 'Distraction-free writing mode' and update the help string. fixes #30657 .
...
Built from https://develop.svn.wordpress.org/trunk@30890
git-svn-id: http://core.svn.wordpress.org/trunk@30880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 10:07:23 +00:00
Andrew Nacin
7b015d507d
Update/add plugin recommendation strings.
...
Update [30887], add a translation function to the Vine string.
fixes #30337 . see #30435 .
Built from https://develop.svn.wordpress.org/trunk@30889
git-svn-id: http://core.svn.wordpress.org/trunk@30879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 10:06:24 +00:00
Andrew Nacin
23f4b0f62f
Updates to the 'Log out everywhere' implementation.
...
* Include a message and a disabled button when you're only logged in at one location.
* Avoid leaking the session token in HTML.
* Simplify, simplify, simplify.
see #30264 .
Built from https://develop.svn.wordpress.org/trunk@30888
git-svn-id: http://core.svn.wordpress.org/trunk@30878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 09:15:23 +00:00
Andrew Nacin
6abad25e05
Finalize two more about page strings. see #30435 .
...
Built from https://develop.svn.wordpress.org/trunk@30887
git-svn-id: http://core.svn.wordpress.org/trunk@30877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 08:58:23 +00:00
Dominik Schilling
fcb00b75e2
Customizer: Add `_wp_attachment_is_custom_background` meta to uploaded background images.
...
Adds `$type` property to `WP_Customize_Background_Image_Control` (PHP) and introduces `wp.customize.BackgroundControl` (JS).
see #30707 .
Built from https://develop.svn.wordpress.org/trunk@30885
git-svn-id: http://core.svn.wordpress.org/trunk@30873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 23:28:23 +00:00
Dominik Schilling
824d751879
Autoprefixer for [30857].
...
see #30435 .
Built from https://develop.svn.wordpress.org/trunk@30884
git-svn-id: http://core.svn.wordpress.org/trunk@30872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 23:20:23 +00:00
John Blackbourn
b01740334c
Correct the height of the search type `select` element when searching the plugin directory.
...
See #30719
Props pavelevap, eliorivero
Built from https://develop.svn.wordpress.org/trunk@30879
git-svn-id: http://core.svn.wordpress.org/trunk@30867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 22:32:23 +00:00
Dominik Schilling
4652717828
Customizer: Remove date filter from the Header/Background Image upload frames.
...
Adds an option to `wp.media.view.AttachmentsBrowser` to hide the date filter added in [29813].
see #30689 .
Built from https://develop.svn.wordpress.org/trunk@30872
git-svn-id: http://core.svn.wordpress.org/trunk@30862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 20:27:22 +00:00
Dominik Schilling
d5914fc1c8
Customizer: Import missing `wp.customize.Control.prototype._toggleActive`.
...
Check also if `completeCallback` is set before calling it.
props westonruter.
see #30701 .
Built from https://develop.svn.wordpress.org/trunk@30871
git-svn-id: http://core.svn.wordpress.org/trunk@30861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 19:54:21 +00:00
Dion Hulse
5661464d35
Background Updates: Pass back whether Group Writable support is being leveraged for an update to the WordPress.org API.
...
See #30245
Built from https://develop.svn.wordpress.org/trunk@30860
git-svn-id: http://core.svn.wordpress.org/trunk@30850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 14:08:23 +00:00
Andrew Nacin
58db3173f1
About page design for 4.1.
...
props melchoyce and ryelle, who again outdid themselves.
see #30435 .
Built from https://develop.svn.wordpress.org/trunk@30857
git-svn-id: http://core.svn.wordpress.org/trunk@30847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 10:47:24 +00:00
Andrew Nacin
180c596d7b
Rename _wp_clear_update_cache() to wp_clean_update_cache().
...
This makes it match most cache-clearing functions, including the ones it wraps. Also no need for it to be prefixed as "private."
wp_clean_plugins_cache() doesn't always exist, so as a quick fix, clear the transient we care to clear.
see #30369 .
Built from https://develop.svn.wordpress.org/trunk@30856
git-svn-id: http://core.svn.wordpress.org/trunk@30846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 08:55:22 +00:00
Andrew Nacin
741e0ec6de
No need for wp_get_password_hint() to be prefixed as if it is private.
...
see #21243 .
Built from https://develop.svn.wordpress.org/trunk@30855
git-svn-id: http://core.svn.wordpress.org/trunk@30845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 08:34:23 +00:00
Andrew Ozz
265b83103d
Editor, new DFW: fix fading out for the right sidebar in IE. Fixes #30714 .
...
Built from https://develop.svn.wordpress.org/trunk@30853
git-svn-id: http://core.svn.wordpress.org/trunk@30843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 03:09:24 +00:00
Andrew Ozz
ee67cd96be
Improve the fix for menu shakiness when over-scrolling. Recalculate heights on editor auto-resize.
...
See #30692 .
Built from https://develop.svn.wordpress.org/trunk@30852
git-svn-id: http://core.svn.wordpress.org/trunk@30842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 00:11:24 +00:00
Dominik Schilling
bb879d101b
Customizer: Re-add the possibility to remove and restore a default background image.
...
see #21483 .
fixes #30683 for trunk.
Built from https://develop.svn.wordpress.org/trunk@30849
git-svn-id: http://core.svn.wordpress.org/trunk@30839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-14 19:37:22 +00:00
Andrew Ozz
910bb84c89
Fix menu shakiness when over-scrolling in Chrome and Safari on MacOS.
...
See #30692 .
Built from https://develop.svn.wordpress.org/trunk@30844
git-svn-id: http://core.svn.wordpress.org/trunk@30834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-14 01:47:23 +00:00
Andrew Ozz
983a743c33
iOS: do not autofocus the readonly textarea with the code for wp-config.php in setup-config.php.
...
See #30703 .
Built from https://develop.svn.wordpress.org/trunk@30843
git-svn-id: http://core.svn.wordpress.org/trunk@30833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-14 00:11:24 +00:00
Andrew Ozz
7cc113ab66
Do not autofocus text fields on page load on mobile devices. This is currently broken in many mobile browsers:
...
- iOS Safari opens the keyboard and auto-scrolls on the first tap anywhere on the screen triggering the click at an unexpected place. That makes it impossible to follow links or press buttons.
- Chrome on iOS opens the keyboard on load and may scroll the focused field off screen.
- The Android 4.4 browser only highlights the field, the user has to tap it to open the keyboard and type.
See #30703 .
Built from https://develop.svn.wordpress.org/trunk@30842
git-svn-id: http://core.svn.wordpress.org/trunk@30832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-13 22:08:23 +00:00
Andrew Nacin
da7d68af53
Finalize more about page strings. see #30435 .
...
Built from https://develop.svn.wordpress.org/trunk@30841
git-svn-id: http://core.svn.wordpress.org/trunk@30831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-13 22:05:22 +00:00
Andrew Nacin
39c97bb5f3
About page updates.
...
* Live-update the number of active translations.
* Finalize most strings.
* Lazily remove links to admin-only screens based on cap checks.
see #30435 .
Built from https://develop.svn.wordpress.org/trunk@30840
git-svn-id: http://core.svn.wordpress.org/trunk@30830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-13 20:12:22 +00:00
Andrew Ozz
bb67aa9d5a
Improve text for the DFW admin pointer. Remove the concatenation.
...
Props kpdesign, ianmjones.
See #30671 .
Built from https://develop.svn.wordpress.org/trunk@30837
git-svn-id: http://core.svn.wordpress.org/trunk@30827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-12 22:12:22 +00:00
Dominik Schilling
e72efb71f0
Revisions: Fix initial state of `compareTwoMode`.
...
Broken since [30131].
fixes #30672 .
Built from https://develop.svn.wordpress.org/trunk@30831
git-svn-id: http://core.svn.wordpress.org/trunk@30821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-12 09:54:25 +00:00
Andrew Ozz
7edc169c7d
Fix search box position on the Add Plugins screen after resizing the window to narrower than 1000px and then back to wider than 1200px. Fixes #30658 .
...
Built from https://develop.svn.wordpress.org/trunk@30830
git-svn-id: http://core.svn.wordpress.org/trunk@30820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-12 00:54:23 +00:00
Andrew Nacin
dc5642c83c
About page, text only (not released for translation), first pass.
...
Design and finalized text to follow. This is just for the RC crowd.
props johnbillion, helen, markjaquith, nacin.
see #30435 .
Built from https://develop.svn.wordpress.org/trunk@30821
git-svn-id: http://core.svn.wordpress.org/trunk@30811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-11 10:16:22 +00:00
Andrew Nacin
5e3e3d0e0f
Editor focus: Don't trigger when typing while the mouse is outside the editor.
...
props avryl.
fixes #20668 .
Built from https://develop.svn.wordpress.org/trunk@30817
git-svn-id: http://core.svn.wordpress.org/trunk@30807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-11 09:34:26 +00:00
Andrew Ozz
0aa0016488
Fix the search field width in the media modal, media library grid and on the install new plugins screen. Props helen, fixes #30658 .
...
Built from https://develop.svn.wordpress.org/trunk@30813
git-svn-id: http://core.svn.wordpress.org/trunk@30803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-11 04:12:23 +00:00
Dominik Schilling
18349e84cf
Remove a stray $ from [30793].
...
props ipm-frommen.
see #30553 .
Built from https://develop.svn.wordpress.org/trunk@30794
git-svn-id: http://core.svn.wordpress.org/trunk@30784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-09 11:27:22 +00:00
Dominik Schilling
332e0a7f82
Themes: Use Customizer deep-links inside the theme modal.
...
props DrewAPicture, ocean90.
see #25569 , #25571 .
fixes #30553 .
Built from https://develop.svn.wordpress.org/trunk@30793
git-svn-id: http://core.svn.wordpress.org/trunk@30783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 22:23:23 +00:00
Sergey Biryukov
0ef8e683f2
Revert [28948], which caused a regression.
...
see #29573 for trunk. see #28350 .
Built from https://develop.svn.wordpress.org/trunk@30791
git-svn-id: http://core.svn.wordpress.org/trunk@30781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 21:14:23 +00:00
Andrew Ozz
a445806c6f
Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337 .
...
Built from https://develop.svn.wordpress.org/trunk@30782
git-svn-id: http://core.svn.wordpress.org/trunk@30772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 23:40:24 +00:00
Drew Jaynes
ced94748fa
Tweak formatting in the DocBlock for the `install_themes_tabs` hook.
...
Props kpdesign.
See #28578 .
Built from https://develop.svn.wordpress.org/trunk@30772
git-svn-id: http://core.svn.wordpress.org/trunk@30762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 18:41:21 +00:00
Andrew Ozz
ef0501e1bc
Better docs for `Plugin_Upgrader::deactivate_plugin_before_upgrade()`. Props DrewAPicture. Fixes #29088 .
...
Built from https://develop.svn.wordpress.org/trunk@30762
git-svn-id: http://core.svn.wordpress.org/trunk@30752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 01:19:24 +00:00
Andrew Ozz
1bb4b6a82b
Always return a value in `Plugin_Upgrader::deactivate_plugin_before_upgrade()`. Props jdgrimes. Fixes #29088 .
...
Built from https://develop.svn.wordpress.org/trunk@30761
git-svn-id: http://core.svn.wordpress.org/trunk@30751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 00:53:23 +00:00
Andrew Ozz
53d22ffb10
Customizer - Widgets: add feedback for screen readers when moving up or down. Props adamsilverstein, afercia. Fixes #28892 .
...
Built from https://develop.svn.wordpress.org/trunk@30760
git-svn-id: http://core.svn.wordpress.org/trunk@30750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 00:45:24 +00:00
Drew Jaynes
473ebca2af
Add missing DocBlocks and parameter descriptions for a wide variety of properties and methods in `WP_Upgrader`, `Plugin_Upgrader`, `Theme_Upgrader`, `Language_Pack_Upgrader`, `Core_Upgrader`, and `File_upload_Upgrader`.
...
Props jdgrimes, DrewAPicture.
See #29086 .
Built from https://develop.svn.wordpress.org/trunk@30758
git-svn-id: http://core.svn.wordpress.org/trunk@30748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 00:26:22 +00:00
Drew Jaynes
bb27a3c53a
Add a blank line preceding a Markdown-formatted ordered list in the DocBlock for the `admin_body_class` filter.
...
Props kpdesign.
See #30558 .
Built from https://develop.svn.wordpress.org/trunk@30756
git-svn-id: http://core.svn.wordpress.org/trunk@30746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 23:21:24 +00:00
Drew Jaynes
cc4ac906dc
Fix a typo in the return description for `get_sample_permalink()`.
...
Props TobiasBg.
Fixes #30591 .
Built from https://develop.svn.wordpress.org/trunk@30755
git-svn-id: http://core.svn.wordpress.org/trunk@30745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:46:23 +00:00
John Blackbourn
bdd00b3902
Improve various hook and filter docs so they are correctly parsed for the code reference.
...
Fixes #30558
Props DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@30754
git-svn-id: http://core.svn.wordpress.org/trunk@30744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:32:24 +00:00
Drew Jaynes
23707b1ada
Convert various uses of `(optional)` in core parameter descriptions to use the style prescribed in the inline documentation standards for PHP.
...
The style for marking parameters optional in inline PHP docs is: `@param type $var Optional. Description. Accepts. Default.`, where Accepts can be omitted on a case-by-case basis.
Props coffee2code.
Fixes #30591 .
Built from https://develop.svn.wordpress.org/trunk@30753
git-svn-id: http://core.svn.wordpress.org/trunk@30743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:24:45 +00:00
Andrew Ozz
79eb593440
Editor DFW v2: fade out the Screen Options/Help tabs when open. Props avryl, fixes #30593 .
...
Built from https://develop.svn.wordpress.org/trunk@30749
git-svn-id: http://core.svn.wordpress.org/trunk@30739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 00:50:22 +00:00
Andrew Ozz
3826c2de6a
Themes screen: fix the position of the search field. Props jesin, fixes #29556 .
...
Built from https://develop.svn.wordpress.org/trunk@30747
git-svn-id: http://core.svn.wordpress.org/trunk@30737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 00:13:23 +00:00
Andrew Ozz
0a199ff4a8
Editor: fix initial state for editor-expand when TinyMCE is disabled or not supported. Props avryl, fixes #30592 .
...
Built from https://develop.svn.wordpress.org/trunk@30743
git-svn-id: http://core.svn.wordpress.org/trunk@30733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-05 01:53:22 +00:00
Andrew Nacin
1cf7a49ffd
Adjust [29806] and revert [29807] to restore placeholder and email copy order.
...
Avoids unnecessarily changing a (large, carefully formatted) translated string from 4.0.
fixes #21089 .
Built from https://develop.svn.wordpress.org/trunk@30742
git-svn-id: http://core.svn.wordpress.org/trunk@30732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-05 01:15:26 +00:00
Helen Hou-Sandí
f5efcf295b
Filter bar: Better field display on smaller screens.
...
props TacoVerdo, jesin.
fixes #29556 and #29495 .
Built from https://develop.svn.wordpress.org/trunk@30740
git-svn-id: http://core.svn.wordpress.org/trunk@30730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 22:23:25 +00:00
John Blackbourn
543f408098
Correct the default value of the `show_split_view` argument for revisions so they are correctly displayed side by side ins
...
tead of inline.
Fixes #24908
Built from https://develop.svn.wordpress.org/trunk@30739
git-svn-id: http://core.svn.wordpress.org/trunk@30729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 14:36:24 +00:00
Scott Taylor
097e4ede58
Add some inline JS docs for Customizer.
...
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30738
git-svn-id: http://core.svn.wordpress.org/trunk@30728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 02:04:22 +00:00
Scott Taylor
82188f74aa
Show title, album, and artist info for audio files displayed in `WP_Customize_Upload_Control()`.
...
See #21483 .
Built from https://develop.svn.wordpress.org/trunk@30737
git-svn-id: http://core.svn.wordpress.org/trunk@30727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 01:59:22 +00:00
Andrew Ozz
1bb20da03b
Update better description of the Screen Options checkbox for DFW v2 and editor-expand. Props johnbillion, kpdesign, fixes #30557 .
...
Built from https://develop.svn.wordpress.org/trunk@30734
git-svn-id: http://core.svn.wordpress.org/trunk@30724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 22:00:29 +00:00
Andrew Ozz
5299e95360
Editor show the DFW v2 pointer for users that have disabled the visual editor. Fixes #30458 .
...
Built from https://develop.svn.wordpress.org/trunk@30730
git-svn-id: http://core.svn.wordpress.org/trunk@30720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 18:18:23 +00:00
Drew Jaynes
8df7115760
Use the correct hash notation syntax for the `WP_Filesystem_Base::dirlist()` DocBlock.
...
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@30722
git-svn-id: http://core.svn.wordpress.org/trunk@30712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 10:11:22 +00:00
Andrew Ozz
04c2e80c03
Update the description of the Screen Options checkbox for turning editor-expand on/off to include DFW v2. Props kpdesign, fixes #30557 .
...
Built from https://develop.svn.wordpress.org/trunk@30718
git-svn-id: http://core.svn.wordpress.org/trunk@30708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 23:23:23 +00:00
Andrew Ozz
71d0c1c977
Update the DFW v2 pointer text. Props kpdesign, DrewAPicture, johnbillion. Fixes #30458 .
...
Built from https://develop.svn.wordpress.org/trunk@30717
git-svn-id: http://core.svn.wordpress.org/trunk@30707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 23:11:24 +00:00
Dominik Schilling
858a51273a
Customizer: Move private helper functions to `wp.customize.utils` so they can be unit tested.
...
Includes unit tests.
props ryankienstra, westonruter.
see #28709 .
Built from https://develop.svn.wordpress.org/trunk@30716
git-svn-id: http://core.svn.wordpress.org/trunk@30706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 22:56:45 +00:00
Dominik Schilling
0826f8ede2
Customizer: Add panel/section type as CSS class to the HTML container.
...
see #28709 .
Built from https://develop.svn.wordpress.org/trunk@30714
git-svn-id: http://core.svn.wordpress.org/trunk@30704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 22:16:23 +00:00
Dominik Schilling
3db8b08686
Customizer: Enhance Background Image/Upload controls.
...
* Adopt the Header Image layout to the Background Image/Upload control.
* Remove templates for interactive audio/video previews. They haven't worked yet.
* Don't show a "Remove" button when the default value is set.
* Avoid calculating of container/placeholder heights which are unrelated to custom headers.
see #21483 .
Built from https://develop.svn.wordpress.org/trunk@30712
git-svn-id: http://core.svn.wordpress.org/trunk@30702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 21:55:23 +00:00
Andrew Ozz
f1dcfa9712
Editor: hide the DFW v2 button when editor-expand is off. Fixes #30568 .
...
Built from https://develop.svn.wordpress.org/trunk@30711
git-svn-id: http://core.svn.wordpress.org/trunk@30701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 20:40:22 +00:00
Andrew Ozz
ab2c480d86
Editor, DFW v2: use a 2D transform to force repaint of the admin toolbar, only on `#wp-toolbar`. Fixes calculating the position of the right sidebar on fade-in and removes any performance and stacking implications.
...
Props joemcgill, see #30516 .
Built from https://develop.svn.wordpress.org/trunk@30710
git-svn-id: http://core.svn.wordpress.org/trunk@30700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 20:25:24 +00:00
John Blackbourn
d58c44dc00
Apply a no-op CSS transformation to the admin toolbar (among other elements) in order to trigger hardware acceleration when focus/DFW deactivates. This helps prevent rendering issues seen in browsers on Retina devices.
...
See #30516
Props joemcgill
Built from https://develop.svn.wordpress.org/trunk@30708
git-svn-id: http://core.svn.wordpress.org/trunk@30698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 14:18:27 +00:00
John Blackbourn
e96e165c3a
Prevent scrolling beneath modals on mobile devices by removing overflow from `#wpwrap` when a modal is open.
...
Fixes #29909
Props avryl
Built from https://develop.svn.wordpress.org/trunk@30707
git-svn-id: http://core.svn.wordpress.org/trunk@30697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 08:09:25 +00:00
John Blackbourn
9b9424aa77
Admin help text changes for the General Settings screen, post editing screen, network settings screen, and user editing screen.
...
Fixes #30547
Props kpdesign
Built from https://develop.svn.wordpress.org/trunk@30705
git-svn-id: http://core.svn.wordpress.org/trunk@30695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 05:15:23 +00:00
Drew Jaynes
c4b9da857a
Using let's properly in inline comments lets us move on to more pressing matters of inline documentation.
...
Props trepmal.
Fixes #30570 .
Built from https://develop.svn.wordpress.org/trunk@30703
git-svn-id: http://core.svn.wordpress.org/trunk@30693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 04:43:22 +00:00
John Blackbourn
6f3414ea67
Correct the width of the background vignette in the plugin info modal.
...
Fixes #28229
Built from https://develop.svn.wordpress.org/trunk@30700
git-svn-id: http://core.svn.wordpress.org/trunk@30690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 03:19:22 +00:00
Helen Hou-Sandí
cb5c43df83
Don't over-target buttons in the publish meta box.
...
This selector caused breakage for any custom buttons added.
props ericlewis.
fixes #30035 .
Built from https://develop.svn.wordpress.org/trunk@30698
git-svn-id: http://core.svn.wordpress.org/trunk@30688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 02:35:28 +00:00
John Blackbourn
6fcf4ed3c5
Prevent the deletion of a theme while it has an active child theme.
...
Fixes #29580
Props karpstrucking, jesin
Built from https://develop.svn.wordpress.org/trunk@30697
git-svn-id: http://core.svn.wordpress.org/trunk@30687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 02:21:24 +00:00
Drew Jaynes
ad297dab6d
Correctly capitalize JavaScript throughout core docs.
...
Fixes #30569 .
Built from https://develop.svn.wordpress.org/trunk@30695
git-svn-id: http://core.svn.wordpress.org/trunk@30685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 00:31:22 +00:00
Andrew Ozz
16e54ae8c0
Editor DFW v2: do not fade out on using keyboard shortcuts in TinyMCE (Alt+Shift+letter).
...
Fixes #30539 .
Built from https://develop.svn.wordpress.org/trunk@30693
git-svn-id: http://core.svn.wordpress.org/trunk@30683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 22:53:24 +00:00
Scott Taylor
37a23b2c73
Improve various `@param` docs.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30682
git-svn-id: http://core.svn.wordpress.org/trunk@30672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 02:17:21 +00:00
Scott Taylor
2c32752abd
Improve various `@param` docs for `src/wp-admin/*`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30680
git-svn-id: http://core.svn.wordpress.org/trunk@30670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 01:00:22 +00:00
Scott Taylor
65ab522a51
Improve various `@param` docs for List Tables.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30679
git-svn-id: http://core.svn.wordpress.org/trunk@30669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 00:33:23 +00:00
Scott Taylor
da4c39480f
Improve various `@param` docs for `src/wp-admin/includes/class-wp-filesystem-*.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30678
git-svn-id: http://core.svn.wordpress.org/trunk@30668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 00:13:22 +00:00
Scott Taylor
67417897ec
Improve the `@param` docs for `src/wp-admin/includes/plugin.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30668
git-svn-id: http://core.svn.wordpress.org/trunk@30658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 22:23:23 +00:00
Scott Taylor
562ddb8316
Use `sanitize_mime_type()` instead of `urlencode()` when string-building `<option>` values in `->get_views()` for media list tables.
...
`urlencode()` was introduced in [28553] via _duck and yours truly.
Got weirder after [29625].
Props birgire.
Fixes #30123 .
Built from https://develop.svn.wordpress.org/trunk@30661
git-svn-id: http://core.svn.wordpress.org/trunk@30651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 20:23:23 +00:00
Scott Taylor
9ea224b78f
The menu items for `users.php` and `profile.php` that require the `promote_users` cap should be wrapped in an `is_multisite()` conditional a la `user-new.php`.
...
Props SergeyBiryukov.
Fixes #30526 .
Built from https://develop.svn.wordpress.org/trunk@30659
git-svn-id: http://core.svn.wordpress.org/trunk@30649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 19:18:23 +00:00
Dominik Schilling
15df631e76
Make notices added in [30459] less ugly.
...
see #25569 , #25571 , [30505].
Built from https://develop.svn.wordpress.org/trunk@30657
git-svn-id: http://core.svn.wordpress.org/trunk@30647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 12:21:22 +00:00
Dominik Schilling
773da4a1e5
Update the Iris color picker to version 1.0.7.
...
Includes a fix for multiple pickers on the same page.
Changes: https://github.com/Automattic/Iris/compare/1.0.6...1.0.7
props mattwiebe.
fixes #30537 .
Built from https://develop.svn.wordpress.org/trunk@30650
git-svn-id: http://core.svn.wordpress.org/trunk@30640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 11:44:22 +00:00
Drew Jaynes
2faf449f51
Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/*.
...
Also includes some changes to move hook docs to directly precede hook lines. This is necessary to prevent DocBlock-matching confusion when core is parsed.
Affects DocBlocks for the following hooks:
* `wp_ajax_ . $_REQUEST['action']`
* `wp_ajax_nopriv_ . $_REQUEST['action']`
* `admin_footer- . $GLOBALS['hook_suffix']`
* `admin_head-$hook_suffix`
* `admin_post_nopriv_{$action}`
* `admin_post_{$action}`
* `load- . $page_hook`
* `load- . $plugin_page`
* `load-importer- . $importer`
* `load- . $pagenow`
* `admin_action_ . $_REQUEST['action']`
* `async_upload_{$type}`
* `add_meta_boxes_ . $post_type`
* `{$taxonomy}_pre_edit_form`
* `{$taxonomy}_term_edit_form_tag`
* `{$taxonomy}_edit_form_fields`
* `{$taxonomy}_edit_form`
* `after-{$taxonomy}-table`
* `{$taxonomy}_pre_add_form`
* `{$taxonomy}_term_new_form_tag`
* `{$taxonomy}_add_form_fields`
* `{$taxonomy}_add_form`
* `media_upload_$type`
* `media_upload_$tab`
* `install_plugins_pre_$tab`
* `install_plugins_$tab`
* `install_themes_pre_{$tab}`
* `install_themes_{$tab}`
* `update-core-custom_{$action}`
* `update-custom_{$action}`
* `user_{$name}_label`
See #30552 .
Built from https://develop.svn.wordpress.org/trunk@30649
git-svn-id: http://core.svn.wordpress.org/trunk@30639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 11:42:24 +00:00
Drew Jaynes
78bb3e5ff5
Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.
...
Also adds a few inline `@see` cross-references as they apply.
Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`
See #30552 .
Built from https://develop.svn.wordpress.org/trunk@30648
git-svn-id: http://core.svn.wordpress.org/trunk@30638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 11:28:24 +00:00
Drew Jaynes
9ae5e43ac8
Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/network/*.
...
Affects DocBlocks for the following hooks:
* `network_admin_edit_' . $_GET['action']`
* `network_sites_updated_message_' . $_GET['updated']`
See #30552 .
Built from https://develop.svn.wordpress.org/trunk@30647
git-svn-id: http://core.svn.wordpress.org/trunk@30637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 11:21:22 +00:00
Drew Jaynes
3ceb75bd8e
Specify a type (array) for the `$post_data` parameter in the DocBlock for `wp_autosave()`.
...
Props tillkruess.
See #30508 .
Built from https://develop.svn.wordpress.org/trunk@30645
git-svn-id: http://core.svn.wordpress.org/trunk@30635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 10:01:23 +00:00
Drew Jaynes
e4425165ff
Improve the inline documentation for `image_edit_apply_changes()`.
...
Including:
* Add a correct type (array) for the `$changes` parameter
* Add the `@since` version
* Add proper descriptions for both parameters and the return value.
Props tillkruess for the initial patch.
See #30508 .
Built from https://develop.svn.wordpress.org/trunk@30644
git-svn-id: http://core.svn.wordpress.org/trunk@30634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 09:59:22 +00:00
Drew Jaynes
5977a7e355
Add an entry to the changelog for the `wp_editor_expand` hook denoting that the `$post_type` parameter was added in 4.1.0.
...
See #30458 .
Built from https://develop.svn.wordpress.org/trunk@30643
git-svn-id: http://core.svn.wordpress.org/trunk@30633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 09:51:23 +00:00
Andrew Ozz
760e3e5fbd
Editor: no pointer for DFW v2 when editor-scrolling is not used. Pass `$post_type` in the `wp_editor_expand` filter. See #30458 .
...
Built from https://develop.svn.wordpress.org/trunk@30641
git-svn-id: http://core.svn.wordpress.org/trunk@30631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 06:37:21 +00:00
Drew Jaynes
74175fb08c
Document the `$user_id` parameter added to the 'admin_color_scheme_picker' hook in 3.8.1.
...
Props Ipstenu.
Fixes #30551 .
Built from https://develop.svn.wordpress.org/trunk@30632
git-svn-id: http://core.svn.wordpress.org/trunk@30622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 05:42:23 +00:00
Drew Jaynes
bb380687fa
Add missing DocBlocks for several functions in wp-admin/includes/ms.php.
...
Props dustyf.
See #30483 .
Built from https://develop.svn.wordpress.org/trunk@30630
git-svn-id: http://core.svn.wordpress.org/trunk@30620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 05:06:23 +00:00
Drew Jaynes
3699ea4155
Use the correct type (integer) for the `$menu_id` parameter in the `wp_get_nav_menu_to_edit()` DocBlock.
...
Also properly mark the parameter as optional and specify the default value.
Props jaimieolmstead for the initial patch.
Fixes #30540 .
Built from https://develop.svn.wordpress.org/trunk@30627
git-svn-id: http://core.svn.wordpress.org/trunk@30617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 04:25:23 +00:00
Boone Gorges
c6e752b063
In `get_default_post_to_edit()`, let 'post_name' be passed to filter.
...
Previously, it was being overridden after the default post had been inserted
into the database, making it cumbersome to override with the 'wp_insert_post_data'
filter.
Props danielbachhuber.
Fixes #29847 .
Built from https://develop.svn.wordpress.org/trunk@30626
git-svn-id: http://core.svn.wordpress.org/trunk@30616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-29 19:26:23 +00:00
Andrew Ozz
2808edf7d1
Editor: fix fading out on Escape in DFW v2. props adamsilverstein, fixes #30528 .
...
Built from https://develop.svn.wordpress.org/trunk@30625
git-svn-id: http://core.svn.wordpress.org/trunk@30615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-29 02:45:22 +00:00
Drew Jaynes
4432dc752b
4.1 Docs Audit: Various formatting fixes for inline documentation in class-wp-list-table.php and comment-template.php.
...
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30610
git-svn-id: http://core.svn.wordpress.org/trunk@30600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 11:22:23 +00:00
Drew Jaynes
374ec33767
4.1 Docs Audit: Clarify the DocBlock summary for `network_settings_add_js()` to specify that it's specific to the Network Settings screen.
...
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30603
git-svn-id: http://core.svn.wordpress.org/trunk@30593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 09:09:22 +00:00
Drew Jaynes
659413eb98
4.1 Docs Audit: Document the `$post` global in the DocBlock for `wp_print_revision_templates()`.
...
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30602
git-svn-id: http://core.svn.wordpress.org/trunk@30592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 09:05:23 +00:00
Drew Jaynes
da589fc375
4.1 Docs Audit: Fix a variety of issues with the DocBlock for the `default_page_template_title` filter.
...
Includes hyphenating 'drop-down', ensuring the DocBlock itself is correctly indented, and wraps lines at an appropriate length.
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30601
git-svn-id: http://core.svn.wordpress.org/trunk@30591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 09:00:24 +00:00
Drew Jaynes
5212725fbe
4.1 Docs Audit: Convert a hook reference to an inline `@see` tag in the hook docs for the `image_add_caption_text` filter.
...
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30600
git-svn-id: http://core.svn.wordpress.org/trunk@30590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 08:56:24 +00:00
Drew Jaynes
087fbce9ae
4.1 Docs Audit: Clarify the DocBlock summary for the `edit_form_before_permalink` hook.
...
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30599
git-svn-id: http://core.svn.wordpress.org/trunk@30589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 08:52:23 +00:00
Sergey Biryukov
8c091940a3
When live-updating site title in toolbar, fall back to the site url if the title is empty.
...
props avryl.
see #28682 .
Built from https://develop.svn.wordpress.org/trunk@30597
git-svn-id: http://core.svn.wordpress.org/trunk@30587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 08:12:23 +00:00
Sergey Biryukov
0a8b72866e
Add missing periods to strings introduced in [30333].
...
props DrewAPicture.
see #30264 .
Built from https://develop.svn.wordpress.org/trunk@30596
git-svn-id: http://core.svn.wordpress.org/trunk@30586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 06:26:22 +00:00
Drew Jaynes
a899bbaee7
Improve inline documentation in `wp_ajax_destroy_sessions()`.
...
If the token is set (`$keep` is a string), this means the user is viewing their own profile-editing screen and destroying their own sessions (except the current one). If it isn't set (`$keep` is null), the user is editing another user's profile and destroying all of their sessions with no exceptions.
See #30264 , #30469
Built from https://develop.svn.wordpress.org/trunk@30595
git-svn-id: http://core.svn.wordpress.org/trunk@30585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 03:48:22 +00:00
Andrew Ozz
9a4a968172
Editor: move the DFW v2 transitions CSS from editor.css to wp-admin.css. They are needed only on the Edit Post screen.
...
See #30453 .
Built from https://develop.svn.wordpress.org/trunk@30594
git-svn-id: http://core.svn.wordpress.org/trunk@30584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 02:36:23 +00:00
Andrew Ozz
9e8f2c7794
Editor: use the Alt+Shift+W keyboard shortcut for new DFW from both the Visual and Text editors. Props afercia, fixes #30450 .
...
Built from https://develop.svn.wordpress.org/trunk@30593
git-svn-id: http://core.svn.wordpress.org/trunk@30583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 01:44:22 +00:00
Andrew Ozz
9597159393
Better error message when the admin is ssl and non-ssl oEmbed previews are not available in the editor. Props Japh, fixes #30533 .
...
Built from https://develop.svn.wordpress.org/trunk@30591
git-svn-id: http://core.svn.wordpress.org/trunk@30581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-27 22:37:24 +00:00
Andrew Ozz
4d651b90bb
Editor: limit scrolling triggered when TinyMCE is auto-resized to 100px. Prevents auto-scrolling on page load. Fixes #30515 .
...
Built from https://develop.svn.wordpress.org/trunk@30586
git-svn-id: http://core.svn.wordpress.org/trunk@30576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-27 01:00:25 +00:00
Dominik Schilling
184d327ff4
Network Admin: Improve width of input fields on Add New Site and Edit Site screens.
...
props honeysilvas.
fixes #16383 .
Built from https://develop.svn.wordpress.org/trunk@30578
git-svn-id: http://core.svn.wordpress.org/trunk@30568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 19:51:23 +00:00
Andrew Ozz
97c81c4507
Editor: add a pointer for the new DFW button. Remove the wp350_media and wp360_revisions pointers from the same screens. See #30458 .
...
Built from https://develop.svn.wordpress.org/trunk@30574
git-svn-id: http://core.svn.wordpress.org/trunk@30564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 02:54:25 +00:00
Andrew Ozz
af1e417d4e
Editor:
...
- Add CSS reset for the TinyMCE fullscreen mode when used on the Edit Post screen.
- Fix loading of the old and new DFW buttons, use another arg. passed to WP_Editors.
- Reset editor-expand when exiting TinyMCE fullscreen mode.
Fixes #30453 .
Built from https://develop.svn.wordpress.org/trunk@30573
git-svn-id: http://core.svn.wordpress.org/trunk@30563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-26 02:50:24 +00:00
Andrew Ozz
0517ee7c6e
TwentyFifteen:
...
- Fix image caption alignment in the editor.
- Remove unused var from functions.js.
Also includes few images that were shrunk a bit when running grunt precommit.
Fixes #30493 .
Built from https://develop.svn.wordpress.org/trunk@30562
git-svn-id: http://core.svn.wordpress.org/trunk@30551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 06:12:22 +00:00
Dominik Schilling
f5e4c9ee04
Improve the focus style for review links in the plugin info modal.
...
props johnbillion.
fixes #30375 .
Built from https://develop.svn.wordpress.org/trunk@30555
git-svn-id: http://core.svn.wordpress.org/trunk@30544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 22:59:21 +00:00
Dominik Schilling
e39c43ad6c
Clear update caches when site language is changed.
...
The update screen has a re-install button which could show the wrong language locale after the site language was changed. That's because the update data is cached.
Introduce `_wp_clear_update_cache()` as a helper function to clean up the update cache.
props SergeyBiryukov, ocean90.
fixes #30369 .
Built from https://develop.svn.wordpress.org/trunk@30554
git-svn-id: http://core.svn.wordpress.org/trunk@30543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 22:50:22 +00:00
Dominik Schilling
d187a5eeba
Customizer: Don't override `Section.isContextuallyActive()` in `SidebarSection`.
...
This fixes a bug where empty widget areas get deactivated in the Customizer.
fixes #30378 .
see #30235 .
props westonruter.
Built from https://develop.svn.wordpress.org/trunk@30552
git-svn-id: http://core.svn.wordpress.org/trunk@30541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 22:26:23 +00:00
Dominik Schilling
aace02c0c0
Update the Iris color picker to version 1.0.6.
...
Changes: https://github.com/Automattic/Iris/compare/1.0.4...1.0.6
props mattwiebe.
fixes #30365 .
Built from https://develop.svn.wordpress.org/trunk@30551
git-svn-id: http://core.svn.wordpress.org/trunk@30540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 22:17:22 +00:00
Drew Jaynes
4b6abbaff4
Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
...
Affects DocBlocks for the following core elements:
* Backtick-escape code snippets in the description for `get_object_taxonomies()`
* Backtick-escape inline code in a markdown-formatted unordered list in the description for `get_taxonomy_labels()`
* Remove an HTML tag from the summary for the `Walker_Category_Checklist` class
* Remove an HTML tag from the summary for `wp_category_checklist()`, various formatting
* Remove an HTML tag from the summary for `wp_terms_checklist()`
* Backtick-escape an HTML tag in the description for `wp_popular_terms_checklist()`
* Remove HTML tags from the summaries for `page_template_dropdown()`, `parent_dropdown()`, and `wp_dropdown_roles()`
* Backtick-escape HTML tags in a parameter description for `add_settings_error()`
* Various formatting in the description and summary for `settings_errors()`
* Markdown-indent code snippets in the descriptions for `wpdb::prepare()`, `wpdb::insert()`, `wpdb::replace()`, `wpdb::update()`, and `wpdb::delete()`
* Backtick-escape an HTML tag in a parameter description for `login_header()`
* Remove HTML tags from the summaries for the `lostpassword_form` and `signup_header` hooks
Props rarst.
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30546
git-svn-id: http://core.svn.wordpress.org/trunk@30535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 06:31:21 +00:00
Drew Jaynes
188e47869f
Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
...
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `wp_salt()`
* Backtick-escape inline code in the return description for `get_avatar()`
* Various markdown formatting in the description for `add_filter()`
* Markdown-indent a code snippet in the description for `apply_filters()`
* Backtick-escape inline code in the `@see` description for `apply_filters_ref_array()`
* Backtick-escape inline code in the description for `do_action()`
* Backtick-escape variables in the parameter and return descriptions for `do_action_ref_array()`
* Various markdown formatting in the description for `get_plugin_data()`
Props rarst.
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30544
git-svn-id: http://core.svn.wordpress.org/trunk@30533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 06:05:23 +00:00
Drew Jaynes
9955384dbe
Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
...
Affects DocBlocks for the following core elements:
* Backtick-escape an HTML tag in the description for the `media_upload_mime_type_links()` hook
* Backtick-escape inline code in the description for `wp_get_active_network_plugins()`
* Remove HTML tags from the summaries for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks
* Backtick-escape HTML tags, add inline `@see` tags to parameter descriptions for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks
Props rarst.
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30543
git-svn-id: http://core.svn.wordpress.org/trunk@30532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:53:22 +00:00
Drew Jaynes
b8c612ca1c
Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
...
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the file header for wp-admin/install-helper.php
* Add markdown formatting and two inline `@see` tags to the description for `translate()`
* Markdown-indent a code snippet in the description for `_n_noop()`
* Remove HTML tags from the summary for `get_media_embedded_in_content()`
* Remove an HTML tag from the summary for `wpview_media_sandbox_styles()`
Props rarst.
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30542
git-svn-id: http://core.svn.wordpress.org/trunk@30531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:47:23 +00:00
Drew Jaynes
07c58f5cca
Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
...
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `_deprecated_argument()`
* Markdown-indent a code snippet in the description for `wp_localize_script()`
* Backtick-escape HTML tags in two parameter descriptions for `wp_register()`
* Various DocBlock formatting in the description for `get_bloginfo()`
* Remove HTML tag from the summary for `_wp_render_title_tag()`
* Backtick-escape a HTML tag in the description for `get_archives_link()`
* Markdown-indent a code snippet in the description for `wp_admin_css_color()`
* Markdown-indent a code snippet in the description for the `welcome_panel` hook
Props rarst.
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30541
git-svn-id: http://core.svn.wordpress.org/trunk@30530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:39:22 +00:00
Drew Jaynes
cc68de7006
Ensure the DocBlock directly precedes the hook line for the `post_edit_form_tag` action in wp-admin/edit-form-advanced.php.
...
This fixes the parser getting confused about which DocBlock belongs to which hook or function in this file.
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30539
git-svn-id: http://core.svn.wordpress.org/trunk@30528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:22:23 +00:00
Drew Jaynes
de809a5a86
Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
...
Affects DocBlocks for the following core elements:
* Remove HTML tag from parameter description in `comment_form()`
* Remove HTML tag from a summary for the `comment_form_top` hook
* Markdown-indent a code snippet in the description for `get_linkobjectsbyname()`
* Markdown-indent a code snippet and format an unordered list in the description for `get_linkobjects()`
* Backtick-escape some inline code in the description for `clean_pre()`
* Remove HTML tag from the summary for the `rss_tag_pre` hook
* Various formatting fixes in the descriptions for `get_filesystem_method()` and `request_filesystem_credentials()`
Props rarst for the initial patch.
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30538
git-svn-id: http://core.svn.wordpress.org/trunk@30527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:19:23 +00:00
Drew Jaynes
273396fe1e
Ensure inline code is markdown-escaped as such, and that code snippets in descriptions are properly indented.
...
Affects DocBlocks for the following core elements:
* Backtick-escapes a `<link>` tag in a parameter description for the `embed_oembed_discover` hook
* Inline code fixes in the summary and return description for `WP_List_Table::get_table_classes()`
* Removes HTML markup from the summary for `WP_List_Table::display_rows_or_placeholder()`
* Backtick-escapes a `<tr>` tag in a parameter description for `WP_Users_List_Table::single_row()`
* Converts non-DocBlocks into multi-line comments in `WP_Dependencies::do_items()`
* Removes HTML markup from the summary for the `comment_form_top` hook.
* Inline code and snippet fixes in the description for `wp_get_schedules()`
Props rarst for the initial patch.
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30537
git-svn-id: http://core.svn.wordpress.org/trunk@30526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 04:58:22 +00:00
Drew Jaynes
6d0cdd7148
Remove HTML `<head>` tags from DocBlock summaries in wp-admin/admin-header.php.
...
Also better-specify the `$hook_suffix` value in the `admin_head-$hook_suffix` hook docs per hook documentation precedent.
Props rarst for the initial patch.
See #30473
Built from https://develop.svn.wordpress.org/trunk@30535
git-svn-id: http://core.svn.wordpress.org/trunk@30524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 04:27:23 +00:00
Andrew Ozz
e8a4452f05
Color Schemes: fix the pointer UP arrow color, fixes #30460 .
...
Built from https://develop.svn.wordpress.org/trunk@30531
git-svn-id: http://core.svn.wordpress.org/trunk@30520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-23 01:26:23 +00:00
John Blackbourn
78367f22d5
Abstract the theme browser route paths into attributes so they can be easily overridden.
...
Fixes #30116
Props matveb
Built from https://develop.svn.wordpress.org/trunk@30508
git-svn-id: http://core.svn.wordpress.org/trunk@30497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 17:30:22 +00:00
Helen Hou-Sandí
97b412af37
Admin notices: Add more variety and make more generically usable.
...
There is now a base class of `notice`, with additional classes of `notice-success`, `notice-warning`, `notice-error`, and a new blue `notice-info`.
Also corrects some misleading notice colors, such as plugin tested up to warnings and login messages.
props avryl, melchoyce.
fixes #27418 .
Built from https://develop.svn.wordpress.org/trunk@30505
git-svn-id: http://core.svn.wordpress.org/trunk@30494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 16:41:25 +00:00
Helen Hou-Sandí
c83f96ec61
Sessions UI: Ensure screen readers provide feedback on action taken.
...
Also fixes some invalid HTML that occurs on DOM changes.
props joedolson.
fixes #30364 .
Built from https://develop.svn.wordpress.org/trunk@30504
git-svn-id: http://core.svn.wordpress.org/trunk@30493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 16:25:23 +00:00
Drew Jaynes
b0db6e6deb
Convert `<title>` to "title tag" in the DocBlock summary for the `admin_title` hook.
...
Fixes #30437 .
Built from https://develop.svn.wordpress.org/trunk@30502
git-svn-id: http://core.svn.wordpress.org/trunk@30491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 07:12:23 +00:00
Sergey Biryukov
aad05ece16
Set min-height for menu item title. Add a fallback for empty-titled items.
...
props philiparthurmoore.
fixes #30283 .
Built from https://develop.svn.wordpress.org/trunk@30500
git-svn-id: http://core.svn.wordpress.org/trunk@30489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 05:57:22 +00:00
Drew Jaynes
a6fc2d610b
Minor syntactical adjustments to the inline documentation for the `revision_text_diff_options` hook.
...
Converts backticked-inline-code to inline `@see` tags (for the full benefit of Code Reference automagical behavior).
See [30396]. See #24908 .
Built from https://develop.svn.wordpress.org/trunk@30497
git-svn-id: http://core.svn.wordpress.org/trunk@30486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 03:50:24 +00:00
Dominik Schilling
cffba3c1ba
Customizer: Use deep-links for Backgrounds, Headers, and Widgets.
...
Replace links in admin menu and toolbar to Custom Background/Header screen with deep-links to the Customizer section.
On the Widgets screen display a link to the Customizer widgets panel.
props topher1kenobe, rzen, celloexpressions, westonruter
fixes #25569 , #25571 , #28032 .
Built from https://develop.svn.wordpress.org/trunk@30459
git-svn-id: http://core.svn.wordpress.org/trunk@30450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 15:29:23 +00:00
Andrew Nacin
58dfcb9bb0
Validate image data.
...
Built from https://develop.svn.wordpress.org/trunk@30458
git-svn-id: http://core.svn.wordpress.org/trunk@30449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 15:25:22 +00:00
Andrew Nacin
432e4dcb50
Press This: Ensure the error message is printed. props johnbillion
...
Built from https://develop.svn.wordpress.org/trunk@30438
git-svn-id: http://core.svn.wordpress.org/trunk@30433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 13:58:23 +00:00
Jeremy Felt
3a7b5748eb
Prevent wpmu_delete_blog from removing the wrong uploads directory
...
`wp_upload_dir()` includes some logic to fall back to the default site's upload directory if a specific directory for the requested site cannot be found. Because of this, if `wpmu_delete_blog()` is fired twice in a row for the same site, the main site's upload directory could be deleted as well.
This adds some checks in `wpmu_delete_blog()` so that we are confident in the site and it's upload directory's existence before dropping the site. Tests are added for when `ms_files_rewriting` is enabled or disabled.
Fixes #30121
Built from https://develop.svn.wordpress.org/trunk@30404
git-svn-id: http://core.svn.wordpress.org/trunk@30399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 06:53:22 +00:00
John Blackbourn
3e3c383e79
Introduce two new filters to the post revisions screen:
...
* `process_text_diff_html` for contextually filtering a diffed line. Allows for the line to be processed in a different manner to the default `htmlspecialchars`.
* `revision_text_diff_options` for filtering the options passed to `wp_text_diff()` when viewing a post revision.
Fixes #24908
Props adamsilverstein
Built from https://develop.svn.wordpress.org/trunk@30396
git-svn-id: http://core.svn.wordpress.org/trunk@30392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 23:21:23 +00:00
Helen Hou-Sandí
ad646bc183
Accessibility: hide admin menu separators from screen readers.
...
props afercia. fixes #30010 .
Built from https://develop.svn.wordpress.org/trunk@30393
git-svn-id: http://core.svn.wordpress.org/trunk@30389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 19:37:21 +00:00
Dion Hulse
9b9289e0a3
Background Updates: Introduce support to take advantage of Group Writable (or World Writable) to Core Background updates.
...
This is only enabled when new files will not be installed during the update (as indicated by the WordPress.org API), and does not apply to Plugin/Theme/Translation Background Updates.
Additionally, the code to determine if the 'direct' filesystem transport should be used has been tweaked for wider support (where getmyuid() was unavailalbe) which fixes #10424
See #10205 , #30245
Built from https://develop.svn.wordpress.org/trunk@30384
git-svn-id: http://core.svn.wordpress.org/trunk@30381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 05:40:23 +00:00
Drew Jaynes
6b83230aa5
Fix parameter description syntax for `WP_Screen::get_option()`.
...
Props zrothauser for the initial patch.
See [30368]. Fixes #30363 .
Built from https://develop.svn.wordpress.org/trunk@30369
git-svn-id: http://core.svn.wordpress.org/trunk@30367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-17 17:11:23 +00:00
Drew Jaynes
bc054387d9
Add a missing `@return` description for `WP_Screen::get_option()`.
...
Also declare the default value for the `$key` parameter.
Props dustyf for the initial patch.
Fixes #30363 .
Built from https://develop.svn.wordpress.org/trunk@30368
git-svn-id: http://core.svn.wordpress.org/trunk@30366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-17 17:08:21 +00:00
John Blackbourn
cd99d5915f
Decode the sample permalink shown to the user. This avoids showing encoded non-Latin characters in the sample permalink.
...
Fixes #16496
Props linuxologos
Built from https://develop.svn.wordpress.org/trunk@30364
git-svn-id: http://core.svn.wordpress.org/trunk@30363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-17 03:00:21 +00:00
John Blackbourn
7cdbac53e8
Add a filter to the displayed title of the default page template.
...
Fixes #27178
Props johnstonphilip
Built from https://develop.svn.wordpress.org/trunk@30360
git-svn-id: http://core.svn.wordpress.org/trunk@30359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 19:32:24 +00:00
John Blackbourn
d88ed475b0
Switch to a `403` response code in places where it is more appropriate than a `500` due to permissions errors.
...
Fixes #10551
Props nacin
Built from https://develop.svn.wordpress.org/trunk@30356
git-svn-id: http://core.svn.wordpress.org/trunk@30355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 06:16:22 +00:00
John Blackbourn
fd15794b5c
Add some specific JSON responses when there are user permission errors for AJAX file uploads. Replace some usage of `wp_json_encode()` with `wp_send_json_*()`.
...
See #25849
Props gcorne
Built from https://develop.svn.wordpress.org/trunk@30354
git-svn-id: http://core.svn.wordpress.org/trunk@30353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 05:47:21 +00:00
John Blackbourn
a005e0b11b
Display a faux revision when a post only has one revision but has an autosave.
...
Fixes #29044
Props adamsilverstein
Built from https://develop.svn.wordpress.org/trunk@30353
git-svn-id: http://core.svn.wordpress.org/trunk@30352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 03:36:23 +00:00
John Blackbourn
afd0dd5ece
Avoid adjusting the current submenu position when tabbing through the admin menu.
...
Fixes #30349
Props 5um17
Built from https://develop.svn.wordpress.org/trunk@30352
git-svn-id: http://core.svn.wordpress.org/trunk@30351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 02:22:21 +00:00
Andrew Ozz
015f786f27
Editor: enable spellchecking of the post title field on the Edit Post screen. Props marsjaninzmarsa, fixes #30338 .
...
Built from https://develop.svn.wordpress.org/trunk@30350
git-svn-id: http://core.svn.wordpress.org/trunk@30349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-15 01:43:21 +00:00
Gary Pendergast
e61bebdbfc
If a saving a post fails, remove any invalid characters (such as emoji) from the primary text fields, then try to save it again.
...
See #21212 .
Built from https://develop.svn.wordpress.org/trunk@30346
git-svn-id: http://core.svn.wordpress.org/trunk@30345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 21:34:22 +00:00
Dominik Schilling
fe63317dad
Sync our jQuery UI styles with jQuery UI 1.11.2 CSS.
...
Removes also our own implementations for touch-action compatibility for IE Touch.
props georgestephanis, ocean90.
fixes #26843 .
Built from https://develop.svn.wordpress.org/trunk@30343
git-svn-id: http://core.svn.wordpress.org/trunk@30342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-14 19:28:22 +00:00
Mark Jaquith
7c4b9419f4
Introduce Distraction-Free Writing v2, a re-think of DFW that uses the main editor instance
...
* the "DFW" button is now an auto/off toggle
* defaulting to auto during beta, decide later for release
* "auto" means that DFW gets enabled as you start typing in editor
* tabbing and mousing out will bring the full interface back
* there is a slight grace period during which your mouse can quickly return
Feature plugin work happened here: https://github.com/avryl/focus
props avryl, azaozz, Michael Arestad
fixes #29806
Built from https://develop.svn.wordpress.org/trunk@30338
git-svn-id: http://core.svn.wordpress.org/trunk@30337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 22:31:22 +00:00
Dominik Schilling
8fb6f317ff
Site Language: Install translations on the fly.
...
The language dropdown now includes installed languages and all available translations when the filesystem is writable by WordPress.
Go to wp-admin/options-general.php, select one of the available translations, submit the form and let WordPress handle the rest.
Works for Multisite's Default Language too.
see #29395 .
Built from https://develop.svn.wordpress.org/trunk@30335
git-svn-id: http://core.svn.wordpress.org/trunk@30334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 17:01:24 +00:00
Dominik Schilling
4a1cb796fc
Improvements to [30333]:
...
* Move `.hide-if-no-js` class to table row
* Add a wrapper class
* Add missing translators comment
see #30264 .
Built from https://develop.svn.wordpress.org/trunk@30334
git-svn-id: http://core.svn.wordpress.org/trunk@30333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 15:54:20 +00:00
John Blackbourn
c02845330e
Introduce a button on the user profile screen which clears all other sessions, and on the user editing screen which clears all sessions. Only appears when there are applicable sessions which can be cleared.
...
See #30264 .
Props jorbin, ocean90, johnbillion
Built from https://develop.svn.wordpress.org/trunk@30333
git-svn-id: http://core.svn.wordpress.org/trunk@30332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 15:21:21 +00:00
Dominik Schilling
f93a197089
Fix selector for the "Live Widget Previews" feature pointer.
...
props rzen.
fixes #30158 .
Built from https://develop.svn.wordpress.org/trunk@30332
git-svn-id: http://core.svn.wordpress.org/trunk@30331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:50:22 +00:00
Dominik Schilling
b8bfbf42e6
Color Picker: Allow to override `mode` and `width` values for Iris via wpColorPicker options.
...
props jtsternberg.
fixes #30182 .
Built from https://develop.svn.wordpress.org/trunk@30330
git-svn-id: http://core.svn.wordpress.org/trunk@30329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:34:23 +00:00
Dominik Schilling
41197a7c31
Customizer: Improve ability to filter active state for widget area Customizer sections.
...
* Mark panels, sections, controls as active if preview explicitly indicates.
* Introduce `WP_Customize_Sidebar_Section` PHP class, and `SidebarSection` JS class.
* Move logic for determining whether a sidebar section is active from the `SidebarControl` to `SidebarSection`.
props westonruter.
fixes #30235 .
Built from https://develop.svn.wordpress.org/trunk@30329
git-svn-id: http://core.svn.wordpress.org/trunk@30328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:19:23 +00:00
Dominik Schilling
120cb5e6ef
Improve keyboard accessibility on Custom Header and Custom Background screen.
...
props florianziegler.
fixes #29289 .
Built from https://develop.svn.wordpress.org/trunk@30327
git-svn-id: http://core.svn.wordpress.org/trunk@30326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:00:57 +00:00
Helen Hou-Sandí
06201646c3
Use a brighter blue against dark backgrounds in the admin menu and toolbar.
...
Not only does this pass contrast guidelines, but it also visually appears closer to the original highlight blue used against light backgrounds.
props melchoyce. fixes #30323 .
Built from https://develop.svn.wordpress.org/trunk@30313
git-svn-id: http://core.svn.wordpress.org/trunk@30312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 20:28:22 +00:00
Dion Hulse
e17d09f233
PHP 5.2 compatibility for [30310], __DIR__ wasn't added until PHP 5.3. Props TobiasBg. Fixes #29628
...
Built from https://develop.svn.wordpress.org/trunk@30311
git-svn-id: http://core.svn.wordpress.org/trunk@30310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 10:44:23 +00:00
Dion Hulse
3e702d8b52
Always use a full filesystem path when including the FTP handler in PemFTP. This prevents other files in the includes directory being scanned/included accidentally.
...
See #29628
Built from https://develop.svn.wordpress.org/trunk@30310
git-svn-id: http://core.svn.wordpress.org/trunk@30309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 03:06:23 +00:00
Dominik Schilling
6d83c8c29e
Customizer: Add support for the media library in Background Image controls.
...
`WP_Customize_Upload_Control` (PHP) and `api.UploadControl` (JS) can now open the media modal.
props celloexpressions, and ericlewis for docs.
see #21483 .
Built from https://develop.svn.wordpress.org/trunk@30309
git-svn-id: http://core.svn.wordpress.org/trunk@30308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 23:52:22 +00:00
Dominik Schilling
8b32164b67
Customizer: Trigger `widget-added` event when initializing.
...
Widget controls are now added to the pane dynamically via JavaScript, see #28709 .
Remove the event trigger from `SidebarControl.addWidget()` as it's covered by `WidgetControl.ready()`.
props westonruter.
fixes #30236 .
Built from https://develop.svn.wordpress.org/trunk@30308
git-svn-id: http://core.svn.wordpress.org/trunk@30307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 22:46:23 +00:00
Dominik Schilling
d21799ee1f
Customizer: Use `jQuery.fn.toggle()` instead of `slideUp`/`slideDown` if panel/section/control is not inserted into DOM yet.
...
jQuery does nothing when calling `slideUp` on elements that are not inserted into the DOM yet, which can now be the case now when first loading the Customizer as the panels, sections and controls get dynamically inserted, see #28709 .
props westonruter.
fixes #30251 .
Built from https://develop.svn.wordpress.org/trunk@30307
git-svn-id: http://core.svn.wordpress.org/trunk@30306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 22:37:22 +00:00
Dominik Schilling
b250062311
Customizer: When navigating around the site within the Customizer preview, update the document title.
...
props westonruter.
fixes #28542 .
Built from https://develop.svn.wordpress.org/trunk@30306
git-svn-id: http://core.svn.wordpress.org/trunk@30305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 22:29:23 +00:00
Drew Jaynes
92c153aa8c
Fix the syntax for some status-related documentation introduced in [30155].
...
* Variables in DocBlocks should be backtick-escaped
* Parameter and return types should be as specific as possible
* `@param` types and variables should align with each other, but not intentionally with the `@return` description
See #30230 .
Built from https://develop.svn.wordpress.org/trunk@30284
git-svn-id: http://core.svn.wordpress.org/trunk@30284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:56:22 +00:00
Scott Taylor
2d1080aed1
Improve `wp.Uploader` documentation.
...
Props ericlewis.
See #30260 .
Built from https://develop.svn.wordpress.org/trunk@30244
git-svn-id: http://core.svn.wordpress.org/trunk@30244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 19:37:23 +00:00
Drew Jaynes
7d56be8521
Ensure the requires for the admin bootstrap are documented in all wp-admin/user/ files.
...
Props NikV for the initial patch.
Fixes #29111 .
Built from https://develop.svn.wordpress.org/trunk@30228
git-svn-id: http://core.svn.wordpress.org/trunk@30228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 16:32:22 +00:00
Drew Jaynes
7081b906f4
Fix a couple of typos in the hook documentation for the `$option` filter in wp-admin/includes/class-wp-list-table.php.
...
Props bobbingwide.
Fixes #30229 .
Built from https://develop.svn.wordpress.org/trunk@30227
git-svn-id: http://core.svn.wordpress.org/trunk@30227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 16:05:22 +00:00
Drew Jaynes
256bea185d
Add parameter and return descriptions to the `WP_List_Table::get_pagination_arg()` DocBlock.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30225
git-svn-id: http://core.svn.wordpress.org/trunk@30225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 15:55:23 +00:00
Dominik Schilling
73b4f6f449
Customizer: Add stable sorting for panels, sections and controls in JS. Improve sorting in PHP.
...
props westonruter.
fixes #30225 .
Built from https://develop.svn.wordpress.org/trunk@30214
git-svn-id: http://core.svn.wordpress.org/trunk@30214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:35:23 +00:00
Scott Taylor
5e3a64e83d
Correct some types in `wp-admin/*`-location files' doc blocks.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30203
git-svn-id: http://core.svn.wordpress.org/trunk@30203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 07:09:23 +00:00
Scott Taylor
7d7a8aa0eb
Correct all `@return unknown` instances.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30202
git-svn-id: http://core.svn.wordpress.org/trunk@30202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:17:22 +00:00
Scott Taylor
bd2521d5ee
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/deprecated.php` (pour one out).
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30201
git-svn-id: http://core.svn.wordpress.org/trunk@30201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:08:22 +00:00
Scott Taylor
196d85a9f6
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/misc.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30200
git-svn-id: http://core.svn.wordpress.org/trunk@30200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:01:24 +00:00
Scott Taylor
37f94bdfd0
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/plugin.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30199
git-svn-id: http://core.svn.wordpress.org/trunk@30199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:59:22 +00:00
Scott Taylor
64167f0845
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/post.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30198
git-svn-id: http://core.svn.wordpress.org/trunk@30198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:55:22 +00:00
Scott Taylor
d9d825db72
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/taxonomy.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30197
git-svn-id: http://core.svn.wordpress.org/trunk@30197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:50:23 +00:00
Scott Taylor
06f49a43a1
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/template.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30196
git-svn-id: http://core.svn.wordpress.org/trunk@30196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:45:24 +00:00
Scott Taylor
5a3256c00b
Fill in the `@param` types for the args for `make_site_theme_from_default()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30195
git-svn-id: http://core.svn.wordpress.org/trunk@30195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:43:21 +00:00
Scott Taylor
ef944e8c19
Fill in the `@param` types for the args for `make_site_theme_from_oldschool()`, which is actually the name of a function?
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30194
git-svn-id: http://core.svn.wordpress.org/trunk@30194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:41:23 +00:00
Scott Taylor
082a1d06ae
Fill in the `@param` types for the args for `dbDelta()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30193
git-svn-id: http://core.svn.wordpress.org/trunk@30193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:40:22 +00:00
Scott Taylor
8eee18ec0e
Fill in types for the `@param`s for `wp_comment_reply()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30190
git-svn-id: http://core.svn.wordpress.org/trunk@30190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:21:22 +00:00
Scott Taylor
0eb038d97b
In `Custom_Image_Header`:
...
* In `->process_default_headers()`, remove check on non-existent `$headers` property. Introduced in [13403].
* Declare `$updated` as a property.
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30187
git-svn-id: http://core.svn.wordpress.org/trunk@30187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:15:22 +00:00
Scott Taylor
a14a4fc9a5
In `Custom_Background`, declare `$updated` as a property.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30186
git-svn-id: http://core.svn.wordpress.org/trunk@30186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:08:22 +00:00
Jeremy Felt
796ceebb25
Use common core syntax for checking DOING_AJAX
...
Our current check for a non truthy `DOING_AJAX` is `! DOING_AJAX`.
props TobiasBg
Fixes #29891
Built from https://develop.svn.wordpress.org/trunk@30177
git-svn-id: http://core.svn.wordpress.org/trunk@30177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-02 02:24:23 +00:00
Scott Taylor
73c8e4cf10
Declare the `$update_count` and `$update_current` properties for `WP_Upgrader`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30171
git-svn-id: http://core.svn.wordpress.org/trunk@30171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:07:23 +00:00
Scott Taylor
3fc8778359
Declare the `$options` property for `WP_Upgrader_Skin`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30170
git-svn-id: http://core.svn.wordpress.org/trunk@30170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:03:22 +00:00
Scott Taylor
4d0f66854a
Fix the return value doc for `WP_List_Table->get_pagination_arg()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30169
git-svn-id: http://core.svn.wordpress.org/trunk@30169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:00:23 +00:00
Scott Taylor
6a109700d0
In `wp_ajax_get_tagcloud()`, bail immediately if `$_POST['tax']` isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - `wp_die()` confuses Scrutinizer.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30168
git-svn-id: http://core.svn.wordpress.org/trunk@30168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:54:22 +00:00
Scott Taylor
a786fb779c
In `wp_ajax_ajax_tag_search()`, bail immediately if `$_GET['tax']` isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - `wp_die()` confuses Scrutinizer.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30167
git-svn-id: http://core.svn.wordpress.org/trunk@30167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:48:22 +00:00
Scott Taylor
e41e38183d
In `customize.php`, check that `$autofocus` is an `array` after running `wp_unslash()` instead of before. This is admittedly to skip a traversable hint in Scrutinizer.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30164
git-svn-id: http://core.svn.wordpress.org/trunk@30164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:17:22 +00:00
Scott Taylor
60b73c589c
Display error message when Media Library upload fails.
...
Props gcorne.
Fixes #29891 .
Built from https://develop.svn.wordpress.org/trunk@30156
git-svn-id: http://core.svn.wordpress.org/trunk@30156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:25:23 +00:00
Scott Taylor
be08f576df
Improve some `post_status`-related documentation.
...
Props ericlewis.
See #30230 .
Built from https://develop.svn.wordpress.org/trunk@30155
git-svn-id: http://core.svn.wordpress.org/trunk@30155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:20:23 +00:00
Scott Taylor
0b9c1be743
In `WP_List_Table`, add a property, `$modes`, to allow `WP_Media_List_Table` to inherit `->view_switcher()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30154
git-svn-id: http://core.svn.wordpress.org/trunk@30154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 19:56:24 +00:00
Boone Gorges
96b42c2fdc
Allow resource_type to be specified in `get_ancestors()`.
...
Being explicit about resource type (taxonomy vs post_type) allows for the
proper resolution of conflicts when a taxonomy and post_type share a slug.
Props filosofo.
Fixes #15029 .
Built from https://develop.svn.wordpress.org/trunk@30141
git-svn-id: http://core.svn.wordpress.org/trunk@30141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 02:58:23 +00:00
Scott Taylor
fcbc7b5a78
In `Custom_Image_Header->step_2()`, `$type` is set internally but never used.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30136
git-svn-id: http://core.svn.wordpress.org/trunk@30136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:24:22 +00:00
Boone Gorges
e9f6ee53bb
Fix database schema update introduced in [30121].
...
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.
Fixes #22023 .
Built from https://develop.svn.wordpress.org/trunk@30134
git-svn-id: http://core.svn.wordpress.org/trunk@30134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:11:22 +00:00
Scott Taylor
29deacc30c
Revisions modules should not rely on global settings:
...
* Only pass in global settings on `init`, this allows the classes to be used agnostically elsewhere
* Clean up some erroneous/weird Backbone syntax
Props ericlewis, wonderboymusic.
Fixes #30219 .
Built from https://develop.svn.wordpress.org/trunk@30131
git-svn-id: http://core.svn.wordpress.org/trunk@30131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:39:24 +00:00
Scott Taylor
d1d93b7cda
Set `revision.settings` via short-circuit check for `window` property: `window._wpRevisionsSettings || {}`
...
Props ericlewis.
Fixes #30218 .
Built from https://develop.svn.wordpress.org/trunk@30130
git-svn-id: http://core.svn.wordpress.org/trunk@30130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:20:22 +00:00
Scott Taylor
a4963672d6
Add a single responsibility function for outputting Revisions JS templates: `wp_print_revision_templates()`.
...
Use it in `wp-admin/revision.php`.
Props ericlewis.
Fixes #30220 .
Built from https://develop.svn.wordpress.org/trunk@30129
git-svn-id: http://core.svn.wordpress.org/trunk@30129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:15:24 +00:00
Scott Taylor
7cbb7552da
Allow revision Backbone classes to be used on pages other than `revision.php`.
...
Props ericlewis.
Fixes #30221 .
Built from https://develop.svn.wordpress.org/trunk@30128
git-svn-id: http://core.svn.wordpress.org/trunk@30128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:08:21 +00:00
Scott Taylor
f1634f7c8f
Add some JSDoc blocks to `revisions.js`.
...
Props ericlewis.
See #30222 .
Built from https://develop.svn.wordpress.org/trunk@30127
git-svn-id: http://core.svn.wordpress.org/trunk@30127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 23:55:22 +00:00
Dominik Schilling
461507452a
Customizer: Improve `ColorControl`'s `wpColorPicker` to update UI based on setting changes.
...
Update Twenty Fifteen's `colorScheme` control to properly interact with the API, using `wp.customize.control()` instead of traversing DOM for other controls' container elements and stop manually updating color control UIs.
props westonruter.
fixes #30031 .
Built from https://develop.svn.wordpress.org/trunk@30126
git-svn-id: http://core.svn.wordpress.org/trunk@30126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:45:22 +00:00
Drew Jaynes
66c47f29bb
Correct references of `@uses $wpdb` in core documentation to use `@global`.
...
See #30191 , [30105].
Fixes #30217 .
Built from https://develop.svn.wordpress.org/trunk@30122
git-svn-id: http://core.svn.wordpress.org/trunk@30122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 17:56:22 +00:00
Boone Gorges
70631df84a
Bump db_version and add upgrade routine for schema change in [30056].
...
Fixes #22023 .
Built from https://develop.svn.wordpress.org/trunk@30121
git-svn-id: http://core.svn.wordpress.org/trunk@30121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 16:03:22 +00:00
Sergey Biryukov
94fa6e1615
Use correct file name in a hook comment.
...
props wedi.
fixes #30200 .
Built from https://develop.svn.wordpress.org/trunk@30117
git-svn-id: http://core.svn.wordpress.org/trunk@30117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 18:35:28 +00:00
Drew Jaynes
f8657d5890
Remove redundant and erroneous `@uses` tag from most core inline documentation.
...
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.
Fixes #30191 .
Built from https://develop.svn.wordpress.org/trunk@30105
git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 01:05:24 +00:00
Dominik Schilling
00845a6c3d
Customizer: Fix missing newly added widgets in the preview after [29905].
...
props westonruter.
fixes #29983 .
Built from https://develop.svn.wordpress.org/trunk@30104
git-svn-id: http://core.svn.wordpress.org/trunk@30104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:57:23 +00:00
Dominik Schilling
3c962ee5d8
Improve/introduce Customizer JavaScript models for Controls, Sections, and Panels.
...
* Introduce models for panels and sections.
* Introduce API to expand and focus a control, section or panel.
* Allow deep-linking to panels, sections, and controls inside of the Customizer.
* Clean up `accordion.js`, removing all Customizer-specific logic.
* Add initial unit tests for `wp.customize.Class` in `customize-base.js`.
https://make.wordpress.org/core/2014/10/27/toward-a-complete-javascript-api-for-the-customizer/ provides an overview of how to use the JavaScript API.
props westonruter, celloexpressions, ryankienstra.
see #28032 , #28579 , #28580 , #28650 , #28709 , #29758 .
fixes #29529 .
Built from https://develop.svn.wordpress.org/trunk@30102
git-svn-id: http://core.svn.wordpress.org/trunk@30102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:51:22 +00:00
Mark Jaquith
63cf4db8ae
Fix weird HiDPI screen rendering issue with theme install preview toolbar
...
fixes #28898
props ocean90
Built from https://develop.svn.wordpress.org/trunk@30101
git-svn-id: http://core.svn.wordpress.org/trunk@30101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:36:21 +00:00
John Blackbourn
ee6d4968da
Add a hidden submit button to the Appearance -> Header screen so keyboard users can submit the form correctly when a default image provided by the theme is in use.
...
Fixes #20880 .
Props kovshenin, joedolson.
Built from https://develop.svn.wordpress.org/trunk@30095
git-svn-id: http://core.svn.wordpress.org/trunk@30095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 21:41:43 +00:00
John Blackbourn
a866a7192f
Introduce some actions and filters which aid plugins in revisioning post meta.
...
* `wp_save_post_revision_post_has_changed` filter which can be used to determine if a post has been changed, and therefore if a revision should be created for a post.
* `wp_get_revision_ui_diff` filter which can be used to filter the fields displayed in the post revision diff UI.
* `wp_creating_autosave` action which is fired just before an autosave is created.
See #20564 .
Props mattheu, adamsilverstein.
Built from https://develop.svn.wordpress.org/trunk@30091
git-svn-id: http://core.svn.wordpress.org/trunk@30091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 19:02:21 +00:00
Mark Jaquith
6de35acf28
Increase both mystery and humanism
...
Built from https://develop.svn.wordpress.org/trunk@30089
git-svn-id: http://core.svn.wordpress.org/trunk@30089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 03:20:24 +00:00
Aaron Jorbin
2261f4ceb4
Update images based on grunt imagemin
...
The new version of imagemin that was added in r30059 condenses some images more.
see #30141
Built from https://develop.svn.wordpress.org/trunk@30079
git-svn-id: http://core.svn.wordpress.org/trunk@30079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 22:02:22 +00:00
Scott Taylor
ee97a47c61
In `_wp_handle_upload()`, if `test_upload` is set to `false` in the array of dangerous overrides that the function allows, the only thing that happens when an upload fails is more potential breakage.
...
`$test_uploaded_file` lets is know if `$file['tmp_name']` exists, which allows to exit with an error, instead of continuing to attempt to move the file.
`$test_upload` override is now a noop.
Fixes #28208 .
Built from https://develop.svn.wordpress.org/trunk@30076
git-svn-id: http://core.svn.wordpress.org/trunk@30076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 21:17:22 +00:00
Aaron Jorbin
0a790fef4d
Don't cascade autoprefixer output
...
Autoprefixer changed the default for cascade from false to true. Our css coding standards do not include the cascade for browser prefixes.
Introduced in r30067
see #30141
Built from https://develop.svn.wordpress.org/trunk@30069
git-svn-id: http://core.svn.wordpress.org/trunk@30069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 20:45:23 +00:00
Aaron Jorbin
1ed642b276
Update grunt-sass to 0.16.0
...
Upstream changes https://github.com/sindresorhus/grunt-sass/compare/v0.14.0...v0.16.0
see #30141
Built from https://develop.svn.wordpress.org/trunk@30061
git-svn-id: http://core.svn.wordpress.org/trunk@30061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 19:27:40 +00:00
Boone Gorges
502bc03090
Remove UNIQUE key from 'slug' column of terms table.
...
Each slug is a unique and beautiful snowflake, but let's enforce that
uniqueness elsewhere.
Props hotchkissconsulting.
Fixes #22023 .
Built from https://develop.svn.wordpress.org/trunk@30056
git-svn-id: http://core.svn.wordpress.org/trunk@30056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 18:37:18 +00:00
Gary Pendergast
007ec52958
Add `wp_json_encode()`, a wrapper for `json_encode()` that ensures everything is converted to UTF-8.
...
Change all core calls from `json_encode()` to `wp_json_encode()`.
Fixes #28786 .
Built from https://develop.svn.wordpress.org/trunk@30055
git-svn-id: http://core.svn.wordpress.org/trunk@30055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 18:35:19 +00:00
John Blackbourn
3d99ef90d6
Add a missing Oxford comma to the install screen. Fixes #30107 . Props Ankit K Gupta.
...
Built from https://develop.svn.wordpress.org/trunk@30054
git-svn-id: http://core.svn.wordpress.org/trunk@30054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 18:32:18 +00:00
Sergey Biryukov
3badb558f6
Remove one-time loop and redundant isset() checks in do_meta_boxes().
...
See [30022] for do_accordion_sections().
props ipm-frommen.
fixes #30093 .
Built from https://develop.svn.wordpress.org/trunk@30040
git-svn-id: http://core.svn.wordpress.org/trunk@30040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-27 12:58:19 +00:00