Commit Graph

21267 Commits

Author SHA1 Message Date
Joe McGill a1d67608bf Media: Fix exif_imagetype check in wp_get_image_mime
This is a follow up to [39831].

Merges [39850] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@39853


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 16:40:32 +00:00
Joe McGill a8dcdd4fd5 Media: Improve image filetype checking.
This adds a new function `wp_get_image_mime()` which is used by
`wp_check_filetype_and_ext()` to validate image files using
`exif_imagetype()` if available instead of `getimagesize()`.

`getimagesize()` is less performant than `exif_imagetype()` and is
dependent on GD. If `exif_imagetype()` is not available, it falls back to
`getimagesize()` as before.

If `wp_check_filetype_and_ext()` can't validate the filetype, we now return
`false` for ext/MIME values.

Merges [39831] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@39834


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 13:15:31 +00:00
Dominik Schilling c1684e38b0 Themes: Fix markup for theme name fallbacks.
Merge of [39807] to the 4.5 branch.
Built from https://develop.svn.wordpress.org/branches/4.5@39811


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 11:10:05 +00:00
Jeremy Felt 13d318d196 Multisite: Use `wp_rand()` in signup key creation.
Merges [39795] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@39798


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 05:33:32 +00:00
Dion Hulse 440b7b387f Update PHPMailer to 5.2.22.
The full list of changes is available here:
https://github.com/PHPMailer/PHPMailer/compare/v5.2.21...v5.2.22

Merges [39759] to the 4.5 branch.
Fixes  for 4.5.

Built from https://develop.svn.wordpress.org/branches/4.5@39786


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-11 05:23:31 +00:00
Dion Hulse f991d9356c Mail: Upgrade PHPMailer to 5.2.21.
Merges [39645] to the 4.5 branch.
See .

Built from https://develop.svn.wordpress.org/branches/4.5@39723


git-svn-id: http://core.svn.wordpress.org/branches/4.5@39663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-06 22:04:36 +00:00
Jeremy Felt 34ea4c35f4 Bump 4.5 branch to 4.5.4.
Built from https://develop.svn.wordpress.org/branches/4.5@38550


git-svn-id: http://core.svn.wordpress.org/branches/4.5@38493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-07 14:58:31 +00:00
Jeremy Felt ff1790b8e8 Media: Sanitize upload filename.
Merge of [38538] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@38540


git-svn-id: http://core.svn.wordpress.org/branches/4.5@38483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-07 13:57:58 +00:00
Pascal Birchler b7bb8822d7 Upgrade/Install: Sanitize file name in `File_Upload_Upgrader`.
Merge of [38524] to the 4.5 branch.
Built from https://develop.svn.wordpress.org/branches/4.5@38526


git-svn-id: http://core.svn.wordpress.org/branches/4.5@38467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-06 17:34:33 +00:00
Dominik Schilling c1e4d25350 The 4.5 branch is now 4.5.4-alpha.
Built from https://develop.svn.wordpress.org/branches/4.5@38000


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-07 12:07:32 +00:00
Boone Gorges b15f7577d3 Bump 4.5 branch to 4.5.3.
Built from https://develop.svn.wordpress.org/branches/4.5@37826


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 15:53:29 +00:00
Pascal Birchler 47e67b7d33 Media: Fix rendering of incorrect toolbar in the Edit view.
This switches event binding in `wp.media.controller.EditImage` to use `on`
instead of `listenTo` to restore rendering of the correct toolbar when the
`toolbar:render:edit-image` event fires. The existing listeners broke
when we upgraded Backbone in [36546].

Merge of [37678] to the 4.5 branch.

Props adamsilverstein.
Fixes .
Built from https://develop.svn.wordpress.org/branches/4.5@37813


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:55:30 +00:00
Joe McGill b747172c20 Media: Improve handling of extensionless filenames.
Merge of [37756] to the 4.5 branch.

See .
Built from https://develop.svn.wordpress.org/branches/4.5@37809


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:52:06 +00:00
Nikolay Bachiyski df44f6cbc4 Admin: escape URL-encoded permalinks
Merge of [37801] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@37806


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:50:03 +00:00
Pascal Birchler 63325a253e Media: Restore keyboard navigation of the media grid.
This changes the binding of event listeners in the Attachments Browser
to use `on` instead of `listenTo` for the `attachment:keydown:arrow` and
`attachment:details:shift-tab` events. The existing listeners broke
when we upgraded Backbone in [36546].

Merge of [37755] to the 4.5 branch.

Props adamsilverstein.
Fixes .
Built from https://develop.svn.wordpress.org/branches/4.5@37804


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:49:28 +00:00
Rachel Baker 01fbbebff4 Revisions: Change the capability needed to view revision diffs to `edit_post`.
Merge of [37779] to the 4.5 branch.
Built from https://develop.svn.wordpress.org/branches/4.5@37791


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:27:33 +00:00
Nikolay Bachiyski 97bcc889a7 Admin: Escape attachment name in case it contains special characters
Merge of [37774] to the 4.5 branch.

Built from https://develop.svn.wordpress.org/branches/4.5@37783


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:23:45 +00:00
Dominik Schilling 45dc424bc1 Customize: Make sure that preview and return URLs are URLs.
Merge of [37527] to the 4.5 branch.
Built from https://develop.svn.wordpress.org/branches/4.5@37768


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:16:56 +00:00
Boone Gorges 4113f3fb69 Taxonomy: More specific cap check when processing category data on post save.
Ports [37691] to the 4.5 branch.

 Props dlh.
 Fixes .
 Please enter the commit message for your changes. Lines starting
Built from https://develop.svn.wordpress.org/branches/4.5@37759


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:11:55 +00:00
Jeremy Felt c75e86705a Admin: Allow for the consistent filtering of `auth_redirect_scheme`
Merge of [37651] to the 4.5 branch.

See .

Built from https://develop.svn.wordpress.org/branches/4.5@37757


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-21 14:10:30 +00:00
Pascal Birchler f5fdf443eb Menus: Support nested array variables in POST data when saving menus.
[36510] allowed larger menus to be created in the Edit Menu screen by JSON-encoding the entire form into a single input field. However, it did not correctly handle nested arrays.

This introduces a new `_wp_expand_nav_menu_post_data()` helper function to handle this POST data which uses `array_replace_recursive()` internally. Since the latter is only available on PHP 5.3+, we add a compatibility function to ensure PHP 5.2 support.

Merge of [37748] and [37750] to the 4.5 branch.

Props ericlewis, neverything, swissspidy.
Fixes . See .
Built from https://develop.svn.wordpress.org/branches/4.5@37754


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-20 19:50:30 +00:00
Aaron Jorbin 9b7c749c86 Output node and npm versions on travis.
In order to make local debugging of travis easier, output the npm and node versions when travis runs.

[37730] for 4.5.

see . 

Built from https://develop.svn.wordpress.org/branches/4.5@37733


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-16 17:32:28 +00:00
Pascal Birchler e05facfc58 Embeds: Enforce a valid post ID when embedding a post from the current site.
Otherwise `wp_filter_pre_oembed_result()` could erroneously return the HTML of the current post instead of the intended result.

Merge of [37729] to the 4.5 branch.

Props kraftbj.
See .
Built from https://develop.svn.wordpress.org/branches/4.5@37732


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-16 17:30:55 +00:00
Dominik Schilling c3a292dc76 Customize: Separate preview and actions in the site icon control.
Reverts [37456] to allow users to remove/change a site icon even if the attachment has corrupt/missing data about sizes.

Merge of [37724] to the 4.5 branch.

See .
Built from https://develop.svn.wordpress.org/branches/4.5@37725


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-16 09:53:28 +00:00
Pascal Birchler e09e36af80 Fix tests after [37709].
Avoids using `assertNotFalse()` which is only available in PHPUnit 4.0 and above.

See [37708], [37710].
See .
Built from https://develop.svn.wordpress.org/branches/4.5@37711


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-15 12:24:28 +00:00
Pascal Birchler ddfbf0cbe4 Embeds: Improve performance when embedding a post of the current site.
When the post being embedded is from the same site, there's no reason to do an HTTP request for it. The data can be fetched directly using `get_oembed_response_data()`.

Merge of [37708] to the 4.5 branch.

Fixes .
Built from https://develop.svn.wordpress.org/branches/4.5@37709


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-15 11:32:29 +00:00
Dominik Schilling caf7ab7df5 Database: `dbDelta()` will no longer try to downgrade the size of `TEXT` and `BLOB` columns.
When upgrading to `utf8mb4`, `TEXT` fields will be upgraded to `MEDIUMTEXT` (and likewise for all other `*TEXT` and `*BLOB` fields). This is to allow for the additional space requirements of `utf8mb4`.

On the subsequent upgrade, after the `utf8mb4` upgrade, `dbDelta()` would try and downgrade the fields to their original size again. At best, this it a waste of time, at worst, this could truncate any data larger than the original size. There's no harm in leaving them at their original size, so let's do that.

Merge of [37525] to the 4.5 branch.

Props pento.
See .


Built from https://develop.svn.wordpress.org/branches/4.5@37606


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-01 12:59:28 +00:00
Dominik Schilling d04d7ae710 TinyMCE: Fix inline toolbar positioning.
Introduced in [37000].
See 2fb8aa48e9.
See 5734a8d880.

Merge of [37559] to the 4.5 branch.

Props iseulde.
Fixes .
Built from https://develop.svn.wordpress.org/branches/4.5@37605


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-01 12:32:27 +00:00
Dominik Schilling 71b97108db External Libraries: Update jQuery Migrate to 1.4.1.
http://blog.jquery.com/2016/05/19/jquery-migrate-1-4-1-released-and-the-path-to-jquery-3-0/

Unquoted selectors for attribute selectors should function once again (and output a warning so that plugins and themes using them can update).

Merge of [37472] to the 4.5 branch.

Props jorbin.
Fixes .
Built from https://develop.svn.wordpress.org/branches/4.5@37604


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-01 12:25:31 +00:00
Dominik Schilling c988d1e5ac External Libraries: Update jQuery to 1.12.4.
Release post: https://blog.jquery.com/2016/05/20/jquery-1-12-4-and-2-2-4-released/
Changelog: https://github.com/jquery/jquery/compare/1.12.3...1.12.4

Merge of [37433] and [37526] to the 4.5 branch.

Fixes .
Built from https://develop.svn.wordpress.org/branches/4.5@37528


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 09:34:30 +00:00
Dominik Schilling 4a57c6bace Media: Remove medium_large size from `$whitelist_options['media']` in `options.php`.
The `medium_large_size_w` and `medium_large_size_h` options were added to the
`$whitelist_options['media']` in options.php in [35479], which causes both options
to be set to `0` when the media settings are changed. When this occurs, the
medium_large image size will no longer be created when an image is uploaded.

Since these options aren't meant to be updated via the settings UI, they can be
safely removed from the whitelist.

Merge of [37435] to the 4.5 branch.

Props joemcgill.
Fixes .
Built from https://develop.svn.wordpress.org/branches/4.5@37457


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:40:29 +00:00
Dominik Schilling 3d0c06e1f6 Embeds: Change attachment metadata condition to prevent a warning in the embeds template.
Merge of [37452] to the 4.5 branch.

Props swissspidy.
See .
Fixes .
Built from https://develop.svn.wordpress.org/branches/4.5@37455


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:38:32 +00:00
Dominik Schilling 677c67fa2f TinyMCE: prevent showing the placeholder URL when adding a link and clicking more than once on the Insert Link button.
Merge of [37301] to the 4.5 branch.

Props iseulde.
Fixes .
Built from https://develop.svn.wordpress.org/branches/4.5@37454


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:36:34 +00:00
Dominik Schilling 53acd1636d Customize: Handle filtering `sidebars_widgets` when the underlying option is non-existent.
Fixes warning related to a non-array argument for `array_merge()` in `WP_Customize_Widgets::customize_register()`. 

Merge of [37352] to the 4.5 branch.

See [37166].
See .
Fixes .
Built from https://develop.svn.wordpress.org/branches/4.5@37453


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:34:30 +00:00
Dominik Schilling e16574e010 Bootstrap/Load: Silence `ini_set()` in `wp_debug_mode()`.
Merge of [37448] to the 4.5 branch.

Props SergeyBiryukov.
Fixes .
Built from https://develop.svn.wordpress.org/branches/4.5@37451


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:31:29 +00:00
Dominik Schilling 946b2cc8a2 Customize: Remove use of reserved word `default` in Underscore template which breaks IE8.
Fixes regression introduced in [36769].

Merge of [37417] to the 4.5 branch.

Props adamsilverstein.
Fixes .

Built from https://develop.svn.wordpress.org/branches/4.5@37450


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:29:30 +00:00
Aaron Jorbin 5d60412106 Correct usage of Covers for Tests_Update_Comment_Count_Now
When @covers is used with a plain alphanumeric string, PHPUnit assumes that it is covering a class. If there is no class, it fails and exits rather than continuing to generate coverage. To cover a global function, the name must start with `::`.  See https://phpunit.de/manual/5.3/en/appendixes.annotations.html#appendixes.annotations.covers

See , 


Built from https://develop.svn.wordpress.org/branches/4.5@37445


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 17:52:30 +00:00
Dominik Schilling 2429d91496 The 4.5 branch is now 4.5.3-alpha.
Built from https://develop.svn.wordpress.org/branches/4.5@37420


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 11:54:30 +00:00
Dominik Schilling ee28ddbf8f Bump 4.5 branch to 4.5.2.
Built from https://develop.svn.wordpress.org/branches/4.5@37384


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-06 18:11:28 +00:00
Nikolay Bachiyski bb244816c7 External Libraries: Update plupload from upstream
Built from https://develop.svn.wordpress.org/branches/4.5@37382


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-06 18:01:28 +00:00
Dominik Schilling a9a70e1bfb External Libraries: Update MediaElement.js from upstream.
Merge of [37370] to the 4.5 branch.
Built from https://develop.svn.wordpress.org/branches/4.5@37371


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-06 17:52:29 +00:00
Helen Hou-Sandí d7f37d8bc0 The 4.5 branch is now 4.5.2-alpha.
Built from https://develop.svn.wordpress.org/branches/4.5@37312


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-26 20:25:28 +00:00
Pascal Birchler 31d8e7d909 Bump 4.5 branch to version 4.5.1.
Built from https://develop.svn.wordpress.org/branches/4.5@37310


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-26 17:52:32 +00:00
Gary Pendergast 998a0152f4 Post 4.5.1-RC2 version bump.
Built from https://develop.svn.wordpress.org/branches/4.5@37295


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 05:57:27 +00:00
Gary Pendergast 20d537e973 4.5.1-RC2
Built from https://develop.svn.wordpress.org/branches/4.5@37294


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 05:52:27 +00:00
Gary Pendergast 59123b5b24 Database: Suppress connection error messages when `WP_DEBUG` isn't enabled.
This is a partial revert of [35860], which has been causing un-catchable warnings to be generated on some server configurations.

Merge of [37292] to the 4.5 branch.

Fixes .
See .


Built from https://develop.svn.wordpress.org/branches/4.5@37293


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 05:24:29 +00:00
Andrew Ozz c84cda9fd0 Post 4.5.1-RC version bump.
Built from https://develop.svn.wordpress.org/branches/4.5@37291


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 01:26:28 +00:00
Andrew Ozz 44e684419b 4.5.1-RC
Built from https://develop.svn.wordpress.org/branches/4.5@37290


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 01:09:28 +00:00
Dominik Schilling 9bfc7ded12 Media: Remove an extra quote when sending a link of a media file to the editor.
Introduced in [37035].

Merge of [37288] to the 4.5 branch.

Props joemcgill, swissspidy, boonebgorges.
Fixes .
Built from https://develop.svn.wordpress.org/branches/4.5@37289


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 21:34:30 +00:00
Dominik Schilling 3ea969bb66 Media: Don't cache the results of `wp_mkdir_p()` in a persistent cache.
To improve the performance of `wp_upload_dir()` the result of `wp_mkdir_p()` was stored in a persistent cache, introduced in [36565]. But this becomes an issue when WordPress is scaled horizontally. You may end up caching a value for a server where the directory doesn't exist which will prevent further uploads on other servers because of the persistent cache.
The fix is to use a non-persistent cache.

Merge of [37285] to the 4.5 branch.

Props azaozz, ocean90.
See .
Fixes .
Built from https://develop.svn.wordpress.org/branches/4.5@37286


git-svn-id: http://core.svn.wordpress.org/branches/4.5@37252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 20:18:28 +00:00