Sergey Biryukov
ff00c377ec
Show a "No themes found" message if the search for an installed theme doesn't produce any results.
...
props gauravmittal1995 for initial patch.
fixes #28587 .
Built from https://develop.svn.wordpress.org/trunk@28890
git-svn-id: http://core.svn.wordpress.org/trunk@28689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-29 09:16:14 +00:00
Scott Taylor
2f513d3320
Fix some `hackificator` odds and ends in `wp-admin`:
...
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28500
git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:04:16 +00:00
Andrew Nacin
dcb39d4dad
Themes: Hide 'Add New' with no JS. see #27055 .
...
Built from https://develop.svn.wordpress.org/trunk@27936
git-svn-id: http://core.svn.wordpress.org/trunk@27766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 23:06:16 +00:00
Andrew Nacin
8ff7cf5c3e
Themes screen: Use a normal error for WP_Theme errors.
...
see #27235 for trunk.
Built from https://develop.svn.wordpress.org/trunk@27760
git-svn-id: http://core.svn.wordpress.org/trunk@27597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 23:37:25 +00:00
Andrew Nacin
deb8779af5
More translation cleanups.
...
Affects widgets (see #27112 ), custom headers (see #21785 ), theme installer (see #27055 , reverts [27614]), and some media stuff. Untranslates some complicated strings that need additional study.
see #27453 .
Built from https://develop.svn.wordpress.org/trunk@27620
git-svn-id: http://core.svn.wordpress.org/trunk@27463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 08:18:14 +00:00
Andrew Nacin
dce0b9adea
Use SSL when linking to WordPress.org. see #27115 .
...
Built from https://develop.svn.wordpress.org/trunk@27469
git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 04:14:15 +00:00
Mark Jaquith
acb65e13c3
Improve pushState, replaceState and routing for Themes page
...
* Uses `pushState()` generally
* Uses `replaceState()` when updating a search query (so no history cruft from typing)
fixes #27198 . props gcorne, adamsilverstein.
Built from https://develop.svn.wordpress.org/trunk@27268
git-svn-id: http://core.svn.wordpress.org/trunk@27124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 19:22:13 +00:00
Sergey Biryukov
8363d0660b
Use .screen-reader-text class instead of an alt attribute for overlay button labels on Themes screen.
...
props bramd.
fixes #26603 for trunk.
Built from https://develop.svn.wordpress.org/trunk@27119
git-svn-id: http://core.svn.wordpress.org/trunk@26986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 17:33:12 +00:00
Andrew Nacin
e18a013956
Themes screen: Add aria-describedby attributes to provide better information to screen readers.
...
props joedolson for initial patch.
fixes #26602 for trunk.
Built from https://develop.svn.wordpress.org/trunk@27012
git-svn-id: http://core.svn.wordpress.org/trunk@26889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 21:00:11 +00:00
Andrew Nacin
9e942606c8
Keyboard navigation friendliness for themes.php.
...
props matveb, azaozz, jorbin.
see #26527 .
Built from https://develop.svn.wordpress.org/trunk@26922
git-svn-id: http://core.svn.wordpress.org/trunk@26803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-08 21:35:09 +00:00
Andrew Nacin
c06ed485b8
Don't use a JS reserved word in a Backbone template, this breaks IE8.
...
props ocean90.
fixes #26539 .
Built from https://develop.svn.wordpress.org/trunk@26853
git-svn-id: http://core.svn.wordpress.org/trunk@26740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-11 22:49:09 +00:00
Ryan Boren
07c16fd23c
The Pinking Shears stir from their slumber, awakened by what may seem, to those
...
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!
One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.
Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.
Built from https://develop.svn.wordpress.org/trunk@26851
git-svn-id: http://core.svn.wordpress.org/trunk@26738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-11 19:49:11 +00:00
Andrew Nacin
87265a374b
Themes: use explicit 'search installed themes' label and placeholder.
...
fixes #26496 .
Built from https://develop.svn.wordpress.org/trunk@26827
git-svn-id: http://core.svn.wordpress.org/trunk@26714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 07:41:10 +00:00
Ryan Boren
b07b8d4fe8
Make the Backbone routes pushSTate capable with ?theme=themename type urls instead of hashes. Same applies to search queries.
...
Props adamsilverstein, nacin
fixes #25963
Built from https://develop.svn.wordpress.org/trunk@26767
git-svn-id: http://core.svn.wordpress.org/trunk@26655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 03:11:10 +00:00
Andrew Nacin
7ab63ed719
Update the help text on themes.php. The Install Themes tab is now an Add New button.
...
props ethitter.
fixes #26285 .
Built from https://develop.svn.wordpress.org/trunk@26759
git-svn-id: http://core.svn.wordpress.org/trunk@26647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 00:45:10 +00:00
Andrew Nacin
32736c45ff
Remove screenshotGallery. see #25948 .
...
Built from https://develop.svn.wordpress.org/trunk@26728
git-svn-id: http://core.svn.wordpress.org/trunk@26617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 17:11:10 +00:00
Andrew Nacin
df48cebeb4
No-JavaScript and no-Customizer support for the new Themes screen.
...
JavaScript is rarely disabled, but graceful degradation is still important. For example, syntax errors can occur, usually with major WP updates that overhaul entire experiences and update external libraries combined with themes or plugins doing weird or old things. If this error is due to their current theme, a user needs to be able to access the themes screen to switch away from the theme. A more subtle issue could make things painful to diagnose.
This commit renders the grid in PHP (the template is duplicated, but it lightweight, fairly mundane, and easy to sync). On Backbone render, the grid is then re-rendered from JavaScript so searches can occur. Customize and Live Preview is disabled if JS fails to kick in. If JS is disabled, old-school "Preview" links are displayed.
No-Customizer support: The customizer is only supported when the browser supports postMessage (IE8+), and if the frontend is a different domain, CORS (IE10+). We use the .hide-if-no-customize class for this. Pre-customize "Preview" links should use .hide-if-customize.
The .load-customize class should be used to declare a link that opens the customizer. This enables customize-loader.js to intercept this link and load the customizer on top of the current window, making for a smoother experience.
fixes #25964 .
Built from https://develop.svn.wordpress.org/trunk@26726
git-svn-id: http://core.svn.wordpress.org/trunk@26615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 16:11:10 +00:00
Andrew Nacin
9ecfa135d8
Map old -width theme tags to new -layout tags for the purposes of translation in the admin.
...
see #21442 .
Built from https://develop.svn.wordpress.org/trunk@26725
git-svn-id: http://core.svn.wordpress.org/trunk@26614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 14:37:10 +00:00
Andrew Nacin
d1dcd30c5f
Themes: Switch to a text overlay instead of an icon on hover. Numerous reasons outlined in the ticket.
...
props shaunandrews.
fixes #26440 .
Built from https://develop.svn.wordpress.org/trunk@26708
git-svn-id: http://core.svn.wordpress.org/trunk@26597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 23:43:11 +00:00
Andrew Nacin
08430e2684
Theme: When showing an author in the grid (during a search), don't include the author's link.
...
fixes #26433 .
Built from https://develop.svn.wordpress.org/trunk@26684
git-svn-id: http://core.svn.wordpress.org/trunk@26574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 19:08:10 +00:00
Andrew Nacin
72f9712a1f
Themes: Refine how we display the current theme.
...
props shaunandrews, kwight, matveb.
see #26003 .
Built from https://develop.svn.wordpress.org/trunk@26681
git-svn-id: http://core.svn.wordpress.org/trunk@26571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 18:42:16 +00:00
Andrew Nacin
fce306232a
Allow HTML in the theme name for the themes.php template.
...
props matveb.
fixes #26411 .
Built from https://develop.svn.wordpress.org/trunk@26638
git-svn-id: http://core.svn.wordpress.org/trunk@26528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 21:41:10 +00:00
Andrew Nacin
bb32d28c75
For the current theme, display all available actions, as dictated by the admin menu.
...
Restores 3.7 behavior. This could include things like Header and Background as well as theme options pages.
see #25948 .
Built from https://develop.svn.wordpress.org/trunk@26531
git-svn-id: http://core.svn.wordpress.org/trunk@26424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 18:58:09 +00:00
Dion Hulse
0e5af31e0f
Themes: Update notifiations shouldn't be a <a> if they're not links, data.update already contains <p> tags. See #25948
...
Built from https://develop.svn.wordpress.org/trunk@26524
git-svn-id: http://core.svn.wordpress.org/trunk@26417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 08:38:10 +00:00
Dion Hulse
ea219afa23
Themes: Standardise on dot notation for object access in the Templates. See #25948
...
Built from https://develop.svn.wordpress.org/trunk@26523
git-svn-id: http://core.svn.wordpress.org/trunk@26416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 07:34:10 +00:00
Dion Hulse
b6a102f1f5
Themes: Remove some HTML from a new string and put it in the replacement value instead. See #25948
...
Built from https://develop.svn.wordpress.org/trunk@26522
git-svn-id: http://core.svn.wordpress.org/trunk@26415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 07:20:09 +00:00
Dion Hulse
6c9356b360
Themes: Indent the HTML for proper indentation after r26519 added an extra div. See #25961 , #26192
...
Built from https://develop.svn.wordpress.org/trunk@26520
git-svn-id: http://core.svn.wordpress.org/trunk@26413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 07:14:10 +00:00
Dion Hulse
4829e81966
Themes: Make the Theme Detail view div use more of the available viewport, Fix the Header and Footer in the viewport and only scroll the theme details, Prefix some more theme CSS classes. Props shaunandrews for the initial viewport patch. Fixes #25961 , #26192
...
Built from https://develop.svn.wordpress.org/trunk@26519
git-svn-id: http://core.svn.wordpress.org/trunk@26412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 07:12:09 +00:00
Dion Hulse
ec734890a9
Themes: Add a updated Help text. Props designsimply & hanni. See #26285
...
Built from https://develop.svn.wordpress.org/trunk@26517
git-svn-id: http://core.svn.wordpress.org/trunk@26410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 03:23:10 +00:00
Sergey Biryukov
8ddb058d36
Fix Customize link in theme info window. props kovshenin. see #25948 .
...
Built from https://develop.svn.wordpress.org/trunk@26508
git-svn-id: http://core.svn.wordpress.org/trunk@26402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-01 21:09:10 +00:00
Dominik Schilling
19b3779e0e
Themes: Fix HTML markup for screenshots. props kovshenin. fixes #25959 .
...
Built from https://develop.svn.wordpress.org/trunk@26504
git-svn-id: http://core.svn.wordpress.org/trunk@26398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-01 18:00:09 +00:00
Dominik Schilling
cc11eeac5b
Themes: Merge theme.css into wp-admin.css. fixes #25966 .
...
Built from https://develop.svn.wordpress.org/trunk@26484
git-svn-id: http://core.svn.wordpress.org/trunk@26381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-30 17:32:10 +00:00
Dominik Schilling
e5ab876603
Themes: Add missing close tag, see [26462]. see #25959 .
...
Built from https://develop.svn.wordpress.org/trunk@26473
git-svn-id: http://core.svn.wordpress.org/trunk@26371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 17:17:11 +00:00
Dion Hulse
0af3bf7748
Themes: Restore a label accidentally removed in r26470. Props SergeyBiryukov. See #25948
...
Built from https://develop.svn.wordpress.org/trunk@26472
git-svn-id: http://core.svn.wordpress.org/trunk@26370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 12:04:11 +00:00
Dion Hulse
8ad620e51f
Themes: Do extra Cap checks before outputting links, and use full URI's. See #25948
...
Built from https://develop.svn.wordpress.org/trunk@26470
git-svn-id: http://core.svn.wordpress.org/trunk@26368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 09:01:09 +00:00
Dion Hulse
2c78650fd0
Themes: Add a default image for when a theme doesn't have a screenshot. Props matveb. See #25959
...
Built from https://develop.svn.wordpress.org/trunk@26462
git-svn-id: http://core.svn.wordpress.org/trunk@26360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 04:04:11 +00:00
Dion Hulse
483824f8fb
Themes: Display Activated/Deleted messages below the H2, before the Themes. See #26305
...
Built from https://develop.svn.wordpress.org/trunk@26461
git-svn-id: http://core.svn.wordpress.org/trunk@26359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 02:40:09 +00:00
Dion Hulse
72166b14ad
Themes: Remove an unused Delete Theme link on the multiple view. See #25948
...
Built from https://develop.svn.wordpress.org/trunk@26459
git-svn-id: http://core.svn.wordpress.org/trunk@26357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 01:55:10 +00:00
Dominik Schilling
2597e857be
Appearance Themes: Don't show theme actions if the current theme doesn't support menus or widgets.
...
props MikeHansenMe.
fixes #25949 .
Built from https://develop.svn.wordpress.org/trunk@26335
git-svn-id: http://core.svn.wordpress.org/trunk@26237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-23 12:15:10 +00:00
Dion Hulse
61ed60c619
Themes: Move the escaping of content from JS back to PHP. This allows us to take advantage of the display() WP_Theme method to translate the text properly, and to strip out any HTML tags we don't wish to display. Fixes #26100 . See #25948
...
Built from https://develop.svn.wordpress.org/trunk@26316
git-svn-id: http://core.svn.wordpress.org/trunk@26220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-22 02:34:10 +00:00
Dion Hulse
3be48e6d26
Themes page: Don't display the Author as a link if the Author has no AuthorURI set. Props morganestes. Fixes #26098
...
Built from https://develop.svn.wordpress.org/trunk@26314
git-svn-id: http://core.svn.wordpress.org/trunk@26218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-22 02:10:10 +00:00
Andrew Nacin
4f08cf2efa
Dash cleanup.
...
* Use wp_add_dashboard_widget() rather than add_meta_box().
* Use original functions like wp_dashboard_primary(), wp_dashboard_right_now(), wp_dashboard_quick_press() (where possible).
* Only include plugins section of the news widget when appropriate, which necessitates the set_current_screen() via the ajax action.
* Remove some debug cruft that was preventing caching and invalidation.
* Simplify lots of things where possible.
see #25824 .
Built from https://develop.svn.wordpress.org/trunk@26291
git-svn-id: http://core.svn.wordpress.org/trunk@26196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 19:44:12 +00:00
Sergey Biryukov
b545ee773e
Only show "Add New Theme" block on Manage Themes screen if not Multisite and the user can install themes.
...
props markoheijnen.
see #25948 .
Built from https://develop.svn.wordpress.org/trunk@26288
git-svn-id: http://core.svn.wordpress.org/trunk@26193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 14:09:10 +00:00
Dion Hulse
893262f742
Themes: Add a get_theme_update_available() function to retrieve an update link and use it on the Themes page. See #26078
...
Built from https://develop.svn.wordpress.org/trunk@26282
git-svn-id: http://core.svn.wordpress.org/trunk@26187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 02:57:10 +00:00
Andrew Nacin
dce9327f2a
Update the Themes screen, merging THX into core.
...
* Name: THX38
* Description: Update the Themes screen with a new design and experience.
* Tags: visually-focused, bigger-screenshots, fast, mobile-friendly, backbone-driven
* Author: matveb, shaunandrews, melchoyce, designsimply, shelob9
* URI: http://wordpress.org/plugins/thx38/
fixes #25948
Built from https://develop.svn.wordpress.org/trunk@26141
git-svn-id: http://core.svn.wordpress.org/trunk@26052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 20:58:05 +00:00
Andrew Nacin
6a675a8c9b
Don't let the query string pile up on successive themes.php searches.
...
props SergeyBiryukov.
fixes #25270 .
Built from https://develop.svn.wordpress.org/trunk@25679
git-svn-id: http://core.svn.wordpress.org/trunk@25595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 01:26:09 +00:00
Andrew Nacin
7de2054ece
Show a proper error message on the dashboard when the current theme is broken.
...
Clean up Appearance -> Themes when we don't have enough information to show for a broken theme.
Clean up broken/ugly "alt" row styling when we are displaying broken themes.
props johnbillion for initial patch.
fixes #21670 .
Built from https://develop.svn.wordpress.org/trunk@25666
git-svn-id: http://core.svn.wordpress.org/trunk@25582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 20:50:09 +00:00
Andrew Nacin
fd57b239d2
Don't rely on include_path to include files.
...
Always use dirname() or, once available, ABSPATH.
props ketwaroo, hakre.
fixes #17092 .
Built from https://develop.svn.wordpress.org/trunk@25616
git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
Andrew Nacin
797ee34bc3
Remove /extend/ from URLs to wordpress.org/plugins, /themes, and /mobile, as those are all now top-level. see #24389 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 21:01:57 +00:00
Andrew Nacin
b11654ce74
Revert [23871] - Customize should be added to the menu, but not hacked in as first. see #21413 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 19:33:39 +00:00