1651342d2b
Privacy: Improve clarity of privacy error strings.
...
Primarily this adds "user privacy" to the strings for privacy requests, so they are more easily distinguished from other system actions within logs.
Props garrett-eclipse, carike, birgire.
Fixes #51351 .
Built from https://develop.svn.wordpress.org/trunk@49090
git-svn-id: http://core.svn.wordpress.org/trunk@48852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-04 03:23:09 +00:00
f426a1fa04
Media: clear inputs after cropping on attachment details screen.
...
Clear the crop selection input fields after the crop action is complete.
Fixes unexpected re-cropping behavior if the crop button was clicked more than once.
Props davidbinda.
Fixes #30155 .
Built from https://develop.svn.wordpress.org/trunk@49087
git-svn-id: http://core.svn.wordpress.org/trunk@48849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-02 15:11:06 +00:00
1079647d30
Docs: Various docblock improvements related to user and site signup functionality.
...
See #50768
Built from https://develop.svn.wordpress.org/trunk@49078
git-svn-id: http://core.svn.wordpress.org/trunk@48840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-30 21:54:07 +00:00
b3b8942dfc
Docs: Correct description for `wp_ajax_update_widget()`.
...
Follow-up to [28355].
Props burhandodhy, sabernhardt.
Fixes #44583 .
Built from https://develop.svn.wordpress.org/trunk@49071
git-svn-id: http://core.svn.wordpress.org/trunk@48833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-30 09:44:09 +00:00
2cbcc5d548
Media: Make the "Copy URL" button implementation more consistent with other instances in core:
...
* Make the "Copied!" text green.
* Make the button verbiage clear that it's copied "to clipboard".
Props garrett-eclipse, mukesh27.
Fixes #51355 .
Built from https://develop.svn.wordpress.org/trunk@49064
git-svn-id: http://core.svn.wordpress.org/trunk@48826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-27 20:48:05 +00:00
c298458751
Docs: Add missing `@return` tags for some `WP_Automatic_Updater` methods:
...
* `::is_vcs_checkout()`
* `::should_update()`
* `::send_core_update_notification_email()`
Props ankitmaru, mukesh27.
Fixes #51385 .
Built from https://develop.svn.wordpress.org/trunk@49061
git-svn-id: http://core.svn.wordpress.org/trunk@48823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-27 08:36:06 +00:00
eaf325e386
Upgrade/Install: Introduce the `wp_installed_email` filter for filtering the contents of the email sent when WordPress is installed, without needing to override the `wp_new_blog_notification()` pluggable function.
...
Props Dharm1025, nikolam, johnbillion
Fixes #42133
Built from https://develop.svn.wordpress.org/trunk@49048
git-svn-id: http://core.svn.wordpress.org/trunk@48810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-25 22:33:08 +00:00
41b456eca9
Editor: Hide Screen Options tab from block editor
...
The block editor provides its own interface for managing screen options, so we
can safely hide Screen Options tab found in the top right of the page.
Props aduth.
See #46157 .
Built from https://develop.svn.wordpress.org/trunk@49040
git-svn-id: http://core.svn.wordpress.org/trunk@48802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-24 03:00:08 +00:00
a16faa6989
Privacy: Ensure bulk action related strings end with periods.
...
Props garrett-eclipse, mukesh27.
Fixes #51371 .
Built from https://develop.svn.wordpress.org/trunk@49035
git-svn-id: http://core.svn.wordpress.org/trunk@48797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-22 18:40:04 +00:00
175c2c5b7c
Users: Introduce the `invited_user_email` filter for filtering the contents of the email sent when an existing user is invited to a site on Multisite.
...
Props contact-banker, anand.au14, nikolam, johnbillion
Fixes #42132
Built from https://develop.svn.wordpress.org/trunk@49029
git-svn-id: http://core.svn.wordpress.org/trunk@48791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-21 17:16:07 +00:00
aef504acfd
Docs: Correct the indentation for some array type docs.
...
See #50768
Built from https://develop.svn.wordpress.org/trunk@49028
git-svn-id: http://core.svn.wordpress.org/trunk@48790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-21 16:46:06 +00:00
29c0edfbba
Privacy: Check if the accumulated data in `wp_privacy_process_personal_data_export_page()` is not empty.
...
This avoids an error on PHP 8 caused by passing an empty string to `array_merge()`, instead of an array.
See #50913 .
Built from https://develop.svn.wordpress.org/trunk@49026
git-svn-id: http://core.svn.wordpress.org/trunk@48788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-21 13:51:03 +00:00
aba2165aae
Media: Standardise the description for image size parameters.
...
This brings continuity to all the image related functions and filters which accept or pass a size parameter.
Props dilipbheda, johnbillion
Fixes #47364
Built from https://develop.svn.wordpress.org/trunk@49021
git-svn-id: http://core.svn.wordpress.org/trunk@48783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-20 16:23:07 +00:00
0b2e31a7f8
Docs: Inline documentation improvements for media related functions and hooks.
...
See #47364 , #50768
Built from https://develop.svn.wordpress.org/trunk@49020
git-svn-id: http://core.svn.wordpress.org/trunk@48782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-20 15:55:10 +00:00
43b11121de
Media: Correct some types for attachment ID parameters passed to functions and filters.
...
See #47364 , #50768
Built from https://develop.svn.wordpress.org/trunk@49017
git-svn-id: http://core.svn.wordpress.org/trunk@48779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-20 14:05:05 +00:00
7d61c45afc
I18N: Add a language icon next to the Default Language network option.
...
Fixes #51359
Built from https://develop.svn.wordpress.org/trunk@49013
git-svn-id: http://core.svn.wordpress.org/trunk@48775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-20 13:18:05 +00:00
123806ff28
Themes: Remove the ability to delete themes from the single site Appearance screen on Multisite installations.
...
This brings theme deletion inline with plugin deletion and theme and plugin editing, which can only be performed from within Network Admin.
Props Mista-Flo, williampatton, johnbillion
Fixes #41441
Built from https://develop.svn.wordpress.org/trunk@49011
git-svn-id: http://core.svn.wordpress.org/trunk@48773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-20 12:03:05 +00:00
d5b8d282e8
Docs: Update the URL for PHP date formats table in translator comments.
...
Props hareesh-pillai, iandunn.
Fixes #51332 .
Built from https://develop.svn.wordpress.org/trunk@48991
git-svn-id: http://core.svn.wordpress.org/trunk@48753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-18 10:37:08 +00:00
282c813259
Coding Standards: Explicitly declare the `$wp_version` global used in some core files.
...
Props jaydeep-rami, sabernhardt.
Fixes #44932 .
Built from https://develop.svn.wordpress.org/trunk@48971
git-svn-id: http://core.svn.wordpress.org/trunk@48733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-12 00:12:08 +00:00
f29d62012d
Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-plugin-install-list-table.php`.
...
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@48970
git-svn-id: http://core.svn.wordpress.org/trunk@48732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-11 01:05:08 +00:00
e36c7f0ba0
Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-plugins-list-table.php`.
...
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@48968
git-svn-id: http://core.svn.wordpress.org/trunk@48730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-10 14:23:08 +00:00
7dada5df2f
Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-ms-themes-list-table.php`.
...
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@48967
git-svn-id: http://core.svn.wordpress.org/trunk@48729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-10 14:21:09 +00:00
447b526379
Privacy: Remove extraneous colon from settings screen.
...
Props vinita29, garrett-eclipse.
Fixes #50414 .
Built from https://develop.svn.wordpress.org/trunk@48965
git-svn-id: http://core.svn.wordpress.org/trunk@48727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-09 19:43:08 +00:00
04c8217724
Administration: Add the `aria-hidden` attribute to admin menu icons.
...
The admin menu icons are included as a visual element to support the text links. Without the `aria-hidden=“true”` attribute, they are also exposed to assistive technologies (which can process icon fonts in unpredictable ways).
This change improves the experience for multiple types of assistive technologies, including screen reading and voice control software. With `aria-hidden=“true”` added, the icons will not be read, and a user can now trigger a click of a top level admin menu item with commands such as “click posts”, or “click plugins”.
Props joedolson, afercia, audrasjb, adriantirusli.
Fixes #51012 .
Built from https://develop.svn.wordpress.org/trunk@48963
git-svn-id: http://core.svn.wordpress.org/trunk@48725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-09 16:15:06 +00:00
17a4c20d55
Comments: Check if a valid comment ID was passed when editing a comment.
...
This avoids a PHP notice after submitting the Edit Comment form.
Props regan.khadgi.
Fixes #51263 .
Built from https://develop.svn.wordpress.org/trunk@48958
git-svn-id: http://core.svn.wordpress.org/trunk@48720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-08 13:41:08 +00:00
93b8183327
Media: In `wp_ajax_image_editor()`, check if the `error` property exists before accessing it.
...
This avoids a PHP notice when editing an image.
Follow-up to [48375].
Props Mista-Flo.
Fixes #51251 .
Built from https://develop.svn.wordpress.org/trunk@48946
git-svn-id: http://core.svn.wordpress.org/trunk@48708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-05 18:12:08 +00:00
e05edbcd53
Comments: Rename `WP_Comments_List_Table::comment_status_dropdown()` to `::comment_type_dropdown()`.
...
This better reflects the purpose of the method, which doesn't have anything to do with a comment status.
Follow-up to [48521].
Props davidbaumwald, johnbillion, SergeyBiryukov.
Fixes #51248 .
Built from https://develop.svn.wordpress.org/trunk@48943
git-svn-id: http://core.svn.wordpress.org/trunk@48705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-05 00:33:05 +00:00
dd03a5a156
Docs: Further correct placement for `wp_editor_expand` filter DocBlock.
...
This ensures that the filter is only applied if the conditions before it are evaluated to true.
Follow-up to [48714].
Props johnbillion.
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@48942
git-svn-id: http://core.svn.wordpress.org/trunk@48704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-04 21:48:07 +00:00
d0a32c5111
Docs: Various docblock corrections and improvements.
...
See #50768
Built from https://develop.svn.wordpress.org/trunk@48941
git-svn-id: http://core.svn.wordpress.org/trunk@48703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-04 20:41:07 +00:00
6d0491119e
Administration: Give the `$error` variable in `wp-admin/admin-header.php` a more descriptive name.
...
This avoids a conflict with the same global variable used elsewhere, e.g. in Theme Editor.
Follow-up to [48850].
Props vinayak.anivase.
Fixes #51219 .
Built from https://develop.svn.wordpress.org/trunk@48938
git-svn-id: http://core.svn.wordpress.org/trunk@48700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-03 01:43:07 +00:00
68dfbf51d9
Script Loader: Add backward compatibility for JavaScript i18n globals and properties deprecated in WordPress 5.5.
...
The recommended approach for any plugins using these globals or properties is to switch to the newer `wp.i18n` functions.
In the meantime, this ensures that accessing any of these globals does not break the rest of the code on the page, and an appropriate warning message is logged to the JavaScript console.
Follow-up to: https://core.trac.wordpress.org/query?summary=~wp.i18n&milestone=5.5
Props omarreiss, peterwilsoncc, kbjohnson90, johnbillion, TimothyBlynJacobs, joostdevalk, ocean90, desrosj, SergeyBiryukov.
Fixes #51123 .
Built from https://develop.svn.wordpress.org/trunk@48923
git-svn-id: http://core.svn.wordpress.org/trunk@48685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-31 20:30:03 +00:00
d4d3e23ad0
Themes: Normalize the installed theme path in `Theme_Installer_Skin::do_overwrite()` before comparing with the uploaded theme.
...
This ensures that the data for the currently installed theme is picked up properly when uploading a theme update on Windows.
Follow-up to [48390].
Props bobbingwide, wpamitkumar, mukesh27.
Fixes #51182 .
Built from https://develop.svn.wordpress.org/trunk@48913
git-svn-id: http://core.svn.wordpress.org/trunk@48675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-31 17:11:04 +00:00
ee33a7b019
Docs: Add a `@since` note to the `display_post_states` filter to clarify that it is now also applied in the Customizer context.
...
If any admin functions are used within the filter, their existence should be checked with `function_exists()` before being used.
Follow-up to [47763], [48620].
Props audrasjb, garrett-eclipse, Howdy_McGee, dlh, khag7, SergeyBiryukov.
Fixes #51081 .
Built from https://develop.svn.wordpress.org/trunk@48910
git-svn-id: http://core.svn.wordpress.org/trunk@48672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-31 13:32:04 +00:00
94555079eb
Docs: Clarify the usage of `null` for `auto_update_{$type}` filter.
...
The value is internally used to detect whether nothing has hooked into this filter.
Props audrasjb, pbiron, johnbillion, SergeyBiryukov.
Fixes #50848 .
Built from https://develop.svn.wordpress.org/trunk@48909
git-svn-id: http://core.svn.wordpress.org/trunk@48671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-31 13:20:07 +00:00
be4ad8548c
Administration: Correct the padding for "Warning: these pages should not be the same" messages on Reading Settings screen.
...
Replace the legacy `.error` class with a more appropriate `.notice-warning`.
Props musicaljoeker, shital-patel, man4toman, garrett-eclipse, SergeyBiryukov.
Fixes #50766 .
Built from https://develop.svn.wordpress.org/trunk@48906
git-svn-id: http://core.svn.wordpress.org/trunk@48668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-29 00:42:05 +00:00
af523447f4
Media: Make the `is_gd_image()` function available on front end.
...
This avoids a fatal error if a plugin calls image creation or editing functions like `wp_imagecreatetruecolor()` outside of the admin.
Follow-up to [48798]
Props BackuPs.
Fixes #51174 . See #50833 .
Built from https://develop.svn.wordpress.org/trunk@48905
git-svn-id: http://core.svn.wordpress.org/trunk@48667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-28 16:45:06 +00:00
71ffaac835
Docs: Correct formatting of the `auto_theme_update_send_email` filter DocBlock.
...
Synchronize description of the `$enabled` parameter with the `auto_plugin_update_send_email` filter.
Follow-up to [48889].
See #50768 , #50988 .
Built from https://develop.svn.wordpress.org/trunk@48903
git-svn-id: http://core.svn.wordpress.org/trunk@48665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-28 02:38:05 +00:00
308f752596
Upgrade/Install: Only display the auto-update links on the Network Admin > Themes screen for themes that support the feature.
...
Follow-up to [48669], [48688].
Props afragen, pbiron, audrasjb, desrosj, SergeyBiryukov.
Fixes #51129 .
Built from https://develop.svn.wordpress.org/trunk@48899
git-svn-id: http://core.svn.wordpress.org/trunk@48661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 22:24:07 +00:00
2aba7550c4
Upgrade/Install: Pass details about the specific plugin and theme updates attempted to filters.
...
This adds an additional parameter to the `auto_plugin_update_send_email` and `auto_theme_update_send_email` filters to provide the additional context of which updates were attempted and their outcome. This will help plugin and theme auto-update emails to be better tailored to a site owner’s liking.
Props audrasjb, Paddy Landau, desrosj.
Fixes #50988 .
Built from https://develop.svn.wordpress.org/trunk@48888
git-svn-id: http://core.svn.wordpress.org/trunk@48650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 19:27:03 +00:00
604b273c0f
Taxonomy: Make sure `wp_terms_checklist()` and `Walker_Category_Checklist::start_el()` properly handle an array of strings as `selected_cats` or `popular_cats` values.
...
Even with these values documented as an array of integers, they can technically also accept an array of strings, e.g. as form results.
Add a unit test.
Props brianhogg, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51137 .
Built from https://develop.svn.wordpress.org/trunk@48880
git-svn-id: http://core.svn.wordpress.org/trunk@48642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 02:48:06 +00:00
aa803be1ec
Upgrade/Install: Make the check for empty `home` option in `__get_option()` more resilient.
...
This addresses a regression in [47808], where the `home` check expected an empty string to use `siteurl` as a fallback, but `wpdb::get_var()` returns `null` if the option is empty.
Props fjarrett.
Fixes #51011 .
Built from https://develop.svn.wordpress.org/trunk@48868
git-svn-id: http://core.svn.wordpress.org/trunk@48630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-26 16:57:16 +00:00
9700ca0f55
Quick/Bulk Edit: Revert [48134] to address the bottom "Bulk actions" dropdown not functioning properly on Posts and Users list tables.
...
A better solution for the original issue will be explored in a future release.
Props audrasjb, garrett-eclipse, webzunft, Krstarica, chunkysteveo, SergeyBiryukov.
Fixes #50882 , #50998 . See #46872 .
Built from https://develop.svn.wordpress.org/trunk@48866
git-svn-id: http://core.svn.wordpress.org/trunk@48628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-26 14:18:04 +00:00
8c2c812cf9
Administration: Remove non-color related styling from Modern color scheme.
...
Color schemes should only affect colors, to avoid diverging from a consistent and predictable layout, especially if core CSS rules subsequently change.
Follow-up to [48277], [48286], [48345].
Props Joen, johnbillion, afercia, johnjamesjacoby.
Fixes #51127 . See #50504 .
Built from https://develop.svn.wordpress.org/trunk@48862
git-svn-id: http://core.svn.wordpress.org/trunk@48624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-26 13:19:08 +00:00
5ce95b7c88
Administration: Don't print the `.php-error` class in the admin header for PHP notices in `wp-config.php`.
...
Any notices in that file happen before `WP_DEBUG` takes effect, and should not be displayed with the `error_reporting` level previously set in `wp-load.php`.
Adding the class when there is no notice displayed results in extra padding under the admin bar, which should be avoided.
Follow-up to [20102], [21025], [26620], [47745].
Props akissz, tw2113, laxman-prajapati, sabernhardt, johnbillion, SergeyBiryukov.
Fixes #51073 .
Built from https://develop.svn.wordpress.org/trunk@48850
git-svn-id: http://core.svn.wordpress.org/trunk@48612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-24 10:48:06 +00:00
23b4fd4a86
Editor: Use `wp_add_inline_script()` instead of `wp_localize_script()` to pass the `_wpMetaBoxUrl` value to the `wp-editor` script.
...
This fixes a PHP 8 "Only the first byte will be assigned to the string offset" warning on Edit Post screen.
The correct usage of `wp_localize_script()` is to pass an array of data, not a string.
Fixes #51108 .
Built from https://develop.svn.wordpress.org/trunk@48841
git-svn-id: http://core.svn.wordpress.org/trunk@48603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-22 00:04:06 +00:00
5918f7e11d
Taxonomy: Allow for `wp_count_terms( $args )` signature, making passing a taxonomy optional.
...
This brings `wp_count_terms()` in line with other taxonomy functions such as `get_terms()` which technically no longer require a taxonomy. Similar to the previously modified functions, no deprecation warning is triggered when using the legacy signature.
Fixes #36399 .
Built from https://develop.svn.wordpress.org/trunk@48840
git-svn-id: http://core.svn.wordpress.org/trunk@48602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-21 22:32:06 +00:00
0c0e39d8bf
Privacy: Avoid a PHP 7.4 notice in `WP_Privacy_Policy_Content::text_change_check()`.
...
When iterating over the items stored in '_wp_suggested_privacy_policy_content` meta value for the Privacy Policy page, make sure the item is an array before accessing its properties.
Props treibstoff.
Fixes #51084 .
Built from https://develop.svn.wordpress.org/trunk@48836
git-svn-id: http://core.svn.wordpress.org/trunk@48598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-21 01:13:05 +00:00
25b0783629
Docs: Correct references to `WP_Filesystem_Base` methods in various DocBlocks.
...
Props pbiron.
Fixes #51087 .
Built from https://develop.svn.wordpress.org/trunk@48835
git-svn-id: http://core.svn.wordpress.org/trunk@48597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-21 00:43:05 +00:00
c66d70f2a5
Comments: Revert unintended changes from [48822].
...
See #51044 .
Built from https://develop.svn.wordpress.org/trunk@48823
git-svn-id: http://core.svn.wordpress.org/trunk@48585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-19 01:59:04 +00:00
3e16f7510a
Comments: Make sure the comment data passed to the `preprocess_comment` filter includes the `comment_agent` and `comment_author_IP` values.
...
Props zodiac1978, SergeyBiryukov.
Fixes #51044 .
Built from https://develop.svn.wordpress.org/trunk@48822
git-svn-id: http://core.svn.wordpress.org/trunk@48584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-19 01:57:08 +00:00
8b3a813e1a
Plugins: Avoid a PHP notice if the `update-supported` key in plugin data is not set.
...
Props sanzeeb3.
Fixes #51052 .
Built from https://develop.svn.wordpress.org/trunk@48820
git-svn-id: http://core.svn.wordpress.org/trunk@48582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-18 20:38:09 +00:00
fdeba269ca
Help/About: Fix typo and remove trailing spaces from some strings.
...
Props mukesh27, casiepa, davidbaumwald.
Fixes #51028 .
Built from https://develop.svn.wordpress.org/trunk@48809
git-svn-id: http://core.svn.wordpress.org/trunk@48571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 02:12:04 +00:00
e50ac120a3
Site Health: Ensure that the tests returned by `WP_Site_Health::get_tests()` always have the required array keys: `direct` and `async`.
...
This avoids PHP notices if these keys were accidentally removed using the `site_status_tests` filter.
Props khag7, Ov3rfly, desrosj, Clorith.
Fixes #50858 .
Built from https://develop.svn.wordpress.org/trunk@48808
git-svn-id: http://core.svn.wordpress.org/trunk@48570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 02:03:04 +00:00
d9135ad9d0
Site Health: Add site environment type to the debug information.
...
Follow-up to [47919], [48188], [48372].
Props joostdevalk, Clorith.
Fixes #50887 .
Built from https://develop.svn.wordpress.org/trunk@48802
git-svn-id: http://core.svn.wordpress.org/trunk@48564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-16 18:27:04 +00:00
7cb2ca73a2
Site Health: Rename the `$upload_max_size` variable to `$upload_max_filesize`, for consistency with the PHP setting name.
...
Follow-up to [48535], [48538], [48539], [48544], [48800].
See #50945 .
Built from https://develop.svn.wordpress.org/trunk@48801
git-svn-id: http://core.svn.wordpress.org/trunk@48563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-16 17:54:05 +00:00
88e668d8e6
Site Health: Only display the warning about the `post_max_size` PHP value when it's lower than `upload_max_filesize`.
...
Previously, the warning was displayed even if the value was higher than `upload_max_filesize`, which made the report inaccurate, as these values don't necessarily have to match.
Props oakesjosh, jeroenrotty, desrosj, Clorith.
Fixes #50945 .
Built from https://develop.svn.wordpress.org/trunk@48800
git-svn-id: http://core.svn.wordpress.org/trunk@48562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-16 17:48:08 +00:00
54184bf872
Docs: Fix typo in the `$image` parameter description in `is_gd_image()`.
...
Follow-up to [48798].
See #50833 .
Built from https://develop.svn.wordpress.org/trunk@48799
git-svn-id: http://core.svn.wordpress.org/trunk@48561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-16 14:02:03 +00:00
12c8f0e678
Code Modernization: Introduce `is_gd_image()` to check for PHP 8 `GdImage` object instances.
...
In PHP 8, the GD extension uses `GdImage` objects instead of resources for its underlying data structures.
This updates the existing `is_resource()` calls for image resources in core to accomodate for `GdImage` instances as well.
Props ayeshrajans, jrf.
Fixes #50833 .
Built from https://develop.svn.wordpress.org/trunk@48798
git-svn-id: http://core.svn.wordpress.org/trunk@48560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-16 13:33:09 +00:00
a5edb2a8a1
Filesystem API: Use correct variable when closing the file handle in `WP_Filesystem_FTPext::get_contents()`.
...
Props gothick@gothick.org.uk .
Fixes #51029 .
Built from https://develop.svn.wordpress.org/trunk@48797
git-svn-id: http://core.svn.wordpress.org/trunk@48559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-15 20:56:02 +00:00
440eb31bb7
Site Health: Recognize `define( 'WP_AUTO_UPDATE_CORE', 'minor' )` as an acceptable value.
...
Previously, it was only incidentally recognized as valid due to a loose comparison with `true`.
With the strict comparison added to `WP_Site_Health_Auto_Updates::test_constants()`, this was no longer the case.
Follow-up to [47841].
Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov.
Fixes #50912 .
Built from https://develop.svn.wordpress.org/trunk@48792
git-svn-id: http://core.svn.wordpress.org/trunk@48554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-14 20:39:08 +00:00
dc63fb7c85
Help/About: Final adjustments to the 5.5 About page.
...
- Final CDN asset URLs.
- Some minor color adjustments.
Props ryelle, marybaum, davidbaumwald, audrasjb, estelaris, afercia, cbringmann, andreamiddleton, desrosj, SergeyBiryukov, ocean90, nrqsnchz, spacedmonkey, whyisjake, man4toman.
Fixes #50416 .
Built from https://develop.svn.wordpress.org/trunk@48783
git-svn-id: http://core.svn.wordpress.org/trunk@48545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-11 16:53:09 +00:00
1f85e7484f
Docs: Consistently use third-person singular verbs for various filter descriptions, per the documentation standards.
...
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@48782
git-svn-id: http://core.svn.wordpress.org/trunk@48544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-11 00:34:08 +00:00
9214595e90
I18N: Fix typo in a screen reader text string on the About page.
...
Follow-up to [48729].
Props pedromendonca.
Fixes #50884 .
Built from https://develop.svn.wordpress.org/trunk@48770
git-svn-id: http://core.svn.wordpress.org/trunk@48532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-10 13:15:04 +00:00
5c0361aeb1
Coding Standards: Remove a few more extra brackets from some conditions in `wp-admin/includes/plugin.php`.
...
Follow-up to [48764].
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@48766
git-svn-id: http://core.svn.wordpress.org/trunk@48528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-09 01:56:05 +00:00
004e3f897f
Coding Standards: Fix WPCS issues in `wp-admin/includes/plugin.php`.
...
Includes minor code layout fixes for better readability.
Props rnaby for initial patch.
See #50767 , #43848 .
Built from https://develop.svn.wordpress.org/trunk@48764
git-svn-id: http://core.svn.wordpress.org/trunk@48526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-08 21:04:04 +00:00
f5a4ac614e
Coding Standards: Simplify some parts of `user_can_access_admin_page()` for better readability.
...
Props rnaby, valentinbora, khag7.
Fixes #43848 .
Built from https://develop.svn.wordpress.org/trunk@48762
git-svn-id: http://core.svn.wordpress.org/trunk@48524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-08 20:24:05 +00:00
1e5b6101e7
Help/About: Update videos and their descriptions on the About page.
...
Follow-up to [48675], [48686], [48721], [48729], [48730], [48736].
Props ryelle, marybaum, estelaris, desrosj, joen, afercia.
See #50416 .
Built from https://develop.svn.wordpress.org/trunk@48761
git-svn-id: http://core.svn.wordpress.org/trunk@48523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-08 14:16:02 +00:00
132942b9fa
Docs: Document the return value of `get_settings_errors()` using hash notation.
...
Props stevenlinx, webdevmattcrom, atachibana.
Fixes #42786 .
Built from https://develop.svn.wordpress.org/trunk@48760
git-svn-id: http://core.svn.wordpress.org/trunk@48522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-08 12:39:06 +00:00
961f455a00
Comments: Update DB version number used to trigger the upgrade routine for changing the `comment_type` DB field value in comments table.
...
Follow-up to [47597], [47626], [48225], [48227], [48748].
Props desrosj.
See #49236 .
Built from https://develop.svn.wordpress.org/trunk@48751
git-svn-id: http://core.svn.wordpress.org/trunk@48513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 16:32:03 +00:00
6b5e748dee
Docs: Correct usage of the dynamic `auto_update_{$type}` filter.
...
This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct.
Props johnbillion.
Fixes #50868 .
Built from https://develop.svn.wordpress.org/trunk@48750
git-svn-id: http://core.svn.wordpress.org/trunk@48512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 16:14:03 +00:00
5221a27593
Site Health: Consistently pass an object to the `auto_update_{$type}` filter in Site Health debug data.
...
Previously, some instances of the filter received an array from a plugin or theme update response, potentially triggering PHP notices.
Props bpayton, pbiron.
Fixes #50852 .
Built from https://develop.svn.wordpress.org/trunk@48745
git-svn-id: http://core.svn.wordpress.org/trunk@48507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 13:28:05 +00:00
3a32284b26
Posts, Post Types: Use a consistent wording in messages about a locked post.
...
Props ramiy.
Fixes #50859 .
Built from https://develop.svn.wordpress.org/trunk@48743
git-svn-id: http://core.svn.wordpress.org/trunk@48505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-06 13:14:08 +00:00
7e1e4f379a
Site Health: Check if `session_status()` exists before calling it.
...
Props bgermann.
Fixes #50862 .
Built from https://develop.svn.wordpress.org/trunk@48742
git-svn-id: http://core.svn.wordpress.org/trunk@48504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-06 00:25:07 +00:00
ee213e333b
Comments: Remove a few more unnecessary instances of `esc_html()` in `WP_Comments_List_Table::comment_status_dropdown()`.
...
Core translations are considered safe, and these labels are not escaped in any other instances.
Follow-up to [48521], [48722], [48724].
See #40188 , #50815 .
Built from https://develop.svn.wordpress.org/trunk@48741
git-svn-id: http://core.svn.wordpress.org/trunk@48503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-05 13:53:06 +00:00
2f878f1e74
Help/About: Correct header spacing on shorter screens after removing the musician name.
...
Remove some unnecessary CSS.
Follow-up to [48730].
Props ryelle.
See #50416 .
Built from https://develop.svn.wordpress.org/trunk@48736
git-svn-id: http://core.svn.wordpress.org/trunk@48498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 18:11:09 +00:00
aaf49752b2
Plugins: Move the "Successfully installed the plugin" string to the correct `Plugin_Upgrader` method.
...
The string refers to the installation, and belongs in the `::install_strings()` method, not in `::upgrade_strings()`.
Props sswebster, nateinaction, SergeyBiryukov.
Fixes #50837 .
Built from https://develop.svn.wordpress.org/trunk@48734
git-svn-id: http://core.svn.wordpress.org/trunk@48496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 17:54:04 +00:00
b84d7f1fd3
Site Health: Display auto-update properly for plugins that don't support auto-updates.
...
Properly filter `auto_update_plugin` when displaying the table.
Fixes #50822 .
Props Gwendydd, pbiron, audrasjb, SergeyBiryukov, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48731
git-svn-id: http://core.svn.wordpress.org/trunk@48493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 17:37:02 +00:00
fa9b043313
Help/About: Remove “Musician Name” placeholder.
...
The musician name is traditionally not included on the About page due to i18n concerns regarding last minute changes.
Props audrasjb, SergeyBiryukov.
See #50416 .
Built from https://develop.svn.wordpress.org/trunk@48730
git-svn-id: http://core.svn.wordpress.org/trunk@48492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 17:35:06 +00:00
527ca5ff78
Help/About: String updates and accessibility improvements to the 5.5 About page.
...
Props ryelle, nrqsnchz, desrosj, audrasjb, marybaum, spacedmonkey, SergeyBiryukov, estelaris, afercia, ocean90.
See #50416 .
Built from https://develop.svn.wordpress.org/trunk@48729
git-svn-id: http://core.svn.wordpress.org/trunk@48491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 17:26:03 +00:00
315db55458
Comments: Restore the `::has_items()` call in `WP_Comments_List_Table::extra_tablenav()` for now, until unit tests are updated accordingly.
...
Follow-up to [48722].
Fixes #40188 . See #50815 .
Built from https://develop.svn.wordpress.org/trunk@48724
git-svn-id: http://core.svn.wordpress.org/trunk@48486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 16:26:03 +00:00
b615c45103
Comments: Use the existing static variable instead of calling `::has_items()` again in `WP_Comments_List_Table::extra_tablenav()`.
...
Additionally, removed unnecessary `esc_html()` on the Filter button label. Core translations are considered safe, and this label is not escaped in any other instance.
Props whyisjake, SergeyBiryukov.
Fixes #40188 .
Built from https://develop.svn.wordpress.org/trunk@48722
git-svn-id: http://core.svn.wordpress.org/trunk@48484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 15:58:06 +00:00
500c0118d4
Help/About: String update for 5.5 release.
...
We don't use hyphens for the [block editor](https://make.wordpress.org/core/handbook/best-practices/spelling/ ).
See #50416 .
Props davidbaumwald, marybaum, desrosj.
Built from https://develop.svn.wordpress.org/trunk@48721
git-svn-id: http://core.svn.wordpress.org/trunk@48483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 15:56:02 +00:00
efdd927b48
Accessibility: Administration: Address backward compatibility concerns for the sortable postboxes areas after [48340].
...
Fixes #49288 .
Built from https://develop.svn.wordpress.org/trunk@48717
git-svn-id: http://core.svn.wordpress.org/trunk@48479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 13:17:02 +00:00
e2c8e2fa5a
Administration: Allow `wp_credits()` to accept `$version` and `$locale` parameters.
...
This can be helpful for plugin developers to get credits information for older versions or different locales.
Props ramiy.
Fixes #35910 .
Built from https://develop.svn.wordpress.org/trunk@48715
git-svn-id: http://core.svn.wordpress.org/trunk@48477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-03 12:53:08 +00:00
016df3b6c6
Docs: Correct placement for `wp_editor_expand` filter DocBlock.
...
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@48714
git-svn-id: http://core.svn.wordpress.org/trunk@48476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-03 12:11:06 +00:00
8ff7595ae9
Permalinks: Don't show "You should update your `.htaccess` file now" message when saving permalink settings on Multisite.
...
Multisite routing is taken care of by WordPress, not by the web server.
Follow-up to [13706], [37747], [38066].
Props boonebgorges.
Fixes #39547 .
Built from https://develop.svn.wordpress.org/trunk@48713
git-svn-id: http://core.svn.wordpress.org/trunk@48475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-02 12:57:08 +00:00
0a76cb6240
Permalinks: Simplify the logic for displaying "You should update your `.htaccess` file now" message.
...
See #39547 , #50834 .
Built from https://develop.svn.wordpress.org/trunk@48712
git-svn-id: http://core.svn.wordpress.org/trunk@48474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-02 12:51:03 +00:00
c9cf1ba365
Docs: Correct formatting for a comment in `wp-admin/options-permalink.php`.
...
Previously committed in [48694], accidentally reverted in [48710].
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@48711
git-svn-id: http://core.svn.wordpress.org/trunk@48473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-02 12:39:07 +00:00
38f653b639
Permalinks: Correct the check whether `.htaccess` update is required when saving permalink settings.
...
The check should be performed after the permalink structure update, not before.
Fixes #50834 .
Built from https://develop.svn.wordpress.org/trunk@48710
git-svn-id: http://core.svn.wordpress.org/trunk@48472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-02 12:36:02 +00:00
85c38d54e6
Upgrade/Install: Show the installed WordPress version number on WordPress Updates screen if there is a newer version available.
...
This makes it easier for a user to know how significant of an update the change might be, and helps them make an informed decision about how to proceed.
Props tmdesigned, dd32, circlecube, dkarfa, hakre, scribu, MadtownLems, markshep, nbachiyski, dmchale, miqrogroove, ovann86, danieltj, sterndata, seanpaulrasmussen, mrgrt, Commeuneimage, dpacks, puneetsahalot, jonoaldersonwp, SergeyBiryukov.
Fixes #15101 . See #35554 , #47848 .
Built from https://develop.svn.wordpress.org/trunk@48709
git-svn-id: http://core.svn.wordpress.org/trunk@48471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-01 19:46:04 +00:00
224fdb27b8
Upgrade/Install: Ensure the proper count of plugins that have auto-update enabled.
...
As certain plugins may not support updates, this count needs to accurately reflect that in the navbar.
Fixes 50808.
Props knutsp, audrasjb, pbiron, dd32, apedog, afragen, chriscct7, garyc40, whyisjake, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@48703
git-svn-id: http://core.svn.wordpress.org/trunk@48465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-31 17:21:04 +00:00
b4497ef13f
Upgrade/Install: Allow for WordPress.org to remotely disable auto-updates for plugins/themes
...
As auto-updates are rolled out across WordPress.org, the API response can modulate the response, ensuring that a rolled out could be stalled or staggered if needed for security or performance reasons.
Fixes #50824 .
Props dd32, whyisjake, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@48701
git-svn-id: http://core.svn.wordpress.org/trunk@48463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-31 17:03:05 +00:00
3f83523b4e
Editor: Correctly back up the global `$post` in `wp-admin/edit-form-blocks.php`.
...
To create a copy of the object, instead of a reference to the same object, the `clone` keyword should be used.
Props scarolan.
Fixes #50775 .
Built from https://develop.svn.wordpress.org/trunk@48700
git-svn-id: http://core.svn.wordpress.org/trunk@48462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-31 14:00:05 +00:00
078db63c4b
Upgrade/Install: Pass the plugin file path into the `plugin_auto_update_debug_string` filter.
...
Adds better tooling for when user specific plugins can be updated, but platform specific ones cannot.
Fixes #50821 .
Props bpayton, pbiron, audrasjb, SergeyBiryukov, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48696
git-svn-id: http://core.svn.wordpress.org/trunk@48458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-30 21:50:02 +00:00
629af79b24
Docs: Correct formatting for a comment in `wp-admin/options-permalink.php`.
...
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@48694
git-svn-id: http://core.svn.wordpress.org/trunk@48456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-30 14:02:04 +00:00
cf137e7c1b
Comments: Pass the `$which` parameter to the `manage_comments_nav` action.
...
This brings some consistency with the `manage_users_extra_tablenav` and `manage_users_extra_tablenav` actions.
Props Tkama, wpgurudev.
Fixes #50736 .
Built from https://develop.svn.wordpress.org/trunk@48693
git-svn-id: http://core.svn.wordpress.org/trunk@48455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-30 13:27:04 +00:00
72b87b3d74
Themes: Pass correct variable to `is_php_version_compatible()` in `wp_theme_update_row()`.
...
This applies to the Themes screen in Multisite network admin.
Follow-up to [48660].
Props pbiron, afragen.
Fixes #48507 . See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48689
git-svn-id: http://core.svn.wordpress.org/trunk@48451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-29 21:08:02 +00:00
e6bfdde581
Upgrade/Install: Only show auto-update for themes that support the feature.
...
Similar to the changes for plugins in [48669], let's only show the UI for themes when updates are supported for that theme.
See #50280 .
Props dd32.
Built from https://develop.svn.wordpress.org/trunk@48688
git-svn-id: http://core.svn.wordpress.org/trunk@48450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-29 20:01:08 +00:00
1d552ea6b1
Help/About: Adjust two strings on the About page for better i18n.
...
Follow-up to [48675].
Props ocean90, audrasjb, kittmedia, nao.
See #50416 .
Built from https://develop.svn.wordpress.org/trunk@48686
git-svn-id: http://core.svn.wordpress.org/trunk@48448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-29 13:29:04 +00:00
d351100eba
Upgrade/Install: Pass correct argument to `clear_destination` in `Theme_Upgrader::install()`.
...
Follow-up to [48390].
Props afragen, sabernhardt.
Fixes #9757 .
Built from https://develop.svn.wordpress.org/trunk@48685
git-svn-id: http://core.svn.wordpress.org/trunk@48447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-29 13:09:04 +00:00
c5ef3b7976
Media: Pass the `$rel` parameter to `image_send_to_editor` filter.
...
Props mihdan, pputzer.
Fixes #50765 .
Built from https://develop.svn.wordpress.org/trunk@48684
git-svn-id: http://core.svn.wordpress.org/trunk@48446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 21:21:05 +00:00
d8fd6d05a3
Upgrade/Install: Swap `auto-update-supported` to `update-supported` in update checks.
...
Ensures backwards compatability with external updaters.
See #50280 .
Props everyone-in-the-core-updates-channel.
Built from https://develop.svn.wordpress.org/trunk@48678
git-svn-id: http://core.svn.wordpress.org/trunk@48440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 18:28:06 +00:00
6209a40fd9
Upgrade/Install: Clarify the descriptions for `install_(plugin|theme)_overwrite_actions`.
...
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48677
git-svn-id: http://core.svn.wordpress.org/trunk@48439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 18:16:07 +00:00
1aa48c68f5
Upgrade/Install: Correct spelling of “overwrite” in new hooks and array indexes.
...
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48676
git-svn-id: http://core.svn.wordpress.org/trunk@48438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 17:56:04 +00:00
7267fc02b0
Help/About: WordPress 5.5 About Page.
...
Speed. Search. Security.
This is the start of the WordPress 5.5 about page.
Fixes #50416 .
Props ryelle, marybaum, estelaris, yvettesonneveld, michelebutcher-jones, metalandcoffee, melchoyce, marktimemedia, abhanonstopnewsuk, elmastudio, davidbaumwald, audrasjb, afercia, cbringmann, andreamiddleton, desrosj, earnjam, SergeyBiryukov, whyisjake, elrae.
Built from https://develop.svn.wordpress.org/trunk@48675
git-svn-id: http://core.svn.wordpress.org/trunk@48437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 17:46:04 +00:00
eb0869755e
Administration: Correct alignment of the "PHP Update Required" dashboard box title.
...
Restore one instance of `!important` CSS rule for backward compatibility.
Follow-up to [48129], [48373].
Props whyisjake, sabernhardt, TimothyBlynJacobs, SergeyBiryukov.
Fixes #50788 .
Built from https://develop.svn.wordpress.org/trunk@48671
git-svn-id: http://core.svn.wordpress.org/trunk@48433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 17:08:03 +00:00
e4b2ad02b6
Administration: Don't override the `$mode` global in `WP_Screen::render_view_mode()` if it's already set.
...
Follow-up to [48398], [48423], [48424], [48450].
See #49715 .
Built from https://develop.svn.wordpress.org/trunk@48670
git-svn-id: http://core.svn.wordpress.org/trunk@48432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:55:04 +00:00
0f1f9bdb03
Upgrade/Install: Enhance auto-updates to be disabled for plugins that don't suport updates.
...
This removes the toggle UI when updates aren't available. When plugins use the filter, the UI is updated to show that they are being controlled via code. And then removed entirely when not available.
See #50798 .
Fixes #50280 .
Props elrae, pbiron, SergeyBiryukov, audrasjb, azaozz, StephenCronin, whyisjake, dd32, TimothyBlynJacobs, desrosj.
Built from https://develop.svn.wordpress.org/trunk@48669
git-svn-id: http://core.svn.wordpress.org/trunk@48431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:32:01 +00:00
2bf5b5749f
Administration: Pull the `table_view_mode` filter for now.
...
The extensibility of list table view modes will be explored in a future release.
Props audrasjb.
See #49715 .
Built from https://develop.svn.wordpress.org/trunk@48668
git-svn-id: http://core.svn.wordpress.org/trunk@48430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:19:03 +00:00
3db534a988
Upgrade/Install: Disable the plugin/theme auto-updates UI if `AUTOMATIC_UPDATER_DISABLED` is defined and set as `true`.
...
Props pbiron, dd32.
Fixes #50798 . See #50280 .
Built from https://develop.svn.wordpress.org/trunk@48667
git-svn-id: http://core.svn.wordpress.org/trunk@48429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:15:03 +00:00
4cfc383544
Upgrade/Install: Check WordPress and PHP version requirements when uploading a plugin or theme from ZIP file.
...
Props mariovalney, desrosj.
See #50593 .
Built from https://develop.svn.wordpress.org/trunk@48666
git-svn-id: http://core.svn.wordpress.org/trunk@48428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:07:02 +00:00
0dd2f9f5c5
Docs: Add missing documentation for various upgrade/install class properties and methods.
...
Props ramiy.
Fixes #42923 .
Built from https://develop.svn.wordpress.org/trunk@48661
git-svn-id: http://core.svn.wordpress.org/trunk@48423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 11:57:03 +00:00
a745f035ab
Themes: Display a message on Themes list table if a theme update requires a higher version of PHP or WordPress.
...
This applies to the Themes screen in Multisite network admin.
Props afragen, SergeyBiryukov.
Fixes #48507 . See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48660
git-svn-id: http://core.svn.wordpress.org/trunk@48422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 11:34:04 +00:00
e349d92b53
Themes: Include theme name in available update messages, for better accessibility and consistency with other similar messages.
...
Follow-up to [48652-48654].
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48659
git-svn-id: http://core.svn.wordpress.org/trunk@48421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 11:31:01 +00:00
8c3d56919e
Upgrade/Install: Improve `wp_opcache_invalidate()` performance.
...
Changes from using `preg_match()` based `.php` extension checking to using `substr()` in `wp_opcache_invalidate()`.
Props jnylen0, aaroncampbell, SergeyBiryukov, desrosj, mikeschroder.
Fixes #50784 .
Built from https://develop.svn.wordpress.org/trunk@48657
git-svn-id: http://core.svn.wordpress.org/trunk@48419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 08:09:05 +00:00
26b706e27f
Site Health: Incorrect file path in `require_once`.
...
Ensure that background updater can be loaded for testing to see if auto-updates can enable automatic updates.
Fixes #50793 .
Props dd32.
Built from https://develop.svn.wordpress.org/trunk@48655
git-svn-id: http://core.svn.wordpress.org/trunk@48417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 02:21:06 +00:00
db175a9868
Themes: Display a message in theme updates list if an update requires a higher version of PHP or WordPress.
...
This applies to the WordPress Updates screen.
Props afragen, SergeyBiryukov.
Fixes #48491 .
Built from https://develop.svn.wordpress.org/trunk@48654
git-svn-id: http://core.svn.wordpress.org/trunk@48416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 01:02:04 +00:00
ab6c396531
Themes: Correct the logic for displaying a message in theme grid if a theme update requires a higher version of PHP or WordPress.
...
This applies to the Themes screen fallback used when JS is turned off.
Follow-up to [48652].
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48653
git-svn-id: http://core.svn.wordpress.org/trunk@48415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 00:43:02 +00:00
0122e035b0
Themes: Display a message in theme grid and Theme Details modal if a theme update requires a higher version of PHP or WordPress.
...
This applies to the Themes screen and the Customizer theme browser.
Props afragen, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48652
git-svn-id: http://core.svn.wordpress.org/trunk@48414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 00:09:02 +00:00
6307a7c41c
Docs: Correct alignment for some parameters in JS documentation.
...
Follow-up to [48650].
See #43828 .
Built from https://develop.svn.wordpress.org/trunk@48651
git-svn-id: http://core.svn.wordpress.org/trunk@48413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 00:07:03 +00:00
3dd9628aae
Build/Test Tools: Enable JSDocs to be linted with ESLint.
...
As part of the [Javascript Inline Docs Initiative](https://make.wordpress.org/core/handbook/docs/inline/js/ ) this add some tooling to lint Javascript docblocks. Two new commands:
* `npm run lint:jsdoc`
* `npm run lint:jsdoc:fix`
The latter will run the linter and try to fix an possible issues automatically.
Fixes #43828 .
Props netweb, atimmer, kamataryo, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48650
git-svn-id: http://core.svn.wordpress.org/trunk@48412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 23:35:02 +00:00
bb54ebcd0d
Administration: Fix the red links on the Media Modal.
...
The custom link colors for admin scheme colors were overriding the danger color.
Props kebbet, dlh.
Fixes #50547 .
Built from https://develop.svn.wordpress.org/trunk@48643
git-svn-id: http://core.svn.wordpress.org/trunk@48405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 19:17:05 +00:00
e071ace6c4
Themes: Display a message in theme grid if a theme requires a higher version of PHP or WordPress.
...
This applies to the Themes screen fallback used when JS is turned off.
Props afragen, desrosj, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48640
git-svn-id: http://core.svn.wordpress.org/trunk@48402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 15:21:02 +00:00
4336a2b9a7
Themes: Display a message in theme grid if a theme requires a higher version of PHP or WordPress.
...
This applies to the Themes screen, Add Themes screen, and the Customizer theme browser.
Props afragen, desrosj, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48638
git-svn-id: http://core.svn.wordpress.org/trunk@48400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 15:04:03 +00:00
39147698d9
Themes: Display a message in Details & Preview modal on Add Themes screen if a theme requires a higher version of PHP or WordPress.
...
Props afragen, desrosj, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48637
git-svn-id: http://core.svn.wordpress.org/trunk@48399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 14:26:07 +00:00
1f89186a3d
Themes: Display a message in Theme Details modal if a theme requires a higher version of PHP or WordPress.
...
Props afragen, desrosj, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48636
git-svn-id: http://core.svn.wordpress.org/trunk@48398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 13:12:04 +00:00
9ec7f2febd
Docs: Correct `wp_opcache_invalidate_file` filter docs.
...
Changes incorrectly named `$filename` variable to `$filepath` and adjusts wording to align with PHP docs.
See #36455 .
Built from https://develop.svn.wordpress.org/trunk@48632
git-svn-id: http://core.svn.wordpress.org/trunk@48394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 09:08:05 +00:00
df74d8f10d
Revisions: Ensure the global `$post` remains the same after revision is restored.
...
Because `wp_insert_post()` and `wp_transition_post_status()` are called during the process, plugins can unexpectedly modify `$post`.
Props markparnell, tofandel, archon810, SergeyBiryukov.
Fixes #46671 .
Built from https://develop.svn.wordpress.org/trunk@48625
git-svn-id: http://core.svn.wordpress.org/trunk@48387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-26 21:25:02 +00:00
a6cf8df9d1
Docs: Synchronize some comments in `wp-admin/revision.php`.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48624
git-svn-id: http://core.svn.wordpress.org/trunk@48386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-26 20:43:02 +00:00
d8c62b5647
Posts, Post Types: Move `get_post_states()` back to the admin for now, require the file in `WP_Customize_Nav_Menus::customize_register()` instead.
...
This provides a minor performance improvement by only running the function in contexts where it's needed.
Follow-up to [47211], [47213], [47763], [48619].
See #46829 , #49374 .
Built from https://develop.svn.wordpress.org/trunk@48620
git-svn-id: http://core.svn.wordpress.org/trunk@48382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-26 10:51:06 +00:00
aab535a576
Posts, Post Types: Make `get_post_states()` available on frontend.
...
This allows special pages to be denoted as such when editing a menu in the Customizer.
This applies to the Front Page, Posts Page, and Privacy Policy Page.
Follow-up to [47211], [47213], [47763].
Props dlh, whyisjake, SergeyBiryukov.
Fixes #46829 . See #49374 .
Built from https://develop.svn.wordpress.org/trunk@48619
git-svn-id: http://core.svn.wordpress.org/trunk@48381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-26 01:14:06 +00:00
609acd89ed
I18N: Merge duplicate "List view" and "Grid view" strings.
...
Props ramiy.
Fixes #50757 .
Built from https://develop.svn.wordpress.org/trunk@48618
git-svn-id: http://core.svn.wordpress.org/trunk@48380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 21:32:05 +00:00
c40a645510
Docs: Correct `@see` references for privacy hooks:
...
* `wp_privacy_personal_data_export_page`
* `wp_privacy_personal_data_erasure_page`
Hooks should be single-quoted when referenced.
Props pbiron, coffee2code.
See #49572 , #meta5318.
Built from https://develop.svn.wordpress.org/trunk@48616
git-svn-id: http://core.svn.wordpress.org/trunk@48378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 19:14:03 +00:00
7d305c8ff9
Docs: Correct `@since` tags for some `WP_List_Table` hooks:
...
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
Follow-up to [15491], [15578], [26401].
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48615
git-svn-id: http://core.svn.wordpress.org/trunk@48377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 18:55:03 +00:00
0ef0a1905b
Docs: Remove outdated statement in `bulk_actions-{$this->screen->id}` filter description.
...
As of WordPress 4.7, developers can register their own bulk actions on list table screens.
Follow-up to [17297], [38647].
Props joyously, pbiron.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48614
git-svn-id: http://core.svn.wordpress.org/trunk@48376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 18:13:02 +00:00
ef382e6aaf
Site Health: Escape the displayed result of the request in REST API availability test.
...
Props siliconforks, gisselfeldt.
Fixes #50588 .
Built from https://develop.svn.wordpress.org/trunk@48608
git-svn-id: http://core.svn.wordpress.org/trunk@48370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 15:38:06 +00:00
b6f52721ed
Administration: Use sentence case for "Mark as spam" bulk action links for sites and users, for consistency with comments.
...
Follow-up to [48352].
See #40244 .
Built from https://develop.svn.wordpress.org/trunk@48595
git-svn-id: http://core.svn.wordpress.org/trunk@48357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-24 00:27:03 +00:00
703a978a77
Administration: Capitalize `Trash` consistently in various messages.
...
When used as a noun referring to the "virtual" place, `Trash` should be capitalized.
Follow-up to [47233], [48352].
See #45317 , #40244 .
Built from https://develop.svn.wordpress.org/trunk@48594
git-svn-id: http://core.svn.wordpress.org/trunk@48356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-24 00:21:03 +00:00
9bc7d0a776
Docs: Another pass at some inline docs fixes mostly made by PHPCBF.
...
See #49572 , #50744
Built from https://develop.svn.wordpress.org/trunk@48590
git-svn-id: http://core.svn.wordpress.org/trunk@48352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 21:11:05 +00:00
3f04e3bf5c
I18N: Further adjust some update/install strings for consistency.
...
Follow-up to [48568], [48569].
See #50708 , #50714 .
Built from https://develop.svn.wordpress.org/trunk@48589
git-svn-id: http://core.svn.wordpress.org/trunk@48351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 21:08:01 +00:00
5950e15042
I18N: Merge two "Return to top" strings.
...
Props ramiy, carike, whyisjake.
Fixes #50743 .
Built from https://develop.svn.wordpress.org/trunk@48588
git-svn-id: http://core.svn.wordpress.org/trunk@48350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 20:21:07 +00:00
161821d155
Site Health: Correct the quotes for the `tested` value of mock plugin data in auto-updates test.
...
Follow-up to [48584].
See #50662 .
Built from https://develop.svn.wordpress.org/trunk@48587
git-svn-id: http://core.svn.wordpress.org/trunk@48349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 20:13:05 +00:00
57a3f803ae
Docs: First pass at some inline docs fixes mostly made by PHPCBF.
...
See #49572 , #50744
Built from https://develop.svn.wordpress.org/trunk@48586
git-svn-id: http://core.svn.wordpress.org/trunk@48348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 20:01:04 +00:00
7f898dd9c4
Docs: Use more appropriate variable names in the inline docs for action and filter parameters.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48585
git-svn-id: http://core.svn.wordpress.org/trunk@48347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 19:06:03 +00:00
231d21ebcd
Site Health: Pass all expected parameters to `auto_update_{$type}`.
...
This prevents fatal errors when other hooked functions are expecting both parameters.
Props dd32, desrosj, audrasjb, pbiron.
Fixes #50662 .
Built from https://develop.svn.wordpress.org/trunk@48584
git-svn-id: http://core.svn.wordpress.org/trunk@48346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 19:03:04 +00:00
0eb1b2a447
I18N: Update "Default Template" string to match the sentence case used in the block editor.
...
Props ramiy.
Fixes #50742 .
Built from https://develop.svn.wordpress.org/trunk@48583
git-svn-id: http://core.svn.wordpress.org/trunk@48345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 18:55:01 +00:00
2c2508f98c
General: Ensure the database upgrades from [48575] are run.
...
This corrects the database version to match the commit number the upgrade changes were made.
See #50413 .
Built from https://develop.svn.wordpress.org/trunk@48582
git-svn-id: http://core.svn.wordpress.org/trunk@48344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 18:43:04 +00:00
124972f2c6
Docs: Further corrections and improvements to various inline docblocks.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48576
git-svn-id: http://core.svn.wordpress.org/trunk@48338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 07:39:02 +00:00
6cab8cce22
General: Update code for readability and inclusion
...
There are two pieces in here:
1) The update to change blacklist to blocklist is moved to disallowed_list. "Block" has a meaning in our code, and there could be ambiguity between this code and code related to blocks.
2) This improves backwards compatibility for code that was accessing the now deprecated code.
Previously: [48477], [48405], [48400], [48121], [48122], [48124], [48142], [48566]
Props: desrosj, SergeyBiryukov, johnjamesjacoby
Fixes : #50413
Built from https://develop.svn.wordpress.org/trunk@48575
git-svn-id: http://core.svn.wordpress.org/trunk@48337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 03:14:06 +00:00
0bf9b04c53
Docs: Various formatting improvements to inline docblocks.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48574
git-svn-id: http://core.svn.wordpress.org/trunk@48336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 00:52:05 +00:00
Sergey Biryukov
Adam Silverstein
John Blackbourn
noisysocks
desrosj
Helen Hou-Sandí
Felix Arntz
whyisjake
Andrea Fercia
Mike Schroder
youknowriad
Aaron Jorbin