John Blackbourn
702e4e8ea7
Don't set `CURLOPT_CAINFO` when `sslverify` is false when sending HTTP API requests through cURL. This avoids sending redundant information to cURL, and avoids a bug in Apple's SecureTransport library which causes a request to fail when a CA bundle is set but certificate verification is disabled.
...
This fixes issues with local HTTPS requests (eg. WP Cron) on OS X where cURL is using SecureTransport instead of OpenSSL.
Fixes #33978
Built from https://develop.svn.wordpress.org/trunk@34639
git-svn-id: http://core.svn.wordpress.org/trunk@34603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 21:37:24 +00:00
John Blackbourn
cbdd8e5494
Introduce `WP_UnitTestCase::assertNotWPError()` for when a test needs to assert that something is, well, not a `WP_Error`.
...
See #33978
Built from https://develop.svn.wordpress.org/trunk@34638
git-svn-id: http://core.svn.wordpress.org/trunk@34602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 21:29:26 +00:00
Helen Hou-Sandí
9cfddb6c3b
Autoprefixer for [34634].
...
Normally when there are multiple comma-separated values in CSS, each one would go on its own indented line. However, Autoprefixer appears to be tripping up on gradients at the moment, so it's going to stay on one line until we investigate upstream.
see #33299 .
Built from https://develop.svn.wordpress.org/trunk@34637
git-svn-id: http://core.svn.wordpress.org/trunk@34601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 19:17:25 +00:00
Scott Taylor
f78170934a
Users List Table: show the "Change role to" dropdown on the top and bottom. Currently only shows on top.
...
See #27743 .
Built from https://develop.svn.wordpress.org/trunk@34636
git-svn-id: http://core.svn.wordpress.org/trunk@34600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 19:11:26 +00:00
Drew Jaynes
9c46736476
Docs: Fix some syntatical issues in the DocBlock for `WP::send_headers()` following [34632].
...
See #20226 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34635
git-svn-id: http://core.svn.wordpress.org/trunk@34599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 18:49:29 +00:00
Scott Taylor
1c74c7108f
Feature Image: Improve the preview for transparent background images by using CSS3 to show a checkered background.
...
Props metodiew.
Fixes #33299 .
Built from https://develop.svn.wordpress.org/trunk@34634
git-svn-id: http://core.svn.wordpress.org/trunk@34598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 18:41:25 +00:00
Scott Taylor
7bc7ea0076
After [34629], update unit tests to reflect this change.
...
See #32093 .
Built from https://develop.svn.wordpress.org/trunk@34633
git-svn-id: http://core.svn.wordpress.org/trunk@34597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 18:30:24 +00:00
Scott Taylor
8272a839cd
Update the docs in `WP` to explain the need to do [34476].
...
Fixes #20226 .
Built from https://develop.svn.wordpress.org/trunk@34632
git-svn-id: http://core.svn.wordpress.org/trunk@34596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 18:28:24 +00:00
Drew Jaynes
ccef2fc743
Docs: Add documentation for the `$browse`, `$user`, `$search`, `$author`, `$tag`, `$installed_plugins`, and `$page` parameters in `plugins_api()`.
...
Props ocean90.
Fixes #34035 .
Built from https://develop.svn.wordpress.org/trunk@34631
git-svn-id: http://core.svn.wordpress.org/trunk@34595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 18:13:48 +00:00
Scott Taylor
d6774f0f6d
Nav Menus: in `wp_nav_menu()`, `$container` is already bound to a list of allowed tags. PHP, being its whimsical self, while return `true` if someone sets `$container` to `true` via `in_array( true, [ 'div', 'nav' ] )`. Check that `$container` is a string before the `in_array()` check. `'true'` does not pass.
...
Props shedonist for the original patch.
Fixes #32464 .
Built from https://develop.svn.wordpress.org/trunk@34630
git-svn-id: http://core.svn.wordpress.org/trunk@34594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 18:13:24 +00:00
Scott Taylor
1b6ed5cbb7
Add `size-$size` class to `<img>` in `wp_get_attachment_image()`.
...
Fixes #32093 .
Built from https://develop.svn.wordpress.org/trunk@34629
git-svn-id: http://core.svn.wordpress.org/trunk@34593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 17:54:27 +00:00
Boone Gorges
b581489e93
Add test for `get_term_by( 'slug' )` behavior with accented chars.
...
When passing a value of 'slug' to `wp_insert_term()` that contains non-ASCII
characters, WordPress converts accented characters to non-accented versions.
(See `sanitize_title()` and `remove_accents()`.) The same conversion happens
when fetching when fetching a term using a slug. In this way, it's possible to
create a term and fetch it using the same accented string, even though the slug
is actually stored with non-accented characters.
See #16282 .
Built from https://develop.svn.wordpress.org/trunk@34628
git-svn-id: http://core.svn.wordpress.org/trunk@34592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 16:32:26 +00:00
Boone Gorges
03870781b1
Move `get_term_by()` tests to their own file.
...
Built from https://develop.svn.wordpress.org/trunk@34627
git-svn-id: http://core.svn.wordpress.org/trunk@34591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 16:10:26 +00:00
Boone Gorges
320b12ac96
Add unit test verifying that 60 char `user_login` is valid.
...
Props ruudjoyo.
Fixes #33793 .
Built from https://develop.svn.wordpress.org/trunk@34626
git-svn-id: http://core.svn.wordpress.org/trunk@34590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 15:42:27 +00:00
Boone Gorges
c243d7070e
Introduce `'the_category_list'` filter.
...
Used to filter categories as structured data, before building markup in
`get_the_category_list()`.
We use this filter in addition to upstream filters (such as
'get_the_categories'`) because those upstream filters are used in numerous
contexts, while `'the_category_list'` is always used for generating markup
for display.
Props KevinB, ericlewis, SergeyBiryukov, DrewAPicture.
Fixes #9227 .
Built from https://develop.svn.wordpress.org/trunk@34625
git-svn-id: http://core.svn.wordpress.org/trunk@34589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 02:22:24 +00:00
Boone Gorges
1ae565455b
Pass the post ID to the `get_the_categories` filter.
...
Props SergeyBiryukov.
See #9227 .
Built from https://develop.svn.wordpress.org/trunk@34624
git-svn-id: http://core.svn.wordpress.org/trunk@34588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 02:17:25 +00:00
Boone Gorges
1573a8a1b7
`WP_Comment::get_children()` test should be order-agnostic.
...
See #8071 .
Built from https://develop.svn.wordpress.org/trunk@34623
git-svn-id: http://core.svn.wordpress.org/trunk@34587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 02:01:25 +00:00
Drew Jaynes
c3a83b5726
Restore and deprecate the `WP_Widget_Recent_Comments::flush_widget_cache()` method, removed in [34580].
...
Fixes #25556 .
Built from https://develop.svn.wordpress.org/trunk@34622
git-svn-id: http://core.svn.wordpress.org/trunk@34586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 01:40:26 +00:00
Drew Jaynes
ad089ffe15
Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Nav_Menu_Widget`.
...
Props leemon.
Fixes #34015 . Fixes #34013 .
Built from https://develop.svn.wordpress.org/trunk@34621
git-svn-id: http://core.svn.wordpress.org/trunk@34585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 01:16:24 +00:00
Drew Jaynes
c1796c55c3
Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Archives`.
...
Props leemon.
Fixes #34016 . See #34013 .
Built from https://develop.svn.wordpress.org/trunk@34620
git-svn-id: http://core.svn.wordpress.org/trunk@34584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 01:11:25 +00:00
Drew Jaynes
a05eb043c3
Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Calendar`.
...
Props leemon.
Fixes #34017 . See #34013 .
Built from https://develop.svn.wordpress.org/trunk@34619
git-svn-id: http://core.svn.wordpress.org/trunk@34583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 01:07:25 +00:00
Drew Jaynes
e0d024b355
Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, `form()`, and `_get_current_taxonomy()` methods in `WP_Widget_Categories`.
...
Props leemon.
Fixes #34018 . See #34013 .
Built from https://develop.svn.wordpress.org/trunk@34618
git-svn-id: http://core.svn.wordpress.org/trunk@34582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 01:04:25 +00:00
Drew Jaynes
192e7f8c61
Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Links`.
...
Props leemon.
Fixes #34019 . See #34013 .
Built from https://develop.svn.wordpress.org/trunk@34617
git-svn-id: http://core.svn.wordpress.org/trunk@34581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 01:00:24 +00:00
Drew Jaynes
233ecbfdb8
Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Meta`.
...
Props leemon.
Fixes #34020 . See #34013 .
Built from https://develop.svn.wordpress.org/trunk@34616
git-svn-id: http://core.svn.wordpress.org/trunk@34580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 00:58:24 +00:00
Drew Jaynes
033c9b8d7f
Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Pages`.
...
Props leemon.
Fixes #34021 . See #34013 .
Built from https://develop.svn.wordpress.org/trunk@34615
git-svn-id: http://core.svn.wordpress.org/trunk@34579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 00:54:24 +00:00
Drew Jaynes
5ab3821730
Docs: Improve documentation for the `__construct()`, `recent_comments_style()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Recent_Comments`.
...
Also fixes a typo in the class DocBlock.
Props leemon.
Fixes #34022 . See #34013 .
Built from https://develop.svn.wordpress.org/trunk@34614
git-svn-id: http://core.svn.wordpress.org/trunk@34578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 00:51:24 +00:00
Drew Jaynes
e76083ce6e
Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Recent_Posts`.
...
Also fixes a typo in the class DocBlock.
Props leemon.
Fixes #34023 . See #34013 .
Built from https://develop.svn.wordpress.org/trunk@34613
git-svn-id: http://core.svn.wordpress.org/trunk@34577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 00:46:25 +00:00
Drew Jaynes
4f8f817865
Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_RSS`.
...
Props leemon.
Fixes #34024 . See #34013 .
Built from https://develop.svn.wordpress.org/trunk@34612
git-svn-id: http://core.svn.wordpress.org/trunk@34576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 00:42:24 +00:00
Drew Jaynes
80a32b4bc8
Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Search`.
...
Props leemon.
Fixes #34025 . See #34013 .
Built from https://develop.svn.wordpress.org/trunk@34611
git-svn-id: http://core.svn.wordpress.org/trunk@34575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 00:37:24 +00:00
Drew Jaynes
08277293e5
Docs: Improve the documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Tag_Cloud`.
...
Props leemon.
Fixes #34026 . See #34013 .
Built from https://develop.svn.wordpress.org/trunk@34610
git-svn-id: http://core.svn.wordpress.org/trunk@34574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 00:32:24 +00:00
Drew Jaynes
83da7624e6
Docs: Improve documentation for the `__construct()`, `widget()`, `update()`, and `form()` methods in `WP_Widget_Text`.
...
(first!) Props leemon.
Fixes #34027 .
Built from https://develop.svn.wordpress.org/trunk@34609
git-svn-id: http://core.svn.wordpress.org/trunk@34573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 00:27:26 +00:00
John Blackbourn
bc4b983f89
Add function signature tests for the pluggable functions in wp-admin/includes/schema.php and wp-admin/includes/upgrade.php.
...
See #33867
Built from https://develop.svn.wordpress.org/trunk@34608
git-svn-id: http://core.svn.wordpress.org/trunk@34572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 22:04:24 +00:00
John Blackbourn
336ac6e5d9
Add function signature tests for the pluggable functions in `wp-includes/cache.php`.
...
See #33867
Built from https://develop.svn.wordpress.org/trunk@34607
git-svn-id: http://core.svn.wordpress.org/trunk@34571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 22:03:25 +00:00
Aaron Jorbin
d09f7b6c1d
Revert change from true to false in multisite upload test
...
This change was introduced in [34601]. 0 is a special snowflake. The code treats it as if it should fall back to the default, rather than respecting 0 as 0. Essentially, 0 means 100. WAT? This has been discussed previusly in https://core.trac.wordpress.org/ticket/19538#comment:10 . This test should return True right now, but the behavior should be discussed and in the future 0 may mean 0.
See #34037
Props jorbin, boonebgorges
Built from https://develop.svn.wordpress.org/trunk@34606
git-svn-id: http://core.svn.wordpress.org/trunk@34570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 20:59:24 +00:00
Weston Ruter
7493641f86
Customize: Prevent showing "Front Page" and "Posts Page" states for pages in list table when `show_on_front` is not "page".
...
Changing the `show_on_front` option back to "posts" also resets the `page_on_front` and `page_for_posts` options when updating via the Reading settings page. In the Customizer, however, this is not the case as these other options remain unchanged. This change accounts for this difference in behavior.
Fixes #34004 .
Built from https://develop.svn.wordpress.org/trunk@34605
git-svn-id: http://core.svn.wordpress.org/trunk@34569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 20:54:25 +00:00
Boone Gorges
cc8df8ecb6
Remove failing xmlrpc upload test.
...
This test was added [34577], but shouldn't have been, because the bug it
describes has not been fixed.
See #21292 .
Built from https://develop.svn.wordpress.org/trunk@34604
git-svn-id: http://core.svn.wordpress.org/trunk@34568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 20:32:25 +00:00
Scott Taylor
2c30a11518
After [34577], alter `wp_xmlrpc_server::mw_newMediaObject()` to check upload space in multisite.
...
See #21292 .
Built from https://develop.svn.wordpress.org/trunk@34603
git-svn-id: http://core.svn.wordpress.org/trunk@34567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 19:49:25 +00:00
Scott Taylor
685ff76514
After [34601], some more cleanup.
...
Built from https://develop.svn.wordpress.org/trunk@34602
git-svn-id: http://core.svn.wordpress.org/trunk@34566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 19:29:26 +00:00
Scott Taylor
982edbb061
After [34577] (not because of), uncover and fix some horrifying anomalies in `Tests_Multisite_Site`.
...
Built from https://develop.svn.wordpress.org/trunk@34601
git-svn-id: http://core.svn.wordpress.org/trunk@34565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 19:11:24 +00:00
Aaron Jorbin
6856803922
Use an http URL rather then an https URL for tests
...
Travis doesn't properly support SSL on older versions of PHP. Since we don't test for SSL support in all of the tests, this can cause these tests to fail. This changes a URL introduced in [34568]
See #33968
Built from https://develop.svn.wordpress.org/trunk@34600
git-svn-id: http://core.svn.wordpress.org/trunk@34564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 17:48:33 +00:00
Boone Gorges
9f36a943b5
Improve post field lazyloading for comments.
...
[34583] modified comment queries so that all post fields are no longer loaded
by default. Instead, they are loaded only when requested on individual comment
objects. This changeset improves that flow:
* `WP_Comment` magic methods `__isset()` and `__get()` should only load the post when a post field is being requested.
* The new `update_comment_post_cache` argument for `WP_Comment_Query` allows developers to specify that, when comments are queried, all of the posts matching those comments should be loaded into cache with a single DB hit. This parameter defaults to false, since typical comment queries are linked to a single post.
Fixes #27571 .
Built from https://develop.svn.wordpress.org/trunk@34599
git-svn-id: http://core.svn.wordpress.org/trunk@34563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 16:02:25 +00:00
Dominik Schilling
7b33ad2a99
Plugins: Don't request all fields via `plugins_api( 'plugin_information' )` for plugin installs and update checks.
...
The Plugins API returns a lot of data by default (see [34596]) but when installing or checking for updates we don't need all of it. To save bandwidth, memory and time request only required fields.
Fixes #34030 .
Built from https://develop.svn.wordpress.org/trunk@34598
git-svn-id: http://core.svn.wordpress.org/trunk@34562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 15:50:25 +00:00
John Blackbourn
2079755bd8
Remove the unnecessary horizontal rules in the oEmbed providers table to tidy up the Code Reference.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@34597
git-svn-id: http://core.svn.wordpress.org/trunk@34561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 15:17:24 +00:00
Drew Jaynes
ae91c35cb3
Docs: Add much-needed (and awesome) hash-notation-style documentation for the `$args` parameter in the `plugins_api()` DocBlock.
...
Also fixes up some formatting in the DocBlock summary and description, and adds a link to the function reference, where supplementary information on return object structs and formatting will live.
Props ocean90.
Fixes #34035 .
Built from https://develop.svn.wordpress.org/trunk@34596
git-svn-id: http://core.svn.wordpress.org/trunk@34560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 15:13:25 +00:00
Boone Gorges
95679a3292
Use correct property name when setting child comments.
...
This fixes a typo from [34546], uncovered by unrelated changes in [34583].
See #8071 , #27571 .
Built from https://develop.svn.wordpress.org/trunk@34595
git-svn-id: http://core.svn.wordpress.org/trunk@34559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 14:41:24 +00:00
Sergey Biryukov
cef2439453
Replace a stray semicolon on Edit Page screen with a full stop.
...
Props manolis09, sjmur.
Fixes #33297 .
Built from https://develop.svn.wordpress.org/trunk@34594
git-svn-id: http://core.svn.wordpress.org/trunk@34558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 13:44:26 +00:00
Drew Jaynes
1a91ac752a
Docs: Fix a minor typo from [34592]. Meant to be past-tense, not present.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34593
git-svn-id: http://core.svn.wordpress.org/trunk@34557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 13:14:25 +00:00
Drew Jaynes
231b6f4d5b
Docs: Add missing parameter documentation for `$profileuser` in the hook doc for `show_password_fields`, added in [11302].
...
Also adds a changelog entry for when the parameter was introduced.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34592
git-svn-id: http://core.svn.wordpress.org/trunk@34556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 13:11:49 +00:00
Sergey Biryukov
b28dd45f3d
Network Admin: Properly pass the number of delete plugins to the corresponding message.
...
Fixes #33239 .
Built from https://develop.svn.wordpress.org/trunk@34591
git-svn-id: http://core.svn.wordpress.org/trunk@34555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 13:11:25 +00:00
Drew Jaynes
efad273513
Docs: Relocate the hook doc for the `show_password_fields` filter to its duplicate, since the original was removed in [34582].
...
Adds a changelog entry noting the adjustment in behavior, and simplifies the conditional logic.
Fixes #15115 .
Built from https://develop.svn.wordpress.org/trunk@34590
git-svn-id: http://core.svn.wordpress.org/trunk@34554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 13:05:26 +00:00