Commit Graph

2651 Commits

Author SHA1 Message Date
Weston Ruter 0e19241593 Customizer: Fix moving focus to available nav menu items search.
Fixes regression introduced in [34219].

Cherry-picks [34829].

Props tyxla.
See #33360.
Fixes #34125 for 4.3.

Built from https://develop.svn.wordpress.org/branches/4.3@34830


git-svn-id: http://core.svn.wordpress.org/branches/4.3@34795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 15:30:24 +00:00
Weston Ruter 5e34f4344f Customizer: Smooth animation for closing accordions in the available nav menu items pane.
Merges [34219] from `trunk`.

Props tyxla.
Fixes #33360 for 4.3.

Built from https://develop.svn.wordpress.org/branches/4.3@34220


git-svn-id: http://core.svn.wordpress.org/branches/4.3@34184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 23:43:24 +00:00
Dominik Schilling 12b08da9c2 Settings, password field: Fix placement of the error icon and removal of the error class.
Merge of [34068] to the 4.3 branch.

Props liljimmi, adamsilverstein.
See #33406.
Built from https://develop.svn.wordpress.org/branches/4.3@34119


git-svn-id: http://core.svn.wordpress.org/branches/4.3@34087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 13:07:23 +00:00
Helen Hou-Sandí bf8ffcc14e Comments: Fix inline edit/reply on small screens.
Merges [34094] to the 4.3 branch.

props ocean90, SergeyBiryukov.
see #33596.

Built from https://develop.svn.wordpress.org/branches/4.3@34095


git-svn-id: http://core.svn.wordpress.org/branches/4.3@34063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 12:54:23 +00:00
Weston Ruter 23ef1979f6 Customize: Fix logic for determining the container element when focusing on a panel, section, or control.
Cherry-picks [33939] on the 4.3 branch.
Fixes #33695 for 4.3

Built from https://develop.svn.wordpress.org/branches/4.3@33940


git-svn-id: http://core.svn.wordpress.org/branches/4.3@33909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 06:05:23 +00:00
Dion Hulse e7bb78b884 WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user.
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.

Merges [33688] to the 4.3 branch.
Props jobst.
Fixes #33480 for 4.3

Built from https://develop.svn.wordpress.org/branches/4.3@33883


git-svn-id: http://core.svn.wordpress.org/branches/4.3@33852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 04:38:15 +00:00
Dion Hulse 7f29687a55 Revert [33845]
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 03:33:24 +00:00
Dion Hulse f0706a0895 Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler.
Merges [33727] to the 4.3 branch
Props Otto42, dd32, peterwilsoncc
Fixes #33423 for trunk

Built from https://develop.svn.wordpress.org/branches/4.3@33877


git-svn-id: http://core.svn.wordpress.org/branches/4.3@33845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 03:31:17 +00:00
Dion Hulse 7cfe2d293f Revert [33688] which removed all branches/4.3 files due to a sync script error.
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-24 22:14:43 +00:00
Weston Ruter 4e96fc9fd7 Widgets: Switch back to using `array_key_exists()` instead of `isset()` for widget instance existence check.
Reverts unnecessary change in [32602] since `array_key_exists()` does actually work with `ArrayIterator` objects.

Merges [33696] to the 4.3 branch.
See #32474.
Fixes #33442 for the 4.3 branch.

Built from https://develop.svn.wordpress.org/branches/4.3@33721


git-svn-id: http://core.svn.wordpress.org/branches/4.3@33688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-24 19:31:16 +00:00
Dion Hulse 0b648f198b Revert [33614] which removed all branches/4.3 files due to a sync script error.
git-svn-id: http://core.svn.wordpress.org/branches/4.3@33616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 13:24:10 +00:00
Dion Hulse 7f86f37642 Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621].
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.

Merges [33646] to the 4.3 branch.
Props mechter for noticing!
See #30261.
Fixes #33423 for the 4.3 branch.

Built from https://develop.svn.wordpress.org/branches/4.3@33647


git-svn-id: http://core.svn.wordpress.org/branches/4.3@33614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 11:37:14 +00:00
Helen Hou-Sandí 50e42e8a07 List tables: Yet more primary column fallbacks.
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.

props Chouby, obenland, ocean90.
fixes #33313.

Built from https://develop.svn.wordpress.org/trunk@33623


git-svn-id: http://core.svn.wordpress.org/trunk@33590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 15:38:25 +00:00
Weston Ruter 9ee7f050e9 Customize: Fix keyboard accessibility for toggling screen options and contextual help.
Also fix layout of search results in mobile.

Props valendesigns, afercia, adamsilverstein.
Fixes #33184.

Built from https://develop.svn.wordpress.org/trunk@33617


git-svn-id: http://core.svn.wordpress.org/trunk@33584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-14 21:23:27 +00:00
Konstantin Obenland 35f8b77882 About: Third pass at 4.3 about page:
* Improves some of the feature descriptions.
* Uses .org CDN for images and feature video.
* Fixes an overzealous Jetpack style that adds unwanted padding.
* Uses more specific `WP_List_Table` header.
* Adds 4.3 tagline to freedoms and credit page.
* Adds infrastructure for 4.3 about video. Only the ID needs to be updated.
* Makes all strings translatable.

Props siobhan, adamsilverstein, melchoyce, ocean90, markjaquith, helen, obenland.
Fixes #32929.


Built from https://develop.svn.wordpress.org/trunk@33613


git-svn-id: http://core.svn.wordpress.org/trunk@33580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-13 22:11:35 +00:00
Weston Ruter 7fcc3e50e1 Customize: Fix layout issues in panels and sections when resizing and autofocusing.
Also reverts [33157] which is no longer needed.

Props valendesigns, mattwiebe, westonruter, ocean90.
Fixes #33220.

Built from https://develop.svn.wordpress.org/trunk@33610


git-svn-id: http://core.svn.wordpress.org/trunk@33577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-11 23:56:25 +00:00
Konstantin Obenland 08743e43eb After [32948]: Account for the use of `paginate_links()` with table navigation markup.
Props afercia.
Fixes #32253.


Built from https://develop.svn.wordpress.org/trunk@33608


git-svn-id: http://core.svn.wordpress.org/trunk@33575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-11 20:43:24 +00:00
Konstantin Obenland 48712a0309 Customize: Limit styles for menu's reorder button to the `nav_menu` control.
This prevents it from bleeding into other controls, misaligning their buttons.
Selectors use a class now too, which is preferable over ids.

Fixes #33260.


Built from https://develop.svn.wordpress.org/trunk@33604


git-svn-id: http://core.svn.wordpress.org/trunk@33571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-10 19:36:27 +00:00
Dominik Schilling 45b8634605 Customizer: Remove obsolete `.control-panel-back` and `.customize-overlay-close` buttons.
props afercia, ocean90.
see #31336.
fixes #33229.
Built from https://develop.svn.wordpress.org/trunk@33599


git-svn-id: http://core.svn.wordpress.org/trunk@33566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-09 19:00:24 +00:00
Dominik Schilling bd342572f1 List tables: Adjust width of Quick Edit labels for longer translations.
props Clorith, SergeyBiryukov, ocean90.
fixes #33212.
Built from https://develop.svn.wordpress.org/trunk@33598


git-svn-id: http://core.svn.wordpress.org/trunk@33565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-09 18:55:25 +00:00
Konstantin Obenland f673128a13 Install: Adjust `th` padding to align with `td`s.
Props Ankit K Gupta for initial patch.
Fixes #33280.


Built from https://develop.svn.wordpress.org/trunk@33595


git-svn-id: http://core.svn.wordpress.org/trunk@33562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-07 22:10:26 +00:00
Helen Hou-Sandí ea8f8acc79 Menu customizer: More clearly separate search results from available items.
Available items now fade from view while you're searching, and there is an explicit way to clear search results. No results gives a better message, though still brief this time around.

props valendesigns, designsimply, DH-Shredder, helen.
fixes #32710.

Built from https://develop.svn.wordpress.org/trunk@33511


git-svn-id: http://core.svn.wordpress.org/trunk@33478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 23:40:25 +00:00
Konstantin Obenland 3dfce31be0 Customizer: Improve focus styles for screen option and help toggles.
Props ocean90.
See #33181.


Built from https://develop.svn.wordpress.org/trunk@33510


git-svn-id: http://core.svn.wordpress.org/trunk@33477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 23:25:25 +00:00
Dominik Schilling 6142cb7c94 Customizer: This circular focus thing is hot.
see #33181.
Built from https://develop.svn.wordpress.org/trunk@33503


git-svn-id: http://core.svn.wordpress.org/trunk@33470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 21:51:24 +00:00
Weston Ruter 5720007f67 Customizer: Stack the menu gear icon below the help icon for more text breathing room.
Fixes #33181.

Built from https://develop.svn.wordpress.org/trunk@33500


git-svn-id: http://core.svn.wordpress.org/trunk@33467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 20:23:26 +00:00
Konstantin Obenland 9152362dda About: Second pass at 4.3 about page.
Adds images and videos for major and minor features.
Restores a mangled placeholder in Formatting Shortcuts description.

Assets still need to be moved to the .org CDN once deemed final.

Props ryelle, melchoyce, helen.
See #32929.


Built from https://develop.svn.wordpress.org/trunk@33498


git-svn-id: http://core.svn.wordpress.org/trunk@33465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 19:57:25 +00:00
Andrew Ozz 7ace03443a Press This: properly add Open Sans to the editor, using the `mce_css` filter.
See #26072. Fixes #33189.
Built from https://develop.svn.wordpress.org/trunk@33497


git-svn-id: http://core.svn.wordpress.org/trunk@33464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 19:38:25 +00:00
Helen Hou-Sandí 7b7ae2ee25 Comments list table: Display that cute lil comment bubble.
The comments list table suffers from "wall of text" problems, which the two plain text links compounded.

props obenland. fixes #33149.

Built from https://develop.svn.wordpress.org/trunk@33490


git-svn-id: http://core.svn.wordpress.org/trunk@33457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 18:08:25 +00:00
Dominik Schilling a5ed94ab62 Customizer: Add an `aria-expanded` attribute to Edit menu item toggles.
props afercia.
fixes #33129.
Built from https://develop.svn.wordpress.org/trunk@33483


git-svn-id: http://core.svn.wordpress.org/trunk@33450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 09:50:24 +00:00
Konstantin Obenland 4cac76486f About: First pass at WordPress 4.3 About page.
Still missing images and some string revisions.

See #32929.


Built from https://develop.svn.wordpress.org/trunk@33466


git-svn-id: http://core.svn.wordpress.org/trunk@33433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-28 21:23:25 +00:00
Ella Iseulde Van Dorpe 3e36b24b24 Remove broken/dead colour scheme code
See #32152.

Built from https://develop.svn.wordpress.org/trunk@33453


git-svn-id: http://core.svn.wordpress.org/trunk@33420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-27 23:50:25 +00:00
Konstantin Obenland 2a516d6345 Menus: Readjust screen options toggle icon.
Third revision. This will let the icon appear slightly bigger than the help
icon on Macs and just slightly smaller on Windows machines. It's a compromise
in every way.

Fixes #32733. Again.


Built from https://develop.svn.wordpress.org/trunk@33444


git-svn-id: http://core.svn.wordpress.org/trunk@33411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-27 15:43:25 +00:00
Mark Jaquith b2b53fd997 Fix the padding for the feature filter box on the Add Themes screen.
fixes #33132
props SergeyBiryukov
Built from https://develop.svn.wordpress.org/trunk@33439


git-svn-id: http://core.svn.wordpress.org/trunk@33406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-27 03:34:25 +00:00
Dominik Schilling de86d6b18d Customizer: Add missing text or labels to some nav menu UI controls.
props afercia, celloexpressions, westonruter.
fixes #32715.
Built from https://develop.svn.wordpress.org/trunk@33413


git-svn-id: http://core.svn.wordpress.org/trunk@33381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-24 20:28:25 +00:00
Konstantin Obenland 458332302e Menus: Account for browsers that set a default margin for buttons.
Fixes #32733.


Built from https://develop.svn.wordpress.org/trunk@33410


git-svn-id: http://core.svn.wordpress.org/trunk@33378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-24 17:24:24 +00:00
Konstantin Obenland d512633588 Comments: Normalize button color on hover in alt color schemes.
Props iseulde.
Fixes #33086.


Built from https://develop.svn.wordpress.org/trunk@33409


git-svn-id: http://core.svn.wordpress.org/trunk@33377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-24 17:11:24 +00:00
Konstantin Obenland 7c5989379e Comments: Align author form label with its field labels below.
Props liljimmi.
Fixes #33069.


Built from https://develop.svn.wordpress.org/trunk@33408


git-svn-id: http://core.svn.wordpress.org/trunk@33376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-24 16:51:27 +00:00
Mark Jaquith ae03a8a0a2 Make password field toggling work in IE8, and clean up a bunch of password CSS issues.
fixes #32886
props peterwilsoncc, adamsilverstein
Built from https://develop.svn.wordpress.org/trunk@33362


git-svn-id: http://core.svn.wordpress.org/trunk@33334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 16:56:27 +00:00
Konstantin Obenland f1e604e6e2 Customize: Align screen options toggle with info icon.
Fixes #32733.

Built from https://develop.svn.wordpress.org/trunk@33336


git-svn-id: http://core.svn.wordpress.org/trunk@33308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 21:21:25 +00:00
Konstantin Obenland f535f2889b Site Icon: Improve vertical spacing in preview.
Props eliorivero.
Fixes #33038.


Built from https://develop.svn.wordpress.org/trunk@33332


git-svn-id: http://core.svn.wordpress.org/trunk@33304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 19:01:50 +00:00
Konstantin Obenland 7c75a6d00a Passwords: Use small screen styles for all small screens.
H/t johnjamesjacoby.
Introduced in [33206].

See #32589.

Built from https://develop.svn.wordpress.org/trunk@33331


git-svn-id: http://core.svn.wordpress.org/trunk@33303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 19:01:26 +00:00
Konstantin Obenland 3248497cf3 Site Icon: Add crop preview to the media modal.
* Monkey patches imgAreaSelect library to support touch events.
* Removes Settings version of Site Icon since it would have been the same flow.
* Removes default value for Customizer setting - there is no default favicon.

Fixes #16434.



Built from https://develop.svn.wordpress.org/trunk@33329


git-svn-id: http://core.svn.wordpress.org/trunk@33301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 15:57:25 +00:00
Weston Ruter 910092531b Customizer: Indicate when there are no nav menu items available for a given type.
Props celloexpressions, valendesigns, rittesh.patel.
Fixes #32810.

Built from https://develop.svn.wordpress.org/trunk@33323


git-svn-id: http://core.svn.wordpress.org/trunk@33295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-19 00:06:24 +00:00
Helen Hou-Sandí e9f33a90b3 Customizer: Ensure consistent margins in sections.
Since the customizer dynamically changes, `nth-child` selectors are not always a great idea.

props afercia.
fixes #32902.

Built from https://develop.svn.wordpress.org/trunk@33297


git-svn-id: http://core.svn.wordpress.org/trunk@33269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 19:15:27 +00:00
Ella Iseulde Van Dorpe 54b5b3c808 Editor: DFW: hide udate message
Props miqrogroove.
Fixes #32674.

Built from https://develop.svn.wordpress.org/trunk@33293


git-svn-id: http://core.svn.wordpress.org/trunk@33265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 10:38:25 +00:00
Ella Iseulde Van Dorpe 25a9a1873c TinyMCE: fix visual regressions (2)
See #32801.

Built from https://develop.svn.wordpress.org/trunk@33289


git-svn-id: http://core.svn.wordpress.org/trunk@33261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 23:35:24 +00:00
Ella Iseulde Van Dorpe 952564e84b TinyMCE: fix visual regressions
See #32801.

Built from https://develop.svn.wordpress.org/trunk@33285


git-svn-id: http://core.svn.wordpress.org/trunk@33257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 21:31:24 +00:00
Helen Hou-Sandí 59ad07be48 Toolbar: Ensure icons are colored correctly in alternate schemes.
props ryelle.
fixes #32931. see #29906.

Built from https://develop.svn.wordpress.org/trunk@33284


git-svn-id: http://core.svn.wordpress.org/trunk@33256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 20:14:25 +00:00
Weston Ruter 8c9eb43d47 Customizer: Hide the transport list when it's empty, especially for screen readers.
Also prevent invalid markup for `.customize-section-description`.

Props valendesigns.
Fixes #32843.

Built from https://develop.svn.wordpress.org/trunk@33282


git-svn-id: http://core.svn.wordpress.org/trunk@33254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 19:59:25 +00:00
Weston Ruter 4cb73cf347 Customizer: Fix element focus after menu item is deleted for keyboard accessibility.
Also restores box shadow on focus.

Props valendesigns.
Fixes #32740.

Built from https://develop.svn.wordpress.org/trunk@33279


git-svn-id: http://core.svn.wordpress.org/trunk@33251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 18:44:25 +00:00