Scott Taylor
a6b3bced06
`get_comment()`, `wp_get_post_revision()`, and `get_term()` all used to return by reference. Because of this, `$null` was set to `null` so the return value would be a variable where applicable. This has not been necessary since [21792], so the `$null`s have been removed.
...
Props toszcze.
Fixes #24768 .
Built from https://develop.svn.wordpress.org/trunk@27057
git-svn-id: http://core.svn.wordpress.org/trunk@26930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 06:46:12 +00:00
Scott Taylor
678ef2b1e1
In `wpdb::db_connect()`, allow the loading of a custom database error template - this is already allowed in `dead_db()`.
...
In `dead_db()`, move the call to `wp_load_translations_early()` before the inclusion of the `db-error.php` file to allow translation in both locations before the template is loaded.
Props sbruner, kovshenin.
Fixes #25703 .
Built from https://develop.svn.wordpress.org/trunk@27056
git-svn-id: http://core.svn.wordpress.org/trunk@26929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 05:28:12 +00:00
Scott Taylor
ad211ca06a
Add Unit Tests for `get_comment_pages_count()`. Fix a notice caused when `$wp_query->comments` is not set in that function.
...
Props mdbitz, markjaquith.
Fixes #20633 .
Built from https://develop.svn.wordpress.org/trunk@27055
git-svn-id: http://core.svn.wordpress.org/trunk@26928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 05:17:12 +00:00
Scott Taylor
0347a8944e
Update the versions of several `devDependencies` in `package.json`. `grunt-cssjanus` has been updated to `0.2.2`, we no longer need the fork. Run `npm install` to receive updates for `node_modules` in the project root.
...
Props yoavf, TobiasBg.
Fixes #26073 .
Built from https://develop.svn.wordpress.org/trunk@27053
git-svn-id: http://core.svn.wordpress.org/trunk@26927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 04:43:30 +00:00
Andrew Ozz
6f25a990d0
TinyMCE: fix Ctrl + s shortcut (trigger autosave), see #24067 .
...
Built from https://develop.svn.wordpress.org/trunk@27052
git-svn-id: http://core.svn.wordpress.org/trunk@26926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 23:29:12 +00:00
Scott Taylor
e1759d668a
For starters, [27050] is rad. This just cleans up some extra new lines that were littered about, updates *some* of the inline docs (needs more), moves `wp.media.controller.ImageDetails` closer to its parent class, and de-dupes some code in `media-template.php`.
...
See #24409 .
Built from https://develop.svn.wordpress.org/trunk@27051
git-svn-id: http://core.svn.wordpress.org/trunk@26925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 23:21:13 +00:00
Andrew Ozz
33eedc570b
Introduce Edit Image (single mode) in the media modal and use it to edit images inserted in the editor. Adds new feature: replace an image in the editor. Props gcorne, see #24409 .
...
Built from https://develop.svn.wordpress.org/trunk@27050
git-svn-id: http://core.svn.wordpress.org/trunk@26924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 21:17:12 +00:00
Drew Jaynes
9172107539
Inline documentation for hooks in wp-includes/class-http.php.
...
Props kraftbj for the initial patches. Props kpdesign, DrewAPicture.
Fixes #26049 .
Built from https://develop.svn.wordpress.org/trunk@27049
git-svn-id: http://core.svn.wordpress.org/trunk@26923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 08:25:11 +00:00
Andrew Ozz
544116e76a
TinyMCE: add dashicon for the "wp_page" button, see #24067 .
...
Built from https://develop.svn.wordpress.org/trunk@27044
git-svn-id: http://core.svn.wordpress.org/trunk@26918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 15:06:32 +00:00
Andrew Nacin
c4e119d530
Basic unit tests and additional documentation for wp_strip_all_tags().
...
props joehoyle.
fixes #25507 .
Built from https://develop.svn.wordpress.org/trunk@27042
git-svn-id: http://core.svn.wordpress.org/trunk@26916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 03:16:11 +00:00
Andrew Ozz
864ab9ae56
Autosave:
...
- Move the 'Saving post' and 'Draft saved at...' strings from autosaveL10n to postL10n as they are used only there.
- Use the custom jQuery events 'before-autosave' and 'after-autosave' to show these messages.
- Separate autosave.suspend() for local and server so local autosaves can continue while server autosaves are suspended.
- Remove the recently added autosave.server.disable() and use autosave.server.suspend() instead.
- Bring back .button.disabled, button-primary.disabled and use .disabled to prevent multiple form submissions.
See #25272 .
Built from https://develop.svn.wordpress.org/trunk@27038
git-svn-id: http://core.svn.wordpress.org/trunk@26914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 00:28:13 +00:00
Andrew Ozz
07ae13e432
TinyMCE: do not run preventDefault() on the tab key when Ctrl, Alt or Command key is also pressed. Ctrl + Tab is used to switch between browser tabs. See #24067 , fixes #17261 .
...
Built from https://develop.svn.wordpress.org/trunk@27034
git-svn-id: http://core.svn.wordpress.org/trunk@26910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 00:29:12 +00:00
Scott Taylor
7ef7a7cb47
Add some inline docs to methods in `media-models.js` - particularly around `@param` and `@returns`.
...
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@27032
git-svn-id: http://core.svn.wordpress.org/trunk@26908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-25 08:56:12 +00:00
Scott Taylor
bf09d042eb
Add some JSDoc annotations to `media-models.js` to disambiguate instance properties and static class properties/methods in the base media Models.
...
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@27031
git-svn-id: http://core.svn.wordpress.org/trunk@26907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-25 07:39:11 +00:00
Andrew Ozz
ed3145ec3d
TinyMCE: fix the compat3x plugin appending 'en.' to button titles. Set charset to UTF-8 in html_entity_decode() for translated strings. See #24067 , see #26875 .
...
Built from https://develop.svn.wordpress.org/trunk@27030
git-svn-id: http://core.svn.wordpress.org/trunk@26906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-25 01:21:13 +00:00
Dominik Schilling
2d9bf68585
Update to jQuery UI 1.10.4. fixes #26884 .
...
Built from https://develop.svn.wordpress.org/trunk@27028
git-svn-id: http://core.svn.wordpress.org/trunk@26904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-24 17:44:12 +00:00
Dominik Schilling
91f7d8e1b7
Update to jQuery 1.11.0. fixes #26926 .
...
Built from https://develop.svn.wordpress.org/trunk@27027
git-svn-id: http://core.svn.wordpress.org/trunk@26903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-24 17:40:13 +00:00
Andrew Nacin
1318242221
Docs fix: edit_comment_link() doesn't actually return anything.
...
props Corphi.
fixes #26436 .
Built from https://develop.svn.wordpress.org/trunk@27026
git-svn-id: http://core.svn.wordpress.org/trunk@26902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-24 07:17:36 +00:00
Scott Taylor
d8db2e0cc7
Fix imperceptible whitespace cruff from [27017].
...
Built from https://develop.svn.wordpress.org/trunk@27018
git-svn-id: http://core.svn.wordpress.org/trunk@26895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 22:35:12 +00:00
Scott Taylor
580d8ab0db
Fix a bit of whitespace from [27016].
...
Built from https://develop.svn.wordpress.org/trunk@27017
git-svn-id: http://core.svn.wordpress.org/trunk@26894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 22:34:12 +00:00
Scott Taylor
a9c661c00e
Let `is_attachment()` accept an $attachment parameter, similar to `is_page()` and `is_single()`. Adds Unit Tests for all 3.
...
Props alex-ye for the initial patch.
Fixes #24257 .
Built from https://develop.svn.wordpress.org/trunk@27016
git-svn-id: http://core.svn.wordpress.org/trunk@26893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 22:31:12 +00:00
Andrew Ozz
33c41db77a
Improve keyboard accessibility for the admin menu when in responsive mode, props SergeyBiryukov, fixes #26639 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@27011
git-svn-id: http://core.svn.wordpress.org/trunk@26888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 20:08:11 +00:00
Matt Thomas
7d002a5e84
Responsive improvements to submenus in the adminbar:
...
- Remove .ab-sub-wrapper rules in the 782px media query, as they're duplicates of the rules set on line 161.
- Reposition the arrows for submenus at responsive sizes where the menus are taller.
- Set the submenu position to static at smartphone sizes, so it's not positioned outside of its parent (and thus offscreen).
Fixes #26720 , props undergroundnetwork, iammattthomas.
Built from https://develop.svn.wordpress.org/trunk@27006
git-svn-id: http://core.svn.wordpress.org/trunk@26883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 18:38:24 +00:00
Scott Taylor
f850ddd4f8
Add inline docs to each method of the namespaced objects in `media-editor.js`, explaining what each does. Add inline docs to params as well.
...
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@27005
git-svn-id: http://core.svn.wordpress.org/trunk@26882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 18:38:11 +00:00
Andrew Ozz
167235a602
TinyMCE: fix initializing TinyMCE when the default editor in getUserSetting() is overridden from PHP by using the 'wp_default_editor' filter. See #24067 .
...
Built from https://develop.svn.wordpress.org/trunk@27004
git-svn-id: http://core.svn.wordpress.org/trunk@26881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 18:17:12 +00:00
Scott Taylor
f6b1f2202a
Add the `@namespace` annotation where appropriate in `media-editor.js`. Also indicate the default value of a few params via the [options={}] syntax.
...
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@27000
git-svn-id: http://core.svn.wordpress.org/trunk@26877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 17:17:11 +00:00
Andrew Ozz
335add2573
Autosave: refactor autosave.js, use heartbeat for transport and move all "Add/Edit Post" related functionality to post.js. See #25272 .
...
Built from https://develop.svn.wordpress.org/trunk@26995
git-svn-id: http://core.svn.wordpress.org/trunk@26872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 04:56:16 +00:00
Andrew Ozz
b4d76115cd
TinyMCE: fix error trying to translate non-existent button "title" in the compat3x plugin. See #24067 .
...
Built from https://develop.svn.wordpress.org/trunk@26994
git-svn-id: http://core.svn.wordpress.org/trunk@26871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 02:29:12 +00:00
Matt Thomas
9f4f560258
Eliminate the 1px padding adjustment on active buttons because it creates an un-clickable dead zone 1px high and spanning the entire width of the button. Modify the background color of active buttons for better contrast to make the active state more obvious.
...
See #26700 , props johnbillion.
Built from https://develop.svn.wordpress.org/trunk@26993
git-svn-id: http://core.svn.wordpress.org/trunk@26870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-21 21:27:12 +00:00
Scott Taylor
18b8c717f2
Make some `@param` types more specific in `media-models.js`.
...
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@26991
git-svn-id: http://core.svn.wordpress.org/trunk@26868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-21 17:37:12 +00:00
Scott Taylor
60986d43b4
Remove debug cruft.
...
Props nacin.
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@26990
git-svn-id: http://core.svn.wordpress.org/trunk@26867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-21 16:31:11 +00:00
Scott Taylor
f473d5eef2
Disambiguate `this` and use the `@this` annotation in `media-editor.js`. This will become way more necessary in other places, but a few examples here show how confusing it can be.
...
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@26989
git-svn-id: http://core.svn.wordpress.org/trunk@26866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-21 16:30:11 +00:00
Scott Taylor
86aec42f7c
Correct a type.
...
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@26988
git-svn-id: http://core.svn.wordpress.org/trunk@26865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-21 15:57:16 +00:00
Scott Taylor
ad4cf383cd
Elaborate on JSDoc blocks for `media-editor.js`.
...
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@26987
git-svn-id: http://core.svn.wordpress.org/trunk@26864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-21 15:55:13 +00:00
Scott Taylor
328fc8bae8
Add initial JSDoc blocks to `media-views.js`. The initial blocks are a baseline to work from and invite future iterations. Initial commit is to avoid commits this large in the future.
...
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@26986
git-svn-id: http://core.svn.wordpress.org/trunk@26863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-20 23:42:11 +00:00
Scott Taylor
e2cec2e4d8
Add initial JSDoc blocks to `media-models.js`. The initial blocks are a baseline to work from and invite future iterations. Initial commit is to avoid commits this large in the future.
...
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@26985
git-svn-id: http://core.svn.wordpress.org/trunk@26862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-20 23:40:11 +00:00
Scott Taylor
8457a40032
Add initial JSDoc blocks to `media-editor.js`. The initial blocks are a baseline to work from and invite future iterations. Initial commit is to avoid commits this large in the future.
...
See #26870 .
Built from https://develop.svn.wordpress.org/trunk@26984
git-svn-id: http://core.svn.wordpress.org/trunk@26861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-20 23:35:15 +00:00
Andrew Ozz
910ec9c462
TinyMCE: add a custom jQuery event 'tinymce-editor-init' triggered on initialization of every editor instance. This makes it a lot more convenient to hook into the instance compared to the init.setup callback. See #24067 , see #26872 .
...
Built from https://develop.svn.wordpress.org/trunk@26983
git-svn-id: http://core.svn.wordpress.org/trunk@26860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-19 23:22:14 +00:00
Andrew Ozz
ec5288d405
TinyMCE: fix 3.x callbacks added with init.setup as they run before the compat3x plugin is loaded. Ideally this will be fixed internally in TinyMCE, see #24067 .
...
Built from https://develop.svn.wordpress.org/trunk@26982
git-svn-id: http://core.svn.wordpress.org/trunk@26859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-18 22:20:12 +00:00
Drew Jaynes
7c38bb38b7
Use a docs-specific variable for the `link_category` hook docs in wp-admin/bookmarks-template.php.
...
See #25364 .
Built from https://develop.svn.wordpress.org/trunk@26980
git-svn-id: http://core.svn.wordpress.org/trunk@26857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-18 16:58:13 +00:00
Andrew Nacin
f73508e9bc
Ensure that SSL YouTube URLs receive SSL embeds.
...
props adamsilverstein, Otto42, JayCC.
fixes #23149 .
Built from https://develop.svn.wordpress.org/trunk@26978
git-svn-id: http://core.svn.wordpress.org/trunk@26855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-17 19:46:11 +00:00
Andrew Nacin
b7d3166e90
Use the_title_attribute() in feed_links_extra(), rather than get_the_title().
...
props c3mdigital.
fixes #15046 .
Built from https://develop.svn.wordpress.org/trunk@26975
git-svn-id: http://core.svn.wordpress.org/trunk@26854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-17 09:53:09 +00:00
Andrew Nacin
0ee1cb3046
make_clickable: When cleaning up accidental links within links, account for the tag being split by newlines.
...
props dd32.
fixes #19028 .
Built from https://develop.svn.wordpress.org/trunk@26974
git-svn-id: http://core.svn.wordpress.org/trunk@26853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-17 09:32:10 +00:00
Andrew Nacin
8ec592f244
Add dfn, mark, and samp to kses.
...
props kraftbj.
fixes #24950 .
Built from https://develop.svn.wordpress.org/trunk@26973
git-svn-id: http://core.svn.wordpress.org/trunk@26852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-17 08:38:09 +00:00
Andrew Nacin
d9b0e70d4a
Unit tests for get_url_in_content(). Return false when no content is passed, to match the return value of no links being found.
...
props mdbitz.
#26171 .
Built from https://develop.svn.wordpress.org/trunk@26972
git-svn-id: http://core.svn.wordpress.org/trunk@26851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-17 07:47:10 +00:00
Andrew Nacin
8adc7db517
Add a contrasting border to admin feature pointers.
...
props iammattthomas.
see #26689 .
Built from https://develop.svn.wordpress.org/trunk@26970
git-svn-id: http://core.svn.wordpress.org/trunk@26849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-17 03:49:11 +00:00
Andrew Nacin
7881b4eca8
Realign the oEmbed providers. see #26844 .
...
Built from https://develop.svn.wordpress.org/trunk@26968
git-svn-id: http://core.svn.wordpress.org/trunk@26847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-17 03:29:11 +00:00
Andrew Nacin
7e18ca2dec
Switch Twitter oEmbed to SSL due to a Twitter API change. Ah, the open web.
...
props yurivictor, cojennin.
see #26844 .
Built from https://develop.svn.wordpress.org/trunk@26967
git-svn-id: http://core.svn.wordpress.org/trunk@26846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-17 03:26:10 +00:00
Andrew Ozz
5d92ed5632
TinyMCE: remove the 'spellchecker' plugin. It has been disabled for a while and the back-end currently doesn't work. See #24067 .
...
Built from https://develop.svn.wordpress.org/trunk@26958
git-svn-id: http://core.svn.wordpress.org/trunk@26837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-15 19:07:11 +00:00
Andrew Ozz
71101bc9e2
TinyMCE: fix `send_to_editor()`. It no longer needs to replace shortcode strings with html placeholers before inserting them in the editor. This is handled properly by the editor's `'BeforeSetContent'` event callbacks. See #24067 .
...
Built from https://develop.svn.wordpress.org/trunk@26945
git-svn-id: http://core.svn.wordpress.org/trunk@26824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-14 23:35:11 +00:00