Commit Graph

129 Commits

Author SHA1 Message Date
nacin 5b2c145a4d Improve the performance of WP_Object_Cache's _exists() method.
Results showed a performance improvement on one admin screen of 90ms (~2%).

fixes #21320. see #20004.



git-svn-id: http://core.svn.wordpress.org/trunk@21285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-20 04:21:42 +00:00
duck_ c0892fbaf0 Prevent notices by checking if the $group key isset(). See #20004.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 21:57:03 +00:00
ryan 783e59e185 Fix NULL and FALSE in WP_Object_Cache and make found/not-found unambiguous. Props andy. fixes #20004
git-svn-id: http://svn.automattic.com/wordpress/trunk@20089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 21:10:37 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan 83b131f8e3 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:50:54 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
nacin 89c0895887 new does not require by reference.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-18 20:20:59 +00:00
duck_ e085f4f0d6 Remove the non_existent_objects property from WP_Object_Cache. Fixes #16274.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-15 20:28:06 +00:00
duck_ cda68f14f9 Introduce wp_suspend_cache_addition() to allow reduced memory usage when cache additions aren't useful. Fixes #5389.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-15 20:23:00 +00:00
ryan 5ebcc1d3ea Improve cron locking. Avoid multiple cron processes looping over the same events. fixes #17462
git-svn-id: http://svn.automattic.com/wordpress/trunk@18659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-09 19:59:44 +00:00
ryan 6e68c7bfd9 Update cache.php phpdoc. Props SergeyBiryukov. fixes #18607
git-svn-id: http://svn.automattic.com/wordpress/trunk@18653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-08 17:19:09 +00:00
ryan 4410168419 Standardize variable names. Consistently use and . fixes #18607
git-svn-id: http://svn.automattic.com/wordpress/trunk@18644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-06 21:13:11 +00:00
duck_ e4ed63fc6f Fix typos in documentation (wp-includes/[a-h]). See #18560.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-03 16:02:41 +00:00
ryan c93728e287 Introduce wp_cache_incr() and wp_cache_decr(). fixes #18494
git-svn-id: http://svn.automattic.com/wordpress/trunk@18580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-22 17:39:44 +00:00
ryan e3895262ef Deprecate wp_clone(). Call clone directly. Props hakre. fixes #16813
git-svn-id: http://svn.automattic.com/wordpress/trunk@17613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-06 17:44:29 +00:00
ryan b60c345536 Remove PHP4 constructors. Props hakre. see #16768
git-svn-id: http://svn.automattic.com/wordpress/trunk@17604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-05 17:25:08 +00:00
nacin b8ce0261df More param fixes, props duck_. see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-18 19:12:48 +00:00
westi 0027abcb1a Strip back the stats in the memory based object cache to something less verbose and useless.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-11 10:55:06 +00:00
nacin d3451c6301 Fix html in WP_Object_Cache::stats. props Utkarsh, fixes #15183.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 13:15:24 +00:00
nacin 7bb63ebe44 esc_html in WP_Object_Cache::stats(). fixes #15003.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-09 11:38:12 +00:00
nacin 5a20c05d27 Phpdoc argument/@param cleanups. props duck_, see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-07 11:21:11 +00:00
nacin f60838c8f9 s/echos/echoes/ in phpdoc. props demetris, fixes #13742.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-06 05:16:32 +00:00
ryan f97aa91a68 Preload commonly loaded site options when running multisite without a persistent cache. Introduce wp_cache_reset() and call it instead of wp_cache_init() when re-initing after the blog ID chanages to avoid throwing out the entire cache. Pass cached site options through the site option filter when fetching.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-12 17:06:43 +00:00
ryan c75817ca52 Fix typos. Fix assignment. Remove passing of non-existent arg. Props ScottMac. fixes #12193
git-svn-id: http://svn.automattic.com/wordpress/trunk@13054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-11 16:58:32 +00:00
ryan f6c2de0141 Use clone to break object refs when setting and getting cache. see #8146 #8191
git-svn-id: http://svn.automattic.com/wordpress/trunk@9740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-17 21:01:12 +00:00
westi f7b32217a3 phpDoc corrections for wp-includes. See #7550 props santosj.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-27 06:45:13 +00:00
ryan 35b18e5034 Trailing whitespace cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@8600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-09 05:36:14 +00:00
ryan 62784a594f phpdoc updates from jacobsantos. see #7038
git-svn-id: http://svn.automattic.com/wordpress/trunk@7990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-25 15:45:05 +00:00
ryan 58e47dcb4a wp_cache_add_global_groups() and wp_cache_add_non_persistent_groups(). fixes #6740
git-svn-id: http://svn.automattic.com/wordpress/trunk@7986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-22 17:28:54 +00:00
ryan 8263948a96 Some notice fixes from Nazgul. fixes #3155
git-svn-id: http://svn.automattic.com/wordpress/trunk@6711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-02 18:42:09 +00:00
ryan 1d1c3cc6f5 phpdoc for cache.php from darkdragon. fixes #5511
git-svn-id: http://svn.automattic.com/wordpress/trunk@6543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-03 04:35:47 +00:00
ryan 60220997a6 Fix cache close. see #5570
git-svn-id: http://svn.automattic.com/wordpress/trunk@6540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-02 23:03:25 +00:00
ryan bc53152043 Remove persistent object cache. fixes #5570
git-svn-id: http://svn.automattic.com/wordpress/trunk@6539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-02 22:13:16 +00:00
ryan bd5d107814 Allow single post ID and comma delimited list of post IDs to be passed to update_postmeta_cache(). Fix default cache to allow storage of empty array. see #5194
git-svn-id: http://svn.automattic.com/wordpress/trunk@6247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-10-14 01:08:07 +00:00
ryan 13b23aa20a Space before slash to properly close br tag. Props tmountjr. fixes #4717
git-svn-id: http://svn.automattic.com/wordpress/trunk@5870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-14 03:12:24 +00:00
ryan f2f6101e1c Comment caching. Reduce queries on edit-comments.php page. Add non-persistent cache groups. Hat tip to hovenko. fixes #4387
git-svn-id: http://svn.automattic.com/wordpress/trunk@5666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-08 00:20:22 +00:00
ryan f7e5557f6e Don't load category cache from old tables. see #4189
git-svn-id: http://svn.automattic.com/wordpress/trunk@5544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-05-25 09:45:55 +00:00
rob1n 75efedc528 Delete the cache in tmp even if the copy failed. Props andy. fixes #4141
git-svn-id: http://svn.automattic.com/wordpress/trunk@5255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-04-12 16:31:47 +00:00
markjaquith d0f79bb3f2 trailing tabs and whitespace cleanup.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-02-27 15:24:54 +00:00
markjaquith 36491e0980 make sure nothing going into the object cache is being passed by reference. fixes #3726
git-svn-id: http://svn.automattic.com/wordpress/trunk@4856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-02-01 09:16:15 +00:00
markjaquith 12e9cabfb7 Introduce Notoptions and Alloptions caching, so that all options (and previously attempted Notoptions) are read from the cache in one go. Should reduce cache misses to zero or close to it. fixes #3726
git-svn-id: http://svn.automattic.com/wordpress/trunk@4855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-02-01 08:53:08 +00:00
ryan 4d2ab530cb Fiddle with object destruction and shutdown. Curses upon php 5.2. fixes #3354
git-svn-id: http://svn.automattic.com/wordpress/trunk@4686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-01-06 23:36:51 +00:00
ryan 9f534ebae6 Remove trailing spaces and convert spaces to tabs. Props Nazgul. fixes #986
git-svn-id: http://svn.automattic.com/wordpress/trunk@4495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-11-19 07:56:05 +00:00
ryan 92421de747 Ref more singletons.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-11-19 00:12:57 +00:00
ryan 1181533296 Remove unused var.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-05-31 01:40:25 +00:00
ryan e38d68adac wp_salt() and more hash work.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-05-31 01:40:00 +00:00
ryan a50330dd45 wp_hash() and server secret.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-05-31 00:24:03 +00:00
ryan e7618712cb base64 cached objects and store within multi-line comment block to avoid CRLF injections into the cache. Props Peter Westwood.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-05-26 21:14:36 +00:00
ryan 6eadde74ac Add get_category_by_path(). Remove old fullpath stuff.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-02-28 08:00:39 +00:00
ryan dd202ce1f9 Death to trailing tabs. Props Mark J. fixes #2405
git-svn-id: http://svn.automattic.com/wordpress/trunk@3517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-02-12 07:53:23 +00:00
ryan 6c4e7e48d2 Disable cache by default.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-02-04 03:21:09 +00:00
ryan ee7a432c55 Cache flush improvements from Owen. fixes #2223 #2278
git-svn-id: http://svn.automattic.com/wordpress/trunk@3465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-01-19 22:12:15 +00:00
ryan 4dcbfe9b37 Add ENABLE_CACHE flag to force persistent cache enable.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-01-18 22:21:40 +00:00
ryan 150fb02aa0 Disable peristent cache when safe_mode.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-01-14 21:22:48 +00:00
ryan 937e73d016 Acquire lock when flushing cache.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-01-14 00:05:22 +00:00
ryan 84da5fc90f Save cache after the shutdown hook runs. fixes #2232
git-svn-id: http://svn.automattic.com/wordpress/trunk@3411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-01-06 02:10:43 +00:00
ryan 05188cd4a0 Don't remove top level cache dir when flushing.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-01-05 04:50:58 +00:00
ryan 9675f5fd55 More reliable cache flusher that does not require glob().
git-svn-id: http://svn.automattic.com/wordpress/trunk@3400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-01-05 02:56:42 +00:00
ryan 807f5ded08 Preserve suid and sgid bits when creating new directories. fixes #2190
git-svn-id: http://svn.automattic.com/wordpress/trunk@3388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-01-02 02:50:59 +00:00
ryan faa30b7898 Default expiration is too long. Change it to 15 minutes.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-12-31 22:34:58 +00:00
ryan a626f32296 Cache user ids and user logins separately to avoid collision. Props donncha. fixes #2096
git-svn-id: http://svn.automattic.com/wordpress/trunk@3330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-12-19 19:14:22 +00:00
ryan 5be6242b23 Silence mkdir().
git-svn-id: http://svn.automattic.com/wordpress/trunk@3194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-22 07:45:07 +00:00
ryan eb7c563406 Silence fopen warnings and check return.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-19 22:52:57 +00:00
ryan 6628bfcf35 Suppress fopen warnings and check return.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-19 20:12:26 +00:00
ryan f237c0bf41 Don't loop over empty options. fixes #1900
git-svn-id: http://svn.automattic.com/wordpress/trunk@3138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-17 22:46:18 +00:00
ryan 3a83db90da Don't bother with sems.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-17 09:30:14 +00:00
ryan a6472cdafa Check if writable before checking if dir to avoid permission denied problems.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-17 02:24:52 +00:00
ryan 36722b2528 Silence file ops.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-16 23:40:14 +00:00
ryan 64567c90f4 Don't flush if cache is disabled.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-16 19:01:58 +00:00
ryan a3a84d2957 Flush the cache before installing. fixes #1877
git-svn-id: http://svn.automattic.com/wordpress/trunk@3088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-14 22:32:03 +00:00
ryan 08fea3c335 Implement wp_cache_flush().
git-svn-id: http://svn.automattic.com/wordpress/trunk@3087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-14 22:10:28 +00:00
ryan 60d04abb0c Avoid infinite recursion when expiring cache. fixes #1875
git-svn-id: http://svn.automattic.com/wordpress/trunk@3086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-14 21:29:30 +00:00
ryan 3a088cfaf1 Remove debug cruft.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-09 11:17:33 +00:00
ryan 6f54ba207a Add cache expiration. Cache requests for non-existant options.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-09 11:10:34 +00:00
ryan f49dbd725d Hide serialized object data in comment blocks within .php files. Props ringmaster. fixes #1857
git-svn-id: http://svn.automattic.com/wordpress/trunk@3019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-09 02:38:17 +00:00
ryan 13cff25d99 Oops. Comment out stats dump.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-08 22:28:45 +00:00
ryan b9ee18b899 Obfuscate keys with some salt. Add empty index.php files to the cache dirs to prevent directory listings. Props to ringmaster. fixes #1851
git-svn-id: http://svn.automattic.com/wordpress/trunk@3017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-08 22:15:06 +00:00
ryan 4e2d4a842f Remove trailing blank lines.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-08 00:39:26 +00:00
ryan 85723b8944 Object caching, round one.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-07 21:56:03 +00:00