Sergey Biryukov
a885f914e4
Coding Standards: Add missing semicolon to some `endif` keywords.
...
See #52627 .
Built from https://develop.svn.wordpress.org/trunk@50560
git-svn-id: http://core.svn.wordpress.org/trunk@50173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 13:05:04 +00:00
Sergey Biryukov
d72f4e0e48
Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-upgrader.php`.
...
See #52627 .
Built from https://develop.svn.wordpress.org/trunk@50557
git-svn-id: http://core.svn.wordpress.org/trunk@50170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 12:12:07 +00:00
Sergey Biryukov
d3d78e755b
Coding Standards: Add a space before `/` character in some self-closing HTML tags.
...
While this has no effect on the code, it fixes a minor inconsistency with the rest of core.
Props laxman-prajapati.
Fixes #52870 .
Built from https://develop.svn.wordpress.org/trunk@50556
git-svn-id: http://core.svn.wordpress.org/trunk@50169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-20 18:30:08 +00:00
Sergey Biryukov
643888dfc6
I18N: Update list of continents and cities for the timezone selection.
...
Props wangql, mukesh27.
Fixes #52861 .
Built from https://develop.svn.wordpress.org/trunk@50555
git-svn-id: http://core.svn.wordpress.org/trunk@50168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 15:42:04 +00:00
Sergey Biryukov
b4c09beba8
I18N: Remove duplicate entries from the list of continents and cities.
...
Follow-up to [37554].
See #52861 .
Built from https://develop.svn.wordpress.org/trunk@50554
git-svn-id: http://core.svn.wordpress.org/trunk@50167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 15:21:08 +00:00
whyisjake
471fc1e913
Media: Pass the appropriate reference into `wp_getimagesize`.
...
With changes that were introduced in [49889] the second parameter for getimagesize() function is expecting a a reference.
Previously, most calls did not pass the 2nd param, and as a result, we are getting unexpected results.
This was only a problem with applications that are using a custom stream wrapper, and the image contained EXIF data.
For more see:
* https://github.com/humanmade/S3-Uploads/issues/496
* https://github.com/aws/aws-sdk-php/issues/1923
Fixes #52826 .
Props terriann, SergeyBiryukov, Mista-Flo, hellofromTonya, rinatkhaziev, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@50552
git-svn-id: http://core.svn.wordpress.org/trunk@50165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 00:01:03 +00:00
ryelle
0bfb5f043b
Administration: Make focus states consistent in admin menu when collapsed.
...
When collapsed or on a small screen, these styles would override the color schemes, causing a dark background to appear regardless of the color scheme's settings. This change also uses `focus-within` to show or hide the menu item's arrow, consistent with how the arrow behaves on hover.
Props afercia, Bueltge.
Fixes #32579 .
Built from https://develop.svn.wordpress.org/trunk@50549
git-svn-id: http://core.svn.wordpress.org/trunk@50162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 21:44:09 +00:00
Sergey Biryukov
87db5b833d
External Libraries: Further fix jQuery deprecations in WordPress core.
...
Follow-up to [50001], [50270], [50367], [50383], [50410], [50420], [50429].
Props Clorith.
See #51812 .
Built from https://develop.svn.wordpress.org/trunk@50547
git-svn-id: http://core.svn.wordpress.org/trunk@50160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 19:01:03 +00:00
desrosj
235b19b3b0
Build/Test Tools: Update some `devDependencies`.
...
This updates a handful of dependencies to their latest versions.
- `qunit` from `2.14.0` to `2.14.1`.
- `uglify-js` from `3.13.0` to `3.13.1`.
- `wait-on` from `5.2.1` to `5.3.0`.
See #52624 .
Built from https://develop.svn.wordpress.org/trunk@50545
git-svn-id: http://core.svn.wordpress.org/trunk@50158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 17:48:23 +00:00
Sergey Biryukov
bf29bb4441
Coding Standards: Use strict comparison for JS fragment in some admin files.
...
Follow-up to [48083].
Props nayanchamp7, rnaby.
Fixes #52845 , #41988 .
Built from https://develop.svn.wordpress.org/trunk@50541
git-svn-id: http://core.svn.wordpress.org/trunk@50154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 14:13:08 +00:00
ryelle
5d983ec85b
Help/About: Run image comparison script after all assets have loaded.
...
If the callback is called before the images are loaded, the comparison doesn't work. `wp.domReady` uses `DOMContentLoaded`, which does not guarantee that the images are loaded. This switches to use the `load` event, which waits for all resources to load.
Props vladytimy, joyously, sergeybiryukov.
Fixes #52758 .
Built from https://develop.svn.wordpress.org/trunk@50535
git-svn-id: http://core.svn.wordpress.org/trunk@50148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-15 19:51:09 +00:00
Sergey Biryukov
3f03bb352e
Site Health: Use a singular string in dashboard widget if there is only one critical issue or recommendation.
...
Props Presskopp, hareesh-pillai.
Fixes #52521 .
Built from https://develop.svn.wordpress.org/trunk@50530
git-svn-id: http://core.svn.wordpress.org/trunk@50143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-13 10:59:02 +00:00
gziolo
f27c179afc
Editor: Make block type aware of variations
...
Currently block variations are only defined on the client. In some cases, creating block variations on the server can be very useful, especially when needed data is not exposed in the REST APIs.
Related to https://github.com/WordPress/gutenberg/pull/29095 .
Props: gwwar, timothyblynjacobs.
Fixes : #52688 .
Built from https://develop.svn.wordpress.org/trunk@50527
git-svn-id: http://core.svn.wordpress.org/trunk@50140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-12 13:35:09 +00:00
Sergey Biryukov
96377c956f
Accessibility: Administration: Use a darker color for post dates in the Activity and Quick Draft dashboard widgets.
...
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.
Follow-up to [50025].
Props sabernhardt, Otshelnik-Fm, audrasjb.
Fixes #52760 .
Built from https://develop.svn.wordpress.org/trunk@50525
git-svn-id: http://core.svn.wordpress.org/trunk@50138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-12 12:06:13 +00:00
ryelle
9808fad416
Help/About: Use absolute URLs for inline images on About pages.
...
This ensures the images are loaded correctly from both single site and network About pages.
Props TobiasBg, audrasjb.
Fixes #52743 .
Built from https://develop.svn.wordpress.org/trunk@50523
git-svn-id: http://core.svn.wordpress.org/trunk@50136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-11 21:38:08 +00:00
Sergey Biryukov
88df1ef431
Coding Standards: Consistently format `opendir()` calls in `get_plugins()`.
...
Props sabernhardt, subrataemfluence.
Fixes #44250 .
Built from https://develop.svn.wordpress.org/trunk@50522
git-svn-id: http://core.svn.wordpress.org/trunk@50135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-11 15:19:08 +00:00
Sergey Biryukov
a292585ea4
Help/About: Correct the WebM video URL on About page.
...
Props mihdan, audrasjb.
Fixes #52756 .
Built from https://develop.svn.wordpress.org/trunk@50518
git-svn-id: http://core.svn.wordpress.org/trunk@50131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-10 10:28:11 +00:00
Peter Wilson
0b75f9557e
Docs: Improve spelling in [50516].
...
Props jeremyfelt.
See #52628 , #34564 .
Built from https://develop.svn.wordpress.org/trunk@50517
git-svn-id: http://core.svn.wordpress.org/trunk@50130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 23:22:06 +00:00
Peter Wilson
fb1857def8
Docs: Improve compatibility comment in `WP_List_Table`.
...
Improve comment explaining backward compatibility check for the primary column in `WP_List_Table::get_column_info()`.
Unprops helen, markjaquith.
See #52628 , #34564 .
Built from https://develop.svn.wordpress.org/trunk@50516
git-svn-id: http://core.svn.wordpress.org/trunk@50129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 22:35:06 +00:00
Sergey Biryukov
ebee7d0ab9
Classic Editor: Make sure word count is hidden if JavaScript is disabled.
...
Removing `display: block` from the element allows the `.hide-if-no-js` class to have the intended effect.
Follow-up to [34275].
Props sabernhardt, mukesh27.
Fixes #52662 .
Built from https://develop.svn.wordpress.org/trunk@50512
git-svn-id: http://core.svn.wordpress.org/trunk@50125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 10:13:08 +00:00
desrosj
a8b7cd17e0
Update `$_old_files` for 5.7.
...
Follow up to [50066].
See #52334 .
Built from https://develop.svn.wordpress.org/trunk@50510
git-svn-id: http://core.svn.wordpress.org/trunk@50123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-08 18:30:07 +00:00
Sergey Biryukov
fa5a9d5e92
Upgrade/Install: Display version number on the "Update now" button on WordPress Updates screen.
...
Additionally, adjust the "Update to latest nightly" button to include the major version number of the nightly build.
This makes the button labels more accurate and provides more clear understanding of what the update will be.
Follow-up to [49984].
Props afragen, pbiron, SergeyBiryukov.
Fixes #52513 .
Built from https://develop.svn.wordpress.org/trunk@50506
git-svn-id: http://core.svn.wordpress.org/trunk@50119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-08 11:31:09 +00:00
John Blackbourn
52679edbff
Docs: Add examples of possible names for various hooks whose name contains a dynamic portion.
...
This provides greater discoverability of such hooks in search results on the Code Reference site as well as increased clarity when reading the source.
See #50734 , #52628
Built from https://develop.svn.wordpress.org/trunk@50505
git-svn-id: http://core.svn.wordpress.org/trunk@50118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-07 12:32:09 +00:00
ryelle
22358d62ce
Help/About: Clarify two strings.
...
The intro text has been updated for accuracy and to make it easier for translation. The button text has been updated for accuracy.
Props jdy68, audrasjb, marybaum, davidbaumwald.
See #52347 .
Built from https://develop.svn.wordpress.org/trunk@50495
git-svn-id: http://core.svn.wordpress.org/trunk@50108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-04 19:10:06 +00:00
desrosj
bbdc16d705
Build/Test Tools: Update some dependencies.
...
This updates the following `devDependencies`:
- `grunt-contrib-cssmin` from `3.0.0` to `4.0.0`.
- `uglify-js` from `3.12.8` to `3.13.0`.
See #52624 .
Built from https://develop.svn.wordpress.org/trunk@50487
git-svn-id: http://core.svn.wordpress.org/trunk@50100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 21:16:22 +00:00
Sergey Biryukov
3cdbafe164
Help/About: Clarify a string about lazy-loading iframes.
...
Props davidbaumwald, audrasjb, hellofromTonya.
See #52347 .
Built from https://develop.svn.wordpress.org/trunk@50483
git-svn-id: http://core.svn.wordpress.org/trunk@50094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 21:38:03 +00:00
ryelle
f4f117144e
Help/About: Iterate on the 5.7 About Page.
...
Adds a more obviously interactive comparison for viewing the color scheme differences. Improvements on RTL and IE11. Update strings to be more clear and consistent. Switch to the CDN for loading images.
Props sarahricker, desrosj, melchoyce, SergeyBiryukov, tikifez, clorith, marybaum, audrasjb, francina, hellofromTonya.
Fixes #52693 . See #52347 .
Built from https://develop.svn.wordpress.org/trunk@50478
git-svn-id: http://core.svn.wordpress.org/trunk@50089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 19:50:04 +00:00
Mike Schroder
34b0dc8023
Upgrade/Install: Invalidate OPcache for `version.php` during update.
...
Invalidate OPcache for `wp-content/version.php` on update individually, since it’s copied separately.
Props stodorovic, krstarica, cenay, desrosj, pbiron, sergeybiryukov, mikeschroder.
Fixes #51686 , #51281 .
See #36455 .
Built from https://develop.svn.wordpress.org/trunk@50475
git-svn-id: http://core.svn.wordpress.org/trunk@50086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 17:13:03 +00:00
Sergey Biryukov
69a0a68817
Docs: Clarify a comment about `wp_opcache_invalidate()` in `_copy_dir()`.
...
Follow-up to [48160].
See #52628 .
Built from https://develop.svn.wordpress.org/trunk@50460
git-svn-id: http://core.svn.wordpress.org/trunk@50071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-01 10:38:05 +00:00
Sergey Biryukov
74e0d8ba54
Docs: Correct function name in `add_settings_field()` DocBlock.
...
See #52628 .
Built from https://develop.svn.wordpress.org/trunk@50434
git-svn-id: http://core.svn.wordpress.org/trunk@50045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-25 12:02:03 +00:00
desrosj
b231afc0b7
Help/About: Remove extra space in the 5.7 About page copy.
...
Props tobifjellner, audrasjb.
Fixes #52632 .
Built from https://develop.svn.wordpress.org/trunk@50430
git-svn-id: http://core.svn.wordpress.org/trunk@50041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-24 15:51:06 +00:00
Sergey Biryukov
ed5c0971f5
Administration: Revert the change to `click` event handler for fly-out submenus.
...
The `click()` method there is not the jQuery method, but is an HTML DOM method instead.
This makes the fly-out submenu header clickable again when the menu is folded.
Follow-up to [50420].
Props peterwilsoncc.
Fixes #52638 . See #51812 .
Built from https://develop.svn.wordpress.org/trunk@50429
git-svn-id: http://core.svn.wordpress.org/trunk@50040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-24 12:22:07 +00:00
Sergey Biryukov
b65d83b872
External Libraries: Further fix jQuery deprecations in WordPress core.
...
This includes many minor adjustments to a wide array of core files to replace shorthands with full declarations.
Follow-up to [50001], [50270], [50367].
Props Clorith, hellofromTonya, peterwilsoncc, adamsilverstein, aristath.
See #51812 .
Built from https://develop.svn.wordpress.org/trunk@50420
git-svn-id: http://core.svn.wordpress.org/trunk@50031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-23 19:45:04 +00:00
ryelle
9a32a41e52
Help/About: WordPress 5.7 About Page.
...
This is the start of the WordPress 5.7 about page.
Props audrasjb, metalandcoffee, melchoyce, hedgefield, francina, webcommsat, lukecarbis, meher, sarahricker, marybaum.
See #52347 .
Built from https://develop.svn.wordpress.org/trunk@50418
git-svn-id: http://core.svn.wordpress.org/trunk@50029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-23 18:41:05 +00:00
desrosj
8fc757b1f0
Build/Test Tools: Update NPM dependencies.
...
This updates two `devDependencies`:
- `uglify-js` from `3.12.7` to `3.12.8`.
- `sassn` from `1.32.6` to `1.32.8`.
See #51801 .
Built from https://develop.svn.wordpress.org/trunk@50416
git-svn-id: http://core.svn.wordpress.org/trunk@50027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-23 16:45:19 +00:00
Sergey Biryukov
af9675bdcb
Users: Give the Password Reset table row its own wrapper class.
...
Previously, the class of the Sessions table row was duplicated.
Follow-up to [50129], [50411].
See #52597 .
Built from https://develop.svn.wordpress.org/trunk@50412
git-svn-id: http://core.svn.wordpress.org/trunk@50023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-23 14:35:03 +00:00
Sergey Biryukov
e0b66dd56c
Users: Relocate the Password Reset feature to the Account Management section.
...
Follow-up to [50129].
Props mukesh27, audrasjb, hellofromTonya.
Fixes #52597 .
Built from https://develop.svn.wordpress.org/trunk@50411
git-svn-id: http://core.svn.wordpress.org/trunk@50022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-23 14:21:05 +00:00
Sergey Biryukov
ddca2ed164
Docs: Document the usage of `$pagenow` global in a few functions.
...
See #51800 .
Built from https://develop.svn.wordpress.org/trunk@50407
git-svn-id: http://core.svn.wordpress.org/trunk@50018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-22 19:18:12 +00:00
Peter Wilson
0b9c7b7cdf
Site Health: Update loopback test to `POST` to wp-cron.
...
Replace loopback health check URL with a `POST` request to `wp-cron.php` in the WordPress install directory. This more closely represents how WordPress uses loopback requests.
A `POST` request is used to cause `wp-cron.php` to exit prior to running any cron jobs. This allows the test to indicate success quicker and accounts for sites that set the `DISABLE_WP_CRON` constant to avoid running cron jobs on loopback requests.
Props clorith, peterwilsoncc, TimothyBlynJacobs.
Fixes #52547 .
Built from https://develop.svn.wordpress.org/trunk@50399
git-svn-id: http://core.svn.wordpress.org/trunk@50010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-22 00:51:09 +00:00
Sergey Biryukov
17fa3f6b6d
I18N: Remove extra spaces from translatable strings in Privacy help tabs.
...
Follow-up to [50147].
Props tobifjellner.
Fixes #52583 .
Built from https://develop.svn.wordpress.org/trunk@50398
git-svn-id: http://core.svn.wordpress.org/trunk@50009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-21 16:04:11 +00:00
Sergey Biryukov
50f8dafe17
Users: Correctly display an error message after clicking the "Send Reset Link" button.
...
The `addInlineNotice()` function expects a single string as a success or error message, not an array of strings.
Follow-up to [50129].
Props audrasjb.
Fixes #52573 .
Built from https://develop.svn.wordpress.org/trunk@50390
git-svn-id: http://core.svn.wordpress.org/trunk@50001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-19 17:24:05 +00:00
ryelle
6e895528e7
Customizer: Bring admin color schemes back into the customizer.
...
In #50547 , the admin color schemes were added to the customizer UI, but at some point specificity changed and the colors were overridden by the defaults. This brings the color schemes back into the customizer, using the button color as a highlight, with the link color for text to keep things readable.
Follow up to [48371].
Props audrasjb, peterwilsoncc.
Fixes #52230 .
Built from https://develop.svn.wordpress.org/trunk@50386
git-svn-id: http://core.svn.wordpress.org/trunk@49997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-18 16:51:05 +00:00
ryelle
369c43ff2e
Administration: Apply background color to updated message in plugin list table.
...
Follow-up to [50025].
Props afragen.
Fixes #52452 .
Built from https://develop.svn.wordpress.org/trunk@50385
git-svn-id: http://core.svn.wordpress.org/trunk@49996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-18 15:16:03 +00:00
Peter Wilson
c6af819b3a
Site Health: Use home page for loopback test.
...
Use `home_url()` for asynchronous loopback test to ensure correct results on sites with WordPress installed elsewhere, for example WordPress in a sub-directory.
Props Levdbas.
Fixes #52547 .
Built from https://develop.svn.wordpress.org/trunk@50381
git-svn-id: http://core.svn.wordpress.org/trunk@49992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 23:10:04 +00:00
Sergey Biryukov
dcbe3cb7b8
Privacy: Suggest `wp_add_privacy_policy_content()` as an alternative for the deprecated `wp_get_default_privacy_policy_content` hook.
...
Follow-up to [50161].
See #49264 .
Built from https://develop.svn.wordpress.org/trunk@50374
git-svn-id: http://core.svn.wordpress.org/trunk@49985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 12:45:04 +00:00
Sergey Biryukov
f331ff5a7a
Docs: Correct the alternative hook name for the deprecated `whitelist_options` hook.
...
Follow-up to [48121].
See #51800 .
Built from https://develop.svn.wordpress.org/trunk@50373
git-svn-id: http://core.svn.wordpress.org/trunk@49984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 12:42:03 +00:00
Sergey Biryukov
8080762e93
External Libraries: Further fix jQuery deprecations in WordPress core.
...
This addresses `JQMIGRATE` warnings in some admin files and the Thickbox library.
Follow-up to [50001], [50270].
Props bordoni, poena.
See #51812 .
Built from https://develop.svn.wordpress.org/trunk@50367
git-svn-id: http://core.svn.wordpress.org/trunk@49978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 20:25:03 +00:00
Sergey Biryukov
b50e49f5c1
Accessibility: Taxonomy: Correct keyboard navigation for the Tags meta box in classic editor.
...
Props sabernhardt, almendron, jose64, alexstine, joedolson, ryokuhi.
Fixes #52408 .
Built from https://develop.svn.wordpress.org/trunk@50363
git-svn-id: http://core.svn.wordpress.org/trunk@49974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 20:04:07 +00:00
Sergey Biryukov
e99d544215
Administration: Apply the `months_dropdown_results` filter separately from `pre_months_dropdown_query`.
...
Follow-up to [50163].
Props hellofromTonya.
Fixes #51660 .
Built from https://develop.svn.wordpress.org/trunk@50362
git-svn-id: http://core.svn.wordpress.org/trunk@49973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 19:58:05 +00:00
John Blackbourn
6cb1eaa583
Posts, Post Types: Update the styling of the legacy Links editing screen.
...
This brings its styling inline with other meta boxes in the admin area.
Props antonlukin, kburgoine, grzim, sabernhardt, pbiron, audrasjb
Fixes #48782
Built from https://develop.svn.wordpress.org/trunk@50357
git-svn-id: http://core.svn.wordpress.org/trunk@49968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 18:50:03 +00:00