Commit Graph

149 Commits

Author SHA1 Message Date
Dominik Schilling 46f98473d1 Widgets: Add return param for widgets admin page to the "Manage in Customizer" link.
props tywayne.
fixes #30888.
Built from https://develop.svn.wordpress.org/trunk@31420


git-svn-id: http://core.svn.wordpress.org/trunk@31401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 20:57:26 +00:00
Scott Taylor 7f8b548df1 In HTML5, the `action` attribute is no longer required. Remove this attribute when empty.
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.

Built from https://develop.svn.wordpress.org/trunk@31200


git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 04:16:24 +00:00
Dominik Schilling cffba3c1ba Customizer: Use deep-links for Backgrounds, Headers, and Widgets.
Replace links in admin menu and toolbar to Custom Background/Header screen with deep-links to the Customizer section.
On the Widgets screen display a link to the Customizer widgets panel.

props topher1kenobe, rzen, celloexpressions, westonruter
fixes #25569, #25571, #28032.
Built from https://develop.svn.wordpress.org/trunk@30459


git-svn-id: http://core.svn.wordpress.org/trunk@30450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 15:29:23 +00:00
John Blackbourn d88ed475b0 Switch to a `403` response code in places where it is more appropriate than a `500` due to permissions errors.
Fixes #10551
Props nacin

Built from https://develop.svn.wordpress.org/trunk@30356


git-svn-id: http://core.svn.wordpress.org/trunk@30355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 06:16:22 +00:00
Drew Jaynes 097dc8ee15 Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.

Built from https://develop.svn.wordpress.org/trunk@29206


git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
Drew Jaynes 5613b40981 The `sidebar_admin_setup` hook should only be documented once in wp-admin/widgets.php. All others are duplicates.
See #25374, #25501, #27531.

Built from https://develop.svn.wordpress.org/trunk@27823


git-svn-id: http://core.svn.wordpress.org/trunk@27657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 19:47:15 +00:00
Andrew Nacin dce0b9adea Use SSL when linking to WordPress.org. see #27115.
Built from https://develop.svn.wordpress.org/trunk@27469


git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 04:14:15 +00:00
Matt Thomas baefdf5bf8 Revert r26593 so Available and Inactive widgets are once again collapsible. Make the arrows only appear on hover when uncollapsed. Fixes #26327, props nacin.
Built from https://develop.svn.wordpress.org/trunk@26608


git-svn-id: http://core.svn.wordpress.org/trunk@26498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 16:31:10 +00:00
Matt Thomas 26a22db98e Set Available and Inactive Widget areas to not collapse, since they don't look like collapsing elements. Fixes #26327, props MikeHansenMe.
Built from https://develop.svn.wordpress.org/trunk@26593


git-svn-id: http://core.svn.wordpress.org/trunk@26483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 21:32:10 +00:00
Andrew Ozz 8d6059b383 Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119
Built from https://develop.svn.wordpress.org/trunk@26518


git-svn-id: http://core.svn.wordpress.org/trunk@26411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 03:53:11 +00:00
Andrew Ozz db074f8e65 Widgets: improve the help text on the Widgets screen, props siobhan, props Hanni, fixes #26244.
Built from https://develop.svn.wordpress.org/trunk@26505


git-svn-id: http://core.svn.wordpress.org/trunk@26399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-01 18:29:09 +00:00
Andrew Ozz f46e743343 Widgets: drop onto closed sidebars.
- Make dropping a widget easier by preventing the source sidebar from resizing while the widget is being dragged.
- Move widgets dropped on closed sidebars to the top. UI Sortable places them randomly near the bottom.
- Fix possible regression in wp_list_widget_controls(), add an optional argument to output the sidebar name inside the sortable container.
- Updated styles for sidebar description and widget-hover class.
Part props shaunandrews, fixes #25952.
Built from https://develop.svn.wordpress.org/trunk@26426


git-svn-id: http://core.svn.wordpress.org/trunk@26326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-27 01:30:10 +00:00
Andrew Ozz c944323a4f Widgets:
- Don't deactivate "draggable" on the widget when the chooser is open. Makes it possible to still drag the "widget-in-question".
- Change the chooser's HTML id to a class to avoid collisions when cloning.
- Refresh the "sortable" positions when an open widget is dragged. Fixes problems moving the widget up or down in the same sidebar.
See #25821
Built from https://develop.svn.wordpress.org/trunk@26366


git-svn-id: http://core.svn.wordpress.org/trunk@26267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-24 22:07:10 +00:00
Matt Thomas f26fea70c5 Making improvements to new styles added in the MP6 merge, and addressing visual feedback from core team.
Improved and more consistent styling on the widgets & menus pages:

* Use the same visual treatment for both widgets and menus.
* Re-use existing styles from input:focus for draggable elements.
* Use the standard H3 size for widget area titles.
* Re-style the Widgets page drop zone to match drop zone from dashboard.
* Replace the gear icon on Widgets with the standard open/close arrows.
* Remove "Choose a sidebar" header from widget area chooser.

Make open/close arrows more consistent:

* Use the same arrow direction everywhere: pointing down when its container is closed, pointing up when open (following the Dashboard example).
* Set a consistent color for open/close arrows.
* Add a hover color for open/close arrows.
* Make open/close arrows permanently visible; :hover states don't exist on touch.

Make typography and color more consistent:

* Switch all declarations of #dedede to #ddd for simplicity's sake.
* Make H3s the same weight and color as H2s.
* Make select elements the same color as text inputs.
* Make paragraph text #444 so it doesn't look washed out on grey backgrounds.

General improvements:

* Eliminate the border between rows in settings tables.
* Make text and buttons line up in the Customizer.

See #25858.


Built from https://develop.svn.wordpress.org/trunk@26293


git-svn-id: http://core.svn.wordpress.org/trunk@26198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 22:48:09 +00:00
Andrew Ozz c39f333b06 Widgets: fix html for sidebars columns when the theme has only one sidebar. See #25952.
Built from https://develop.svn.wordpress.org/trunk@26286


git-svn-id: http://core.svn.wordpress.org/trunk@26191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 05:09:10 +00:00
Andrew Ozz 30b1c76a01 Widgets: split the sidebars in two containers so there are no empty spaces when they are shown in two columns and some are open, other closed. See #25952.
Built from https://develop.svn.wordpress.org/trunk@26285


git-svn-id: http://core.svn.wordpress.org/trunk@26190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 04:45:10 +00:00
Andrew Ozz c19660468b Widgets: move the chooser inside the selected widget so it inherits the width, add some keyboard shortcuts: tab to select, enter to append and escape to cancel. Props shaunandrews, see #25821
Built from https://develop.svn.wordpress.org/trunk@26271


git-svn-id: http://core.svn.wordpress.org/trunk@26176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-19 18:03:09 +00:00
Andrew Ozz 753e745796 Merge the Widgets Area Chooser feature plugin. First run, see #25821
Built from https://develop.svn.wordpress.org/trunk@26054


git-svn-id: http://core.svn.wordpress.org/trunk@25979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-08 23:05:10 +00:00
Andrew Nacin 70fd806759 Revert r25824:25875 from the core.svn.wordpress.org repository.
These commits were accidentally re-synced commits from develop.svn.wordpress.org due to a race condition. Thankfully, the history of this repository matters fairly little. It also happened only for trunk.


git-svn-id: http://core.svn.wordpress.org/trunk@25876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-25 02:29:52 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Ryan Boren b87d4b77e5 Pinking shears
Built from https://develop.svn.wordpress.org/trunk@25880


git-svn-id: http://core.svn.wordpress.org/trunk@25792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 14:38:10 +00:00
Drew Jaynes c100d28a25 Inline documentation for hooks in wp-admin/widgets.php.
Props r3df, kpdesign.
Fixes #25501.

Built from https://develop.svn.wordpress.org/trunk@25734


git-svn-id: http://core.svn.wordpress.org/trunk@25647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-08 20:27:08 +00:00
Andrew Nacin fd57b239d2 Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
Sergey Biryukov a9cb64b537 Avoid 'Only variables should be passed by reference' notice on Widgets screen. props jdgrimes. fixes #25225.
Built from https://develop.svn.wordpress.org/trunk@25226


git-svn-id: http://core.svn.wordpress.org/trunk@25196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-04 05:11:09 +00:00
Andrew Nacin 9bba27f4e5 Fix various typos and omissions across a number of help tabs. props DrewAPicture, Ipstenu. see #22451.
git-svn-id: http://core.svn.wordpress.org/trunk@22812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 08:45:15 +00:00
Andrew Nacin 1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Andrew Nacin 9f6fe3c4ff Don't show Appearance > Widgets if the theme has no sidebars defined. props SergeyBiryukov for the initial patch. fixes #21761.
git-svn-id: http://core.svn.wordpress.org/trunk@21825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-12 02:16:46 +00:00
Andrew Ozz e00b17aac6 Replace the dark spinner with the light on the widgets screen and retire wpspin_dark.gif, props helenyhou and lessbloat, fixes #20957
git-svn-id: http://core.svn.wordpress.org/trunk@21577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-22 02:02:37 +00:00
azaozz 618fdf1535 Widgets: ensure the "drop zone" matches the height of the Inactive Widgets container, fixes #21250
git-svn-id: http://core.svn.wordpress.org/trunk@21270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-13 01:47:16 +00:00
azaozz 6aaf0dad43 Add the jQuery UI Touch Punch plugin to handle dragging on mobile devices, props georgestephanis, see #20014
git-svn-id: http://svn.automattic.com/wordpress/trunk@20433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-11 02:20:51 +00:00
nacin ee72413797 Don't use esc_attr_e() function for a non-translatable context. props zeo. fixes #19479.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-08 17:56:03 +00:00
ryan 837d46fe67 Don't use a gettext function for a non-translatable context. Props nacin. fixes #19479
git-svn-id: http://svn.automattic.com/wordpress/trunk@19570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-08 16:51:52 +00:00
ryan 6bba5a265b Pinking shears
git-svn-id: http://svn.automattic.com/wordpress/trunk@19528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 04:51:35 +00:00
nacin 65a10cedbb Help tweaks for themes, plugins screens. props jane, see #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 01:24:39 +00:00
azaozz a55d901b12 Check the sidebar class for orphaned sidebars, match sidebars by id while retrieving orphans and the theme has not changed, props SergeyBiryukov, fixes #19350
git-svn-id: http://svn.automattic.com/wordpress/trunk@19455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-26 06:16:43 +00:00
dd32 6da2f73c78 Add a missing translation. Props yuraz, vanillalounge. Fixes #19359
git-svn-id: http://svn.automattic.com/wordpress/trunk@19454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-26 04:08:38 +00:00
azaozz 952187eb76 Update the text for inactive sidebars, props chrisbliss18 SergeyBiryukov, fixes #19350
git-svn-id: http://svn.automattic.com/wordpress/trunk@19453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-25 20:00:21 +00:00
azaozz f1ef47ded2 Make sure all orphaned sidebars are shown on the left (under Available Widgets), see #19350
git-svn-id: http://svn.automattic.com/wordpress/trunk@19452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-25 19:46:41 +00:00
azaozz e8638a517a Move the check whether the theme supports widgets before we register any extra sidebars, fixes #19352
git-svn-id: http://svn.automattic.com/wordpress/trunk@19449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-24 17:44:53 +00:00
ryan efbbab1b3c Help tabs. Props chexee. see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-24 00:21:39 +00:00
azaozz 2d6d3c748a Prevent errors in assigning widgets to sidebars for themes with dynamic sidebars, props batmoo, fixes #19274
git-svn-id: http://svn.automattic.com/wordpress/trunk@19334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-18 07:00:26 +00:00
nacin bfb98c193e s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020, #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:14:10 +00:00
ryan 3ad1f67958 Use add_help_sidebar(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 03:12:37 +00:00
nacin 795ca8d394 Revert [18861], [18862], [18864], [18874], [18879], and [18880]. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 04:57:12 +00:00
dd32 5ad995f089 Fix admin_body_class filter for Menu's and Widgets pages, Include the filter in Iframe's. Props SergeyBiryukov & johnbillion. Fixes #18853
git-svn-id: http://svn.automattic.com/wordpress/trunk@18882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 07:09:51 +00:00
azaozz bbafdfa0e5 Use add_option() method, introduce add_option_context() method for adding specific text above the screen options, see #18690
git-svn-id: http://svn.automattic.com/wordpress/trunk@18867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-03 04:00:57 +00:00
azaozz 3575537e5f Add screen_options with contextual content, see #18690
git-svn-id: http://svn.automattic.com/wordpress/trunk@18864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-02 06:59:36 +00:00
azaozz d83b14c165 Moves orphaned sidebars to main content area above Inactive Widgets, props aaroncampbell, see #17979
git-svn-id: http://svn.automattic.com/wordpress/trunk@18631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-03 03:01:11 +00:00
azaozz 4852c5887f Avoid losing widgets when switching themes - take one, props aaroncampbell, see #17979
git-svn-id: http://svn.automattic.com/wordpress/trunk@18630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-02 22:13:55 +00:00
azaozz 1cdec6ff6e Merge most admin css files, first run, see #18314
git-svn-id: http://svn.automattic.com/wordpress/trunk@18577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-21 03:46:43 +00:00