5c4290f999
I18N: Remove `<kbd>` tag from a translatable string on Edit Post screen.
...
Props ramiy, tobifjellner.
Fixes #48874 .
Built from https://develop.svn.wordpress.org/trunk@48194
git-svn-id: http://core.svn.wordpress.org/trunk@47963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-27 23:02:03 +00:00
abe112c750
Administration: Correct the URL for "Learn more about getting started" link in "Welcome to WordPress" panel.
...
Props hareesh-pillai, johnbillion.
Fixes #50484 .
Built from https://develop.svn.wordpress.org/trunk@48191
git-svn-id: http://core.svn.wordpress.org/trunk@47960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-27 12:45:04 +00:00
3079ab76dc
Administration: Add missing comma to the message in "Post via email" section.
...
Props kinjaldalwadi, sabernhardt.
Fixes #49238 .
Built from https://develop.svn.wordpress.org/trunk@48186
git-svn-id: http://core.svn.wordpress.org/trunk@47955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-26 19:38:06 +00:00
40c389c95e
Docs: Standardize on "Returning a value from the filter" vs. "Passing a value to the filter".
...
The filter is the callback function added with `add_filter()`, therefore the hook passes a value to the filter, and the filter returns a value to change its behaviour.
The documentation is referring to the latter.
Props johnbillion.
See #49572 , #16557 .
Built from https://develop.svn.wordpress.org/trunk@48185
git-svn-id: http://core.svn.wordpress.org/trunk@47954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-26 18:49:09 +00:00
eb9a6c9690
Docs: Miscellaneous docblock improvements.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48184
git-svn-id: http://core.svn.wordpress.org/trunk@47953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-26 18:40:04 +00:00
c0db9a2f3d
Editor: update JavaScript packages
...
Also update default block categories
Props youknowriad, gziolo, aduth.
Fixes #50420 , #50278 .
Built from https://develop.svn.wordpress.org/trunk@48177
git-svn-id: http://core.svn.wordpress.org/trunk@47946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-26 13:33:47 +00:00
16b35340f4
Site Health: Improve the error message displayed when activating a plugin that requires a higher version of PHP or WordPress.
...
This adds some extra details to the message:
* The current PHP or WordPress version.
* The plugin's minimum required PHP or WordPress version.
* A link to the support documentation on how to update PHP.
Props stuffradio, johnbillion, garrett-eclipse, sabernhardt, williampatton, SergeyBiryukov.
Fixes #48245 .
Built from https://develop.svn.wordpress.org/trunk@48172
git-svn-id: http://core.svn.wordpress.org/trunk@47941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-26 00:27:09 +00:00
56342b8e8f
Docs: Replace "AJAX" with "Ajax" in DocBlocks and comments, per the spelling glossary.
...
Props mukesh27, sabernhardt, SergeyBiryukov.
Fixes #50064 .
Built from https://develop.svn.wordpress.org/trunk@48168
git-svn-id: http://core.svn.wordpress.org/trunk@47937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 12:43:07 +00:00
d38a32bfac
Coding Standards: Reformat some long `apply_filters_deprecated()` and `do_action_deprecated()` calls for better readability.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@48167
git-svn-id: http://core.svn.wordpress.org/trunk@47936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 12:06:07 +00:00
bfafc0aecb
Administration: Correct and simplify the logic for `asc` and `desc` arguments in `WP_List_Table::get_sortable_columns()`.
...
Setting the initial order didn't work as expected due to reversed logic.
Follow-up to [48151].
See #45089 .
Built from https://develop.svn.wordpress.org/trunk@48165
git-svn-id: http://core.svn.wordpress.org/trunk@47934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 11:35:13 +00:00
178059c1cb
Docs: Improve DocBlocks in `wp-admin/includes/file.php` per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48164
git-svn-id: http://core.svn.wordpress.org/trunk@47933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 09:39:13 +00:00
f8c59f3152
Docs: Synchronize documentation and variable names in `wp_get_(plugin|theme)_file_editable_extensions()` for consistency.
...
Add missing `@since` tag to `wp_get_theme_file_editable_extensions()`.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48163
git-svn-id: http://core.svn.wordpress.org/trunk@47932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 09:31:15 +00:00
5162a10959
Docs: Improve DocBlocks in `wp-admin/includes/class-wp-list-table.php` per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48162
git-svn-id: http://core.svn.wordpress.org/trunk@47931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 08:56:16 +00:00
0792fb37db
Upgrade/Install: Fix Yoda condition in `wp_opcache_invalidate()`.
...
Fixes linting failure due to Yoda condition in `wp_opcache_invalidate()` following [48160].
See #36455 .
Built from https://develop.svn.wordpress.org/trunk@48161
git-svn-id: http://core.svn.wordpress.org/trunk@47930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 07:55:12 +00:00
dd11076dc7
Upgrade/Install: Invalidate OPcache for PHP files during updates.
...
When files are copied into place, check whether opcode invalidation is available and attempt to invalidate to avoid unintended behavior or fatal errors from themes, plugins, or core.
Introduces `wp_opcache_invalidate()` to allow safe invalidation of PHP files from opcode cache, and a filter, `wp_opcache_invalidate_file` to override the behavior.
Replaces the existing calls to `opcache_invalidate()` in the plugin and theme editors to use the new function.
Thanks to jnylen0 for porting over a patch from ClassicPress that provided much of the approach for what is being committed.
Props nigro.simone, dd32, JasWSInc, szepe.viktor, swissspidy, JanR, asalce, Garavani, pavelevap, pputzer, GregLone, benoitchantre, jadonn, doc987, kraftbj, Krstarica, jnylen0, nextendweb, williampatton, ayeshrajans, joostdevalk, stevenkussmaul, boogah, jorbin, mikeschroder.
Fixes #36455 , #50354 .
Built from https://develop.svn.wordpress.org/trunk@48160
git-svn-id: http://core.svn.wordpress.org/trunk@47929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 07:15:12 +00:00
6d927e494c
Block Editor: Add the Block Patterns API.
...
Backport WP_Block_Pattern_Categories_Registry, WP_Block_Patterns_Registry
and block patterns registration functions from the Gutenberg repository.
Props ocean90, ellatrix
Fixes #50445 .
Built from https://develop.svn.wordpress.org/trunk@48156
git-svn-id: http://core.svn.wordpress.org/trunk@47925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-24 12:59:11 +00:00
bb7601f6d0
Comments: Allow `wp_update_comment()` to return `WP_Error()`.
...
The `wp_update_comment_data` filter introduced in 4.7 allows comment data to be filtered before it is updated in the database.
The patch aims to handle `WP_Error` as the filter above return value in a similar manner as is done for `wp_new_comment()`.
Fixes #39732 .
Props: enricosorcinelli, swissspidy, gkloveweb, jnylen0, jbpaul17, afercia, SergeyBiryukov, audrasjb, imath, davidbaumwald.
Built from https://develop.svn.wordpress.org/trunk@48154
git-svn-id: http://core.svn.wordpress.org/trunk@47923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-24 00:05:12 +00:00
4f69c150b7
Cache API: Cache the results of `get_uploaded_header_images()`.
...
Fixes #49446 .
Props pbiron, SergeyBiryukov, desrosj.
Built from https://develop.svn.wordpress.org/trunk@48152
git-svn-id: http://core.svn.wordpress.org/trunk@47921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 23:34:06 +00:00
cb553e4747
Administration: Update `WP_List_Table::get_sortable_columns()` to support `asc` and `desc` arguments.
...
This makes the API a little more clear, whereas setting `false` used to mean `asc` and `true` meant `desc`, you can now use those directly, while maintaining back-compat.
Fixes #45089 .
Props Tkama, SergeyBiryukov, shital-patel, desrosj, birgire, davidbaumwald.
Built from https://develop.svn.wordpress.org/trunk@48151
git-svn-id: http://core.svn.wordpress.org/trunk@47920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 23:15:10 +00:00
517f6501df
Security: Don't display the plugin auto-update options for mu-plugins or dropins.
...
They can't be updated, so we shouldn't be showing the buttons.
Fixes #50459 .
Props Chouby, audrasjb, pbiron.
Built from https://develop.svn.wordpress.org/trunk@48149
git-svn-id: http://core.svn.wordpress.org/trunk@47918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 22:58:09 +00:00
ce784f7ad4
I18N: Include placeholder in translator comments in `wp_get_auto_update_message()`.
...
See #50436 , #50052 .
Built from https://develop.svn.wordpress.org/trunk@48148
git-svn-id: http://core.svn.wordpress.org/trunk@47917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 22:30:09 +00:00
8dad73a5b6
Security: Remove unnecessary `DISABLE_WP_CRON` check in plugin and theme automatic updates.
...
Fixes #50436 .
Props johnbillion, audrasjb, bookdude13, pbiron, arpitgshah.
Built from https://develop.svn.wordpress.org/trunk@48147
git-svn-id: http://core.svn.wordpress.org/trunk@47916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 22:24:09 +00:00
840d1c796b
Accessibility: Administration: Give the link to meetup organizer handbook in the WordPress Events and News dashboard widget a more meaningful label.
...
This ensures that the link still makes sense when read out of context by assistive technologies.
Additionally, underline the link per the accessibility coding standards.
Props samful, afercia, williampatton, audrasjb.
Fixes #50338 .
Built from https://develop.svn.wordpress.org/trunk@48146
git-svn-id: http://core.svn.wordpress.org/trunk@47915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 21:53:09 +00:00
a86cfefecb
Accessibility: Privacy: Improve the readability of the removed text in Privacy Policy Guide.
...
Per WCAG 2.0 guidelines, big chunks of italic text should be avoided for better accessibility.
Additionally, replace the legacy `.error` class for "You deactivated this plugin and may no longer need this policy" message with `.notice-info`.
Follow-up to [47147], [48116].
Props afercia, audrasjb.
See #47327 , #44621 .
Built from https://develop.svn.wordpress.org/trunk@48145
git-svn-id: http://core.svn.wordpress.org/trunk@47914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 20:57:11 +00:00
dee326a5e4
Accessibility: Site Health: Make the heading text for site health check issues easier to select in Firefox.
...
Props afercia, sabernhardt, johnbillion, Clorith, audrasjb.
Fixes #50281 .
Built from https://develop.svn.wordpress.org/trunk@48144
git-svn-id: http://core.svn.wordpress.org/trunk@47913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 20:48:10 +00:00
af0df40f6b
Themes: Ensure the Activate button in theme preview overlay on Add Themes screen has a consistent height.
...
Props afercia, pravinparmar2404, Toru, mukesh27.
Fixes #50316 .
Built from https://develop.svn.wordpress.org/trunk@48143
git-svn-id: http://core.svn.wordpress.org/trunk@47912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 20:13:10 +00:00
c5b1a12a55
General: Rename `(add|remove)_option_allowed_list()` to `(add|remove)_allowed_option()`.
...
The new names make the purpose more clear. It also adds consistency with the `$allowed_options` global variable.
Also in this change, the `wp-deprecated` dependency has been removed from the password strength meter in favor of a `window.console.log()` call to avoid adding 3 dependencies for one deprecated notice.
Props SergeyBiryukov, ocean90, desrosj
Fixes #50413 .
Built from https://develop.svn.wordpress.org/trunk@48142
git-svn-id: http://core.svn.wordpress.org/trunk@47911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 18:54:16 +00:00
a918d853aa
Quick/Bulk Edit: Ensure the proper actions is triggered when using the bulk updater.
...
If a user selects the top option, then chooses a different option, the top selection takes precedence. This update gives a new name to the bottom action, ensuring the proper update is carried out.
Fixes 46872.
Props clayray, garrett-eclipse, subrataemfluence.
Built from https://develop.svn.wordpress.org/trunk@48134
git-svn-id: http://core.svn.wordpress.org/trunk@47903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 05:56:08 +00:00
e7f9aca8dd
Editor: Revert [48119].
...
This commit caused the majority of blocks in the block editor to no longer
register as they reference the old category names.
See #50278 .
Built from https://develop.svn.wordpress.org/trunk@48130
git-svn-id: http://core.svn.wordpress.org/trunk@47899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 00:15:11 +00:00
9edf42f215
Administration: Remove unnecessary !important CSS rules from common.css
...
Fixes #47569 .
Props foack, SergeyBiryukov, davidbaumwald, sabernhardt, isabel_brison, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@48129
git-svn-id: http://core.svn.wordpress.org/trunk@47898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 00:01:07 +00:00
f51cb0a7c5
Media: Ensure that uploaded images get a success notification by users with `upload_files` capability.
...
There was an early `wp_die` that was preventing the success notification from being sent in the upload process.
Fixes #44581 .
Props pbiron, mikeschroder, joemcgill, rebasaurus, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48128
git-svn-id: http://core.svn.wordpress.org/trunk@47897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 23:53:09 +00:00
84f39df101
Privacy: Use relative paths for exported personal data.
...
Ensures back-compat while moving to paths off of the /exports directory.
Fixes : #44038 .
Props: allendav, mrTall, desrosj, garrett-eclipse, cameronamcintyre, nmenescardi, xkon, whyisjake, davidbaumwald.
Built from https://develop.svn.wordpress.org/trunk@48127
git-svn-id: http://core.svn.wordpress.org/trunk@47896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 22:40:11 +00:00
f27cb65e1e
Administration: Remove the `xmlns` attribute on the `<html>` tag.
...
The attribute is specific to XHTML and is not needed in HTML5.
Props audrasjb, diddledan, hommealone, joyously, mukesh27, valentinbora, peterwilsoncc, SergeyBiryukov.
Fixes #49126 .
Built from https://develop.svn.wordpress.org/trunk@48126
git-svn-id: http://core.svn.wordpress.org/trunk@47895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 21:26:16 +00:00
89e99f57a2
Site Health: Correct the check of whether the theme directory is writable when the current theme is symlinked into the theme directory.
...
This ensures that the check is done on a sub-directory within `WP_CONTENT_DIR`, rather than outside of `ABSPATH`.
Props pbiron, Clorith.
Fixes #48199 .
Built from https://develop.svn.wordpress.org/trunk@48125
git-svn-id: http://core.svn.wordpress.org/trunk@47894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 20:15:14 +00:00
d0d8ce1adb
Docs: Small inline documentation corrections following [48121].
...
Also, remove the `version` argument from the `wp.deprecated()` call in `password-strength-meter.js`. This argument is for specifying the version a feature will be removed, not when the feature was removed.
Props hareesh-pillai.
Fixes #50413 .
Built from https://develop.svn.wordpress.org/trunk@48124
git-svn-id: http://core.svn.wordpress.org/trunk@47893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 19:09:11 +00:00
35545bee43
Administration: Improve the plugin and theme auto-update emails.
...
This makes several improvements to the emails sent to site admins when plugin and theme auto-updates are attempted.
- Emails are now specifically tailored to the three results (success, failed, or mixed).
- Subject lines and body copy for mixed and failed results now correctly convey the importance of double checking the site in question.
- The site’s URL is now included in all emails.
- When failures occur, links to the Plugins and/or Themes pages in the admin are now included so that site owners can easily take action.
Props audrasjb, desrosj, azaozz, garrett-eclipse, paaljoachim, johnbillion, marybaum, pbiron.
Follow up to [47835].
See #50052 .
Fixes #50268 .
Built from https://develop.svn.wordpress.org/trunk@48123
git-svn-id: http://core.svn.wordpress.org/trunk@47892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 18:18:08 +00:00
acc97eae32
General: Reference the correct database version for 5.5.0 upgrades.
...
Follow up to [48121].
See #50413 .
Built from https://develop.svn.wordpress.org/trunk@48122
git-svn-id: http://core.svn.wordpress.org/trunk@47891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 17:33:08 +00:00
4b60af1a6a
General: Remove “whitelist” and “blacklist” in favor of more clear and inclusive language.
...
“The WordPress open source community cares about diversity. We strive to maintain a welcoming environment where everyone can feel included.”
With this commit, all occurrences of “whitelist” and “blacklist” (with the single exception of the `$new_whitelist_options` global variable) are removed. A new ticket has been opened to explore renaming the `$new_whitelist_options` variable (#50434 ).
Changing to more specific names or rewording sentences containing these terms not only makes the code more inclusive, but also helps provide clarity. These terms are often ambiguous. What is being blocked or allowed is not always immediately clear. This can make it more difficult for non-native English speakers to read through the codebase.
Words matter. If one contributor feels more welcome because these terms are removed, this was worth the effort.
Props strangerstudios, jorbin, desrosj, joemcgill, timothyblynjacobs, ocean90, ayeshrajans, davidbaumwald, earnjam.
See #48900 , #50434 .
Fixes #50413 .
Built from https://develop.svn.wordpress.org/trunk@48121
git-svn-id: http://core.svn.wordpress.org/trunk@47890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 17:26:13 +00:00
7dbc898342
Plugins: Make the appearance of plugin action links on Add Plugins screen more consistent.
...
This ensures that the "More Details" link does not randomly wrap to a second line depending on the length of the button label above.
Props sabernhardt, kharisblank, Otto42, paresh07.
Fixes #48648 .
Built from https://develop.svn.wordpress.org/trunk@48120
git-svn-id: http://core.svn.wordpress.org/trunk@47889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 15:30:18 +00:00
2349d1f999
Editor: Update default block categories
...
See https://github.com/WordPress/gutenberg/pull/19279 .
Props aduth, gziolo.
Fixes #50278 .
Built from https://develop.svn.wordpress.org/trunk@48119
git-svn-id: http://core.svn.wordpress.org/trunk@47888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 14:07:10 +00:00
29ffb31cb3
Blocks: Add context fields to WP_Block_Type
...
New block context related fields were added as part of https://github.com/WordPress/gutenberg/pull/22686 . This changest backports them to WP_Block_Type class.
Props aduth, spacedmonkey, mcsf, epiqueras.
Fixes #47656 .
Built from https://develop.svn.wordpress.org/trunk@48117
git-svn-id: http://core.svn.wordpress.org/trunk@47886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 10:26:14 +00:00
aa98d37cad
Accessibility: Improve readability by removing unnecessary italic font style.
...
Continues the removal of italic text where unnecessary or where used on whole lines and big chunks of text.
Removes italic type from:
- all the `howto` text e.g. the "Tags" meta box, the "Featured image" meta box, the "Insert/edit link" modal dialog in the Classic Editor
- the Taxonomies list pages
- the edit Taxonomies pages
- the Menus page
- the Settings pages
Props audrasjb.
See #47327 .
Built from https://develop.svn.wordpress.org/trunk@48116
git-svn-id: http://core.svn.wordpress.org/trunk@47885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-21 18:03:10 +00:00
ae447adaf4
I18N: Restore the "Error:" prefix for error messages.
...
Partially reverts [48059] as there's no full consensus on the removal of the text prefix. Further actions should be taken to improve consistency and accessibility of the admin notices. Keeps some improvements to the translatable strings from [48059].
Fixes #47656 .
Built from https://develop.svn.wordpress.org/trunk@48115
git-svn-id: http://core.svn.wordpress.org/trunk@47884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-21 14:00:09 +00:00
19bca10d79
Coding Standards: Replace `echo sprintf()` with `printf()`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@48111
git-svn-id: http://core.svn.wordpress.org/trunk@47880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 13:18:11 +00:00
be16bb9fba
Docs: Remove extra spaces from `@param` tags.
...
Per the documentation standards, `@param` tags should be aligned with each other, but not with the `@return` tag.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48110
git-svn-id: http://core.svn.wordpress.org/trunk@47879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:58:10 +00:00
b16368c268
Docs: Remove `@staticvar` tags from core.
...
The tag was supported in phpDocumentor 1.x, but is no longer supported in 2.x and 3.x.
Usage of static variables is considered an internal implementation detail and has no information value for someone reading the docs.
Props alishanvr, jrf.
Fixes #50426 .
Built from https://develop.svn.wordpress.org/trunk@48109
git-svn-id: http://core.svn.wordpress.org/trunk@47878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:40:12 +00:00
65724cf380
Docs: Correct DocBlock placement for `allow_subdirectory_install` filter.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48108
git-svn-id: http://core.svn.wordpress.org/trunk@47877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:24:08 +00:00
3fb623cf76
Docs: Use a hyphen with the "non" prefix in a more consistent way.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48106
git-svn-id: http://core.svn.wordpress.org/trunk@47875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:16:10 +00:00
26621b3b44
Docs: Miscellaneous DocBlock corrections for plugin and theme installation and updates.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48105
git-svn-id: http://core.svn.wordpress.org/trunk@47874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:14:09 +00:00
e13c363b17
Docs: Capitalize "ID", when referring to a post ID, term ID, etc. in a more consistent way.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48104
git-svn-id: http://core.svn.wordpress.org/trunk@47873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:02:12 +00:00
a576a13246
Docs: Remove an empty line between `@param` and `@return` tags, per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48102
git-svn-id: http://core.svn.wordpress.org/trunk@47871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 11:18:09 +00:00
1a77bb81d8
Docs: Remove unnecessary variables names from `@return` tags.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48100
git-svn-id: http://core.svn.wordpress.org/trunk@47869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-19 22:55:12 +00:00
acb8983ac1
Docs: Corrections and improvements to inline docs related to plugin and theme auto-updates.
...
See #50052 , #49572
Built from https://develop.svn.wordpress.org/trunk@48097
git-svn-id: http://core.svn.wordpress.org/trunk@47866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-19 22:17:07 +00:00
82a5d41d9b
Help/About: Move "Learn more: Auto-updates documentation" link about "Support", for consistency with other screens.
...
Follow-up to [48062].
See #50215 .
Built from https://develop.svn.wordpress.org/trunk@48095
git-svn-id: http://core.svn.wordpress.org/trunk@47864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-19 21:14:08 +00:00
aca919f007
Plugins and Themes Auto-Updates:
...
- Fix displaying of errors on the Themes screen.
- Correct the classes used for the error messages, and use `notice-alt` as notices are mostly shown on a white background.
Props afercia, azaozz.
Fixes #50405 .
Built from https://develop.svn.wordpress.org/trunk@48092
git-svn-id: http://core.svn.wordpress.org/trunk@47859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-19 16:51:14 +00:00
0050998801
Filesystem API: Expicitly set directory permissions in `WP_Filesystem_SSH2::mkdir()`.
...
This ensures the permissions are correct after a directory is created with `ssh2_sftp_mkdir()`, which appears to be affected by system `umask` settings.
Props bbrdaric.
Fixes #49218 .
Built from https://develop.svn.wordpress.org/trunk@48090
git-svn-id: http://core.svn.wordpress.org/trunk@47857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-19 10:38:08 +00:00
527696af3b
Coding Standards: Add some space around control structures in `WP_Filesystem_*` classes for consistency and better readability.
...
Additionally, synchronize `$tempfile` and `$temphandle` variable names in `WP_Filesystem_FTPext` and `WP_Filesystem_ftpsockets`.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@48089
git-svn-id: http://core.svn.wordpress.org/trunk@47856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-19 10:36:12 +00:00
1e3d4921fb
Privacy: Revert use relative paths for exported personal data.
...
Tests need to be updated to pass.
See: #44038 .
Unprops: whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48088
git-svn-id: http://core.svn.wordpress.org/trunk@47855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-18 23:02:10 +00:00
2d514c83d5
Privacy: Use relative paths for exported personal data.
...
Ensures back-compat while moving to paths off of the `/exports` directory.
Fixes : #44038 .
Props: allendav, mrTall, desrosj, garrett-eclipse, cameronamcintyre, nmenescardi, xkon, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48087
git-svn-id: http://core.svn.wordpress.org/trunk@47854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-18 21:40:14 +00:00
05e28b4d7c
Coding Standards: Use strict comparison for JS fragment in `wp-admin/admin-header.php`.
...
Props subrataemfluence.
Fixes #45810 .
Built from https://develop.svn.wordpress.org/trunk@48083
git-svn-id: http://core.svn.wordpress.org/trunk@47850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-18 20:08:09 +00:00
8d3075952e
Administration: Combine the styles for `<p>` and `.wp-die-message`, instead of duplicating.
...
This brings some consistency with `_default_wp_die_handler()`, where they are already combined.
Follow-up to [45909].
See #47580 .
Built from https://develop.svn.wordpress.org/trunk@48082
git-svn-id: http://core.svn.wordpress.org/trunk@47849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-18 15:07:11 +00:00
d61790f9dc
Fix empty line phpcs error.
...
See #50280 .
Built from https://develop.svn.wordpress.org/trunk@48078
git-svn-id: http://core.svn.wordpress.org/trunk@47845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-18 00:46:09 +00:00
7757ad5e94
Plugins and Themes Auto-Updates: allow overriding of the HTML for the auto-update setting link. This will let plugins show better/specific information when they are overriding the auto-update settings, for example "Updates are managed by ... plugin".
...
Introduces: `theme_auto_update_setting_html`, `plugin_auto_update_setting_html`, and `theme_auto_update_setting_template` filters.
Props audrasjb, pbiron, azaozz.
Fixes #50280 .
Built from https://develop.svn.wordpress.org/trunk@48077
git-svn-id: http://core.svn.wordpress.org/trunk@47844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-18 00:00:13 +00:00
cb72d22d67
Menus: Check the correct variable in `Walker_Nav_Menu_Edit::start_el()` when menu item is a taxonomy term.
...
Follow-up to [45891].
Props ashour.
Fixes #50415 .
Built from https://develop.svn.wordpress.org/trunk@48076
git-svn-id: http://core.svn.wordpress.org/trunk@47843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-17 19:47:14 +00:00
689fdc6319
Site Health: Verify PHP version requirements when auto-updating themes.
...
Follow up of [47819].
See #49653 .
Fixes #50411 .
Built from https://develop.svn.wordpress.org/trunk@48071
git-svn-id: http://core.svn.wordpress.org/trunk@47838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-17 14:48:07 +00:00
de59ad23a4
Docs: Consistently include an empty line between `@since` tag and `@see`, `@link`, or `@global`, per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48067
git-svn-id: http://core.svn.wordpress.org/trunk@47834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 21:07:14 +00:00
49edaea6f1
Coding Standards: Fix WPCS issues in `wp-admin/nav-menus.php`.
...
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@48063
git-svn-id: http://core.svn.wordpress.org/trunk@47830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 18:38:08 +00:00
97e2b94f84
Help/About: Add help tabs to provide informations about plugin & themes auto-updates.
...
Adds language around how the feature works and includes links to the WordPress HelpHub pages.
Fixes : #50215 .
Props: audrasjb, garrett-eclipse, paaljoachim, marybaum, pbiron, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48062
git-svn-id: http://core.svn.wordpress.org/trunk@47829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 17:29:07 +00:00
f83c504b88
I18N: Remove the "Error:" prefix from error messages.
...
For a number of years, most of the WordPress error messages have been prefixed with "Error:". However, these messages appear in a context where it's already clear an error occurred. Whether it's an error, a warning, or any other classification, that's not so relevant for users. The content of the message is the relevant part. The "Error:" prefix doesn't add great value while it does add unnecessary complexity for the message readability.
Also, revises some of these messages to improve clarity and removes HTML from translatable strings.
Props garrett-eclipse, ramiy, SergeyBiryukov, afercia, sabernhardt, quadthemes, audrasjb.
See #47003 , #43037 , #42945 , #15887 .
Fixes #47656 .
Built from https://develop.svn.wordpress.org/trunk@48059
git-svn-id: http://core.svn.wordpress.org/trunk@47826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 15:35:13 +00:00
ccf534dc48
Code Standards: Cleanup some code spacing.
...
See: #37826 and #44286 .
Built from https://develop.svn.wordpress.org/trunk@48052
git-svn-id: http://core.svn.wordpress.org/trunk@47819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 00:56:08 +00:00
d3c44a690d
Menus: Provide menu settings when creating a new menu.
...
This simplifies the steps in the process of adding new menus.
Props: garrett-eclipse, audrasjb, ianjvr.
Built from https://develop.svn.wordpress.org/trunk@48051
git-svn-id: http://core.svn.wordpress.org/trunk@47818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 23:22:06 +00:00
28d29b35f7
Comments: Don't display edit links to trashed post comments.
...
If a post is in the trash, the comments bubble won't link to the comments list.
Fixes : #37826 .
Props: swissspidy, helen, FolioVision, DrewAPicture, stevenlinx, donmhico, birgire, garrett-eclipse, andraganescu, johnbillion.
Built from https://develop.svn.wordpress.org/trunk@48050
git-svn-id: http://core.svn.wordpress.org/trunk@47817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 23:06:08 +00:00
6aa5788189
Text Changes: Replace "Webmaster" in output messages with more appropriate terms:
...
* "All at `###SITENAME###`" in `wp-admin/ms-delete-site.php`, for consistency with other Multisite emails.
* "Site admin" in `register_new_user()`, for clarity.
Props Presskopp, marybaum.
Fixes #50394 .
Built from https://develop.svn.wordpress.org/trunk@48049
git-svn-id: http://core.svn.wordpress.org/trunk@47816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 19:41:11 +00:00
893c580831
Users: On the 'Add New User' screen, don't show the roles dropdown if the current user can't promote other users.
...
Fixes #50345 .
Built from https://develop.svn.wordpress.org/trunk@48042
git-svn-id: http://core.svn.wordpress.org/trunk@47809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-14 17:03:10 +00:00
9f7a7f8d57
Coding Standards: Fix code indentation in `post_submit_meta_box()` to improve readability.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@48041
git-svn-id: http://core.svn.wordpress.org/trunk@47808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-14 16:31:08 +00:00
04200b39ce
Themes: Ensure the theme slug is set before checking if the theme is installed or active.
...
This fixes an issue with every installed theme being marked as active on Themes screen.
The slug is set on Add Themes screen, but not on Themes.
Follow-up to [47924].
Props BackuPs, mukesh27, SergeyBiryukov.
Fixes #50381 . See #50334 .
Built from https://develop.svn.wordpress.org/trunk@48037
git-svn-id: http://core.svn.wordpress.org/trunk@47804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-13 14:26:07 +00:00
4cc11cdbdd
Filesystem API: Avoid a PHP notice in `WP_Filesystem_Direct::owner()` and `::group()` methods and their `WP_Filesystem_SSH2` counterparts.
...
Although not officially documented in the PHP manual, `posix_getpwuid()` and `posix_getgrgid()` can return `false` in some circumstances.
Props logig.
Fixes #50373 .
Built from https://develop.svn.wordpress.org/trunk@48031
git-svn-id: http://core.svn.wordpress.org/trunk@47798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-12 12:35:09 +00:00
dda0ccdd18
Administration: Add a new filter to extend `set-screen-option`.
...
Props: xknown, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@47951
git-svn-id: http://core.svn.wordpress.org/trunk@47723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:24:51 +00:00
ffc4869c9c
Themes: Ensure a broken theme name is returned properly.
...
Props: sstoqnov.
Built from https://develop.svn.wordpress.org/trunk@47950
git-svn-id: http://core.svn.wordpress.org/trunk@47722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:23:36 +00:00
7e9267567f
Editor: Prevent HTML decoding on by setting the proper editor context.
...
Props: sstoqnov.
Built from https://develop.svn.wordpress.org/trunk@47948
git-svn-id: http://core.svn.wordpress.org/trunk@47720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:21:20 +00:00
784908ae5f
Coding Standards: PHP short ternary operator syntax is not allowed.
...
WPCS 2.2.0 added a sniff for detecting short ternary operator syntax, which is not allowed per the Core handbook.
Follow up of [47927].
Fixes #50258 .
Built from https://develop.svn.wordpress.org/trunk@47929
git-svn-id: http://core.svn.wordpress.org/trunk@47702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 21:27:10 +00:00
4adfd75159
Themes: Show a disabled "Activated" button instead of "Activate" for the active theme on Add Themes screen.
...
Additionally, switch the "Live Preview" label for the active theme to "Customize", for consistency with the Themes screen.
Props afercia, SergeyBiryukov.
Fixes #50334 .
Built from https://develop.svn.wordpress.org/trunk@47924
git-svn-id: http://core.svn.wordpress.org/trunk@47698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 18:16:10 +00:00
18a9359c06
Posts, Post Types: Display a more specific error message when an attachment could not be inserted into the database.
...
Props shital-patel, Presskopp, ocean90.
Fixes #50325 .
Built from https://develop.svn.wordpress.org/trunk@47922
git-svn-id: http://core.svn.wordpress.org/trunk@47696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-07 09:24:11 +00:00
0b9a800512
Media: remove any `attachment-filter` query param when switching views.
...
Fix an issue where the media attachment filter no longer worked after switching to list view, filtering by a media type then switching back to the grid view.
Props itzmekhokan, netsurfer2705, zodiac1978.
Fixes #43656 .
Built from https://develop.svn.wordpress.org/trunk@47915
git-svn-id: http://core.svn.wordpress.org/trunk@47689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-05 21:13:10 +00:00
4bbb7fb852
Docs: Update the DocBlock for the `wp_media_attach_action` hook per the documentation standards.
...
Rename the `$att_id` variable to `$attachment_id` for clarity.
Follow-up to [47909].
See #49614 .
Built from https://develop.svn.wordpress.org/trunk@47913
git-svn-id: http://core.svn.wordpress.org/trunk@47687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-05 08:30:10 +00:00
b013a15d43
Accessibility: Add the `aria-hidden` attribute to the auto-update related icons.
...
`<span>` elements used for displaying icons should use the `aria-hidden` attribute as they are purely decorative.
Props audrasjb, ryokuhi.
Fixes #50293 .
Built from https://develop.svn.wordpress.org/trunk@47910
git-svn-id: http://core.svn.wordpress.org/trunk@47684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 15:47:09 +00:00
00d3696923
Media: Add an action for `wp_media_attach_action`.
...
This action fires when media is attached/detached from a post.
Fixes : #49614 .
Props: jonoaldersonwp, antpb, rebasaurus, donmhico.
Built from https://develop.svn.wordpress.org/trunk@47909
git-svn-id: http://core.svn.wordpress.org/trunk@47683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 15:00:09 +00:00
b50e87d52b
Docs: Add missing `@global` reference for the `$post_id` global in `wp_admin_bar_edit_menu()`.
...
Follow-up to [47903].
Props davidbaumwald.
See #50312 .
Built from https://develop.svn.wordpress.org/trunk@47906
git-svn-id: http://core.svn.wordpress.org/trunk@47680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 21:27:09 +00:00
27485fd7aa
General: Continuing to work towards a passing PHP Compatibility scan.
...
This is a final pass to fix PHP compatibiilty issues in the codebase with code changes or adding `phpcs:ignore` comments.
With this change, all PHP compatibility warnings and errors without specific tickets have been addressed (see #49810 and #41750 ).
Props desrosj, johnbillion, jrf.
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47902
git-svn-id: http://core.svn.wordpress.org/trunk@47676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 17:40:12 +00:00
f22e113e95
File Editor: Don't verify SSL certificate when doing loopback requests for checking for fatal errors.
...
Previously, verification was disabled for the loopback request to the admin URL, but not to the home URL.
Follow-up to [46230].
Props munyagu.
Fixes #50309 . See #47957 .
Built from https://develop.svn.wordpress.org/trunk@47896
git-svn-id: http://core.svn.wordpress.org/trunk@47670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 11:43:15 +00:00
cf597dcf7c
Plugins: Make the message displayed when no plugins are installed more concise.
...
Props johnjamesjacoby, Presskopp.
Fixes #42336 .
Built from https://develop.svn.wordpress.org/trunk@47894
git-svn-id: http://core.svn.wordpress.org/trunk@47668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 10:51:13 +00:00
b247cafd91
Docs: Correct `@since` version for `available_permalink_structure_tags` filter.
...
Follow-up to [41182].
Props tiagohillebrandt, sabernhardt.
Fixes #42624 .
Built from https://develop.svn.wordpress.org/trunk@47893
git-svn-id: http://core.svn.wordpress.org/trunk@47667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 10:38:09 +00:00
ba92ed7615
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/updates.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50235 .
Built from https://develop.svn.wordpress.org/trunk@47884
git-svn-id: http://core.svn.wordpress.org/trunk@47658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 21:41:09 +00:00
0318a92948
Plugins and Themes Auto-Updates: update the state of the auto-update link on the themes screen after successfully saving the setting.
...
Props desrosj, pbiron, azaozz.
Fixes #50291 .
Built from https://develop.svn.wordpress.org/trunk@47883
git-svn-id: http://core.svn.wordpress.org/trunk@47657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 20:53:15 +00:00
69a866a1a9
Administration: Unify the date structure in list view and excerpt view.
...
Both views now show a full date string. Something like `Published 2020/05/27 at 10:25 pm`.
Fixes : #35391 .
Props: afercia, ocean90, TimothyBlynJacobs, audrasjb, SergeyBiryukov, joedolson.
Built from https://develop.svn.wordpress.org/trunk@47879
git-svn-id: http://core.svn.wordpress.org/trunk@47653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 19:15:08 +00:00
c704057e0d
Add fields to WP_Block_Type
...
As part of #47620 and the RFC for block registeration. Server registered blocks are missing some fields. These changeset includes them.
Props spacedmonkey, aduth.
Fixes #48529 .
Built from https://develop.svn.wordpress.org/trunk@47875
git-svn-id: http://core.svn.wordpress.org/trunk@47649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 12:27:08 +00:00
1c176ffb1e
Docs: Correct and clarify an inline comment about the `upload_url_path` and `upload_path` options in `wp-admin/options-media.php`.
...
Synchronize it with a similar comment in `wp-admin/options.php`.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47874
git-svn-id: http://core.svn.wordpress.org/trunk@47648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 11:22:13 +00:00
9859bf6204
Build/Test Tools: Revert some devDependency changes for 5.5.
...
After bumping some major updates, tests on Travis are failing.
See: https://travis-ci.com/WordPress/wordpress-develop/builds/168839259 ##49768.
Unprops: whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47869
git-svn-id: http://core.svn.wordpress.org/trunk@47644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 19:51:42 +00:00
8924832842
Coding Standards: Use strict comparison in `wp-admin/_index.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47862
git-svn-id: http://core.svn.wordpress.org/trunk@47638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-28 10:02:12 +00:00
38b7495af7
Administration and Site Health: Make information on Search engine visibility more prominent.
...
- makes the "Search engines discouraged" message on the Dashboard more prominent
- adds "Search engine visibility" information under Site Health > Info > WordPress
- removes title case in favor of sentence case in all the related strings
Props audrasjb, swissspidy, emanuel_blagonic, Presskopp, karmatosed, valentinbora, melchoyce.
Fixes #35288 .
Built from https://develop.svn.wordpress.org/trunk@47859
git-svn-id: http://core.svn.wordpress.org/trunk@47635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-27 14:33:11 +00:00
Sergey Biryukov
John Blackbourn
ellatrix
Mike Schroder
youknowriad
whyisjake
desrosj
noisysocks
gziolo
Andrea Fercia
Andrew Ozz
Dominik Schilling
Adam Silverstein