WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
39,783 Commits 50 Branches 749 Tags 982 MiB
Commit Graph

368 Commits

Author SHA1 Message Date
Konstantin Kovshenin 919867b090 Docs: Remove some more dittography. 
See #34885, r35793.

Built from https://develop.svn.wordpress.org/trunk@35796


git-svn-id: http://core.svn.wordpress.org/trunk@35760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-06 21:50:25 +00:00
Mark Jaquith 1a43f0b290 Do not pass FALSE as second parameter in variable class_exists() checks 
Because these are generally plugin-provided, we want plugins to be
able to use autoloaders.

fixes #20523
Built from https://develop.svn.wordpress.org/trunk@35749


git-svn-id: http://core.svn.wordpress.org/trunk@35713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-11-30 04:15:27 +00:00
Aaron Jorbin e8d8e79371 Revert [34291] bringing back my-hacks 
Keeping myhacks support is a small price to pay for not breaking people's sites.  Even if it is very very very few sites, breaking sites isn't something that should be encouraged. Even with 10 years of deprecation notices.

https://core.trac.wordpress.org/ticket/33741#comment:18 outlines all the ways that the hack_file and my-hacks options can be setup and thus all the ways that the removal of those options could break sites.

Fixes #33741.



Built from https://develop.svn.wordpress.org/trunk@35688


git-svn-id: http://core.svn.wordpress.org/trunk@35652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-11-18 20:49:26 +00:00
Dion Hulse 42ff945649 Decrease the chances that `wp_tempnam()` will conflict with an existing file by suffixing a random ID to the generated filename. 
This also switches from using `touch()` to using `fopen( $file, 'x')` to ensure that we're the process creating the file.

Fixes #34562

Built from https://develop.svn.wordpress.org/trunk@35644


git-svn-id: http://core.svn.wordpress.org/trunk@35608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-11-16 05:33:25 +00:00
Dion Hulse f47801d504 Media: Allow `media_sideload_image()` to work when the upload directory is a PHP Stream. Using copy() instead of rename() allows the function to work across different stream sources. 
Props mattheu.
Fixes #29257

Built from https://develop.svn.wordpress.org/trunk@35579


git-svn-id: http://core.svn.wordpress.org/trunk@35543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-11-09 00:44:27 +00:00
Scott Taylor 85d21feca6 Plugins/Updates: in `request_filesystem_credentials()`, alter the heading HTML tag based on the current screen for improved semantics. 
Props afercia.
Fixes #34267.

Built from https://develop.svn.wordpress.org/trunk@35315


git-svn-id: http://core.svn.wordpress.org/trunk@35281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-21 03:51:24 +00:00
Drew Jaynes 1cb39b180f Docs: Standardize the file header summary for wp-admin/includes/file.php. 
Also adds an `@since` version and corrects the `@subpackage` value.

See #33701.

Built from https://develop.svn.wordpress.org/trunk@35221


git-svn-id: http://core.svn.wordpress.org/trunk@35187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-16 16:56:26 +00:00
Boone Gorges 0e7c1d3b14 Use `wp_installing()` instead of `WP_INSTALLING` constant. 
The `WP_INSTALLING` constant is a flag that WordPress sets in a number of
places, telling the system that options should be fetched directly from the
database instead of from the cache, that WP should not ping wordpress.org for
updates, that the normal "not installed" checks should be bypassed, and so on.

A constant is generally necessary for this purpose, because the flag is
typically set before the WP bootstrap, meaning that WP functions are not yet
available.  However, it is possible - notably, during `wpmu_create_blog()` -
for the "installing" flag to be set after WP has already loaded. In these
cases, `WP_INSTALLING` would be set for the remainder of the process, since
there's no way to change a constant once it's defined. This, in turn, polluted
later function calls that ought to have been outside the scope of site
creation, particularly the non-caching of option data. The problem was
particularly evident in the case of the automated tests, where `WP_INSTALLING`
was set the first time a site was created, and remained set for the rest of the
suite.

The new `wp_installing()` function allows developers to fetch the current
installation status (when called without any arguments) or to set the
installation status (when called with a boolean `true` or `false`). Use of
the `WP_INSTALLING` constant is still supported; `wp_installing()` will default
to `true` if the constant is defined during the bootstrap.

Props boonebgorges, jeremyfelt.
See #31130.
Built from https://develop.svn.wordpress.org/trunk@34828


git-svn-id: http://core.svn.wordpress.org/trunk@34793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-05 15:06:28 +00:00
Scott Taylor 8bb4c2c2e9 Theme Editor: ensure that files named `index.php` in theme subfolders are not labeled as "Main Index Template" 
Props MikeHansenMe, wonderboymusic, bravokeyl, Shelob9.
Fixes #27201.

Built from https://develop.svn.wordpress.org/trunk@34658


git-svn-id: http://core.svn.wordpress.org/trunk@34622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-28 03:11:24 +00:00
John Blackbourn aa35e473f7 `callback` is not a valid type in PHP, PSR-5, or phpDocumentor. `callable` should be used instead. 
Fixes #34032

Built from https://develop.svn.wordpress.org/trunk@34566


git-svn-id: http://core.svn.wordpress.org/trunk@34530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 23:58:25 +00:00
Scott Taylor 84da11d918 Pass `false` as the 2nd argument to `class_exists()` to disable autoloading and to not cause problems for those who define `__autoload()`. 
Fixes #20523.

Built from https://develop.svn.wordpress.org/trunk@34348


git-svn-id: http://core.svn.wordpress.org/trunk@34312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 03:52:25 +00:00
Aaron Jorbin 10d03c1ab3 Remove support for my-hacks.php 
For the last 10 years, my-hacks has been deprecated and has been throwing a deprecation notice. For the last six years, you haven't been able to enable my-hacks.php in the admin UI. That should be enough time to give developers notice. Plugins and themes seem like they might have staying power.

Fixes #33741
Props bobbingwide


Built from https://develop.svn.wordpress.org/trunk@34291


git-svn-id: http://core.svn.wordpress.org/trunk@34255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 17:06:25 +00:00
Dominik Schilling f3a62b7714 Theme Editor: Change file descriptions of `header.php` and `footer.php`. 
`header.php` is now "Theme Header" and `footer.php` is "Theme Footer". This prevents a clash with other "Header" strings in the context of "Custom Header".

Props ramiy.
Fixes #32975.
Built from https://develop.svn.wordpress.org/trunk@34290


git-svn-id: http://core.svn.wordpress.org/trunk@34254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 16:03:24 +00:00
Drew Jaynes 13c25f5f49 Docs: Put "it's" in its place (again). 
Props kitchin.
Fixes #33894.

Built from https://develop.svn.wordpress.org/trunk@34234


git-svn-id: http://core.svn.wordpress.org/trunk@34198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-16 12:46:28 +00:00
Sergey Biryukov 465e348c12 Fix closing div in `wp_print_request_filesystem_credentials_modal()`. 
Props trepmal.
Fixes #33737.
Built from https://develop.svn.wordpress.org/trunk@33908


git-svn-id: http://core.svn.wordpress.org/trunk@33877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 15:17:24 +00:00
Scott Taylor a0e373ef80 For doc block types, favor `bool` over the few remaining `boolean`s 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32964


git-svn-id: http://core.svn.wordpress.org/trunk@32935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 01:03:25 +00:00
Scott Taylor b56b9b3e5c Add `@global` annotations for `wp-admin/*`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32642


git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 21:41:30 +00:00
Drew Jaynes cdbecf201b Clarify accepted types for the `$args` and `$context` parameters in `WP_Filesystem()`. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32338


git-svn-id: http://core.svn.wordpress.org/trunk@32309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-04 01:04:25 +00:00
Dion Hulse 610e34c215 When creating a temporary file treat the `/` directory properly, to prevent it ending up in an endless self-calling loop. 
Props hnle, taka2. Fixes #32135. See #31811

Built from https://develop.svn.wordpress.org/trunk@32322


git-svn-id: http://core.svn.wordpress.org/trunk@32293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-29 03:17:31 +00:00
Dominik Schilling 89e45feb4c Don't focus input fields outside of the request filesystem credentials form. 
props valendesigns.
fixes #32055.
Built from https://develop.svn.wordpress.org/trunk@32266


git-svn-id: http://core.svn.wordpress.org/trunk@32237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-22 16:24:26 +00:00
Aaron Jorbin abfddb8f3e Update placeholder for FTP credentials 
Two changes:
 * Remove superfluous __ function call
 * Update domain used

Fixes #31922
Props Tmeister


Built from https://develop.svn.wordpress.org/trunk@32077


git-svn-id: http://core.svn.wordpress.org/trunk@32056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-08 16:50:27 +00:00
Drew Jaynes 02810a305f Clarify the DocBlock description for `wp_print_request_filesystem_credentials_modal()`. 
See [31811]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32016


git-svn-id: http://core.svn.wordpress.org/trunk@31995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-04 21:13:26 +00:00
Aaron Jorbin 8f99fbeb8d Refine UI for FTP modal and shiny updates 
Numerous changes to make the FTP modal experience a good one.  These include:
 * Update HTML used by both the form here and the form on the standalone screen
 * Allow users to cancel FTP install
 * Focus locking in the modal
 * Focus on modal form on load
 * ARIA Attributes
 * Style Enhancements
 * Add low screen height (such as phone and some tablets) friendly experience for entering credentials

Props ericlewis, afercia 
Fixes #31608


Built from https://develop.svn.wordpress.org/trunk@31949


git-svn-id: http://core.svn.wordpress.org/trunk@31928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-01 02:48:28 +00:00
Dion Hulse 7e1e32909e Add some logic into `wp_tempnam` to prevent it creating 'falsey' directory names that might get used elsewhere within WordPress. 
Although this logic looks a little strange at this low level, it's the best location within the Upgrades code for it to happen.
Fixes #31811

Built from https://develop.svn.wordpress.org/trunk@31936


git-svn-id: http://core.svn.wordpress.org/trunk@31915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-31 02:11:26 +00:00
Drew Jaynes 1ad0eaf416 Clean up DocBlock information and syntax for `get_filesystem_method()`. 
Props ericlewis, HarishChaudhari, valendesigns.
Fixes #31267.

Built from https://develop.svn.wordpress.org/trunk@31884


git-svn-id: http://core.svn.wordpress.org/trunk@31863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-25 16:32:28 +00:00
Aaron Jorbin 2d64637ff8 Request FTP and SSH credentials when needed during shiny updates 
This is a restoration of [31749] which was reverted in [31755].

It includes a number of enhancements from the original version.  Namely:
 * Not doing a credential check in src/wp-includes/script-loader.php
 * Add new function `wp_print_request_filesystem_credentials_modal`
 * update the version number in the list table when a plugin is updated

UI still needs further work, but this basic version should enable more testing

Props ericlewis, jorbin
See #31528


Built from https://develop.svn.wordpress.org/trunk@31811


git-svn-id: http://core.svn.wordpress.org/trunk@31793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-18 03:18:27 +00:00
Scott Taylor eeda68bbda Fix some erroneous `@param` annotations. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31219


git-svn-id: http://core.svn.wordpress.org/trunk@31200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 22:44:25 +00:00
Scott Taylor bc55996a0b `@param` cleanup: 
* `get_metadata()` will return literally anything, needs to be `mixed`
* `wp()` and `WP_Query::__construct()` no longer just take a query string
* Clarify a few others

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31212


git-svn-id: http://core.svn.wordpress.org/trunk@31193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 19:03:23 +00:00
Scott Taylor 60b0cd7943 The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31090


git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 07:05:25 +00:00
Scott Taylor ff98cfcf45 Pinking Shears. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31077


git-svn-id: http://core.svn.wordpress.org/trunk@31058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 05:03:23 +00:00
Dion Hulse 5661464d35 Background Updates: Pass back whether Group Writable support is being leveraged for an update to the WordPress.org API. 
See #30245

Built from https://develop.svn.wordpress.org/trunk@30860


git-svn-id: http://core.svn.wordpress.org/trunk@30850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-15 14:08:23 +00:00
Drew Jaynes 23707b1ada Convert various uses of `(optional)` in core parameter descriptions to use the style prescribed in the inline documentation standards for PHP. 
The style for marking parameters optional in inline PHP docs is: `@param type $var Optional. Description. Accepts. Default.`, where Accepts can be omitted on a case-by-case basis.

Props coffee2code.
Fixes #30591.

Built from https://develop.svn.wordpress.org/trunk@30753


git-svn-id: http://core.svn.wordpress.org/trunk@30743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 21:24:45 +00:00
Drew Jaynes 78bb3e5ff5 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*. 
Also adds a few inline `@see` cross-references as they apply.

Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30648


git-svn-id: http://core.svn.wordpress.org/trunk@30638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 11:28:24 +00:00
Drew Jaynes de809a5a86 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Remove HTML tag from parameter description in `comment_form()`
* Remove HTML tag from a summary for the `comment_form_top` hook
* Markdown-indent a code snippet in the description for `get_linkobjectsbyname()`
* Markdown-indent a code snippet and format an unordered list in the description for `get_linkobjects()`
* Backtick-escape some inline code in the description for `clean_pre()`
* Remove HTML tag from the summary for the `rss_tag_pre` hook
* Various formatting fixes in the descriptions for `get_filesystem_method()` and `request_filesystem_credentials()`

Props rarst for the initial patch.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30538


git-svn-id: http://core.svn.wordpress.org/trunk@30527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 05:19:23 +00:00
Dion Hulse 9b9289e0a3 Background Updates: Introduce support to take advantage of Group Writable (or World Writable) to Core Background updates. 
This is only enabled when new files will not be installed during the update (as indicated by the WordPress.org API), and does not apply to Plugin/Theme/Translation Background Updates.

Additionally, the code to determine if the 'direct' filesystem transport should be used has been tweaked for wider support (where getmyuid() was unavailalbe) which fixes #10424

See #10205, #30245

Built from https://develop.svn.wordpress.org/trunk@30384


git-svn-id: http://core.svn.wordpress.org/trunk@30381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-19 05:40:23 +00:00
Scott Taylor 5e3a64e83d Correct some types in `wp-admin/*`-location files' doc blocks. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30203


git-svn-id: http://core.svn.wordpress.org/trunk@30203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 07:09:23 +00:00
Drew Jaynes f8657d5890 Remove redundant and erroneous `@uses` tag from most core inline documentation. 
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.

Built from https://develop.svn.wordpress.org/trunk@30105


git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-30 01:05:24 +00:00
Scott Taylor ee97a47c61 In `_wp_handle_upload()`, if `test_upload` is set to `false` in the array of dangerous overrides that the function allows, the only thing that happens when an upload fails is more potential breakage. 
`$test_uploaded_file` lets is know if `$file['tmp_name']` exists, which allows to exit with an error, instead of continuing to attempt to move the file.

`$test_upload` override is now a noop.

Fixes #28208.

Built from https://develop.svn.wordpress.org/trunk@30076


git-svn-id: http://core.svn.wordpress.org/trunk@30076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-28 21:17:22 +00:00
Andrew Nacin 1447092f6e Don't set ftp_credentials option when installling. see #29635. 
Built from https://develop.svn.wordpress.org/trunk@29749


git-svn-id: http://core.svn.wordpress.org/trunk@29521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-17 17:58:15 +00:00
Dominik Schilling 6c9853930a Add missing array keys for connection type in `request_filesystem_credentials()`. 
see [28456].
fixes #29347.

Built from https://develop.svn.wordpress.org/trunk@29580


git-svn-id: http://core.svn.wordpress.org/trunk@29354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-24 16:04:18 +00:00
Scott Taylor a14f5b97d5 In `sanitize_file_name()`, replace `%20` and `+` with dashes. Remove unnecessary code from `_wp_handle_upload()`. 
Adds unit tests.

Props ericmann.
Fixes #16330.

Built from https://develop.svn.wordpress.org/trunk@29290


git-svn-id: http://core.svn.wordpress.org/trunk@29072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-24 22:09:16 +00:00
Scott Taylor fa02568c42 Merge `wp_handle_upload()` and `wp_handle_sideload()` by making them each wrap a new function: `_wp_handle_upload()`. 
Props DrewAPicture for docs.
Fixes #23686.

Built from https://develop.svn.wordpress.org/trunk@29209


git-svn-id: http://core.svn.wordpress.org/trunk@28993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-17 18:58:44 +00:00
Drew Jaynes 097dc8ee15 Fix syntax for single- and multi-line comments in wp-admin-directory files. 
See #28931.

Built from https://develop.svn.wordpress.org/trunk@29206


git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-17 09:14:16 +00:00
John Blackbourn 3f1c3dd4ca Normalise the schemes used in `get_home_path()` so it returns the correct path for sites using SSL in the admin area but not the front end. Fixes #25767. Props GregLone for the initial patch. 
Built from https://develop.svn.wordpress.org/trunk@28893


git-svn-id: http://core.svn.wordpress.org/trunk@28692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 10:29:14 +00:00
Scott Taylor 8eb9f2ffe4 Eliminate use of `extract()` in `request_filesystem_credentials()`. 
The only property that doesn't need to be set to a variable is `$password`.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28456


git-svn-id: http://core.svn.wordpress.org/trunk@28283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 18:26:15 +00:00
Scott Taylor 39de969bf2 Update inline docs for `wp_handle_upload|sideload` to reflect their non-use of `extract()`. 
See #22400.


Built from https://develop.svn.wordpress.org/trunk@28452


git-svn-id: http://core.svn.wordpress.org/trunk@28279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 17:41:16 +00:00
Scott Taylor 632eb5b17e Eliminate use of `extract()` in `wp_handle_sideload()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28451


git-svn-id: http://core.svn.wordpress.org/trunk@28278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 16:15:14 +00:00
Scott Taylor 4caf3e79f3 Eliminate use of `extract()` in `wp_handle_upload()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28450


git-svn-id: http://core.svn.wordpress.org/trunk@28277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 16:10:38 +00:00
Scott Taylor d74272ecf5 Eliminate one of the uses of `extract()` in `wp_handle_upload()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28417


git-svn-id: http://core.svn.wordpress.org/trunk@28244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 04:31:14 +00:00
Scott Taylor fc59804352 Eliminate one of the uses of `extract()` in `wp_handle_sideload()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28416


git-svn-id: http://core.svn.wordpress.org/trunk@28243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 04:29:15 +00:00
Scott Taylor 644024dfc4 Dead code in `wp-admin/includes/file.php`: 
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28268


git-svn-id: http://core.svn.wordpress.org/trunk@28096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:22:14 +00:00
Sergey Biryukov 2cb849fc52 Fix typo in verify_file_md5() description. see [25541]. 
props siobhan.
see #27651.
Built from https://develop.svn.wordpress.org/trunk@27938


git-svn-id: http://core.svn.wordpress.org/trunk@27768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 00:03:14 +00:00
Drew Jaynes 8efd225e4d Inline documentation for hooks in wp-admin/includes/file.php. 
Fixes #27429.

Built from https://develop.svn.wordpress.org/trunk@27672


git-svn-id: http://core.svn.wordpress.org/trunk@27515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 02:45:15 +00:00
Dion Hulse 87c6791a41 WP_Filesystem: Update request_filesystem_credentials() to handle the correct ssh value of FS_METHOD. Props jnielsendotnet. Fixes #27265 
Built from https://develop.svn.wordpress.org/trunk@27546


git-svn-id: http://core.svn.wordpress.org/trunk@27389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-15 03:09:16 +00:00
Sergey Biryukov bc036d0843 Avoid an undefined index notice in wp_handle_upload(). 
props tivnet.
fixes #27225.
Built from https://develop.svn.wordpress.org/trunk@27319


git-svn-id: http://core.svn.wordpress.org/trunk@27171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-27 21:16:15 +00:00
Andrew Nacin 912379a022 Simplify error in validate_file_to_edit(). 
props MattyRob for initial patch.
fixes #25924.

Built from https://develop.svn.wordpress.org/trunk@27219


git-svn-id: http://core.svn.wordpress.org/trunk@27076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-21 14:46:14 +00:00
Andrew Ozz eb1d21d782 Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712. 
Built from https://develop.svn.wordpress.org/trunk@27029


git-svn-id: http://core.svn.wordpress.org/trunk@26905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-24 19:06:15 +00:00
Drew Jaynes cd8cedc40d First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin. 
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.

Built from https://develop.svn.wordpress.org/trunk@26868


git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-24 18:57:12 +00:00
Andrew Nacin d61e188f23 Only enforce disk free space checks when doing background updates. 
see #25652.

Built from https://develop.svn.wordpress.org/trunk@25869


git-svn-id: http://core.svn.wordpress.org/trunk@25869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:59:29 +00:00
Dion Hulse 8abd2f86d5 Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check). 
See #25576, #22704

Built from https://develop.svn.wordpress.org/trunk@25831


git-svn-id: http://core.svn.wordpress.org/trunk@25831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:54:05 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:53:14 +00:00
Andrew Nacin d5fdd66f9d Only enforce disk free space checks when doing background updates. 
see #25652.

Built from https://develop.svn.wordpress.org/trunk@25869


git-svn-id: http://core.svn.wordpress.org/trunk@25781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-22 18:18:09 +00:00
Dion Hulse 924e35d66a Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check). 
See #25576, #22704

Built from https://develop.svn.wordpress.org/trunk@25831


git-svn-id: http://core.svn.wordpress.org/trunk@25743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-17 18:40:10 +00:00
Dion Hulse 1c8e79353a Language Packs: Many many fixes such as: 
- Add a "Update Translations" stand-alone button to the updates page
- Shift Language feedback to before update process completion action links & limit the verbosity of output (name + success/errors)
- Simplify/combine the language update descriptive string to only include a plugin/theme name
- Properly handle cache clearing after language updates to prevent langs being repeditively updated
- Display a "All items up to date" string when there's nothing to do
- Reduce the 'Connection Information' from a <h2> to a <h3> to remove duplicate h2's and screen icons from update screens
- Fix the Direct filesystem method not being used for Language updates because WP_LANG_DIR doesn't exist (check it's parent for writable instead)
See #18200, #22704


Built from https://develop.svn.wordpress.org/trunk@25806


git-svn-id: http://core.svn.wordpress.org/trunk@25718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-16 04:15:09 +00:00
Andrew Nacin 95831a8a67 Remove accidental debug cruft in [25780]. see #22704. 
Built from https://develop.svn.wordpress.org/trunk@25799


git-svn-id: http://core.svn.wordpress.org/trunk@25711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-15 21:24:09 +00:00
Andrew Nacin eeaad19a26 Use FS_CHMOD_FILE rather than an explicit 0644 in copy_dir() and _copy_dir(). 
This occurs when we can't copy a file. We chmod it and try again.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25793


git-svn-id: http://core.svn.wordpress.org/trunk@25705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-15 19:14:10 +00:00
Andrew Nacin 9b56d4d11f Parse absolute paths out of error data. see #22704. 
Built from https://develop.svn.wordpress.org/trunk@25780


git-svn-id: http://core.svn.wordpress.org/trunk@25693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-14 22:25:08 +00:00
Dion Hulse 4dcca90887 Remove PHP4 compat code from the ZipArchive unzip handler, and pass the failure reason into the WP_Error return. 
See #22704

Built from https://develop.svn.wordpress.org/trunk@25779


git-svn-id: http://core.svn.wordpress.org/trunk@25692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-14 21:55:09 +00:00
Andrew Nacin 145dbde82f Account for possible failures by disk_free_space(), as well as the potential need to copy the unzipped files. 
see #25576.

Built from https://develop.svn.wordpress.org/trunk@25776


git-svn-id: http://core.svn.wordpress.org/trunk@25689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-14 20:58:09 +00:00
Andrew Nacin d68a80217f In unzip_file(), confirm we have enough available disk space before extracting. 
"enough" is calculated by adding up the uncompressed size of the files in the archive, then adding a 20% buffer.

props dd32.
fixes #25576.

Built from https://develop.svn.wordpress.org/trunk@25774


git-svn-id: http://core.svn.wordpress.org/trunk@25687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-14 20:15:09 +00:00
Andrew Nacin 29f5f5b5fd Refine error codes throughout the upgrader so we can better detect at what stage updates fail. 
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25763


git-svn-id: http://core.svn.wordpress.org/trunk@25676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-11 16:06:11 +00:00
Dion Hulse 543d84a379 Upgrader: Create Directories with a minimum of 0755 and files with a minimum of 0644 when upgrading, which matches pre-3.7 behaviour. Fixes #20069 
Built from https://develop.svn.wordpress.org/trunk@25739


git-svn-id: http://core.svn.wordpress.org/trunk@25652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-09 16:47:09 +00:00
Dion Hulse a82b463610 When using download_url(), if the resource supplies a Content-MD5 header, verify the downloaded file against it. Fixes #20074 
Built from https://develop.svn.wordpress.org/trunk@25541


git-svn-id: http://core.svn.wordpress.org/trunk@25461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-21 06:54:09 +00:00
Dion Hulse 6737d0a202 Upgrader: Perform a MD5 file verification check on the files during upgrade. This ensures that both a Partial upgrade build can be used, and that all the files were copied into place correctly. 
Props pento for initial patch. Fixes #18201

Built from https://develop.svn.wordpress.org/trunk@25540


git-svn-id: http://core.svn.wordpress.org/trunk@25460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-21 06:49:11 +00:00
Dion Hulse f98f5d0a36 WordPress Upgrades: When defining the default filesystem permissions for files/directories, base the value on the existing ABSPATH & index.php file permissions - so as to respect the executable bit (if set) and not set global read if not required. 
This sets a minimum permission set to 750 and 640 for directories and files, so any systems requring less permission than that will still need to define the constants themselves. Fixes #20069 

Built from https://develop.svn.wordpress.org/trunk@25469


git-svn-id: http://core.svn.wordpress.org/trunk@25390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-17 08:06:09 +00:00
Dion Hulse 83ebc727e8 Switch unzip_file() over to using the mbstring.func_override helper functions. See #25259 
Built from https://develop.svn.wordpress.org/trunk@25347


git-svn-id: http://core.svn.wordpress.org/trunk@25309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-11 08:09:08 +00:00
Sergey Biryukov 00c9232a19 Move get_real_file_to_edit() to wp-admin/includes/deprecated.php. props iamfriendly. fixes #23680. 
Built from https://develop.svn.wordpress.org/trunk@25201


git-svn-id: http://core.svn.wordpress.org/trunk@25173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-01 12:37:12 +00:00
Dion Hulse ff290a88bf Add a note that the FTP Password will not be stored on the server to the FTP credentials page. Fixes #16492 
Built from https://develop.svn.wordpress.org/trunk@25071


git-svn-id: http://core.svn.wordpress.org/trunk@25056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-21 07:07:09 +00:00
Dion Hulse ad980384f2 Check to see if mbstring.func_overload is configured to affect string functions before switching charsets. Props SergeyBiryukov. Fixes #25063 
Built from https://develop.svn.wordpress.org/trunk@25056


git-svn-id: http://core.svn.wordpress.org/trunk@25042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-20 06:24:09 +00:00
Andrew Nacin 21a1fe8d4b Use wp_safe_remote_request() and friends instead of reject_unsafe_urls = true. 
fixes #24646.



git-svn-id: http://core.svn.wordpress.org/trunk@24917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-31 06:52:13 +00:00
Andrew Nacin 96ee267343 Better validation of the URL used in core HTTP requests. 
git-svn-id: http://core.svn.wordpress.org/trunk@24480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-21 06:07:47 +00:00
Andrew Nacin be01fce99f Show a relative path in an upload error message. 
git-svn-id: http://core.svn.wordpress.org/trunk@24463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-21 02:29:26 +00:00
Ryan Boren 469d1a3099 Escape form action urls with esc_url() rather than esc_attr(). 
Props SergeyBiryukov
fixes #23266


git-svn-id: http://core.svn.wordpress.org/trunk@23739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-18 14:01:25 +00:00
Sergey Biryukov 28248c1b08 Make get_home_path() return consistent slashes. fixes #23175. 
git-svn-id: http://core.svn.wordpress.org/trunk@23669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-12 11:04:14 +00:00
Ryan Boren 5f809d1d22 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes(). 
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 17:00:25 +00:00
Ryan Boren 43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:28:40 +00:00
Ryan Boren cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00
Helen Hou-Sandí b1f1579604 its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665. 
git-svn-id: http://core.svn.wordpress.org/trunk@23191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-20 15:55:32 +00:00
Dion Hulse bcbfb232f7 Correct get_home_path() for cases where WordPress is installed in a subdirectory called /wp/, previously it would match on /wp-admin instead of /wp causing an incorrect return path. Props SergeyBiryukov. Fixes #20449 
git-svn-id: http://core.svn.wordpress.org/trunk@22800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-21 22:39:59 +00:00
Andrew Nacin 4cbc20ada1 Pass the post date to wp_upload_dir() during sideloads, just as we do uploads. Ensures that sideloaded images make it into the right uploads directory. 
props solarisssmoke, fixes #16777.



git-svn-id: http://core.svn.wordpress.org/trunk@22105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-03 18:49:37 +00:00
ryan 2417e42fe5 Improved phpdoc for file.php. Props tommcfarlin. fixes #21328 
git-svn-id: http://core.svn.wordpress.org/trunk@21350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-26 15:08:30 +00:00
dd32 509b845abc Make get_home_path() work in more cases by being case insensitive and sanitzing Windows paths. In some cases (such as differing case of hostnames or paths in the site/home options, or when SCRIPT_FILENAME contains forward slashes) the function was failing to return the correct path, and would instead return /. Props to SergeyBiryukov for the initial patch. Fixes #20449 Fixes #10447 
git-svn-id: http://core.svn.wordpress.org/trunk@21224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-06 13:54:15 +00:00
nacin 23abe58a59 Rewrite theme-editor.php to use the new WP_Theme API. see #20103. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-29 03:00:38 +00:00
dd32 86577f34ea Fix a small typo. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-02 11:00:51 +00:00
duck_ bb94e702f8 Drop image resizing code from wp_handle_upload(). Fixes #19800. 
This code stops wp_handle_upload() from reporting errors when the upload couldn't be moved to its final local and it was a non-JS fallback that is unused.


git-svn-id: http://svn.automattic.com/wordpress/trunk@20019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-28 20:02:43 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-08 17:01:11 +00:00
dd32 e15f5275a8 Fix edge case in get_home_path() where the incorrect path may be returned. Props ptahdunbar. Fixes #18768 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-06 13:46:22 +00:00
ryan 340e93324c Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-14 17:36:38 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-13 23:45:31 +00:00
azaozz 331b242bcd Revert [19223] and only stop showing the checkbox, props nacin, see #19174 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-08 22:34:09 +00:00
azaozz 623220187a Remove the Resize files checkbox for now (revisit in 3.4), fixes #19174 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-08 22:23:40 +00:00
ryan 62afab8db3 Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-24 19:13:23 +00:00
markjaquith 37e23be4ed Be more consistent with ERROR: messages. fixes #15887 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-30 17:18:35 +00:00
duck_ c1d1590171 Fix typos in documentation (wp-admin/). See #18560. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-03 14:18:10 +00:00
azaozz 9a65f6e237 Fix handling of resizing images after upload, props ocean90, see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-06 21:04:15 +00:00
azaozz 91a8720fff Pluploader take 1, props jacobwg, see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-29 08:59:35 +00:00
ryan a117773fc8 Typo fix. Props kawauso. fixes #18177 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-21 17:46:01 +00:00
markjaquith 029a8d1bef Remove code formatting from uploaded file size error messages, for now. props JohnONolan. fixes #17674 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-08 16:27:57 +00:00
nacin da2732c7de Use wp_remote_retrieve_* helper functions instead of the raw HTTP response array. props aaroncampbell, fixes #17416. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-14 19:45:07 +00:00
westi 80f4e83a8c Introduce WP_MAX_MEMORY_LIMIT constant for the high memory limit we set when image processing and unzipping. 
Ensure it is always filterable by plugins as well as configurable in wp-config
Fixes #13847 props hakre


git-svn-id: http://svn.automattic.com/wordpress/trunk@17749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-28 16:25:36 +00:00
dd32 bed23730dc Handle zip error's in PclZip better. PclZip::extract() returns an array on success, 0 on failure. Fixes #17224 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-23 14:30:44 +00:00
dd32 9081c7636c Set the mb_string internal encoding to ISO-8859-1 whilst uncompressing archives using PclZip. Fixes 'PCLZIP_ERR_BAD_FORMAT (-10) : Invalid block size' errors on systems utilising mbstring.func_overload. Fixes #15789 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-03 12:32:06 +00:00
dd32 5b12ecb83d Be a party-pooper; No more Akismet Dancing upon upgrade; Respect custom WP_CONTENT_DIR for bundled plugins/theme installation; Respect custom WP_CONTENT_DIR/WP_LANG_DIR for Language files when upgrading; Standardise WP_Filesystem path method returns (They're trailing slash'd). Adds an exclusion list to copy_dir() as well as WP_Filesystem_Base::wp_lang_dir(). See #14484 See #11495 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-03-31 13:28:36 +00:00
dd32 00dc7a57d6 First run of introducing Stream-To-File for the WP_HTTP API. Reduces memory consumption during file downloads. Implemented in download_url() for upgraders. Props sivel. See #16236 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-03-25 02:42:20 +00:00
dd32 a83a2842ea Optimisations to WP_Filesystem; Pass known information to called functions. Props aldenta (John Ford) for investigation and patch. See #10913 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-03-22 00:04:15 +00:00
nacin 53d0af84b0 Don't esc_html the default error string. props SergeyBiryukov, fixes #16058. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-01 22:14:42 +00:00
nacin e5b099a459 Add missing translation for 'Page Template' in the theme editor. props SergeyBiryukov, fixes #15933. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-21 14:58:54 +00:00
westi 1bb4914c3a Allow for the callee of download_url() to specify a different timeout if they want to - maybe they don't want to wait that long. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-07 12:45:24 +00:00
nacin 5021403b9d Add 'Visual Editor RTL Stylesheet' to the list of theme file descriptions. see #15672. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-04 04:22:48 +00:00
markjaquith ad6e83136d Improve the wording of the file upload security message. props janeforshort. fixes #13550 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-24 20:45:21 +00:00
ryan 847499e531 Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-17 18:47:34 +00:00
nacin d81d7b7f4a Some escaping 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-14 17:33:16 +00:00
markjaquith fc6e89da45 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-28 21:56:43 +00:00
nacin 82b1349664 Docs for wp-admin/includes/file.php. props sivel, see #14783. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-27 22:24:06 +00:00
nacin 1dee100f3a Fix typo. props mrmist, fixes #14571. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-09-07 15:11:43 +00:00
dd32 fe5e3d0fb6 Do not check to see if parents of folders outside of the Destination folder exist within the Archive extractors, unzip_file() will take care of that area. Fixes #13741 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-07 11:19:51 +00:00
nacin 3ba9fc235c More request_filesystem_credentials() string improvements. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-03 18:58:41 +00:00
nacin 80437ca9e1 Add missing spaces. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-01 21:57:26 +00:00
nacin 09c448f63e Clarify the connection information requested in request_filesystem_credentials() to reduce confusion surrounding FTP information versus your WordPress login. see #13467, props jane. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-01 20:35:59 +00:00
dd32 92eeafce24 Always fallback to PclZip in the event that ZipArchive does not return true. The PHP Zip extension is hit-and-miss with OSX generated zip files, sometimes 0 will be emitted and extraction will succeed, others it will fail with. Reverts r14346, r14377, partially r14800. See #12637. See #13491 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-29 13:16:35 +00:00
ryan 1a552dd029 Strip trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 02:42:15 +00:00
dd32 989a52d7ff Ensure that the entire folder structure exists within the $needed_folders array before attempting to create folders. Fixes cases where the Zip file does not contain a node for a folder which contains subfolders without files in the same level. Fixes #13171 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-23 05:56:31 +00:00
dd32 f8111531f4 Correct the ZipArchive opening test logic. See #13491 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-22 05:09:08 +00:00
nacin 7c8a77efa3 Introduce wp_check_filetype_and_ext() to handle mime/ext image comparisons and corrections for upload and sideload. props Viper007Bond, see #11946. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-15 04:47:03 +00:00
dd32 72f99c8a96 Silence PHP Warnings on is_writable calls. Can trigger open_basedir warnings on certain hosting environments. Props ocean90. Fixes #12866 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-03 23:39:57 +00:00
nacin 248f4ab860 Provide a context to wp_handle_upload to differentiate between upload and sideload. props technosailor, fixes #12740. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-03 22:16:48 +00:00
ryan 7b7243d94a Strip trailing whites. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-03 20:26:11 +00:00
nacin efa2e9d397 Ensure image MIME type matches extension for images. props Viper007Bond, fixes #11946. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-03 20:17:01 +00:00
dd32 79bb63a4e0 Fix ZIP_ER_OK constant, Its a class constant, and only accessible as such under PHP5. Props sivel for noticing. Fixes #12637 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-03 18:44:34 +00:00
dd32 2db60de875 Skip over __MACOSX folders during zip extraction. Props chrisbliss18. Fixes #12637 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-02 23:24:36 +00:00
dd32 3213eab0f8 Check for "ZIP_ER_OK" return value on ZipArchive. See #12637 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-02 22:25:30 +00:00
dd32 d5ee7bca10 Replace use of tmpfile() with a safe get_temp_dir(). tmpfile() may use a temporary directly which is not writable. Add static caching to get_temp_dir() & better protect against bad server configs. Fixes #12866 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-06 11:20:51 +00:00
nacin f925c3c2b4 Adjust get_file_description() to account for absolute paths. see #12843 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-04 12:07:27 +00:00
nacin 37faed2c03 Give names to author.php and tag.php in the theme editor. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-04 11:23:09 +00:00
nacin 6182fa89af Give editor-style.css a name in the theme editor. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-04 11:14:29 +00:00
nacin a7feaed0e6 Change @since 3.0 to @since 3.0.0. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-26 19:13:36 +00:00
nacin 6e0976117a Fix potential notice in wp_handle_sideload(). 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-26 17:42:34 +00:00
ryan e25a65b36a Trim trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-17 16:27:25 +00:00
nacin f6415fc7eb Fix logic and pull static code out of a loop. fixes #12581 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-11 17:21:18 +00:00
nacin 20eae9d24a Use disabled() form helper. fixes #12581 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-11 17:12:23 +00:00