e5302dff26
Multisite/Sites: supplemental commit to r46251.
...
This commit adds the links to the list-table class itself (that were missed in r46251.)
See #37392 . Props pbiron, thomaswm.
Built from https://develop.svn.wordpress.org/trunk@46254
git-svn-id: http://core.svn.wordpress.org/trunk@46066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:51:58 +00:00
22ae908ede
Editor: Add Nonce Endpoint
...
This is a follow up to #47843 , implementing a PHP endpoint and inline scripts
after the editor package updates. The action was originally added in
https://github.com/WordPress/gutenberg/pull/16683 .
Fixes #48076 .
Built from https://develop.svn.wordpress.org/trunk@46253
git-svn-id: http://core.svn.wordpress.org/trunk@46065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:47:56 +00:00
b65ea119bb
Multisite/Sites: Add links to filter websites by status.
...
This commit brings the Network-Admin Sites list page up-to-speed with other similar list-table powered pages, by adding links to filter the results by Site Status.
Includes a single unit test for the newly introduced `wp_count_sites()` multisite function, named to match the `wp_count_` function pattern from other list tables.
Fixes #37392 . Props mnelson4, spacedmonkey, pbiron.
Built from https://develop.svn.wordpress.org/trunk@46251
git-svn-id: http://core.svn.wordpress.org/trunk@46063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:35:59 +00:00
956725990f
Accessibility: Make sortable meta boxes non sortable when there are no locations they can be dragged to.
...
Depending on the amount of meta boxes and the layout settings under Screen Options, sortable meta boxes may not be actually sortable.
In these cases, jQuery UI sortable needs to be disabled and the user interface shouldn't use a CSS `cursor: move`.
The use of consistent and relevant cursors may be important for users who have a cognitive disability, since cursors give a visual clue as to an element's functionality. Using the move cursor for elements which cannot be moved may be confusing or counter-intuitive for users.
Props adamsilverstein, antpb, anevins.
Fixes #47131 .
Built from https://develop.svn.wordpress.org/trunk@46250
git-svn-id: http://core.svn.wordpress.org/trunk@46062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:30:58 +00:00
6cb8e14790
Accessibility: Improve and modernize user interface controls. Sixth part: allow checkboxes and radio buttons to scale with text.
...
- uses a SVG icon for checkboxes
- uses CSS `rem` relative units
Props kjellr, afercia, audrasjb.
Fixes #47498 .
Built from https://develop.svn.wordpress.org/trunk@46248
git-svn-id: http://core.svn.wordpress.org/trunk@46060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 16:51:57 +00:00
165ac34260
Accessibility: Improve and modernize user interface controls for better contrast. Fifth part: Common form controls.
...
Props anevins, melchoyce, audrasjb, kjellr.
Fixes #47153 .
Built from https://develop.svn.wordpress.org/trunk@46247
git-svn-id: http://core.svn.wordpress.org/trunk@46059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 16:21:58 +00:00
46892ffb12
Media: Sets `post_id` optional in `media_sideload_image()` and `media_handle_sideload()`.
...
Props SergeyBiryukov, donmhico, mikeschroder, sebastian.pisula.
Fixes #43579 .
Built from https://develop.svn.wordpress.org/trunk@46245
git-svn-id: http://core.svn.wordpress.org/trunk@46057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 16:03:56 +00:00
38be855367
Accessibility: Improve and modernize user interface controls. Third part: allow buttons and form controls to scale with text.
...
Props kjellr, abrightclearweb, audrasjb.
Fixes #47477 .
Built from https://develop.svn.wordpress.org/trunk@46243
git-svn-id: http://core.svn.wordpress.org/trunk@46055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 15:27:57 +00:00
271f45072d
Accessibility: Improve and modernize user interface controls for better contrast. Second part: tables, meta boxes, and other user interface elements.
...
Introduces better contrast for borders of the following user interface elements:
- Tables
- Screen Options and Help
- Admin notices
- Welcome panel
- Meta boxes (post boxes)
- Cards
- Health Check accordions and headings
- Theme and Plugin upload forms
Props kjellr, melchoyce, karmatosed, audrasjb.
Fixes #48101 .
Built from https://develop.svn.wordpress.org/trunk@46242
git-svn-id: http://core.svn.wordpress.org/trunk@46054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 15:10:59 +00:00
618883f6f4
Accessibility: Improve and modernize user interface controls for better contrast. First part: buttons and links.
...
- Introduces new styles for the buttons, with better contrast for borders and better focus style.
- Introduces a new focus style for links.
- The new styles improve consistency with the ones used in the new Block Editor (Gutenberg).
Props michaelarestad, truchot, mor10, kellychoffman, adamsoucie, paaljoachim, Joen, kjellr, melchoyce, karmatosed, audrasjb, afercia.
Fixes #34904 .
Built from https://develop.svn.wordpress.org/trunk@46241
git-svn-id: http://core.svn.wordpress.org/trunk@46053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 14:43:58 +00:00
e43633b7d0
Accessibility: Menus: Improve the menu items "Select All".
...
- changes "Select All" from a link to a checkbox
- the new checkbox is available only when JavaScript support is on
- semantically and for accessibility, a checkbox is a better user interface control because the available action is clear to all users and the selected state is communicated natively
- it's consistent with the existing pattern for the admin tables
Props birgire, audrasjb, afercia.
Fixes #47048 .
Built from https://develop.svn.wordpress.org/trunk@46240
git-svn-id: http://core.svn.wordpress.org/trunk@46052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 12:42:58 +00:00
e36d1bcbd8
Docs: Docblock corrections and improvements, mostly related to various `pre_*` filters.
...
See #47110
Built from https://develop.svn.wordpress.org/trunk@46232
git-svn-id: http://core.svn.wordpress.org/trunk@46044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-21 17:41:57 +00:00
123b4475b0
Site Health: Don't verify SSL certificate when testing the local site.
...
The SSL certificate may be self-signed which prevents various tests from returning proper results. Since the Cron API and file editors don't verify the certificate the tests shouldn't either.
Props Clorith, ocean90.
Fixes #47957 .
Built from https://develop.svn.wordpress.org/trunk@46231
git-svn-id: http://core.svn.wordpress.org/trunk@46043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-21 16:06:57 +00:00
4d9c482e79
File Editor: Don't verify SSL certificate when doing loopback requests for checking for fatal errors.
...
Props Clorith.
See #47957 .
Built from https://develop.svn.wordpress.org/trunk@46230
git-svn-id: http://core.svn.wordpress.org/trunk@46042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-21 15:59:56 +00:00
01b6bd9f38
Site Health: Replace `wp_get_upload_dir()` with `wp_upload_dir()`.
...
`wp_get_upload_dir()` returns the theoretical path of the uploads directory. When there was no upload yet the test returns an incorrect result (not writeable) because the directory doesn't exist. Switching to `wp_upload_dir()`, which creates the directory on the fly, ensures a proper test result.
Fixes #47958 .
Built from https://develop.svn.wordpress.org/trunk@46228
git-svn-id: http://core.svn.wordpress.org/trunk@46040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-21 15:49:57 +00:00
a879bcb1c6
Code Modernization: Remove a workaround for `IMAGETYPE_ICO` in `file_is_displayable_image()`.
...
The `IMAGETYPE_ICO` constant was introduced in PHP 5.3, so no longer needs a workaround.
Props jrf.
See #48074 .
Built from https://develop.svn.wordpress.org/trunk@46217
git-svn-id: http://core.svn.wordpress.org/trunk@46029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 22:18:59 +00:00
594f77dbae
Docs: Add missing `$which` parameter descriptions.
...
Follow up of [46211].
See #45954 .
Built from https://develop.svn.wordpress.org/trunk@46212
git-svn-id: http://core.svn.wordpress.org/trunk@46024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 20:57:57 +00:00
ba2700068d
Networks and Sites: Add support for the `extra_tablenav()` method in `WP_MS_Sites_List_Table`.
...
This method allows additional filters or other UI components to be added to the top and bottom of the `WP_List_Table` between the bulk actions dropdown and search input field.
Fixes #45954 .
Props pbiron, desrosj.
Built from https://develop.svn.wordpress.org/trunk@46211
git-svn-id: http://core.svn.wordpress.org/trunk@46023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 20:53:58 +00:00
a9aefc83bc
Code Modernization: Remove conditional use of PHP `realpath()`.
...
The `realpath()` function was introduced in PHP 4.0.0. There's no point in checking if the function exists in PHP 5.6+, in only 2 instances out of 29.
Props jrf.
Fixes #48075 .
Built from https://develop.svn.wordpress.org/trunk@46210
git-svn-id: http://core.svn.wordpress.org/trunk@46022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 20:46:56 +00:00
d2ebf7d0e4
Privacy: Display group items count in the personal data export file if there's more than one item in the group.
...
Props birgire, garrett-eclipse, pputzer.
Fixes #46895 .
Built from https://develop.svn.wordpress.org/trunk@46209
git-svn-id: http://core.svn.wordpress.org/trunk@46021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 20:30:58 +00:00
a2f45dc9eb
Media: make search input full width on mobile. Take two.
...
Props m1tk00.
Fixes #40130 .
Built from https://develop.svn.wordpress.org/trunk@46207
git-svn-id: http://core.svn.wordpress.org/trunk@46019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 20:09:54 +00:00
3cf6276ed0
Code Modernization: Remove JSON extension workarounds for PHP < 5.6.
...
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), JSON extension related polyfills and backwards compatibility code can now be removed.
This change removes code that supported JSON related functionality on older versions of PHP. This includes (but is not limited to) checks that `json_last_error()` exists, checking and setting the `JSON_UNESCAPED_SLASHES` and `JSON_PRETTY_PRINT` constants if not previously defined, and deprecating the `_wp_json_prepare_data()` function (which was 100% workaround code).
Follow up of [46205].
See #47699 .
Props jrf, Clorith, pento.
Built from https://develop.svn.wordpress.org/trunk@46206
git-svn-id: http://core.svn.wordpress.org/trunk@46018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 20:08:57 +00:00
0628245170
Admin email verification:
...
- Fix wording of the HTML title.
- Add hidden `(opens in a new tab)` to links that need it.
- Add the `screen-reader-text` CSS class to login.css.
- Add another translator comment.
Props afercia.
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@46203
git-svn-id: http://core.svn.wordpress.org/trunk@46015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 18:51:56 +00:00
29ea4c6a4c
Media/Upload: rotate images on upload according to EXIF Orientation.
...
Props msaggiorato, wpdavis, markoheijnen, dhuyvetter, msaggiorato, n7studios, triplejumper12, pbiron, mikeschroder, joemcgill, azaozz.
Fixes #14459 .
Built from https://develop.svn.wordpress.org/trunk@46202
git-svn-id: http://core.svn.wordpress.org/trunk@46014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 18:21:57 +00:00
38254bdc6f
Site Health: Use sentence casing consistently in header tags.
...
Props SergeyBiryukov, ajayghaghretiya1, ronakganatra, mukesh27, Clorith.
Fixes #47298 .
Built from https://develop.svn.wordpress.org/trunk@46199
git-svn-id: http://core.svn.wordpress.org/trunk@46011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 17:26:57 +00:00
d968a74e2a
Docs: Add `@since` tag for the new `$position` argument added to `add_submenu_page()` and related functions in [46197].
...
See #39776 .
Built from https://develop.svn.wordpress.org/trunk@46198
git-svn-id: http://core.svn.wordpress.org/trunk@46010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 17:06:57 +00:00
6ca808129c
Menus: add a position argument to `add_submenu_page` and the helper functions that use it.
...
Add a position argument to the `add_submenu_page` function similar to the one already in `add_menu_page`. When adding sub menus enables setting the position in the sub menu where the item should appear.
In addition, add the position argument to functions that call `add_submenu_page` under the hood: `add_management_page`, `add_options_page`, `add_theme_page`, `add_plugins_page`, `add_users_page`, `add_dashboard_page`, `add_posts_page`, `add_media_page`, `add_links_page`, `add_pages_page` and `add_comments_page`.
Props welcher, birgire, alexvorn2.
Fixes #39776 .
Built from https://develop.svn.wordpress.org/trunk@46197
git-svn-id: http://core.svn.wordpress.org/trunk@46009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 15:00:59 +00:00
a014bd21c1
Multisite: Remove the redundant `blog_versions` table.
...
As part of the Multisite installation process, a `blog_versions` table is created. This table is never read from (except immediately prior to updating it), it's only ever inserted into or updated. It is not used to determine which blogs need to be upgraded.
This table was introduced in 3.0 when the WPMU schema was merged #11644 and it appears the table has never been used in core and is therefore redundant and may as well be removed.
Props johnbillion, nacin, ryan, johnjamesjacoby, whyisjake.
Fixes #19755 . See #41685 .
Built from https://develop.svn.wordpress.org/trunk@46194
git-svn-id: http://core.svn.wordpress.org/trunk@46006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-19 22:07:57 +00:00
250eb42802
Networks and Sites: Save database version in site meta (Multisite)
...
Currently there is there a table in multisite called blog_versions. All this table stores is the database version as number and the date updated. With plans to add site meta in #37923 this new table should be used. This has a number of benefits, including functions to CRUD these values in the database. Once this data is in the blogmeta, table, the blog_versions table can be removed all together. If require a SQL view can be used blog_versions from data stored in blogmeta.
Props spacedmonkey, leogermani.
Fixes #41685 . See #19755 .
Built from https://develop.svn.wordpress.org/trunk@46193
git-svn-id: http://core.svn.wordpress.org/trunk@46005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-19 21:42:58 +00:00
3d06de26a3
PHP 7.4: Fix another instance of array access on a datatype that cannot be accessed as an array.
...
PHP 7.4 adds a warning when trying access a null/bool/int/float/resource (everything but array, string and object) as if it were an array.
Follow up of [45639].
Props desrosj, jrf.
See #47704 .
Built from https://develop.svn.wordpress.org/trunk@46185
git-svn-id: http://core.svn.wordpress.org/trunk@45997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-19 14:30:56 +00:00
463e050b25
Uploads: add helper functions for setting, getting, and deleting the temp upload reference used to the attachment_id when retrying to make image sub-sizes.
...
See #47872 .
Built from https://develop.svn.wordpress.org/trunk@46174
git-svn-id: http://core.svn.wordpress.org/trunk@45986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-19 01:26:55 +00:00
08a077658d
Accessibility: Replace wp-a11y.js with @wordpress/a11y package
...
We've extracted wp-includes/wp-a11y.js to a reusable package wordpress/a11y which is published on NPM. Let's make sure this package is also used in WordPress core. Once all the JavaScript is built using webpack, we can also import this package wherever it is used and configure webpack to load is an external.
Props omarreiss, herregroen, desrosj, ocean90, afercia, sstoqnov
Built from https://develop.svn.wordpress.org/trunk@46167
git-svn-id: http://core.svn.wordpress.org/trunk@45979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-18 17:41:55 +00:00
5a477b5715
Docs: Add missing descriptions for functions in `wp-admin/update-core.php`.
...
Also, fix the `@since` annotation added in [45480] to include the correct version.
Props SergeyBiryukov, ajayghaghretiya1.
Fixes #47424 .
Built from https://develop.svn.wordpress.org/trunk@46161
git-svn-id: http://core.svn.wordpress.org/trunk@45973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-17 20:43:56 +00:00
5329411f6d
General: Ensure the arguments passed to `implode()` are in the correct order.
...
The `implode()` function accepts two. parameters, `$glue` and `$pieces`. For historical reasons, these parameters have been accepted in any order, though it was recommended that the documented order of `$glue, $pieces` be used.
Starting in PHP 7.4, specifying the parameters in the reverse order will trigger a deprecation notice with the plan to remove this tolerance in PHP 8.0.
This change fixes the occurrences of reversed arguments in Core with the exception of those contained in included external libraries. These will be handled separately.
Props jrf, jorbin.
See #47746 .
Built from https://develop.svn.wordpress.org/trunk@46155
git-svn-id: http://core.svn.wordpress.org/trunk@45967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-17 13:40:57 +00:00
757d077669
Network Admin: Allow Sites to have filterable States in List Table rows.
...
This change introduces a new `site_states()` method to the Sites List Table class (with a new `display_site_states` filter inside of it) following the pattern popularized in other List Table classes before it (Posts, Media, etc...)
Fixes #37684 . Props mnelson4, pbiron, jeremyfelt, johnjamesjacoby.
Built from https://develop.svn.wordpress.org/trunk@46153
git-svn-id: http://core.svn.wordpress.org/trunk@45965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-16 23:34:55 +00:00
e6bbff13c5
Code Modernisation: Replace `call_user_func_array()` in various `__call()` methods with dynamic function calls.
...
The callback in these functions is always checked against a limited list of valid callbacks that can be safely changed to dynamic function calls.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46144
git-svn-id: http://core.svn.wordpress.org/trunk@45956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 11:53:56 +00:00
8ee3790851
Code Modernisation: Replace `call_user_func_array()` in `wp-admin/includes/widgets.php` and associated unit tests with a direct function call.
...
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46138
git-svn-id: http://core.svn.wordpress.org/trunk@45950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 11:41:55 +00:00
f166554882
Code Modernisation: Replace `call_user_func_array()` in `wp-admin/includes/template.php` with a dynamic function call.
...
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46137
git-svn-id: http://core.svn.wordpress.org/trunk@45949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 11:35:56 +00:00
7c370fa9d0
Code Modernisation: Replace `call_user_func_array()` in `wp-admin/includes/ajax-actions.php` with a dynamic function call.
...
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46136
git-svn-id: http://core.svn.wordpress.org/trunk@45948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 11:34:57 +00:00
30fe3f5d4f
Code Modernisation: Introduce the spread operator in `wp-admin/includes/media.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46131
git-svn-id: http://core.svn.wordpress.org/trunk@45943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 11:12:55 +00:00
7093392099
Code Modernisation: Introduce the spread operator in `wp-admin/includes/dashboard.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46130
git-svn-id: http://core.svn.wordpress.org/trunk@45942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 11:11:56 +00:00
340b7b53c8
Code Modernisation: Introduce the spread operator in `wp-admin/includes/class-*-upgrader-skin.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46125
git-svn-id: http://core.svn.wordpress.org/trunk@45937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 10:42:54 +00:00
099eb0578e
Block Editor: Add preloading of autosaves.
...
With the introduction of https://github.com/WordPress/gutenberg/pull/7945 , the block editor requests autosave data when the editor is loaded. This can be optimized by preloading the request server-side and then passing the request data to the client using the preloading mechanism in editor-form-blocks.php.
Props: talldanwp, aduth.
Built from https://develop.svn.wordpress.org/trunk@46110
git-svn-id: http://core.svn.wordpress.org/trunk@45922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-14 16:47:54 +00:00
42079f34a9
Site Health: Modify the grading indicator to remove percentage score in favor of a "Good" or "Should be improved" status.
...
This removes arbitrary confusion about what the numbers mean.
Props Clorith, hedgefield, Cybr, arena, DavidAnderson, earnjam, daveshine, Otto42, azaozz, asadkn, KARTHOST, tigertech, maximejobin, johnbillion, raboodesign, ramiy, afragen.
Fixes #47046 .
Built from https://develop.svn.wordpress.org/trunk@46106
git-svn-id: http://core.svn.wordpress.org/trunk@45918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-14 14:29:56 +00:00
dd3ad3ac51
GENERAL: Remove magic quote functions
...
The path to magic quote sanity took a fun and exciting turn: PHP core removed it and WordPress updated the minimum version.
For the formally external pclzip, the code is commented out to make investigating easier and in case we ever need to merge upstream (if that still exists) changes.
Props ayeshrajans, jrf, jorbin.
See #47783 .
Fixes #18322 .
Built from https://develop.svn.wordpress.org/trunk@46105
git-svn-id: http://core.svn.wordpress.org/trunk@45917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-13 22:21:01 +00:00
a3eba2c201
Login and Registration: reset password - ensure submit button disabled when field empty.
...
Fix an issue where the submit button was enabled with an empty password when the user previously checked "Confirm use of weak password" for a weak password, then cleared the password field.
Props henry.wright.
Fixes #47924 .
Built from https://develop.svn.wordpress.org/trunk@46103
git-svn-id: http://core.svn.wordpress.org/trunk@45915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-13 18:30:55 +00:00
3591f1ad60
Text Changes: Correct "up-to-date" vs. "up to date" usage in a database update string and inline comments.
...
* "Up to date" is an adverb phrase that describes an action that brings something in line with the latest information.
* "Up-to-date" is an adjective phrase that is used as a synonym for "current".
Props socalchristina, hareesh-pillai, garrett-eclipse, desrosj, aprea.
Fixes #38998 .
Built from https://develop.svn.wordpress.org/trunk@46096
git-svn-id: http://core.svn.wordpress.org/trunk@45908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-12 13:06:57 +00:00
abed60bb51
Editor: Add missing block data fields for blocks registered server side.
...
In [44122], the `styles` and `parent` block fields were omitted on accident. This change makes it possible to reuse them on the client.
Props gziolo.
Fixes #47017 .
Built from https://develop.svn.wordpress.org/trunk@46091
git-svn-id: http://core.svn.wordpress.org/trunk@45903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-11 14:52:56 +00:00
dcb08f0637
Docs: Fix placement of some duplicate hook references.
...
Hook documentation should be on the line directly above the line containing the `do_action()` or `apply_filters()` call. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of duplicate hook references.
Includes minor code layout fixes.
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@46088
git-svn-id: http://core.svn.wordpress.org/trunk@45900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-10 19:23:55 +00:00
49b4cfc034
Accessibility: Media: Replace `@` with `at` in the displayed date format.
...
The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.
Props audrasjb, afercia.
Fixes #47893 .
Built from https://develop.svn.wordpress.org/trunk@46085
git-svn-id: http://core.svn.wordpress.org/trunk@45897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-09 00:07:57 +00:00
86a10090a0
Accessibility: Comments: Replace `@` with `at` in the displayed date format.
...
The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.
Props birgire, afercia, audrasjb, SergeyBiryukov.
Fixes #47893 .
Built from https://develop.svn.wordpress.org/trunk@46084
git-svn-id: http://core.svn.wordpress.org/trunk@45896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-08 23:53:55 +00:00
f8ba775d7c
Accessibility: Posts, Post Types: Replace `@` with `at` in the displayed date format.
...
The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.
Props birgire, afercia, audrasjb, SergeyBiryukov.
Fixes #47832 .
Built from https://develop.svn.wordpress.org/trunk@46083
git-svn-id: http://core.svn.wordpress.org/trunk@45895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-08 23:24:56 +00:00
dc8349ba0a
Media: Add handling for "BIG" images. When the users upload a big image, typically a photo, scale it down to make it suitable for web use. Then use the scaled image as the "full" size, and keep the originally uploaded image for creating high quality sub-sizes in the future and in case the users want to download it later.
...
Introduces `wp_get_original_image_path()` that retrieves the path to the originally uploaded image in all cases, and `big_image_size_threshold` filter to set the pixel value above which images will be scaled. The same value is used as max-width and max-height when scaling.
See #47873 .
Built from https://develop.svn.wordpress.org/trunk@46076
git-svn-id: http://core.svn.wordpress.org/trunk@45888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-07 01:07:55 +00:00
699c6001fd
Upgrade/Install: Escape the `%` in `width="100%"` in a `printf()` call in `Plugin_Upgrader_Skin::after()`.
...
Props afragen.
Fixes #47989 .
Built from https://develop.svn.wordpress.org/trunk@46072
git-svn-id: http://core.svn.wordpress.org/trunk@45884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-06 06:26:56 +00:00
c1e3b68b19
Docs: Improve documentation for `do_meta_boxes` action.
...
Props felipeelia, killua99, SergeyBiryukov.
Fixes #46542 .
Built from https://develop.svn.wordpress.org/trunk@46071
git-svn-id: http://core.svn.wordpress.org/trunk@45883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-06 00:06:56 +00:00
17652fb3d4
Widgets: Fix "jumpiness" when reordering widgets by dragging them.
...
Props ketanumretiya030, mukesh27, andraganescu, audrasjb.
Fixes #46941 .
Built from https://develop.svn.wordpress.org/trunk@46028
git-svn-id: http://core.svn.wordpress.org/trunk@45838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 21:49:48 +00:00
90d9bdc54c
Update wp.a11y.speak() to sanitize HTML before display.
...
Props iandunn, adamsilverstein, sstoqnov, peterwilsoncc
Built from https://develop.svn.wordpress.org/trunk@45979
git-svn-id: http://core.svn.wordpress.org/trunk@45790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 17:13:21 +00:00
761cd81a01
Escape the output in `wp_ajax_upload_attachment()`.
...
Props whyisjake, sstoqnov.
Built from https://develop.svn.wordpress.org/trunk@45936
git-svn-id: http://core.svn.wordpress.org/trunk@45747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 16:09:56 +00:00
e313498193
Uploads: After an image is uploaded and PHP times out or runs out of memory during post-processing (the server response is HTTP 500 error), try to resize it three more times. Then, if all attempts fail, do a cleanup of any sub-sizes that may have been created and show an error message asking the user to scale the image and upload it again.
...
See #47872 .
Built from https://develop.svn.wordpress.org/trunk@45934
git-svn-id: http://core.svn.wordpress.org/trunk@45745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 01:11:54 +00:00
97cbf72bf9
I18N: Fix typo in a function name in [45932].
...
See #44360 .
Built from https://develop.svn.wordpress.org/trunk@45933
git-svn-id: http://core.svn.wordpress.org/trunk@45744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:57:54 +00:00
e199663322
I18N: Capitalize translator comments consistently, add trailing punctuation.
...
Includes minor code layout fixes.
See #44360 .
Built from https://develop.svn.wordpress.org/trunk@45932
git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
fbc9dba70b
Accessibility: Audit usage of abbreviations.
...
Title attributes on abbreviations are only available to a minority of users. The
best option is to avoid unnecessary abbreviations when possible. In the other cases,
use an `<abbr>` element (which provides a hint to user agents on how to announce
and display the abbreviation) and provide an expansion in plain text on first use.
- `readme.html`: improves abbreviations and removes unnecessary `title` attributes
- options-general: removes unnecessary abbreviations and improves the remaining ones
- customizer schedule changeset date: removes unnecessary abbreviations and improves the remaining ones
- posts table date: uses a `span` element instead of an `abbr` element because this is not an abbreviation
Fixes #46980 .
Built from https://develop.svn.wordpress.org/trunk@45930
git-svn-id: http://core.svn.wordpress.org/trunk@45741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-02 21:44:58 +00:00
8662d9a74d
I18N: Split translatable strings located on the same line preceded with a translator comment, where the first string needs that comment, but the second does not.
...
Props johnbillion.
See #44360 .
Built from https://develop.svn.wordpress.org/trunk@45927
git-svn-id: http://core.svn.wordpress.org/trunk@45738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-02 00:43:55 +00:00
16b8d91baa
I18N: Improve translator comments.
...
* Add missing translator comments.
* Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various `.pot` file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments.
Includes minor code layout fixes.
Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders!
Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov.
Fixes #44360 .
Built from https://develop.svn.wordpress.org/trunk@45926
git-svn-id: http://core.svn.wordpress.org/trunk@45737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-01 17:13:59 +00:00
ffcb1d0d99
Comments: In AJAX response when deleting a comment, account for ` ` as a thousands separator in `total_items_i18n` and `total_pages_i18n` numbers.
...
Props denisco, SergeyBiryukov.
Fixes #47953 .
Built from https://develop.svn.wordpress.org/trunk@45918
git-svn-id: http://core.svn.wordpress.org/trunk@45729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-30 18:34:06 +00:00
d26191eb03
Docs: Simplify `get_plugin_data()` and `get_file_data()` description.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45917
git-svn-id: http://core.svn.wordpress.org/trunk@45728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-30 16:57:56 +00:00
3f048f5ace
Docs: Update plugin headers example in `get_plugin_data()` to clarify that `Version` is not a required field.
...
Props casiepa.
See #47110 , #meta4707.
Built from https://develop.svn.wordpress.org/trunk@45916
git-svn-id: http://core.svn.wordpress.org/trunk@45727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-30 16:16:57 +00:00
640c90d35d
Docs: Correct and improve inline docs relating to caching, terms, meta, and some misc tweaks.
...
See #47110
Built from https://develop.svn.wordpress.org/trunk@45915
git-svn-id: http://core.svn.wordpress.org/trunk@45726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-30 11:36:08 +00:00
3965d4735c
I18N: Add missing translator comment in help text on Reading Settings screen.
...
Props garrett-eclipse.
See #46708 .
Built from https://develop.svn.wordpress.org/trunk@45913
git-svn-id: http://core.svn.wordpress.org/trunk@45724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-29 21:36:55 +00:00
7caac01470
Administration: Add a note to "For each post in a feed, include [Full text / Summary]" option that how content is displayed in browsers depends on the theme.
...
Add a documentation link to learn more about feeds.
Props JarretC, SergeyBiryukov, pento, talldanwp, dinhtungdu, noisysocks, tobifjellner.
Fixes #46708 .
Built from https://develop.svn.wordpress.org/trunk@45912
git-svn-id: http://core.svn.wordpress.org/trunk@45723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-29 21:25:55 +00:00
90c424f73b
Multisite: Improve performance by caching not found lookups for sites and networks.
...
With this change, the result of a site or network lookup by ID will be cached even if the ID does not exist. When a new site or network is created, the cache for the respective new ID is cleared.
Props mnelson4, nielsdeblaauw.
Fixes #42251 .
Built from https://develop.svn.wordpress.org/trunk@45910
git-svn-id: http://core.svn.wordpress.org/trunk@45721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-29 12:42:56 +00:00
ccdc221b32
Administration: Output valid HTML when `wp_die()` is called.
...
To better support HTML and string calls to `wp_die()` without
outputting invalid HTML, wraps error messages in `<div>` rather than `<p>`.
Adds `.wp-die-message` CSS class for styling.
Props dinhtungdu, jeremyfelt, audrasjb, SergeyBiryukov, afercia, audrasjb, noisysocks.
Fixes #47580 .
Built from https://develop.svn.wordpress.org/trunk@45909
git-svn-id: http://core.svn.wordpress.org/trunk@45720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-29 07:54:01 +00:00
27a384caa4
Site Health: Merge two similar strings explaining what drop-in plugins are.
...
Props garrett-eclipse, ramiy, Clorith.
Fixes #47247 .
Built from https://develop.svn.wordpress.org/trunk@45905
git-svn-id: http://core.svn.wordpress.org/trunk@45716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-28 03:13:55 +00:00
6cad27efcd
Site Health: Standardize on `SELECT VERSION()` query for checking the database server version, due to the MariaDB version declaration potentially causing issues in production environments.
...
Partially reverts [45691].
Props Clorith.
Fixes #47738 .
Built from https://develop.svn.wordpress.org/trunk@45904
git-svn-id: http://core.svn.wordpress.org/trunk@45715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-28 03:09:52 +00:00
b1847ef3e2
Menus: In `wp_setup_nav_menu_item()` and `Walker_Nav_Menu_Edit::start_el()`, check if the post or term associated with the menu item still exists to avoid a PHP notice.
...
If the associated post or term no longer exists, mark the menu item as invalid.
Props mehulkaklotar, kamrankhorsandi, cristiano.zanca, SergeyBiryukov.
Fixes #31703 .
Built from https://develop.svn.wordpress.org/trunk@45891
git-svn-id: http://core.svn.wordpress.org/trunk@45702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-25 21:32:59 +00:00
fe0b22cd67
Users: Adjust [45806] to make sure `$all_userids` is always defined.
...
Props kbrownkd.
Fixes #47936 .
Built from https://develop.svn.wordpress.org/trunk@45890
git-svn-id: http://core.svn.wordpress.org/trunk@45701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-25 20:03:57 +00:00
c896a0911e
Site Health: Add timezone to Site Health Info page.
...
Props justinahinon, sharaz, artisticasad, Rarst.
Fixes #47842 .
Built from https://develop.svn.wordpress.org/trunk@45889
git-svn-id: http://core.svn.wordpress.org/trunk@45700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-24 19:37:57 +00:00
1aaf11947e
Date/Time: Simplify the date comparing logic in `WP_Community_Events::trim_events()`.
...
The Events API returns event date without timezone information, so trying to parse it into a timestamp and compare to a WP timestamp is pointless.
Props Rarst.
Fixes #47463 .
Built from https://develop.svn.wordpress.org/trunk@45886
git-svn-id: http://core.svn.wordpress.org/trunk@45697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-23 02:15:55 +00:00
6e555f0c77
Date/Time: Introduce `current_datetime()` for better time operations.
...
Returning a `DateTimeImmutable` representation of the current moment in time, this allows for a more flexible and reliable use than `current_time()` provides.
Props Rarst.
Fixes #47464 .
Built from https://develop.svn.wordpress.org/trunk@45883
git-svn-id: http://core.svn.wordpress.org/trunk@45694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-23 01:12:55 +00:00
e7c8b21e71
Coding Standards: Dynamic hooks should be named using interpolation not concatenation.
...
Props arena, desrosj.
Fixes #47052 .
Built from https://develop.svn.wordpress.org/trunk@45881
git-svn-id: http://core.svn.wordpress.org/trunk@45692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-22 19:08:55 +00:00
f6fc8025c4
Administration: Adjust [45814] to address a backward compatibility issue for plugins passing multiple CSS classes to `add_settings_error()`.
...
Only add the `notice-` prefix for `error`, `success`, `warning`, `info` CSS classes, keep other classes as is.
Add unit tests for `settings_errors()`.
Props afercia, SergeyBiryukov.
Fixes #44941 .
Built from https://develop.svn.wordpress.org/trunk@45873
git-svn-id: http://core.svn.wordpress.org/trunk@45684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-22 00:22:56 +00:00
3d12c4b6d8
Docs: Fix typo in `_wp_make_subsizes()` DocBlock.
...
Props itowhid06.
Fixes #47913 . See #40439 .
Built from https://develop.svn.wordpress.org/trunk@45871
git-svn-id: http://core.svn.wordpress.org/trunk@45682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-21 16:23:56 +00:00
f8fb93cd0d
Customizer: Trim whitespace from custom link URLs.
...
This complements a similar fix for the Menus screen in [45655].
Props donmhico, audrasjb.
Fixes #47888 . See #47723 .
Built from https://develop.svn.wordpress.org/trunk@45869
git-svn-id: http://core.svn.wordpress.org/trunk@45680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-21 00:27:57 +00:00
d9954ed4cb
Privacy: Add descriptions for sections in a personal data export file.
...
Props garrett-eclipse, Venutius, karmatosed.
Fixes #45491 .
Built from https://develop.svn.wordpress.org/trunk@45825
git-svn-id: http://core.svn.wordpress.org/trunk@45636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-18 02:07:57 +00:00
53f5b172ab
Plugins: Adjust margin for plugin headings on "Add Plugins" screen to avoid overlapping with "Network Activate" button.
...
Props justinahinon, chetan200891.
Fixes #47600 .
Built from https://develop.svn.wordpress.org/trunk@45824
git-svn-id: http://core.svn.wordpress.org/trunk@45635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-17 14:33:56 +00:00
be6bbe4b5d
Administration: Replace legacy `updated` message type in `add_settings_error()` calls with `success`.
...
See #44640 .
Built from https://develop.svn.wordpress.org/trunk@45818
git-svn-id: http://core.svn.wordpress.org/trunk@45629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-16 00:39:55 +00:00
e5deae5e78
Administration: In `add_settings_error()`, add `warning` and `info` as possible values for message type.
...
Account for these new values in `settings_errors()`, resulting in `notice-warning` and `notice-info` CSS classes.
Map legacy `error` and `updated` CSS classes to `notice-error` and `notice-success`.
Props donmhico, toddhalfpenny, flixos90, desrosj, javorszky, SergeyBiryukov.
Fixes #44640 , #44941 .
Built from https://develop.svn.wordpress.org/trunk@45814
git-svn-id: http://core.svn.wordpress.org/trunk@45625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 23:01:55 +00:00
ab0b860db9
Users: When deleting users, exclude the current user from the content existence check.
...
The current user cannot be deleted, so the check is redundant in that context and should only be done for other users.
Props mt8.biz, SergeyBiryukov.
Fixes #47851 .
Built from https://develop.svn.wordpress.org/trunk@45806
git-svn-id: http://core.svn.wordpress.org/trunk@45617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 13:06:55 +00:00
7169586254
Schema: Add an index to `wp_options.autoload`.
...
Most sites will be unaffected by this change, but those with a large number of rows in `wp_options`, only a small number of which have `autoload` set, will see a significant performance improvement.
Sites with a large number of rows in `wp_options`, with many of them having `autoload` set will unfortunately see a performance penalty on top of the already very slow queries they're running, but this should be the minority of cases.
Props DanBUK.
Fixes #24044 .
Built from https://develop.svn.wordpress.org/trunk@45805
git-svn-id: http://core.svn.wordpress.org/trunk@45616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 07:13:55 +00:00
98ffc642a9
Networks and Sites: Trim site domain when creating a new site on Add New Site screen before further validation.
...
Props dharmin16, jeremyfelt, aubreypwd.
Fixes #44808 .
Built from https://develop.svn.wordpress.org/trunk@45804
git-svn-id: http://core.svn.wordpress.org/trunk@45615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 01:21:55 +00:00
d85ba82d8e
Docs: Add missing `@since` tag for `WP_Site_Health::has_late_cron()`.
...
See #47223 .
Built from https://develop.svn.wordpress.org/trunk@45803
git-svn-id: http://core.svn.wordpress.org/trunk@45614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 00:42:55 +00:00
a56256d158
Site Health Check: Increase time allowance for cron checks.
...
Introduces `WP_Site_Health::has_late_cron()` for late wp-cron jobs and extends the time allowance before a job is considered missed.
In a standard configuration using loopback requests, a job is considered late once past due and missed over five minutes past due.
Late and missed time frames are extended if `DISABLE_WP_CRON` is defined as `true` to allow for crontab tasks running less frequently. A job is considered late once it's 15 minutes past due and missed over one hour past due.
A file for site health unit tests has been introduced with tests for cron in critical, late and missed states.
Props rockfire, afragen, peterwilsoncc.
Fixes #47223 .
Built from https://develop.svn.wordpress.org/trunk@45801
git-svn-id: http://core.svn.wordpress.org/trunk@45612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-15 00:35:55 +00:00
428a738f1d
Plugins: Adjust the pause before running plugin search AJAX request on "Add Plugins" screen to allow more time for using browser's autocomplete.
...
Props donmhico, apermo.
Fixes #46021 .
Built from https://develop.svn.wordpress.org/trunk@45793
git-svn-id: http://core.svn.wordpress.org/trunk@45604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 02:02:56 +00:00
4cf729f5a9
Site Health: Simplify the language in Status Health Info page introduction, add a link to Status page.
...
Props birgire, mukesh27, subrataemfluence, leogermani.
Fixes #46946 .
Built from https://develop.svn.wordpress.org/trunk@45791
git-svn-id: http://core.svn.wordpress.org/trunk@45602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 23:35:56 +00:00
400ed5add0
Remove trailing white space in upgrade.php.
...
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@45789
git-svn-id: http://core.svn.wordpress.org/trunk@45600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 19:53:55 +00:00
197b4a829b
Admin email verification:
...
- Add the `admin_email_lifespan` option when installing. Fixes a bug where the verification screen is shown right after installation.
- Reset the same option when upgrading and the user doing the DB upgrade is not an admin. This will ensure the email verification is shown next time an admin logs in.
- Use `site_url()` instead of `network_site_url()` for the form action. The latter seems needed only for password reset.
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@45788
git-svn-id: http://core.svn.wordpress.org/trunk@45599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 17:40:55 +00:00
99f4ff2578
Site Health: Add database charset and collation information to debug info.
...
Props sharaz, Clorith, SergeyBiryukov.
Fixes #47828 .
Built from https://develop.svn.wordpress.org/trunk@45782
git-svn-id: http://core.svn.wordpress.org/trunk@45593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-12 01:54:57 +00:00
6041a08347
Bootstrap/Load: Change "Insufficient Requirements" `wp_die()` heading to "Requirements Not Met", which is more appropriate for the context it's used in.
...
Props yoavf.
Fixes #47575 .
Built from https://develop.svn.wordpress.org/trunk@45770
git-svn-id: http://core.svn.wordpress.org/trunk@45581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 12:54:56 +00:00
c965d2e097
Administration: Show a warning in Reading Settings when a Privacy Policy page is accidentally set as a Homepage or Posts page.
...
Props garrett-eclipse, subrataemfluence.
Fixes #46831 .
Built from https://develop.svn.wordpress.org/trunk@45766
git-svn-id: http://core.svn.wordpress.org/trunk@45577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 23:03:54 +00:00
32afb6f7c7
Coding Standards: Use strict comparison in `wp-admin/edit.php`.
...
Props davidbaumwald.
Fixes #47201 .
Built from https://develop.svn.wordpress.org/trunk@45759
git-svn-id: http://core.svn.wordpress.org/trunk@45570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 11:40:55 +00:00
52c53ae6f8
Remove trailing white space in upgrade.php after [45757].
...
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@45758
git-svn-id: http://core.svn.wordpress.org/trunk@45569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 01:01:57 +00:00
fff56d219f
Add admin email verification screen. Shown every six months after an admin has logged in.
...
Also includes WPCS fixes for wp-login.php.
Props andraganescu, boemedia, lessbloat, azaozz.
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@45757
git-svn-id: http://core.svn.wordpress.org/trunk@45568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-07 00:04:56 +00:00
e081194455
Administration: Correct "Quick Edit" link height in list tables for consistency with other action links.
...
Props jobthomas, burhandodhy.
Fixes #47815 .
Built from https://develop.svn.wordpress.org/trunk@45756
git-svn-id: http://core.svn.wordpress.org/trunk@45567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 22:20:58 +00:00
2ac34c799b
Coding Standards: Use strict comparison in `wp-admin/options-reading.php`.
...
Props subrataemfluence.
Fixes #46834 .
Built from https://develop.svn.wordpress.org/trunk@45752
git-svn-id: http://core.svn.wordpress.org/trunk@45563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 12:52:56 +00:00
ad9d8c7d58
Plugins: Use `include_once` for `wp-admin/includes/plugin-install.php` in `WP_Plugin_Install_List_Table::prepare_items()`.
...
This brings consistency with the other instances where the file is included, and allows for reusing its functions in custom code.
Props engelen, desrosj.
Fixes #38874 .
Built from https://develop.svn.wordpress.org/trunk@45751
git-svn-id: http://core.svn.wordpress.org/trunk@45562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 11:07:55 +00:00
c1a252da8e
Site Health: Use correct variable when checking PHP requirements for a plugin update in `WP_Plugins_List_Table::single_row()`.
...
Props diddledan, sharaz, vaishalipanchal.
Fixes #47835 .
Built from https://develop.svn.wordpress.org/trunk@45750
git-svn-id: http://core.svn.wordpress.org/trunk@45561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 10:58:56 +00:00
f7b8423b12
Upgrade/Install: Make sure `translate_level_to_role()` always returns a value.
...
Props diddledan.
Fixes #46848 .
Built from https://develop.svn.wordpress.org/trunk@45747
git-svn-id: http://core.svn.wordpress.org/trunk@45558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 07:48:58 +00:00
e8cd892ba4
Administration: Display a warning at the top of "All Settings" screen.
...
Props zodiac1978, donmhico, pixolin.
Fixes #47718 .
Built from https://develop.svn.wordpress.org/trunk@45743
git-svn-id: http://core.svn.wordpress.org/trunk@45554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 13:03:55 +00:00
9967a3e030
Docs: Add missing description for `$post` global.
...
Props immeet94.
Fixes #46503 . See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45742
git-svn-id: http://core.svn.wordpress.org/trunk@45553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 12:28:56 +00:00
6da93732e7
Docs: Add missing description for `$current_screen` global.
...
Props mukesh27.
Fixes #45604 . See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45740
git-svn-id: http://core.svn.wordpress.org/trunk@45551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 02:03:55 +00:00
7f7480cb2a
Docs: Add missing description for `$wp_query` and `$wp_the_query` globals.
...
Props mukesh27.
See #45604 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45739
git-svn-id: http://core.svn.wordpress.org/trunk@45550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:59:56 +00:00
e0311b76c7
Docs: Add missing description for `$wp_locale` global.
...
Props mukesh27.
See #45604 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45737
git-svn-id: http://core.svn.wordpress.org/trunk@45548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:46:55 +00:00
b1e34ccc1f
Docs: Add missing description for `$wp_rewrite` global.
...
See #45604 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45735
git-svn-id: http://core.svn.wordpress.org/trunk@45546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:19:56 +00:00
29b072e706
Docs: Add missing description for `$wpdb`, `$wp_db_version`, and `$wp_current_db_version` globals.
...
Props mukesh27, utsav72640, immeet94, SergeyBiryukov.
See #45604 .
Built from https://develop.svn.wordpress.org/trunk@45734
git-svn-id: http://core.svn.wordpress.org/trunk@45545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:12:56 +00:00
702ee129ad
Docs: Fix typo in a comment in `WP_Site_Health::get_test_theme_version()`.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45733
git-svn-id: http://core.svn.wordpress.org/trunk@45544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 00:48:56 +00:00
fd83290995
Site Health: If `WP_DEFAULT_THEME` doesn't exist, use `WP_Theme::get_core_default_theme()` as a fallback.
...
Props ajayghaghretiya1, juliobox, SergeyBiryukov.
Fixes #47299 .
Built from https://develop.svn.wordpress.org/trunk@45732
git-svn-id: http://core.svn.wordpress.org/trunk@45543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 00:02:55 +00:00
7dbc4d28e5
Script Loader: Send a 400 Bad Request status code in `load-scripts.php` and `load-styles.php` if the required `load[]` parameter is not set.
...
Props compilenix.
Fixes #44108 .
Built from https://develop.svn.wordpress.org/trunk@45731
git-svn-id: http://core.svn.wordpress.org/trunk@45542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 22:17:57 +00:00
c377191858
PHP 7.4 compatibility fix / accessing arrays/string using curly brace syntax
...
PHP used to allow both square brackets and curly braces to be used interchangeably for accessing array elements and string offsets. The curly bracket syntax is only allowed in a limited set of cases and can be confusing for people not used to it.
PHP 7.4 will deprecate the curly brace syntax for accessing array elements and string offsets and it is expected that support will be completely removed in PHP 8.0.
Ref: https://wiki.php.net/rfc/deprecate_curly_braces_array_access
See #47751 .
Props jrf.
Built from https://develop.svn.wordpress.org/trunk@45730
git-svn-id: http://core.svn.wordpress.org/trunk@45541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 20:21:55 +00:00
b853e21bf9
Accessibility: Improve the differences between revisions.
...
Color alone is not sufficient to visually communicate differences.
- adds `plus` and `minus` icons to the changed lines
- adds visually hidden text: `Added`, `Deleted`, and `Unchanged` to clarify the differences to assistive technologies users
Props birgire, audrasjb, kjellr, adamsilverstein.
Fixes #43532 .
Built from https://develop.svn.wordpress.org/trunk@45729
git-svn-id: http://core.svn.wordpress.org/trunk@45540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 15:46:54 +00:00
7b45746001
Menus: Fix the Custom Links text fallback.
...
When adding a Custom Link and leaving the "Link Text" field empty, WordPress used to set a default fallback text: "Menu Item".
The changes in [36379] broke this behavior making the fallback text: ` (Pending)`, with a leading space.
Pending major refactoring of the Menus page (which is going to use a block-based user interface) this change just restores the original behavior by adding the fallback text to the related AJAX response.
Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb.
Fixes #38415 .
Built from https://develop.svn.wordpress.org/trunk@45727
git-svn-id: http://core.svn.wordpress.org/trunk@45538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 12:19:56 +00:00
c26f1c5d90
Taxonomy: Fix deprecated calls to `get_terms()`.
...
The taxonomy should be passed as part of `$args`, rather than as its own argument.
Props sgastard, mukesh27, SergeyBiryukov.
Fixes #47819 .
Built from https://develop.svn.wordpress.org/trunk@45723
git-svn-id: http://core.svn.wordpress.org/trunk@45534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 03:35:56 +00:00
60431f3c53
Customize: Make the color picker close when clicking on the empty area on the right.
...
Props monikarao.
Fixes #47693 .
Built from https://develop.svn.wordpress.org/trunk@45722
git-svn-id: http://core.svn.wordpress.org/trunk@45533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-02 17:09:57 +00:00
b32cff72c2
Users: Deprecate `update_user_status()` in favor of `wp_update_user()`.
...
Props spacedmonkey, SergeyBiryukov.
Fixes #45747 .
Built from https://develop.svn.wordpress.org/trunk@45708
git-svn-id: http://core.svn.wordpress.org/trunk@45519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-01 11:28:54 +00:00
ee23869c68
Docs: Correct parameter documentation for `bulk_edit_custom_box` and `quick_edit_custom_box` actions.
...
Props abrain.
Fixes #47810 .
Built from https://develop.svn.wordpress.org/trunk@45704
git-svn-id: http://core.svn.wordpress.org/trunk@45515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-31 15:10:58 +00:00
fa9980049e
Admin: Improve Dashboard icon contrast.
...
The icons used across the dashboard had too low contrast to pass AA WCAG guidelines. They’re now slightly darker for better contrast.
Props @melchoyce, @SergeyBiryukov, @chetan200891 , @kjellr
Fixes #46935
Built from https://develop.svn.wordpress.org/trunk@45700
git-svn-id: http://core.svn.wordpress.org/trunk@45511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-30 22:54:57 +00:00
98642b4821
Users: Use case-insensitive email address comparison when checking whether "Grant this user super admin privileges" checkbox should be displayed on Edit User screen.
...
Props trepmal.
Fixes #47119 .
Built from https://develop.svn.wordpress.org/trunk@45698
git-svn-id: http://core.svn.wordpress.org/trunk@45509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 17:42:55 +00:00
ec8940edeb
Coding Standards: Fix WPCS violations in `wp-admin/includes/class-walker-nav-menu-edit.php`.
...
Props sudhiryadav, audrasjb.
Fixes #46902 .
Built from https://develop.svn.wordpress.org/trunk@45697
git-svn-id: http://core.svn.wordpress.org/trunk@45508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:53:52 +00:00
c9942bb3d8
Coding Standards: Fix WPCS violations in [45694].
...
See #47466 .
Built from https://develop.svn.wordpress.org/trunk@45696
git-svn-id: http://core.svn.wordpress.org/trunk@45507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:52:56 +00:00
e7abdc7040
Docs: Improve the DocBlocks for `got_mod_rewrite()`, `extract_from_markers()`, `insert_with_markers()`.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45695
git-svn-id: http://core.svn.wordpress.org/trunk@45506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:35:56 +00:00
67e5038470
Rewrite Rules: Add a comment to `# BEGIN/END` `.htaccess` markers to clarify that the directives are dynamically generated, and should only be modified via WordPress filters.
...
Introduce `insert_with_markers_inline_instructions` filter to modify the default instructions text.
Props bradleyt, SergeyBiryukov.
Fixes #47466 .
Built from https://develop.svn.wordpress.org/trunk@45694
git-svn-id: http://core.svn.wordpress.org/trunk@45505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:31:57 +00:00
7a4d1b5dbd
Permalinks: Improve appearance of URL examples on Permalink Settings screen.
...
Props luan-ramos, sarath.ar.
Fixes #41559 .
Built from https://develop.svn.wordpress.org/trunk@45693
git-svn-id: http://core.svn.wordpress.org/trunk@45504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:11:56 +00:00
b95b055225
Administration: Allow breaking long strings in `<code>` tags at any point, to avoid overflowing on mobile.
...
Props david.binda, mukesh27.
Fixes #47329 .
Built from https://develop.svn.wordpress.org/trunk@45692
git-svn-id: http://core.svn.wordpress.org/trunk@45503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 16:09:55 +00:00
a59301c2ba
Site Health: Consistently use `wpdb::db_version()` for checking the database server version, instead of partically replicating its functionality.
...
Props Clorith, wpfed.
Fixes #47738 .
Built from https://develop.svn.wordpress.org/trunk@45691
git-svn-id: http://core.svn.wordpress.org/trunk@45502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-28 14:55:57 +00:00
f933abef11
Accessibility: Taxonomy: When a new category or tag is being added, show a spinner and noop the button to avoid multiple requests.
...
Props andg, afercia, guddu1315, SergeyBiryukov.
Fixes #47607 .
Built from https://develop.svn.wordpress.org/trunk@45683
git-svn-id: http://core.svn.wordpress.org/trunk@45494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 17:46:56 +00:00
5cdbe22b16
Administration: Merge CSS rules for `#adminmenu .wp-submenu a` in one place.
...
Props ozmatflc, AkSDvP.
Fixes #47780 .
Built from https://develop.svn.wordpress.org/trunk@45682
git-svn-id: http://core.svn.wordpress.org/trunk@45493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 13:49:57 +00:00
e925997562
Site Health: Show parent theme in its own accordion on Site Health Info screen; rename "Other Themes" to "Inactive Themes".
...
Props garrett-eclipse, mukesh27, Clorith, xkon, msaggiorato.
Fixes #46925 .
Built from https://develop.svn.wordpress.org/trunk@45680
git-svn-id: http://core.svn.wordpress.org/trunk@45491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-26 03:49:55 +00:00
a186dbcb65
I18N: Update translator comments after [45674].
...
See #47771 .
Built from https://develop.svn.wordpress.org/trunk@45676
git-svn-id: http://core.svn.wordpress.org/trunk@45487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 22:52:56 +00:00
8e85299a00
General: First pass at replacing Codex URLs with a corresponding HelpHub or DevHub article.
...
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771 .
Built from https://develop.svn.wordpress.org/trunk@45674
git-svn-id: http://core.svn.wordpress.org/trunk@45485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 22:45:57 +00:00
ccba6c4aec
Upgrade/Install: Bring some consistency to installation screen styles.
...
* Include `forms.css` and `l10n.css`, for consistency with login screen and other admin screens.
* Remove redundant `@import` directives from `login.css` for files already declared as dependencies.
* Adjust margin on password strength meter for consistency with other fields.
* Increase font size for "You will need this password to log in" notice.
* Fix misaligned icon on "Hide" button for the password.
Props iseulde, dan@micamedia.com , bassgang, cdog, johnbillion, nmenescardi, mukesh27, SergeyBiryukov.
Fixes #35776 , #47757 , #47758 .
Built from https://develop.svn.wordpress.org/trunk@45673
git-svn-id: http://core.svn.wordpress.org/trunk@45484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 19:11:55 +00:00
316fa4aecb
Code Editor: Check for correct `mode` value in `wp.codeEditor.initialize` to enable autocomplete support for PHP.
...
Props ediamin.
Fixes #47769 .
Built from https://develop.svn.wordpress.org/trunk@45670
git-svn-id: http://core.svn.wordpress.org/trunk@45481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 01:27:57 +00:00
aee690fd84
Permalinks: Update URLs for "Changing File Permissions" documentation article.
...
Props patilswapnilv, ianbelanger, SergeyBiryukov.
Fixes #47768 .
Built from https://develop.svn.wordpress.org/trunk@45669
git-svn-id: http://core.svn.wordpress.org/trunk@45480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 01:18:55 +00:00
18bd01985b
Coding Standards: Rename `$r` variable used with `wp_parse_args()` to `$parsed_args` for clarity.
...
Props freewebmentor.
Fixes #45059 .
Built from https://develop.svn.wordpress.org/trunk@45667
git-svn-id: http://core.svn.wordpress.org/trunk@45478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 00:48:58 +00:00
971814047f
Coding Standards: Move wp-admin/custom-background.php to wp-admin/includes/class-custom-background.php
...
This renames the file containing the Custom_Background class to conform to the coding standards.
This commit also includes:
- A new custom-background.php that includes the new file, for anyone that may've been including the file directly.
- Replaces a reference to the old filename with the new filename.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45662
git-svn-id: http://core.svn.wordpress.org/trunk@45473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 04:02:55 +00:00
1f5fcff132
Coding Standards: Improve spacing of `printf()` calls in the admin About pages.
...
Props garrett-eclipse.
Fixes #47734 .
Built from https://develop.svn.wordpress.org/trunk@45660
git-svn-id: http://core.svn.wordpress.org/trunk@45471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-19 00:09:58 +00:00
1c331e8931
I18N: Make URLs to ` https://wordpress.org/about/ ` and related pages translatable, as they can now be localized on Rosetta sites.
...
Props mukesh27.
Fixes #46386 .
Built from https://develop.svn.wordpress.org/trunk@45659
git-svn-id: http://core.svn.wordpress.org/trunk@45470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-18 12:41:57 +00:00
22412b1d97
Customizer: Show all widgets when the search field is cleared.
...
When clicking the clear button on the widget search field, the search results should refresh to show all widgets.
Props Mahesh901122.
Fixes #47534 .
Built from https://develop.svn.wordpress.org/trunk@45658
git-svn-id: http://core.svn.wordpress.org/trunk@45469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-18 05:55:59 +00:00
7149d65934
Editor: Replace external Classic Editor plugin URL with a link to Add Plugins screen with Classic Editor pre-selected.
...
This applies to messages displayed when JavaScript is disabled in Block Editor, or an incompatible meta box is used.
Props garrett-eclipse, derweili, afercia.
Fixes #47487 .
Built from https://develop.svn.wordpress.org/trunk@45657
git-svn-id: http://core.svn.wordpress.org/trunk@45468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-18 01:33:57 +00:00
24d08a9463
Coding Standards: Move `wp-admin/custom-header.php` to `wp-admin/includes/class-custom-image-header.php`
...
This renames the file containing the `Custom_Image_Header` class to conform to the coding standards.
This commit also includes:
- A new `custom-header.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45654
git-svn-id: http://core.svn.wordpress.org/trunk@45465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 06:17:56 +00:00
1f256f3fdc
Administration: In `admin-ajax.php`, send `X-Robots-Tag` header earlier, so that it applies before `wp_die()` when no action parameter was provided.
...
Props robi-bobi, harryfear, garrett-eclipse.
Fixes #47711 .
Built from https://develop.svn.wordpress.org/trunk@45650
git-svn-id: http://core.svn.wordpress.org/trunk@45461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-17 01:11:56 +00:00
66afb60397
Site Health: Use consistent verbiage for "Learn more" links.
...
Props ronakganatra, garrett-eclipse.
Fixes #47302 .
Built from https://develop.svn.wordpress.org/trunk@45649
git-svn-id: http://core.svn.wordpress.org/trunk@45460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 22:28:57 +00:00
f600647e22
Site Health: Replace "harddrive" with "device" on Site Health Info screen.
...
Props chetan200891, timhavinga, Cybr, Clorith.
Fixes #46965 .
Built from https://develop.svn.wordpress.org/trunk@45648
git-svn-id: http://core.svn.wordpress.org/trunk@45459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 22:19:55 +00:00
e5ad773194
I18N: Merge duplicate "Your plugins/themes/translations are all up to date" strings.
...
Props ramiy.
Fixes #47252 .
Built from https://develop.svn.wordpress.org/trunk@45647
git-svn-id: http://core.svn.wordpress.org/trunk@45458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 22:13:58 +00:00
5eba5381e6
Media: Sort the new sizes array by priority when creating image sub-sizes.
...
See #40439 .
Built from https://develop.svn.wordpress.org/trunk@45645
git-svn-id: http://core.svn.wordpress.org/trunk@45456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 21:48:56 +00:00
62216de5d4
Docs: Move the `do_mu_upgrade` DocBlock out of the preceding `if` statement.
...
Props ChriCo, dkarfa.
Fixes #47710 .
Built from https://develop.svn.wordpress.org/trunk@45643
git-svn-id: http://core.svn.wordpress.org/trunk@45454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 13:15:58 +00:00
62dc808103
Docs: Correct `@since` tag for `do_mu_upgrade` hook, for consistency with `after_mu_upgrade` and `wpmu_upgrade_site`.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45642
git-svn-id: http://core.svn.wordpress.org/trunk@45453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-16 12:42:59 +00:00
83d175cdd0
I18N: Add context for theme filter strings in `WP_MS_Themes_List_Table::get_views()`.
...
Props audrasjb.
Fixes #47695 .
Built from https://develop.svn.wordpress.org/trunk@45634
git-svn-id: http://core.svn.wordpress.org/trunk@45445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-14 14:47:56 +00:00
436a9512e2
Upgrade/Install: Remove debugging artifacts from `wp-admin/upgrade.php` added in [1229].
...
Props rahulvaza.
Fixes #47074 .
Built from https://develop.svn.wordpress.org/trunk@45633
git-svn-id: http://core.svn.wordpress.org/trunk@45444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-14 14:39:57 +00:00
02c07f23d5
Customize: Fix text direction for color picker in RTL.
...
Props vjik for the report.
Fixes #47688 . See #23740 .
Built from https://develop.svn.wordpress.org/trunk@45626
git-svn-id: http://core.svn.wordpress.org/trunk@45437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 00:05:57 +00:00
bb8afb46b9
Block Editor: Avoid a PHP warning when a theme adds an editor style with an empty filename.
...
Fixes #45739 .
Built from https://develop.svn.wordpress.org/trunk@45619
git-svn-id: http://core.svn.wordpress.org/trunk@45430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 07:21:55 +00:00
4c3d541e23
Block Editor: Fix the link to the classic editor when incompatible meta boxen are detected.
...
Props tmatsuur, mukesh27.
Fixes #45935 .
Built from https://develop.svn.wordpress.org/trunk@45618
git-svn-id: http://core.svn.wordpress.org/trunk@45429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 06:01:58 +00:00
7369ff02f5
Coding Standards: Remove extra whitespace in list tables' `column_cb()` methods.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45617
git-svn-id: http://core.svn.wordpress.org/trunk@45428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 21:11:58 +00:00
9a5f538153
Coding Standards: Remove extra whitespace in `wp-admin/includes/image-edit.php`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45616
git-svn-id: http://core.svn.wordpress.org/trunk@45427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 21:05:57 +00:00
6a696f6051
I18N: Move code out of translatable string in a `_deprecated_argument()` message in `wp_stream_image()`, `wp_save_image_file()`, and `image_edit_apply_changes()`.
...
Props ramiy.
Fixes #47406 .
Built from https://develop.svn.wordpress.org/trunk@45615
git-svn-id: http://core.svn.wordpress.org/trunk@45426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 20:57:56 +00:00
bb365054b8
Menus: Remove extra whitespace from URLs in `Walker_Nav_Menu_Edit::start_el()`.
...
Props alexeyskr, SergeyBiryukov.
Fixes #47666 .
Built from https://develop.svn.wordpress.org/trunk@45614
git-svn-id: http://core.svn.wordpress.org/trunk@45425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 20:45:56 +00:00
29e5155969
Filesystem API: Check correct variable in `WP_Filesystem_Direct::dirlist()` after [45611].
...
Props zinigor.
Fixes #47668 . See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45613
git-svn-id: http://core.svn.wordpress.org/trunk@45424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 15:58:57 +00:00
4be25f3d06
Coding Standards: Fix instances of `WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase`.
...
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45612
git-svn-id: http://core.svn.wordpress.org/trunk@45423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 06:29:57 +00:00
abcbee954f
Coding Standards: Fix instances of `WordPress.PHP.NoSilencedErrors.Discouraged`.
...
Noteable changes:
- The `magic_quotes_runtime` and `magic_quotes_sybase` settings were removed in PHP 5.4, so no longer need to be set.
- Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
- Quite a few functions would cause errors if `safe_mode` was set. This setting was removed in PHP 5.4.
- Only a handful of `header()` calls needed corresponding `headers_sent()` checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45611
git-svn-id: http://core.svn.wordpress.org/trunk@45422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 05:45:58 +00:00
82935b0343
Theme Editor: Hide the recommendation to create a child theme when editing a child theme.
...
Props mukesh27, davidbaumwald.
Fixes #44889 .
Built from https://develop.svn.wordpress.org/trunk@45608
git-svn-id: http://core.svn.wordpress.org/trunk@45419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-08 03:15:56 +00:00
14c7533162
Coding Standards: Fix all `WordPress.DB.PreparedSQLPlaceholders` issues.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45603
git-svn-id: http://core.svn.wordpress.org/trunk@45414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 05:43:55 +00:00
87675d288b
Coding Standards: Fix all `WordPress.WhiteSpace.PrecisionAlignment` issues.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45602
git-svn-id: http://core.svn.wordpress.org/trunk@45413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 05:21:56 +00:00
a02b5cc2a8
Coding Standards: Mark the handful of hook names with uppercase characters or hyphens as ignored.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45599
git-svn-id: http://core.svn.wordpress.org/trunk@45410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 01:45:56 +00:00
4af4c78a27
Text Changes: Use consistent question wording for plugin and theme deletion confirmations.
...
Props johnjamesjacoby, Presskopp.
Fixes #44878 .
Built from https://develop.svn.wordpress.org/trunk@45597
git-svn-id: http://core.svn.wordpress.org/trunk@45408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 09:56:57 +00:00
cf3fa9f7c8
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `wp-admin`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45583
git-svn-id: http://core.svn.wordpress.org/trunk@45394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 12:52:01 +00:00
55af0f0d0a
Coding Standards: Fix/ignore the `WordPress.NamingConventions.ValidFunctionName` violations.
...
See #47632
Built from https://develop.svn.wordpress.org/trunk@45580
git-svn-id: http://core.svn.wordpress.org/trunk@45391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:01:57 +00:00
072682b1ed
Multisite: Use `size_format()` in `display_space_usage()`.
...
Deleted code is the best code.
Fixes #28239 .
Built from https://develop.svn.wordpress.org/trunk@45579
git-svn-id: http://core.svn.wordpress.org/trunk@45390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 03:47:56 +00:00
9d7bd11631
Docs: Correct `@since` for `admin/edit-comments.js`, introduced in [3736].
...
See #47581 .
Built from https://develop.svn.wordpress.org/trunk@45567
git-svn-id: http://core.svn.wordpress.org/trunk@45378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-26 18:19:52 +00:00
05c9032a0b
Editor: Fix undefined `$locked` var in edit-form-blocks.php when the `show_post_locked_dialog` filter is used to disable displaying of the dialog.
...
Props aprea.
Fixes #47604 .
Built from https://develop.svn.wordpress.org/trunk@45564
git-svn-id: http://core.svn.wordpress.org/trunk@45375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-25 15:03:52 +00:00
ba24a8f6d3
Plugins: Fix the plugin details modal layout after [45520].
...
Props mukesh27, marybaum, audrasjb.
Fixes #47561 .
Built from https://develop.svn.wordpress.org/trunk@45563
git-svn-id: http://core.svn.wordpress.org/trunk@45374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-25 14:11:55 +00:00
225de4e6eb
Docs: Improve JSDoc for `admin/edit-comments.js`.
...
Props manuelaugustin, diedeexterkate, thulshof, Xyfi, ireneyoast.
Fixes #47581 .
Built from https://develop.svn.wordpress.org/trunk@45558
git-svn-id: http://core.svn.wordpress.org/trunk@45369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 14:45:51 +00:00
bcc4ecb1f6
Themes: improve search by trimming search string.
...
Fix an issue where searching installed themes for an empty string resulted in matching all themes.
Props afercia, desrosj, hesyifei, evalarumbe.
Fixes #39041 .
Built from https://develop.svn.wordpress.org/trunk@45557
git-svn-id: http://core.svn.wordpress.org/trunk@45368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 14:15:53 +00:00
89e7a75d96
Date/Time: Eliminate use of `date_default_timezone_set()` for determining DST status on General Options screen.
...
Time calculations should not need to rely on manipulating global PHP configuration state.
Props Rarst.
Fixes #46483 .
Built from https://develop.svn.wordpress.org/trunk@45556
git-svn-id: http://core.svn.wordpress.org/trunk@45367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 14:11:53 +00:00
8756207ef2
Comments: Open comment quick edit on double click.
...
In [42767] the quick edit button changed from a link to a button. This caused the jQuery code that selects on a link to no longer work. This commit restores the previous behavior.
Fixes #47572 .
See #43382 , #38677 .
Built from https://develop.svn.wordpress.org/trunk@45553
git-svn-id: http://core.svn.wordpress.org/trunk@45364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 10:06:51 +00:00
470177a906
Help/About: Improve wording of PHP Error Protection section.
...
Props pedromendonca, garrett-eclipse.
See #47475 .
Fixes #47538 .
Built from https://develop.svn.wordpress.org/trunk@45551
git-svn-id: http://core.svn.wordpress.org/trunk@45362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 09:52:54 +00:00
f0e9ffdebb
Plugins: When validating plugin's WordPress and PHP requirements, check for `Requires at least` and `Requires PHP` headers in the plugin's main PHP file.
...
This allows for blocking plugin activation if it requires a higher version of PHP or WordPress, and does not have a `readme.txt` file.
If the headers are defined in both `readme.txt` and the main plugin file, precedence is given to the plugin file.
Props afragen, Otto42, Ipstenu.
Fixes #46938 .
Built from https://develop.svn.wordpress.org/trunk@45546
git-svn-id: http://core.svn.wordpress.org/trunk@45357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-18 03:24:52 +00:00
88ffa41ee3
Media: Ignore errors coming from `image_resize_dimensions()` when creating sub-sizes (for now). It returns `false` when the requested size is larger than the original image and should be skipped. This triggers new `WP_Error` in `WP_Image_Editor::resize()`.
...
See #40439 .
Built from https://develop.svn.wordpress.org/trunk@45543
git-svn-id: http://core.svn.wordpress.org/trunk@45354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-16 01:33:51 +00:00
4e4ef1170b
I18N: Merge duplicate strings in notifications displayed when a new user has been created or added to the site.
...
Props ramiy.
Fixes #35746 .
Built from https://develop.svn.wordpress.org/trunk@45542
git-svn-id: http://core.svn.wordpress.org/trunk@45353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 18:57:52 +00:00
da7839dc45
After [45538]: fix another WPCS "strict comparison" fix.
...
Props birgire.
See #40439 .
Built from https://develop.svn.wordpress.org/trunk@45540
git-svn-id: http://core.svn.wordpress.org/trunk@45351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 16:24:52 +00:00
5987caeecc
After [45538]: fix a WPCS fix and make couple of var names consistent.
...
See #40439 .
Built from https://develop.svn.wordpress.org/trunk@45539
git-svn-id: http://core.svn.wordpress.org/trunk@45350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 01:32:53 +00:00
05302bd054
Save progress of intermediate image creation after upload. First run.
...
- Introduces `wp_get_missing_image_subsizes()` and `wp_update_image_subsizes()` to generate image sub-sizes that are missing or were not created after the upload.
- Adds a way to display errors that happened while creating sub-sizes.
- Introduces `wp_create_image_subsizes()` intended for use after an image was uploaded. It saves/updates the image metadata immediately after each sub-size is created. This fixes the (long standing) problem when some of the sub-size image files were created but there was a timeout or an error and the metadata was not saved. Until now such uploads were considered "failed" which usually resulted in the user trying to upload the same image again, creating even more "orphan" image files.
Note that the patch also includes some unrelated WPCS fixes.
Props mikeschroder, azaozz.
See #40439 .
Built from https://develop.svn.wordpress.org/trunk@45538
git-svn-id: http://core.svn.wordpress.org/trunk@45349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 01:02:52 +00:00
0239fe6d10
Administration: Adjust code for "Manage widgets or menus" item on "Welcome to WordPress" panel to avoid an extra space after [42343].
...
Props Presskopp, davidbaumwald.
Fixes #47536 .
Built from https://develop.svn.wordpress.org/trunk@45536
git-svn-id: http://core.svn.wordpress.org/trunk@45347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-14 00:29:52 +00:00
d38e15e59d
Fix displaying of the "An updated version of WordPress is available." notice when running the latest nightly build. Note that it is still displayed when running a local build or from `/src`.
...
Props afragen, audrasjb, SergeyBiryukov.
Fixes #45202 .
Built from https://develop.svn.wordpress.org/trunk@45532
git-svn-id: http://core.svn.wordpress.org/trunk@45343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 16:43:53 +00:00
727838a11b
Add a Recovery Mode Exit button to the notice. This fixes it in responsive view.
...
Props desrosj, karmatosed, chetan200891, afercia, afragen, garrett-eclipse.
Fixes #47070 .
Built from https://develop.svn.wordpress.org/trunk@45529
git-svn-id: http://core.svn.wordpress.org/trunk@45340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 16:00:52 +00:00
340fd28d82
Accessibility: Improve focus management in the Media Views.
...
- keeps focus management only where necessary to avoid focus losses
- removes focus management where a specific user workflow was assumed
- makes the "Attachment Details" navigation buttons really disabled when there are no next or previous attachments
- adds inline comments to clarify all the usages of focus()
Fixes #43169 .
Built from https://develop.svn.wordpress.org/trunk@45524
git-svn-id: http://core.svn.wordpress.org/trunk@45335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 21:03:52 +00:00
9f579ea448
Administration: Improve the horizontal centering of the Site Health tabs.
...
Props dkarfa, davidbaumwald, Clorith, tinkerbelly, afercia.
Fixes #46881 .
Built from https://develop.svn.wordpress.org/trunk@45522
git-svn-id: http://core.svn.wordpress.org/trunk@45333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 19:31:52 +00:00
9f7f9d2d89
Administration: Fix the responsive layout after changes to the Screen Options and Help buttons position.
...
Fixes #45094 .
Built from https://develop.svn.wordpress.org/trunk@45520
git-svn-id: http://core.svn.wordpress.org/trunk@45331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 19:21:54 +00:00
d0c1b77cda
Privacy tools:
...
- Move the (remaining) privacy tools related functions from `wp-admin/includes/file.php` to `wp-admin/includes/privacy-tools.php`.
- Move the `WP_User_Request` class to a separate file.
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45519
git-svn-id: http://core.svn.wordpress.org/trunk@45330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 23:54:53 +00:00
3b69e493f6
I18N: Merge duplicate "authenticity could not be verified" strings, fix comma placement on About page.
...
Props pedromendonca, garrett-eclipse.
Fixes #47475 .
Built from https://develop.svn.wordpress.org/trunk@45515
git-svn-id: http://core.svn.wordpress.org/trunk@45326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 14:14:51 +00:00
a5e57d7245
Site health: Introduce `view_site_health_checks` capability.
...
Introduces the faux primitive capability `view_site_health_checks` available to single site admins and multisite super-admin to view the site health page within the admin.
The capability is mapped to the `install_plugins` capability without being dependent on the file system being writable. This fixes a bug where the feature couldn't be used by sites unable to write to the file system or managed through version control.
The capability is granted on the `user_has_cap` filter.
Props birgire, Clorith, palmiak, peterwilsoncc, spacedmonkey.
Fixes #46957 .
Built from https://develop.svn.wordpress.org/trunk@45507
git-svn-id: http://core.svn.wordpress.org/trunk@45318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 07:42:52 +00:00
c9b51df3d0
I18N: Allow the length of automatically generated excerpts to be localized.
...
This introduces three new strings that can be used to control the maximum length of automatically generated excerpts for posts, comments, and draft post previews in the dashboard. Optionally combined with the existing word count type control this allows languages which include many multibyte characters to specify more appropriate maximum excerpt lengths.
Props miyauchi, birgire, johnbillion
Fixes #44541
Built from https://develop.svn.wordpress.org/trunk@45505
git-svn-id: http://core.svn.wordpress.org/trunk@45316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 18:42:52 +00:00
935c35fe34
Accessibility: Improve the Screen Options and Help buttons order.
...
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]
Props vrimill, mukesh27 for reporting and testing.
Fixes #45094 .
Built from https://develop.svn.wordpress.org/trunk@45503
git-svn-id: http://core.svn.wordpress.org/trunk@45314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:31:53 +00:00
be14c6e5c6
Administration: Improve the Screen Options and Help buttons focus style after [45501].
...
Amends [45501].
See #46749 .
Built from https://develop.svn.wordpress.org/trunk@45502
git-svn-id: http://core.svn.wordpress.org/trunk@45313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:07:52 +00:00
17034e2a4e
Administration: Remove extra border from the Screen Options and Help buttons.
...
The extra border was visible in the responsive view for smaller screens after [32844].
Props jitendrabanjara1991.
Fixes #46749 .
Built from https://develop.svn.wordpress.org/trunk@45501
git-svn-id: http://core.svn.wordpress.org/trunk@45312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 14:50:52 +00:00
7cee029897
Privacy tools: remove some left-over code and fix inline comment.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45500
git-svn-id: http://core.svn.wordpress.org/trunk@45311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 00:30:51 +00:00
6a9bcaeaa9
Accessibility: Improve accessibility of all the media views form controls.
...
- changes the media views form controls to have explicitly associated labels with for/id attributes
- adds a few missing labels / aria-labels
- improves a few existing labels / aria-labels
- improves semantics in a few places, by adding visually hidden headings, fieldset + legend elements, aria-describedby attributes
- improves the image custom size input fields and their labelling
- adds `role="status"` to the "saved" indicator so that status messages are announced to assistive technologies
- swaps the columns source order in the image details template, to make visual and DOM order match
- swaps the "Replace" and "Back" buttons source order in the Replace Image view, to make visual and DOM order match
- gallery settings: move checkbox label to the right: checkboxes are supposed to have labels on the right
- merge similar strings, unified to "Drop files to upload" (removed "Drop files here", and "Drop files anywhere to upload")
- makes the "upload-ui" consistent across the media views
- hides the IE 11 "X" `::-ms-clear` button in the Insert from URL field, as it conflicts with the uploading spinner
- adds comments to all the media templates to clarify their usage
- slightly increases vertical spacing between form fields in the media sidebar
- removes some CSS selectors introduced as backwards compatibility for WordPress pre-4.4
- removes some CSS still targeting Internet Explorer 7 and 8
Fixes #47141 .
Fixes #47122 .
Built from https://develop.svn.wordpress.org/trunk@45499
git-svn-id: http://core.svn.wordpress.org/trunk@45310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 20:45:02 +00:00
d5333b9593
Fix the media player controls bar width in the media views.
...
Props vaishalipanchal, chetan200891.
Fixes #47457 .
Built from https://develop.svn.wordpress.org/trunk@45497
git-svn-id: http://core.svn.wordpress.org/trunk@45308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 13:29:52 +00:00
baa2cd69b8
Media: Restore correct arrow direction in RTL in Attachment Details modal.
...
Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.
Props ramiy, SergeyBiryukov.
Fixes #46289 .
Built from https://develop.svn.wordpress.org/trunk@45495
git-svn-id: http://core.svn.wordpress.org/trunk@45306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-06 01:25:52 +00:00
4c0620bdf8
Privacy: Remove inline CSS within personal data request list tables.
...
The `.hidden` class can be used to show and hide UI elements instead.
Props birgire, pratikthink, garrett-eclipse.
Fixes #44839 .
Built from https://develop.svn.wordpress.org/trunk@45490
git-svn-id: http://core.svn.wordpress.org/trunk@45301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-04 23:40:55 +00:00
32d761ce7d
I18N: Merge duplicate "Status" and "Info" strings on Site Health screens.
...
Props ramiy.
Fixes #47227 .
Built from https://develop.svn.wordpress.org/trunk@45488
git-svn-id: http://core.svn.wordpress.org/trunk@45299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-01 22:10:52 +00:00
13da094c39
Upgrade/Install: Correct operator precedence for an error code in `WP_Ajax_Upgrader_Skin::error()`.
...
Props jrf.
Fixes #47441 .
Built from https://develop.svn.wordpress.org/trunk@45487
git-svn-id: http://core.svn.wordpress.org/trunk@45298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-31 14:14:52 +00:00
0d40c54f9b
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/media.css`.
...
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46530 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45484
git-svn-id: http://core.svn.wordpress.org/trunk@45295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:45:50 +00:00
412ffd0aaf
Media: Move tag cloud styles that accidentally ended up in Media section after the reorganization in [16136] to a more appropriate place.
...
Remove styles for `wp-admin/update-core.php` accidentally duplicated in Media section as part of the same reorganization.
See #46530 .
Built from https://develop.svn.wordpress.org/trunk@45483
git-svn-id: http://core.svn.wordpress.org/trunk@45294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:40:52 +00:00
349d95f27a
Docs: Add missing function documentation for `list_plugin_updates()`.
...
Introduced in [9543].
Props priyankkpatel, mukesh27.
Fixes #47424 .
Built from https://develop.svn.wordpress.org/trunk@45480
git-svn-id: http://core.svn.wordpress.org/trunk@45291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 15:10:52 +00:00
fdc6b9583b
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/revisions.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46517 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45468
git-svn-id: http://core.svn.wordpress.org/trunk@45279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:16:52 +00:00
ca6aa01705
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/list-tables.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46515 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45467
git-svn-id: http://core.svn.wordpress.org/trunk@45278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:15:52 +00:00
afaeca95cf
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/login.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46514 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45466
git-svn-id: http://core.svn.wordpress.org/trunk@45277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:09:52 +00:00
1899a99c35
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/install.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46513 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45465
git-svn-id: http://core.svn.wordpress.org/trunk@45276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:53:53 +00:00
03814826b2
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/forms.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46512 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45464
git-svn-id: http://core.svn.wordpress.org/trunk@45275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:49:53 +00:00
41accccad6
Administration: Improve the Site Health tables layout for small screens.
...
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield.
Fixes #46960 .
Built from https://develop.svn.wordpress.org/trunk@45463
git-svn-id: http://core.svn.wordpress.org/trunk@45274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 18:22:51 +00:00
52d478cb0d
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/edit.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46511 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45462
git-svn-id: http://core.svn.wordpress.org/trunk@45273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:05:53 +00:00
ce25e2f34d
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/dashboard.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46510 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45461
git-svn-id: http://core.svn.wordpress.org/trunk@45272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:03:52 +00:00
9860a4366d
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/customize-widgets.css`.
...
Props ianbelanger, pbiron, afercia.
Fixes #46509 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45460
git-svn-id: http://core.svn.wordpress.org/trunk@45271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:01:53 +00:00
bb3c264350
Administration: Add missing filter documentation for Site Health auto update tests.
...
Props johnbillion, mukesh27.
Fixes #47388 .
Built from https://develop.svn.wordpress.org/trunk@45459
git-svn-id: http://core.svn.wordpress.org/trunk@45270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 13:59:51 +00:00
6de52463a7
Script loader: prevent sorting of the `load` array in the query string when passing the script handles to load-scripts.php and load-styles.php.
...
Fixes #45346 #26886 .
Built from https://develop.svn.wordpress.org/trunk@45456
git-svn-id: http://core.svn.wordpress.org/trunk@45267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 02:43:55 +00:00
51ee349942
Docs: Add a comment about the reinstated `wp-admin/options-privacy.php`.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45454
git-svn-id: http://core.svn.wordpress.org/trunk@45265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-27 03:03:52 +00:00
96b4570781
Privacy: Remove reinstated `wp-admin/options-privacy.php` from `$_old_files`.
...
Fix WPCS violations in [45448].
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45453
git-svn-id: http://core.svn.wordpress.org/trunk@45264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-27 02:40:53 +00:00
2f7f0ad901
Fix typo in [45451] and move the redirect to the proper location.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45452
git-svn-id: http://core.svn.wordpress.org/trunk@45263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 23:21:51 +00:00
cbcccbd5b6
Privacy tools: restore `privacy.php` to its "proper" use to output the Privacy tab on the About screen, see [42814]. Then add the Privacy tab updates from freedoms.php.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45451
git-svn-id: http://core.svn.wordpress.org/trunk@45262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 22:57:52 +00:00
6aab3f2f05
Docs: Improve documentation for some more variadic functions.
...
Fixes #37402
Built from https://develop.svn.wordpress.org/trunk@45450
git-svn-id: http://core.svn.wordpress.org/trunk@45261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 22:48:51 +00:00
87acdab81d
Privacy tools: Organize privacy functions into logical files and classes.
...
Props xkon, birgire, desrosj, garrett-eclipse, azaozz.
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45448
git-svn-id: http://core.svn.wordpress.org/trunk@45259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 20:50:53 +00:00
cd9c6ce36e
I18N: Merge duplicate "Add Comment" strings.
...
Props ramiy.
Fixes #47246 .
Built from https://develop.svn.wordpress.org/trunk@45441
git-svn-id: http://core.svn.wordpress.org/trunk@45252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 18:43:52 +00:00
dd7956c674
I18N: Use consistent error messages when importing or exporting content.
...
Props ramiy.
Fixes #42269 .
Built from https://develop.svn.wordpress.org/trunk@45440
git-svn-id: http://core.svn.wordpress.org/trunk@45251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 18:09:52 +00:00
702f7d4e8d
I18N: Merge duplicate "not allowed to manage options" strings.
...
Props ramiy.
Fixes #42271 .
Built from https://develop.svn.wordpress.org/trunk@45439
git-svn-id: http://core.svn.wordpress.org/trunk@45250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 16:00:52 +00:00
b97a2d4366
I18N: Merge duplicate "Loading..." strings.
...
Props ramiy.
Fixes #47248 .
Built from https://develop.svn.wordpress.org/trunk@45438
git-svn-id: http://core.svn.wordpress.org/trunk@45249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:46:52 +00:00
21a12ce6cd
I18N: Merge similar strings in Edit Media help tabs.
...
Props ramiy.
Fixes #46919 .
Built from https://develop.svn.wordpress.org/trunk@45437
git-svn-id: http://core.svn.wordpress.org/trunk@45248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:38:53 +00:00
9f4c2fcbae
I18N: Merge duplicate "Try Again" strings.
...
Props ramiy.
Fixes #47251 .
Built from https://develop.svn.wordpress.org/trunk@45433
git-svn-id: http://core.svn.wordpress.org/trunk@45244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 14:40:51 +00:00
6c50f22e4e
I18N: Remove unnecessary markup from plugin action messages, for consistency with the rest of the admin.
...
Props ramiy.
Fixes #47238 .
Built from https://develop.svn.wordpress.org/trunk@45432
git-svn-id: http://core.svn.wordpress.org/trunk@45243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 14:36:51 +00:00
f5db16738e
Administration: Merge similar "file does not exist" messages in plugin and theme editors.
...
Props ramiy.
Fixes #47249 .
Built from https://develop.svn.wordpress.org/trunk@45431
git-svn-id: http://core.svn.wordpress.org/trunk@45242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 12:35:51 +00:00
c77e771c84
Date/Time: Replace all instances of `date()` with `gmdate()`.
...
Use of `date()` in core depends on PHP timezone set to UTC and not changed by third party code (which cannot be guaranteed).
`gmdate()` is functionally equivalent, but is not affected by PHP timezone setting: it's always UTC, which is the exact behavior the core needs.
Props nielsdeblaauw, Rarst.
Fixes #46438 . See #44491 .
Built from https://develop.svn.wordpress.org/trunk@45424
git-svn-id: http://core.svn.wordpress.org/trunk@45235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 00:12:54 +00:00
fc17576fd2
Accessibility: Improve toggling the "Post locked" information visibility.
...
- effectively hides the "Post locked" information from assistive technologies
- when a post is locked, reveals the "Post locked" information without CSS animation
- the height CSS animation didn't work anyways after [24906]
See #24553 .
Fixes #44946 .
Built from https://develop.svn.wordpress.org/trunk@45417
git-svn-id: http://core.svn.wordpress.org/trunk@45228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 17:15:52 +00:00
48d9d94881
Accessibility: Improve settings tables and forms after [45403].
...
- adds `role="presentation"` to the edit comment table
- removes a few pointless `<fieldset>` elements
- adds a few missing `<label>` elements
- adds the CSS class `class="td-full"` to table rows spanning to multiple cells
- adds explicit `scope="row"` attribute to the table headers in `options-permalink.php`: this table is better communicated as data table
- uses consistent label association in the "Privacy Settings" page
- in the installation page "Set up your database connection": associates descriptions to their inout fields using `aria-describedby`
- improves the link to gravatar.com in the `user-edit.php` page
See #46899 .
Fixes #47390 .
Built from https://develop.svn.wordpress.org/trunk@45416
git-svn-id: http://core.svn.wordpress.org/trunk@45227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 15:19:53 +00:00
00c60ccd33
CSS Coding Standards: Update unitless values for `line-height` in `wp-admin/css/widgets.css` with more precise calculations.
...
Props ianbelanger.
Fixes #46531 .
Built from https://develop.svn.wordpress.org/trunk@45415
git-svn-id: http://core.svn.wordpress.org/trunk@45226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:44:52 +00:00
962da3db60
CSS Coding Standards: Update unitless values for `line-height` in `wp-admin/css/nav-menus.css` with more precise calculations.
...
Props ianbelanger.
Fixes #46516 .
Built from https://develop.svn.wordpress.org/trunk@45414
git-svn-id: http://core.svn.wordpress.org/trunk@45225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:42:52 +00:00
693e90ac81
Editor: In `edit-form-blocks.php`, check the result of `wp_set_post_lock()`, which may return `false` and cause a warning when passed to `implode()`.
...
Props kakshak, aduth.
Fixes #47013 .
Built from https://develop.svn.wordpress.org/trunk@45413
git-svn-id: http://core.svn.wordpress.org/trunk@45224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:35:52 +00:00
35a2322d32
General: Update support forum links.
...
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/ .
This is a follow-up to [45140], which changed the links in help tabs.
Props dilipbheda.
Fixes #47239 . See #46790 .
Built from https://develop.svn.wordpress.org/trunk@45412
git-svn-id: http://core.svn.wordpress.org/trunk@45223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:24:50 +00:00
add6a8e13f
Accessibility: Fix the headings hierarchy in the legacy Custom Background and Custom Header pages.
...
Fixes #47386 .
Built from https://develop.svn.wordpress.org/trunk@45411
git-svn-id: http://core.svn.wordpress.org/trunk@45222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 13:32:53 +00:00
ca028cfc4c
Users: Allow Super Admins to remove themselves from a site on a Multisite network.
...
Props Mista-Flo, birgire
Fixes #41439
Built from https://develop.svn.wordpress.org/trunk@45407
git-svn-id: http://core.svn.wordpress.org/trunk@45218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 00:13:53 +00:00
b77cf42c0b
Accessibility: Make sure layout tables across the admin are correctly linearized.
...
Adds `role="presentation"` to the `<table>` elements used for layout purposes.
Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.
Props greatislander, afercia.
Fixes #46899 .
Built from https://develop.svn.wordpress.org/trunk@45403
git-svn-id: http://core.svn.wordpress.org/trunk@45214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 21:56:54 +00:00
01917b9f74
I18N: Add a language icon next to language selectors.
...
This change means that users who can't read the site's current language can more easily identify controls that allow them to change either the site language or their own admin area language.
Props janak007, atlasmahesh, afercia, birgire, JoshuaWold
Fixes #43144
Built from https://develop.svn.wordpress.org/trunk@45402
git-svn-id: http://core.svn.wordpress.org/trunk@45213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 20:43:52 +00:00
53794e9719
Administration: Replace references to "articles" with "posts" for greater consistency of terminology.
...
Props angelagibson
Fixes #38517
Built from https://develop.svn.wordpress.org/trunk@45401
git-svn-id: http://core.svn.wordpress.org/trunk@45212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 19:18:51 +00:00
729d4a4942
I18N: Remove PHP function name from translatable string in `WP_Debug_Data`.
...
Props ramiy.
Fixes #47254 .
Built from https://develop.svn.wordpress.org/trunk@45399
git-svn-id: http://core.svn.wordpress.org/trunk@45210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:41:52 +00:00
a36f5d2295
Docs: Fix typos in DocBlocks and comments in `wp-admin/includes/file.php`.
...
Props mukesh27.
Fixes #47026 .
Built from https://develop.svn.wordpress.org/trunk@45394
git-svn-id: http://core.svn.wordpress.org/trunk@45205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:08:51 +00:00
726e77d97e
Networks and Sites: Readjust tabs in `wp-admin/includes/network.php` for (more or less) consistent alignment.
...
See #47062 .
Built from https://develop.svn.wordpress.org/trunk@45391
git-svn-id: http://core.svn.wordpress.org/trunk@45202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 23:35:52 +00:00
139225ad7a
Networks and Sites: Remove extra whitespace in `.htaccess` rules on Network Setup page.
...
Props riddhiehta02 for initial patch, sebastienserre, masterforwordpress.
Fixes #47062 .
Built from https://develop.svn.wordpress.org/trunk@45390
git-svn-id: http://core.svn.wordpress.org/trunk@45201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 23:28:53 +00:00
239a159ad2
Administration: Don't apply italic formatting to code blocks in setting descriptions.
...
Props chetan200891
Fixes #42651
Built from https://develop.svn.wordpress.org/trunk@45389
git-svn-id: http://core.svn.wordpress.org/trunk@45200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 23:14:53 +00:00
f2ef36bb2d
I18N: Use a complete translatable string for the "Delete My Site" email subject.
...
Props thrijith
Fixes #46855
Built from https://develop.svn.wordpress.org/trunk@45387
git-svn-id: http://core.svn.wordpress.org/trunk@45198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 22:15:54 +00:00
e32389fc04
I18N: Capitalize "Privacy Policy Page" heading to merge two similar strings.
...
Props ramiy, garrett-eclipse.
Fixes #47250 .
Built from https://develop.svn.wordpress.org/trunk@45384
git-svn-id: http://core.svn.wordpress.org/trunk@45195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 21:11:52 +00:00
a3c363f8c2
I18N: Make punctuation in some `wp-admin` strings more consistent.
...
Props pedromendonca.
Fixes #47358 .
Built from https://develop.svn.wordpress.org/trunk@45382
git-svn-id: http://core.svn.wordpress.org/trunk@45193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 01:12:53 +00:00
3b926e0b47
Upgrade/Install: As a follow-up to [45357], when linking to Update PHP support page in error messages, check if `wp_get_update_php_url()` and `wp_get_update_php_annotation()` exist.
...
`wp-admin/includes/update-core.php` runs in the context of the previous WordPress version. Any calls to newly introduced functions there need to be checked via `function_exists()`.
Reviewed by desrosj, earnjam, SergeyBiryukov.
Props dd32, imath.
Fixes #47323 .
Built from https://develop.svn.wordpress.org/trunk@45365
git-svn-id: http://core.svn.wordpress.org/trunk@45176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-20 14:29:55 +00:00
f72cb6dc83
Upgrade/Install: Improve error messages displayed when WordPress update fails due to an incompatible PHP version by linking to the Update PHP support page.
...
Additionally, fix a regression in [44451] where the error message in `wp-admin/upgrade.php` was prepared, but never displayed.
Props afragen, netweb, hareesh-pillai, SergeyBiryukov.
Fixes #46937 .
Built from https://develop.svn.wordpress.org/trunk@45357
git-svn-id: http://core.svn.wordpress.org/trunk@45168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 18:11:51 +00:00
e68fe165ae
Site Health: In PHP modules test description, move the space before the screen reader text out from the translatable string.
...
Props ocean90, tobifjellner.
Fixes #47161 .
Built from https://develop.svn.wordpress.org/trunk@45346
git-svn-id: http://core.svn.wordpress.org/trunk@45157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 11:50:58 +00:00
1d730f20e5
Upgrade/Install: Don't run signature verify on slow 32-bit systems.
...
The sodium_compat library can be very slow for certain operations on 32-bit architectures, which can lead to web server timeouts while attempting to verify an update. This adds a runtime speed check to skip signature verification on systems that would otherwise time out. Includes simple unit tests.
Props dd32, paragoninitiativeenterprises.
See #47186 .
Built from https://develop.svn.wordpress.org/trunk@45345
git-svn-id: http://core.svn.wordpress.org/trunk@45156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 11:06:53 +00:00
00255ae0be
Help/About: Restore placeholder for WordPress version in tagline on About, Credits, and Freedoms pages to include minor versions.
...
Props desrosj, mukesh27.
Fixes #46408 .
Built from https://develop.svn.wordpress.org/trunk@45338
git-svn-id: http://core.svn.wordpress.org/trunk@45149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 01:08:53 +00:00
cbad1109f4
Site Health: Use correct singular string for plugin and theme version tests.
...
Props edocev, Presskopp.
Fixes #47264 .
Built from https://develop.svn.wordpress.org/trunk@45336
git-svn-id: http://core.svn.wordpress.org/trunk@45147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 01:00:54 +00:00
4236a3522d
I18N: Avoid using placeholders for link start and end tags in alt text description strings added in [45158].
...
Use an established pattern of moving additional link attributes out of the translatable string.
Props dimadin.
Fixes #47159 .
Built from https://develop.svn.wordpress.org/trunk@45334
git-svn-id: http://core.svn.wordpress.org/trunk@45145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 00:53:54 +00:00
a9fc042377
Site Health: In PHP modules test, ensure the description is translated as a whole sentence, not as separate string parts.
...
Props dimadin, SergeyBiryukov.
Fixes #47161 .
Built from https://develop.svn.wordpress.org/trunk@45331
git-svn-id: http://core.svn.wordpress.org/trunk@45142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 00:07:54 +00:00
9c1a666249
Site Health: In HTTP requests test, when checking whether the `WP_HTTP_BLOCK_EXTERNAL` constant is defined, check its value as well.
...
Props chesio.
Fixes #47297 .
Built from https://develop.svn.wordpress.org/trunk@45328
git-svn-id: http://core.svn.wordpress.org/trunk@45139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 22:08:54 +00:00
c6da25fa9a
Privacy: Prevent email field for personal data requests from overflowing.
...
Props anischarolia, ianbelanger, afercia.
Fixes #46961 .
Built from https://develop.svn.wordpress.org/trunk@45326
git-svn-id: http://core.svn.wordpress.org/trunk@45137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 20:45:54 +00:00
1ef254a465
Menus: Fix alignment of menu actions on mobile.
...
In [41197], changes were made to improve the responsive view for the Menu Name field and Save buttons. This caused the Delete Menu button to be misaligned.
Props ianbelanger, audrasjb, afercia, mukesh27.
Fixes #47173 .
Built from https://develop.svn.wordpress.org/trunk@45324
git-svn-id: http://core.svn.wordpress.org/trunk@45135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 19:05:53 +00:00
ca7c9a8288
Site Health: Improve alignment and spacing for section headers.
...
This changes the CSS for Site Health headers to use flexbox, which helps ensure the text is vertically aligned center and consistently spaced in both the Status and Info tabs. It also fixes an issue where the loading spinner GIF was cut off on smaller screens (originally reported in #47203 .
Props Presskopp, odminstudios, kjellr, afercia, desrosj, hedgefield, ianbelanger, xavortm.
Fixes #47063 .
Built from https://develop.svn.wordpress.org/trunk@45322
git-svn-id: http://core.svn.wordpress.org/trunk@45133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 18:30:53 +00:00
f48f926077
Site Health: Improve vertical alignment of icons in test result descriptions.
...
This change removes redundant CSS properties for different health check statuses in favor of utilizing the `.dashicons` class already in Core to define them more consistently. This also fixes the vertical alignment issues.
Props chetan200891, Clorith, desrosj.
Fixes #46940 .
Built from https://develop.svn.wordpress.org/trunk@45309
git-svn-id: http://core.svn.wordpress.org/trunk@45120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 14:26:07 +00:00
7d04482650
Site Health: Link to the correct plugin update screen in multisite installs.
...
Props Clorith, sebastienserre, jeremyfelt, desrosj.
Fixes #47189 .
Built from https://develop.svn.wordpress.org/trunk@45308
git-svn-id: http://core.svn.wordpress.org/trunk@45119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 14:13:05 +00:00
1b3b04f354
Accessibility: Improve the "skip links" position for medium and small screens.
...
Fixes #47065 .
Built from https://develop.svn.wordpress.org/trunk@45301
git-svn-id: http://core.svn.wordpress.org/trunk@45110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 21:12:02 +00:00
9cc696fbce
Accessibility: Add `aria-current` to the links in the `<nav>` elements introduced in [44905].
...
Also fixes a few translators comments and coding standards.
Props audrasjb.
Fixes #47106 .
Built from https://develop.svn.wordpress.org/trunk@45300
git-svn-id: http://core.svn.wordpress.org/trunk@45109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 20:58:54 +00:00
d0f46bf73c
I18N: Combine similar strings with minor differences.
...
Props dimadin.
Fixes #47158 .
Built from https://develop.svn.wordpress.org/trunk@45298
git-svn-id: http://core.svn.wordpress.org/trunk@45107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 19:48:53 +00:00
71f9170c08
Administration: Prevent cards on the Tools page from overflowing on small screens.
...
Props anischarolia, mukesh27.
Fixes #46972 .
Built from https://develop.svn.wordpress.org/trunk@45296
git-svn-id: http://core.svn.wordpress.org/trunk@45105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 14:56:56 +00:00
bfcd57d327
Help/About: Update the 5.2 tagline on Freedoms and Credits.
...
Props ocean90.
See #46901 .
Built from https://develop.svn.wordpress.org/trunk@45292
git-svn-id: http://core.svn.wordpress.org/trunk@45101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 20:00:54 +00:00
c4062c75a7
Help/About: Final 5.2 about page updates.
...
Use final image URLs and fix a bug in IE11 where images were being cut off.
Props afercia, SergeyBiryukov, ianbelanger, desrosj, audrasjb.
See #46901 .
Built from https://develop.svn.wordpress.org/trunk@45287
git-svn-id: http://core.svn.wordpress.org/trunk@45096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 17:19:55 +00:00
3360974ad2
Help/About: Polish the About page for 5.2.
...
- The About page now uses a CSS grid to layout its design, making the page’s structure more obvious and hopefully easier for contributors in the future.
- Removes some code that is no longer used (such as videos, mejs elements, etc.).
- Update images.
- Unnecessary HTML is removed from a string on the page. This was a regression.
- Only users with the correct capability should be instructed to check their site status.
- Fixes the placement of commas.
Reviewed by melchoyce, afercia, jeremyfelt, and desrosj.
Props ryelle, melchoyce, cathibosco1, man4toman, SergeyBiryukov, afercia, ramiy, kjellr, tellyworth, earnjam, andreamiddleton, marybaum.
See #46901 .
Built from https://develop.svn.wordpress.org/trunk@45278
git-svn-id: http://core.svn.wordpress.org/trunk@45087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 15:44:53 +00:00
d53659ed71
Help/About: Fix tab display issues.
...
This change restores About page tab heights and fixes bugs with the tab bottom border caused by [44905] and [45243].
Reviewed by SergeyBiryukov and desrosj.
Props ixkaito, ianbelanger, afercia, SergeyBiryukov.
See #46901 .
Fixes #47075 .
Built from https://develop.svn.wordpress.org/trunk@45276
git-svn-id: http://core.svn.wordpress.org/trunk@45085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 10:37:51 +00:00
6ac1d4ec1a
Site Health: Disable recommendations that could be problematic on multisite installs.
...
When viewing Site Health for a multisite install, there are a few recommendations that are not appropriate and could have negative implications for other sites on the install if the administrator follows the advice provided.
For example, Site Health recommends that inactive plugins and themes for a site should be removed. On a single site install, this is a great recommendation. However, on a multisite install, inactive plugins and themes for one site should not be removed because they could be active for other sites on the network.
This change also disables the `test_wp_version_check_attached()` test for multisite. This test checks for the presence of the `wp_version_check()` function on the `wp_version_check` hook, which is not present for every site on multisite.
Reviewed by jeremyfelt and desrosj.
Props iandunn, Clorith, azaozz, jeremyfelt.
Fixes #47084 .
Built from https://develop.svn.wordpress.org/trunk@45275
git-svn-id: http://core.svn.wordpress.org/trunk@45084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-01 18:08:53 +00:00
e4a0fd4c01
Admin: Add some additional clarity to some about page links
...
It's important for links to have enough information in them in order to be clearly actionable. Destination and purpose should be clear. For example, `debug` isn't nearly as useful as `learn how to debug issues`.
This was signed off on by chanthaboune and jorbin.
Props afercia.
See: #46901 .
Built from https://develop.svn.wordpress.org/trunk@45274
git-svn-id: http://core.svn.wordpress.org/trunk@45083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-30 17:31:55 +00:00
d86524f09d
Admin: Add the text for the WordPress 5.2 About page.
...
This changes includes placeholder images for now, they'll be replaced by the final images before final release.
Props chanthaboune, melchoyce, karmatosed, pento, marybaum, birgire, earnjam, andreamiddleton.
See #46901 .
Built from https://develop.svn.wordpress.org/trunk@45271
git-svn-id: http://core.svn.wordpress.org/trunk@45080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 00:57:53 +00:00
8b333f8c20
Docs: Use 3-digit, x.x.x style semantic versioning for `@since 5.2.0` entries in `wp-admin/includes/file.php`.
...
See #46543 .
Built from https://develop.svn.wordpress.org/trunk@45266
git-svn-id: http://core.svn.wordpress.org/trunk@45075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 23:36:51 +00:00
ed802428e3
Upgrade/install: fix verification bugs and scale back signature checks.
...
This fixes several bugs in the signature verification code:
Disables signature checks on certain incompatible PHP versions that cause math errors when opcache is enabled;
Prevents a spurious URL and subsequent error when downloading a zip file with query arguments;
Prevents errors triggered by third-party upgrade scripts as per #46615 ;
Disables signature tests for Plugins, Themes, and Translations, leaving only core updates.
At the 5.2 release the API servers will only provide signatures for core update packages, which is why messages are suppressed for plugins and other package types. Signatures for those other items will become available later.
Props dd32.
See #39309 , #46615
Built from https://develop.svn.wordpress.org/trunk@45262
git-svn-id: http://core.svn.wordpress.org/trunk@45071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-24 07:44:51 +00:00
0da8c2265f
Site Health: Fix count of inactive themes and the recommendation to remove them when the default theme is active or is a parent of the active child theme.
...
Props sudhiryadav, ianbelanger, mukesh27, azaozz.
Fixes #46900 .
Built from https://develop.svn.wordpress.org/trunk@45260
git-svn-id: http://core.svn.wordpress.org/trunk@45069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 21:37:53 +00:00
2548263bac
Site Health: Allow some HTML (inline tags only) in the section descriptions. Add some more docs about expected formatting of the gathered data.
...
Props kraftbj, jeherve, mukesh27, audrasjb, azaozz.
Fixes #46878 .
Built from https://develop.svn.wordpress.org/trunk@45259
git-svn-id: http://core.svn.wordpress.org/trunk@45068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 21:05:52 +00:00
bd9421104a
Networks and Sites: Use correct escaping function for classes added via ` ms_user_list_site_class` filter.
...
Props david.binda.
Fixes #46990 . See #41146 .
Built from https://develop.svn.wordpress.org/trunk@45252
git-svn-id: http://core.svn.wordpress.org/trunk@45061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-19 13:51:51 +00:00
2d58638ba0
Site Health: Fix debug data with nested fields for copying.
...
* Use `$debug_data` instead of `$field['value']` to retrieve the debug data.
* Rename inner variables to avoid overriding the output variable.
Props Clorith, ocean90.
See #46573 .
Built from https://develop.svn.wordpress.org/trunk@45246
git-svn-id: http://core.svn.wordpress.org/trunk@45055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 16:26:51 +00:00
3e6183c69c
Site Health: Provide context for tab headings to be able to distinguish them from existing strings.
...
See #46573 .
Built from https://develop.svn.wordpress.org/trunk@45245
git-svn-id: http://core.svn.wordpress.org/trunk@45054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 16:06:51 +00:00
6fcd281707
CSS: Remove the units from `line-height` properties in `common.css`.
...
Props ianbelanger, talldanwp.
Fixes #46493 .
Built from https://develop.svn.wordpress.org/trunk@45243
git-svn-id: http://core.svn.wordpress.org/trunk@45052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 06:02:53 +00:00
3a0563e853
Site Health info tab: fix replacing the size strings in the copied info.
...
Props xkon.
See #46707 .
Built from https://develop.svn.wordpress.org/trunk@45241
git-svn-id: http://core.svn.wordpress.org/trunk@45050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 04:51:52 +00:00
9659676fca
Site Health info tab: Remove the "Directories and Sizes" section on Multisite installations. Most of the info shown there doesn't apply for multisite.
...
Props xkon, desrosj, azaozz.
Built from https://develop.svn.wordpress.org/trunk@45239
git-svn-id: http://core.svn.wordpress.org/trunk@45048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-18 00:34:51 +00:00
2a5c2a2cce
Site health info tab: replace "Not calculated" with "Loading..." in the "Directories and Sizes" section (that's an existing string and wouldn't cause problems for translators).
...
See #46707 .
Built from https://develop.svn.wordpress.org/trunk@45237
git-svn-id: http://core.svn.wordpress.org/trunk@45046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 21:26:52 +00:00
23de32062e
Site Health: Allow any callable added via `site_status_tests` filter to return test results for direct tests.
...
Async tests still need to be a string for the AJAX action.
Props kraftbj.
Fixes #46836 .
Built from https://develop.svn.wordpress.org/trunk@45234
git-svn-id: http://core.svn.wordpress.org/trunk@45043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 14:35:50 +00:00
1be34a234f
Docs: Remove `@global` tag for `$wpdb` from `wp-admin/install.php` and `wp-admin/upgrade.php`.
...
Per the documentation standards, the `@global` tag is meant to list PHP globals used within functions or methods.
The code in question uses the variable in global namespace, but does not explicitly declare it.
Props jayupadhyay01, dswebsme.
Fixes #46602 .
Built from https://develop.svn.wordpress.org/trunk@45233
git-svn-id: http://core.svn.wordpress.org/trunk@45042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 14:07:53 +00:00
d2ccaacedf
Docs: Correct spelling in various comments and DocBlocks, per the conventions in Core Contributor Handbook.
...
Props man4toman, samanehmirrajabi.
Fixes #45857 .
Built from https://develop.svn.wordpress.org/trunk@45232
git-svn-id: http://core.svn.wordpress.org/trunk@45041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 13:26:51 +00:00
604769cca5
Site Health: Group `WP_DEBUG`-related constants together.
...
Props tmatsuur.
Fixes #46955 .
Built from https://develop.svn.wordpress.org/trunk@45230
git-svn-id: http://core.svn.wordpress.org/trunk@45039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 12:00:54 +00:00
d89a302503
Site Health: Improve the accordions styles for small screens.
...
Also, changes the hex color values to lowercase.
Props subrataemfluence, man4toman, garrett-eclipse, chetan200891, mukesh27, melchoyce, karmatosed, Clorith.
Fixes #46949 .
Built from https://develop.svn.wordpress.org/trunk@45229
git-svn-id: http://core.svn.wordpress.org/trunk@45038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 11:00:53 +00:00
65ab4e7607
Site Health: Remove title attribute from the directory sizes spinner.
...
Amends [45176].
See #46707 .
Built from https://develop.svn.wordpress.org/trunk@45228
git-svn-id: http://core.svn.wordpress.org/trunk@45037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 10:09:52 +00:00
4ead9880b0
Accessibility: Make the Tags meta box better support Input Method Editor (IME) converters.
...
Also, restores the keyboard interaction behavior prior to [41988] by requesting one single Enter key press to add a tag.
Props ryanshoover, miyauchi.
Fixes #45371 .
Built from https://develop.svn.wordpress.org/trunk@45227
git-svn-id: http://core.svn.wordpress.org/trunk@45036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 07:18:51 +00:00
74e9c3d20d
Docs: Improve documentation for various `WP_Filesystem_Base` methods and extending classes.
...
Props jaydeep-rami, man4toman, SaeedFard, mukesh27, mohadeseghasemi, ebrahimzadeh, juiiee8487, SergeyBiryukov.
Fixes #42227 , #46806 , #46840 . See #46543 .
Built from https://develop.svn.wordpress.org/trunk@45226
git-svn-id: http://core.svn.wordpress.org/trunk@45035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 04:13:51 +00:00
f807a098b1
Administration: Improve the accuracy of `is_block_editor()`.
...
Currently, there are a number of scenarios where `is_block_editor()` (and `WP_Screen::is_block_editor`) would incorrectly indicate block editor support at different points of the loading process. Most notably, checking `is_block_editor` when hooking into the `current_screen` action will always result in `false`, even when the block editor is being loaded. This is because `is_block_editor` is not set to `true` until `edit-form-blocks.php` is included.
This change adds logic to `WP_Screen` to ensure the accuracy of `is_block_editor` on block editor pages earlier in the load process.
While edit screens will now be accurate 100% of the time from `current_screen` on, there are still a few edge cases where `is_block_editor` could contain an incorrect value when creating a new post.
Because a `WP_Post` object is a required parameter for the `replace_editor` filter and `use_block_editor_for_post()` function, `WP_Screen` will fall back to the value returned by `use_block_editor_for_post_type()` for the post being created. To eliminate these edge cases, the `use_block_editor_for_post_type` filter can be used to return the appropriate boolean value to indicate support.
Props Chouby, desrosj, aduth, johnbillion.
Fixes #46195 .
Built from https://develop.svn.wordpress.org/trunk@45224
git-svn-id: http://core.svn.wordpress.org/trunk@45033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 01:56:52 +00:00
893be2cf11
Site Health: Remove reference to an undefined variable in `WP_Site_Health_Auto_Updates::test_constants()`.
...
Props diddledan.
Fixes #46952 .
Built from https://develop.svn.wordpress.org/trunk@45223
git-svn-id: http://core.svn.wordpress.org/trunk@45032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 01:10:52 +00:00
01dec9af0b
Docs: Fix typo in `WP_Site_Health_Auto_Updates::test_constants()` description.
...
See #46543 .
Built from https://develop.svn.wordpress.org/trunk@45222
git-svn-id: http://core.svn.wordpress.org/trunk@45031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 01:00:51 +00:00
6ad0bf33ec
PHPCS: Fix WPCS violations in [45220].
...
See #46707 .
Built from https://develop.svn.wordpress.org/trunk@45221
git-svn-id: http://core.svn.wordpress.org/trunk@45030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-17 00:45:50 +00:00
9a316c6ea4
Site health, info tab:
...
- Change `recurse_dirsize()` to accept an array of excluded paths.
- Change so we don't calculate the sizes of dirs in wp-content twice.
- Add the size in bytes to the "debug" into.
- Add a custom DOM event after the dir sizes request is done. Can be used by plugins to "daisy chain" more requests.
- Move "WordPress directory location" and "WordPress directory size" to the top in the "Directories and Sizes" section.
- Move "Theme directory location" to the "Active Theme" section.
- Fix labels capitalization.
Props xkon, afercia, Clorith, azaozz.
Fixes #46707 .
Built from https://develop.svn.wordpress.org/trunk@45220
git-svn-id: http://core.svn.wordpress.org/trunk@45029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 23:02:51 +00:00
8e9315f51e
Media: move `get_available_post_mime_types` to `wp-includes/post.php` making it more generally available.
...
Address an issue since r44947 where calling `wp_enqueue_media` on the front-end would result in a PHP fatal.
Props david.binda.
Fixes #46795 .
Built from https://develop.svn.wordpress.org/trunk@45219
git-svn-id: http://core.svn.wordpress.org/trunk@45028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 20:30:51 +00:00
fc7a8f7194
Administration: Improve the Site Health "Passed tests" button style for small screens.
...
Props chetan200891.
Fixes #46939 .
Built from https://develop.svn.wordpress.org/trunk@45217
git-svn-id: http://core.svn.wordpress.org/trunk@45026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 16:23:52 +00:00
c28e516c80
Export: Remove extra whitespace from `<title>`, `<content:encoded>`, and `<excerpt:encoded>` elements in WXR files.
...
Props sgastard, juliarrr, aristath, SergeyBiryukov.
Fixes #46575 .
Built from https://develop.svn.wordpress.org/trunk@45216
git-svn-id: http://core.svn.wordpress.org/trunk@45025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 15:57:53 +00:00
6efa2cd724
I18N: Fix typo in a translator comment.
...
See #46920 .
Built from https://develop.svn.wordpress.org/trunk@45207
git-svn-id: http://core.svn.wordpress.org/trunk@45016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 23:56:52 +00:00
d4d1267847
I18N: Improvements to and additions of translator comments for various email subject strings.
...
Props ramiy
Fixes #46920
Built from https://develop.svn.wordpress.org/trunk@45204
git-svn-id: http://core.svn.wordpress.org/trunk@45013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 22:39:50 +00:00
df276c333a
Administration: Update chevron color in Site Health.
...
Props afercia.
Fixes #46934 . See #46730 .
Built from https://develop.svn.wordpress.org/trunk@45202
git-svn-id: http://core.svn.wordpress.org/trunk@45011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 18:56:54 +00:00
10239ba45d
Administration: Add a chevron icon to the Site Health "Passed tests" button.
...
The chevron icon helps clarify what the button does.
Props garrett-eclipse, Clorith, xkon, melchoyce.
Fixes #46730 .
Built from https://develop.svn.wordpress.org/trunk@45201
git-svn-id: http://core.svn.wordpress.org/trunk@45010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 18:01:53 +00:00
5ac2b28396
Administration: Provide translatable strings for the Site Health comment status report.
...
Props ocean90.
Fixes #46909 .
Built from https://develop.svn.wordpress.org/trunk@45200
git-svn-id: http://core.svn.wordpress.org/trunk@45009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 15:08:51 +00:00
5b530e903d
Site Health: Add missing translator comments.
...
Amends [45178].
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45199
git-svn-id: http://core.svn.wordpress.org/trunk@45008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-15 14:39:55 +00:00
b0ef0ae305
Site health: Improve jQuery selectors so that they don't depend on a specific markup.
...
Amends [45178].
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45198
git-svn-id: http://core.svn.wordpress.org/trunk@45007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-14 14:30:51 +00:00
a9542cd60a
Coding standards: Site health: Avoid to use `var` in the middle of JavaScript function blocks.
...
Amends [45178].
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45197
git-svn-id: http://core.svn.wordpress.org/trunk@45006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-14 13:49:55 +00:00
394d3b2f9b
Site Health: Merge duplicate "utf8mb4 requires a newer client library" strings.
...
Props ramiy.
Fixes #46917 .
Built from https://develop.svn.wordpress.org/trunk@45196
git-svn-id: http://core.svn.wordpress.org/trunk@45005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 18:18:52 +00:00
f94f0684b1
Site Health: Merge duplicate "Error" strings.
...
Props ramiy.
Fixes #46915 .
Built from https://develop.svn.wordpress.org/trunk@45195
git-svn-id: http://core.svn.wordpress.org/trunk@45004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 18:12:52 +00:00
38f3607c53
Users: Merge duplicate "Download failed" strings.
...
Props ramiy.
Fixes #46914 .
Built from https://develop.svn.wordpress.org/trunk@45194
git-svn-id: http://core.svn.wordpress.org/trunk@45003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 18:08:52 +00:00
cbe1c88485
Site Health: Merge duplicate "Latest version" strings.
...
Props ramiy.
Fixes #46913 .
Built from https://develop.svn.wordpress.org/trunk@45193
git-svn-id: http://core.svn.wordpress.org/trunk@45002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 18:04:52 +00:00
845977ed1f
Site Health: Merge duplicate "Learn more about updating PHP" strings.
...
Props ramiy.
Fixes #46912 .
Built from https://develop.svn.wordpress.org/trunk@45192
git-svn-id: http://core.svn.wordpress.org/trunk@45001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 17:59:52 +00:00
b6471e9be4
Bootstrap/Load: Remove duplicate leading slashes on inclusion of various files under `ABSPATH`.
...
Props dmsnell, birgire, szepe.viktor.
Fixes #46327 .
Built from https://develop.svn.wordpress.org/trunk@45190
git-svn-id: http://core.svn.wordpress.org/trunk@44999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 04:46:52 +00:00
b2a9bb4e78
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/customize-controls.css`.
...
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46494 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45189
git-svn-id: http://core.svn.wordpress.org/trunk@44998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 04:36:51 +00:00
77ff117d7f
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/themes.css`.
...
Props ianbelanger, mukesh27, audrasjb, pbiron, afercia.
Fixes #46518 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45188
git-svn-id: http://core.svn.wordpress.org/trunk@44997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 04:32:51 +00:00
5fe5733f38
CSS Coding Standards: Use unitless values for `line-height` for count bubbles in `wp-admin/css/admin-menu.css`.
...
Missed in [45186].
Props ianbelanger.
See #46489 , #44643 .
Built from https://develop.svn.wordpress.org/trunk@45187
git-svn-id: http://core.svn.wordpress.org/trunk@44996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 04:20:50 +00:00
b76772b9a7
CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/admin-menu.css`.
...
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46489 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45186
git-svn-id: http://core.svn.wordpress.org/trunk@44995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-13 00:17:50 +00:00
88fdfae793
Plugins: Introduce `is_wp_version_compatible()` and `is_php_version_compatible()` for checking compatibility with the current WordPress or PHP version.
...
Props afragen.
Fixes #46599 .
Built from https://develop.svn.wordpress.org/trunk@45185
git-svn-id: http://core.svn.wordpress.org/trunk@44994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 23:56:52 +00:00
a2e273944a
Plugins: In `list_plugin_updates()`, only display the annotation and the surrounding tags if it's not empty.
...
Props afragen.
Fixes #46680 .
Built from https://develop.svn.wordpress.org/trunk@45184
git-svn-id: http://core.svn.wordpress.org/trunk@44993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 21:52:52 +00:00
41022dc6f2
Privacy: Remove unnecessary translation from help notice action label.
...
As static markup, the Privacy Policy editor help notice link no longer needs to be translateable with the revisions included in [45174].
Props garrett-eclipse.
Fixes #46098 . See [45174].
Built from https://develop.svn.wordpress.org/trunk@45180
git-svn-id: http://core.svn.wordpress.org/trunk@44989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 20:44:52 +00:00
7e4b4e1089
Site Health: Use `_n()` for `%s Items with no issues detected` string, missed in [45178].
...
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45179
git-svn-id: http://core.svn.wordpress.org/trunk@44988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 20:40:51 +00:00
1ae11820fc
Site Health: i18n audit, take 2.
...
* Use `wp.i18n` to translate JavaScript strings.
* Use `_n()` for proper plural forms support.
Props TimothyBlynJacobs, ocean90, afercia.
Fixes #46683 .
Built from https://develop.svn.wordpress.org/trunk@45178
git-svn-id: http://core.svn.wordpress.org/trunk@44987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 20:34:51 +00:00
30ccfd540f
Site health: Load the "Info" tab immediately and notify the user while gathering site data. Changes the Info tab to work similarly to the Status tab: it does separate request to fetch the directories sizes and doesn't "block" the loading of the page.
...
Props xkon, afercia, Clorith, azaozz.
See #46707 .
Built from https://develop.svn.wordpress.org/trunk@45176
git-svn-id: http://core.svn.wordpress.org/trunk@44985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 19:24:51 +00:00
105277f93e
Administration: Move “Recovery Mode” to the beginning of the document title.
...
This improves accessibility, ensuring users utilizing screen readers are informed that the site is in recovery mode.
Props: afercia, TimothyBlynJacobs.
See #46608 .
Built from https://develop.svn.wordpress.org/trunk@45175
git-svn-id: http://core.svn.wordpress.org/trunk@44984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 19:05:51 +00:00
7f456cab7d
Privacy: Display help notice on block editor screen.
...
Use the Notices data module when viewing the block editor screen for the assigned Privacy Policy page to display a help notice.
Props garrett-eclipse, joen, xkon.
Fixes #46098 .
Built from https://develop.svn.wordpress.org/trunk@45174
git-svn-id: http://core.svn.wordpress.org/trunk@44983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 18:19:51 +00:00
77e87830ae
TinyMCE: Fix keyboard navigation when the `dfw` button is present but hidden. Ensure that button is added last in the DOM to match where it appears visually.
...
Props afercia, azaozz.
Fixes #46640 .
Built from https://develop.svn.wordpress.org/trunk@45172
git-svn-id: http://core.svn.wordpress.org/trunk@44981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 18:08:53 +00:00
44d977b2af
Site Health: Correctly refer to an `.htaccess` file as hidden.
...
The preceding period (`.`) should always be included when referring to an `.htaccess` file.
Props: ianbelanger, garrett-eclipse, subrataemfluence, burhandodhy.
Fixes #46841 .
Built from https://develop.svn.wordpress.org/trunk@45171
git-svn-id: http://core.svn.wordpress.org/trunk@44980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 17:50:52 +00:00
6afe73667c
Site Health: Add missing actions to tests.
...
This change adds missing actions for several tests. This ensures that the user is provided with a next step, whenever possible.
Also, change the URL displayed in the WordPress.org communication test description to `api.wordpress.org` for accuracy.
Props: garrett-eclipse, Clorith, vaishalipanchal.
Fixes #46734 .
Built from https://develop.svn.wordpress.org/trunk@45170
git-svn-id: http://core.svn.wordpress.org/trunk@44979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 17:40:53 +00:00
5bafb4ea2d
Site Health: Improve the test badge implementation.
...
Label badges for each Site Health test currently display in either red, orange, or green, regardless of if the test passed or failed. This is confusing, as seeing red labels in the “Passed Test” section could alarm users (when really everything is OK and no action is required), and seeing green labels in the “Failed Tests” section would not appropriately encourage the user to take appropriate action.
This change makes several improvements to the label badges:
- Always right align the badges for consistent display.
- Remove background fill for badges. Instead, use a border.
- Use a consistent styling for all tests (passed and failed).
- The text color no longer uses true black (#000000 ).
- The `.badge.pink` CSS definition has been switched to `.badge.purple`, and the definitions for blue, gray, and green have also been updated to more closely follow the official WordPress color palette.
Props: pbiron, garrett-eclipse, hedgefield, Clorith, xkon, melchoyce, mdwolinski, alexdenning.
Fixes #46623 .
Built from https://develop.svn.wordpress.org/trunk@45169
git-svn-id: http://core.svn.wordpress.org/trunk@44978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 17:04:52 +00:00
e04ffc348b
Administration: Remove unnecessary numbered placeholders.
...
Props: tobifjellner, thrijith.
Fixes #46824 .
Built from https://develop.svn.wordpress.org/trunk@45167
git-svn-id: http://core.svn.wordpress.org/trunk@44976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 16:32:50 +00:00
501234ebe0
Site Health: Include both site and user locales in debug information.
...
Previously, only the site’s locale was displayed in the Site Health debug information. Moving forward, both the site’s default locale and the user’s locale will be specified.
This change also removes the `@param` tag for `WP_Debug_Data::debug_data()`. This parameter was previously removed in [45156].
Props: mukesh27, ianbelanger, Clorith, desrosj.
Fixes #46803 .
Built from https://develop.svn.wordpress.org/trunk@45166
git-svn-id: http://core.svn.wordpress.org/trunk@44975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 15:49:52 +00:00
8d04086af3
Upgrade/Install: Prevent plugin auto updates if PHP version requirements are not satisfied.
...
In [44937] and [44939], changes were made to prevent a user from updating any plugin that requires a higher version of PHP than the site is running. This compliments those changes to also prevent plugins from being auto updated when the same requirements are not met.
Props: TimothyBlynJacobs, davidbaumwald.
Fixes #46613 .
Built from https://develop.svn.wordpress.org/trunk@45165
git-svn-id: http://core.svn.wordpress.org/trunk@44974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 14:02:53 +00:00
8b0cc1c90f
Site Health: Clarify `WP_DEBUG` warning and translation contexts.
...
Clarifies that `WP_DEBUG` can cause `WP_DEBUG_DISPLAY` to be enabled,
and uses the constants themselves in related translation contexts.
Props mukesh27, ocean90, clorith, SergeyBiryukov, mikeschroder.
Fixes #46877 .
Built from https://develop.svn.wordpress.org/trunk@45164
git-svn-id: http://core.svn.wordpress.org/trunk@44973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-12 02:27:51 +00:00
2887cea50f
Accessibility: Improve the image "Alternative Text" field in the Edit Media screen.
...
Brings parity with the changes for the Media Views introduced in [44900].
- moves the alt text field to the top as first field
- adds an explanatory text with a link pointing to the W3C "alt decision tree" tutorial
- adds `aria-describedby` to target the explanatory text
- adjusts the CSS and indentation
Props chetan200891.
Fixes #46875 .
Built from https://develop.svn.wordpress.org/trunk@45158
git-svn-id: http://core.svn.wordpress.org/trunk@44967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-10 20:00:50 +00:00
f27917373c
Login and Registration: improve the CSS padding on the login input fields.
...
The right padding added in [44895] needs to be set only on the input fields in the Reset Password screen and exclude other login screens.
Amends [44895].
Fixes #42853 .
Built from https://develop.svn.wordpress.org/trunk@45157
git-svn-id: http://core.svn.wordpress.org/trunk@44966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-10 16:12:51 +00:00
8ffebab3e6
Site health: Fix gathering the site data twice on non-English locales. Introduces two sets of data:
...
- More verbose set used to generate the admin page.
- More concise set that is copied when clicking the "Copy the site info" button intended mostly for support and developers.
Props xkon, azaozz.
Fixes #46726 .
Built from https://develop.svn.wordpress.org/trunk@45156
git-svn-id: http://core.svn.wordpress.org/trunk@44965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-10 05:07:51 +00:00
447b956bb8
Site Health: Add missing i18n for “Copied!” string.
...
Props: Soean, mukesh27, davidbaumwald.
Fixes #46847 .
Built from https://develop.svn.wordpress.org/trunk@45155
git-svn-id: http://core.svn.wordpress.org/trunk@44964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-09 15:24:53 +00:00
dd0785d3f9
Privacy: Pass admin URLs for data export and erase forms through `esc_url()`.
...
Introduced in [45149].
Props: birgire.
Fixes #44047 .
Built from https://develop.svn.wordpress.org/trunk@45154
git-svn-id: http://core.svn.wordpress.org/trunk@44963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-09 14:07:51 +00:00
d6c90ca7d7
Privacy: Add a missing `<form>` action on the Export/Erasure screens.
...
This lack of action could cause an expired nonce to end up in the URL.
Props garrett-eclipse, saimonh, xkon.
Fixes #44047 .
Built from https://develop.svn.wordpress.org/trunk@45149
git-svn-id: http://core.svn.wordpress.org/trunk@44958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-09 00:08:54 +00:00
cbc0240cd6
Privacy: Only mark a personal data export as complete when the user downloads it.
...
An admin may download an export to check that it's all correct, but this action shouldn't mark the request as complete.
Props garrett-eclipse, JoshuaWold, birgire.
Fixes #44644 .
Built from https://develop.svn.wordpress.org/trunk@45148
git-svn-id: http://core.svn.wordpress.org/trunk@44957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-09 00:04:50 +00:00
johnjamesjacoby
Ella Iseulde Van Dorpe
Andrea Fercia
antpb
John Blackbourn
Dominik Schilling
Sergey Biryukov
desrosj
Adam Silverstein
Andrew Ozz
whyisjake
jorgefilipecosta
Aaron Jorbin
Felix Arntz
Mike Schroder
Gary Pendergast
Peter Wilson
Tammie Lister
atimmer
tellyworth
Mel Choyce
aduth