Commit Graph

91 Commits

Author SHA1 Message Date
Sergey Biryukov 47ed56f38f Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant.
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.

This commit also includes:

* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
 * `wp-admin/admin-header.php`
 * `wp-admin/admin-footer.php`
 * `wp-includes/version.php`

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.
Built from https://develop.svn.wordpress.org/trunk@47198


git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-06 06:33:11 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Andrew Nacin fd57b239d2 Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
nacin 9cb6e158fc Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-28 15:24:49 +00:00
ryan 3f72e340d6 Update since phpdoc. Props demetris. fixes #15445
git-svn-id: http://svn.automattic.com/wordpress/trunk@16660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 19:24:38 +00:00
nacin 6ec7cb4540 Use relative paths when including files, avoiding include_path. fixes #12594, props sorich87.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-18 06:14:45 +00:00
westi 7f894ae416 phpdoc for wp-admin. See #7496 props santosj.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-14 06:30:38 +00:00
ryan 7db4c0ad2c Fix profile submenu highlight. Make is_profile_page a constant so that register globals can't manipulate it. see #5736
git-svn-id: http://svn.automattic.com/wordpress/trunk@6700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-31 22:03:48 +00:00
ryan ece19d2bfb Merge user-edit.php and profile.php. Props nbachiyski. fixes #5736
git-svn-id: http://svn.automattic.com/wordpress/trunk@6697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-31 21:44:17 +00:00
ryan 7c1515630d Fix funky char, remove IE taunt. Props nbachiyski. see #4470
git-svn-id: http://svn.automattic.com/wordpress/trunk@6429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-20 05:50:57 +00:00
ryan 1f28d55ab3 Password strength meter from MellerTime. see #4470
git-svn-id: http://svn.automattic.com/wordpress/trunk@6419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-19 21:53:10 +00:00
rob1n 845ae5609d Add ID's to profile edit form's fieldsets. fixes #4434
git-svn-id: http://svn.automattic.com/wordpress/trunk@5689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-12 21:52:50 +00:00
rob1n 44088f5463 Add id attribute where it's only name. fixes #3696
git-svn-id: http://svn.automattic.com/wordpress/trunk@5323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-04-27 00:47:01 +00:00
ryan 9f534ebae6 Remove trailing spaces and convert spaces to tabs. Props Nazgul. fixes #986
git-svn-id: http://svn.automattic.com/wordpress/trunk@4495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-11-19 07:56:05 +00:00
ryan eda9021317 Hold off on menu cleanup until next release. There be dragons.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-11-18 07:31:29 +00:00
matt 07126127e6 Admin functions cleanup, and change how we do titles and parents in the backend
git-svn-id: http://svn.automattic.com/wordpress/trunk@4478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-11-18 06:09:48 +00:00
markjaquith 29c36e2b75 Restore 2x missing <br />. Props Nazgul and Xmion. fixes #3221
git-svn-id: http://svn.automattic.com/wordpress/trunk@4447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-11-04 05:23:12 +00:00
markjaquith 0fd28b6d83 Don't assume that TinyMCE exists, and degrade gracefully if it doesn't. fixes #3272
git-svn-id: http://svn.automattic.com/wordpress/trunk@4417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-10-24 03:57:19 +00:00
matt c437b9c9b0 Some UI cleanups, changes, and various miscellany.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-10-06 01:14:47 +00:00
matt 67d5a6d3c7 Options cleanup and some styling changes.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-09-19 06:11:42 +00:00
ryan 207d876c81 Make those chars feel special.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-08-24 22:33:16 +00:00
ryan 7677eca675 Capitalization fix from Mark J. fixes #3004
git-svn-id: http://svn.automattic.com/wordpress/trunk@4079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-08-07 18:44:13 +00:00
matt 157786ecaa Some renames
git-svn-id: http://svn.automattic.com/wordpress/trunk@3999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-07-06 04:27:45 +00:00
ryan 5e7c850484 User management improvements from Mark Jaquith and David House. #2793
git-svn-id: http://svn.automattic.com/wordpress/trunk@3857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-06-08 18:36:05 +00:00
ryan 96c3f739a8 Update nonce action strings. Props mdawaffe.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-05-26 23:08:05 +00:00
ryan 3f57a94f4c Nonce from above. #2678
git-svn-id: http://svn.automattic.com/wordpress/trunk@3759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-05-02 22:36:06 +00:00
ryan 0784227411 i81n fix from David House. fixes #2214
git-svn-id: http://svn.automattic.com/wordpress/trunk@3412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-01-07 06:33:49 +00:00
ryan c98cc7da09 Validation fix from philor. fixes #1958
git-svn-id: http://svn.automattic.com/wordpress/trunk@3316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-12-16 02:40:40 +00:00
matt beff0bedba Don't do bad xhtml fixing by default - fixes #1975
git-svn-id: http://svn.automattic.com/wordpress/trunk@3223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-28 23:05:12 +00:00
matt d0aa219739 Removing personal options, putting on profile page. Fixes #1557
git-svn-id: http://svn.automattic.com/wordpress/trunk@3112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-16 23:32:38 +00:00
ryan b6f44dc532 Pull the values in WP_User::data directly into WP_User so that we don't have to do ->data->blah.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-16 02:54:23 +00:00
matt 4e25506c93 Really shouldn't be shown.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-13 04:54:03 +00:00
ryan a8b6fe21ba Show Role in profile and user edit. Don't allow users with edit_users caps to demote themselves. Props: davidhouse, ringmaster. fixes #1825
git-svn-id: http://svn.automattic.com/wordpress/trunk@2995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-06 03:58:52 +00:00
ryan acfd349d19 Rename image-uploading to inline-uploading. Props skeltoac. fixes #1834
git-svn-id: http://svn.automattic.com/wordpress/trunk@2994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-06 03:40:43 +00:00
ryan 45435f003e wp_handle_upload() and image upload improvements from Andy. fixes #1806
git-svn-id: http://svn.automattic.com/wordpress/trunk@2979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-01 21:28:03 +00:00
ryan 5ba66d6c04 User create/update rework. Introduce wp_insert_user(), wp_create_user(), wp_update_user(), add_user(), update_user(), wp_new_user_notification().
git-svn-id: http://svn.automattic.com/wordpress/trunk@2872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-09-14 00:03:02 +00:00
matt 101ac654d1 Better names and typo.
git-svn-id: http://svn.automattic.com/wordpress/trunk@2844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-09-06 06:58:02 +00:00
matt b2afd0be71 Break out the updating part.
git-svn-id: http://svn.automattic.com/wordpress/trunk@2841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-09-06 03:08:09 +00:00
matt a1d90df64d Break up profile page into more logical sections
git-svn-id: http://svn.automattic.com/wordpress/trunk@2840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-09-06 02:01:33 +00:00
matt 65546ba7a5 Draw more attention to the messages, which now blend in a little with the header. TODO: Put all messages in an array, abstract out HTML
git-svn-id: http://svn.automattic.com/wordpress/trunk@2762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-08-08 01:13:22 +00:00
ryan 1e5d0b0736 Cap migration.
git-svn-id: http://svn.automattic.com/wordpress/trunk@2720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-07-17 19:29:55 +00:00
ryan 7af36168cb Roles update + UI from Owen.
git-svn-id: http://svn.automattic.com/wordpress/trunk@2704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-07-12 15:53:13 +00:00
matt 1851ed7f78 Let's be a little more discrete ;)
git-svn-id: http://svn.automattic.com/wordpress/trunk@2638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-06-13 09:06:30 +00:00
matt 1f9a608be9 User data migration should be complete
git-svn-id: http://svn.automattic.com/wordpress/trunk@2636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-06-13 08:32:44 +00:00
matt de9cc8b12c More user updates
git-svn-id: http://svn.automattic.com/wordpress/trunk@2632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-06-12 23:14:52 +00:00
matt 1613a1e1ab Adding profile update hook, fixes #1434
git-svn-id: http://svn.automattic.com/wordpress/trunk@2628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-06-10 23:33:58 +00:00
ryan c1c2c0df34 Do not require password update when changing profile. http://mosquito.wordpress.org/view.php?id=1101 Props: idanso
git-svn-id: http://svn.automattic.com/wordpress/trunk@2439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-03-13 17:29:33 +00:00
ryan 5123086148 Change login noun to Username. http://mosquito.wordpress.org/view.php?id=1088 Props: Albert
git-svn-id: http://svn.automattic.com/wordpress/trunk@2437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-03-13 17:06:18 +00:00
ryan 8b36e6be3a Introducing wp_redirect(), first cut. http://mosquito.wordpress.org/view.php?id=592 Props: Toby Simmons
git-svn-id: http://svn.automattic.com/wordpress/trunk@2436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-03-13 16:36:09 +00:00