afb0b3e4ef
Media Grid: add screen reader labels with more context to filters and bulk actions. Ditto for list view.
...
Props afercia.
Fixes #29026 .
Built from https://develop.svn.wordpress.org/trunk@29428
git-svn-id: http://core.svn.wordpress.org/trunk@29206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 05:20:16 +00:00
8ed123c97f
In `media.view.AttachmentFilters.All`, make `uploaded` conditional upon `media.view.settings.post.id` and include a new filter: `unattached`.
...
Drop the `mime-types` filter and related class (which was added for Media Grid) and use `all` instead.
Props ocean90, wonderboymusic.
Fixes #29065 .
Built from https://develop.svn.wordpress.org/trunk@29426
git-svn-id: http://core.svn.wordpress.org/trunk@29204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 04:44:17 +00:00
42809dad43
Use proper non-capturing regex syntax for YouTube in `wp_video_shortcode()`.
...
Props Fab1en.
See [27063].
Fixes #29119 .
Built from https://develop.svn.wordpress.org/trunk@29401
git-svn-id: http://core.svn.wordpress.org/trunk@29179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 17:01:17 +00:00
3f3395a086
Avoid PHP notices in Media Library if an attachment parent post type no longer exists.
...
Synchronize the 'edit_post' capability check between the list table and the media grid.
fixes #27446 .
Built from https://develop.svn.wordpress.org/trunk@29320
git-svn-id: http://core.svn.wordpress.org/trunk@29101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-29 01:41:16 +00:00
6f44e96d70
Set default values for attachment meta and ID3 data when preparing for JS to avoid errors in rendering templates. props ericmann for the initial patch. fixes #29013 .
...
Built from https://develop.svn.wordpress.org/trunk@29281
git-svn-id: http://core.svn.wordpress.org/trunk@29063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 18:04:18 +00:00
270a57075c
Media Grid: Add a date filter.
...
props ericlewis.
fixes #28895 .
Built from https://develop.svn.wordpress.org/trunk@29271
git-svn-id: http://core.svn.wordpress.org/trunk@29053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-22 20:47:15 +00:00
06f5b5a490
Media Grid:
...
Instead of a separate bulk selection mode, persistently show a checkbox for each item. Restores the more familiar bulk actions dropdown + action button.
props ericlewis. see #28842 .
Built from https://develop.svn.wordpress.org/trunk@29212
git-svn-id: http://core.svn.wordpress.org/trunk@28996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 20:42:15 +00:00
b7445ec8a4
Media Grid Attachment Details modal UI improvements:
...
* Align better visually with the existing media modal and the post image edit modal.
* Add back a link to the full attachment edit screen (post.php).
* Add a title to the modal and move prev/next buttons next to the more-consistent close button.
* Remove mode tabs (metadata vs. image editing) in favor of the Edit Image button.
Still to come: responsive, IE8 testing and targeted CSS (calc() usage), general CSS cleanup.
props ericlewis, helen, melchoyce. see #28844 . fixes #28915 .
Built from https://develop.svn.wordpress.org/trunk@29204
git-svn-id: http://core.svn.wordpress.org/trunk@28988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 03:55:15 +00:00
89d9bbd7f6
Make audio and video URLs/embed handlers work in `<iframe>`-sandbox'd MCE views.
...
Introduce:
`get_editor_stylesheets()`
`wp_media_mce_styles()`.
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29176
git-svn-id: http://core.svn.wordpress.org/trunk@28960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 21:51:15 +00:00
f1b19b24f3
Inline documentation cleanup for 4.0 audit.
...
Added in [28652]:
* Various phpDoc improvements for `wp_embed_handler_youtube()`
* Adds `@see` reference to `wp_embed_handler_youtube()` in 'wp_embed_handler_youtube' filter docs
Added in [29029]:
* s/post_id/post ID in `@return` description for `attachment_url_to_postid()`
See #28885 .
Built from https://develop.svn.wordpress.org/trunk@29164
git-svn-id: http://core.svn.wordpress.org/trunk@28948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 01:07:15 +00:00
448422f8ae
Media Grid improvements:
...
* Remove fixed elements.
* Adjusts toolbar and search, fixes #28833 .
* Add link to Add New button, fixes #28825 .
* Add "Edit Metadata" tab to all items, "Edit Image" only for images
* Make strings translatable.
* First pass for help tab.
see #28850 .
Built from https://develop.svn.wordpress.org/trunk@29136
git-svn-id: http://core.svn.wordpress.org/trunk@28920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-13 16:16:15 +00:00
e3c39d02cf
Media Grid, for audio files: show Bitrate in the Edit Attachments modal a la the Edit Post screen.
...
See #28839 .
Built from https://develop.svn.wordpress.org/trunk@29106
git-svn-id: http://core.svn.wordpress.org/trunk@28892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 21:56:16 +00:00
57dbc55e6e
When setting the poster image for a video shortcode, set that image as the featured image for that attachment (if found) in the background. This AJAX functionality could be used for audio as well.
...
Introduces `attachment_url_to_postid()` to attempt to turn URLs into post IDs.
Fixes #27891 .
Built from https://develop.svn.wordpress.org/trunk@29029
git-svn-id: http://core.svn.wordpress.org/trunk@28817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-08 17:48:17 +00:00
d4dd02b4ae
Remove backticks on `$post` variables in some short parameter descriptions.
...
See [28653], [28654].
See #28388 .
Built from https://develop.svn.wordpress.org/trunk@28976
git-svn-id: http://core.svn.wordpress.org/trunk@28765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-03 19:28:14 +00:00
428a83259e
Avoing a PHP warning in media modal if the attached file does not exist.
...
props kovshenin.
see #24716 .
Built from https://develop.svn.wordpress.org/trunk@28959
git-svn-id: http://core.svn.wordpress.org/trunk@28755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-02 14:37:15 +00:00
f799048057
Pass $url parameter to wp_embed_defaults() and 'embed_defaults' filter.
...
props wpsmith, sabreuse, jacobdubail.
fixes #20151 .
Built from https://develop.svn.wordpress.org/trunk@28923
git-svn-id: http://core.svn.wordpress.org/trunk@28722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-30 11:16:15 +00:00
6216aa2331
Add documentation for the default playlist shortcode attributes in `wp_playlist_shortcode()`.
...
Props taylorde.
Fixes #28678 .
Built from https://develop.svn.wordpress.org/trunk@28901
git-svn-id: http://core.svn.wordpress.org/trunk@28700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-29 21:29:17 +00:00
b9fd9db83b
Uploader: enable selecting multiple files on mobile devices (still doesn't work on Android). See #28640 .
...
Built from https://develop.svn.wordpress.org/trunk@28847
git-svn-id: http://core.svn.wordpress.org/trunk@28651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-26 04:15:15 +00:00
2efb8f8507
When `wp_oembed_add_provider()` or `wp_oembed_remove_provider()` is called before the `plugins_loaded` hook has, store the values statically on the `WP_oEmbed` object and add them just-in-time when the object is instantiated.
...
This ensures that all plugins have an accurate provider list when `apply_filters( 'oembed_providers', $providers )` is called.
Props kovshenin.
Fixes #28284 .
Built from https://develop.svn.wordpress.org/trunk@28846
git-svn-id: http://core.svn.wordpress.org/trunk@28650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-26 02:30:15 +00:00
b5ef672c6b
Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further.
...
props ericlewis, shaunandrews, wonderboymusic.
see #24716 .
Built from https://develop.svn.wordpress.org/trunk@28682
git-svn-id: http://core.svn.wordpress.org/trunk@28500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-05 22:01:18 +00:00
b0877f02a4
Make sure `$post` is properly documented as optional where applicable.
...
See #28388 .
Built from https://develop.svn.wordpress.org/trunk@28653
git-svn-id: http://core.svn.wordpress.org/trunk@28471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-03 03:53:17 +00:00
91e6a8c017
Because of YouTube's overwhelming dominance in the online video space, we should help our users who paste bad URLs when possible. It is easy to fix ` http://youtube.com/embed/acb1233 ` URLs by turning them into ` http://youtube.com/watch?v=abc1233 ` embeds using an embed handler (we already have one to fix Google Video embeds).
...
We should avoid doing this in almost every other case, but it's YouTube, and it's an easy error for a novice to make.
Fixes #24660 .
Built from https://develop.svn.wordpress.org/trunk@28652
git-svn-id: http://core.svn.wordpress.org/trunk@28470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-02 01:22:15 +00:00
2b6c8462b3
Avoid a PHP notice in adjacent_image_link() if no images were found.
...
props nabil_kadimi.
see #28361 .
Built from https://develop.svn.wordpress.org/trunk@28584
git-svn-id: http://core.svn.wordpress.org/trunk@28409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-27 10:55:16 +00:00
dd25ef25d9
`$count` is set in `get_post_galleries()` and never used, relic from PFUI RIP.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28550
git-svn-id: http://core.svn.wordpress.org/trunk@28376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 19:13:14 +00:00
abff6bf6cf
`$gallery_div` is set twice in `gallery_shortcode()` before it is used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28549
git-svn-id: http://core.svn.wordpress.org/trunk@28375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 19:12:14 +00:00
e4bc49c244
Because PHP can be configured without `--filter`, it is not 100% safe to use `filter_var()`. This is problematic for casting `"false"` to `false`, as PHP always casts it to `true`. `FILTER_VALIDATE_BOOLEAN` fixes this, but it may not be available.
...
Add a new function, `wp_validate_boolean()`, to replace `filter_var( $var, FILTER_VALIDATE_BOOLEAN )`.
Fixes #28170 .
Built from https://develop.svn.wordpress.org/trunk@28542
git-svn-id: http://core.svn.wordpress.org/trunk@28368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 18:34:15 +00:00
dcc6cbc04f
Eliminate use of `extract()` in `gallery_shortcode()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28414
git-svn-id: http://core.svn.wordpress.org/trunk@28241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:41:15 +00:00
08824b6529
Add a complete short description to the `get_attached_media` filter documentation.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28377
git-svn-id: http://core.svn.wordpress.org/trunk@28205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:21:14 +00:00
3bbed6ceac
`audio`, `video`, and `playlist` shortcodes:
...
* Convert all instances of variable variables to array properties
* Eradicate use of `extract()`
* Rename `$atts` to `$html_atts` where collision with new `$atts` (shortcode atts holder) var might occur
See #22400 , #27881 .
Built from https://develop.svn.wordpress.org/trunk@28342
git-svn-id: http://core.svn.wordpress.org/trunk@28170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 17:36:18 +00:00
ab041987d3
Remove some unnecessary abstraction introduced in [28191]. See #27985 .
...
Built from https://develop.svn.wordpress.org/trunk@28194
git-svn-id: http://core.svn.wordpress.org/trunk@28024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-24 11:55:22 +00:00
d6e03df3c9
Avoid an expensive attachment counting query on the post editing screen. See #27985 , for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@28191
git-svn-id: http://core.svn.wordpress.org/trunk@28021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-23 22:05:16 +00:00
55becc0dfd
Refinements for asynchronous rendering in `wp.mce.media.PlaylistView`:
...
* Add `visibility: hidden` as an inline style to `<audio>` tags, there is a race with the stylesheet which can get enqueued in the body and loaded in the footer.
* When creating new instances of `MediaElementPlayer`, always push them onto a stack. Lone views can be responsible for multiple instances of the same shortcode on render.
* Rename `wp.media.mixin.unsetPlayer()` to `wp.media.mixin.unsetPlayers()` to reflect the above.
* Call `wp.media.mixin.unsetPlayers()` on the view's `unbind()` method, instead of inline in the `render()` method
* Make sure `WPPlaylistView` is instantiated for each editor instance
* Ensure that the `No Items Found` view state is not rendered when attachments actually do exist.
Props gcorne, wonderboymusic.
See #27899 .
Built from https://develop.svn.wordpress.org/trunk@28182
git-svn-id: http://core.svn.wordpress.org/trunk@28013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-22 17:53:16 +00:00
f6387ec25a
Properly translate 'Select Poster Image'.
...
props dimadin.
see #27845 , for trunk.
Built from https://develop.svn.wordpress.org/trunk@28168
git-svn-id: http://core.svn.wordpress.org/trunk@27999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-19 18:28:15 +00:00
e3a4c57563
Final about page.
...
props melchoyce, helen, wonderboymusic, nacin, and the illustrious Michael Pick.
fixes #27713 , #27837 .
Built from https://develop.svn.wordpress.org/trunk@28150
git-svn-id: http://core.svn.wordpress.org/trunk@27981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 17:40:14 +00:00
e8020e91fd
Cast wp_count_attachments() before iterating it to avoid a notice when items exist without a mime type.
...
props bobbingwide.
fixes #27802 .
Built from https://develop.svn.wordpress.org/trunk@28139
git-svn-id: http://core.svn.wordpress.org/trunk@27970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 00:00:15 +00:00
da896b7cf3
Inline documentation for hooks in wp-includes/media.php.
...
Props scottlee for the initial patch. Props kpdesign, DrewAPicture.
Fixes #27718 .
Built from https://develop.svn.wordpress.org/trunk@28128
git-svn-id: http://core.svn.wordpress.org/trunk@27959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 01:36:14 +00:00
bfe44f07a3
Plupload: Restore 3.8 handles and filenames to avoid breaking plugins.
...
fixes #27763 .
Built from https://develop.svn.wordpress.org/trunk@28108
git-svn-id: http://core.svn.wordpress.org/trunk@27939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 00:07:16 +00:00
e8da400c69
Don't show featured images for image attachments. Remove abstractions for now.
...
fixes #27673 .
Built from https://develop.svn.wordpress.org/trunk@28051
git-svn-id: http://core.svn.wordpress.org/trunk@27881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 17:40:28 +00:00
4d6fcfdba1
Escape playlist data in templates.
...
props wonderboymusic.
fixes #27710 .
Built from https://develop.svn.wordpress.org/trunk@28050
git-svn-id: http://core.svn.wordpress.org/trunk@27880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 17:40:14 +00:00
6b41f728d4
Header Images: Add suggested dimensions to the media workflow.
...
props ehg, gcorne.
see #21785 .
Built from https://develop.svn.wordpress.org/trunk@28030
git-svn-id: http://core.svn.wordpress.org/trunk@27860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 01:55:15 +00:00
42a66ea424
Make playlist tracks keyboard-accessible.
...
Fixes #27644 .
Built from https://develop.svn.wordpress.org/trunk@28023
git-svn-id: http://core.svn.wordpress.org/trunk@27853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 22:28:16 +00:00
eebf49c180
General PHPDoc improvements in wp-includes/media.php for 3.9 functionality.
...
See #27700 .
Built from https://develop.svn.wordpress.org/trunk@28004
git-svn-id: http://core.svn.wordpress.org/trunk@27834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 20:38:15 +00:00
2c88f6e941
[27640] supported a caption for audio and video shortcodes as part of a UX iteration for the related MCE views. These captions have since be excluded, so the extra code should be removed (it was there for this sole reason).
...
See #27320 .
Built from https://develop.svn.wordpress.org/trunk@27979
git-svn-id: http://core.svn.wordpress.org/trunk@27809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 06:13:18 +00:00
7689cc4a74
When dynamically instantiating `MediaElementPlayer` instances in JS, `preload="metadata"` is extremely wonky. `preload="none"` lets the file play right away.
...
This has already been addressed for audio|video shortcodes, but also needs to be the case for playlists. When loading a playlist from a DOM cache or via AJAX, and when the sources match those already pre-loaded, the browser will sometimes donkey-punch the HTTP request for the first cached track selected.
Set `preload="none"` for the empty `<audio|video>` tag for playlists.
See commits related to #26779 .
Built from https://develop.svn.wordpress.org/trunk@27974
git-svn-id: http://core.svn.wordpress.org/trunk@27804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-06 21:33:15 +00:00
3238664215
Revert the changes made to `data.title` in playlist Underscore templates in [27869]. `{{ data.title }}` causes the title to be double-encoded on the front end.
...
See #27574 .
Built from https://develop.svn.wordpress.org/trunk@27960
git-svn-id: http://core.svn.wordpress.org/trunk@27790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 20:06:16 +00:00
5e79b94d81
Header images: Handle cropping failures.
...
props ehg.
see #21785 .
Built from https://develop.svn.wordpress.org/trunk@27946
git-svn-id: http://core.svn.wordpress.org/trunk@27776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 15:48:16 +00:00
079ddec045
Remove <br> elements for HTML5 galleries.
...
props obenland.
fixes #27637 , see #26697 .
Built from https://develop.svn.wordpress.org/trunk@27914
git-svn-id: http://core.svn.wordpress.org/trunk@27745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-02 21:50:14 +00:00
55b61b7a70
Re-instantiate the `MediaElementPlayer` instance when switching mime types in playlists.
...
Fixes #27608 .
Built from https://develop.svn.wordpress.org/trunk@27871
git-svn-id: http://core.svn.wordpress.org/trunk@27702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-31 15:35:15 +00:00
01d2062af3
Cleanup up the display, escaping, and handling of ID3 data for media. Rename `wp_get_relevant_id3_keys()` to `wp_get_attachment_id3_keys()`.
...
Props nacin.
See #27574 .
Built from https://develop.svn.wordpress.org/trunk@27869
git-svn-id: http://core.svn.wordpress.org/trunk@27700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-31 05:16:16 +00:00
b6ac65f07f
Using percentages for playlist font-sizing was ambitious, but fell prey to `editor-style.css` in the admin. We have switched to using pixels. The editor styles were also forcing MediaElement players to inherit `font-family`, which was undesirable. And while we're at it, remove the top and bottom border from the playlist's list of tracks, which adds a dash of lovely to the playlist's default styles.
...
Props nacin for the addition of `—` in the playlist track list.
Fixes #27600 .
Built from https://develop.svn.wordpress.org/trunk@27865
git-svn-id: http://core.svn.wordpress.org/trunk@27696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 22:12:16 +00:00
Scott Taylor
Sergey Biryukov
Helen Hou-Sandí
Dominik Schilling
Drew Jaynes
Andrew Ozz
John Blackbourn
Andrew Nacin