Commit Graph

56 Commits

Author SHA1 Message Date
Gary Pendergast 7a617078fa Coding Standards: Upgrade WPCS to 1.2.1.
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.

Fixes #45956.


Built from https://develop.svn.wordpress.org/trunk@44574


git-svn-id: http://core.svn.wordpress.org/trunk@44405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 06:41:52 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Dominik Schilling 64fc7294b6 Use HTTPS URLs for codex.wordpress.org.
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Sergey Biryukov 31c11b1f0d Bundled themes: After [31453], replace `current()` with `reset()`, which is guaranteed to be the first item.
see #31259, #31260.
Built from https://develop.svn.wordpress.org/trunk@31842


git-svn-id: http://core.svn.wordpress.org/trunk@31824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 02:04:27 +00:00
Lance Willett 86a133a79a Bundled themes: replace `array_shift()` with `current()` for performance.
Props SergeyBiryukov, fixes #31260.
Built from https://develop.svn.wordpress.org/trunk@31453


git-svn-id: http://core.svn.wordpress.org/trunk@31434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 17:52:27 +00:00
Lance Willett ff5628169e Twenty Ten: fix escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31266


git-svn-id: http://core.svn.wordpress.org/trunk@31247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-22 00:42:44 +00:00
Andrew Nacin f5eb32ec6b Default themes: Don't use /** docblocks for simple multiline comments.
props DrewAPicture, ericlewis.
fixes #25256.

Built from https://develop.svn.wordpress.org/trunk@25746


git-svn-id: http://core.svn.wordpress.org/trunk@25659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 20:39:09 +00:00
Lance Willett 6268f714e0 Twenty Ten: update code comments to reflect WP inline docs standards. Props DrewAPicture, closes #25256.
Built from https://develop.svn.wordpress.org/trunk@25627


git-svn-id: http://core.svn.wordpress.org/trunk@25544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 17:04:10 +00:00
Lance Willett a738cc3c83 Bundled themes: remove `the_title_attribute()` title attributes where it duplicates `the_title()` in anchor text. Props nacin, fixes #24203.
git-svn-id: http://core.svn.wordpress.org/trunk@24131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 16:57:30 +00:00
Lance Willett 5697b2f828 Twenty Ten: improve how gallery image IDs are retrieved for use in the Gallery post format template. Props to obenland for original patch, fixes #23617.
git-svn-id: http://core.svn.wordpress.org/trunk@23826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-27 20:37:34 +00:00
Lance Willett 8eea008b2c Twenty Ten: change gallery category post meta output to check for a "gallery" category using `get_term_by()` to avoid a possible WP_Error for an empty result by getting a false (boolean) return value instead.
And, change link output to use `get_category_link()` instead of `get_term_link()`.

Props SergeyBiryukov and keoshi, fixes #23837.

git-svn-id: http://core.svn.wordpress.org/trunk@23793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-22 22:56:55 +00:00
Lance Willett cdbda911ae Twenty Ten: escape i18n attributes as late as possible, fixes cases in loop.php -- props mfields. See #21756.
git-svn-id: http://core.svn.wordpress.org/trunk@22197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-11 20:12:40 +00:00
ryan 9f5c80eb92 Use one space, not two, after trailing punctuation. Prop Zeo. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-16 17:13:16 +00:00
ryan b4173bbc4e 3.0 compat for twentyten
git-svn-id: http://svn.automattic.com/wordpress/trunk@17469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-02-21 18:35:37 +00:00
nacin cf52befe03 Revert [16614] and [16614]. Deal with plural form issues in early 3.2 and remove the hacks from Twenty Ten. see #13651.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-22 18:06:56 +00:00
nacin be21df74ee Handle 'This gallery contains X photos' properly in Twenty Ten. fixes #15858.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-20 09:34:58 +00:00
nacin 7c2e6f8c90 Add 'View Galleries' link for post formats. fixes #15506.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-07 23:31:35 +00:00
nacin 0e29723f63 Fix comment number in Twenty Ten when there is one comment. Due to how these values are then passed to comments_popup_link(). We need to fix this. see #13651.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-05 02:15:51 +00:00
nbachiyski d43b3a704c Make comments_popup_link() calls in Twenty Ten respect languages with multiple plural forms until we add such support in comments_number(). See #13651, props zeo
git-svn-id: http://svn.automattic.com/wordpress/trunk@16614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-29 18:42:31 +00:00
nacin 41c46efc24 Only link to the Gallery category if the post is in the category. (It may be a format.) see #15506, see #15378.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-25 18:59:19 +00:00
nacin 27cb70434a Twenty Ten code cleanups. props lancewillett, fixes #15476.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-19 05:37:47 +00:00
westi 435c4c2dbf Revert most of [16332] - renaming and deprecating a commonly used function is silly. Improving it is good. Fixes #15407.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-12 21:53:15 +00:00
scribu 98cda5bd65 Replace get_the_category() with get_the_categories(). Props filosofo. Fixes #15407
git-svn-id: http://svn.automattic.com/wordpress/trunk@16332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-12 20:05:37 +00:00
markjaquith 7616a6cafb Add Post Format support to TwentyTen. Can now use this to designate an Aside or a Gallery! see #14746
git-svn-id: http://svn.automattic.com/wordpress/trunk@16197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-05 02:25:41 +00:00
nacin c43b5bc26b Update to Twenty Ten 1.0.3 from theme dir. see #14284.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-12 19:40:21 +00:00
nacin 44f8ce8909 Don't pass bogus argument to the_excerpt. props zeo, fixes #13883.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-14 08:24:34 +00:00
wpmuguru b7432248ba arrange twentyten strings for easier translation, props zeo, fixes #13824
git-svn-id: http://svn.automattic.com/wordpress/trunk@15222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-11 16:15:25 +00:00
nacin 9e65c710fe Don't reveal gallery content in Twenty Ten when the post is password protected. fixes #13770, props zeo.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-10 18:23:08 +00:00
nacin 9584b002b3 Use a more generic HTML comment. props zeo, fixes #12695.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 04:36:42 +00:00
nacin a35791a4ae In Twenty Ten, final pass on inline docs et al. props jorbin, zeo. fixes #12695.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-21 18:56:27 +00:00
nacin f713b87e31 In Twenty Ten, documentation and code improvements. see #12695.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-17 06:36:11 +00:00
nacin ff32a9aa28 Various minor tweaks to file-level phpdoc in Twentyten. props dremeda. see #12695.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-17 06:32:03 +00:00
nacin c40e204b6c Twenty Ten documentation and functions.php improvements. see #12695.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 20:53:36 +00:00
nacin ff66f09ec9 @subpackage cannot have spaces.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 17:10:21 +00:00
markjaquith 4ab768959d Do not show dummy default category output when calling the_category on a post_type that does not support the category taxonomy (like pages). Fix TwentyTen theme to not display wrapping text if there are no categories. fixes #10333
git-svn-id: http://svn.automattic.com/wordpress/trunk@14660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-15 09:59:15 +00:00
nbachiyski e27f57e1b6 Do not cut the Tagged <tags> phrase in half. Fixes #13198
git-svn-id: http://svn.automattic.com/wordpress/trunk@14552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-10 21:24:32 +00:00
nbachiyski 75b3a4ea29 Clean up loop i18n. Props zeo, see #13198
* Take out tags from strings
 * Extract two common and complicatd strings into functions
 * Whitespace


git-svn-id: http://svn.automattic.com/wordpress/trunk@14541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-10 19:06:22 +00:00
nacin 4340b23564 Make sure we're localizing the Gallery category in Twenty Ten. Use get_term_link because it can look up the category by the slug, instead of an extra get_cat_ID call. See [14350] for previous changes.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-07 18:13:20 +00:00
nacin 3e035809a1 Twenty Ten spacing and string cleanups. props zeo, markmcwilliams. see #13198. Add a twentyten_credits filter, props nathanrice, fixes #12804. Also clean up the generator/credits string.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-04 07:01:09 +00:00
ryan 97c448ed14 Coding standard cleanups. Props zeo. see #13198
git-svn-id: http://svn.automattic.com/wordpress/trunk@14391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 19:30:02 +00:00
iammattthomas 941da09fa7 In Twenty Ten:
* removed custom functions for listing tags, cats, or other custom taxonomy terms.
* fixed up a couple of span tags meant to catch the text before tag and cat listings (for child themes)
* made attachment pages full width with a filterable size for the image, 'twentyten_attachment_size' (for child themes)
* removed "RSS for this post" in single.php.
clicking on attachment images in a gallery takes you to the next image, unless it's the last image in a gallery, in which case it points you back to the parent post.
* added a link to the full-size image in the post meta

Props iandstewart.

git-svn-id: http://svn.automattic.com/wordpress/trunk@14384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 19:16:47 +00:00
ryan b4e14fb299 Mark Asides and Gallery category slugs for translation.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-02 23:32:59 +00:00
iammattthomas 207a41d5a5 Links on dates in Twenty Ten back by popular demand. Fixes #12925.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-13 23:41:13 +00:00
iammattthomas 607a8c4fbf Remove the permalink from dates in Twenty Ten, fixes #12925
git-svn-id: http://svn.automattic.com/wordpress/trunk@14083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-13 23:05:37 +00:00
nacin cfee8704b2 Remove unnecessary quote escaping and \n\t indentation in twentyten. see #12902
git-svn-id: http://svn.automattic.com/wordpress/trunk@14037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-08 03:13:48 +00:00
nacin a4c7fb5869 Rough cut of Twenty Ten inline documentation. see #12695. props jorbin, demetris.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-29 22:03:15 +00:00
nacin 40773a776b Remove trailing whites and double semicolons.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 19:36:49 +00:00
iammattthomas 8babcc5d7c Replace query strings with arras in Twenty Ten, see #12698. Props demetris.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 05:37:55 +00:00
iammattthomas a70633cedc Coding standards cleanup in twentyten, see #9015. Props sivel
git-svn-id: http://svn.automattic.com/wordpress/trunk@13720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-16 20:17:22 +00:00