Gary Pendergast
cddee8b72e
Formatting: Loosen the type checking in `_sanitize_text_fields()`.
...
[44618] added strict type checking to `_sanitize_text_fields()`, which has caused some compat issues with plugins.
We can loosen the type checking to only reject objects and arrays, and cast other types to string.
Props Nick_theGeek, pento.
Fixes #41450 .
Built from https://develop.svn.wordpress.org/trunk@44731
git-svn-id: http://core.svn.wordpress.org/trunk@44562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-07 23:35:49 +00:00
laurelfulford
a1eceec5bd
Default Themes: Bump the version numbers and release dates.
...
Update the theme versions and release dates for the default themes, in time for WordPress 5.1.
The POT files for Twenty Eleven and Twenty Ten have also been updated.
Fixes #46070 .
Built from https://develop.svn.wordpress.org/trunk@44730
git-svn-id: http://core.svn.wordpress.org/trunk@44561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-07 23:23:50 +00:00
youknowriad
a89b6c042d
Block Editor: Update WordPress Packages to solve PHP 5.2.2 parser incompatibility.
...
Updated:
- @wordpress/block-library@2.2.16
- @wordpress/block-serialization-default-parser@2.0.5
- @wordpress/blocks@6.0.7
- @wordpress/edit-post@3.1.11
- @wordpress/editor@9.0.11
- @wordpress/format-library@1.2.14
Props pento.
Fixes #46200 .
Built from https://develop.svn.wordpress.org/trunk@44729
git-svn-id: http://core.svn.wordpress.org/trunk@44560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-07 09:02:49 +00:00
Gary Pendergast
95d5aa0e97
Build: Update `package.json` dependencies to match Gutenberg.
...
Props wpscholar, azaozz, gziolo.
Fixes #46039 .
Built from https://develop.svn.wordpress.org/trunk@44728
git-svn-id: http://core.svn.wordpress.org/trunk@44559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-07 06:28:03 +00:00
Gary Pendergast
c2c021baf1
Multisite: After creating a new blog, ensure the blog cache is correctly cleaned up.
...
Props david.binda, spacedmonkey.
Fixes #46125 .
Built from https://develop.svn.wordpress.org/trunk@44727
git-svn-id: http://core.svn.wordpress.org/trunk@44558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-07 06:04:51 +00:00
Gary Pendergast
bbbf0ee62e
Admin: Re-add some validation from [44048] that was accidentally removed in [44165].
...
Props david.binda.
See #45037 .
Built from https://develop.svn.wordpress.org/trunk@44726
git-svn-id: http://core.svn.wordpress.org/trunk@44557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-07 04:12:51 +00:00
desrosj
2d1d80f4c5
Themes: Revert returning the value of `locate_template()` in functions that call it.
...
Because the names of the `get_header()`, `get_footer()`, `get_sidebar()`, and `get_template_part()` functions indicate that a value is returned, some plugins and themes already have `echo get_template_part()` in their codebase. Adding a return value to these functions using the approach in [44678] will cause the two unintended side effects of unexpected content being sent to the browser, and accidental path disclosure.
Reverts [44678].
Props davidbinda.
See #40969 .
Built from https://develop.svn.wordpress.org/trunk@44725
git-svn-id: http://core.svn.wordpress.org/trunk@44556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-06 18:37:51 +00:00
Andrew Ozz
5b6a1ad3b2
TinyMCE: fix color of highlighted drop-down menu items in Classic Block.
...
Fixes #46164 .
Built from https://develop.svn.wordpress.org/trunk@44724
git-svn-id: http://core.svn.wordpress.org/trunk@44555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-05 17:47:55 +00:00
Sergey Biryukov
ee8c3deaa5
Build/Test Tools: Display a message about currently supported PHPUnit branch to avoid fatal errors on later versions.
...
See #46149 .
Built from https://develop.svn.wordpress.org/trunk@44723
git-svn-id: http://core.svn.wordpress.org/trunk@44554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-03 22:41:53 +00:00
Peter Wilson
f5cab6780f
Administration: Save column visibility on small screens.
...
Modifies the jQuery selector for determining hidden columns to ensure they are detected when the expanded columns details are closed.
Adds high-specificity selectors specifically for setting screen options in the comments and plugins lists.
Props afercia.
Fixes #46005 .
Built from https://develop.svn.wordpress.org/trunk@44722
git-svn-id: http://core.svn.wordpress.org/trunk@44553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-01 02:14:51 +00:00
Gary Pendergast
60ddb6012e
Post WordPress 5.1 Beta 3 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@44721
git-svn-id: http://core.svn.wordpress.org/trunk@44552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-31 03:32:51 +00:00
Gary Pendergast
60d36c140a
WordPress 5.1 Beta 3.
...
Built from https://develop.svn.wordpress.org/trunk@44720
git-svn-id: http://core.svn.wordpress.org/trunk@44551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-31 03:17:51 +00:00
Sergey Biryukov
61a7dc1277
Build/Test Tools: Move `WP_UnitTestCase_Base::assertPostConditions()` to a more appropriate place.
...
See #43218 .
Built from https://develop.svn.wordpress.org/trunk@44719
git-svn-id: http://core.svn.wordpress.org/trunk@44550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-30 14:31:51 +00:00
Andrew Ozz
02adaaf90c
TinyMCE: fix external references in `wpview` and `wpemoji` plugins in the Classic Block instance when running from `/build`.
...
Fixes #46147 .
Built from https://develop.svn.wordpress.org/trunk@44718
git-svn-id: http://core.svn.wordpress.org/trunk@44549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-30 14:12:52 +00:00
Felix Arntz
92c3c46abe
Bootstrap/Load: Revert fatal error recovery mechanism from 5.1 to polish for 5.2.
...
Due to the high number of follow-up tickets and associated security concerns, it was decided to reschedule the fatal error recovery feature for WordPress 5.2, in order to address these issues properly. The feature will continue to be developed, with iterations being merged into trunk early in the 5.2 release cycle.
Fixes #46141 . See #44458 , #45932 , #45940 , #46038 , #46047 , #46068 .
Built from https://develop.svn.wordpress.org/trunk@44717
git-svn-id: http://core.svn.wordpress.org/trunk@44548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-30 11:01:52 +00:00
Andrew Ozz
6a5df4271f
TinyMCE: update alternative icon fonts for older browsers after [44713].
...
See #46094 .
Built from https://develop.svn.wordpress.org/trunk@44716
git-svn-id: http://core.svn.wordpress.org/trunk@44547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-30 10:07:50 +00:00
Sergey Biryukov
32ee2ed573
Build/Test Tools: Simplify `WP_PHPUnit_Util_Getopt` and update documentation.
...
Introduced in [918/tests] and updated in [26871], the class is there to make sure that known bugs are not skipped when `phpunit` is called with a `--group` that corresponds to an `@ticket` annotation (such as `phpunit --group 12345`).
Enforcing recognized arguments or correctly formed arguments is not the concern here, so reusing `PHPUnit_Util_Getopt::parseLongOption()` was superfluous.
See #43218 .
Built from https://develop.svn.wordpress.org/trunk@44715
git-svn-id: http://core.svn.wordpress.org/trunk@44546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-30 00:54:51 +00:00
Peter Wilson
d9a1f99d9c
Customize: Remove `wp_targeted_link_rel` pre-save filter from change-sets.
...
The pre-save filters added to links in [43732] could invalidate JSON data when saving Customizer change-sets.
This removes the filters when saving and publishing change-sets.
Props peterwilsoncc, nikeo for testing.
See #45292 .
Built from https://develop.svn.wordpress.org/trunk@44714
git-svn-id: http://core.svn.wordpress.org/trunk@44545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-29 21:29:50 +00:00
Ella Iseulde Van Dorpe
2ce767141a
TinyMCE: Update to 4.9.2
...
https://github.com/tinymce/tinymce-dist/compare/4.8.0...4.9.2
Fixes #46094 .
Built from https://develop.svn.wordpress.org/trunk@44713
git-svn-id: http://core.svn.wordpress.org/trunk@44544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-29 20:19:51 +00:00
Andrea Fercia
da75c0cdb6
Comments: Restore a removed fieldset legend after [44466].
...
In the Edit Comment page:
- moves the "Author" `h2` heading out of the form fieldset
- removes an unnecessary `<span>` element
- adds a visually hidden legend element to the fieldset
- uses an existing string "Comment Author"
Fixes #43586 .
Built from https://develop.svn.wordpress.org/trunk@44712
git-svn-id: http://core.svn.wordpress.org/trunk@44543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-29 19:10:49 +00:00
youknowriad
3c7a623f85
Block Editor: Update WordPress Packages to the latest versions.
...
Updated Packages:
- @wordpress/annotations@1.0.8
- @wordpress/block-library@2.2.15
- @wordpress/components@7.0.8
- @wordpress/edit-post@3.1.10
- @wordpress/editor@9.0.10
- @wordpress/format-library@1.2.13
- @wordpress/list-reusable-blocks@1.1.21
- @wordpress/nux@3.0.9
- @wordpress/rich-text@3.0.7
Fixes list block indentation and Crowdsignal embed block.
Props iseulde.
Fixes #46137 .
Built from https://develop.svn.wordpress.org/trunk@44711
git-svn-id: http://core.svn.wordpress.org/trunk@44542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-29 18:23:55 +00:00
Gary Pendergast
129db19a29
Tests: Fix the tests for the `c` and `r` formats in `date_i18n()`.
...
To test the `date_i18n()` output correctly, the tests added in [43434] need to set a non-UTC timezone.
Props Rarst.
Fixes #20973 .
Built from https://develop.svn.wordpress.org/trunk@44710
git-svn-id: http://core.svn.wordpress.org/trunk@44541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-29 01:20:50 +00:00
Dominik Schilling
8af55f1578
Script Loader: Add missing semicolon.
...
Fixes #46131 .
Built from https://develop.svn.wordpress.org/trunk@44709
git-svn-id: http://core.svn.wordpress.org/trunk@44540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-28 21:59:49 +00:00
Dominik Schilling
9531bd8378
Privacy: Use `label_count` property of post status for request counts in the list table views.
...
See #44952 .
Fixes #46112 .
Built from https://develop.svn.wordpress.org/trunk@44708
git-svn-id: http://core.svn.wordpress.org/trunk@44539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-28 21:55:51 +00:00
Sergey Biryukov
503e533f6d
Build/Test Tools: Don't throw an exception for unrecognized options in `WP_PHPUnit_Util_Getopt::parseLongOption()`.
...
The method is only used for two known options: `group` and `exclude-group`, others should be passed to PHPUnit.
Props johnbillion.
See #43218 .
Built from https://develop.svn.wordpress.org/trunk@44707
git-svn-id: http://core.svn.wordpress.org/trunk@44538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-28 18:50:53 +00:00
Felix Arntz
e7e87ca545
Bootstrap/Load: Fix notice when theme directories are not populated yet.
...
When a fatal error occurs outside of a regular plugin in a stage where theme directories are not set up yet (for example in a MU plugin), this would previously trigger a notice.
Props johnbillion.
Fixes #46068 . See #44458 .
Built from https://develop.svn.wordpress.org/trunk@44706
git-svn-id: http://core.svn.wordpress.org/trunk@44537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-28 17:43:51 +00:00
Sergey Biryukov
c0339fc3da
Coding Standards: Replace spaced indentation sections of `phpunit.xml.dist`, `multisite.xml`, and `build.xml` with tabs.
...
Props netweb, desrosj.
See #43218 .
Built from https://develop.svn.wordpress.org/trunk@44705
git-svn-id: http://core.svn.wordpress.org/trunk@44536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-28 17:21:48 +00:00
Sergey Biryukov
3803d8bb60
Build/Test Tools: Reorder `<file>` and `<exclude>` rules in `multisite.xml` to avoid warnings in PHPUnit 7.2+.
...
Missed in [44702].
See #43218 .
Built from https://develop.svn.wordpress.org/trunk@44704
git-svn-id: http://core.svn.wordpress.org/trunk@44535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-28 17:20:50 +00:00
Sergey Biryukov
28674e5e39
Build/Test Tools: Correct `WP_Test_REST_Schema_Sanitization::test_type_string()` to check for both `1.1` float and `'1.10'` string explicitly.
...
Previously, the test only passed due to a bug in PHPUnit 7.1.x and older versions.
Fixes #43218 . See #38586 .
Built from https://develop.svn.wordpress.org/trunk@44703
git-svn-id: http://core.svn.wordpress.org/trunk@44534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-28 16:54:50 +00:00
Sergey Biryukov
1353355216
Build/Test Tools: Reorder `<file>` and `<exclude>` rules in `phpunit.xml.dist` to avoid warnings in PHPUnit 7.2+.
...
Remove deprecated `logIncompleteSkipped` option that does not exist in PHPUnit 6.0+.
See #43218 .
Built from https://develop.svn.wordpress.org/trunk@44702
git-svn-id: http://core.svn.wordpress.org/trunk@44533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-28 15:55:50 +00:00
Sergey Biryukov
74468758dd
Build/Test Tools: Add support for PHPUnit 7.x.
...
* Create an abstract `WP_UnitTestCase_Base` class to share between PHPUnit 7.x and older versions.
* Add a speed-trap loader to determine which `SpeedTrapListener` class needs to be loaded for the current PHPUnit version.
* Remove unnecessary `PHPUnit\Util\Test` and `PHPUnit_Util_Getopt` inheritances.
* Update Travis CI config to use PHPUnit 7.x for PHP 7.1, 7.2, and nightly PHP versions.
Props jipmoors, netweb, desrosj, ayeshrajans, soulseekah, SergeyBiryukov.
See #43218 .
Built from https://develop.svn.wordpress.org/trunk@44701
git-svn-id: http://core.svn.wordpress.org/trunk@44532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-28 14:11:51 +00:00
Dominik Schilling
fb552cad0f
Install/Upgrade: After [44451], update translator comments to include the new placeholder.
...
See #46111 .
Fixes #45574 .
Built from https://develop.svn.wordpress.org/trunk@44700
git-svn-id: http://core.svn.wordpress.org/trunk@44531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-27 14:46:55 +00:00
Dominik Schilling
05a3c91d34
TinyMCE Classic Block: Remove unused variable.
...
See #46071 .
Built from https://develop.svn.wordpress.org/trunk@44699
git-svn-id: http://core.svn.wordpress.org/trunk@44530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-26 12:59:49 +00:00
Dominik Schilling
fe73f310d4
REST API: Prevent translating the hook name in a `_doing_it_wrong()` message by using a placeholder.
...
See #45265 .
Built from https://develop.svn.wordpress.org/trunk@44698
git-svn-id: http://core.svn.wordpress.org/trunk@44529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-26 12:29:54 +00:00
Andrew Ozz
c31e8cf756
TinyMCE Classic Block: fix repositioning of the inline toolbar on scrolling.
...
Props iseulde, azaozz.
Fixes #46062 .
Built from https://develop.svn.wordpress.org/trunk@44697
git-svn-id: http://core.svn.wordpress.org/trunk@44528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-24 11:24:50 +00:00
Andrew Ozz
a6e8abca83
TinyMCE Classic Block: fix the Advanced Link modal (accessible when clicking on the cogwheel in the inline link modal in a Classic Block).
...
Fixes #46071 .
Built from https://develop.svn.wordpress.org/trunk@44696
git-svn-id: http://core.svn.wordpress.org/trunk@44527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-24 11:21:50 +00:00
Andrew Ozz
6bd203bb50
TinyMCE Classic Block: fix the Edit Image modal to work as in the Classic Editor.
...
Fixes #46085 .
Built from https://develop.svn.wordpress.org/trunk@44695
git-svn-id: http://core.svn.wordpress.org/trunk@44526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-24 11:11:51 +00:00
Peter Wilson
2a19ad39db
Docs: Correct documentation for the `schedule_event` filter.
...
The filter runs for both recurring and single events.
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@44694
git-svn-id: http://core.svn.wordpress.org/trunk@44525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-23 23:23:52 +00:00
Peter Wilson
6f337d1195
Cron: Move logic for finding the next event's timestamp.
...
Moves the logic for determining when an event will next run from `wp_next_scheduled()` to `wp_get_scheduled_event()`.
This improves the performance of `wp_get_scheduled_event()` by avoiding duplicate function calls and object cache hits.
Props peterwilsoncc.
Fixes #45976 .
Built from https://develop.svn.wordpress.org/trunk@44693
git-svn-id: http://core.svn.wordpress.org/trunk@44524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-23 23:08:51 +00:00
Peter Wilson
cccba7e224
Plugins: Update docs for individual plugin loaded actions.
...
Corrects documentation to indicate the full path is passed to each action.
Fixes #41346 .
Built from https://develop.svn.wordpress.org/trunk@44692
git-svn-id: http://core.svn.wordpress.org/trunk@44523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-23 03:39:51 +00:00
Peter Wilson
24e8467c6f
Formatting: Prevent `wp_targeted_link_rel()` adding an empty attribute.
...
Bypass adding a `rel` attribute when the `wp_targeted_link_rel` filter returns an empty string or other falsy result.
Props mcmwebsol, spartank, meatman89fs.
Fixes #45352 .
Built from https://develop.svn.wordpress.org/trunk@44691
git-svn-id: http://core.svn.wordpress.org/trunk@44522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-22 21:55:51 +00:00
Felix Arntz
c204ac4bc7
Bootstrap/Load: Fix fatal error when passing a `WP_Error` to `wp_die()`.
...
This was introduced in [44466]. Also, this changeset adds tests for `_wp_die_process_input()` so that this never happens again.
Props dd32.
See #45933 .
Built from https://develop.svn.wordpress.org/trunk@44690
git-svn-id: http://core.svn.wordpress.org/trunk@44521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-22 08:52:50 +00:00
Gary Pendergast
cb25284b2f
Post WordPress 5.1 Beta 2 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@44689
git-svn-id: http://core.svn.wordpress.org/trunk@44520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-22 00:57:50 +00:00
Gary Pendergast
a10a37c6d7
WordPress 5.1 Beta 2.
...
Built from https://develop.svn.wordpress.org/trunk@44688
git-svn-id: http://core.svn.wordpress.org/trunk@44519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-22 00:39:49 +00:00
Gary Pendergast
7d17b53ff2
Blocks: Define the `edit_posts` capability on the `wp_block` post type.
...
Meta capability mapping doesn't recurse through multiple meta definitions, which creates a situation where the capabilities test is looking for the non-existent primitive capability `edit_blocks`, which should instead be mapped to `edit_posts`.
Defining the `edit_posts` capability when the `wp_block` post type is registered causes this check to change to to the `edit_posts` capability.
Props aduth.
Fixes #45373 .
Built from https://develop.svn.wordpress.org/trunk@44687
git-svn-id: http://core.svn.wordpress.org/trunk@44518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-22 00:05:52 +00:00
Gary Pendergast
af73067eb5
Menus: Fix a deprecated call to `get_terms()`.
...
The taxonomy should be passed as part of `$args`, rather than as its own argument.
Props birgire.
Fixes #45297 .
Built from https://develop.svn.wordpress.org/trunk@44686
git-svn-id: http://core.svn.wordpress.org/trunk@44517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-21 23:38:52 +00:00
Gary Pendergast
2d6bf285d4
Menus: Show an appropriate message when no menus exist.
...
Props garrett-eclipse.
Fixes #45155 .
Built from https://develop.svn.wordpress.org/trunk@44685
git-svn-id: http://core.svn.wordpress.org/trunk@44516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-21 23:32:51 +00:00
Gary Pendergast
faf1528d8f
Customiser: Prevent JS errors when previewing pages with an `<area>` tag.
...
The customiser assumes that `<area>` tags will have a `href` attribute, which isn't necessarily true. Now it checks instead of assuming.
Props janthiel, adamsilverstein.
Fixes #45053 .
Built from https://develop.svn.wordpress.org/trunk@44684
git-svn-id: http://core.svn.wordpress.org/trunk@44515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-21 23:03:50 +00:00
Gary Pendergast
64877e74e8
Comments: Default the `show_comments_cookies_opt_in` checkbox to enabled.
...
This also updates the option label, to clarify that it needs to be enabled for comment cookies to work.
Props azaozz, pento, dhavalkasvala, desrosj, pputzer, mirkoschubert, ThemeZee.
Fixes #44736 .
Built from https://develop.svn.wordpress.org/trunk@44683
git-svn-id: http://core.svn.wordpress.org/trunk@44514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-21 22:57:52 +00:00
John Blackbourn
63a2dc94c6
Bootstrap/Load: Update the `@since` entry for `wp_die()`.
...
See #46038
Built from https://develop.svn.wordpress.org/trunk@44682
git-svn-id: http://core.svn.wordpress.org/trunk@44513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-21 22:52:51 +00:00