Dominik Schilling
6e44f060ee
Customizer: Remove an `overflow: hidden` declaration to prevent cutting off the left and right edge focus style of the "Add a Menu" input field.
...
props paulwilde.
fixes #32680 .
Built from https://develop.svn.wordpress.org/trunk@32825
git-svn-id: http://core.svn.wordpress.org/trunk@32796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:43:26 +00:00
Dominik Schilling
5864a7ad44
Customizer: Fix keyboard events for the menu items search field.
...
Replace the `change` event with `keyup`, see https://core.trac.wordpress.org/ticket/26600#comment:59 for background.
props tywayne.
fixes #32677 .
Built from https://develop.svn.wordpress.org/trunk@32824
git-svn-id: http://core.svn.wordpress.org/trunk@32795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:37:27 +00:00
Dominik Schilling
504db9233b
Customizer: Revert the blue on hover color which was introduced in [32649].
...
Blue is meant to be the primary action which isn't the case in this context. Colors need to be revised in #29158 .
see #31336 .
Built from https://develop.svn.wordpress.org/trunk@32823
git-svn-id: http://core.svn.wordpress.org/trunk@32794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:07:27 +00:00
Dominik Schilling
a1f7f4fe17
Customizer: Replace usage of `calc()` with `box-sizing: border-box`.
...
IE8 doesn't support `calc()`.
props afercia.
see #31336 .
fixes #32664 .
Built from https://develop.svn.wordpress.org/trunk@32821
git-svn-id: http://core.svn.wordpress.org/trunk@32792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 19:35:28 +00:00
Boone Gorges
f62bf61b2c
Bail out of 4.3 term splitting routine when no shared terms are found.
...
Props dd32.
See #30261 .
Built from https://develop.svn.wordpress.org/trunk@32819
git-svn-id: http://core.svn.wordpress.org/trunk@32790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 11:40:24 +00:00
Ella Iseulde Van Dorpe
1a4c6ad45d
JSHint after [32806]
...
See #32576 .
Built from https://develop.svn.wordpress.org/trunk@32815
git-svn-id: http://core.svn.wordpress.org/trunk@32786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 04:15:26 +00:00
Boone Gorges
290044ef15
Split all shared taxonomy terms on upgrade to 4.3.
...
Dear Shared Terms, Welcome to Splitsville. Population: You.
See #30261 .
Built from https://develop.svn.wordpress.org/trunk@32814
git-svn-id: http://core.svn.wordpress.org/trunk@32785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 01:53:26 +00:00
Dominik Schilling
ac33d71623
Fix a typo in [32806].
...
see #32576 .
Built from https://develop.svn.wordpress.org/trunk@32808
git-svn-id: http://core.svn.wordpress.org/trunk@32779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 23:09:25 +00:00
Dominik Schilling
62e3a0c15c
Add menu management to the Customizer.
...
This brings in the Menu Customizer plugin: https://wordpress.org/plugins/menu-customizer/ .
props celloexpressions, westonruter, valendesigns, voldemortensen, ocean90, adamsilverstein, kucrut, jorbin, designsimply, afercia, davidakennedy, obenland.
see #32576 .
Built from https://develop.svn.wordpress.org/trunk@32806
git-svn-id: http://core.svn.wordpress.org/trunk@32777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 22:08:26 +00:00
Helen Hou-Sandí
d159cc2272
Media list table: Avoid PHP notices by using the proper variables.
...
Also visually tightens up the row actions.
props tyxla.
fixes #32657 . see #29881 .
Built from https://develop.svn.wordpress.org/trunk@32805
git-svn-id: http://core.svn.wordpress.org/trunk@32776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 21:33:25 +00:00
Scott Taylor
45d5037a10
Avoid using HTML in translation strings in `edit-form-comment.php`.
...
Fixes #31847 .
Built from https://develop.svn.wordpress.org/trunk@32801
git-svn-id: http://core.svn.wordpress.org/trunk@32772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:08:24 +00:00
Scott Taylor
5c6b63d3a6
`if` is a statment, not a function.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32800
git-svn-id: http://core.svn.wordpress.org/trunk@32771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:01:25 +00:00
Scott Taylor
5e14470894
Avoid using `<code>` in a translation string.
...
Props ramiy.
Fixes #31848 .
Built from https://develop.svn.wordpress.org/trunk@32799
git-svn-id: http://core.svn.wordpress.org/trunk@32770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 19:53:27 +00:00
Helen Hou-Sandí
a49c192f37
Media list table: Restore row actions.
...
see #29881 , #32657 .
Built from https://develop.svn.wordpress.org/trunk@32798
git-svn-id: http://core.svn.wordpress.org/trunk@32769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 19:47:24 +00:00
Helen Hou-Sandí
457456ef25
Comments: Better markup for the edit screen.
...
Previously there were no labels, and since labels can't contain links and the links were of dubious value, we've removed those.
props afercia, DrewAPicture.
fixes #31326 .
Built from https://develop.svn.wordpress.org/trunk@32796
git-svn-id: http://core.svn.wordpress.org/trunk@32767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 18:54:26 +00:00
Boone Gorges
66c1d75c1c
Tag/category conversion link on edit-tags.php should point to specific importer page when cat2tag plugin is active.
...
Props solarissmoke, c3mdigital.
Fixes #16369 .
Built from https://develop.svn.wordpress.org/trunk@32792
git-svn-id: http://core.svn.wordpress.org/trunk@32763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 04:30:26 +00:00
Dion Hulse
faf6383ebd
Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key.
...
Props mordauk. Fixes #31784
Built from https://develop.svn.wordpress.org/trunk@32784
git-svn-id: http://core.svn.wordpress.org/trunk@32755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 06:26:25 +00:00
Dion Hulse
c6bb637f89
Updats: Add a filter for the options params for the update being performed.
...
Props nofearinc. Fixes #27754
Built from https://develop.svn.wordpress.org/trunk@32783
git-svn-id: http://core.svn.wordpress.org/trunk@32754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 05:35:26 +00:00
Dion Hulse
c726f72ea4
Updates: Allow the update row to include the active border styling post-ajax update.
...
Props TobiasBg. Fixes #32129
Built from https://develop.svn.wordpress.org/trunk@32782
git-svn-id: http://core.svn.wordpress.org/trunk@32753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 05:13:25 +00:00
Dion Hulse
b881a541bb
Updates: Remove redundant title tags from update outputs.
...
Props afercia. Fixes #32530
Built from https://develop.svn.wordpress.org/trunk@32781
git-svn-id: http://core.svn.wordpress.org/trunk@32752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 05:09:25 +00:00
Dion Hulse
629545aaf5
Updates: When an update fails (and it's not during the credential form) allow further updates to continue, with the assumption that the error only affects a single plugin.
...
Props magicroundabout. Fixes #32110 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32780
git-svn-id: http://core.svn.wordpress.org/trunk@32751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 04:28:25 +00:00
Dion Hulse
6eef8a8ff2
Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners.
...
Fixes #32435 , #32473
Built from https://develop.svn.wordpress.org/trunk@32779
git-svn-id: http://core.svn.wordpress.org/trunk@32750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:48:28 +00:00
Dion Hulse
0eb8bfc464
Updates: When a error occurs during the connection phase, pass the error message back as the ajax failure message.
...
See #32435
Built from https://develop.svn.wordpress.org/trunk@32778
git-svn-id: http://core.svn.wordpress.org/trunk@32749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:32:27 +00:00
Dion Hulse
04325cd834
Updates: Better handling when the credential form is long (such as when SSH is active). This adds scrolling to the dialogue, and hides the SSH-specific fields when not using the SSH handler.
...
See #32435
Built from https://develop.svn.wordpress.org/trunk@32777
git-svn-id: http://core.svn.wordpress.org/trunk@32748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:20:28 +00:00
Dion Hulse
a4b4918377
Updates: When a connection failure occurs, and no credential form is present client side, allow it to fall through to the normal failure handlers.
...
See #32435
Built from https://develop.svn.wordpress.org/trunk@32776
git-svn-id: http://core.svn.wordpress.org/trunk@32747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 02:48:28 +00:00
Helen Hou-Sandí
e3ae4f9d7e
Multisite: Use an email input for new user email address.
...
We also need to set novalidate on the form due to some browsers rejecting valid email addresses containing an IDN. We should holistically investigate whether this is still an issue in any major browsers at some point.
props earnjam.
fixes #32643 .
Built from https://develop.svn.wordpress.org/trunk@32774
git-svn-id: http://core.svn.wordpress.org/trunk@32745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 20:41:27 +00:00
Helen Hou-Sandí
ed46512c20
Reduce form spacing on narrower screens.
...
props liljimmi.
fixes #32489 , #32484 .
Built from https://develop.svn.wordpress.org/trunk@32772
git-svn-id: http://core.svn.wordpress.org/trunk@32743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 20:12:26 +00:00
Andrew Nacin
e7f618d86e
Tweak the first post/page content to get with the times.
...
props chriscct7.
fixes #22474 .
Built from https://develop.svn.wordpress.org/trunk@32768
git-svn-id: http://core.svn.wordpress.org/trunk@32739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 18:56:50 +00:00
Jeremy Felt
8daec04557
Remove a now unused `switch_to_blog()` and `restore_current_blog()` in site-info.php
...
Now that we decide when to automatically update `home` and `siteurl`, we no longer need to switch to the site while displaying the form output.
See #32503 .
Built from https://develop.svn.wordpress.org/trunk@32761
git-svn-id: http://core.svn.wordpress.org/trunk@32732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 08:23:26 +00:00
Jeremy Felt
da35c25fb7
Remove the "Update siteurl and home as well" checkbox when editing a site
...
Rather than provide a checkbox to update the `siteurl` and `home` options, we can make an educated decision based on the current state. If the home and/or siteurl domain and path match the existing domain and path of the site, then we update with the new information.
Also, while scheme is not stored in `wp_blogs` along with a site, the scheme of the `home` and `siteurl` options can now be modified via the Site URL setting in `site-info.php` when the `home` and/or `siteurl` options match the existing domain.
Props @hugobaeta, @earnjam, @jeremyfelt.
Fixes #32503 , see #22383 .
Built from https://develop.svn.wordpress.org/trunk@32760
git-svn-id: http://core.svn.wordpress.org/trunk@32731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 07:52:24 +00:00
Jeremy Felt
186c37a325
Capture domain and path when editing sites on a subdomain network
...
When a network is configured as subdomain, allow for the input of arbitrary domain and path combinations when editing a site rather than just the domain.
This takes a step or two toward #32503 .
Props @scribu, @ericlewis, @jeremyfelt.
See #22383 .
Built from https://develop.svn.wordpress.org/trunk@32759
git-svn-id: http://core.svn.wordpress.org/trunk@32730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 07:09:25 +00:00
Jeremy Felt
f996e163b8
Improve code readability in site-info.php
...
In advance of some other work here, clean up some braces and spaces.
See #22383 .
Built from https://develop.svn.wordpress.org/trunk@32758
git-svn-id: http://core.svn.wordpress.org/trunk@32729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 05:01:28 +00:00
Scott Taylor
4348074f3a
In `WP_MS_Users_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - there is a small amount of logic that requires overriding, otherwise it is largely the same as the parent method
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32757
git-svn-id: http://core.svn.wordpress.org/trunk@32728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 17:11:26 +00:00
Scott Taylor
3855cfbffd
In `WP_MS_Themes_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32756
git-svn-id: http://core.svn.wordpress.org/trunk@32727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 16:54:26 +00:00
Scott Taylor
2bdcc71bc0
In `WP_MS_Sites_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - it could inherit from `WP_List_Table` if we can find a way to handle the `id` column. When that happens, we can ditch this method.
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32755
git-svn-id: http://core.svn.wordpress.org/trunk@32726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 16:23:25 +00:00
Scott Taylor
ba8cfcab71
In `WP_Media_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32754
git-svn-id: http://core.svn.wordpress.org/trunk@32725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:57:27 +00:00
Scott Taylor
a56576edfe
In `WP_Links_List_Table::display_rows()`:
...
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32753
git-svn-id: http://core.svn.wordpress.org/trunk@32724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:33:25 +00:00
Scott Taylor
b8eb353590
In `WP_Posts_List_Table`, move the `<th>` markup out of `->column_cb()`.
...
See #29881 , [32740].
Built from https://develop.svn.wordpress.org/trunk@32752
git-svn-id: http://core.svn.wordpress.org/trunk@32723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:14:24 +00:00
Scott Taylor
18827ed337
In `wp_ajax_hidden_columns()`, don't `explode()` on an empty string.
...
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.
This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.
Props afercia, wonderboymusic.
Fixes #32466 .
Built from https://develop.svn.wordpress.org/trunk@32751
git-svn-id: http://core.svn.wordpress.org/trunk@32722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:00:25 +00:00
Scott Taylor
da0400e273
In `WP_Posts_List_Table::column_title()`, use `is_post_type_hierarchical()` instead of `$this->hierarchical_display` in the logic to determine whether `the_excerpt()` should be called.
...
Fixes #32187 .
Built from https://develop.svn.wordpress.org/trunk@32749
git-svn-id: http://core.svn.wordpress.org/trunk@32720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:42:26 +00:00
Dominik Schilling
fe31ed1e5f
Nav menu: Allow the sortable items selector in `wpNavMenu` to be overridden.
...
props adamsilverstein.
fixes #32633 .
Built from https://develop.svn.wordpress.org/trunk@32745
git-svn-id: http://core.svn.wordpress.org/trunk@32716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:03:25 +00:00
Weston Ruter
40ad21b58b
Fix regressions from [32649] wrt Customizer `expanded` and `active` state changes for sections.
...
The `args.completeCallback` was not always called when `onChangeExpanded()` was called. And when a section became inactive (`active` state goes to `false`) and it was currently `expanded`, the Customizer panel would then becomes blank as the section was hidden; it needed to `collapse()` the section first before hiding the element.
See #31336 .
Built from https://develop.svn.wordpress.org/trunk@32743
git-svn-id: http://core.svn.wordpress.org/trunk@32714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 22:28:25 +00:00
Scott Taylor
c11e433858
After [32740], in `WP_Posts_List_Table::single_row()` - `$lock_holder` is checked but unused, so the call to `get_userdata()` is unnecessary.
...
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32742
git-svn-id: http://core.svn.wordpress.org/trunk@32713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 20:48:26 +00:00
Scott Taylor
c1c7a7c14c
After [32740], correct doc block typo.
...
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32741
git-svn-id: http://core.svn.wordpress.org/trunk@32712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 20:29:26 +00:00
Scott Taylor
3f4cadf4aa
Override `->single_row_columns()` in `WP_Posts_List_Table`.
...
Break apart the giant `switch` statement in `->single_row()` into `column_{$column_name}` methods.
To maintain the `->single_row_columns( $item )` interface, add a property, `$current_level`, to allow access to `$level`.
This list table class is now easier to subclass.
Props joehoyle, wonderboymusic.
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32740
git-svn-id: http://core.svn.wordpress.org/trunk@32711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 20:18:24 +00:00
Scott Taylor
d0aa8e4a6e
In `WP_Terms_List_Table::display_rows_or_placeholder()`:
...
* `get_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* The 2nd call to `get_terms()` can be removed, it is redundant #OPTIMIZATION
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32739
git-svn-id: http://core.svn.wordpress.org/trunk@32710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:55:25 +00:00
Scott Taylor
da4c3d0fe4
In `WP_Posts_List_Table::single_row()`:
...
* `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* Correct the `@param` doc blocks
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32738
git-svn-id: http://core.svn.wordpress.org/trunk@32709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:50:25 +00:00
Scott Taylor
4835310a18
In `WP_Media_List_Table::display_rows()`, `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32737
git-svn-id: http://core.svn.wordpress.org/trunk@32708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:45:25 +00:00
Scott Taylor
f88b42be94
In `WP_Comments_List_Table::column_comment()`, `$post` and `$the_comment_status` are unused, as is the `$comment_status` global.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32736
git-svn-id: http://core.svn.wordpress.org/trunk@32707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:39:25 +00:00
Scott Taylor
55b3ec92f4
Fix some malformed doc blocks in `Custom_Image_Header`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32735
git-svn-id: http://core.svn.wordpress.org/trunk@32706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:35:26 +00:00