Drew Jaynes
d4dd02b4ae
Remove backticks on `$post` variables in some short parameter descriptions.
...
See [28653], [28654].
See #28388 .
Built from https://develop.svn.wordpress.org/trunk@28976
git-svn-id: http://core.svn.wordpress.org/trunk@28765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-03 19:28:14 +00:00
Sergey Biryukov
5f0b156155
Prevent bulk actions from being performed when Filter button is clicked.
...
props jesin.
fixes #28555 .
Built from https://develop.svn.wordpress.org/trunk@28916
git-svn-id: http://core.svn.wordpress.org/trunk@28715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-30 01:10:15 +00:00
Sergey Biryukov
5bd180bcbd
Revert [28766].
...
see #28555 .
Built from https://develop.svn.wordpress.org/trunk@28772
git-svn-id: http://core.svn.wordpress.org/trunk@28585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-18 02:23:13 +00:00
Sergey Biryukov
cd7618399e
Prevent bulk actions from being performed when Filter button is clicked.
...
props layotte.
fixes #28555 .
Built from https://develop.svn.wordpress.org/trunk@28766
git-svn-id: http://core.svn.wordpress.org/trunk@28579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-17 22:17:14 +00:00
Helen Hou-Sandí
b5ef672c6b
Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further.
...
props ericlewis, shaunandrews, wonderboymusic.
see #24716 .
Built from https://develop.svn.wordpress.org/trunk@28682
git-svn-id: http://core.svn.wordpress.org/trunk@28500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-05 22:01:18 +00:00
Scott Taylor
85f73cf458
Classes that have `__set()` also need `__isset()` and `__unset()`.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28524
git-svn-id: http://core.svn.wordpress.org/trunk@28350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:52:14 +00:00
Scott Taylor
821246b4ae
Some classes with `__get()` method also need `__set()`.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28521
git-svn-id: http://core.svn.wordpress.org/trunk@28347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:31:15 +00:00
Scott Taylor
2f513d3320
Fix some `hackificator` odds and ends in `wp-admin`:
...
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28500
git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:04:16 +00:00
Scott Taylor
130771a383
`hackificator` doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28497
git-svn-id: http://core.svn.wordpress.org/trunk@28323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:59:15 +00:00
Scott Taylor
d28f6344de
Add access modifiers to methods and members of list table classes:
...
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28493
git-svn-id: http://core.svn.wordpress.org/trunk@28319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:17:15 +00:00
Scott Taylor
aef35fe6a2
Eliminate use of `extract()` in `WP_List_Table::pagination()`:
...
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28389
git-svn-id: http://core.svn.wordpress.org/trunk@28217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:27:14 +00:00
Scott Taylor
192e235672
Eliminate use of `extract()` in `WP_List_Table::ajax_response()`:
...
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28387
git-svn-id: http://core.svn.wordpress.org/trunk@28215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:14:14 +00:00
Scott Taylor
08d73b9e23
Eliminate use of `extract()` in `WP_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28386
git-svn-id: http://core.svn.wordpress.org/trunk@28214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:08:13 +00:00
Scott Taylor
ded4871368
In `WP_List_Table::display_rows_or_placeholder()`, the call to `get_column_info()` in unnecessary and unused. The call to `get_column_count()` immediately after makes the same call internally.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28279
git-svn-id: http://core.svn.wordpress.org/trunk@28107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 05:32:15 +00:00
Dominik Schilling
d1f3abe55c
Remove "Show" prefix from filter dropdowns, see #26743 .
...
Built from https://develop.svn.wordpress.org/trunk@27626
git-svn-id: http://core.svn.wordpress.org/trunk@27469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 22:13:14 +00:00
Sergey Biryukov
f29df4f74c
Remove duplicate description of WP_List_Table class.
...
props bravokeyl.
fixes #27346 .
Built from https://develop.svn.wordpress.org/trunk@27502
git-svn-id: http://core.svn.wordpress.org/trunk@27345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-11 16:23:15 +00:00
Andrew Ozz
87589dd445
Remove table cellspacing attribute from the admin, part-props MattyRob, fixes #22086 .
...
Built from https://develop.svn.wordpress.org/trunk@27036
git-svn-id: http://core.svn.wordpress.org/trunk@26912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 20:28:12 +00:00
Drew Jaynes
73f42e01a2
Inline documentation for hooks in wp-admin/includes/class-wp-list-table.php.
...
Props miyauchi, kpdesign.
Fixes 25848.
Built from https://develop.svn.wordpress.org/trunk@26401
git-svn-id: http://core.svn.wordpress.org/trunk@26301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 08:12:09 +00:00
Helen Hou-Sandí
9796e54574
Saner CSS for row actions - now we can just target `.row-actions` instead of both `.row-actions` and `.row-actions-visible`. CSS for `.row-actions-visible` remains for now due to usage in plugins. Visibility is controlled by toggling a `.visible` class. fixes #25403 .
...
Built from https://develop.svn.wordpress.org/trunk@25592
git-svn-id: http://core.svn.wordpress.org/trunk@25509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 01:54:09 +00:00
Drew Jaynes
c5abe8acaa
Make the `WP_List_Table::months_dropdown()` query results filterable.
...
Introduces the `months_dropdown_results` filter.
Fixes #17022 .
Built from https://develop.svn.wordpress.org/trunk@25556
git-svn-id: http://core.svn.wordpress.org/trunk@25476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 18:35:09 +00:00
Helen Hou-Sandí
6c121d303d
Add a class to the bulk actions wrapper div. props nofearinc. fixes #25197 .
...
Built from https://develop.svn.wordpress.org/trunk@25509
git-svn-id: http://core.svn.wordpress.org/trunk@25429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-19 21:01:09 +00:00
Scott Taylor
31f26dc3ce
Remove lingering instances of call time pass-by-reference, limited to instances of `callable` - use `$this` instead of `&$this`.
...
Props jdgrimes.
See #25160 .
Built from https://develop.svn.wordpress.org/trunk@25254
git-svn-id: http://core.svn.wordpress.org/trunk@25222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 16:34:09 +00:00
Sergey Biryukov
dace3f0b6d
Remove redundant echo calls from list tables. Don't mix string concatenation with direct output. see #24210 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 01:10:50 +00:00
Helen Hou-Sandí
b1f1579604
its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-20 15:55:32 +00:00
Andrew Ozz
cbd737470c
Kill use of colons in class names, props SergeyBiryukov, fixes #21152
...
git-svn-id: http://core.svn.wordpress.org/trunk@22396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 01:01:52 +00:00
Ryan Boren
44774b52ab
Fix strict warnings for WP_Plugins_List_Table::bulk_actions() and WP_Plugins_List_Table::single_row(). Props kurtpayne. fixes #22224
...
git-svn-id: http://core.svn.wordpress.org/trunk@22376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 18:29:20 +00:00
Andrew Nacin
c1b0670c2d
Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 19:34:23 +00:00
Ryan Boren
a3cfe28527
Reduce reliance on global variables in the list tables. Allow passing a screen ID to the list tables so that ajax handlers can set the needed screen.
...
Props nacin
fixes #21871
git-svn-id: http://core.svn.wordpress.org/trunk@21914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 12:43:31 +00:00
Daryl Koopersmith
67894a3407
New button styles.
...
Using the new buttons:
* Button classes are now stackable.
* All buttons should use a base class of "button".
* Buttons default to the gray style (formerly "button-secondary"). Buttons can add a style by adding additional classes. To make a primary button, add the "button-primary" class.
* Buttons can be rendered in various sizes. In addition to the default size, you can add "button-large", "button-small", or "button-tiny".
For backwards compatibility reasons, "button-primary" and "button-secondary" both work as standalone classes.
get_submit_button() has been adjusted to handle shorthand button classes (i.e. button classes can be passed without the "button-" prefix).
props lessbloat, helenyhou, trepmal, nacin. see #21598 .
git-svn-id: http://core.svn.wordpress.org/trunk@21789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-08 04:58:34 +00:00
Ryan Boren
fd3b312310
Remove the filter setting when searching media. Props helenyhou. fixes #19452
...
git-svn-id: http://core.svn.wordpress.org/trunk@21750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 21:20:51 +00:00
Ryan Boren
c55cf716da
Use set_url_scheme(). Props johnbillion, MarcusPope. see #19037 #20759
...
git-svn-id: http://core.svn.wordpress.org/trunk@21664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-30 13:33:00 +00:00
ryan
73addbbd24
More screen reader text for list table checkboxes and theme install search. Props MikeLittle, SergeyBiryukov. see #21325
...
git-svn-id: http://core.svn.wordpress.org/trunk@21323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 16:18:14 +00:00
ryan
c36145c9aa
Add screen reader text to checkboxes in list tables. Props MikeLittle, nacin. see #21325
...
git-svn-id: http://core.svn.wordpress.org/trunk@21317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-24 18:01:22 +00:00
nacin
1af728f890
Remove type='number' from list table page inputs out of a concern for UX, as well as styling issues. fixes #20247 . see #17863 for further discussion.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-16 04:04:07 +00:00
azaozz
f3b63e4537
Set proper HTML5 input types in the admin, props georgestephanis, fixes #17863
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-10 01:23:48 +00:00
koopersmith
e251ff1c04
Partially revert [20100]. The list_args JS variable cannot be extended due to its use as an argument in fetch-list. see #19815 .
...
We should reattempt extending the args created in WP_List_Table, but will need to deprecate the current list_args to do so.
Also, infinite scroll on themes pages is no longer broken. Go team.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-03 02:40:43 +00:00
nacin
1fed7c5c11
Allow WP_List_Table::_js_vars() to take an array of additional args to add. Allows us to have a single variable printing data when child classes need more data. Also, fix compact() call in [20094]. see #19815 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 23:06:31 +00:00
nacin
05313daa77
Output themes and theme-install infinite scrolling args in JS, rather than parsing query strings. props DH-Shredder, helenyhou. Make WP_Theme_Install_List_Table extend WP_Themes_List_Table. Doesn't help much yet, but we should be able to dry things up further. see #19815 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 22:09:26 +00:00
nacin
e23bba5249
Use existing string to properly translate month + year combo. see #19598 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-03 00:11:01 +00:00
ryan
e3b46b25d3
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
nacin
3e61e179d9
Sanitize plural and singular args for list tables. props sbressler, fixes #18875 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-19 23:51:06 +00:00
koopersmith
2d3fa6fcb8
Make screen options a help tab. Move screen option functions into WP_Screen. see #18690 , #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-01 00:24:44 +00:00
duck_
c1d1590171
Fix typos in documentation (wp-admin/). See #18560 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-03 14:18:10 +00:00
ryan
2521eb5f17
Update phpdoc for WP_List_Table::views(). Props Viper007Bond. fixes #18358
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-25 17:56:34 +00:00
ryan
daa14c36f9
Bring out the pinking shears.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-10 23:01:45 +00:00
azaozz
ec2778daa9
Do not run bulk edit when the user clicks on a filter, fixes #17733
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-10 00:01:16 +00:00
markjaquith
0e57bd3a37
Centralize pagination bound exceeding redirects for list tables. props garyc40. props johnjamesjacoby. fixes #16208
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 06:09:42 +00:00
ryan
a7909cf4b6
Always show # items text. Props johnbillion. fixes #17260
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-04 19:45:41 +00:00
ryan
04487fc268
Constructor cleanup. Props ocean90. fixes #16768
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-29 20:05:12 +00:00
nacin
c6edeffa66
Avoid printf entirely. props SergeyBiryukov, fixes #16611 for trunk.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-02-22 10:12:38 +00:00