Scott Taylor
a99f7baa5a
List Tables: Fix PHP error notice when `$columns` is `null`
...
Use of `register_column_headers()` and `print_column_headers()` creates a `_WP_List_Table_Compat` without any columns. When the List Table object doesn't have any columns, there's naturally no primary column.
Props danielbachhuber.
Fixes #34148 .
Built from https://develop.svn.wordpress.org/trunk@35698
git-svn-id: http://core.svn.wordpress.org/trunk@35662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 23:01:26 +00:00
Jeremy Felt
f7b29ecd1b
Multisite: Re-Account for striped table rows with `.site-*` classes.
...
[34356] removed the table row specificity on rules for `.site-deleted`, `.site-spammed`, `.site-archived`, and `.site-matured` so that the styles would be properly applied to other elements. Now, the zebra striping rules override these styles on even rows.
We can account for `tr` specific and more generic applications of these classes.
Fixes #33595 .
Built from https://develop.svn.wordpress.org/trunk@35692
git-svn-id: http://core.svn.wordpress.org/trunk@35656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 21:59:26 +00:00
Boone Gorges
b17cb707dc
Eliminate a db query when building the admin menu for non-privileged users.
...
Users who cannot `edit_posts` do not see the Comments nav item anyway, so
don't bother running a query that gets a comment count to display in the menu.
Props bordoni, johnbillion.
Fixes #19372 .
Built from https://develop.svn.wordpress.org/trunk@35691
git-svn-id: http://core.svn.wordpress.org/trunk@35655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 21:34:26 +00:00
Aaron Jorbin
e8d8e79371
Revert [34291] bringing back my-hacks
...
Keeping myhacks support is a small price to pay for not breaking people's sites. Even if it is very very very few sites, breaking sites isn't something that should be encouraged. Even with 10 years of deprecation notices.
https://core.trac.wordpress.org/ticket/33741#comment:18 outlines all the ways that the hack_file and my-hacks options can be setup and thus all the ways that the removal of those options could break sites.
Fixes #33741 .
Built from https://develop.svn.wordpress.org/trunk@35688
git-svn-id: http://core.svn.wordpress.org/trunk@35652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:49:26 +00:00
Dominik Schilling
c25efe2d52
Revert [35336] and [35337].
...
See #28344 .
Built from https://develop.svn.wordpress.org/trunk@35685
git-svn-id: http://core.svn.wordpress.org/trunk@35649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:30:25 +00:00
Aaron Jorbin
d507b5636f
Set cssmin compatibility to ie7
...
This matches the autoprefixer setting. This changes all compiled CSS.
Fixes #34540 .
Props christophherr, peterwilsoncc, netweb
Built from https://develop.svn.wordpress.org/trunk@35684
git-svn-id: http://core.svn.wordpress.org/trunk@35648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:28:25 +00:00
Scott Taylor
19834a4c21
List Tables: After [35622] and [34271], improve pagination logic when queries are altered.
...
Props bradyvercher.
Fixes #29870 .
Built from https://develop.svn.wordpress.org/trunk@35683
git-svn-id: http://core.svn.wordpress.org/trunk@35647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:25:26 +00:00
Scott Taylor
af0498989c
List Tables: After [34728], don't try to infer `orderby` from query params.
...
List tables are really good.
Props cklosows.
Fixes #25493 .
Built from https://develop.svn.wordpress.org/trunk@35682
git-svn-id: http://core.svn.wordpress.org/trunk@35646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:19:26 +00:00
Scott Taylor
8caf5d9759
Plugins: add dismissible notices to update failures.
...
Adds unit test.
Props afercia, mehulkaklotar.
Fixes #33465 .
Built from https://develop.svn.wordpress.org/trunk@35681
git-svn-id: http://core.svn.wordpress.org/trunk@35645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:10:26 +00:00
Scott Taylor
f2e9e98fa6
Media: in `media_send_to_editor()`, use `wp_json_encode()` instead of `addslashes()`.
...
Props TobiasBg.
Fixes #22135 .
Built from https://develop.svn.wordpress.org/trunk@35677
git-svn-id: http://core.svn.wordpress.org/trunk@35641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:40:27 +00:00
Scott Taylor
838592c1ba
List Tables: because we can never eradicate the existence of globals, ensure that `$comment` is hoisted into the global space inside `WP_Comments_List_Table::single_row()`.
...
Fixes #34654 .
Built from https://develop.svn.wordpress.org/trunk@35674
git-svn-id: http://core.svn.wordpress.org/trunk@35638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:05:30 +00:00
Scott Taylor
f0bbe00890
After [35616], improve the consistency of tabs styling.
...
Props afercia.
Fixes #34214 .
Built from https://develop.svn.wordpress.org/trunk@35673
git-svn-id: http://core.svn.wordpress.org/trunk@35637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 18:55:26 +00:00
Sergey Biryukov
bc41f44158
I18N: After [34424], replace the placeholder with comments count after `translate_nooped_plural()` runs, not before.
...
Props hnle.
Fixes #34680 .
Built from https://develop.svn.wordpress.org/trunk@35670
git-svn-id: http://core.svn.wordpress.org/trunk@35634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 18:04:28 +00:00
Drew Jaynes
283b7d0a66
Plugins: Rename the `delete_plugin` action hook (introduced in [35094]) to `deleted_plugin` as it fires ''following'' a plugin deletion attempt.
...
Further, introduce a new `delete_plugin` action hook, to be fired ''before'' a plugin deletion attempt. Both changes bring parity with other such transactional hooks in core that fire before and after certain actions, including on plugin activation/deactivation and install/uninstall, among others.
Props johnjamesjacoby.
Fixes #26904 .
Built from https://develop.svn.wordpress.org/trunk@35669
git-svn-id: http://core.svn.wordpress.org/trunk@35633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:58:26 +00:00
Sergey Biryukov
0d4cf36199
I18N: Remove `<a>` tag from translatable string in `wp-admin/includes/class-wp-comments-list-table.php`.
...
Props ramiy.
Fixes #34686 .
Built from https://develop.svn.wordpress.org/trunk@35666
git-svn-id: http://core.svn.wordpress.org/trunk@35630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:34:27 +00:00
Sergey Biryukov
7cb5ca6b33
I18N: Remove `<a>` tag from translatable string in `wp-admin/comment.php`.
...
Props ramiy.
See #34686 .
Built from https://develop.svn.wordpress.org/trunk@35665
git-svn-id: http://core.svn.wordpress.org/trunk@35629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:33:30 +00:00
Sergey Biryukov
5539193dd0
I18N: Add translator comments for strings in `wp-admin/includes/class-wp-filesystem-ftpsockets.php`.
...
Fixes #34684 .
Built from https://develop.svn.wordpress.org/trunk@35664
git-svn-id: http://core.svn.wordpress.org/trunk@35628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:23:29 +00:00
Sergey Biryukov
a7c5161db1
I18N: Add translator comments for strings in `wp-admin/includes/class-wp-filesystem-ftpext.php`.
...
See #34684 .
Built from https://develop.svn.wordpress.org/trunk@35663
git-svn-id: http://core.svn.wordpress.org/trunk@35627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:22:27 +00:00
Sergey Biryukov
0237fadd3a
I18N: Add translator comments for strings in `wp-admin/includes/class-wp-filesystem-base.php`.
...
See #34684 .
Built from https://develop.svn.wordpress.org/trunk@35662
git-svn-id: http://core.svn.wordpress.org/trunk@35626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:21:26 +00:00
Sergey Biryukov
6b94d7c89c
I18N: Add translator comments for strings in `wp-admin/includes/class-wp-filesystem-ssh2.php`.
...
Props ramiy.
See #34684 .
Built from https://develop.svn.wordpress.org/trunk@35661
git-svn-id: http://core.svn.wordpress.org/trunk@35625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:18:40 +00:00
Dominik Schilling
9df7c4edea
Passwords: Only disable hidden password fields if they are really hidden.
...
Makes the password field on install and for password resets editable again. Both fields were accidentally set to disabled in [35603].
Props adamsilverstein, flixos90.
Fixes #33699 .
Built from https://develop.svn.wordpress.org/trunk@35649
git-svn-id: http://core.svn.wordpress.org/trunk@35613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 20:49:26 +00:00
Dominik Schilling
c29fe96196
Thickbox: Change only the `background-image` property for HiDPI screens.
...
`background` resets `background-size` and makes the spinner fuzzy. Introduced in [35418].
See #33311 .
Built from https://develop.svn.wordpress.org/trunk@35648
git-svn-id: http://core.svn.wordpress.org/trunk@35612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 20:33:25 +00:00
Dominik Schilling
a7848ea08b
Themes: Hide the favorites form when performing a search.
...
The search is global and ignores the user setting. Same for filters.
See #34206 .
Built from https://develop.svn.wordpress.org/trunk@35647
git-svn-id: http://core.svn.wordpress.org/trunk@35611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 19:50:26 +00:00
Dominik Schilling
99f4fc4404
Themes: Check if the browse view is set in `wp_ajax_query_themes()` to avoid a PHP notice when searching for new themes.
...
Introduced in [35527].
See #34206 .
Built from https://develop.svn.wordpress.org/trunk@35646
git-svn-id: http://core.svn.wordpress.org/trunk@35610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 19:47:54 +00:00
Dion Hulse
42ff945649
Decrease the chances that `wp_tempnam()` will conflict with an existing file by suffixing a random ID to the generated filename.
...
This also switches from using `touch()` to using `fopen( $file, 'x')` to ensure that we're the process creating the file.
Fixes #34562
Built from https://develop.svn.wordpress.org/trunk@35644
git-svn-id: http://core.svn.wordpress.org/trunk@35608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 05:33:25 +00:00
Weston Ruter
acba061485
Customize: Ensure multi-line label alignment for checkbox/radio inputs on both desktop and mobile.
...
Follow-up to [35608].
Props bordoni, delawski.
Fixes #34607 .
Built from https://develop.svn.wordpress.org/trunk@35643
git-svn-id: http://core.svn.wordpress.org/trunk@35607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 04:44:26 +00:00
Dion Hulse
be94558c46
Upgrader: Pass the `$args['hook_extra']` context to the `upgrader_source_selection` filter.
...
Props afragen
Fixes #34696
Built from https://develop.svn.wordpress.org/trunk@35642
git-svn-id: http://core.svn.wordpress.org/trunk@35606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 02:47:25 +00:00
Dominik Schilling
40b303069a
Schema: Increase length of `user_pass` and `user_activation_key` fields to 255.
...
Props grvrulz and Miglosh for testing.
Fixes #33904 .
Built from https://develop.svn.wordpress.org/trunk@35638
git-svn-id: http://core.svn.wordpress.org/trunk@35602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-15 14:19:28 +00:00
Helen Hou-Sandí
ae9e173082
Buttons: Standardize on `.button-link` for link-like buttons.
...
This serves as both a reset and some basic styling. The class name also aligns with parallel components in other popular projects.
props paulwilde for the initial patch.
fixes #34242 .
Built from https://develop.svn.wordpress.org/trunk@35636
git-svn-id: http://core.svn.wordpress.org/trunk@35600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-13 15:47:27 +00:00
Sergey Biryukov
95c55ca251
Cast `'illegal_user_logins'` filter result to array.
...
See #27317 .
Built from https://develop.svn.wordpress.org/trunk@35630
git-svn-id: http://core.svn.wordpress.org/trunk@35594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 16:34:27 +00:00
Sergey Biryukov
b08ae1d60b
Users: After [35189], make `'illegal_user_logins'` check case-insensitive.
...
Props juliobox.
Fixes #27317 .
Built from https://develop.svn.wordpress.org/trunk@35629
git-svn-id: http://core.svn.wordpress.org/trunk@35593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 16:30:28 +00:00
Gary Pendergast
6381e168b7
Pinking Shears: Remove some errant non-breaking spaces from a few JavaScript files.
...
Props francoisb.
Fixes #34658 .
Built from https://develop.svn.wordpress.org/trunk@35627
git-svn-id: http://core.svn.wordpress.org/trunk@35591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 12:04:27 +00:00
Scott Taylor
128a9c3acd
List Tables: after [34271], account for searches when calculating pagination.
...
Fixes #29870 .
Built from https://develop.svn.wordpress.org/trunk@35622
git-svn-id: http://core.svn.wordpress.org/trunk@35586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 23:14:26 +00:00
Dominik Schilling
1f15d30396
Upgrade: Revert [34543] because of incomplete and incorrect functionality.
...
See #33932 .
Fixes #34434 .
Built from https://develop.svn.wordpress.org/trunk@35619
git-svn-id: http://core.svn.wordpress.org/trunk@35583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 22:46:26 +00:00
Scott Taylor
b4daf516ec
Help/About: unify tab styling.
...
Props afercia.
Fixes #34214 .
Built from https://develop.svn.wordpress.org/trunk@35616
git-svn-id: http://core.svn.wordpress.org/trunk@35580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 21:54:26 +00:00
Dominik Schilling
27e4384e89
Comments: Dynamically update the document title text for all languages, not only English.
...
See [33821].
Fixes #33414 .
Built from https://develop.svn.wordpress.org/trunk@35615
git-svn-id: http://core.svn.wordpress.org/trunk@35579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 21:00:27 +00:00
Sergey Biryukov
db8c89cccb
Remove non-translatable HTML code from the first post content in `populate_network()` and `wp_install_defaults()`.
...
Add translator comment.
Props ramiy.
Fixes #34619 .
Built from https://develop.svn.wordpress.org/trunk@35614
git-svn-id: http://core.svn.wordpress.org/trunk@35578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 20:55:26 +00:00
Sergey Biryukov
d206e633c2
Users: Only show the profile picture if 'Show Avatars' option in Discussion Settings is enabled.
...
Props ocean90.
See #32286 .
Built from https://develop.svn.wordpress.org/trunk@35613
git-svn-id: http://core.svn.wordpress.org/trunk@35577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 19:41:25 +00:00
Dominik Schilling
0251086dec
About: Don't use `_n_noop()` for singular/plural strings which provide no placeholder for a number.
...
This allows for using proper plural forms in languages with more than two forms.
Props SergeyBiryukov.
Fixes #34307 .
See #28502 .
Built from https://develop.svn.wordpress.org/trunk@35611
git-svn-id: http://core.svn.wordpress.org/trunk@35575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 19:29:25 +00:00
Sergey Biryukov
694ff83cc6
Users: Add user's Gravatar to 'About the user' section on user profile page.
...
Add `user_profile_picture_description` filter for the description text displayed under the Gravatar.
Props carolinegeven, obrienlabs, SergeyBiryukov.
Fixes #32286 .
Built from https://develop.svn.wordpress.org/trunk@35610
git-svn-id: http://core.svn.wordpress.org/trunk@35574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 19:28:28 +00:00
Andrea Fercia
62e236b3c6
Accessibility: Improve form labels and descriptions for the Tags meta box in the Edit Post screen.
...
Fixes #34627 .
Built from https://develop.svn.wordpress.org/trunk@35609
git-svn-id: http://core.svn.wordpress.org/trunk@35573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 15:24:29 +00:00
Weston Ruter
025074bbda
Customize: Prevent multi-line checkbox control labels from wrapping under checkbox.
...
Props bordoni.
Fixes #34607 .
Built from https://develop.svn.wordpress.org/trunk@35608
git-svn-id: http://core.svn.wordpress.org/trunk@35572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 09:37:27 +00:00
Andrea Fercia
5f93491286
Accessibility: improvements for the taxonomies Quick Edit form.
...
Changes the "Cancel" and "Update" controls in buttons for better semantics and
accessibility. On cancel and successful saving, moves focus back to the term title
to avoid a focus loss. Dispatches error and success messages to `wp.a11y.speak`
to give assistive technologies users an audible feedback.
Patch prepared at #wpcdit, first Italian WordPress Contributor Day.
Props garusky, chiara_09.
Fixes #34613 .
Built from https://develop.svn.wordpress.org/trunk@35605
git-svn-id: http://core.svn.wordpress.org/trunk@35569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 00:24:28 +00:00
Drew Jaynes
eba05b2c98
Permalinks: Use "Plain" instead of "None" for the `?p-###`, which is still a valid permalink structure, just not a "pretty" one.
...
Permalinks are enabled by default (where supported) since in 4.2. When that change was made, it rended the "Default" label (previous to [35599]) inaccurate.
Props Ankit-K-Gupta.
Fixes #34509 .
Built from https://develop.svn.wordpress.org/trunk@35604
git-svn-id: http://core.svn.wordpress.org/trunk@35568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 22:19:27 +00:00
Dominik Schilling
66dee42444
Passwords: Disable hidden input fields on profile/user edit page.
...
Prevents an issue where password helpers would autofill the hidden password fields and inadvertently causing password changes when editing other fields on the profile page.
Props adamsilverstein.
Fixes #33699 .
Built from https://develop.svn.wordpress.org/trunk@35603
git-svn-id: http://core.svn.wordpress.org/trunk@35567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 20:41:26 +00:00
Drew Jaynes
c5a8c3aa86
Permalinks: Rename the "Default" permalink structure to "None" as permalinks have been enabled by default (where supported) since 4.2.
...
Updates help tabs and contextual text to match.
Props johnbillion, DrewAPicture.
Fixes #34509 .
Built from https://develop.svn.wordpress.org/trunk@35599
git-svn-id: http://core.svn.wordpress.org/trunk@35563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 06:58:25 +00:00
Konstantin Obenland
5eeeeb89ce
Menu: Continue to use post dashicon as default menu icon.
...
Prevents a bug where custom post types without a specified menu icon would
adopt the menu icon of the preceding post type. Introduced in [33723].
See #16865 .
Fixes #34637 .
Built from https://develop.svn.wordpress.org/trunk@35590
git-svn-id: http://core.svn.wordpress.org/trunk@35554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 22:00:26 +00:00
Dion Hulse
2103984c02
Fix a typo in a docblock
...
Built from https://develop.svn.wordpress.org/trunk@35586
git-svn-id: http://core.svn.wordpress.org/trunk@35550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 03:38:26 +00:00
Weston Ruter
f4659f7ee0
Customize: Fix focus and autofocus on `nav_menu_item` controls.
...
Embed the `nav_menu_item` control not only when the contained `nav_menu` section expands, but also if the control was autofocused (via the `autofocus[control]` query param). Also applies change from [33596] to work-around a broken `:focusable` selector in jQuery UI.
See #33258 .
Fixes #34629 .
Built from https://develop.svn.wordpress.org/trunk@35584
git-svn-id: http://core.svn.wordpress.org/trunk@35548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 03:14:25 +00:00
Dion Hulse
09ada24c99
Upgrade: Force disable the rest-api plugin on upgrade to 4.4 unless it's beta5+. Previous versions of the plugin were not configured correctly to gradefully degrade during update which would cause fatal errors.
...
Props wonderboymusic.
Fixes #34415
Built from https://develop.svn.wordpress.org/trunk@35582
git-svn-id: http://core.svn.wordpress.org/trunk@35546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 01:22:28 +00:00