Commit Graph

30386 Commits

Author SHA1 Message Date
Andrew Ozz 1f75220e9a TinyMCE, inline link toolbar: fix z-index bug in iOS Safari.
See #32604.
Built from https://develop.svn.wordpress.org/trunk@32958


git-svn-id: http://core.svn.wordpress.org/trunk@32929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 20:29:24 +00:00
Andrew Ozz 7a4c8d8977 TinyMCE: add the editor focusing help the Keyboard Shortcuts modal.
See #31913.
Built from https://develop.svn.wordpress.org/trunk@32957


git-svn-id: http://core.svn.wordpress.org/trunk@32928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 18:49:25 +00:00
Andrew Ozz 5f041b37bf TinyMCE, inline link toolbar: fix styling on small screens so the displayed URL is not needlessly truncated.
See #32604.
Built from https://develop.svn.wordpress.org/trunk@32956


git-svn-id: http://core.svn.wordpress.org/trunk@32927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 17:55:25 +00:00
Dominik Schilling a6b7a691be Customizer: Prevent dragging menu items above the main heading.
Improve targeting for the `sortableItems`, resolving an issue where the first `<li>` in the control became a sortable target, allowing the user to drag a single top level menu outside the intended sortable area.

props adamsilverstein.
fixes #32738.
#wceu
Built from https://develop.svn.wordpress.org/trunk@32955


git-svn-id: http://core.svn.wordpress.org/trunk@32926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 17:11:24 +00:00
Boone Gorges d99f9d3a22 Improve error checking in `get_edit_term_link()`.
The function should not throw notices when an improper term or taxonomy is
passed.

Props tmatsuur, MikeHansenMe.
Fixes #32786.
Built from https://develop.svn.wordpress.org/trunk@32954


git-svn-id: http://core.svn.wordpress.org/trunk@32925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 14:13:24 +00:00
Boone Gorges 40ab4567e7 Introduce `WP_UnitTestCase::delete_user()`.
This static method provides a multisite-agnostic way to delete users during
automated testing.

See #32796.
Built from https://develop.svn.wordpress.org/trunk@32953


git-svn-id: http://core.svn.wordpress.org/trunk@32924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 12:59:26 +00:00
Scott Taylor 72bf48f0b9 In Media microtemplates after [32467], use `<button>` instead of `<a>` for several more non-links.
Props afercia.
Fixes #26550.

Built from https://develop.svn.wordpress.org/trunk@32952


git-svn-id: http://core.svn.wordpress.org/trunk@32923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 05:01:24 +00:00
Andrew Ozz 561ca94998 TinyMCE: update the Keyboard Shortcuts help modal, use the TinyMCE UI API instead of an iframe.
Props iseulde, azaozz. Fixes #31913.
Built from https://develop.svn.wordpress.org/trunk@32951


git-svn-id: http://core.svn.wordpress.org/trunk@32922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 04:40:24 +00:00
Dion Hulse 4df2bd0b2a Remove an undeeded space concatenation from `wpmu_validate_user_signup()`.
This was previously used to prevent `strpos()` returning 0, which is not needed after r32942.
See #32444

Built from https://develop.svn.wordpress.org/trunk@32950


git-svn-id: http://core.svn.wordpress.org/trunk@32921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 01:39:25 +00:00
Scott Taylor 747b1eb713 After [32866], fix doc blocks.
Props DrewAPicture.
See #32363.

Built from https://develop.svn.wordpress.org/trunk@32949


git-svn-id: http://core.svn.wordpress.org/trunk@32920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 21:02:25 +00:00
Scott Taylor 7537240d37 List tables: when post navigation links point to the current page, use `<span>`s and text instead of `<a>`s.
Props afercia.
Fixes #32253.

Built from https://develop.svn.wordpress.org/trunk@32948


git-svn-id: http://core.svn.wordpress.org/trunk@32919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 20:32:26 +00:00
Scott Taylor 7a264022e7 After [32896], update `ConvertChars.php` unit tests and rename to `ConvertInvalidEntries.php`.
Props boonebgorges.
Fixes #32335.

Built from https://develop.svn.wordpress.org/trunk@32947


git-svn-id: http://core.svn.wordpress.org/trunk@32918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:51:27 +00:00
Scott Taylor 2518b37222 Admin menu: improve accessibility when collapsed.
Props afercia.
Fixes #32346.

Built from https://develop.svn.wordpress.org/trunk@32946


git-svn-id: http://core.svn.wordpress.org/trunk@32917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:33:26 +00:00
Scott Taylor 587c570efa After [32796], improve the accessibility and markup for instances of `touch_time()`.
Props rianrietveld, afercia.
Fixes #31714.

Built from https://develop.svn.wordpress.org/trunk@32945


git-svn-id: http://core.svn.wordpress.org/trunk@32916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:30:25 +00:00
Andrew Ozz 7142248743 Press This: better screen reader text for the arrow part of the split button.
Props afercia. See #32757.
Built from https://develop.svn.wordpress.org/trunk@32944


git-svn-id: http://core.svn.wordpress.org/trunk@32915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:24:25 +00:00
Scott Taylor 26855e651b In `get_site_option()` and `get_option()`, ensure that `$notoptions` is an array before writing to it. Prevents a flood of `Cannot use a scalar value as an array`, because `$notoptions` is otherwise set to the result of `wp_cache_get()`, which returns `mixed`.
Props hauvong.
Fixes #31147.

Built from https://develop.svn.wordpress.org/trunk@32943


git-svn-id: http://core.svn.wordpress.org/trunk@32914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:01:26 +00:00
Scott Taylor aaa99969e4 `wpmu_validate_user_signup()` should strictly check against `false` when using `strpos()`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32942


git-svn-id: http://core.svn.wordpress.org/trunk@32913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 16:57:26 +00:00
Scott Taylor b3ecfda08d `WP_Rewrite::add_rule()` should strictly check against `false` when using `strpos()`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32941


git-svn-id: http://core.svn.wordpress.org/trunk@32912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 16:56:25 +00:00
Scott Taylor b9e8ee95b5 `prep_atom_text_construct()` and `before_last_bar()` should strictly check against `false` when using `str(r)?pos()`.
Sidenote: there's a function named `before_last_bar`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32940


git-svn-id: http://core.svn.wordpress.org/trunk@32911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 16:49:25 +00:00
Scott Taylor 7453d12390 Remove unused code from `WP_Press_This::html()`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32939


git-svn-id: http://core.svn.wordpress.org/trunk@32910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 16:38:25 +00:00
Scott Taylor d9bd43c702 Remove unused code from `WP_MS_Sites_List_Table::display_rows()`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32938


git-svn-id: http://core.svn.wordpress.org/trunk@32909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 16:36:29 +00:00
Andrew Ozz 8005ccff74 TinyMCE, inline link toolbar:
- Add max-width for all floating toolbars.
- Ensure the inline link toolbar doesn't exceed the width on small screen devices.
- Do not cut/concatenate the URL when it is less than 40 characters long.
- Show more of the URL if the beginning part plus the ending part are less than 40 characters long.
See #32604.
Built from https://develop.svn.wordpress.org/trunk@32937


git-svn-id: http://core.svn.wordpress.org/trunk@32908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 04:42:28 +00:00
Andrew Ozz d3ee649cb9 Press This: support passing `i` parameter to add an image src.
Props stephdau, azaozz. Fixes #32173.
Built from https://develop.svn.wordpress.org/trunk@32936


git-svn-id: http://core.svn.wordpress.org/trunk@32907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 03:06:25 +00:00
Andrew Ozz eaadfde950 Define `SCRIPT_DEBUG` early on every load, similarly to `WP_DEBUG`. Remove `defined( 'SCRIPT_DEBUG' )` checks.
Fixes #32333.
Built from https://develop.svn.wordpress.org/trunk@32935


git-svn-id: http://core.svn.wordpress.org/trunk@32906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 02:29:31 +00:00
Andrew Ozz d4f3428d5f Press This, split button: wrap the sub-buttons in an unordered list to aid accessibility.
Props afercia. See #32757.
Built from https://develop.svn.wordpress.org/trunk@32934


git-svn-id: http://core.svn.wordpress.org/trunk@32905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 01:55:30 +00:00
John Blackbourn b5973e92ec Introduce a `no_terms` label for taxonomies. This label is used when indicating that there are no terms in the given taxonomy associated with an object.
Fixes #32150
Props afercia

Built from https://develop.svn.wordpress.org/trunk@32933


git-svn-id: http://core.svn.wordpress.org/trunk@32904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 00:16:27 +00:00
Ella Iseulde Van Dorpe af4f2bd1e8 wplink: update TinyMCE UI after updating the link
See #32604.

Built from https://develop.svn.wordpress.org/trunk@32932


git-svn-id: http://core.svn.wordpress.org/trunk@32903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 23:23:26 +00:00
Ella Iseulde Van Dorpe d710b768eb TinyMCE: wplink: add inline toolbar
Now the URL can be viewed as soon as you put the cursor in an anchor tag. Clicking on it will open the page in a new tab. You also have the edit and remove button close at hand.

First run.
See #32604.

Built from https://develop.svn.wordpress.org/trunk@32931


git-svn-id: http://core.svn.wordpress.org/trunk@32902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 23:05:26 +00:00
Scott Taylor d8b13fa32b YouTube oEmbed parsing: support the `m` subdomain.
Adds unit tests.

Props Toru, johnbillion.
Fixes #32714.

Built from https://develop.svn.wordpress.org/trunk@32930


git-svn-id: http://core.svn.wordpress.org/trunk@32901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 21:06:26 +00:00
Scott Taylor f23199caaa Remove the `whois.arin.net` link from `wp_notify_postauthor()` and `wp_notify_moderator()`.
Also, remove from `edit-form-comment.php` and add a new filter: `edit_comment_misc_actions`. 

Props ozh, joedolson, rachelbaker.
Fixes #15281.

Built from https://develop.svn.wordpress.org/trunk@32929


git-svn-id: http://core.svn.wordpress.org/trunk@32900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 20:56:27 +00:00
Sergey Biryukov 3f448d7cd5 Add `editor_stylesheets` filter to `get_editor_stylesheets()`.
props danielbachhuber, MikeHansenMe.
fixes #31672.
Built from https://develop.svn.wordpress.org/trunk@32928


git-svn-id: http://core.svn.wordpress.org/trunk@32899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 13:32:32 +00:00
Drew Jaynes e9758d4e48 Fix a typo in the DocBlock for `get_plugins()`.
Props onnimonni, swissspidy.
Fixes #32758.

Built from https://develop.svn.wordpress.org/trunk@32927


git-svn-id: http://core.svn.wordpress.org/trunk@32898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 12:22:27 +00:00
Drew Jaynes e872f02bc8 Document default values for optional arguments in `edit_term_link()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32926


git-svn-id: http://core.svn.wordpress.org/trunk@32897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 10:56:27 +00:00
Drew Jaynes 8a6f4cb0ef Add missing documentation for the `$echo` parameter in the DocBlock for `edit_term_link()`.
Props tmatsuur.
Fixes #32776.

Built from https://develop.svn.wordpress.org/trunk@32925


git-svn-id: http://core.svn.wordpress.org/trunk@32896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 10:53:28 +00:00
Dion Hulse 42fbb6568e WP Filesystem: Correctly set the @since for WP_Filesystem_Base::getchmod() added in r32923.
This is 2.5.0 as that's when the function become available in all subclasses.
See #29548

Built from https://develop.svn.wordpress.org/trunk@32924


git-svn-id: http://core.svn.wordpress.org/trunk@32895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 04:52:25 +00:00
Dion Hulse 8f47efe7dc WP Filesystem: Correctly parse the permissions field in the directory listings, and actually set it in FTP environments
Props mnelson4 for initial patch.
Fixes #29548

Built from https://develop.svn.wordpress.org/trunk@32923


git-svn-id: http://core.svn.wordpress.org/trunk@32894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 04:49:25 +00:00
Andrew Ozz dfaa89d853 Press This: fix spinner position relative to the split button.
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32922


git-svn-id: http://core.svn.wordpress.org/trunk@32893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 03:32:25 +00:00
Andrew Ozz f8cf80e9b1 Press This: ensure proper tab order in the split button. Tweak padding and border color a bit.
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32921


git-svn-id: http://core.svn.wordpress.org/trunk@32892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 03:23:27 +00:00
Andrew Ozz f4109b0c5d Press This: convert the Preview | Save | Publish buttons to a split button.
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32920


git-svn-id: http://core.svn.wordpress.org/trunk@32891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 02:46:27 +00:00
John Blackbourn 0fdc7bb582 Implement tests for the `upload_mimes` filter to ensure it prevents the upload of disallowed file types.
See #32693

Built from https://develop.svn.wordpress.org/trunk@32919


git-svn-id: http://core.svn.wordpress.org/trunk@32890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 00:43:26 +00:00
John Blackbourn f4ec9be456 Implement canonical and `url_to_postid()` tests for child pages which share a post name with other child pages.
See #32759

Built from https://develop.svn.wordpress.org/trunk@32918


git-svn-id: http://core.svn.wordpress.org/trunk@32889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 00:41:27 +00:00
John Blackbourn 3c7ea03cb0 Correct the title used on the user dashboard.
Fixes #32754
Props johnjamesjacoby

Built from https://develop.svn.wordpress.org/trunk@32917


git-svn-id: http://core.svn.wordpress.org/trunk@32888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 00:37:28 +00:00
Scott Taylor 8854256155 Because programming is fun. After [32915], `_.find()` will return `undefined` if an empty array is passed - in that case, the function should return `true`.
See #32746.

Built from https://develop.svn.wordpress.org/trunk@32916


git-svn-id: http://core.svn.wordpress.org/trunk@32887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 19:43:25 +00:00
Scott Taylor 15bfe75f88 When filtering media by type in `wp.media.model.Attachments.filters.type()`, account for the library's `type` being an array of full mime-types.
Fixes #32746.

Built from https://develop.svn.wordpress.org/trunk@32915


git-svn-id: http://core.svn.wordpress.org/trunk@32886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 19:40:26 +00:00
Scott Taylor 3b88c839f9 In `wp_prepare_attachment_for_js()`, when setting `filename`, call `wp_basename()` on the result of `get_attached_file()`, not `WP_Post->guid`. `guid` can be set to the result `get_permalink()`, which is not a file path.
Props daxelrod.
Fixes #32531.

Built from https://develop.svn.wordpress.org/trunk@32914


git-svn-id: http://core.svn.wordpress.org/trunk@32885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 18:30:26 +00:00
Scott Taylor f61501f57f The `query-attachments` AJAX action immediately errors out if the user doesn't have the `upload_files` cap. As such, the Customizer shouldn't show buttons that launch the media modal when the user doesn't have the proper permissions to query attachments.
See #32654.

Built from https://develop.svn.wordpress.org/trunk@32913


git-svn-id: http://core.svn.wordpress.org/trunk@32884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 18:20:27 +00:00
Boone Gorges 3ffe2a059d Add `expectedDeprecated` flags to `wp_richedit_pre()` and `wp_htmledit_pre()` unit tests.
These functions were deprecated in [32899].

See #32425.
Built from https://develop.svn.wordpress.org/trunk@32912


git-svn-id: http://core.svn.wordpress.org/trunk@32883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 14:42:26 +00:00
Boone Gorges fdd0917471 In `WP_Comment_Query`, parse meta_query vars after the `pre_get_comments` hook.
[31467] included a change that involved generating meta_query SQL before the
`pre_get_comments` hook, with the result that `pre_get_comments` callbacks were
no longer able to modify comment meta queries. We fix the problem by moving the
SQL generation to after the hook.

This changeset also includes a second call to `meta_query->parse_query_vars()`,
to ensure that modifications to metadata-related query vars (such as `meta_key`
and `meta_value`) performed in `pre_get_comments` callbacks have the expected
effect on the comment query.

Fixes #32762.
Built from https://develop.svn.wordpress.org/trunk@32911


git-svn-id: http://core.svn.wordpress.org/trunk@32882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 14:36:27 +00:00
Boone Gorges 03be8647c5 Fix PHP notice in `WP_Tax_Query::get_sql_for_clause()`.
Previously, the `$where` variable was not initialized, so that when an invalid
'operator' was passed, PHP would complain that `$where` was undefined.

Props dlh.
Fixes #32756.
Built from https://develop.svn.wordpress.org/trunk@32910


git-svn-id: http://core.svn.wordpress.org/trunk@32881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 12:44:27 +00:00
Scott Taylor b30b08fd92 Refresh attachment links in the media modal are unneeded since bringing the image editor into it in [27445].
Props rommelxcastro.
Fixes #32550.

Built from https://develop.svn.wordpress.org/trunk@32909


git-svn-id: http://core.svn.wordpress.org/trunk@32880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 21:33:26 +00:00