ea8331f00d
REST API: Allow queries other than the main query to be `is_home`.
...
Ensure that REST API calls can match the main query of the page.
See #34373 .
Fixes #50213 .
Props: dlh, TimothyBlynJacobs, boonebgorges, joemcgill, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48053
git-svn-id: http://core.svn.wordpress.org/trunk@47820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 06:04:12 +00:00
ccf534dc48
Code Standards: Cleanup some code spacing.
...
See: #37826 and #44286 .
Built from https://develop.svn.wordpress.org/trunk@48052
git-svn-id: http://core.svn.wordpress.org/trunk@47819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 00:56:08 +00:00
d3c44a690d
Menus: Provide menu settings when creating a new menu.
...
This simplifies the steps in the process of adding new menus.
Props: garrett-eclipse, audrasjb, ianjvr.
Built from https://develop.svn.wordpress.org/trunk@48051
git-svn-id: http://core.svn.wordpress.org/trunk@47818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 23:22:06 +00:00
28d29b35f7
Comments: Don't display edit links to trashed post comments.
...
If a post is in the trash, the comments bubble won't link to the comments list.
Fixes : #37826 .
Props: swissspidy, helen, FolioVision, DrewAPicture, stevenlinx, donmhico, birgire, garrett-eclipse, andraganescu, johnbillion.
Built from https://develop.svn.wordpress.org/trunk@48050
git-svn-id: http://core.svn.wordpress.org/trunk@47817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 23:06:08 +00:00
6aa5788189
Text Changes: Replace "Webmaster" in output messages with more appropriate terms:
...
* "All at `###SITENAME###`" in `wp-admin/ms-delete-site.php`, for consistency with other Multisite emails.
* "Site admin" in `register_new_user()`, for clarity.
Props Presskopp, marybaum.
Fixes #50394 .
Built from https://develop.svn.wordpress.org/trunk@48049
git-svn-id: http://core.svn.wordpress.org/trunk@47816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 19:41:11 +00:00
4cdd79af25
Emoji: Upgrade Twemoji to version 13.0.0.
...
🥸
Props kraftbj, desrosj, otto42.
Fixes #50148 .
Built from https://develop.svn.wordpress.org/trunk@48048
git-svn-id: http://core.svn.wordpress.org/trunk@47815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 18:04:26 +00:00
6d914acd6c
Bundled Themes: Twenty Nineteen dropcap appears higher than expected in Firefox.
...
Fixes the issue by adding moz specific top margin for the dropcap.
Props kjellr, joseph.dickson, maxpertici, samful.
Fixes #45876 .
Built from https://develop.svn.wordpress.org/trunk@48047
git-svn-id: http://core.svn.wordpress.org/trunk@47814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 15:13:09 +00:00
b8de1549ff
Coding Standards: Remove the PHP Compatibility scanning job from the `allowed_failures` list.
...
All pre-existing compatibility warnings and errors as flagged by the PHPCompatibilityWP ruleset have been addressed.
Fixes #49922 .
Built from https://develop.svn.wordpress.org/trunk@48046
git-svn-id: http://core.svn.wordpress.org/trunk@47813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 15:04:10 +00:00
c4a89f1635
General: Continuing to work towards a passing PHP Compatibility scan.
...
- Add `phpcs:ignore` statements to compatibility checks in PHPMailer.
- Remove quotes around the assertion in an `assert()` call. This will trigger a deprecated notice under certain conditions on PHP 7.2.
Props jrf, desrosj.
See #49922 , #48033 .
Built from https://develop.svn.wordpress.org/trunk@48045
git-svn-id: http://core.svn.wordpress.org/trunk@47812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 14:56:07 +00:00
942fc4e0fc
Networks and Sites: Don't unnecessarily switch to the current blog in `get_blog_details()`.
...
Props arpitgshah, djennez, acsnaterse, joostdevalk, SergeyBiryukov.
Fixes #50391 .
Built from https://develop.svn.wordpress.org/trunk@48044
git-svn-id: http://core.svn.wordpress.org/trunk@47811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 12:31:11 +00:00
a1f8dd4972
Posts, Post Types: Introduce `default_category_post_types` filter.
...
The filter allows custom post types associated with the `category` taxonomy to opt in to requiring a default category, same as regular posts.
Props enrico.sorcinelli.
Fixes #43516 .
Built from https://develop.svn.wordpress.org/trunk@48043
git-svn-id: http://core.svn.wordpress.org/trunk@47810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-14 21:42:17 +00:00
893c580831
Users: On the 'Add New User' screen, don't show the roles dropdown if the current user can't promote other users.
...
Fixes #50345 .
Built from https://develop.svn.wordpress.org/trunk@48042
git-svn-id: http://core.svn.wordpress.org/trunk@47809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-14 17:03:10 +00:00
9f7a7f8d57
Coding Standards: Fix code indentation in `post_submit_meta_box()` to improve readability.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@48041
git-svn-id: http://core.svn.wordpress.org/trunk@47808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-14 16:31:08 +00:00
d776a4d15e
Coding Standards: Use strict comparison in `js/_enqueues/lib/ajax-response.js`.
...
Props ankitmaru.
Fixes #50320 .
Built from https://develop.svn.wordpress.org/trunk@48040
git-svn-id: http://core.svn.wordpress.org/trunk@47807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-14 11:28:07 +00:00
01eb2907a7
Accessibility: Themes: Don't link to the home page in `get_custom_logo()` when it's displayed on the home page.
...
Props Soean, audrasjb, sabernhardt, FlorianBrinkmann, rianrietveld, afercia, joedolson, samful, knutsp, SergeyBiryukov.
See #37011 .
Built from https://develop.svn.wordpress.org/trunk@48039
git-svn-id: http://core.svn.wordpress.org/trunk@47806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-14 10:02:11 +00:00
e6ee3f742e
External Libraries: Update Masonry to 4.2.2 and imagesLoaded to 4.1.4.
...
Notable changes include dropping support for IE 8 & 9, which are no longer supported by WordPress core either.
Release notes:
https://github.com/desandro/masonry/releases
https://github.com/desandro/imagesloaded/releases
Changelogs:
https://github.com/desandro/masonry/compare/v3.3.2...v4.2.2
https://github.com/desandro/imagesloaded/compare/v3.2.0...v4.1.4
Props pierlo, hareesh-pillai, grapplerulrich, pderksen, desrosj, garrett-eclipse, SergeyBiryukov.
Fixes #37675 , #48031 .
Built from https://develop.svn.wordpress.org/trunk@48038
git-svn-id: http://core.svn.wordpress.org/trunk@47805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-13 18:53:27 +00:00
04200b39ce
Themes: Ensure the theme slug is set before checking if the theme is installed or active.
...
This fixes an issue with every installed theme being marked as active on Themes screen.
The slug is set on Add Themes screen, but not on Themes.
Follow-up to [47924].
Props BackuPs, mukesh27, SergeyBiryukov.
Fixes #50381 . See #50334 .
Built from https://develop.svn.wordpress.org/trunk@48037
git-svn-id: http://core.svn.wordpress.org/trunk@47804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-13 14:26:07 +00:00
c7b843302f
Coding Standards: Exclude the whole PHPMailer directory from WPCS checks, for consistency with other external libraries in their own directory.
...
Follow-up to [48033].
See #41750 .
Built from https://develop.svn.wordpress.org/trunk@48036
git-svn-id: http://core.svn.wordpress.org/trunk@47803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-13 12:36:10 +00:00
aa5017ebb9
External Libraries: Add class aliases for `phpmailerException` and `SMTP` to deprecated files to account for the new namespace.
...
This ensures backward compatibility with plugins using the old `class-phpmailer.php` or `class-smtp.php` files.
Follow-up to [48033].
Props Otto42.
Fixes #50379 . See #41750 .
Built from https://develop.svn.wordpress.org/trunk@48035
git-svn-id: http://core.svn.wordpress.org/trunk@47802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-12 21:42:09 +00:00
afaeaf1529
External Libraries: Skip deprecated file warning for PHPMailer if the API is not loaded.
...
In [48033] the "class-phpmailer.php" file was deprecated. In test suites, this file is loaded before WordPress in order to setup a mock PHPMailer instance. This means that for test suites that are still loading that file, they'll experience fatal errors due to the undefined "_deprecated_file" function.
This commit skips issuing the deprecated file warning if the "_deprecated_file" function is not available.
Fixes #50380 .
Built from https://develop.svn.wordpress.org/trunk@48034
git-svn-id: http://core.svn.wordpress.org/trunk@47801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-12 21:10:08 +00:00
e4379c5ba8
External Libraries: Upgrade PHPMailer to version 6.1.6.
...
Now that WordPress Core supports PHP >= 5.6, the PHPMailer library can be updated to the latest version.
The PHPMailer files now reside in a new directory, `wp-includes/PHPMailer`. These files are copied verbatim from the library upstream and will make updating in the future easier. For backwards compatibility, the old files will remain and trigger deprecated file warnings.
The PHPMailer class is also now under the `PHPMailer\PHPMailer\PHPMailer` namespace. The `PHPMailer` class in the global namespace has been aliased for a seamless transition.
This upgrade also clears up a handful of PHP compatibility issues detailed in #49922 .
For a full list of changes, see the PHPMailer GitHub: https://github.com/PHPMailer/PHPMailer/compare/v5.2.27...v6.1.6 .
Props Synchro, SergeyBiryukov, desrosj, donmhico, ayeshrajans.
Fixes #41750 .
Built from https://develop.svn.wordpress.org/trunk@48033
git-svn-id: http://core.svn.wordpress.org/trunk@47800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-12 15:47:07 +00:00
232277586f
Bundled Themes: Twenty Nineteen long submenu item titles do not wrap.
...
Fixes the issue of long submenu item titles that do not wrap by adding a `max-width: 20rem;` and removing `white-space: nowrap;`.
Props kjellr, mukesh27, mohsinrasool, samful.
Fixes #45866 .
Built from https://develop.svn.wordpress.org/trunk@48032
git-svn-id: http://core.svn.wordpress.org/trunk@47799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-12 15:11:08 +00:00
4cc11cdbdd
Filesystem API: Avoid a PHP notice in `WP_Filesystem_Direct::owner()` and `::group()` methods and their `WP_Filesystem_SSH2` counterparts.
...
Although not officially documented in the PHP manual, `posix_getpwuid()` and `posix_getgrgid()` can return `false` in some circumstances.
Props logig.
Fixes #50373 .
Built from https://develop.svn.wordpress.org/trunk@48031
git-svn-id: http://core.svn.wordpress.org/trunk@47798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-12 12:35:09 +00:00
99c6adfeaa
Bundled Themes: Twenty Seventeen CSS issue when using rowspan in tables.
...
Fixes CSS issue when using rowspan in tables. This issue does not apply to the Table Block, just tables inserted as custom html.
Props aussi, subrataemfluence, jainnidhi.
Fixes #44004 .
Built from https://develop.svn.wordpress.org/trunk@48028
git-svn-id: http://core.svn.wordpress.org/trunk@47796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-11 17:15:08 +00:00
5bc4b92551
Bundled Themes: Twenty Seventeen add Telegram and Whatsapp support to Social Media Menu.
...
Adds Telegram and Whatsapp support and SVG's to Social Media Menu.
Props cpasqualini, audrasjb, laurelfulford, karmatosed, ibdz.
Fixes #43999 .
Built from https://develop.svn.wordpress.org/trunk@48027
git-svn-id: http://core.svn.wordpress.org/trunk@47795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-11 15:31:09 +00:00
4de0d47792
Canonical: Revert [47937] pending unit tests and further review.
...
Props needle.
See #12456 .
Built from https://develop.svn.wordpress.org/trunk@48026
git-svn-id: http://core.svn.wordpress.org/trunk@47794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-11 10:55:11 +00:00
c075eec24f
Editor: Ensure latest comments can only be viewed from public posts.
...
Props: poena, xknown.
Built from https://develop.svn.wordpress.org/trunk@47984
git-svn-id: http://core.svn.wordpress.org/trunk@47752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 19:20:11 +00:00
9524b335c7
Bundled Themes: Twenty Twenty and Twenty Nineteen version bump.
...
We are releasing new versions of Twenty Twenty & Twenty Nineteen today thus we need to bump the version.
Props ianbelanger.
Fixes #50359 .
Built from https://develop.svn.wordpress.org/trunk@47952
git-svn-id: http://core.svn.wordpress.org/trunk@47724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:32:06 +00:00
dda0ccdd18
Administration: Add a new filter to extend `set-screen-option`.
...
Props: xknown, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@47951
git-svn-id: http://core.svn.wordpress.org/trunk@47723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:24:51 +00:00
ffc4869c9c
Themes: Ensure a broken theme name is returned properly.
...
Props: sstoqnov.
Built from https://develop.svn.wordpress.org/trunk@47950
git-svn-id: http://core.svn.wordpress.org/trunk@47722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:23:36 +00:00
10e2a50c52
Formatting: Ensure that `wp_validate_redirect()` sanitizes a wider variety of characters.
...
Props: xknow, vortfu.
Built from https://develop.svn.wordpress.org/trunk@47949
git-svn-id: http://core.svn.wordpress.org/trunk@47721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:22:28 +00:00
7e9267567f
Editor: Prevent HTML decoding on by setting the proper editor context.
...
Props: sstoqnov.
Built from https://develop.svn.wordpress.org/trunk@47948
git-svn-id: http://core.svn.wordpress.org/trunk@47720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:21:20 +00:00
2ae3b3b801
Embeds: Ensure that the title attribute is set correctly on embeds.
...
Props xknown.
Built from https://develop.svn.wordpress.org/trunk@47947
git-svn-id: http://core.svn.wordpress.org/trunk@47719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:20:10 +00:00
1d95eb63a7
Docs: Add missing documentation for the `$group` parameter of `WP_Object_Cache::get_multiple()`.
...
Synchronize documentation between `wp_cache_get_multiple()`, its compat version, and the class method.
See #20875 .
Built from https://develop.svn.wordpress.org/trunk@47944
git-svn-id: http://core.svn.wordpress.org/trunk@47717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 09:57:09 +00:00
941a31318c
REST API: Fix updating "multiple" meta keys with non-string values.
...
Previously, the REST API would end up deleting each row of metadata and recreating it unnecessarily. This was caused by a type mismatch where the metadata API would always return a string value, and the REST API operated on a typed value.
The REST API now applies the same sanitization and type casting for "multiple" meta keys and "single" meta keys.
Fixes #49339 .
Props renathoc.
Built from https://develop.svn.wordpress.org/trunk@47943
git-svn-id: http://core.svn.wordpress.org/trunk@47716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 02:22:13 +00:00
38352d2c7a
Coding Standards: Cleans up some PHPCS issues introduced in [47938].
...
See #20875 .
Built from https://develop.svn.wordpress.org/trunk@47942
git-svn-id: http://core.svn.wordpress.org/trunk@47715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 22:42:12 +00:00
4e61c5fb0f
Bundled Themes: Twenty Twenty number of replies not translatable.
...
Fixes the issue by removing the single quote from around the `1` in the elseif conditional of the comments template.
Props Parvand, SergeyBiryukov, desrosj, juliobox, Mista-Flo, benjamingosset, audrasjb, opurockey.
Fixes #49058 .
Built from https://develop.svn.wordpress.org/trunk@47941
git-svn-id: http://core.svn.wordpress.org/trunk@47714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 20:02:08 +00:00
32116649cf
Bundled Themes: Twenty Twenty HTML in featured image caption is being escaped.
...
Fixes the issue by replacing `esc_html` with `wp_kses_post` in the caption in featured images.
Props pierlo, JavierCasares, audrasjb.
Fixes #49833 .
Built from https://develop.svn.wordpress.org/trunk@47940
git-svn-id: http://core.svn.wordpress.org/trunk@47713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 19:52:07 +00:00
ae76b79f85
Cache API: Include the `cache-compat` file.
...
This was missed during the prior commit.
See [47938].
Built from https://develop.svn.wordpress.org/trunk@47939
git-svn-id: http://core.svn.wordpress.org/trunk@47712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 19:50:09 +00:00
3e2b649351
Cache API: Introduce `wp_cache_get_multi()`.
...
Many caching backend have support for multiple gets in a single request. This brings that support to core, with a compatability fallback that will loop over requests if needed.
Fixes : #20875 .
Props: nacin, tollmanz, wonderboymusic, ryan, jeremyfelt, spacedmonkey, boonebgorges, dd32, rmccue, ocean90, jipmoors, johnjamesjacoby, tillkruess, donmhico, davidbaumwald, SergeyBiryukov, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47938
git-svn-id: http://core.svn.wordpress.org/trunk@47711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 19:47:13 +00:00
c65334d820
Canonical: Ensure a redirect for posts missing `postname` in a query with an ID.
...
If a site is using `/%post_id%/%postname%/` as permalink structure, and is missing the `postname`, the site won't redirect to the appropriate URL. This change ensure that the redirect happens.
Fixes : #12456 .
Props: Frank.Prendergast, dd32, Otto42, hlanggo, wonderboymusic, atimmer, seth17, calvin_ngan, Niresh12495, anbumz, SergeyBiryukov, donmhico.
Built from https://develop.svn.wordpress.org/trunk@47937
git-svn-id: http://core.svn.wordpress.org/trunk@47710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 19:26:12 +00:00
f5d5b76f6e
Docs: Fix typo in `WP_Widget::__construct()` and `::WP_Widget()` DocBlocks.
...
Props SUM1.
Fixes #50348 .
Built from https://develop.svn.wordpress.org/trunk@47936
git-svn-id: http://core.svn.wordpress.org/trunk@47709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 15:37:10 +00:00
c227ed2322
Docs: Improve documentation for `is_active_sidebar()`.
...
The function determines whether the sidebar contains widgets, not that it is loaded on the page.
Props SUM1.
Fixes #50347 .
Built from https://develop.svn.wordpress.org/trunk@47935
git-svn-id: http://core.svn.wordpress.org/trunk@47708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 15:31:09 +00:00
c681e37da7
Bundled Themes: Twenty Fifteen bulleted list block appears too far to the left in the editor.
...
Fixes the issue by removing unnecessary margin rules for bulleted lists in the editor.
Props kjellr.
Fixes #50029 .
Built from https://develop.svn.wordpress.org/trunk@47934
git-svn-id: http://core.svn.wordpress.org/trunk@47707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 14:10:09 +00:00
644fb1b931
Bundled Themes: Twenty Twenty uses overly specific selector for button background.
...
Fixes the issue by removing `:not(.toogle)` from the `button` selector, as it is not needed.
Props flixos90.
Fixes #50271 .
Built from https://develop.svn.wordpress.org/trunk@47933
git-svn-id: http://core.svn.wordpress.org/trunk@47706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 13:52:08 +00:00
bbdfffdaa1
Networks and Sites: Ensure the site ID in `wp_insert_site()` is still correct after calling `clean_blog_cache()`.
...
By saving `$wpdb->insert_id` to a variable, we make sure the ID does not change if another database insert is performed on the `clean_site_cache` action.
Props trepmal.
Fixes #50324 .
Built from https://develop.svn.wordpress.org/trunk@47932
git-svn-id: http://core.svn.wordpress.org/trunk@47705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 12:41:09 +00:00
40584118d9
Docs: Document that `get_tags()` returns a `WP_Error` object if any of the specified taxonomies do not exist.
...
Props coffee2code.
Fixes #50344 .
Built from https://develop.svn.wordpress.org/trunk@47930
git-svn-id: http://core.svn.wordpress.org/trunk@47703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 11:14:12 +00:00
784908ae5f
Coding Standards: PHP short ternary operator syntax is not allowed.
...
WPCS 2.2.0 added a sniff for detecting short ternary operator syntax, which is not allowed per the Core handbook.
Follow up of [47927].
Fixes #50258 .
Built from https://develop.svn.wordpress.org/trunk@47929
git-svn-id: http://core.svn.wordpress.org/trunk@47702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 21:27:10 +00:00
d1015f46b5
Build/Test Tools: Update the `wp-coding-standards/wpcs` package.
...
This updates the version from 2.1.1 to 2.3.0, the latest version at this time.
Fixes #50258 .
Built from https://develop.svn.wordpress.org/trunk@47927
git-svn-id: http://core.svn.wordpress.org/trunk@47701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 20:11:10 +00:00
c591d94cc5
General: Remove or add inline comments to `$HTTP_RAW_POST_DATA` occurrences.
...
The `$HTTP_RAW_POST_DATA` global was deprecated in PHP 5.6 and removed completely in PHP 7.0. In general, `php://input` should be used instead of `$HTTP_RAW_POST_DATA`.
Because WordPress Core still supports PHP 5.6, some plugins or sites may still rely on this variable being present and populated with the expected data. For that reason, occurrences of the variable will remain with updated inline documentation until support for PHP 5.6 is officially dropped in WordPress.
Props skoskie, jrf, desrosj, TimothyBlynJacobs.
See #49922 .
Fixes #49810 .
Built from https://develop.svn.wordpress.org/trunk@47926
git-svn-id: http://core.svn.wordpress.org/trunk@47700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 19:55:10 +00:00
9e9be350e2
Bundled Themes: Update several package versions in Twenty Twenty and Twenty Nineteen.
...
The following packages received version bumps:
Twenty Twenty
- `concurrently`
- `postcss-cli`
- `rtlcss`
- `stylelint-a11y`
Twenty Nineteen
- `node-sass`
- `postcss-cli`
- `rtlcss`
See #49768 .
Built from https://develop.svn.wordpress.org/trunk@47925
git-svn-id: http://core.svn.wordpress.org/trunk@47699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 18:47:08 +00:00
4adfd75159
Themes: Show a disabled "Activated" button instead of "Activate" for the active theme on Add Themes screen.
...
Additionally, switch the "Live Preview" label for the active theme to "Customize", for consistency with the Themes screen.
Props afercia, SergeyBiryukov.
Fixes #50334 .
Built from https://develop.svn.wordpress.org/trunk@47924
git-svn-id: http://core.svn.wordpress.org/trunk@47698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 18:16:10 +00:00
5efaf888a5
REST API: Support the (min|max)Items JSON Schema keywords.
...
A future commit will add support for the uniqueItems keyword.
Props sorenbronsted.
See #48821 .
Built from https://develop.svn.wordpress.org/trunk@47923
git-svn-id: http://core.svn.wordpress.org/trunk@47697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-07 22:42:13 +00:00
18a9359c06
Posts, Post Types: Display a more specific error message when an attachment could not be inserted into the database.
...
Props shital-patel, Presskopp, ocean90.
Fixes #50325 .
Built from https://develop.svn.wordpress.org/trunk@47922
git-svn-id: http://core.svn.wordpress.org/trunk@47696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-07 09:24:11 +00:00
171356a890
REST API: Add additional fields to the themes controller.
...
When the themes controller was introduced it only returned a theme's supported features. This adds the majority of a theme's header information to the response.
Props ockham, spacedmonkey.
Fixes #49906 .
Built from https://develop.svn.wordpress.org/trunk@47921
git-svn-id: http://core.svn.wordpress.org/trunk@47695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-07 06:46:10 +00:00
6459c0f2ee
Block Editor: Update `wp-includes/assets/script-loader-packages.php`.
...
Follow-up to [47765], [47766].
See #50094 .
Built from https://develop.svn.wordpress.org/trunk@47920
git-svn-id: http://core.svn.wordpress.org/trunk@47694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-07 01:29:12 +00:00
b19c1627e5
Bootstrap/Load: Introduce `wp_get_environment_type()` to retrieve the current environment type.
...
The type can be set via the `WP_ENVIRONMENT_TYPE` global system variable, a constant of the same name, or the `wp_get_environment_type` filter.
Possible values include `development`, `stage`, `production'. If not set, the type defaults to `production`.
Props Clorith, krogsgard, joostdevalk, frank-klein, Maelacuna, nathanrice, grierson, jchristopher, davidvee, jackfungi, johnbillion, tabrisrp, knutsp, ev3rywh3re, Rastaban, danielbachhuber, pfefferle, audrasjb, SergeyBiryukov.
Fixes #33161 .
Built from https://develop.svn.wordpress.org/trunk@47919
git-svn-id: http://core.svn.wordpress.org/trunk@47693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-06 11:07:12 +00:00
0b9a800512
Media: remove any `attachment-filter` query param when switching views.
...
Fix an issue where the media attachment filter no longer worked after switching to list view, filtering by a media type then switching back to the grid view.
Props itzmekhokan, netsurfer2705, zodiac1978.
Fixes #43656 .
Built from https://develop.svn.wordpress.org/trunk@47915
git-svn-id: http://core.svn.wordpress.org/trunk@47689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-05 21:13:10 +00:00
f546fe5aa5
Networks and Sites: Update the link text for "Debugging a WordPress Network" support article in `ms_not_installed()`.
...
Props Presskopp.
Fixes #50326 .
Built from https://develop.svn.wordpress.org/trunk@47914
git-svn-id: http://core.svn.wordpress.org/trunk@47688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-05 09:13:08 +00:00
4bbb7fb852
Docs: Update the DocBlock for the `wp_media_attach_action` hook per the documentation standards.
...
Rename the `$att_id` variable to `$attachment_id` for clarity.
Follow-up to [47909].
See #49614 .
Built from https://develop.svn.wordpress.org/trunk@47913
git-svn-id: http://core.svn.wordpress.org/trunk@47687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-05 08:30:10 +00:00
07a3972bc3
Docs: Fix a typo in the Docker compose file.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47912
git-svn-id: http://core.svn.wordpress.org/trunk@47686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 16:53:09 +00:00
00df557404
REST API: Ensure that all properties of `get_endpoint_args_for_item_schema` are listed.
...
* Add new var $valid_schema_properties to match rest_validate_value_from_schema()
* Unit test to ensure all valid properties exists, and non-valid properties are ignored
Fixes : #50301 .
Props: pentatonicfunk, TimothyBlynJacobs.
Built from https://develop.svn.wordpress.org/trunk@47911
git-svn-id: http://core.svn.wordpress.org/trunk@47685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 16:43:08 +00:00
b013a15d43
Accessibility: Add the `aria-hidden` attribute to the auto-update related icons.
...
`<span>` elements used for displaying icons should use the `aria-hidden` attribute as they are purely decorative.
Props audrasjb, ryokuhi.
Fixes #50293 .
Built from https://develop.svn.wordpress.org/trunk@47910
git-svn-id: http://core.svn.wordpress.org/trunk@47684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 15:47:09 +00:00
00d3696923
Media: Add an action for `wp_media_attach_action`.
...
This action fires when media is attached/detached from a post.
Fixes : #49614 .
Props: jonoaldersonwp, antpb, rebasaurus, donmhico.
Built from https://develop.svn.wordpress.org/trunk@47909
git-svn-id: http://core.svn.wordpress.org/trunk@47683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 15:00:09 +00:00
0eaae8ebbf
Docs: Update type for `WP_Block_Type::$style` property.
...
Follow-up to [47907].
See #48529 .
Built from https://develop.svn.wordpress.org/trunk@47908
git-svn-id: http://core.svn.wordpress.org/trunk@47682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 10:44:10 +00:00
eec4c743fa
Blocks: Update default value for some fields in WP_Block_Type
...
Related to the issue with default values for the blocks registered on the server. By using null for some fields we can treat them as undefined on the client.
See: WordPress/gutenberg#22849.
Props aduth.
Fixes #48529 .
Built from https://develop.svn.wordpress.org/trunk@47907
git-svn-id: http://core.svn.wordpress.org/trunk@47681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 06:07:13 +00:00
b50e87d52b
Docs: Add missing `@global` reference for the `$post_id` global in `wp_admin_bar_edit_menu()`.
...
Follow-up to [47903].
Props davidbaumwald.
See #50312 .
Built from https://develop.svn.wordpress.org/trunk@47906
git-svn-id: http://core.svn.wordpress.org/trunk@47680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 21:27:09 +00:00
2ef561db67
Build/Test Tools: Revert [47901].
...
This is not matching branches as desired.
Unrops desrosj, jorbin, ocean90, TimothyBlynJacobs.
Fixes #50307 .
Built from https://develop.svn.wordpress.org/trunk@47905
git-svn-id: http://core.svn.wordpress.org/trunk@47679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 21:14:09 +00:00
df343d59f2
Build/Test: Die with an error if populate_network fails
...
If you are missing WP_TESTS_EMAIL, populate_network will fail and it can be hard to debug. As populate_network can return a wp_error object, we can detect that and display the error to a user.
See: https://github.com/WordPress/gutenberg/pull/22613
Fixes : #50251
Props: TimothyBlynJacobs
Built from https://develop.svn.wordpress.org/trunk@47904
git-svn-id: http://core.svn.wordpress.org/trunk@47678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 21:04:10 +00:00
524f188982
Toolbar: Display a "View Post" link when viewing comments for a single post on Comments screen.
...
Props Otto42, matt, SergeyBiryukov.
Fixes #50312 .
Built from https://develop.svn.wordpress.org/trunk@47903
git-svn-id: http://core.svn.wordpress.org/trunk@47677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 19:57:10 +00:00
27485fd7aa
General: Continuing to work towards a passing PHP Compatibility scan.
...
This is a final pass to fix PHP compatibiilty issues in the codebase with code changes or adding `phpcs:ignore` comments.
With this change, all PHP compatibility warnings and errors without specific tickets have been addressed (see #49810 and #41750 ).
Props desrosj, johnbillion, jrf.
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47902
git-svn-id: http://core.svn.wordpress.org/trunk@47676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 17:40:12 +00:00
e2790b4e63
Build/Test Tools: Disable Travis CI build Slack notifications for non-official branches.
...
When branches are unintentionally pushed to the GitHub `wordpress-develop` mirror by committers, a build is triggered in Travis and the result is reported in Slack if the criteria defined is met.
Though this is not the desired workflow (any modifications made to the mirror are erased when the repository is synced from SVN), this can cause a lot of noise if several pushes are made and raise false alarms.
This change limits builds only to the `master` branch, and branches meeting the `X.X` pattern to match each branched version.
Props desrosj, jorbin, ocean90, TimothyBlynJacobs.
Fixes #50307 .
Built from https://develop.svn.wordpress.org/trunk@47901
git-svn-id: http://core.svn.wordpress.org/trunk@47675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 17:03:12 +00:00
353def14e2
Docs: Document the `term_order` value for the `orderby` parameter of `WP_Term_Query::__construct()`.
...
Props pbiron.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47898
git-svn-id: http://core.svn.wordpress.org/trunk@47672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 14:41:06 +00:00
5636fb886b
Docs: Reformat the `orderby` section of `WP_Term_Query::__construct()` for better readability.
...
This makes it more consistent with the `fields` section.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47897
git-svn-id: http://core.svn.wordpress.org/trunk@47671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 14:37:09 +00:00
f22e113e95
File Editor: Don't verify SSL certificate when doing loopback requests for checking for fatal errors.
...
Previously, verification was disabled for the loopback request to the admin URL, but not to the home URL.
Follow-up to [46230].
Props munyagu.
Fixes #50309 . See #47957 .
Built from https://develop.svn.wordpress.org/trunk@47896
git-svn-id: http://core.svn.wordpress.org/trunk@47670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 11:43:15 +00:00
683507fe14
External Libraries: Update clipboard.js to 2.0.6.
...
This change includes some bug fixes and removal of the PhantomJS dependency.
Changelog: https://github.com/zenorocha/clipboard.js/compare/v2.0.4...v2.0.6
Props hareesh-pillai.
Fixes #50306 .
Built from https://develop.svn.wordpress.org/trunk@47895
git-svn-id: http://core.svn.wordpress.org/trunk@47669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 11:12:33 +00:00
cf597dcf7c
Plugins: Make the message displayed when no plugins are installed more concise.
...
Props johnjamesjacoby, Presskopp.
Fixes #42336 .
Built from https://develop.svn.wordpress.org/trunk@47894
git-svn-id: http://core.svn.wordpress.org/trunk@47668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 10:51:13 +00:00
b247cafd91
Docs: Correct `@since` version for `available_permalink_structure_tags` filter.
...
Follow-up to [41182].
Props tiagohillebrandt, sabernhardt.
Fixes #42624 .
Built from https://develop.svn.wordpress.org/trunk@47893
git-svn-id: http://core.svn.wordpress.org/trunk@47667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 10:38:09 +00:00
72b5018aa3
Docs: Miscellaneous DocBlock corrections.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47892
git-svn-id: http://core.svn.wordpress.org/trunk@47666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 10:02:13 +00:00
86b50870ec
Formatting: add a new 'safe_style_disallowed_chars' filter.
...
Enable developers to change the regex used in `safecss_filter_attr` to limit characters in the parsed CSS.
Props paulschreiber, swissspidy, rmccue, bartekcholewa, miinasikk.
Fixes #37134 .
Built from https://develop.svn.wordpress.org/trunk@47891
git-svn-id: http://core.svn.wordpress.org/trunk@47665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 23:46:11 +00:00
569c006248
Comments: Rename `Walker_Comment::comment_text()` to `::filter_comment_text()` for clarity.
...
Ensure the comment object is not null before checking its status.
Follow-up to [47887].
See #49956 .
Built from https://develop.svn.wordpress.org/trunk@47889
git-svn-id: http://core.svn.wordpress.org/trunk@47663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 21:45:10 +00:00
9f86174e08
Comments: Ensure that unmoderated comments won't be search indexed.
...
After a comment is submitted, only allow a brief window where the comment is live on the site.
Fixes #49956 .
Props: jonkolbert, ayeshrajans, Asif2BD, peterwilsoncc, imath, audrasjb, jonoaldersonwp, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47887
git-svn-id: http://core.svn.wordpress.org/trunk@47661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 20:12:07 +00:00
30b61fc9e8
Bundled Themes: Consistently check for `WP_Error` before outputting `get_the_tag_list()`.
...
Some themes already had these checks in place as a result of [41756], but not others.
Props sixhours, davidakennedy, SergeyBiryukov.
Fixes #39860 .
Built from https://develop.svn.wordpress.org/trunk@47886
git-svn-id: http://core.svn.wordpress.org/trunk@47660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 17:05:13 +00:00
3fd1fe298a
Docs: Correct `@param` type for `pre_redirect_guess_404_permalink` filter.
...
Improve filter documentation for consistency with other similar short-circuit filters in core.
Follow-up to [47878].
See #16557 .
Built from https://develop.svn.wordpress.org/trunk@47885
git-svn-id: http://core.svn.wordpress.org/trunk@47659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 16:23:11 +00:00
ba92ed7615
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/updates.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50235 .
Built from https://develop.svn.wordpress.org/trunk@47884
git-svn-id: http://core.svn.wordpress.org/trunk@47658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 21:41:09 +00:00
0318a92948
Plugins and Themes Auto-Updates: update the state of the auto-update link on the themes screen after successfully saving the setting.
...
Props desrosj, pbiron, azaozz.
Fixes #50291 .
Built from https://develop.svn.wordpress.org/trunk@47883
git-svn-id: http://core.svn.wordpress.org/trunk@47657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 20:53:15 +00:00
94be20e612
Build/Test Tools: Avoid an empty "title" heading if no title is set in `_wp_die_handler_exit()` and `_wp_die_handler_txt()`.
...
Fixes #50297 .
Built from https://develop.svn.wordpress.org/trunk@47882
git-svn-id: http://core.svn.wordpress.org/trunk@47656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 20:50:08 +00:00
c5ac08ba45
Build/Test Tools: Add PHPUnit to Composer dev dependencies.
...
This helps setting up the correct version of PHPUnit to run WordPress core tests locally and for using it as source for code autocompletion in tests. Also introduces a new Composer script `test` to run the PHPUnit tests.
Props welcher, ayeshrajans, vinkla, johnbillion, Rarst, netweb, ocean90.
Fixes #46815 .
Built from https://develop.svn.wordpress.org/trunk@47881
git-svn-id: http://core.svn.wordpress.org/trunk@47655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 20:31:07 +00:00
c7aab4121f
Build/Test Tools: Let `WP_UnitTestCase_Base` extend the namespaced version of PHPUnit's test case class.
...
With the minimum PHP version requirement set to 5.6 we're now able to use namespaces by default. This replaces `PHPUnit_Framework_TestCase` with `PHPUnit\Framework\TestCase` for `WP_UnitTestCase_Base` to solve autocompletion issues with code editors when using more recent PHPUnit versions. `PHPUnit\Framework\TestCase` is available since PHPUnit 5.4 and now the minimum required PHPUnit version.
Fixes #50236 .
Built from https://develop.svn.wordpress.org/trunk@47880
git-svn-id: http://core.svn.wordpress.org/trunk@47654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 19:43:13 +00:00
69a866a1a9
Administration: Unify the date structure in list view and excerpt view.
...
Both views now show a full date string. Something like `Published 2020/05/27 at 10:25 pm`.
Fixes : #35391 .
Props: afercia, ocean90, TimothyBlynJacobs, audrasjb, SergeyBiryukov, joedolson.
Built from https://develop.svn.wordpress.org/trunk@47879
git-svn-id: http://core.svn.wordpress.org/trunk@47653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 19:15:08 +00:00
f201c1b217
Canonical: Add the ability to disable `redirect_guess_404_permalink()`.
...
This also adds a few more filters to make adding redirects easier. Notably:
1. `do_redirect_guess_404_permalink`
2. `pre_redirect_guess_404_permalink`
3. `strict_redirect_guess_404_permalink`
Fixes : #16557 .
Props: msafi, nacin, simonwheatley, westi, mboynes, joostdevalk, Lex_Robinson, MikeSchinkel, haukep, paulschreiber, DrewAPicture, ravenswd, esemlabel, stevegibson12, martychc23, DrLightman, jivanpal, neonkowy, laternastudio, apedog, audrasjb, davidbaumwald, Confridin, donmhico, ryotsun.
Built from https://develop.svn.wordpress.org/trunk@47878
git-svn-id: http://core.svn.wordpress.org/trunk@47652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 18:49:10 +00:00
b65cf7f992
Build/Test Tools: Improve Travis config to pass config validation.
...
* Add missing `os` and `dist` with the current default values.
* Replace the alias `matrix` with `jobs`.
* Remove unsupported `on_start` for `notifications.slack`.
Fixes #50296 .
Built from https://develop.svn.wordpress.org/trunk@47877
git-svn-id: http://core.svn.wordpress.org/trunk@47651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 16:39:08 +00:00
7152c73f6a
Editor: Fix code style for constructor arguments added in [47875].
...
Also revert unintended changes to `WP_Block_Type::__construct()` DocBlock.
See #48529 .
Built from https://develop.svn.wordpress.org/trunk@47876
git-svn-id: http://core.svn.wordpress.org/trunk@47650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 16:27:15 +00:00
c704057e0d
Add fields to WP_Block_Type
...
As part of #47620 and the RFC for block registeration. Server registered blocks are missing some fields. These changeset includes them.
Props spacedmonkey, aduth.
Fixes #48529 .
Built from https://develop.svn.wordpress.org/trunk@47875
git-svn-id: http://core.svn.wordpress.org/trunk@47649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 12:27:08 +00:00
1c176ffb1e
Docs: Correct and clarify an inline comment about the `upload_url_path` and `upload_path` options in `wp-admin/options-media.php`.
...
Synchronize it with a similar comment in `wp-admin/options.php`.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47874
git-svn-id: http://core.svn.wordpress.org/trunk@47648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 11:22:13 +00:00
cda84f2409
Build/Test Tools: Bump `node-sass` and `webpack-dev-server` versions as a result of `npm audit`.
...
Props whyisjake.
See #49768 .
Built from https://develop.svn.wordpress.org/trunk@47873
git-svn-id: http://core.svn.wordpress.org/trunk@47647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 20:24:46 +00:00
f7da44c8d2
Upgrade/Install: Rename `wp_in_maintenance_mode()` to `wp_is_maintenance_mode()`, for consistency with `wp_is_recovery_mode()`.
...
While the former name might be a bit more accurate, the latter matches the existing naming pattern.
Follow-up to [47623].
Fixes #49959 .
Built from https://develop.svn.wordpress.org/trunk@47871
git-svn-id: http://core.svn.wordpress.org/trunk@47646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 19:54:24 +00:00
5f47ca5b8b
Docs: Adjust the documentation for the new `ID` alias in `get_term_by()` for consistency with `get_user_by()`.
...
Follow-up to [47865].
See #45163 .
Built from https://develop.svn.wordpress.org/trunk@47870
git-svn-id: http://core.svn.wordpress.org/trunk@47645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 19:53:04 +00:00
9859bf6204
Build/Test Tools: Revert some devDependency changes for 5.5.
...
After bumping some major updates, tests on Travis are failing.
See: https://travis-ci.com/WordPress/wordpress-develop/builds/168839259 ##49768.
Unprops: whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47869
git-svn-id: http://core.svn.wordpress.org/trunk@47644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 19:51:42 +00:00
ef135efa6d
Build/Test Tools: Bump devDependencies for WordPress 5.5
...
There are several other changes that need to be made for the security audit, this is just the first pass.
Fixes #49768 .
Props SergeyBiryukov, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47867
git-svn-id: http://core.svn.wordpress.org/trunk@47643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-30 04:56:34 +00:00
e8fa5d6fc2
Code Standards: Clean up whitespace on the end of a file.
...
See: #45163 .
Props: whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47866
git-svn-id: http://core.svn.wordpress.org/trunk@47642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-29 23:35:11 +00:00
7798f64340
Taxonomy: Extend `get_term_by` to accept `ID` as a term parameter.
...
Similar to `get_user_by`, both `ID` and `id` should be able to accepted.
Fixes #45163 .
Props emrikol, esoj.
Built from https://develop.svn.wordpress.org/trunk@47865
git-svn-id: http://core.svn.wordpress.org/trunk@47641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-29 22:43:09 +00:00
2277a9df24
Docs: Improve documentation for functions in `wp-includes/category.php` per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47864
git-svn-id: http://core.svn.wordpress.org/trunk@47640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-29 10:07:10 +00:00
bc18c233d6
Docs: Document that `get_category_by_slug()` returns `false` if the category doesn't exist.
...
Props stevenlinx.
Fixes #50277 .
Built from https://develop.svn.wordpress.org/trunk@47863
git-svn-id: http://core.svn.wordpress.org/trunk@47639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-29 10:02:13 +00:00
8924832842
Coding Standards: Use strict comparison in `wp-admin/_index.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47862
git-svn-id: http://core.svn.wordpress.org/trunk@47638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-28 10:02:12 +00:00
8713fac0d7
Docs: Remove unused `@global` declarations from `_WP_Editors::print_tinymce_scripts()`.
...
Follow-up to [47860].
See #45398 .
Built from https://develop.svn.wordpress.org/trunk@47861
git-svn-id: http://core.svn.wordpress.org/trunk@47637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-27 19:48:11 +00:00
552883574b
Editor: Remove TinyMCE global version.
...
The global variable is not being used in the `editor_settings` method.
Fixes #45398 .
Props ishitaka, noisysocks, mista-flo.
Built from https://develop.svn.wordpress.org/trunk@47860
git-svn-id: http://core.svn.wordpress.org/trunk@47636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-27 19:28:12 +00:00
38b7495af7
Administration and Site Health: Make information on Search engine visibility more prominent.
...
- makes the "Search engines discouraged" message on the Dashboard more prominent
- adds "Search engine visibility" information under Site Health > Info > WordPress
- removes title case in favor of sentence case in all the related strings
Props audrasjb, swissspidy, emanuel_blagonic, Presskopp, karmatosed, valentinbora, melchoyce.
Fixes #35288 .
Built from https://develop.svn.wordpress.org/trunk@47859
git-svn-id: http://core.svn.wordpress.org/trunk@47635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-27 14:33:11 +00:00
95d53b9a66
Docs: Correct `@return` value for `WP_REST_Meta_Fields::get_value()`.
...
Props chrisvanpatten.
Fixes #50259 .
Built from https://develop.svn.wordpress.org/trunk@47858
git-svn-id: http://core.svn.wordpress.org/trunk@47634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-27 09:44:11 +00:00
57fb3c6cf0
Coding Standards: Change auto-update filters to be more consistent.
...
* send_theme_auto_update_email 👉 auto_theme_update_send_email
* wp_plugins_auto_update_enabled 👉 plugins_auto_update_enabled
* wp_themes_auto_update_enabled 👉 themes_auto_update_enabled
Want to make sure that @ronalfy gets props for his work in #50052 too.
See #50052 .
Props: ronalfy, pbiron, azaozz, audrasjb, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47857
git-svn-id: http://core.svn.wordpress.org/trunk@47633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-26 18:03:08 +00:00
a01835679a
Posts, Post Types: Pass the post object to the `delete_attachment` action.
...
Also add the missing `$post` parameter to the `delete_post` and `deleted_post` actions in `wp_delete_attachment()`.
See #30940 .
Built from https://develop.svn.wordpress.org/trunk@47856
git-svn-id: http://core.svn.wordpress.org/trunk@47632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-26 14:49:06 +00:00
7b192d406a
Coding Standards: Fix instances of `Generic.WhiteSpace.ArbitraryParenthesesSpacing.FoundEmpty`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47855
git-svn-id: http://core.svn.wordpress.org/trunk@47631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-26 09:37:10 +00:00
235bd98f3c
Docs: Improve documentation for `add_existing_user_to_blog()`.
...
Props stevenlinx.
Fixes #50243 .
Built from https://develop.svn.wordpress.org/trunk@47854
git-svn-id: http://core.svn.wordpress.org/trunk@47630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-25 14:23:13 +00:00
786ac48c84
Coding Standards: Use strict comparison in `wp-admin/network` where static strings are involved.
...
Includes minor code layout fixes for better readability.
Follow-up to [47808].
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47853
git-svn-id: http://core.svn.wordpress.org/trunk@47629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-24 09:17:09 +00:00
5899bf0f32
Coding Standards: Use strict comparison for `$wp_db_version` check in `wp-admin/network/upgrade.php`.
...
Follow-up to [47787], [47788].
See #50155 , #49542 .
Built from https://develop.svn.wordpress.org/trunk@47852
git-svn-id: http://core.svn.wordpress.org/trunk@47628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-24 09:15:07 +00:00
5b4174e409
Coding Standards: Use strict comparison for more `count()` calls.
...
Follow-up to [47848].
Props mukesh27.
Fixes #50232 . See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47851
git-svn-id: http://core.svn.wordpress.org/trunk@47627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 16:22:07 +00:00
ed71319421
Role/Capability: Use meta caps `edit_post`, `read_post`, and `delete_post` directly.
...
Rather than consulting the post type object, let `map_meta_cap()` handle that for us.
Props peterwilsoncc, ocean90.
Fixes #50128 .
See #23226 .
Built from https://develop.svn.wordpress.org/trunk@47850
git-svn-id: http://core.svn.wordpress.org/trunk@47626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 15:24:07 +00:00
aaeab2f3f5
Rest API: Ensure `rest_ensure_response()` upgrades `WP_HTTP_Response` to `WP_REST_Response`.
...
An instance of `WP_HTTP_Response` doesn't ensure that the required methods used in `WP_REST_Server::dispatch()` exist, currently causing a fatal error.
Props ali11007, TimothyBlynJacobs, ocean90.
Fixes #49495 .
Built from https://develop.svn.wordpress.org/trunk@47849
git-svn-id: http://core.svn.wordpress.org/trunk@47625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 14:36:09 +00:00
b9751d4efe
Coding Standards: Use strict comparison for `count()` calls.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47848
git-svn-id: http://core.svn.wordpress.org/trunk@47624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 11:38:08 +00:00
e9282e7389
Bundled Themes: Add missing RTL styles for to fix inconsistent margins on `.alignwide` and `.alignfull` items.
...
Fixes the inconsistent margins for alignwide and alignfull classes used on Cover Block when it is the first block on a page.
Props kthmd, utz119, nikhilbhansi, and sabernhardt.
Fixes #49435 .
Built from https://develop.svn.wordpress.org/trunk@47846
git-svn-id: http://core.svn.wordpress.org/trunk@47622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 06:23:06 +00:00
f1114d4507
Coding Standards: Fix WPCS issues in `wp-admin/plugin-editor.php` and `wp-admin/theme-editor.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47845
git-svn-id: http://core.svn.wordpress.org/trunk@47621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 00:01:10 +00:00
c0bec847d1
Theme Editor: Remove unused `$has_templates` boolean.
...
The variable is a remnant from when the Theme Editor still had the "Templates" heading and is unused in the current logic.
The condition it was a part of would always evaluate to true for a child theme, regardless of the `$has_templates` value.
Props dboy1988.
Fixes #50199 .
Built from https://develop.svn.wordpress.org/trunk@47844
git-svn-id: http://core.svn.wordpress.org/trunk@47620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-22 23:20:08 +00:00
e7150ae5c7
REST API: Ensure proper namespacing when registering routes.
...
The PR will corerce routes that have a leading slash and throwing a `_doing_it_wrong` notice while ensuring a proper namespace.
Fixes #49749 .
Props TimothyBlynJacobs, skarabeq, afercia.
Built from https://develop.svn.wordpress.org/trunk@47842
git-svn-id: http://core.svn.wordpress.org/trunk@47618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-22 20:48:08 +00:00
5850f5f6ef
Coding Standards: Fix WPCS issues in `wp-admin/includes/class-wp-site-health-auto-updates.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47841
git-svn-id: http://core.svn.wordpress.org/trunk@47617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-22 17:56:08 +00:00
64ed8a7355
Coding Standards: Fix WPCS issues in `wp-admin/includes/class-wp-debug-data.php`.
...
Follow-up to [47550], [47557], [47835].
See #50052 .
Built from https://develop.svn.wordpress.org/trunk@47840
git-svn-id: http://core.svn.wordpress.org/trunk@47616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-22 17:26:07 +00:00
443dd105d4
Customize: Move the WordPress logo with a white background to the `wp-includes` directory.
...
This ensures that the image used as a default site icon looks good on a dark background.
The image was previously changed in the `wp-admin` directory, but the site icon is now loaded from `wp-includes`.
Follow-up to [36635], [47018], [47564], [47832].
Props ocean90.
Fixes #49798 .
Built from https://develop.svn.wordpress.org/trunk@47838
git-svn-id: http://core.svn.wordpress.org/trunk@47614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-21 09:10:12 +00:00
39babb4dfb
KSES: Support the `video` element's `playsinline` attribute.
...
Allow users without the `unfiltered_html` capability to use the `playsinline` attribute when embedding videos.
Additionally this adds unit tests for passing the video element through kses.
Fixes #50167 . See #29826 .
Built from https://develop.svn.wordpress.org/trunk@47837
git-svn-id: http://core.svn.wordpress.org/trunk@47613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-21 04:54:11 +00:00
ba03c426db
Docs: Add missing `@since` tag for `auto_plugin_theme_update_email` filter.
...
See #50052 .
Built from https://develop.svn.wordpress.org/trunk@47836
git-svn-id: http://core.svn.wordpress.org/trunk@47612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-20 19:33:10 +00:00
661b929e1e
Security: Add user interface to auto-update themes and plugins.
...
Building on core update mechanisms, this adds the ability to enable automatic updates for themes and plugins to the WordPress admin.
Fixes : #50052 .
Props: afercia, afragen, audrasjb, azaozz, bookdude13, davidperonne, desrosj, gmays, gmays, javiercasares, karmatosed, knutsp, mapk, mukesh27, netweb, nicolaskulka, nielsdeblaauw, paaljoachim, passoniate, pbiron, pedromendonca, whodunitagency, whyisjake, wpamitkumar, and xkon.
Built from https://develop.svn.wordpress.org/trunk@47835
git-svn-id: http://core.svn.wordpress.org/trunk@47611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-20 18:49:09 +00:00
2a86d8d534
Accessibility: Media: Hide the invisible "file input" on media views from assistive technologies.
...
The file input button is visually hidden, but was announced by screen readers in workflows unrelated to file uploads.
It is now hidden from assistive technologies by the means of an `aria-hidden` attribute, as its CSS display property must not be changed to make sure it still works on old browsers.
See #49753 .
Fixes #47611 .
Built from https://develop.svn.wordpress.org/trunk@47834
git-svn-id: http://core.svn.wordpress.org/trunk@47610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-20 13:33:07 +00:00
23c4fbeaa0
Customize: Load the default site icon from the `wp-includes` directory.
...
Files inside the `wp-admin` directory may not be publicly available.
Follow-up to [36635], [47018].
Props whyisjake, finomeno, ocean90.
Fixes #50131 .
Built from https://develop.svn.wordpress.org/trunk@47832
git-svn-id: http://core.svn.wordpress.org/trunk@47608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-20 10:36:09 +00:00
434bee9fc9
Coding Standards: Fix WPCS issues in `wp-includes/class-wp-customize-manager.php`.
...
Follow-up to [47819].
Props sorenbronsted.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47821
git-svn-id: http://core.svn.wordpress.org/trunk@47597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-19 08:41:12 +00:00
bc0e05d6c8
Bundled Themes: Twenty Twenty inconsistent top and bottom margins for `.alignwide` and `.alignfull` on Chrome vs Safari.
...
Fixes the inconsistent margins for `alignwide` and `alignfull` classes used on Cover Block when it is the first block on a page.
Props kthmd, utz119, nikhilbhansi.
Fixes #49435 .
Built from https://develop.svn.wordpress.org/trunk@47820
git-svn-id: http://core.svn.wordpress.org/trunk@47596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 19:52:07 +00:00
307725883a
Themes: Prevent installation of themes that require a higher version of PHP or WordPress.
...
Props afragen.
Fixes #49653 . See #48491 .
Built from https://develop.svn.wordpress.org/trunk@47819
git-svn-id: http://core.svn.wordpress.org/trunk@47595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 16:03:09 +00:00
54cdfaef59
Themes: Remove extra whitespace from `wp-admin/includes/ajax-actions.php` and `wp-admin/includes/theme.php`.
...
Follow-up to [47816].
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@47818
git-svn-id: http://core.svn.wordpress.org/trunk@47594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 12:55:06 +00:00
e445642243
Themes: Remove debug call from `wp-admin/theme-install.php`.
...
Follow-up to [47816].
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@47817
git-svn-id: http://core.svn.wordpress.org/trunk@47593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 12:49:08 +00:00
b73bbd8139
Themes: Prevent activation and live preview of themes that require a higher version of PHP or WordPress.
...
Props afragen, jorbin, TimothyBlynJacobs, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@47816
git-svn-id: http://core.svn.wordpress.org/trunk@47592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 12:32:10 +00:00
d528d7a044
Site Health: Use `WP_Theme::parent()` in the inactive themes test as a more reliable check that the parent theme exists.
...
This is also more consistent with the other instances of directly referencing `WP_Theme::parent()` properties or methods in core.
Props mukesh27, juanlopez4691, davidbaumwald, afragen, SergeyBiryukov.
Fixes #49934 .
Built from https://develop.svn.wordpress.org/trunk@47815
git-svn-id: http://core.svn.wordpress.org/trunk@47591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 04:38:10 +00:00
91936df3d1
Coding Standards: Fix WPCS issues in plugin and theme upgrader classes.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47814
git-svn-id: http://core.svn.wordpress.org/trunk@47590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-17 09:39:11 +00:00
f9b60d3334
Accessibility: Login and Registration: Respect the `prefers-reduced-motion` media query for "shake" CSS animation on login failure.
...
This shake should not occur when the user has opted to reduce motion, for example by selecting the "Reduce motion" option in macOS' preferences or unselecting "Show animations in Windows" in Windows' preferences.
Follow-up to [47226].
Props eddystile, johnbillion, sabernhardt, afercia, audrasjb.
Fixes #49723 .
Built from https://develop.svn.wordpress.org/trunk@47813
git-svn-id: http://core.svn.wordpress.org/trunk@47589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 20:25:19 +00:00
cf0bfa3856
Coding Standards: Correct docblock indentation.
...
Fixes PHPCS failure introduced in r47811.
Built from https://develop.svn.wordpress.org/trunk@47812
git-svn-id: http://core.svn.wordpress.org/trunk@47588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 19:56:09 +00:00
1e524e7322
REST API: Add @since entries for rest_validate_value_from_schema().
...
See #49572 , #48818 , #44949 , #50053 , #48820 , #49720 , #42961 , #44975 , #43392 , #38583 .
Built from https://develop.svn.wordpress.org/trunk@47811
git-svn-id: http://core.svn.wordpress.org/trunk@47587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 19:33:09 +00:00
fe00d7f7bf
REST API: Support the JSON Schema pattern keyword.
...
Props jason_the_adams, birgire, sorenbronsted.
Fixes #44949 .
Built from https://develop.svn.wordpress.org/trunk@47810
git-svn-id: http://core.svn.wordpress.org/trunk@47586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 19:03:08 +00:00
26bda18a23
REST API: Check required properties are provided when validating an object.
...
Previously, the WP_REST_Request object validated that top-level properties were defined, but this did not extend to those object's required properties. This adds validation to rest_validate_value_from_schema() directly.
Both the v3 and v4 JSON Schema syntax for required properties is supported.
Props sorenbronsted.
Fixes #48818 .
Built from https://develop.svn.wordpress.org/trunk@47809
git-svn-id: http://core.svn.wordpress.org/trunk@47585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:44:09 +00:00
7932193708
Coding Standards: Use strict comparison where static strings are involved.
...
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47808
git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
45f7e68d54
Media: Expose media grid frame via `wp-media-grid-ready` trigger for easier customization.
...
Props soulseekah.
Fixes #50185 .
Built from https://develop.svn.wordpress.org/trunk@47807
git-svn-id: http://core.svn.wordpress.org/trunk@47583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 17:25:11 +00:00
16a8128765
Coding Standards: Fix WPCS issues in `wp-admin/includes/class-wp-screen.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47802
git-svn-id: http://core.svn.wordpress.org/trunk@47578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-15 18:13:09 +00:00
e54d8406eb
Bundled Themes: Twenty Eleven & Twenty Twelve dropdown category widget exceeds parent div when strings are long enough.
...
Fixes the width of the category dropdown by limiting the width of `select` items in widgets using `max-width: 100%`.
Props gma992, karmatosed.
Fixes #37926 .
Built from https://develop.svn.wordpress.org/trunk@47801
git-svn-id: http://core.svn.wordpress.org/trunk@47577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-15 16:31:11 +00:00
b10bd5134c
Bundled Themes: Twenty Twenty version bump.
...
We are releasing a new version of Twenty Twenty today thus we need to bump the version.
Props ianbelanger.
Fixes #50174 .
Built from https://develop.svn.wordpress.org/trunk@47800
git-svn-id: http://core.svn.wordpress.org/trunk@47576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 18:12:07 +00:00
86b20d5655
Bundled Themes: Twenty Twenty custom post types that don't support authors, shows author box.
...
This fixes the issue where custom post types will show an author box, even if they don't support authors.
Props joyously, donmhico.
Fixes #48803 .
Built from https://develop.svn.wordpress.org/trunk@47799
git-svn-id: http://core.svn.wordpress.org/trunk@47575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 17:17:07 +00:00
whyisjake
Sergey Biryukov
desrosj
ianbelanger
Dominik Schilling
TimothyBlynJacobs
Peter Wilson
Adam Silverstein
gziolo
Aaron Jorbin
Andrew Ozz
Andrea Fercia