Commit Graph

33951 Commits

Author SHA1 Message Date
Tammie Lister 12c6679165 Twenty Thirteen, Twenty Fourteen and Twenty Fifteen: Fixes insufficient check for existence of DOM elements in jQuery object
Fixes #34033
Props: tywayne 

Built from https://develop.svn.wordpress.org/trunk@36999


git-svn-id: http://core.svn.wordpress.org/trunk@36966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-15 21:33:28 +00:00
Mike Schroder 942f9d6357 Media: Fix typo in `test_image_preserves_alpha_on_rotate()`.
peserves -> preserves; introduced in [31040].

See #30596.
Built from https://develop.svn.wordpress.org/trunk@36998


git-svn-id: http://core.svn.wordpress.org/trunk@36965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-15 03:51:25 +00:00
Gary Pendergast c233a88379 WPDB: Reset connection status variables when the connection is closed.
Fixes #36240.


Built from https://develop.svn.wordpress.org/trunk@36997


git-svn-id: http://core.svn.wordpress.org/trunk@36964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-15 03:28:26 +00:00
Mike Schroder 9af79e2582 Media: Fall back to GD when loading URL in HHVM Imagick.
HHVM does not currently support loading URLs in its port of Imagick.
Fixes `test_wp_crop_image_url()` failure introduced in [36916].

See #35973.
Built from https://develop.svn.wordpress.org/trunk@36996


git-svn-id: http://core.svn.wordpress.org/trunk@36963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-15 00:15:26 +00:00
John Blackbourn 852f085d19 Docs: The `$update_result` parameter passed to `WP_Automatic_Updater::after_core_update()` is never a `WP_Error`. If an error is returned, the error object lives in the `result` property of the paramter.
See #32246

Built from https://develop.svn.wordpress.org/trunk@36995


git-svn-id: http://core.svn.wordpress.org/trunk@36962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 22:43:27 +00:00
John Blackbourn 2cee8966ab Docs: Re-add a `@param` that went missing in [36993].
See #32246

Built from https://develop.svn.wordpress.org/trunk@36994


git-svn-id: http://core.svn.wordpress.org/trunk@36961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 22:39:26 +00:00
John Blackbourn 7ecfdc69b7 Docs: Improvements and corrections for the `$ver` parameter of the dependencies API functions.
See #32246

Built from https://develop.svn.wordpress.org/trunk@36993


git-svn-id: http://core.svn.wordpress.org/trunk@36960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 22:37:26 +00:00
John Blackbourn 621085a360 Users: Add `@since` entries to `wp_authenticate()` and its filters now that the `$username` parameter can also be an email address.
See #9568, #35986

Built from https://develop.svn.wordpress.org/trunk@36992


git-svn-id: http://core.svn.wordpress.org/trunk@36959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 22:31:27 +00:00
Andrew Ozz b9a3602070 wpLink: fix accessibility issues:
- Add role=dialog and an aria-labelledby attribute to the modal container.
- Change the modal title to h1.
- Remove one ` ` that gets read out as `blank` by screen readers.
- Replace the Cancel link with a button.
- Clean up unused CSS.

Props afercia.
Fixes #30468.
Built from https://develop.svn.wordpress.org/trunk@36991


git-svn-id: http://core.svn.wordpress.org/trunk@36958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 20:55:26 +00:00
Weston Ruter 783aa8b4fa Customize: Rely on selective refresh exclusively for previewing custom logo changes.
Eliminates JS logic (from [36698]) which attempted to do pure JS update while waiting for the selective refresh response to return. The duplicate JS logic lacked a re-implementation of the `image_downsize()` functionality available in PHP, and so the JS preview logic would fail to properly preview images that didn't have the exact theme image size generated. To keep the code DRY and to eliminate the momentary display of an improperly-sized image, the duplicated JS logic is now removed.

See #27355.
See #33755.
Fixes #36096.

Built from https://develop.svn.wordpress.org/trunk@36990


git-svn-id: http://core.svn.wordpress.org/trunk@36957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 19:17:28 +00:00
Boone Gorges 036e63c31a Query: Ignore search terms consisting of a single dash.
Due to the "exclude" support added in WP 4.4, single dashes were being
converted to "NOT LIKE '%%'" clauses, causing all searches to fail.

Props RomSocial, swissspidy.
Fixes #36195.
Built from https://develop.svn.wordpress.org/trunk@36989


git-svn-id: http://core.svn.wordpress.org/trunk@36956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 14:12:25 +00:00
Boone Gorges cac6d65780 Improve error handling in `get_categories()`.
When passed an invalid `'taxonomy'`, `get_terms()` will return a `WP_Error`
object. This object should not be blindly cast to an array. Instead, an empty
array should be returned, to indicate that no matching terms have been found.

Props virgodesign, sebastian.pisula.
Fixes #36227.
Built from https://develop.svn.wordpress.org/trunk@36988


git-svn-id: http://core.svn.wordpress.org/trunk@36955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 13:53:28 +00:00
Sergey Biryukov 138b2abcf5 Media: Fix typo introduced in [36887].
Props claudiosanches.
Fixes #36230. See #36089.
Built from https://develop.svn.wordpress.org/trunk@36987


git-svn-id: http://core.svn.wordpress.org/trunk@36954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 09:00:28 +00:00
Boone Gorges ea58c985bd Fix test related to cap check in `get_edit_term_link()`.
The test was introduced in [36646] was intended to demonstrate that the cap
check in `get_edit_term_link()` uses the custom capability from the correct
taxonomy when `$taxonomy` is not specified but must be inferred from the
provided term. However, the test was wrongly written in pretty much every way.
Antiprops boonebgorges.

Props swissspidy.
See #35922.
Built from https://develop.svn.wordpress.org/trunk@36986


git-svn-id: http://core.svn.wordpress.org/trunk@36953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 01:52:26 +00:00
Andrew Ozz 13c885bdce TinyMCE, inline link:
- Remove unused user setting for wpLink.
- Remove redundant text and variable from wp_link_dialog().

Props afercia, azaozz.
See #33301.
Built from https://develop.svn.wordpress.org/trunk@36985


git-svn-id: http://core.svn.wordpress.org/trunk@36952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 01:39:26 +00:00
Andrew Ozz cd38787ee7 TinyMCE, inline link:
- Add audible confirmation when a link has been selected or inserted in the editor for both the inline dialog and the modal.
- Do not auto-search when the URL field is empty or already contains an URL.
- Remove a few redundant `tabindex`.

Props afercia, azaozz.
See #33301.
Built from https://develop.svn.wordpress.org/trunk@36984


git-svn-id: http://core.svn.wordpress.org/trunk@36951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-14 00:53:26 +00:00
Andrew Ozz 8fda4ca0b2 TinyMCE: when dragging, prevent error when a range cannot be created at the drop location.
Fixes #36229.
Built from https://develop.svn.wordpress.org/trunk@36983


git-svn-id: http://core.svn.wordpress.org/trunk@36950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-13 22:55:25 +00:00
Andrew Ozz c495d3b2b3 TinyMCE, inline link: when doing undo/redo with keyboard shortcut, do not focus the inline dialog. Cannot do consecutive undo/redo if the focus is moved away from the editor.
See #33301.
Built from https://develop.svn.wordpress.org/trunk@36982


git-svn-id: http://core.svn.wordpress.org/trunk@36949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-13 22:44:25 +00:00
Andrew Ozz dee2f6ccb7 Fix typo in wp-emoji.js.
See #35977.
Built from https://develop.svn.wordpress.org/trunk@36981


git-svn-id: http://core.svn.wordpress.org/trunk@36948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-13 20:30:27 +00:00
Aaron Jorbin 838d93499e Revert r36978
grunt-postcss Dropped nodejs 0.10 support and this is causing builds to fail.  Revert until we bump minimum node version. 

See #35104

Built from https://develop.svn.wordpress.org/trunk@36980


git-svn-id: http://core.svn.wordpress.org/trunk@36947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-13 19:56:57 +00:00
Aaron Jorbin 2d7d1ed81c Update grunt-browserify ~4.0.1 → ~5.0.0
Updates underlying broweserify library to 13.0.0

See #35104


Built from https://develop.svn.wordpress.org/trunk@36979


git-svn-id: http://core.svn.wordpress.org/trunk@36946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-13 19:56:32 +00:00
Andrew Ozz b97b5a797b TinyMCE, inline link: ensure the inline dialog is in preview mode after updating a link from the (advanced) modal.
Props afercia.
See #33301.
Built from https://develop.svn.wordpress.org/trunk@36977


git-svn-id: http://core.svn.wordpress.org/trunk@36945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-13 17:47:26 +00:00
Andrew Ozz c481c4449b TinyMCE: tweak the small animation shown while waiting for wpView data to make it sell CPU intensive.
Props programmin.
Fixes #33525.
Built from https://develop.svn.wordpress.org/trunk@36976


git-svn-id: http://core.svn.wordpress.org/trunk@36944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-13 17:02:26 +00:00
Sergey Biryukov 1a5694fc0f Docs: Update default `$size` value for `get_custom_logo` filter after [36950].
Props wido.
See #33755.
Built from https://develop.svn.wordpress.org/trunk@36975


git-svn-id: http://core.svn.wordpress.org/trunk@36943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-13 09:14:28 +00:00
Andrew Ozz 2448d106a2 TinyMCE, inline link: when searching, do not empty the URL input field when using the arrow keys to highlight items.
Props afercia.
See #33301.
Built from https://develop.svn.wordpress.org/trunk@36974


git-svn-id: http://core.svn.wordpress.org/trunk@36942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-12 19:41:26 +00:00
Eric Lewis 8592072857 Editor: Fix Mac keyboard shortcut for distraction free writing.
Fixes #36214.

Built from https://develop.svn.wordpress.org/trunk@36973


git-svn-id: http://core.svn.wordpress.org/trunk@36941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-12 17:44:26 +00:00
Andrew Ozz 70ac7ab943 Editor: hide the Move to Trash link for auto-drafts until they are auto-saved.
Props iseulde.
Fixes #16116.
Built from https://develop.svn.wordpress.org/trunk@36972


git-svn-id: http://core.svn.wordpress.org/trunk@36940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-12 17:22:26 +00:00
Andrew Ozz 91d2354e7c Editor: correct and update the Visual and Text editors description in the screen help.
Props arush, adamsilverstein, azaozz.
Fixes #35479.
Built from https://develop.svn.wordpress.org/trunk@36971


git-svn-id: http://core.svn.wordpress.org/trunk@36939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-12 16:43:26 +00:00
Dominik Schilling d8f3325c14 Docs: Correct grammar when referring to "a URL" vs "an URL" in several places.
Fixes #36218.
Built from https://develop.svn.wordpress.org/trunk@36970


git-svn-id: http://core.svn.wordpress.org/trunk@36938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-12 12:39:27 +00:00
Pascal Birchler 9462ab0576 Taxonomy: After [36874], rename `$term_id` to `$tag_ID` in `wp-admin/edit-tag-form.php`.
This ensures that no variables changed in the process of introducing `wp-admin/term.php`, improving overall backward compatibility.

Props Chouby for initial patch.
Fixes #34988.
Built from https://develop.svn.wordpress.org/trunk@36969


git-svn-id: http://core.svn.wordpress.org/trunk@36937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-11 08:52:29 +00:00
Dominik Schilling 4497ddfcb2 Media: Merge two error messages and use `sprintf()` for the method names.
See #33642.
Built from https://develop.svn.wordpress.org/trunk@36968


git-svn-id: http://core.svn.wordpress.org/trunk@36936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 23:36:26 +00:00
Andrea Fercia 0020bcd796 Coding standards after [36510].
Built from https://develop.svn.wordpress.org/trunk@36967


git-svn-id: http://core.svn.wordpress.org/trunk@36935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 23:18:26 +00:00
Drew Jaynes 4ecad983b3 Docs: Improve two 4.5.0 changelog entries added for the `plugins_update_check_locales` and `themes_update_check_locales` filters, introduced in [36630].
See #34937. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36966


git-svn-id: http://core.svn.wordpress.org/trunk@36934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 23:01:26 +00:00
Drew Jaynes 2e0866bcbc Docs: Correct a typo in the DocBlock summary for `get_embed_template()`, introduced in [36963].
Props swissspidy.
See #34561, #34278. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36965


git-svn-id: http://core.svn.wordpress.org/trunk@36933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 22:45:26 +00:00
Andrea Fercia fd1f45a7cf Accessibility: Improve accessibility for the Plugin details modal.
The plugin details modal can be invoked from several screens. There's now a new
`.open-plugin-details-modal` CSS class to be used in combination with the
`.thickbox` CSS class that adds everything needed for accessibility.

- Adds an ARIA role `dialog` and an `aria-label` attribute to the modal
- Adds a `title` attribute to the iframe inside the modal
- Constrains tabbing within the modal
- Restores focus back in a proper place when closing the modal

Also, improves a bit the native Thickbox implementation: it should probably be
replaced with some more modern tool but at least keyboard focus should be moved
inside the modal.

Fixes #33305.
Built from https://develop.svn.wordpress.org/trunk@36964


git-svn-id: http://core.svn.wordpress.org/trunk@36932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 22:37:26 +00:00
Drew Jaynes b533878fa2 Docs: Use a third-person singular verb in the summary for `get_embed_template()`, introduced in [36876].
See #34561, #34278. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36963


git-svn-id: http://core.svn.wordpress.org/trunk@36931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 22:09:26 +00:00
Drew Jaynes c29baeb9b8 Docs: Improve changelog entries added for the `delete_term` and `delete_{$taxonomy}` actions in [36080] and a third entry added for the `clean_term_cache` action in [36399]
See #35213, #35611. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36962


git-svn-id: http://core.svn.wordpress.org/trunk@36930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 22:07:27 +00:00
Drew Jaynes f83488a058 Docs: Improve the summary and return description in the DocBlock for `unregister_taxonomy()`, introduced in [36243].
See #35227. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36961


git-svn-id: http://core.svn.wordpress.org/trunk@36929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 22:02:26 +00:00
Drew Jaynes 7f77d5074c Docs: Use a third-person singular verb for the DocBlock summary for `remove_permastruct()`, introduced in [36181].
See #35235. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36960


git-svn-id: http://core.svn.wordpress.org/trunk@36928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 22:00:27 +00:00
Andrea Fercia 899edd87da Accessibility: Improve the color contrast ratio of the expandable panel "handles".
Fixes #35923.
Built from https://develop.svn.wordpress.org/trunk@36959


git-svn-id: http://core.svn.wordpress.org/trunk@36927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 21:44:26 +00:00
Rachel Baker a6e66c0cfc Comments: On the Edit Comment screen do not show the permalink for unapproved comments.
Fixes #36161.
Built from https://develop.svn.wordpress.org/trunk@36958


git-svn-id: http://core.svn.wordpress.org/trunk@36926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 21:18:27 +00:00
Tammie Lister 74e13b1149 Twenty Elevent: Captioned image fix for editor
Fixes #33153
Props: @iseulde

Built from https://develop.svn.wordpress.org/trunk@36957


git-svn-id: http://core.svn.wordpress.org/trunk@36925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 21:13:26 +00:00
Tammie Lister d8636e70d7 Twenty Thirteen: Removes title attribute from footer
Fixes #35843
Props: @davidakennedy

Built from https://develop.svn.wordpress.org/trunk@36956


git-svn-id: http://core.svn.wordpress.org/trunk@36924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 21:07:26 +00:00
Dominik Schilling 703d5bdc8d Build Tools: Rename the `precommit:core` task to `precommit:base` for clarification.
`precommit:base` runs only the `imagemin:core` task.

Fixes #35557.
Built from https://develop.svn.wordpress.org/trunk@36955


git-svn-id: http://core.svn.wordpress.org/trunk@36923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 20:14:27 +00:00
Dominik Schilling 337488e684 oEmbed: Extend the provider list to support moments and timelines from Twitter.
Fixes #36197.
Built from https://develop.svn.wordpress.org/trunk@36954


git-svn-id: http://core.svn.wordpress.org/trunk@36922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 20:04:26 +00:00
John Blackbourn 53851c612c Rewrite Rules: Allow rewrite rules to work in nested WordPress installations on IIS.
Props WiZZarD_
Fixes #35558

Built from https://develop.svn.wordpress.org/trunk@36953


git-svn-id: http://core.svn.wordpress.org/trunk@36921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 20:01:28 +00:00
John Blackbourn adfc09f1b5 Correct a unit test for custom icon functionality.
See #36086

Built from https://develop.svn.wordpress.org/trunk@36952


git-svn-id: http://core.svn.wordpress.org/trunk@36920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 19:59:28 +00:00
John Blackbourn ead41790aa Embeds: Add support for `dai.ly` embeds over HTTPS.
Fixes #36189

Built from https://develop.svn.wordpress.org/trunk@36951


git-svn-id: http://core.svn.wordpress.org/trunk@36919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 19:49:27 +00:00
Konstantin Obenland ff3babeb53 Template: Explicitly set `full` as the default custom logo size.
See #33755.

Built from https://develop.svn.wordpress.org/trunk@36950


git-svn-id: http://core.svn.wordpress.org/trunk@36918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 19:03:26 +00:00
Konstantin Obenland 3e82e111e1 Tests: Introduce multisite unit tests.
Makes sure custom logo functions work for other sites within a network.
Fixes a bug in `get_custom_logo()` where the correct logo was returned, but
linked to the wrong site.

H/t ocean90.
See #33755, #36086.

Built from https://develop.svn.wordpress.org/trunk@36949


git-svn-id: http://core.svn.wordpress.org/trunk@36917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 18:57:26 +00:00