Commit Graph

121 Commits

Author SHA1 Message Date
Andrea Fercia 76a6260353 Plugin Install: show the upload form in place rather than sending users to the devoted upload plugin page.
Props Ipstenu, ericlewis, michaelarestad.

Fixes #35429.
Built from https://develop.svn.wordpress.org/trunk@37221


git-svn-id: http://core.svn.wordpress.org/trunk@37187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-16 16:43:27 +00:00
Aaron Jorbin bd7ffca854 Add Nonce to updating wporg_favorites user meta field
Built from https://develop.svn.wordpress.org/trunk@37145


git-svn-id: http://core.svn.wordpress.org/trunk@37112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:36:26 +00:00
Dominik Schilling 30f8c75047 Themes: Bring the device preview from [31195] to the theme install previewer.
Props celloexpressions.
Fixes #36017.
Built from https://develop.svn.wordpress.org/trunk@36858


git-svn-id: http://core.svn.wordpress.org/trunk@36825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-05 22:07:25 +00:00
Dominik Schilling 6f2a56bf3e Themes: After [36546] restore theme search functionality.
* Correct several incorrect uses of `_.union`. Since Underscore 1.7.0 `_.union` supports only arrays and not variadic args.
* Use a namespaced event `themes:update`. Backbone 1.2 added a built in `update` event that triggers after any amount of models are added or removed from a collection.

Props adamsilverstein.
See #34350.
Built from https://develop.svn.wordpress.org/trunk@36580


git-svn-id: http://core.svn.wordpress.org/trunk@36547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 21:21:26 +00:00
Konstantin Obenland c0e903a040 Themes: Clear floated theme cards on Themes page.
Also maintains visual separation for Broken Themes table on searches that
return no results.

See [36171] for `.wp-clearfix`.

Props 5um17, obenland, valendesigns, afercia.
Fixes #26646.


Built from https://develop.svn.wordpress.org/trunk@36270


git-svn-id: http://core.svn.wordpress.org/trunk@36237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-12 17:13:29 +00:00
Konstantin Obenland d5fd177b96 Themes: Avoid changing the count of themes with updates in network admin.
Makes the count bubble selector a little more specific to avoid interfering
with the admin menu, but not too specific for installed theme searches not to
update the bubble.

See [29786], [31495].
Fixes #35332.


Built from https://develop.svn.wordpress.org/trunk@36204


git-svn-id: http://core.svn.wordpress.org/trunk@36171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-06 22:32:28 +00:00
Dominik Schilling a7848ea08b Themes: Hide the favorites form when performing a search.
The search is global and ignores the user setting. Same for filters.

See #34206.
Built from https://develop.svn.wordpress.org/trunk@35647


git-svn-id: http://core.svn.wordpress.org/trunk@35611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 19:50:26 +00:00
Gary Pendergast 84c8243514 Themes: Remove an errant comma from `theme.js`.
Added in [35527].

See #34206.


Built from https://develop.svn.wordpress.org/trunk@35533


git-svn-id: http://core.svn.wordpress.org/trunk@35497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 23:49:26 +00:00
Sergey Biryukov a41e5d0270 Themes: Add a Favorites tab to the Add Themes screen.
You can now browse and install your wordpress.org theme favorites from the theme installer, just like with plugins.

Props swissspidy.
Fixes #34206.
Built from https://develop.svn.wordpress.org/trunk@35527


git-svn-id: http://core.svn.wordpress.org/trunk@35491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:49:26 +00:00
Scott Taylor f89b90a1c9 Theme Installer: toggle `iframe-ready` on the overlay to control the spinner animated GIF and high CPU usage.
Props afercia, adamsilverstein.
Fixes #33322.

Built from https://develop.svn.wordpress.org/trunk@35281


git-svn-id: http://core.svn.wordpress.org/trunk@35247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:36:25 +00:00
Andrea Fercia e074209a3d Accessibility: Improve the headings hierarchy in the Add Themes screen.
Fixes #33819.
Built from https://develop.svn.wordpress.org/trunk@35273


git-svn-id: http://core.svn.wordpress.org/trunk@35239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 22:04:25 +00:00
Sergey Biryukov 5a97ff5206 Bump H3 headings to H2 on Themes screen for better accessibility.
props joehills.
fixes #33560.
Built from https://develop.svn.wordpress.org/trunk@33820


git-svn-id: http://core.svn.wordpress.org/trunk@33788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:51:21 +00:00
Konstantin Obenland 2849e2c5e9 Themes: Open preview when requesting a single theme in the installer.
Props kraftner, obenland.
Fixes #28735.


Built from https://develop.svn.wordpress.org/trunk@33650


git-svn-id: http://core.svn.wordpress.org/trunk@33617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 18:54:27 +00:00
Dominik Schilling 75d6c10b01 Customizer: Use a `<button>` for the collapse sidebar … button.
props afercia.
fixes #32819.
Built from https://develop.svn.wordpress.org/trunk@33153


git-svn-id: http://core.svn.wordpress.org/trunk@33125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 21:22:26 +00:00
Konstantin Obenland 7dc1d06e64 Proper heading for admin screens.
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@32974


git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 15:41:25 +00:00
Andrew Ozz 52db6356a1 Themes screen: remove extra debounce when searching.
Props evansolomon. Fixes #31812.
Built from https://develop.svn.wordpress.org/trunk@31995


git-svn-id: http://core.svn.wordpress.org/trunk@31974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 02:37:32 +00:00
Andrew Ozz 2d36b8ff4a Accessibility improvements for Themes screen: fix keyboard events and callbacks for the Search field, increase trigger timeout a bit, improve Esc. key handling.
Props joedolson, adamsilverstein, afercia, DrewAPicture. Fixes #26600.
Built from https://develop.svn.wordpress.org/trunk@31994


git-svn-id: http://core.svn.wordpress.org/trunk@31973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 02:32:28 +00:00
Scott Taylor 6ffa051689 Replace flagrant instances of `.html('')` with `.empty()`.
Props OriginalEXE, SergeyBiryukov.
Fixes #27034.

Built from https://develop.svn.wordpress.org/trunk@31690


git-svn-id: http://core.svn.wordpress.org/trunk@31671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 19:44:26 +00:00
Sergey Biryukov f7df99549a Themes: Add feedback for screen readers when search results are changed.
props obenland, joedolson.
see #26600.
Built from https://develop.svn.wordpress.org/trunk@31497


git-svn-id: http://core.svn.wordpress.org/trunk@31478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 10:15:26 +00:00
Sergey Biryukov 677d37753f Themes: Update the theme count when searching for installed themes, like we do on Add Themes screen.
props afercia.
see #26600.
Built from https://develop.svn.wordpress.org/trunk@31495


git-svn-id: http://core.svn.wordpress.org/trunk@31476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 09:41:24 +00:00
Sergey Biryukov eedb4857ba Strip HTML tags when searching for installed themes.
props enej, SergeyBiryukov, obenland.
fixes #27561.
Built from https://develop.svn.wordpress.org/trunk@31240


git-svn-id: http://core.svn.wordpress.org/trunk@31221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 20:40:23 +00:00
John Blackbourn 78367f22d5 Abstract the theme browser route paths into attributes so they can be easily overridden.
Fixes #30116
Props matveb

Built from https://develop.svn.wordpress.org/trunk@30508


git-svn-id: http://core.svn.wordpress.org/trunk@30497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-21 17:30:22 +00:00
Dominik Schilling e3e1433e9a Themes: Make it possible to delete broken themes.
props ideag, obenland.
fixes #28165.
Built from https://develop.svn.wordpress.org/trunk@29924


git-svn-id: http://core.svn.wordpress.org/trunk@29676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:46:18 +00:00
Sergey Biryukov 18606f2d2b Use a more specific selector for the count displayed on Add Themes network admin screen.
props mantismamita, nikolov.tmw.
fixes #29421.
Built from https://develop.svn.wordpress.org/trunk@29786


git-svn-id: http://core.svn.wordpress.org/trunk@29558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 13:07:17 +00:00
Helen Hou-Sandí 713857625e Make filter bar CSS less verbose and redundant.
Also removes an unused handler in the theme feature filter.

see #28794.

Built from https://develop.svn.wordpress.org/trunk@29596


git-svn-id: http://core.svn.wordpress.org/trunk@29370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 15:58:15 +00:00
Dominik Schilling fb9084eed3 Disable background page scrolling when modals are open.
props celloexpressions.
fixes #29074.
Built from https://develop.svn.wordpress.org/trunk@29346


git-svn-id: http://core.svn.wordpress.org/trunk@29124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 20:15:15 +00:00
Helen Hou-Sandí c4b561bb6c Use more generic, reusable CSS for the filter bar on Add Themes. This will allow us to reuse the UI in other places, such as the Media Library. props paulwilde. fixes #28794.
Built from https://develop.svn.wordpress.org/trunk@29217


git-svn-id: http://core.svn.wordpress.org/trunk@29001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 03:40:16 +00:00
Sergey Biryukov ff00c377ec Show a "No themes found" message if the search for an installed theme doesn't produce any results.
props gauravmittal1995 for initial patch.
fixes #28587.
Built from https://develop.svn.wordpress.org/trunk@28890


git-svn-id: http://core.svn.wordpress.org/trunk@28689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-29 09:16:14 +00:00
Sergey Biryukov 08332b50cb Avoid duplication of callbacks in theme browser sidebar each time the Next or Previous button is clicked.
This makes the collapse/expand button work as expected.

fixes #28581.
Built from https://develop.svn.wordpress.org/trunk@28868


git-svn-id: http://core.svn.wordpress.org/trunk@28668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-27 16:06:15 +00:00
Sergey Biryukov 1dd9c189e9 Fix copy/paste error in a comment.
see #28581.
Built from https://develop.svn.wordpress.org/trunk@28777


git-svn-id: http://core.svn.wordpress.org/trunk@28590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-19 01:36:14 +00:00
Andrew Nacin f5c0ad0115 Theme Installer: Properly call router navigation.
props gcorne.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@28147


git-svn-id: http://core.svn.wordpress.org/trunk@27978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 03:06:16 +00:00
Andrew Nacin d46037e0b5 Theme Installer: Fixes for browsers without pushState.
props gcorne.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@28141


git-svn-id: http://core.svn.wordpress.org/trunk@27972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 00:04:15 +00:00
Andrew Nacin 9f81d0526e Theme Installer: Revert to proxying through PHP for WordPress.org API requests.
This is to ensure we have valid installation nonces, though we've run into this as a problem previously (see #27639, #27581, #27055).

A tad slower, but we gained speed in 3.9 by simplifying the request made to the API.

props ocean90.
fixes #27798.

Built from https://develop.svn.wordpress.org/trunk@28126


git-svn-id: http://core.svn.wordpress.org/trunk@27957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 01:16:14 +00:00
Andrew Nacin f911d99902 Theme installer: Improve route handling and make ?theme= work.
props matveb.
fixes #27708.

Built from https://develop.svn.wordpress.org/trunk@28123


git-svn-id: http://core.svn.wordpress.org/trunk@27954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 22:06:15 +00:00
Andrew Nacin cd5f8d517c Theme install: Set a timeout and error message for API responses.
props ocean90.
fixes #27708.

Built from https://develop.svn.wordpress.org/trunk@28105


git-svn-id: http://core.svn.wordpress.org/trunk@27936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-13 19:02:14 +00:00
Andrew Ozz cc694bac21 Fix TinyMCE Views in IE8 and 7:
- Add fallback background images for dashicons.
- Fix hiding the clipboard while still allowing the contents to be selected.
- Work around lack of border-box in gallery styles.
(Includes precommit cleanup for theme.js)
Props gcorne, fixes 27546
Built from https://develop.svn.wordpress.org/trunk@28062


git-svn-id: http://core.svn.wordpress.org/trunk@27894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-09 00:58:15 +00:00
Andrew Nacin b631825414 Theme installer keyboard fixes. Updates [28033] and [28036].
props matveb.
see #27521.

Built from https://develop.svn.wordpress.org/trunk@28049


git-svn-id: http://core.svn.wordpress.org/trunk@27879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 16:24:14 +00:00
Dominik Schilling f2d874e3db Theme Installer: Prevent default events for "Upload Theme" and "Browse" buttons.
see #27055.
Built from https://develop.svn.wordpress.org/trunk@28047


git-svn-id: http://core.svn.wordpress.org/trunk@27877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 12:35:18 +00:00
Andrew Ozz fd0ae7e406 Precommit cleanup for theme.js, editor.css amd wpdialogs/plugin.js, See #27055, #26907, #16284
Built from https://develop.svn.wordpress.org/trunk@28045


git-svn-id: http://core.svn.wordpress.org/trunk@27875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 08:29:14 +00:00
Andrew Nacin 9a82e9070e Theme Installer: Show 'Preview' button for installed themes.
props adamsilverstein.
see #27055, see #27708.

Built from https://develop.svn.wordpress.org/trunk@28038


git-svn-id: http://core.svn.wordpress.org/trunk@27868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 04:38:15 +00:00
Andrew Nacin 640d9cb1a1 Theme Installer: Left/right arrow keys in the overlay.
props adamsilverstein.
see #27521.

Built from https://develop.svn.wordpress.org/trunk@28036


git-svn-id: http://core.svn.wordpress.org/trunk@27866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 04:13:30 +00:00
Andrew Nacin 93d2e831cb Theme Installer: Use 'browse' instead of 'sort' for routes.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@28035


git-svn-id: http://core.svn.wordpress.org/trunk@27865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 04:13:16 +00:00
Andrew Nacin 658032c9f9 Theme Installer: Disable prev/next buttons on first/last themes, add Esc handling, use IDs.
props adamsilverstein, DH-Shredder.
fixes #27521.

Built from https://develop.svn.wordpress.org/trunk@28033


git-svn-id: http://core.svn.wordpress.org/trunk@27863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 03:57:15 +00:00
Andrew Nacin 56c1deba7c Theme Installer: Handle currently installed themes, add search route, let prev/next refresh collections.
props matveb.
see #27055. fixes #27695.

Built from https://develop.svn.wordpress.org/trunk@28025


git-svn-id: http://core.svn.wordpress.org/trunk@27855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 23:04:15 +00:00
Andrew Nacin 7cd04f4829 Theme Installer: Separate API from an event handler to avoid issues where a false return value stops the event.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@27963


git-svn-id: http://core.svn.wordpress.org/trunk@27793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 20:46:15 +00:00
Andrew Nacin 9fc1d41ec1 Theme Installer: Use JSONP for api.wordpress.org requests.
fixes #27639.

Built from https://develop.svn.wordpress.org/trunk@27961


git-svn-id: http://core.svn.wordpress.org/trunk@27791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 20:28:14 +00:00
Andrew Nacin e36c1cbf9e Theme Installer: Fix displaying of errors.
props SergeyBiryukov.
fixes #27640.

Built from https://develop.svn.wordpress.org/trunk@27958


git-svn-id: http://core.svn.wordpress.org/trunk@27788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 19:26:14 +00:00
Andrew Ozz d4755ebea3 TinyMCE: add image backgrounds for more and nextpage tags (also jshint fix for theme.js). Fixes #27106
Built from https://develop.svn.wordpress.org/trunk@27944


git-svn-id: http://core.svn.wordpress.org/trunk@27774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 05:23:14 +00:00
Andrew Nacin 0163a95d79 Theme Installer: Fix sorting, counts, keyboard navigation; add prev/next to previews.
props matveb.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@27937


git-svn-id: http://core.svn.wordpress.org/trunk@27767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 23:53:15 +00:00
Andrew Nacin d330c402c8 Theme Installer fixes:
* Better more filters section. props sonjanyc for some mockups.
 * Better handling of no results.
 * Use # for hrefs.

props matveb.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@27896


git-svn-id: http://core.svn.wordpress.org/trunk@27727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-01 22:20:14 +00:00