Sergey Biryukov
3f1186166d
Taxonomy: In `feed_links_extra()` and `get_the_archive_title()`, make sure the queried taxonomy term exists before accessing its properties.
...
Props donmhico, truchot, zaantar.
Fixes #46420 .
Built from https://develop.svn.wordpress.org/trunk@45817
git-svn-id: http://core.svn.wordpress.org/trunk@45628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-16 00:24:54 +00:00
Sergey Biryukov
06d264d032
Coding Standards: In `wlwmanifest_link()`, use concatenation instead of commas for `echo`, for consistency with `rsd_link()` and the rest of core.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45816
git-svn-id: http://core.svn.wordpress.org/trunk@45627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-16 00:21:56 +00:00
Sergey Biryukov
7f7480cb2a
Docs: Add missing description for `$wp_query` and `$wp_the_query` globals.
...
Props mukesh27.
See #45604 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45739
git-svn-id: http://core.svn.wordpress.org/trunk@45550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:59:56 +00:00
Sergey Biryukov
e0311b76c7
Docs: Add missing description for `$wp_locale` global.
...
Props mukesh27.
See #45604 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45737
git-svn-id: http://core.svn.wordpress.org/trunk@45548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:46:55 +00:00
Sergey Biryukov
b1e34ccc1f
Docs: Add missing description for `$wp_rewrite` global.
...
See #45604 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45735
git-svn-id: http://core.svn.wordpress.org/trunk@45546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:19:56 +00:00
Sergey Biryukov
29b072e706
Docs: Add missing description for `$wpdb`, `$wp_db_version`, and `$wp_current_db_version` globals.
...
Props mukesh27, utsav72640, immeet94, SergeyBiryukov.
See #45604 .
Built from https://develop.svn.wordpress.org/trunk@45734
git-svn-id: http://core.svn.wordpress.org/trunk@45545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-04 01:12:56 +00:00
Sergey Biryukov
18bd01985b
Coding Standards: Rename `$r` variable used with `wp_parse_args()` to `$parsed_args` for clarity.
...
Props freewebmentor.
Fixes #45059 .
Built from https://develop.svn.wordpress.org/trunk@45667
git-svn-id: http://core.svn.wordpress.org/trunk@45478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 00:48:58 +00:00
Gary Pendergast
4803fc405e
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `wp-includes`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45590
git-svn-id: http://core.svn.wordpress.org/trunk@45401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 23:42:58 +00:00
Gary Pendergast
55af0f0d0a
Coding Standards: Fix/ignore the `WordPress.NamingConventions.ValidFunctionName` violations.
...
See #47632
Built from https://develop.svn.wordpress.org/trunk@45580
git-svn-id: http://core.svn.wordpress.org/trunk@45391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:01:57 +00:00
Sergey Biryukov
c77e771c84
Date/Time: Replace all instances of `date()` with `gmdate()`.
...
Use of `date()` in core depends on PHP timezone set to UTC and not changed by third party code (which cannot be guaranteed).
`gmdate()` is functionally equivalent, but is not affected by PHP timezone setting: it's always UTC, which is the exact behavior the core needs.
Props nielsdeblaauw, Rarst.
Fixes #46438 . See #44491 .
Built from https://develop.svn.wordpress.org/trunk@45424
git-svn-id: http://core.svn.wordpress.org/trunk@45235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 00:12:54 +00:00
Sergey Biryukov
eecfa3b4ed
Docs: Correct description for `$seplocation` parameter of `wp_title()`.
...
Props mukesh27, vladlu.
Fixes #47370 .
Built from https://develop.svn.wordpress.org/trunk@45406
git-svn-id: http://core.svn.wordpress.org/trunk@45217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 22:59:52 +00:00
Sergey Biryukov
e3bb526606
Login and Registration: Pass the action to `site_url()` in `wp_logout_url()` and `wp_lostpassword_url()`:
...
* Make `site_url` filter in `wp_logout_url()` aware of the `logout` action.
* Make `network_site_url` filter in `wp_lostpassword_url()` aware of the `lostpassword` action.
Props jfarthing84.
Fixes #43407 .
Built from https://develop.svn.wordpress.org/trunk@45398
git-svn-id: http://core.svn.wordpress.org/trunk@45209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:33:52 +00:00
Sergey Biryukov
0cc6547e43
Docs: Adjust `get_post_modified_time` filter DocBlock for consistency with `get_post_time`.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@45380
git-svn-id: http://core.svn.wordpress.org/trunk@45191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 00:41:51 +00:00
Sergey Biryukov
3c16bdc538
Date/Time: Return early from `the_weekday()` and `the_weekday_date()` if we're not in the loop.
...
Restore `$previousweekday` global usage in `the_weekday_date()`, so it could still be used simultaneously with `the_date()`.
Partially reverts [45378].
See #47354 .
Built from https://develop.svn.wordpress.org/trunk@45379
git-svn-id: http://core.svn.wordpress.org/trunk@45190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 00:38:52 +00:00
Sergey Biryukov
ed08643734
Date/Time: Bring some consistency to `the_date()` and `the_weekday_date()`:
...
* Make `the_date()` always apply the the filter and return a value.
* Use `is_new_day()` in `the_weekday_date()`.
* Add a unit test for `the_weekday_date()`.
Fixes #47354 .
Built from https://develop.svn.wordpress.org/trunk@45378
git-svn-id: http://core.svn.wordpress.org/trunk@45189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-22 21:58:50 +00:00
Sergey Biryukov
0b66be9cd7
Docs: Improve documentation for `the_date()` and `the_weekday_date()`.
...
Correct type for `$currentday` and `$previousday` globals.
See #47354 , #47110 .
Built from https://develop.svn.wordpress.org/trunk@45377
git-svn-id: http://core.svn.wordpress.org/trunk@45188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-22 21:48:52 +00:00
Sergey Biryukov
e06afa8a80
Accessibility: In back-compat code added for `get_search_form()` in [44956], when checking the (previously boolean) `$args` value, account for non-strict comparison.
...
Props dkarfa, sachyya-sachet.
Fixes #47177 . See #42057 .
Built from https://develop.svn.wordpress.org/trunk@45340
git-svn-id: http://core.svn.wordpress.org/trunk@45151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 02:22:53 +00:00
Gary Pendergast
a125989772
Emoji: Update Twemoji to version 12.0.0.
...
Props pento, superpoincare.
Fixes #46404 , #46805 .
Built from https://develop.svn.wordpress.org/trunk@45134
git-svn-id: http://core.svn.wordpress.org/trunk@44943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 05:22:51 +00:00
John Blackbourn
94e4da6aec
Themes: Introduce a generic action that's fired when a template part is loaded.
...
This action allows debugging mechanisms to perform greater introspection into which template parts are loaded for any given request. It also exposes the array of candidate template part file names for each template part instance.
Props pcfreak30, jdeeburke
Fixes #41575
Built from https://develop.svn.wordpress.org/trunk@45059
git-svn-id: http://core.svn.wordpress.org/trunk@44868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:13:54 +00:00
Adam Silverstein
418afaa938
Bundled Theme: trigger a new `wp_body_open` action immediately after the opening `body` tag.
...
* Enables inserting (asynchronous) JavaScript right after the opening `body` tag.
* Add a `wp_body_open` helper function that triggers the `wp_body_open` action.
* Call `wp_body_open` in core themes immediately after the opening `body` tag.
Props joostdevalk, valendesigns, nacin, saracup, jorbin, mikeschinkel, jonnybojangles, lgedeon, Willscrlt, Denis-de-Bernardy, lexiqueen, sky_76, welcher, westonruter, ramiy, joyously.
Fixes #12563 .
Built from https://develop.svn.wordpress.org/trunk@45042
git-svn-id: http://core.svn.wordpress.org/trunk@44851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 21:59:52 +00:00
Sergey Biryukov
d4d906c4d5
Themes: Remove `itemprop="url"` from `get_custom_logo()` output.
...
Making incorrect assumptions about microdata used in a theme results in invalid markup.
The attribute can still be added using the `get_custom_logo` or `wp_get_attachment_image_attributes` filter, but it should not be added by default.
Props henry.wright, tfrommen, afercia, markcallen, zodiac1978.
Fixes #37305 .
Built from https://develop.svn.wordpress.org/trunk@45028
git-svn-id: http://core.svn.wordpress.org/trunk@44837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 12:16:53 +00:00
Sergey Biryukov
eb5c0abc00
Accessibility: Add ability to pass an ARIA label for the `<form>` element returned by `get_search_form()`.
...
This allows screen readers to properly announce each search landmark region independently.
Introduce `search_form_args` filter for the arguments used when generating the search form.
Props afercia, williampatton.
Fixes #42057 .
Built from https://develop.svn.wordpress.org/trunk@44956
git-svn-id: http://core.svn.wordpress.org/trunk@44787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-21 09:20:59 +00:00
Sergey Biryukov
2922b9b1b4
Docs: Add a `@since` tag for the new `$selected` parameter of `get_archives_link()`.
...
See #40662 .
Built from https://develop.svn.wordpress.org/trunk@44898
git-svn-id: http://core.svn.wordpress.org/trunk@44729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-14 19:37:51 +00:00
Sergey Biryukov
bba488f2b7
Widgets: Pre-select currently viewed archive in the Archives dropdown widget, for consistency with the Categories widget.
...
Props robobot3000, audrasjb, afercia, Themonic.
Fixes #40662 .
Built from https://develop.svn.wordpress.org/trunk@44897
git-svn-id: http://core.svn.wordpress.org/trunk@44728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-14 19:31:49 +00:00
Sergey Biryukov
5658305b1c
Date/Time: Reduce explicit local `current_time( 'timestamp' )` usage in favor of native PHP functions.
...
Timestamps don't carry any timezone information, using the intended format directly simplifies the logic and makes the code less confusing.
Props Rarst, jdgrimes.
See #40657 .
Built from https://develop.svn.wordpress.org/trunk@44809
git-svn-id: http://core.svn.wordpress.org/trunk@44641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-07 09:12:51 +00:00
desrosj
2d1d80f4c5
Themes: Revert returning the value of `locate_template()` in functions that call it.
...
Because the names of the `get_header()`, `get_footer()`, `get_sidebar()`, and `get_template_part()` functions indicate that a value is returned, some plugins and themes already have `echo get_template_part()` in their codebase. Adding a return value to these functions using the approach in [44678] will cause the two unintended side effects of unexpected content being sent to the browser, and accidental path disclosure.
Reverts [44678].
Props davidbinda.
See #40969 .
Built from https://develop.svn.wordpress.org/trunk@44725
git-svn-id: http://core.svn.wordpress.org/trunk@44556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-06 18:37:51 +00:00
Gary Pendergast
57c293e2d7
Themes: Return the value of `locate_template()` in functions that call it.
...
The `get_header()`, `get_footer()`, `get_sidebar()`, and `get_template_part()` functions all call `locate_template()` as their final action, which returns the name of the template being loaded. Returning this value helps handle problems with templates being loaded.
Props tferry.
Fixes #40969 .
Built from https://develop.svn.wordpress.org/trunk@44678
git-svn-id: http://core.svn.wordpress.org/trunk@44509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-21 22:00:50 +00:00
Gary Pendergast
0ee053758e
Emoji: Upgrade Twemoji to 11.2.0.
...
This upgrade includes general improvements to the style of a variety of emoji.
Full changelog: https://github.com/twitter/twemoji/compare/v11.0.0...v11.2.0
Props desrosj, pento.
Fixes #45133 .
Built from https://develop.svn.wordpress.org/trunk@44644
git-svn-id: http://core.svn.wordpress.org/trunk@44475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-18 01:42:50 +00:00
Gary Pendergast
e96ea8eab6
Docs: Partial revert of [44636].
...
Unrelated changes in `wp-includes/general-template.php` were accidentally committed.
See #44502 .
Built from https://develop.svn.wordpress.org/trunk@44638
git-svn-id: http://core.svn.wordpress.org/trunk@44469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-17 07:57:52 +00:00
Gary Pendergast
e42dddb5ba
Docs: Mark the internal functions as `@private` in `wp-includes/post.php`.
...
Props shamim51.
Fixes #44502 .
Built from https://develop.svn.wordpress.org/trunk@44636
git-svn-id: http://core.svn.wordpress.org/trunk@44467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-17 07:21:51 +00:00
Gary Pendergast
dcdfd7f412
Docs: Fix the last handful of incorrect `@since 5.0.0` docblock tags.
...
Props peterwilsoncc.
Fixes #45543 .
Built from https://develop.svn.wordpress.org/trunk@44635
git-svn-id: http://core.svn.wordpress.org/trunk@44466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-17 06:46:50 +00:00
desrosj
34c4ce3c81
Docs: Update inaccurate `return` descriptions.
...
In the `@return` tag description for `get_post_modified_time()`, `get_the_time()`, and `get_post_time()`, the `$d` parameter is incorrectly referred to as `$id`.
Props behzod.
Fixes #45323 .
Built from https://develop.svn.wordpress.org/trunk@44592
git-svn-id: http://core.svn.wordpress.org/trunk@44423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 02:08:49 +00:00
Gary Pendergast
4f861b9548
Coding Standards: Fix the `Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace` violations.
...
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44566
git-svn-id: http://core.svn.wordpress.org/trunk@44397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 06:40:50 +00:00
Gary Pendergast
6d5cd6842a
Coding Standards: Document intentional `case` block fall-throughs.
...
Fixes `PSR2.ControlStructures.SwitchDeclaration.TerminatingComment` violations.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44565
git-svn-id: http://core.svn.wordpress.org/trunk@44396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 06:26:50 +00:00
desrosj
4818f7e3f7
Administration: Update default fallback color for SVG icons.
...
Currently, when an SVG is used as a menu icon, the color is inconsistent with the other, default dashicons and the contrast ratio does not meet the minimum requirement for accessibility.
This updates the base color for the default `fresh` color scheme to ensure consistency and proper contrast.
Props swift, dschalk.
Fixes #44209 .
Built from https://develop.svn.wordpress.org/trunk@44353
git-svn-id: http://core.svn.wordpress.org/trunk@44183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-20 19:01:48 +00:00
Jeremy Felt
f93e24ca8e
REST API: Render response in user locale with `?_locale=user`.
...
Introduces new `determine_locale()` function for deciding the proper locale to use for a response. Default value is `get_user_locale()` in the admin, and `get_locale()` on the frontend. Because REST API requests are considered frontend requests, `?_locale=user` can be used to render the response in the user's locale.
Also updates `wp-login.php?wp_lang` implementation to benefit from this abstraction.
Merges [43776] from the 5.0 branch to trunk.
Props flixos90, mnelson4, swissspidy, TimothyBlynJacobs.
Fixes #44758 .
Built from https://develop.svn.wordpress.org/trunk@44134
git-svn-id: http://core.svn.wordpress.org/trunk@43964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-14 01:32:39 +00:00
desrosj
cf6e69ee9f
General: Extract the code editor settings from `wp_enqueue_code_editor()`.
...
They're now returned by a new function, `wp_get_code_editor_settings()`, so they can be reused by the block editor.
Props pento.
Merges [43761] to trunk.
Fixes #45127 .
Built from https://develop.svn.wordpress.org/trunk@44121
git-svn-id: http://core.svn.wordpress.org/trunk@43951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-13 22:24:33 +00:00
Peter Wilson
481e5f4b36
Multisite: Improve messaging for previously activated users.
...
Ensure activation of a site is not attempted multiple times and users are shown the correct message if they follow the link a second time.
Built from https://develop.svn.wordpress.org/trunk@44021
git-svn-id: http://core.svn.wordpress.org/trunk@43851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-13 00:23:24 +00:00
Sergey Biryukov
dafee9fae6
Date/Time: Make `get_the_date()` call `get_post_time()` for consistency with `get_the_time()`.
...
Props Rarst.
Fixes #44490 .
Built from https://develop.svn.wordpress.org/trunk@43591
git-svn-id: http://core.svn.wordpress.org/trunk@43420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-30 08:50:24 +00:00
John Blackbourn
47d32decd6
Docs: Correct and improve various inline documentation.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@43582
git-svn-id: http://core.svn.wordpress.org/trunk@43411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-27 14:28:26 +00:00
Gary Pendergast
56c162fbc9
Coding Standards: Upgrade WPCS to 1.0.0
...
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.
This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script.
- Auto-fixable coding standards issues will now cause Travis failures.
Fixes #44600 .
Built from https://develop.svn.wordpress.org/trunk@43571
git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast
0db068da94
Emoji: Update Twemoji to version 11.0.
...
{U+01F9B9}
Props kraftbj,
Fixes #44339 .
Built from https://develop.svn.wordpress.org/trunk@43377
git-svn-id: http://core.svn.wordpress.org/trunk@43205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:42:55 +00:00
Dominik Schilling
31a4369366
Template: Make sure the version string is correctly escaped for use in attributes.
...
Built from https://develop.svn.wordpress.org/trunk@42893
git-svn-id: http://core.svn.wordpress.org/trunk@42723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-03 14:59:31 +00:00
Dominik Schilling
5c291d49de
Pinking shears.
...
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42843
git-svn-id: http://core.svn.wordpress.org/trunk@42673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-18 14:23:33 +00:00
Sergey Biryukov
4848a09b35
I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders.
...
Add missing translator comments in `WP_Theme_Install_List_Table` and `wp_notify_postauthor()`.
Add missing commas in some translator comments.
Fixes #43523 .
Built from https://develop.svn.wordpress.org/trunk@42827
git-svn-id: http://core.svn.wordpress.org/trunk@42657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-11 16:44:34 +00:00
Sergey Biryukov
b0ddd7ca43
Docs: Add description for `register_admin_color_schemes()`.
...
Props terriann, danieltj.
Fixes #42779 .
Built from https://develop.svn.wordpress.org/trunk@42765
git-svn-id: http://core.svn.wordpress.org/trunk@42595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 03:28:31 +00:00
Sergey Biryukov
0a97d79899
Comments: Avoid a PHP notice in `paginate_comments_links()` if `type` argument is set to array.
...
The function is a wrapper for `paginate_links()`, which returns an array if requested.
Props anantajitjg.
Fixes #43299 .
Built from https://develop.svn.wordpress.org/trunk@42703
git-svn-id: http://core.svn.wordpress.org/trunk@42531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-12 21:12:35 +00:00
Drew Jaynes
39ce01d83a
Docs: Fix a typo in the DocBlock description for `get_bloginfo()` illustrating the URL structure for RDF feeds.
...
Props ibachal.
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42660
git-svn-id: http://core.svn.wordpress.org/trunk@42489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-07 19:42:30 +00:00
Sergey Biryukov
76ad62d11e
Code Editor: Add Ctrl/Cmd+F as aliases for persistent search for more intuitive behaviour.
...
Keep Alt+F as well for users who already expect that.
Props Desertsnowman.
See #42586 .
Built from https://develop.svn.wordpress.org/trunk@42625
git-svn-id: http://core.svn.wordpress.org/trunk@42454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-31 22:22:30 +00:00
Sergey Biryukov
ee58ffcbe7
Emoji: Update emoji base URL in `_print_emoji_detection_script()` and `wp_staticize_emoji()`.
...
Props pento.
Fixes #42862 .
Built from https://develop.svn.wordpress.org/trunk@42590
git-svn-id: http://core.svn.wordpress.org/trunk@42419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-24 16:51:30 +00:00