Commit Graph

43 Commits

Author SHA1 Message Date
Scott Taylor 7de0b2b2c8 Upgrade `_WP_List_Table_Compat` to PHP5-style constructor.
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28531


git-svn-id: http://core.svn.wordpress.org/trunk@28357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 17:20:17 +00:00
Scott Taylor 2f513d3320 Fix some `hackificator` odds and ends in `wp-admin`:
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28500


git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:04:16 +00:00
Scott Taylor 31f26dc3ce Remove lingering instances of call time pass-by-reference, limited to instances of `callable` - use `$this` instead of `&$this`.
Props jdgrimes.
See #25160.


Built from https://develop.svn.wordpress.org/trunk@25254


git-svn-id: http://core.svn.wordpress.org/trunk@25222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 16:34:09 +00:00
Andrew Nacin 262ee531cb Only pass the current screen to the list table constructor when we have a screen to work with. This is not the case for admin-ajax requests. fixes #22570.
git-svn-id: http://core.svn.wordpress.org/trunk@22838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 03:39:29 +00:00
Ryan Boren a3cfe28527 Reduce reliance on global variables in the list tables. Allow passing a screen ID to the list tables so that ajax handlers can set the needed screen.
Props nacin
fixes #21871


git-svn-id: http://core.svn.wordpress.org/trunk@21914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 12:43:31 +00:00
nacin 05313daa77 Output themes and theme-install infinite scrolling args in JS, rather than parsing query strings. props DH-Shredder, helenyhou. Make WP_Theme_Install_List_Table extend WP_Themes_List_Table. Doesn't help much yet, but we should be able to dry things up further. see #19815.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 22:09:26 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
nacin 37075f7f71 Remove AJAX from list tables. first pass. see #16262.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-16 21:47:24 +00:00
westi 93465db918 The old methods are good enough in alot of cases where plugins want to extend simply. So un deprecate for now.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-13 23:19:51 +00:00
nacin 041c9a445e Don't double-slash list table include. props wpmuguru, fixes #15904.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-20 09:14:15 +00:00
ryan 847499e531 Pinking shears
git-svn-id: http://svn.automattic.com/wordpress/trunk@16438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 18:47:34 +00:00
westi 5e90c5d1c3 Revert [16171] and [16172] - The class names were fine as they were and the MultiSite classes stand out more with the original naming.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-04 08:07:03 +00:00
scribu 836ec33dca List-table Class Names: Consistency's Revenge. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@16171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-03 21:09:27 +00:00
westi 8b62d686ca Group the Network admin List Tables class mapping seperately so they are easier to pick out. See #14435, #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@16129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-01 09:24:32 +00:00
westi ad92d629d6 The big renaming of the list-table class files.
See #14579

git-svn-id: http://svn.automattic.com/wordpress/trunk@16128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-01 09:19:50 +00:00
westi c66629c140 Split out the list table functions into a seperate file from the base class.
See #14579.

git-svn-id: http://svn.automattic.com/wordpress/trunk@16127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-01 08:56:27 +00:00
nacin f448471380 Shuffle list-table files. First pass. see #14579.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-25 00:12:41 +00:00
scribu 10ec70d244 Use row_actions() in WP_Plugins_Table. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-23 11:22:00 +00:00
nacin 14ccdbec33 Pruning shears.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 19:55:28 +00:00
scribu 26f95f26d7 Fix notices in WP_List_Table::ajax_response(). Props Utkarsh. Fixes #15185
git-svn-id: http://svn.automattic.com/wordpress/trunk@15894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 15:30:35 +00:00
scribu db6cb9d47f Use isset() instead of '@'. Props Utkarsh. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 15:15:50 +00:00
nacin 5e1184aa57 Pinking shears.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-19 07:48:22 +00:00
scribu c3a31b6576 Add WP_List_Table columns before all others. Fixes #15075
git-svn-id: http://svn.automattic.com/wordpress/trunk@15764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-09 09:39:16 +00:00
nacin b7bacd1bf2 s/Wether/Whether/
git-svn-id: http://svn.automattic.com/wordpress/trunk@15756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-08 02:35:06 +00:00
scribu 11642d9baa Remove misplaced code introduced in [15653]. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-24 19:38:21 +00:00
scribu 248b086540 Column headers revamp:
* undeprecate get_column_headers()
	* undeprecate get_hidden_columns()
	* in WP_List_Table, rename get_column_headers() to get_column_info()
	* remove $taxonomy argument from single_row()
	* merge manage_columns_prefs() into screen_meta()
Fixes #14952. Fixes #14776.


git-svn-id: http://svn.automattic.com/wordpress/trunk@15653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-24 13:35:06 +00:00
scribu e975e650cf Introduce WP_List_Table::current_action() and use throughout admin list screens. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-22 00:10:39 +00:00
scribu a927a1665c Extra single_row_columns() out of single_row() for increased flexibility. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-18 17:21:32 +00:00
scribu 93d4b0c223 Add default display_rows() and single_row() methods to WP_List_Table. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-16 20:07:39 +00:00
scribu 9a9e872597 introduce WP_List_Table::views(). See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-05 21:26:27 +00:00
scribu f24da67b4b Introduce WP_List_Table::row_actions(). See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-05 16:53:59 +00:00
scribu c02669236e Introduce WP_List_Table::get_items_per_page(). See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-05 15:15:46 +00:00
scribu b9955d5a66 use unaltered in the get_list_table_* filter
git-svn-id: http://svn.automattic.com/wordpress/trunk@15535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-26 11:02:51 +00:00
scribu ab4fc9bba9 Rename admin-table.js to list-table.js
git-svn-id: http://svn.automattic.com/wordpress/trunk@15530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-25 01:59:13 +00:00
scribu 75219a5110 Introduce get_list_table(). See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-25 00:51:44 +00:00
scribu 65206ec0d7 Make deprecated functions work. See #14651
git-svn-id: http://svn.automattic.com/wordpress/trunk@15517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-21 18:08:42 +00:00
scribu 1ea0bc3486 Remove dead code from WP_List_Table::print_column_headers()
git-svn-id: http://svn.automattic.com/wordpress/trunk@15516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-21 16:56:24 +00:00
scribu d61363d755 Show dropdowns filter even when JS is disabled. Props blepoxp. Fixes #14150
git-svn-id: http://svn.automattic.com/wordpress/trunk@15511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-19 20:10:28 +00:00
scribu 071746cc11 Fix the Trash quickling in edit-comments.php. See #14637
git-svn-id: http://svn.automattic.com/wordpress/trunk@15508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-18 22:26:22 +00:00
scribu 27b022bd38 correct post id in comments_bubble()
git-svn-id: http://svn.automattic.com/wordpress/trunk@15505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-18 16:41:58 +00:00
scribu eec59d35bb introduce WP_List_Table::comments_bubble(); revert to edit-comments.php?p=123. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-18 16:30:27 +00:00
scribu c6056827ed Introduce WP_List_Table::check_permissions() and WP_List_Table::prepare_items(). Fixes #14596; See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-12 23:21:05 +00:00
scribu 020ce73746 Ajaxify list-type screens in the admin. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-11 21:54:51 +00:00