Commit Graph

17360 Commits

Author SHA1 Message Date
Konstantin Obenland 81df9bffc5 Use https for Google API external libraries.
Google recommends it and users are more likely to have the https version cached in their browser already.

Props rommelxcastro.
Fixes #32552.


Built from https://develop.svn.wordpress.org/trunk@32843


git-svn-id: http://core.svn.wordpress.org/trunk@32814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 15:51:26 +00:00
Konstantin Obenland d872f38c31 Show the posts meta box by default in Appearance > Menus.
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.

Props bcole808.
Fixes #32440.


Built from https://develop.svn.wordpress.org/trunk@32842


git-svn-id: http://core.svn.wordpress.org/trunk@32813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 15:04:26 +00:00
Konstantin Obenland f7f14ae558 More consistent spacing around the excerpt textarea.
Props paulwilde.
Fixes #32242.


Built from https://develop.svn.wordpress.org/trunk@32841


git-svn-id: http://core.svn.wordpress.org/trunk@32812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 14:19:25 +00:00
Boone Gorges dd3b146546 Use `assertFalse()` rather than `assertNull()` in `Tests_WP_Customize_Setting::test_is_current_blog_previewed()`.
`is_current_blog_previewed()` returns a boolean.

See #31428.
Built from https://develop.svn.wordpress.org/trunk@32840


git-svn-id: http://core.svn.wordpress.org/trunk@32811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 14:08:25 +00:00
Boone Gorges 92123c15bf Make sure `$_SERVER['SERVER_NAME']` is set whenever `wp_mail()` is called in PHPUnit tests.
This eliminates PHP notices when `wp_mail()` needs to determine its own From header.

See [25381] for a previous fix, which focused only on the mail-specific tests.

Fixes #32702.
Built from https://develop.svn.wordpress.org/trunk@32839


git-svn-id: http://core.svn.wordpress.org/trunk@32810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 13:53:25 +00:00
Boone Gorges 2e5e0bdc78 When updating a user, only send email-change notification if email address is passed.
The notification, introduced in [32380], was firing incorrectly (and throwing
a PHP notice) when `wp_update_user()` was called without including 'user_email'
in the update data.

Props imath.
Fixes #32684. See #32430.
Built from https://develop.svn.wordpress.org/trunk@32838


git-svn-id: http://core.svn.wordpress.org/trunk@32809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 13:30:26 +00:00
Boone Gorges 6105fca015 Add filters to `wp_unique_term_slug()`.
This changeset adds two new filters:
* 'wp_unique_term_slug_is_bad_slug' lets developers control whether a test slug needs to be made unique, before the queries required to build a suffix are performed.
* 'wp_unique_term_slug' filters the output of the function.

These changes introduce parity with the filters in `wp_unique_post_slug()`.

Props coffee2code, bolo1988, boonebgorges.
Fixes #20783.
Built from https://develop.svn.wordpress.org/trunk@32837


git-svn-id: http://core.svn.wordpress.org/trunk@32808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 13:20:26 +00:00
Ella Iseulde Van Dorpe ecec2b61cf TinyMCE: wptextpattern: escape should undo
Props azaozz.
See #31441.

Built from https://develop.svn.wordpress.org/trunk@32836


git-svn-id: http://core.svn.wordpress.org/trunk@32807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 12:59:28 +00:00
Konstantin Obenland 437b1c2b6a Revert [32834].
It's not ready yet and was a product of misusing vim.

See #30729.


Built from https://develop.svn.wordpress.org/trunk@32835


git-svn-id: http://core.svn.wordpress.org/trunk@32806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 12:27:25 +00:00
Konstantin Obenland 598f4cc4ca Emphasise previewing new themes
Built from https://develop.svn.wordpress.org/trunk@32834


git-svn-id: http://core.svn.wordpress.org/trunk@32805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 12:24:27 +00:00
Konstantin Obenland c9e1e2be9b Make posts in the 'Most recent' tab of post type meta boxes filterable.
Provides parity with the 'View All' tab of post type meta boxes in Appearance > Menus.

Props jpyper, chriscct7.
Fixes #19365.


Built from https://develop.svn.wordpress.org/trunk@32833


git-svn-id: http://core.svn.wordpress.org/trunk@32804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:35:28 +00:00
Ella Iseulde Van Dorpe 8b6ff40038 TinyMCE: wptextpattern: fix issue that removes content
* If the resulting text node is empty, don't remove all the content from the paragraph.
* If there's an empty text node at the start of the paragraph, ignore it and consider the next node to be the start.

See #31441.

Built from https://develop.svn.wordpress.org/trunk@32832


git-svn-id: http://core.svn.wordpress.org/trunk@32803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:34:25 +00:00
Ella Iseulde Van Dorpe 1c586b9390 TinyMCE: show inline toolbar after scroll/resize
Also:

* Reduce the amount of callbacks.
* Move everything under `preinit` (but prepend to the callback). The API shouldn't be availbale earlier, and some UI is not available yet, neither is `editor.dom`.
* Hide the toolbar if the target is out of view.

See #32604.


Built from https://develop.svn.wordpress.org/trunk@32831


git-svn-id: http://core.svn.wordpress.org/trunk@32802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:10:25 +00:00
Konstantin Obenland 326c106159 Recommend a user updates keys/salts in `maint/repair.php`.
Since they are already going into `wp-config.php`, we should also encourage
them to update their unique phrases for keys and salts, assuming they do not
have a complete set of 8 unique ones already.

Props nacin, chriscct7.
Fixes #20779.


Built from https://develop.svn.wordpress.org/trunk@32830


git-svn-id: http://core.svn.wordpress.org/trunk@32801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:07:25 +00:00
John Blackbourn 768d8507e5 Correct a typo in the inline docs for `add_action()`.
Props nabil_kadimi, swissspidy
Fixes #32697

Built from https://develop.svn.wordpress.org/trunk@32829


git-svn-id: http://core.svn.wordpress.org/trunk@32800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 08:37:25 +00:00
Andrew Ozz bc2630e099 Press This: Check the embeds list against all of the oembed providers.
Props stephdau. Fixes #32069.
Built from https://develop.svn.wordpress.org/trunk@32828


git-svn-id: http://core.svn.wordpress.org/trunk@32799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 00:12:26 +00:00
Andrew Ozz b77a3a33f5 Press This: show error message when the user is attempting to add a category that already exists.
Fixes #32339.
Built from https://develop.svn.wordpress.org/trunk@32827


git-svn-id: http://core.svn.wordpress.org/trunk@32798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 23:13:26 +00:00
John Blackbourn b14c6bea0b Correct a unit test name.
See #21212

Built from https://develop.svn.wordpress.org/trunk@32826


git-svn-id: http://core.svn.wordpress.org/trunk@32797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 23:10:25 +00:00
Dominik Schilling 6e44f060ee Customizer: Remove an `overflow: hidden` declaration to prevent cutting off the left and right edge focus style of the "Add a Menu" input field.
props paulwilde.
fixes #32680.
Built from https://develop.svn.wordpress.org/trunk@32825


git-svn-id: http://core.svn.wordpress.org/trunk@32796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:43:26 +00:00
Dominik Schilling 5864a7ad44 Customizer: Fix keyboard events for the menu items search field.
Replace the `change` event with `keyup`, see https://core.trac.wordpress.org/ticket/26600#comment:59 for background.

props tywayne.
fixes #32677.
Built from https://develop.svn.wordpress.org/trunk@32824


git-svn-id: http://core.svn.wordpress.org/trunk@32795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:37:27 +00:00
Dominik Schilling 504db9233b Customizer: Revert the blue on hover color which was introduced in [32649].
Blue is meant to be the primary action which isn't the case in this context. Colors need to be revised in #29158. 

see #31336.
Built from https://develop.svn.wordpress.org/trunk@32823


git-svn-id: http://core.svn.wordpress.org/trunk@32794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:07:27 +00:00
Dominik Schilling 2d2445516c Customizer: Decode HTML entities of panel/section titles.
Titles are now passed into Underscore templates but HTML-escaped, see #30737.

fixes #32670.
Built from https://develop.svn.wordpress.org/trunk@32822


git-svn-id: http://core.svn.wordpress.org/trunk@32793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 19:48:25 +00:00
Dominik Schilling a1f7f4fe17 Customizer: Replace usage of `calc()` with `box-sizing: border-box`.
IE8 doesn't support `calc()`.

props afercia.
see #31336.
fixes #32664.
Built from https://develop.svn.wordpress.org/trunk@32821


git-svn-id: http://core.svn.wordpress.org/trunk@32792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 19:35:28 +00:00
Mark Jaquith 814865ea9e Send emails when a user's email address or password is changed.
* In case of email change, email goes to the OLD address
* Prevents against issues where an account is compromised (say via cookie interception) and then the attacker silently takes over ownership via pw/email changes — now there will at least be a record that something is up

fixes #32430
props RMarks, MikeHansenMe, tharsheblows, obenland
Built from https://develop.svn.wordpress.org/trunk@32820


git-svn-id: http://core.svn.wordpress.org/trunk@32791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 19:31:27 +00:00
Boone Gorges f62bf61b2c Bail out of 4.3 term splitting routine when no shared terms are found.
Props dd32.
See #30261.
Built from https://develop.svn.wordpress.org/trunk@32819


git-svn-id: http://core.svn.wordpress.org/trunk@32790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 11:40:24 +00:00
Ella Iseulde Van Dorpe 8fba763f37 TinyMCE: show active inline toolbar after focus
This makes sure that e.g. the image toolbar shows up again after closing the media library modal.

See #32604.

Built from https://develop.svn.wordpress.org/trunk@32818


git-svn-id: http://core.svn.wordpress.org/trunk@32789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 07:08:25 +00:00
Ella Iseulde Van Dorpe c465640107 TinyMCE: wplink: don't link a URL with a pasted URL
Fixes #32357.


Built from https://develop.svn.wordpress.org/trunk@32817


git-svn-id: http://core.svn.wordpress.org/trunk@32788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 05:05:24 +00:00
Ella Iseulde Van Dorpe a31d79196d TinyMCE: improve reposition method inline toolbars
* Make sure the toolbar does not overlap the target, unless it is higher than half the visible editor area's height.
* Allow the toolbar to have the preference to position itself above or below the target.
* Cache DOM lookups.
* Simplify the logic and fix various positioning issues.

See #32604.


Built from https://develop.svn.wordpress.org/trunk@32816


git-svn-id: http://core.svn.wordpress.org/trunk@32787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 04:42:25 +00:00
Ella Iseulde Van Dorpe 1a4c6ad45d JSHint after [32806]
See #32576.

Built from https://develop.svn.wordpress.org/trunk@32815


git-svn-id: http://core.svn.wordpress.org/trunk@32786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 04:15:26 +00:00
Boone Gorges 290044ef15 Split all shared taxonomy terms on upgrade to 4.3.
Dear Shared Terms, Welcome to Splitsville. Population: You.

See #30261.
Built from https://develop.svn.wordpress.org/trunk@32814


git-svn-id: http://core.svn.wordpress.org/trunk@32785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 01:53:26 +00:00
Boone Gorges cf7e00ed9f Performance enhancements for `_split_shared_term()`.
* Introduce a `$record` parameter, which defaults to true. When set to false, `_split_shared_term()` will not keep a record of split term data in wp_options. The judicious use of this flag can greatly improve performance when processing shared terms in batches.
* Allow term/tt objects to be passed to the `$term_id` and `$term_taxonomy_id` parameters. This has the potential to save database queries when the objects are already available.

See #30261.
Built from https://develop.svn.wordpress.org/trunk@32813


git-svn-id: http://core.svn.wordpress.org/trunk@32784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 01:48:28 +00:00
John Blackbourn 2b699639bd Comprehensive unit tests for every available capability, and for all roles.
Fixes #32394.

Built from https://develop.svn.wordpress.org/trunk@32812


git-svn-id: http://core.svn.wordpress.org/trunk@32783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 00:05:26 +00:00
John Blackbourn 4ad1dc2a1b Ensure the `create_users` capability check checks the super admin status of the user in question, rather than the current user.
Built from https://develop.svn.wordpress.org/trunk@32811


git-svn-id: http://core.svn.wordpress.org/trunk@32782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 00:03:27 +00:00
Drew Jaynes 25829e05fa Add line-wrapping to a long return description because readability in documentation is important.
See [32797]. See #32421.

Built from https://develop.svn.wordpress.org/trunk@32810


git-svn-id: http://core.svn.wordpress.org/trunk@32781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 23:18:25 +00:00
Andrew Ozz 82fcdec660 Editor: do not reuse the preview tab when the user has navigated away.
See #32588.
Built from https://develop.svn.wordpress.org/trunk@32809


git-svn-id: http://core.svn.wordpress.org/trunk@32780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 23:13:26 +00:00
Dominik Schilling ac33d71623 Fix a typo in [32806].
see #32576.
Built from https://develop.svn.wordpress.org/trunk@32808


git-svn-id: http://core.svn.wordpress.org/trunk@32779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 23:09:25 +00:00
Dominik Schilling b2b3f1c3ff Twenty Fifteen: Wrap navigation helpers into a function so it can be called on a refresh event of the Customize Preview.
props westonruter.
see #32576.
Built from https://develop.svn.wordpress.org/trunk@32807


git-svn-id: http://core.svn.wordpress.org/trunk@32778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 22:18:24 +00:00
Dominik Schilling 62e3a0c15c Add menu management to the Customizer.
This brings in the Menu Customizer plugin: https://wordpress.org/plugins/menu-customizer/.

props celloexpressions, westonruter, valendesigns, voldemortensen, ocean90, adamsilverstein, kucrut, jorbin, designsimply, afercia, davidakennedy, obenland.
see #32576.
Built from https://develop.svn.wordpress.org/trunk@32806


git-svn-id: http://core.svn.wordpress.org/trunk@32777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 22:08:26 +00:00
Helen Hou-Sandí d159cc2272 Media list table: Avoid PHP notices by using the proper variables.
Also visually tightens up the row actions.

props tyxla.
fixes #32657. see #29881.

Built from https://develop.svn.wordpress.org/trunk@32805


git-svn-id: http://core.svn.wordpress.org/trunk@32776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 21:33:25 +00:00
Scott Taylor a1bd091d65 In `get_attachment_template()`, pass an array of templates to `get_query_template( 'attachment', $templates )`, instead of bailing on the first found template.
Props willnorris, jfarthing84, SergeyBiryukov, DrewAPicture, wonderboymusic.
Fixes #15337.

Built from https://develop.svn.wordpress.org/trunk@32804


git-svn-id: http://core.svn.wordpress.org/trunk@32775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:50:26 +00:00
Scott Taylor 0cc29d8bb7 In `wp_nav_menu()`, ensure that the `$menu` arg is populated when passed to filters.
Props greuben, chriscct7.
Fixes #16594.

Built from https://develop.svn.wordpress.org/trunk@32803


git-svn-id: http://core.svn.wordpress.org/trunk@32774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:33:25 +00:00
Scott Taylor 6148f3cd41 Add a class method to `wpLink`, `buildHtml()`. This will allows devs to duck-punch the implementation.
Props martinsachse.
Fixes #32180.

Built from https://develop.svn.wordpress.org/trunk@32802


git-svn-id: http://core.svn.wordpress.org/trunk@32773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:20:26 +00:00
Scott Taylor 45d5037a10 Avoid using HTML in translation strings in `edit-form-comment.php`.
Fixes #31847.

Built from https://develop.svn.wordpress.org/trunk@32801


git-svn-id: http://core.svn.wordpress.org/trunk@32772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:08:24 +00:00
Scott Taylor 5c6b63d3a6 `if` is a statment, not a function.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32800


git-svn-id: http://core.svn.wordpress.org/trunk@32771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:01:25 +00:00
Scott Taylor 5e14470894 Avoid using `<code>` in a translation string.
Props ramiy.
Fixes #31848.

Built from https://develop.svn.wordpress.org/trunk@32799


git-svn-id: http://core.svn.wordpress.org/trunk@32770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 19:53:27 +00:00
Helen Hou-Sandí a49c192f37 Media list table: Restore row actions.
see #29881, #32657.

Built from https://develop.svn.wordpress.org/trunk@32798


git-svn-id: http://core.svn.wordpress.org/trunk@32769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 19:47:24 +00:00
Scott Taylor efbb8fa4e5 Document the default list of allowed protocols in the doc block for `wp_allowed_protocols()` and cross-reference in `esc_url()` and the `kses_allowed_protocols` filter.
Props GunGeekATX.
Fixes #32421.

Built from https://develop.svn.wordpress.org/trunk@32797


git-svn-id: http://core.svn.wordpress.org/trunk@32768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 19:45:26 +00:00
Helen Hou-Sandí 457456ef25 Comments: Better markup for the edit screen.
Previously there were no labels, and since labels can't contain links and the links were of dubious value, we've removed those.

props afercia, DrewAPicture.
fixes #31326.

Built from https://develop.svn.wordpress.org/trunk@32796


git-svn-id: http://core.svn.wordpress.org/trunk@32767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 18:54:26 +00:00
Ella Iseulde Van Dorpe dd0bff051a TinyMCE: wptextpattern: Add blockquote and headings
As discussed in the editor meeting 9 June.
We should re-evaluate these additions towards the end of the release.

See #31441.

Built from https://develop.svn.wordpress.org/trunk@32795


git-svn-id: http://core.svn.wordpress.org/trunk@32766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 13:52:25 +00:00
Boone Gorges 0768626735 Clean up uploaded file after `test_media_handle_upload_sets_post_excerpt()`.
Props McGuive7.
Fixes #32534.
Built from https://develop.svn.wordpress.org/trunk@32794


git-svn-id: http://core.svn.wordpress.org/trunk@32765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 12:38:27 +00:00
Dion Hulse 2b2368d68f Add a filter to wp_safe_redirect() for the fallback URL.
Props anubisthejackle. Fixes #22612

Built from https://develop.svn.wordpress.org/trunk@32793


git-svn-id: http://core.svn.wordpress.org/trunk@32764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 05:26:26 +00:00
Boone Gorges 66c1d75c1c Tag/category conversion link on edit-tags.php should point to specific importer page when cat2tag plugin is active.
Props solarissmoke, c3mdigital.
Fixes #16369.
Built from https://develop.svn.wordpress.org/trunk@32792


git-svn-id: http://core.svn.wordpress.org/trunk@32763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 04:30:26 +00:00
Scott Taylor 362704ab9a `sanitize_option()` needs to handle `WP_Error`. DRY the conditional calls to `add_settings_error()`.
Props chriscct7 for an initial patch.
Fixes #32350.

Built from https://develop.svn.wordpress.org/trunk@32791


git-svn-id: http://core.svn.wordpress.org/trunk@32762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 01:29:27 +00:00
Scott Taylor 8df67cb188 Add a note to `wptexturize()` docs.
Props miqrogroove.
Fixes #32521.

Built from https://develop.svn.wordpress.org/trunk@32790


git-svn-id: http://core.svn.wordpress.org/trunk@32761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 00:57:24 +00:00
Scott Taylor 2043805da4 Improve the consistency of punctuation matching in `wptexturize()`.
Adds unit tests.

Props miqrogroove.
Fixes #31886.

Built from https://develop.svn.wordpress.org/trunk@32789


git-svn-id: http://core.svn.wordpress.org/trunk@32760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 00:50:25 +00:00
Scott Taylor 7db2c06ab6 Allow 'Cockney' filter to be translated.
Updates unit test.

Props miqrogroove.
Fixes #31953.

Built from https://develop.svn.wordpress.org/trunk@32788


git-svn-id: http://core.svn.wordpress.org/trunk@32759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 00:46:24 +00:00
Scott Taylor b126a0144f In the `youtube_embed_url` embed handler, make `embed` a non-capturing group that alternately matches for `v` - YouTube supports both URL paths.
Add unit test cases.

Props dmchale for some patch work.
Fixes #32161.

Built from https://develop.svn.wordpress.org/trunk@32787


git-svn-id: http://core.svn.wordpress.org/trunk@32758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 00:35:25 +00:00
Scott Taylor d71d2c062e In `get_comment_reply_link()`, when generating the reply link, add the `replytocom` query arg to the result of `get_permalink()` on the current `$post`, instead of the current global request URI.
Props nazmul.hossain.nihal.
Fixes #31333.

Built from https://develop.svn.wordpress.org/trunk@32786


git-svn-id: http://core.svn.wordpress.org/trunk@32757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 00:19:25 +00:00
Scott Taylor b4f536eabe Set `$_SERVER['REQUEST_METHOD']` for unit tests.
Props johnbillion.
Fixes #32636.

Built from https://develop.svn.wordpress.org/trunk@32785


git-svn-id: http://core.svn.wordpress.org/trunk@32756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 00:04:29 +00:00
Dion Hulse faf6383ebd Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key.
Props mordauk. Fixes #31784

Built from https://develop.svn.wordpress.org/trunk@32784


git-svn-id: http://core.svn.wordpress.org/trunk@32755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 06:26:25 +00:00
Dion Hulse c6bb637f89 Updats: Add a filter for the options params for the update being performed.
Props nofearinc. Fixes #27754

Built from https://develop.svn.wordpress.org/trunk@32783


git-svn-id: http://core.svn.wordpress.org/trunk@32754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 05:35:26 +00:00
Dion Hulse c726f72ea4 Updates: Allow the update row to include the active border styling post-ajax update.
Props TobiasBg. Fixes #32129

Built from https://develop.svn.wordpress.org/trunk@32782


git-svn-id: http://core.svn.wordpress.org/trunk@32753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 05:13:25 +00:00
Dion Hulse b881a541bb Updates: Remove redundant title tags from update outputs.
Props afercia. Fixes #32530

Built from https://develop.svn.wordpress.org/trunk@32781


git-svn-id: http://core.svn.wordpress.org/trunk@32752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 05:09:25 +00:00
Dion Hulse 629545aaf5 Updates: When an update fails (and it's not during the credential form) allow further updates to continue, with the assumption that the error only affects a single plugin.
Props magicroundabout. Fixes #32110 for trunk.

Built from https://develop.svn.wordpress.org/trunk@32780


git-svn-id: http://core.svn.wordpress.org/trunk@32751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 04:28:25 +00:00
Dion Hulse 6eef8a8ff2 Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners.
Fixes #32435, #32473

Built from https://develop.svn.wordpress.org/trunk@32779


git-svn-id: http://core.svn.wordpress.org/trunk@32750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:48:28 +00:00
Dion Hulse 0eb8bfc464 Updates: When a error occurs during the connection phase, pass the error message back as the ajax failure message.
See #32435

Built from https://develop.svn.wordpress.org/trunk@32778


git-svn-id: http://core.svn.wordpress.org/trunk@32749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:32:27 +00:00
Dion Hulse 04325cd834 Updates: Better handling when the credential form is long (such as when SSH is active). This adds scrolling to the dialogue, and hides the SSH-specific fields when not using the SSH handler.
See #32435

Built from https://develop.svn.wordpress.org/trunk@32777


git-svn-id: http://core.svn.wordpress.org/trunk@32748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:20:28 +00:00
Dion Hulse a4b4918377 Updates: When a connection failure occurs, and no credential form is present client side, allow it to fall through to the normal failure handlers.
See #32435

Built from https://develop.svn.wordpress.org/trunk@32776


git-svn-id: http://core.svn.wordpress.org/trunk@32747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 02:48:28 +00:00
Jeremy Felt 947eef9468 Introduce get_main_network_id()
Expand on the logic previously available as part of `is_main_network()` and provide a way to obtain the ID of the main network. Most useful in multi-network configurations.

Props @johnjamesjacoby for the initial patch.
Fixes #30294.

Built from https://develop.svn.wordpress.org/trunk@32775


git-svn-id: http://core.svn.wordpress.org/trunk@32746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 21:45:25 +00:00
Helen Hou-Sandí e3ae4f9d7e Multisite: Use an email input for new user email address.
We also need to set novalidate on the form due to some browsers rejecting valid email addresses containing an IDN. We should holistically investigate whether this is still an issue in any major browsers at some point.

props earnjam.
fixes #32643.

Built from https://develop.svn.wordpress.org/trunk@32774


git-svn-id: http://core.svn.wordpress.org/trunk@32745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 20:41:27 +00:00
Andrew Nacin a0f4e8e086 Media: Support title fields to be removed from attachments.
props antpb.
fixes #23932.

Built from https://develop.svn.wordpress.org/trunk@32773


git-svn-id: http://core.svn.wordpress.org/trunk@32744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 20:33:26 +00:00
Helen Hou-Sandí ed46512c20 Reduce form spacing on narrower screens.
props liljimmi.
fixes #32489, #32484.

Built from https://develop.svn.wordpress.org/trunk@32772


git-svn-id: http://core.svn.wordpress.org/trunk@32743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 20:12:26 +00:00
Andrew Nacin 748b3763cb Add add_user_role and remove_user_role actions for WP_User::add_role() and remove_role().
props shooper.
fixes #32060.

Built from https://develop.svn.wordpress.org/trunk@32771


git-svn-id: http://core.svn.wordpress.org/trunk@32742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 19:26:25 +00:00
Aaron Jorbin 38d59c0828 Improve dbDelta unit tests
Add new tests for more parts of dbDelta.  This was cleaned up and prepared for commit at #wcphilly contributor day.

Props jdgrimes, tryon, jtsternberg, ebinnion, JPry, avnarun, kevkoeh, jorbin, salcode.
Fixes #29020.


Built from https://develop.svn.wordpress.org/trunk@32770


git-svn-id: http://core.svn.wordpress.org/trunk@32741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 19:23:26 +00:00
Andrew Nacin 7080c8e24b Update comment caches in WP_Comment_Query, rather than comments template.
props dd32.
fixes #31081.

Built from https://develop.svn.wordpress.org/trunk@32769


git-svn-id: http://core.svn.wordpress.org/trunk@32740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 19:21:25 +00:00
Andrew Nacin e7f618d86e Tweak the first post/page content to get with the times.
props chriscct7.
fixes #22474.

Built from https://develop.svn.wordpress.org/trunk@32768


git-svn-id: http://core.svn.wordpress.org/trunk@32739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 18:56:50 +00:00
Aaron Jorbin 36e593a46c Restore [32732] as it wasn't the actual cause of test failures as those failures where fixed separately.
See #32732


Built from https://develop.svn.wordpress.org/trunk@32767


git-svn-id: http://core.svn.wordpress.org/trunk@32738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 18:56:26 +00:00
Aaron Jorbin 3d2f8542ac Revert [32732] since it is causing the tests to break
See #32732


Built from https://develop.svn.wordpress.org/trunk@32766


git-svn-id: http://core.svn.wordpress.org/trunk@32737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 18:43:25 +00:00
Aaron Jorbin cbb6f91a29 Improve lastBuildDate timestamp in rss feeds
RSS feed timestamps should reflect the actual timestamps for those RSS feeds rather than the generic timestamp for all posts and all comments. 

Props stevenkword.
Fixes #4575.



Built from https://develop.svn.wordpress.org/trunk@32765


git-svn-id: http://core.svn.wordpress.org/trunk@32736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 18:37:24 +00:00
Dominik Schilling df11970e18 Nav menus: Introduce a `wp_get_nav_menu_object` filter in `wp_get_nav_menu_object()` to filter the retrieved nav_menu term.
props westonruter.
fixes #32629.
Built from https://develop.svn.wordpress.org/trunk@32764


git-svn-id: http://core.svn.wordpress.org/trunk@32735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 17:37:25 +00:00
Dominik Schilling 8dcd236ba3 Nav menus: Reset the `fallback_cb` default argument in `wp_nav_menu` in case of a Customizer preview.
props westonruter.
see #32576.
Built from https://develop.svn.wordpress.org/trunk@32763


git-svn-id: http://core.svn.wordpress.org/trunk@32734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 17:14:24 +00:00
Dominik Schilling 55f3b68c75 Nav Menus: Update `wp_setup_nav_menu_item()` to stop overriding empty properties from supplied `$menu_item`.
Update docs for `WP_Post` constructor to indicate that `WP_Post|object` can be the supplied param, as opposed to just `WP_Post`.

props westonruter.
fixes #32632.
Built from https://develop.svn.wordpress.org/trunk@32762


git-svn-id: http://core.svn.wordpress.org/trunk@32733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 10:53:25 +00:00
Jeremy Felt 8daec04557 Remove a now unused `switch_to_blog()` and `restore_current_blog()` in site-info.php
Now that we decide when to automatically update `home` and `siteurl`, we no longer need to switch to the site while displaying the form output.

See #32503.

Built from https://develop.svn.wordpress.org/trunk@32761


git-svn-id: http://core.svn.wordpress.org/trunk@32732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 08:23:26 +00:00
Jeremy Felt da35c25fb7 Remove the "Update siteurl and home as well" checkbox when editing a site
Rather than provide a checkbox to update the `siteurl` and `home` options, we can make an educated decision based on the current state. If the home and/or siteurl domain and path match the existing domain and path of the site, then we update with the new information.

Also, while scheme is not stored in `wp_blogs` along with a site, the scheme of the `home` and `siteurl` options can now be modified via the Site URL setting in `site-info.php` when the `home` and/or `siteurl` options match the existing domain.

Props @hugobaeta, @earnjam, @jeremyfelt.
Fixes #32503, see #22383.

Built from https://develop.svn.wordpress.org/trunk@32760


git-svn-id: http://core.svn.wordpress.org/trunk@32731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 07:52:24 +00:00
Jeremy Felt 186c37a325 Capture domain and path when editing sites on a subdomain network
When a network is configured as subdomain, allow for the input of arbitrary domain and path combinations when editing a site rather than just the domain.

This takes a step or two toward #32503.

Props @scribu, @ericlewis, @jeremyfelt.
See #22383.

Built from https://develop.svn.wordpress.org/trunk@32759


git-svn-id: http://core.svn.wordpress.org/trunk@32730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 07:09:25 +00:00
Jeremy Felt f996e163b8 Improve code readability in site-info.php
In advance of some other work here, clean up some braces and spaces.

See #22383.

Built from https://develop.svn.wordpress.org/trunk@32758


git-svn-id: http://core.svn.wordpress.org/trunk@32729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 05:01:28 +00:00
Scott Taylor 4348074f3a In `WP_MS_Users_List_Table::display_rows()`:
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - there is a small amount of logic that requires overriding, otherwise it is largely the same as the parent method

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32757


git-svn-id: http://core.svn.wordpress.org/trunk@32728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 17:11:26 +00:00
Scott Taylor 3855cfbffd In `WP_MS_Themes_List_Table::display_rows()`:
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32756


git-svn-id: http://core.svn.wordpress.org/trunk@32727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 16:54:26 +00:00
Scott Taylor 2bdcc71bc0 In `WP_MS_Sites_List_Table::display_rows()`:
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - it could inherit from `WP_List_Table` if we can find a way to handle the `id` column. When that happens, we can ditch this method.

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32755


git-svn-id: http://core.svn.wordpress.org/trunk@32726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 16:23:25 +00:00
Scott Taylor ba8cfcab71 In `WP_Media_List_Table::display_rows()`:
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32754


git-svn-id: http://core.svn.wordpress.org/trunk@32725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:57:27 +00:00
Scott Taylor a56576edfe In `WP_Links_List_Table::display_rows()`:
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32753


git-svn-id: http://core.svn.wordpress.org/trunk@32724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:33:25 +00:00
Scott Taylor b8eb353590 In `WP_Posts_List_Table`, move the `<th>` markup out of `->column_cb()`.
See #29881, [32740].

Built from https://develop.svn.wordpress.org/trunk@32752


git-svn-id: http://core.svn.wordpress.org/trunk@32723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:14:24 +00:00
Scott Taylor 18827ed337 In `wp_ajax_hidden_columns()`, don't `explode()` on an empty string.
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.

This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.

Props afercia, wonderboymusic.
Fixes #32466.

Built from https://develop.svn.wordpress.org/trunk@32751


git-svn-id: http://core.svn.wordpress.org/trunk@32722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:00:25 +00:00
Dominik Schilling 5ec278f585 Toolbar: Remove a duplicate CSS selector.
props deconf.
fixes #32634.
Built from https://develop.svn.wordpress.org/trunk@32750


git-svn-id: http://core.svn.wordpress.org/trunk@32721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:54:25 +00:00
Scott Taylor da0400e273 In `WP_Posts_List_Table::column_title()`, use `is_post_type_hierarchical()` instead of `$this->hierarchical_display` in the logic to determine whether `the_excerpt()` should be called.
Fixes #32187.

Built from https://develop.svn.wordpress.org/trunk@32749


git-svn-id: http://core.svn.wordpress.org/trunk@32720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:42:26 +00:00
Dominik Schilling 792295d077 Nav menus: Apply the `wp_get_nav_menu_items` filter also on an empty list of menu items.
props westonruter.
fixes #32631.
Built from https://develop.svn.wordpress.org/trunk@32748


git-svn-id: http://core.svn.wordpress.org/trunk@32719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:38:25 +00:00
Scott Taylor 144a28a5c2 Add an `abort` class method to the Promise instance returned by `wp.ajax.send()`.
Props westonruter.
Fixes #32628.

Built from https://develop.svn.wordpress.org/trunk@32747


git-svn-id: http://core.svn.wordpress.org/trunk@32718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:30:26 +00:00
Dominik Schilling 33c1c76001 Nav menu: Introduce a `has_nav_menu` filter in `has_nav_menu()` to filter whether a nav menu is assigned to a specified location.
props westonruter.
fixes #32630.
Built from https://develop.svn.wordpress.org/trunk@32746


git-svn-id: http://core.svn.wordpress.org/trunk@32717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:15:25 +00:00
Dominik Schilling fe31ed1e5f Nav menu: Allow the sortable items selector in `wpNavMenu` to be overridden.
props adamsilverstein.
fixes #32633.
Built from https://develop.svn.wordpress.org/trunk@32745


git-svn-id: http://core.svn.wordpress.org/trunk@32716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:03:25 +00:00
Weston Ruter 489db97ea3 Customizer: Allow sections and panels to be exported to JS.
Also fix param docs for `customize_dynamic_setting_class` filter, and use `require_once` for `class-wp-customize-manager.php` in bootstrap function `_wp_customize_include()`.

See #30737, #32576.

Built from https://develop.svn.wordpress.org/trunk@32744


git-svn-id: http://core.svn.wordpress.org/trunk@32715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 22:54:25 +00:00