Scott Taylor
29deacc30c
Revisions modules should not rely on global settings:
...
* Only pass in global settings on `init`, this allows the classes to be used agnostically elsewhere
* Clean up some erroneous/weird Backbone syntax
Props ericlewis, wonderboymusic.
Fixes #30219 .
Built from https://develop.svn.wordpress.org/trunk@30131
git-svn-id: http://core.svn.wordpress.org/trunk@30131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:39:24 +00:00
Scott Taylor
d1d93b7cda
Set `revision.settings` via short-circuit check for `window` property: `window._wpRevisionsSettings || {}`
...
Props ericlewis.
Fixes #30218 .
Built from https://develop.svn.wordpress.org/trunk@30130
git-svn-id: http://core.svn.wordpress.org/trunk@30130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:20:22 +00:00
Scott Taylor
7cbb7552da
Allow revision Backbone classes to be used on pages other than `revision.php`.
...
Props ericlewis.
Fixes #30221 .
Built from https://develop.svn.wordpress.org/trunk@30128
git-svn-id: http://core.svn.wordpress.org/trunk@30128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:08:21 +00:00
Scott Taylor
f1634f7c8f
Add some JSDoc blocks to `revisions.js`.
...
Props ericlewis.
See #30222 .
Built from https://develop.svn.wordpress.org/trunk@30127
git-svn-id: http://core.svn.wordpress.org/trunk@30127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 23:55:22 +00:00
Dominik Schilling
461507452a
Customizer: Improve `ColorControl`'s `wpColorPicker` to update UI based on setting changes.
...
Update Twenty Fifteen's `colorScheme` control to properly interact with the API, using `wp.customize.control()` instead of traversing DOM for other controls' container elements and stop manually updating color control UIs.
props westonruter.
fixes #30031 .
Built from https://develop.svn.wordpress.org/trunk@30126
git-svn-id: http://core.svn.wordpress.org/trunk@30126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 20:45:22 +00:00
Dominik Schilling
00845a6c3d
Customizer: Fix missing newly added widgets in the preview after [29905].
...
props westonruter.
fixes #29983 .
Built from https://develop.svn.wordpress.org/trunk@30104
git-svn-id: http://core.svn.wordpress.org/trunk@30104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:57:23 +00:00
Dominik Schilling
3c962ee5d8
Improve/introduce Customizer JavaScript models for Controls, Sections, and Panels.
...
* Introduce models for panels and sections.
* Introduce API to expand and focus a control, section or panel.
* Allow deep-linking to panels, sections, and controls inside of the Customizer.
* Clean up `accordion.js`, removing all Customizer-specific logic.
* Add initial unit tests for `wp.customize.Class` in `customize-base.js`.
https://make.wordpress.org/core/2014/10/27/toward-a-complete-javascript-api-for-the-customizer/ provides an overview of how to use the JavaScript API.
props westonruter, celloexpressions, ryankienstra.
see #28032 , #28579 , #28580 , #28650 , #28709 , #29758 .
fixes #29529 .
Built from https://develop.svn.wordpress.org/trunk@30102
git-svn-id: http://core.svn.wordpress.org/trunk@30102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 22:51:22 +00:00
Sergey Biryukov
ef00815a3a
Fix JSHint errors introduced in [30014].
...
props adamsilverstein.
see #29572 .
Built from https://develop.svn.wordpress.org/trunk@30024
git-svn-id: http://core.svn.wordpress.org/trunk@30024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-26 12:06:19 +00:00
John Blackbourn
905b6a9d67
Add the ability for a customizer control to render its controls via a JavaScript template. Switches the default color picker control to a JavaScript template. See #29572 . Props celloexpressions
...
Built from https://develop.svn.wordpress.org/trunk@30014
git-svn-id: http://core.svn.wordpress.org/trunk@30014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-24 16:32:18 +00:00
Andrew Ozz
ecdc8d3baf
Admin menu:
...
- Fix scrolling the pinned menu with a mouse wheel.
- Fix pinning when the menu is only slightly taller than the viewport.
- Disable pinning on IE8, updating CSS top makes it jump when scrolling with a mouse wheel.
See #29806
Built from https://develop.svn.wordpress.org/trunk@29978
git-svn-id: http://core.svn.wordpress.org/trunk@29724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-21 06:12:20 +00:00
Sergey Biryukov
79175d10cb
In wp.updates.decrementCount(), only display the count if it's a valid non-negative integer.
...
props jdgrimes.
fixes #29527 .
Built from https://develop.svn.wordpress.org/trunk@29960
git-svn-id: http://core.svn.wordpress.org/trunk@29707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-18 19:55:18 +00:00
Andrew Ozz
553bb3cf77
Editor-expand:
...
- Better calculation for the caret position when auto-scrolling while typing.
- Fix auto-scrolling for non-WebKit browsers when the caret is above the top of the editor.
Fixes #29954
Built from https://develop.svn.wordpress.org/trunk@29929
git-svn-id: http://core.svn.wordpress.org/trunk@29681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 21:31:18 +00:00
Dominik Schilling
e3e1433e9a
Themes: Make it possible to delete broken themes.
...
props ideag, obenland.
fixes #28165 .
Built from https://develop.svn.wordpress.org/trunk@29924
git-svn-id: http://core.svn.wordpress.org/trunk@29676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:46:18 +00:00
Dominik Schilling
4020eacd8b
Customizer: Only POST dirty settings to preview to improve performance.
...
props westonruter.
fixes #29983 .
Built from https://develop.svn.wordpress.org/trunk@29905
git-svn-id: http://core.svn.wordpress.org/trunk@29660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:50:18 +00:00
Dominik Schilling
61819a36ea
Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific.
...
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/ .
props studionashvegas, tareq1988.
fixes #29947 .
Built from https://develop.svn.wordpress.org/trunk@29903
git-svn-id: http://core.svn.wordpress.org/trunk@29658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:21:19 +00:00
Andrew Ozz
f19ad10571
Admin menu:
...
- Fix pinning after resizing the window.
- Merge the two DOM ready callbacks in common.js
- Fix the submenus position adjustment on focus.
See #29806
Built from https://develop.svn.wordpress.org/trunk@29898
git-svn-id: http://core.svn.wordpress.org/trunk@29653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 06:05:18 +00:00
Andrew Ozz
c3b2243a98
Editor-expand: reset the editor height after the window is resized. Fixes #29952 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@29886
git-svn-id: http://core.svn.wordpress.org/trunk@29642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-13 21:15:19 +00:00
Andrew Ozz
0fbefeaaf9
Fix support for the `hide` option in wpColorPicker, props tollmanz, fixes #29632
...
Built from https://develop.svn.wordpress.org/trunk@29879
git-svn-id: http://core.svn.wordpress.org/trunk@29636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-12 00:51:18 +00:00
Andrew Ozz
f98106769d
Pin the admin menu on scrolling similarly to how the side metaboxes are pinned on the Edit Post screen, first run. See #29806 .
...
Built from https://develop.svn.wordpress.org/trunk@29835
git-svn-id: http://core.svn.wordpress.org/trunk@29599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-05 03:09:20 +00:00
Sergey Biryukov
468dc35b8b
When switching to the Text editor, make the textarea visible to screen readers.
...
props afercia.
fixes #29815 .
Built from https://develop.svn.wordpress.org/trunk@29815
git-svn-id: http://core.svn.wordpress.org/trunk@29581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-02 12:46:16 +00:00
Sergey Biryukov
18606f2d2b
Use a more specific selector for the count displayed on Add Themes network admin screen.
...
props mantismamita, nikolov.tmw.
fixes #29421 .
Built from https://develop.svn.wordpress.org/trunk@29786
git-svn-id: http://core.svn.wordpress.org/trunk@29558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 13:07:17 +00:00
Andrew Ozz
0a4d4a3d93
Fix tapping on the menu in iOS and Android, fixes #29365 for trunk
...
Built from https://develop.svn.wordpress.org/trunk@29770
git-svn-id: http://core.svn.wordpress.org/trunk@29542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-26 23:02:16 +00:00
Andrew Ozz
613571202c
Editor expand: hide TinyMCE float panels and tooltips when scrolling, props avryl, fixes #29516 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@29738
git-svn-id: http://core.svn.wordpress.org/trunk@29512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-12 01:21:15 +00:00
Sergey Biryukov
ee6af4f40c
Widgets: Toggle widget arrow when the widget is closed using Close link.
...
props senff.
fixes #29617 .
Built from https://develop.svn.wordpress.org/trunk@29726
git-svn-id: http://core.svn.wordpress.org/trunk@29500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-10 17:36:15 +00:00
Sergey Biryukov
7dcabd849a
Make sure we're on the media grid page before calling wp.media().
...
props azaozz.
fixes #29520 for trunk.
Built from https://develop.svn.wordpress.org/trunk@29725
git-svn-id: http://core.svn.wordpress.org/trunk@29499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-09 10:14:17 +00:00
Andrew Ozz
86373f3a4b
Editor expand: revert back to scrolling to the editor top when switching Visual to Text, fixes #29338
...
Built from https://develop.svn.wordpress.org/trunk@29698
git-svn-id: http://core.svn.wordpress.org/trunk@29473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 18:04:16 +00:00
Helen Hou-Sandí
c8cdcef9be
Editor scrolling: Remember and restore scroll position for visual and text modes.
...
This prevents the editor from jumping off screen when the rendered visual content is significantly taller than plain text, e.g. when there are views present.
This is also a close restoration of 3.9 behavior, some of which was browser-specific.
props avryl.
fixes #29338 .
Built from https://develop.svn.wordpress.org/trunk@29693
git-svn-id: http://core.svn.wordpress.org/trunk@29468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 09:58:16 +00:00
Andrew Nacin
0f73f0bea3
Editor scrolling: Avoid jumping to the cursor when modifier and scrolling keys are pressed.
...
fixes #29485 .
Built from https://develop.svn.wordpress.org/trunk@29692
git-svn-id: http://core.svn.wordpress.org/trunk@29467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-03 09:38:16 +00:00
Dominik Schilling
cdbe551b8c
Menus: Improve performance for title live updating. Add `change` event for IE < 9.
...
props helen, SergeyBiryukov.
fixes #23076 .
Built from https://develop.svn.wordpress.org/trunk@29672
git-svn-id: http://core.svn.wordpress.org/trunk@29446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 13:23:18 +00:00
Helen Hou-Sandí
b80c5d3e51
Comments: Simplify JS for inline edit and reply.
...
fixes #27533 .
Built from https://develop.svn.wordpress.org/trunk@29662
git-svn-id: http://core.svn.wordpress.org/trunk@29436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 03:57:18 +00:00
Andrew Ozz
7a82b73837
Editor expand:
...
- Adjust calculation when comparing sidebar position to wpfooter top. Fixes an annoying jumping when the user scrolls off the bottom.
- Use a var for the 'bottom' distance of the sidebar.
- Fix sidebar pinning when it's height is nearly the same as the viewport height.
Fixes #29349
Built from https://develop.svn.wordpress.org/trunk@29656
git-svn-id: http://core.svn.wordpress.org/trunk@29430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-01 18:49:15 +00:00
Helen Hou-Sandí
c392ff6f90
Editor scrolling: reduce the amount of height jumping on load.
...
props avryl.
fixes #29307 .
Built from https://develop.svn.wordpress.org/trunk@29628
git-svn-id: http://core.svn.wordpress.org/trunk@29402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 18:39:17 +00:00
Helen Hou-Sandí
e51fdf9d7d
Focus styling: bring the blue glow to more places.
...
Handles color picker, theme browser, help/screen options, TinyMCE dialog buttons, jQuery UI dialog buttons, and buttons in color schemes.
props avryl, celloexpressions. fixes #28267 .
Built from https://develop.svn.wordpress.org/trunk@29616
git-svn-id: http://core.svn.wordpress.org/trunk@29390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 05:17:17 +00:00
Helen Hou-Sandí
f348ccccf8
Customizer panels: use a single back button for all panels.
...
This also ensures the back button is visible on iOS devices.
props celloexpressions.
fixes #29135 .
Built from https://develop.svn.wordpress.org/trunk@29610
git-svn-id: http://core.svn.wordpress.org/trunk@29384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 23:05:15 +00:00
Helen Hou-Sandí
713857625e
Make filter bar CSS less verbose and redundant.
...
Also removes an unused handler in the theme feature filter.
see #28794 .
Built from https://develop.svn.wordpress.org/trunk@29596
git-svn-id: http://core.svn.wordpress.org/trunk@29370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 15:58:15 +00:00
Andrew Ozz
488e2aa4cf
Editor expand: add border to the Text editor resize helper, helps calculating the height in some cases. Fixes #29225
...
Built from https://develop.svn.wordpress.org/trunk@29593
git-svn-id: http://core.svn.wordpress.org/trunk@29367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 03:43:17 +00:00
Andrew Ozz
58752f91db
Editor scrolling: fix window height when switching Visual to Text and the editor is shorter. Props mackensen, fixes #29226 .
...
Built from https://develop.svn.wordpress.org/trunk@29592
git-svn-id: http://core.svn.wordpress.org/trunk@29366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 23:12:15 +00:00
Dominik Schilling
3a980c39c8
Apply accessibility improvements to Plugins screen too.
...
props SergeyBiryukov.
fixes #29342 .
Built from https://develop.svn.wordpress.org/trunk@29583
git-svn-id: http://core.svn.wordpress.org/trunk@29357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:22:16 +00:00
Andrew Ozz
61292620c5
Editor scrolling:
...
- Pin the TinyMCE statusbar (elements path) to the bottom.
- Add support for pinning the menu when present.
- Add borders from CSS.
- Optimize getting most elements outerHeight.
Part props avryl, fixes #29293 , see #28328 .
Built from https://develop.svn.wordpress.org/trunk@29579
git-svn-id: http://core.svn.wordpress.org/trunk@29353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 05:11:16 +00:00
Scott Taylor
6352d703a0
Media Grid/Modal Keyboard navigation improvements:
...
* Add focus to arrows on Next/Previous in the grid's modal on left/right keypress, and add the necessary CSS for `:focus`
* When in a disabled input in the grid modal, allow the left/right keys to work
* Make the image editor return a `$.Deferred` so that there isn't a race condition with UI loading.
* Assign focus when the edit image mode is rendered so that the modal can be closed on Esc press
Props wonderboymusic, adamsilverstein (for the initial patch).
See #23560 .
Built from https://develop.svn.wordpress.org/trunk@29560
git-svn-id: http://core.svn.wordpress.org/trunk@29335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 02:35:17 +00:00
Dominik Schilling
f5ec2a211b
Plugin details: Accessibility improvements
...
* Focus the close link to transfer focus into the plugin modal.
* Set title attribute on iframe for screereaders.
props jwenerd for initial patch and a11y team for testing.
fixes #28823 .
Built from https://develop.svn.wordpress.org/trunk@29534
git-svn-id: http://core.svn.wordpress.org/trunk@29310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 20:02:19 +00:00
Andrew Ozz
c0fef55a47
DFW: revert applying the Visual editor body color and background-color for now. Set the color to #333 and the background to transparent. Fixes #28330 .
...
Built from https://develop.svn.wordpress.org/trunk@29533
git-svn-id: http://core.svn.wordpress.org/trunk@29309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 18:23:16 +00:00
Andrew Ozz
68a3e1af2c
Editor scrolling: set max-width: 100% for the text editor clone instead of always resizing it. See #29246 .
...
Built from https://develop.svn.wordpress.org/trunk@29524
git-svn-id: http://core.svn.wordpress.org/trunk@29300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 01:13:16 +00:00
Andrew Ozz
bae4afab44
Editor scrolling:
...
- Properly handle change of sidebar height when opening, closing or hiding postboxes.
- Add a flag when to start pinning. Set it to few pixels more than the initial editor height.
See #28328
Built from https://develop.svn.wordpress.org/trunk@29523
git-svn-id: http://core.svn.wordpress.org/trunk@29299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 00:35:18 +00:00
Andrew Ozz
4fc5f9bcca
Editor scrolling: always resize the text editor clone so it doesn't "push" the parent's width over 100%, fixes #29246 .
...
Built from https://develop.svn.wordpress.org/trunk@29522
git-svn-id: http://core.svn.wordpress.org/trunk@29298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-17 21:33:15 +00:00
Dominik Schilling
27e564113d
Admin Menu: Auto fold the menu at 960px.
...
This gives us some more room at the post edit screen.
props vinod dalvi for initial patch.
fixes #28592 .
Built from https://develop.svn.wordpress.org/trunk@29518
git-svn-id: http://core.svn.wordpress.org/trunk@29294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-17 14:15:17 +00:00
Helen Hou-Sandí
da2d975668
Editor scrolling:
...
* Reduce the starting height of the editor to better match the height at which the top toolbar unpins.
* Pin the side metaboxes so they do not get lost when the editor content is long.
* Turn magic numbers into variables.
props stephdau, azaozz. see #28328 .
Built from https://develop.svn.wordpress.org/trunk@29495
git-svn-id: http://core.svn.wordpress.org/trunk@29273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-15 03:17:15 +00:00
Helen Hou-Sandí
093772f3c0
Plugin details modal:
...
* Scroll all content, rather than the dual-pane scrolling awkwardness.
* Better align the header image and title overlay with the display on WordPress.org, at least at full-width.
* Move the close button outside of the modal itself, rather than overlay on top of colors we can't predict.
props stephdau, tellyworth, helen. fixes #27440 .
Built from https://develop.svn.wordpress.org/trunk@29474
git-svn-id: http://core.svn.wordpress.org/trunk@29252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-12 23:02:16 +00:00
Scott Taylor
5cab03ab29
Add some docs to Customizer JS.
...
Props ericlewis.
See #29157 .
Built from https://develop.svn.wordpress.org/trunk@29451
git-svn-id: http://core.svn.wordpress.org/trunk@29229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-08 23:31:15 +00:00
Andrew Nacin
40258a41b8
Language chooser imporvements.
...
* Use a translated 'Continue' string.
* Go back to using a select element.
* Only show a spinner when we're installing a language.
see #28577 .
Built from https://develop.svn.wordpress.org/trunk@29372
git-svn-id: http://core.svn.wordpress.org/trunk@29150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-04 20:47:16 +00:00