Commit Graph

81 Commits

Author SHA1 Message Date
Helen Hou-Sandí 9d0ab29bc4 Nav menus: Provide visual feedback when attempting to add an empty custom link.
props pragunbhutani for the initial patch.
fixes #18517.

Built from https://develop.svn.wordpress.org/trunk@32690


git-svn-id: http://core.svn.wordpress.org/trunk@32660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-04 04:31:26 +00:00
Gary Pendergast e3f1f8fed1 Ensure post titles are correctly escaped on the Dashboard.
Props helen, ocean90, dd32, pento.


Built from https://develop.svn.wordpress.org/trunk@32175


git-svn-id: http://core.svn.wordpress.org/trunk@32150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 07:39:25 +00:00
Helen Hou-Sandí 3ac1a19529 Spinners: Toggle a class instead of show/hide.
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.

Built from https://develop.svn.wordpress.org/trunk@31996


git-svn-id: http://core.svn.wordpress.org/trunk@31975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 04:52:27 +00:00
Helen Hou-Sandí b201f3a5cb Fix some inline doc typos that were missed in [31604]. see #25698.
Built from https://develop.svn.wordpress.org/trunk@31605


git-svn-id: http://core.svn.wordpress.org/trunk@31586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-03 21:18:25 +00:00
Helen Hou-Sandí 5567d03278 Nav menus: Better JS performance on initial load of edit screen.
The accessibility helpers previously processed all items when editing a menu, which was quite slow to the point of being unresponsive for large menus. They now only process items when they are expanded or a user comes near them in some way, such as hover or focus.

Also simplifies a redundant set of click event handlers down to one, which further enhances performance.

props atimmer, sevenspark.
fixes #25698.

Built from https://develop.svn.wordpress.org/trunk@31604


git-svn-id: http://core.svn.wordpress.org/trunk@31585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-03 21:14:25 +00:00
Sergey Biryukov a82763b7b6 Menus: Don't display "Move" text without direction if there is only one menu item.
props kucrut for initial patch.
fixes #30765.
Built from https://develop.svn.wordpress.org/trunk@31320


git-svn-id: http://core.svn.wordpress.org/trunk@31301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-01 05:29:26 +00:00
Dominik Schilling cdbe551b8c Menus: Improve performance for title live updating. Add `change` event for IE < 9.
props helen, SergeyBiryukov.
fixes #23076.
Built from https://develop.svn.wordpress.org/trunk@29672


git-svn-id: http://core.svn.wordpress.org/trunk@29446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 13:23:18 +00:00
Scott Taylor b964ac0148 Live update the menu item title when the user is editing the "Navigation Label" field.
Props celloexpressions.
See #23076.

Built from https://develop.svn.wordpress.org/trunk@28707


git-svn-id: http://core.svn.wordpress.org/trunk@28523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-09 18:39:15 +00:00
Andrew Nacin 7ac1f7916f Return some semicolons. fixes #25594.
Built from https://develop.svn.wordpress.org/trunk@26623


git-svn-id: http://core.svn.wordpress.org/trunk@26513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 19:08:10 +00:00
Andrew Nacin bfc16271ca Nav Menus: Delegate click events for move links.
props ankit.gade.
fixes #25594.

Built from https://develop.svn.wordpress.org/trunk@26613


git-svn-id: http://core.svn.wordpress.org/trunk@26503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 17:10:11 +00:00
Sergey Biryukov 4e28c278a5 Fix replacement regex in wp-admin/js/nav-menu.js.
props rzen, jeremyfelt.
fixes #26047.
Built from https://develop.svn.wordpress.org/trunk@26233


git-svn-id: http://core.svn.wordpress.org/trunk@26140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-16 07:42:11 +00:00
Andrew Nacin 2c1ccede9d Fix JSHint errors in nav-menu.js.
props atimmer.
fixes #25953.

Built from https://develop.svn.wordpress.org/trunk@26163


git-svn-id: http://core.svn.wordpress.org/trunk@26074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 06:09:11 +00:00
Andrew Nacin d2f06ecf48 Optimize the accessibility JS on the Menus screen to avoid browser crashes with very large menus.
props atimmer.
fixes #25112.

Built from https://develop.svn.wordpress.org/trunk@25708


git-svn-id: http://core.svn.wordpress.org/trunk@25622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-07 13:37:08 +00:00
Dominik Schilling 328c4e9a67 Revert [25622]. fixes #25445. see #25122.
Built from https://develop.svn.wordpress.org/trunk@25687


git-svn-id: http://core.svn.wordpress.org/trunk@25603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 09:12:08 +00:00
Andrew Nacin 8896aab690 Only show top-level items when adding pages to a User's First Nav Menu. (This is also the title of Dave's first children's book.)
props lessbloat.
fixes #25122.

Built from https://develop.svn.wordpress.org/trunk@25622


git-svn-id: http://core.svn.wordpress.org/trunk@25539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 16:23:09 +00:00
Dominik Schilling c2739d12cc Trim leading whitespace from AJAX responses.
This fixes the warning "$(html) HTML strings must start with '<' character" by jQuery Migrate when adding nav menu items, post custom fields or comment replies.

fixes #23681.
Built from https://develop.svn.wordpress.org/trunk@25546


git-svn-id: http://core.svn.wordpress.org/trunk@25466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 10:51:09 +00:00
Helen Hou-Sandí 0da48b8335 Tweaks to the accordion:
* Enqueues JS in `do_accordion_sections()`.
* Top and bottom rounded corners for the nav menu accordion.
* Better RTL and no-JS.

props lessbloat, DrewAPicture, aaroncampbell, helen. fixes #23449.


git-svn-id: http://core.svn.wordpress.org/trunk@24680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 18:16:29 +00:00
Mark Jaquith 19810a259c Move nav menus to a tabbed interface, so that users with a lot of locations can do bulk assignment.
props DrewAPicture, lessbloat. fixes #23770

git-svn-id: http://core.svn.wordpress.org/trunk@23810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-27 11:46:08 +00:00
Sergey Biryukov 9f26938da3 Use placeholders in menu strings instead of manual concatenation. fixes #14045.
git-svn-id: http://core.svn.wordpress.org/trunk@23761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-20 05:49:29 +00:00
Sergey Biryukov f0a60fb9c9 Fix object name. props GaryJ. see #14045.
git-svn-id: http://core.svn.wordpress.org/trunk@23760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-20 05:46:39 +00:00
Mark Jaquith 9bd740f616 Accessibility revamp for nav menus.
props lessbloat. fixes #14045

git-svn-id: http://core.svn.wordpress.org/trunk@23727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-16 04:47:19 +00:00
Mark Jaquith 83bb916b81 Turn the Nav Menu meta boxes into an accordion. Less sprawling and overwhelming.
* Registration stays the same — they're meta boxes
* Call `do_accordion_sections()` instead of `do_meta_boxes()` and they render as an accordion

props DrewAPicture, lessbloat, jkudish. fixes #23450. see #23449

git-svn-id: http://core.svn.wordpress.org/trunk@23707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 13:16:38 +00:00
Andrew Nacin 1e555a03a1 Remove message slide-down effect on the nav-menus.php page. props lessbloat, fixes #23714.
git-svn-id: http://core.svn.wordpress.org/trunk@23640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 17:03:15 +00:00
Mark Jaquith 52c46736df Improve the UX of the Nav Menus screen. Kill the tabs, and change to a
dropdown, unless you have zero or one menus (which is the most common),
in which case you jump right into editing your sole menu.

Do assignment to location using checkboxes in the main menu editing
section instead of the backwards menu => location assignment in a
random meta box.

More to come, but this gets us started.

props lessbloat, DrewAPicture, jkudish. see #23119

git-svn-id: http://core.svn.wordpress.org/trunk@23441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 04:53:59 +00:00
Andrew Nacin 1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Andrew Nacin 2710bcade1 Switch to .min for compressed JS and CSS files.
* This moves our "development" versions from .dev.js to .js (same for css).
 * The compressed version then moves from .js to .min.js (same for css).

By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.

fixes #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
nacin a14dd3db8b Allow enter to trigger a new custom link on nav-menus.php. props mattwiebe, fixes #18255.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-16 01:45:11 +00:00
azaozz 65f9c441a7 Replace .attr() with .prop() as per jQuery 1.6.1. Also fixes couple places where the JS wasn't working because attr('some', '') does not remove the HTML property now, see #17311
git-svn-id: http://svn.automattic.com/wordpress/trunk@18027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-25 01:04:12 +00:00
azaozz 9e4bee6c26 Add quotes to [value="some"] selectors, see #16426
git-svn-id: http://svn.automattic.com/wordpress/trunk@17777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-30 02:15:08 +00:00
scribu 6e56dce7dd Fix menu box search. Fixes #14335
git-svn-id: http://svn.automattic.com/wordpress/trunk@15709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-04 14:17:34 +00:00
nacin 975b2cdb6d Horizontal scrolling/resizing fixes for nav menu UI. Also some RTL fixes. props koopersmith, see #13525
git-svn-id: http://svn.automattic.com/wordpress/trunk@15214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-11 05:19:36 +00:00
nacin dacccec2f7 Prevent 'Enter menu name here' menus, and offer some feedback. props koopersmith, fixes #13703.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-03 03:33:54 +00:00
markjaquith 7aa4551ec7 Do not load window.onbeforeonload event if we are not on an existing nav menu. props filosofo. Reduce opacity on nav menu postboxes if we are not on an existing nav menu, and for JS users, deactivate all links and form elements, to make it obvious that those UI elements are not usable at this stage. fixes #13615
git-svn-id: http://svn.automattic.com/wordpress/trunk@15062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-29 19:39:40 +00:00
nacin 35d800986f Sanity check menu item parents and fix HTML issues. props filosofo, fixes #13600.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-28 23:04:00 +00:00
nacin 0d09181552 Don't show double-AYS for deleting a menu. props filosofo, duck_. see #13525.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-28 20:38:19 +00:00
ryan 70b6f9c478 Nav menu RTL js fixes. Props filosofo. see #13525
git-svn-id: http://svn.automattic.com/wordpress/trunk@15039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-28 16:57:47 +00:00
nacin 4d5114ff86 Force menu AYS when a menu item is deleted. props ocean90, see #13525.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 02:31:23 +00:00
nacin da7b990fb5 Move the "Add Home Link" functionality to a checkbox on the View All tab of the Pages metabox. Also makes it work non-JS. props filosofo, fixes #13213.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 02:24:33 +00:00
ryan 1fa281b08c Ajaxify pagination requests in menu boxes. Props filosofo. fixes #13204
git-svn-id: http://svn.automattic.com/wordpress/trunk@14943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 14:49:43 +00:00
nacin b0e128e69b Don't hide early nav menu instructions until the menu is no longer empty. props koopersmith, see #13525
git-svn-id: http://svn.automattic.com/wordpress/trunk@14917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 00:41:18 +00:00
nacin 7a5d3f2688 First pass on better UX for menu item save. props koopersmith, see #13525.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-24 19:50:20 +00:00
nacin f15cdc78cf Menu tweaks. Save menu locations when saving the menu. Also, centralize theme support checks and add them to menu.php. Improve some branching. Remove some old JS vars, add a missing semicolon, etc. props koopersmith. see #13378.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-24 09:23:56 +00:00
nacin c84bc2e846 Pixel sanity check. props filosofo, fixes #13470.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-21 23:35:37 +00:00
nacin 49437c3491 Fix nav menu locations sorting. props jorbin, koopersmith with assists. see #13378.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-20 22:43:14 +00:00
ryan 2d3d649182 Menu styling fixes for IE. Props filosofo, ocean90. fixes #13388 #13348
git-svn-id: http://svn.automattic.com/wordpress/trunk@14761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-20 19:33:57 +00:00
nacin 337df6e337 Remove AYS for deleting a menu item. fixes #13330.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-20 14:55:11 +00:00
markjaquith 31dd323f01 Add AYS notice on unsaved menu changes. see #12472
git-svn-id: http://svn.automattic.com/wordpress/trunk@14741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-19 09:56:02 +00:00
ryan bc1bf148e4 Add nonce to menu-locations-save. Props koopersmith. see #13378
git-svn-id: http://svn.automattic.com/wordpress/trunk@14725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-18 15:16:58 +00:00
nacin f02fddce86 Save menu locations meta box via ajax. see #13378.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-17 23:58:56 +00:00
nacin 6c01265794 First pass at fixing search for add menu item boxes. props koopersmith, see #13283.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 05:39:53 +00:00