Commit Graph

19703 Commits

Author SHA1 Message Date
Andrew Nacin f965d758fc Add magic set, isset, and unset to wpdb. props pento.
These magic methods allow us to mark properties as protected or private, without breaking compatibility, as they were once accessible. The joys of PHP4.

fixes #18510.



git-svn-id: http://core.svn.wordpress.org/trunk@21512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 20:26:04 +00:00
Andrew Nacin c11a4c09e8 Eliminate error suppression for mysql_free_result() and only call it when the result is actually a resource. Depending on the query, mysql_query() can return a boolean rather than a resource, hence the original use of error suppression.
Fixes a warning introduced in [21472] when calling mysql_free_result() was moved to flush().

fixes #20838.



git-svn-id: http://core.svn.wordpress.org/trunk@21511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 20:21:10 +00:00
Andrew Ozz 96156ac36c Stop Chrome from applying outline to DIVs that have tabindex="-1", see #21324
git-svn-id: http://core.svn.wordpress.org/trunk@21510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 19:37:27 +00:00
Ryan Boren 17f544b798 Update wp_update_user() phpdoc to reflect a possible return of WP_Error. Props SergeyBiryukov. fixes #21439
git-svn-id: http://core.svn.wordpress.org/trunk@21509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 19:29:40 +00:00
Ryan Boren 77fdb14c2c Fix display issues in the custom header screen when height is not specified. Use get_header_image() instead of header_image() so that esc_url() can do its job. Props JarretC, SergeyBiryukov, georgestephanis. fixes #21130 #21433
git-svn-id: http://core.svn.wordpress.org/trunk@21508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 19:24:36 +00:00
Ryan Boren 8eb21fd381 Use admin_url() instead of get_edit_user_link() in wp-login.php since cookies are not yet set. Props SergeyBiryukov. fixes #14787
git-svn-id: http://core.svn.wordpress.org/trunk@21507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 19:10:37 +00:00
Ryan Boren dc58551658 Add isset() check to avoid notice. Props c3mdigital. fixes #21512
git-svn-id: http://core.svn.wordpress.org/trunk@21506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 19:07:56 +00:00
Bot (Assets) a84e9aebfd Compress scripts/styles: 3.5-alpha-21505.
git-svn-id: http://core.svn.wordpress.org/trunk@21505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 18:58:20 +00:00
Ryan Boren 15dd7f70b0 Remove post type from post nonces. Fixes attachment deletion when EMPTY_TRASH_DAYS is 0. Props c3mdigital, kurtpayne, SergeyBiryukov. fixes #21194
git-svn-id: http://core.svn.wordpress.org/trunk@21504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 18:39:15 +00:00
Andrew Nacin 4d014c4f40 Fix WP_Theme's get_template_directory_uri() method. props batmoo. see #21549 for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@21503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 18:38:26 +00:00
Ryan Boren 076868e109 Better instruction text on custom header screen. Props jane, JustinSainton fixes #20992
git-svn-id: http://core.svn.wordpress.org/trunk@21502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 18:32:26 +00:00
Andrew Nacin 84c3a86036 Hide the link manager from the UI on upgrade, if the site has no links. New DB option, link_manager_enabled.
Enforce this by denying the 'manage_links' capability, which hides the All Links, Add New Link, and Link Categories screens. Hide WP_Widget_Links and the UI for the default_link_category as well.

Convert all references to 'posts and links' when handling reassignment on user deletion to just 'posts'.

see #21307.



git-svn-id: http://core.svn.wordpress.org/trunk@21501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-13 16:18:42 +00:00
Andrew Nacin 720e09ff5b Stop adding default links and the 'Blogroll' link category on install. props wonderboymusic. see #21307.
git-svn-id: http://core.svn.wordpress.org/trunk@21500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-13 15:55:15 +00:00
Bot (Assets) 0802777be2 Compress scripts/styles: 3.5-alpha-21499.
git-svn-id: http://core.svn.wordpress.org/trunk@21499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-11 02:58:19 +00:00
Andrew Ozz 64033c4645 Remove unused images, props helenyhou, coffee2code, ocean90, fixes #20980
git-svn-id: http://core.svn.wordpress.org/trunk@21498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-11 02:36:01 +00:00
Ryan Boren 1fd3c5471e Avoid fatal error in the customizer when the current theme doesn't support custom headers. Props c3mdigital. fixes #21515
git-svn-id: http://core.svn.wordpress.org/trunk@21497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-10 20:15:06 +00:00
Ryan Boren cbd6a8becd Allow passing stdClass and WP_User to wp_insert_user() and wp_update_user(). Introduce WP_User::to_array(). Eliminate uses of get_object_vars() when passing to wp_*_user(). fixes #21429
git-svn-id: http://core.svn.wordpress.org/trunk@21496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-10 15:36:54 +00:00
Andrew Ozz ed1698e29b Better editor background, take one, see #21536
git-svn-id: http://core.svn.wordpress.org/trunk@21495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-10 07:11:03 +00:00
potbot 18cf7ea5a2 POT, generated from r21492
git-svn-id: http://core.svn.wordpress.org/trunk@21494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 19:22:41 +00:00
potbot 8d1526b981 POT, generated from r21492
git-svn-id: http://core.svn.wordpress.org/trunk@21493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 19:22:33 +00:00
lancewillett 7e850a0ce6 Twenty Twelve: pinking shears for header.php
git-svn-id: http://core.svn.wordpress.org/trunk@21492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 18:42:36 +00:00
lancewillett 241a9f5b9d Twenty Eleven: allow content-single.php to be overridden for post formats, props murky. Closes #17996.
git-svn-id: http://core.svn.wordpress.org/trunk@21491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 18:31:02 +00:00
lancewillett 27281f6fd1 Twenty Ten and Eleven: *_continue_reading_link() should be pluggable, fixes #16500. Props nacin and SergeyBiryukov.
git-svn-id: http://core.svn.wordpress.org/trunk@21490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 18:21:58 +00:00
lancewillett 2fe505e25a Twenty Twelve: make twentytwelve_is_categorized_site() pluggable, see #21479.
git-svn-id: http://core.svn.wordpress.org/trunk@21489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 18:20:25 +00:00
lancewillett 34056f4c03 Twenty Eleven: fix gallery thumbnail image overflow, props chellycat. Fixes #20478.
git-svn-id: http://core.svn.wordpress.org/trunk@21488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 17:58:56 +00:00
lancewillett 24c98560e1 Twenty Eleven: fix long URLs in comments overflow content area, fixes #21491. Props SergeyBiryukov jkudish andrewspittle.
Also minor pinking shears in stylesheet and functions file.


git-svn-id: http://core.svn.wordpress.org/trunk@21487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 17:32:39 +00:00
lancewillett 3c586888ad Twenty Ten: code readability in twentyten_comment, props kovshenin, fixes #21474. (And minor pinking shears.)
git-svn-id: http://core.svn.wordpress.org/trunk@21486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 17:22:44 +00:00
ryan d286875515 switch_to_blog() and restore_current_blog() housekeeping.
wp-includes/admin-bar.php:

* Replace get_admin_url() and get_home_url() with admin_url() and home_url() and place them inside a switch/restore. Likewise replace current_user_can_for_blog() with current_user_can(). This avoids doing multiple switch restores.

wp-includes/ms-blogs.php:

* Deprecate the $validate argument to switch_to_blog(). This avoids a not very necessary call to get_blog_details(), possibly saving a few queries.
* Use $_wp_switched and $_wp_switched_stack instead of $switched and $switched_stack to make it less likely these globals will be stomped.
* Use GLOBALS to access blog_id and other globals. I've preferred this style lately since it makes it obvious a global is being used and avoids global blog_id being stomped by a local variable.
* Lose some is_object() checks. wp_get_current_user() always returns an object, for example.
* Call the new WP_Roles::reinit() method.

wp-includes/class-wp-xmlrpc-server.php:

* Replace current_user_can_for_blog() with current_user_can() and move it inside the switch/restore pair. This eliminates a switch/restore.

wp-includes/capabilities.php:

* Use array_keys() instead of $role => $data since $data is unused. I *think* this is a bit faster.
* Introduce WP_Roles::reinit(). This reinitializes WP_Roles and is used after switch_to_blog() has already update the blog ID in the wpdb object. If a global roles array is being used instead of the db, reinit is skipped.
* current_user_can_for_blog() now does a switch/restore. It didn't before meaning it could be reinitializing the user with the wrong role information for the current blog.

wp-includes/ms-settings.php:

* Define $_wp_switched_stack and $_wp_switched. This way switch_to_blog() and restore_current_blog() can rely on it being set.

wp-settings.php:

* Instantiate the WP_Roles global. This was it is always defined during init. To remove the WP_Roles checks from WP_Role and WP_User this would probably have to move before plugins are loaded, which might not be a good thing.

wp-includes/functions.php:

* Update wp_upload_dir() to reference _wp_switched.



git-svn-id: http://core.svn.wordpress.org/trunk@21485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 16:28:15 +00:00
ryan 14ecba530b Move get_current_blog_id() to load.php so it is available during multisite bootstrap. fixes #21432
git-svn-id: http://core.svn.wordpress.org/trunk@21484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 13:17:14 +00:00
lancewillett 5fd1d828a6 Twenty Twelve: fix bypostauthor styling, probs obenland and SergeyBiryukov (also improves the RTL layout, see #21441).
git-svn-id: http://core.svn.wordpress.org/trunk@21483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 19:10:22 +00:00
lancewillett 7ef95f756b Twenty Twelve: add basic styles for IE7 and IE8, supports basic layout now with the small-nav styles. Props obenland, closes #21440.
git-svn-id: http://core.svn.wordpress.org/trunk@21482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 18:03:59 +00:00
azaozz cbc9aabfa4 When WP_Dependencies accept a string for a single dependency, make sure the string is not empty, see #20683
git-svn-id: http://core.svn.wordpress.org/trunk@21481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 17:21:24 +00:00
ryan 87dc511c0f Undeprecate *_blog_option() by popular demand. Put them back in ms-blogs.php since direct inclusion of ms-blogs.php/ms-functions.php is unforntunately common.
see #21432


git-svn-id: http://core.svn.wordpress.org/trunk@21480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 17:11:15 +00:00
lancewillett a83649d755 Twenty Twelve: cleanup up extra space in functions.php
git-svn-id: http://core.svn.wordpress.org/trunk@21479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 16:59:15 +00:00
lancewillett ab2b32c6a9 Twenty Twelve: better gallery columns support, and CSS cleanup. Closes #21475, props philiparthurmoore and pdclark.
git-svn-id: http://core.svn.wordpress.org/trunk@21478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 16:38:21 +00:00
lancewillett e220162063 Twenty Twelve: fix for long words getting hidden in widgets. Props DrewAPicture, closes #21503.
git-svn-id: http://core.svn.wordpress.org/trunk@21477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 16:21:14 +00:00
lancewillett 5280582df1 Twenty Twelve: make nav toggle button same height as other buttons.
git-svn-id: http://core.svn.wordpress.org/trunk@21476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 16:14:36 +00:00
lancewillett 2099053853 Twenty Twelve: add polyfill JS for matchMedia rules, avoids JS error in older IE versions. See #21440.
git-svn-id: http://core.svn.wordpress.org/trunk@21475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 16:13:32 +00:00
westi c702fe6657 Multisite: Fix the new get_space_used() function to correctly calculate Megabytes used and update some phpdoc. Props SergeyBiryukov.
git-svn-id: http://core.svn.wordpress.org/trunk@21474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 07:17:33 +00:00
nacin f02bacd9f1 Declare, document, and protect $dbuser, $dbpassword, $dbname, $dbhost and $dbh in wpdb.
These properties, while protected, are still accessible thanks to the magic getter added in [21472].

props pento, nvartolomei, joelhardi. fixes #18510.



git-svn-id: http://core.svn.wordpress.org/trunk@21473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 06:28:57 +00:00
nacin 1425762319 Lazy-load column info in wpdb. props pento. fixes #20838.
git-svn-id: http://core.svn.wordpress.org/trunk@21472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 06:24:59 +00:00
nacin 4e5fd4de46 Introduce wpdb::get_charset_collate() to return the DEFAULT CHARACTER SET and COLLATE for use in table schemas.
props simonwheatley, pento. fixes #18451.



git-svn-id: http://core.svn.wordpress.org/trunk@21471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 06:13:48 +00:00
nacin 73c74cf8f7 Deprecate wpdb::supports_collation() in favor of wpdb::has_cap().
props hakre, pento. fixes #16757.



git-svn-id: http://core.svn.wordpress.org/trunk@21470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 06:06:57 +00:00
azaozz 7de126df1f Fix typo in wp_login_form(), props greenshady, fixes #21514
git-svn-id: http://core.svn.wordpress.org/trunk@21469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-07 23:13:31 +00:00
azaozz cb618f5858 TinyMCE: fix typo in button tooltips.
git-svn-id: http://core.svn.wordpress.org/trunk@21468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-07 03:28:20 +00:00
nacin 3d479c0b51 Hide the charset setting for installs that have a charset of UTF-8 already. fixes #21507.
git-svn-id: http://core.svn.wordpress.org/trunk@21467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-07 03:10:59 +00:00
bumpbot e27c374cf0 Compress scripts/styles: 3.5-alpha-21466.
git-svn-id: http://core.svn.wordpress.org/trunk@21466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-06 22:58:30 +00:00
azaozz 45469ac3a8 Fix .screen-reader-text in RTL, see #21471
git-svn-id: http://core.svn.wordpress.org/trunk@21465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-06 21:29:27 +00:00
lancewillett 850adce105 Twenty Twelve: update author archive markup and styles, props klagraff. Fixes #21494.
git-svn-id: http://core.svn.wordpress.org/trunk@21464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-06 21:05:02 +00:00
bumpbot 704304d6fe Compress scripts/styles: 3.5-alpha-21463.
git-svn-id: http://core.svn.wordpress.org/trunk@21463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-06 20:58:37 +00:00