Boone Gorges
4ce9db9ce8
In `wp_insert_term()`, clean up accidental duplicate terms after insert.
...
In [30056], the UNIQUE index was removed from the 'slug' column of `wp_terms`.
While we have numerous checks in place to avoid the creation of unwanted
duplicate term+term_taxonomy pairs, it's possible that in certain edge cases -
such as during the lag caused by database replication, or a race condition
involving near-simultaneous creation of more than one term - we'll end up
unwittingly inserting two identical rows.
The current changeset minimizes this risk by introducing a failsafe mechanism
into `wp_insert_term()`. After a term and term_taxonomy are INSERTed, we check
to see whether the term just created is a duplicate of an existing term; if so,
we delete the new one and keep the old one. This prevents problems caused by
replication lag, because SELECT queries that take place after an INSERT will
hit the master database; it mitigates race conditions by enforcing that the
term that was created first (ie, the one with the lowest `term_id`) is
always the "canonical" one.
Props nacin, markjaquith.
See #22023 , #5809 .
Built from https://develop.svn.wordpress.org/trunk@30238
git-svn-id: http://core.svn.wordpress.org/trunk@30238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 01:00:24 +00:00
Ian Stewart
1483e80848
Twenty Fifteen: use continue reading links for auto-generated excerpts to provide a readable link for screenreaders.
...
Props davidakennedy, kraftbj, fixes #30135 .
Built from https://develop.svn.wordpress.org/trunk@30237
git-svn-id: http://core.svn.wordpress.org/trunk@30237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 21:19:22 +00:00
Ian Stewart
2047ff9e5a
Twenty Fifteen: Use the new archive template tags and make archive template titling way simpler!
...
Props obenland, fixes #30246 .
Built from https://develop.svn.wordpress.org/trunk@30236
git-svn-id: http://core.svn.wordpress.org/trunk@30236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 21:01:23 +00:00
Ian Stewart
0952952ef7
Twenty Fifteen: adding licensing info for the image used in the screenshot.
...
Props sakinshrestha, fixes #30156 .
Built from https://develop.svn.wordpress.org/trunk@30235
git-svn-id: http://core.svn.wordpress.org/trunk@30235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:55:22 +00:00
Scott Taylor
8fa0755584
Add some docs to `wp.media.view.EditorUploader`.
...
Props ericlewis.
See #29951 .
Built from https://develop.svn.wordpress.org/trunk@30234
git-svn-id: http://core.svn.wordpress.org/trunk@30234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:48:23 +00:00
Ian Stewart
d21ea0a251
Twenty Fifteen: Formatting cleanup for documentation, crossing eyes, dotting tees.
...
Props lancewillett, MikeHansenMe, fixes #30149 .
Built from https://develop.svn.wordpress.org/trunk@30233
git-svn-id: http://core.svn.wordpress.org/trunk@30233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:26:23 +00:00
Ian Stewart
e2d03edb0d
Twenty Fifteen: missing spaces for code standards.
...
Props Jayjdk, fixes #30076 .
Built from https://develop.svn.wordpress.org/trunk@30232
git-svn-id: http://core.svn.wordpress.org/trunk@30232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:16:22 +00:00
Ian Stewart
b519db9ffa
Twenty Fifteen: accessible alt text for post thumbnail links.
...
Props joedolson, fixes #30076 .
Built from https://develop.svn.wordpress.org/trunk@30231
git-svn-id: http://core.svn.wordpress.org/trunk@30231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 18:57:27 +00:00
Ian Stewart
17dbe26df9
Twenty Fifteen: Simplify the header, sidebar, background controls and make customization faster for users to do. This has the added benefit of fixing our bug where hidden header text wasn't being updated on color scheme switch. Nice.
...
Props celloexpressions, iamtakashi, fixes #30164 and #29980 .
Built from https://develop.svn.wordpress.org/trunk@30230
git-svn-id: http://core.svn.wordpress.org/trunk@30230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 18:42:22 +00:00
Ian Stewart
cc9c8edf83
Twenty Fifteen: Crashing chrome if you don't have Noto installed probably isn't the best experience -- removing font kerning.
...
Props iamtakashi, fixes #30195
Built from https://develop.svn.wordpress.org/trunk@30229
git-svn-id: http://core.svn.wordpress.org/trunk@30229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 17:41:21 +00:00
Drew Jaynes
7d56be8521
Ensure the requires for the admin bootstrap are documented in all wp-admin/user/ files.
...
Props NikV for the initial patch.
Fixes #29111 .
Built from https://develop.svn.wordpress.org/trunk@30228
git-svn-id: http://core.svn.wordpress.org/trunk@30228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 16:32:22 +00:00
Drew Jaynes
7081b906f4
Fix a couple of typos in the hook documentation for the `$option` filter in wp-admin/includes/class-wp-list-table.php.
...
Props bobbingwide.
Fixes #30229 .
Built from https://develop.svn.wordpress.org/trunk@30227
git-svn-id: http://core.svn.wordpress.org/trunk@30227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 16:05:22 +00:00
Drew Jaynes
d19de136c6
Merge a multi-line comment into a single-line comment in wp-includes/link-template.php.
...
See [30166]. See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30226
git-svn-id: http://core.svn.wordpress.org/trunk@30226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 15:59:23 +00:00
Drew Jaynes
256bea185d
Add parameter and return descriptions to the `WP_List_Table::get_pagination_arg()` DocBlock.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30225
git-svn-id: http://core.svn.wordpress.org/trunk@30225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 15:55:23 +00:00
Drew Jaynes
784e162177
Cross reference `get_the_archive_title()` and `get_the_archive_description()` in the inline documentation for their corresponding template tags.
...
Also define the default values for `$before` and `$after` in the template tag documentation.
See [30223]. See #21995 .
Built from https://develop.svn.wordpress.org/trunk@30224
git-svn-id: http://core.svn.wordpress.org/trunk@30224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 06:52:23 +00:00
John Blackbourn
6a45f46937
Introduce some new template functions for archive titles and descriptions:
...
* `get_the_archive_title()` and `the_archive_title()` for returning/displaying the title of the current term, date, post type, post format, or author archive.
* `get_the_archive_description()` and `the_archive_description()` for returning/displaying the description associated with the current term archive.
Fixes #21995
Props obenland, DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@30223
git-svn-id: http://core.svn.wordpress.org/trunk@30223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 00:35:22 +00:00
Ian Stewart
7a6ea1e83d
Twenty Fifteen: correct image alignment for RTL.
...
Props iamtakashi, fixes #30239 .
Built from https://develop.svn.wordpress.org/trunk@30222
git-svn-id: http://core.svn.wordpress.org/trunk@30222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 23:12:22 +00:00
Ian Stewart
7dfb040dde
Twenty Fifteen: check if user-selected custom colors are the same as default so we're not duplicating styles.
...
Props iamtakashi, fixes #30234
Built from https://develop.svn.wordpress.org/trunk@30221
git-svn-id: http://core.svn.wordpress.org/trunk@30221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:59:22 +00:00
Ian Stewart
8a930c93a8
Twenty Fifteen: Remove a gap between content and footer when the sidebar is longer than the content.
...
Props iamtakashi, fixes #30228 .
Built from https://develop.svn.wordpress.org/trunk@30220
git-svn-id: http://core.svn.wordpress.org/trunk@30220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:49:44 +00:00
Dominik Schilling
a17fd23e41
Customizer: Bind `input` and `propertychange` events for range input types.
...
props voldemortensen, westonruter.
fixes #30223 .
Built from https://develop.svn.wordpress.org/trunk@30219
git-svn-id: http://core.svn.wordpress.org/trunk@30219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:49:23 +00:00
Ian Stewart
9a3b7977fd
Twenty Fifteen: escaping for the HTML5 shiv call.
...
Props philiparthurmoore, fixes #30212
Built from https://develop.svn.wordpress.org/trunk@30218
git-svn-id: http://core.svn.wordpress.org/trunk@30218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:47:22 +00:00
Ian Stewart
3a0b05e5b1
Twenty Fifteen: kern everything -- it reads better.
...
Props afercia, fixes #30195 .
Built from https://develop.svn.wordpress.org/trunk@30217
git-svn-id: http://core.svn.wordpress.org/trunk@30217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:43:21 +00:00
Ian Stewart
6be421fb37
Twenty Fifteen: Use new core navigation tags.
...
Props obenland, iamtakashi, fixes #30189
Built from https://develop.svn.wordpress.org/trunk@30216
git-svn-id: http://core.svn.wordpress.org/trunk@30216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:40:23 +00:00
Ian Stewart
fe241e3fdc
Twenty Fifteen: Make sure that the edit link will always be right of it's icon.
...
Props iamtakashi, fixes #30171 .
Built from https://develop.svn.wordpress.org/trunk@30215
git-svn-id: http://core.svn.wordpress.org/trunk@30215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:36:23 +00:00
Dominik Schilling
73b4f6f449
Customizer: Add stable sorting for panels, sections and controls in JS. Improve sorting in PHP.
...
props westonruter.
fixes #30225 .
Built from https://develop.svn.wordpress.org/trunk@30214
git-svn-id: http://core.svn.wordpress.org/trunk@30214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:35:23 +00:00
Ian Stewart
4b23645ad4
Twenty Fifteen: nicer styles for playlists.
...
Props iamtakashi, fixes #30163
Built from https://develop.svn.wordpress.org/trunk@30213
git-svn-id: http://core.svn.wordpress.org/trunk@30213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 19:33:23 +00:00
Ian Stewart
cdfbccddb2
Twenty Fifteen: add a fallback icon for social links where we don't have an icon
...
Props iamtakashi, fixes #30148
Built from https://develop.svn.wordpress.org/trunk@30212
git-svn-id: http://core.svn.wordpress.org/trunk@30212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 19:02:22 +00:00
Ian Stewart
c1b360a665
Twenty Fifteen: prevent a flash of visible sub menus before scripts load.
...
Props mattwiebe, aferica, fixes #30056 .
Built from https://develop.svn.wordpress.org/trunk@30211
git-svn-id: http://core.svn.wordpress.org/trunk@30211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 18:58:23 +00:00
Boone Gorges
7919a6d812
Improve docblocks for `get_the_taxonomies()` and `the_taxonomies()`.
...
* In `the_taxonomies()`, only document those arguments that are specific to the function. Arguments shared with `get_the_taxonomies()` should be documented in the later function's docblock.
* Add $args hash documentation to `get_the_taxonomies()`.
* Remove the redundant default argument definition in `the_taxonomies()`.
Fixes #27238 .
Built from https://develop.svn.wordpress.org/trunk@30210
git-svn-id: http://core.svn.wordpress.org/trunk@30210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 18:49:45 +00:00
Boone Gorges
eec3eea392
Introduce `term_template` param to `get_the_taxonomies()`.
...
This parameter allows theme and plugin authors to specify the formatting they
would like on the term links as they are parsed into the taxonomy list.
Props hereswhatidid, dlh, davidjlaietta.
See #27238 .
Built from https://develop.svn.wordpress.org/trunk@30209
git-svn-id: http://core.svn.wordpress.org/trunk@30209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 18:49:24 +00:00
Ian Stewart
a46c99cf78
Twenty Fifteen: make it clear that a link is a link in post and comment meta by underlining it on hover or focus
...
Props morganestes, iamtakashi, fixes #30108
Built from https://develop.svn.wordpress.org/trunk@30208
git-svn-id: http://core.svn.wordpress.org/trunk@30208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 17:01:23 +00:00
Boone Gorges
89526ca7f1
Ignore case when checking string 'false' in `wp_validate_boolean()`.
...
Props TobiasBg, kitchin.
Fixes #30238 .
Built from https://develop.svn.wordpress.org/trunk@30207
git-svn-id: http://core.svn.wordpress.org/trunk@30207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 15:55:23 +00:00
Boone Gorges
99c5817822
Add unit tests for `wp_validate_boolean()`.
...
Props TobiasBg.
See #30238 .
Built from https://develop.svn.wordpress.org/trunk@30206
git-svn-id: http://core.svn.wordpress.org/trunk@30206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 15:52:21 +00:00
Boone Gorges
fc4b17a5d2
In `in_object_in_term()`, only check numeric string values against term_id.
...
The previous `in_array()` check was playing too loose with mixed types, such
that a string like '10_term_name' would incorrectly match a term_id 10.
Props nobinobi, realloc.
Fixes #29467 .
Built from https://develop.svn.wordpress.org/trunk@30205
git-svn-id: http://core.svn.wordpress.org/trunk@30205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 14:25:44 +00:00
Boone Gorges
d2a8ae2544
Add some unit tests for `is_object_in_term()`.
...
These tests check a number of the ways that different kinds of values for
`$terms` (integers that match term_id, strings that match term_id or name or
slug) are handled.
See #29467 .
Built from https://develop.svn.wordpress.org/trunk@30204
git-svn-id: http://core.svn.wordpress.org/trunk@30204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 14:25:22 +00:00
Scott Taylor
5e3a64e83d
Correct some types in `wp-admin/*`-location files' doc blocks.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30203
git-svn-id: http://core.svn.wordpress.org/trunk@30203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 07:09:23 +00:00
Scott Taylor
7d7a8aa0eb
Correct all `@return unknown` instances.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30202
git-svn-id: http://core.svn.wordpress.org/trunk@30202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:17:22 +00:00
Scott Taylor
bd2521d5ee
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/deprecated.php` (pour one out).
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30201
git-svn-id: http://core.svn.wordpress.org/trunk@30201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:08:22 +00:00
Scott Taylor
196d85a9f6
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/misc.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30200
git-svn-id: http://core.svn.wordpress.org/trunk@30200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:01:24 +00:00
Scott Taylor
37f94bdfd0
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/plugin.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30199
git-svn-id: http://core.svn.wordpress.org/trunk@30199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:59:22 +00:00
Scott Taylor
64167f0845
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/post.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30198
git-svn-id: http://core.svn.wordpress.org/trunk@30198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:55:22 +00:00
Scott Taylor
d9d825db72
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/taxonomy.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30197
git-svn-id: http://core.svn.wordpress.org/trunk@30197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:50:23 +00:00
Scott Taylor
06f49a43a1
Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/template.php`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30196
git-svn-id: http://core.svn.wordpress.org/trunk@30196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:45:24 +00:00
Scott Taylor
5a3256c00b
Fill in the `@param` types for the args for `make_site_theme_from_default()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30195
git-svn-id: http://core.svn.wordpress.org/trunk@30195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:43:21 +00:00
Scott Taylor
ef944e8c19
Fill in the `@param` types for the args for `make_site_theme_from_oldschool()`, which is actually the name of a function?
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30194
git-svn-id: http://core.svn.wordpress.org/trunk@30194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:41:23 +00:00
Scott Taylor
082a1d06ae
Fill in the `@param` types for the args for `dbDelta()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30193
git-svn-id: http://core.svn.wordpress.org/trunk@30193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:40:22 +00:00
Scott Taylor
150b4e5157
Fill in the `@param` types for the args in `WP_Text_Diff_Renderer_Table->interleave_changed_lines()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30192
git-svn-id: http://core.svn.wordpress.org/trunk@30192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:39:22 +00:00
Scott Taylor
3e4ca28eb9
Correct the `@param` type for the `$query` arg for `remove_query_arg()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30191
git-svn-id: http://core.svn.wordpress.org/trunk@30191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:29:22 +00:00
Scott Taylor
8eee18ec0e
Fill in types for the `@param`s for `wp_comment_reply()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30190
git-svn-id: http://core.svn.wordpress.org/trunk@30190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:21:22 +00:00
Scott Taylor
63c55ae93c
Correct type in the doc block for `get_theme_support()`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30189
git-svn-id: http://core.svn.wordpress.org/trunk@30189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:18:22 +00:00