Commit Graph

30783 Commits

Author SHA1 Message Date
Dion Hulse cbacb92dae Enable utf8mb4 for MySQL extension users. Previously utf8mb4 was limited to MySQLi users only unintentionally.
This change does the following things
 * Allows utf8mb4 for the MySQL extension
 * Re-runs the utf8->utf8mb4 conversion for single sites, this will do nothing for tables already converted
 * Re-runs the utf8->utf8mb4 conversion for global tables in multisite when the environment supports utf8mb4
 * Removes upgrade_420() calling as upgrade_430() will perform those changes now instead

The index shortenings should have still taken place on utf8 sites previously, so there's no need to run those again. 

Props kovshenin, pento, dd32
Fixes #32127 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33055


git-svn-id: http://core.svn.wordpress.org/trunk@33026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 03:26:24 +00:00
Konstantin Obenland a4e803fbd4 Use `get_default_comment_status()` globally.
Also makes the filter name static and passes the post type for context.

Props valendesigns.
Fixes #31168.


Built from https://develop.svn.wordpress.org/trunk@33054


git-svn-id: http://core.svn.wordpress.org/trunk@33025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 22:32:25 +00:00
Konstantin Obenland cd7a40bdc7 Site Icon: Improve responsiveness for small screen devices.
Using Jcrop's `trueSize` argument also allows us to get rid of all that behind
the scenes temp image creating and back and forth calculating of image sizes.

Props tyxla for initial patch.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33053


git-svn-id: http://core.svn.wordpress.org/trunk@33024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 21:16:24 +00:00
Sergey Biryukov 3fb3d2a762 Replace `@returns` with `@return` in PHP docblocks.
props kraftbj.
fixes #32865.
Built from https://develop.svn.wordpress.org/trunk@33052


git-svn-id: http://core.svn.wordpress.org/trunk@33023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 21:05:24 +00:00
Konstantin Obenland 0d270f67c2 Site Icon: Skip cropping if image has the correct size.
Props jipmoors for initial patch.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33051


git-svn-id: http://core.svn.wordpress.org/trunk@33022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 20:40:25 +00:00
Konstantin Obenland f2ce96004a Add missing prefixed attributes, introduced in [33023].
See ##32589.

Built from https://develop.svn.wordpress.org/trunk@33050


git-svn-id: http://core.svn.wordpress.org/trunk@33021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 17:40:25 +00:00
Konstantin Obenland bcf488fc23 Site Icon: Show correct background preview for transparent images.
iOS will show transparent parts as black, where as the icon itself stays
transparent when used as a favicon.

See #16434.

Built from https://develop.svn.wordpress.org/trunk@33049


git-svn-id: http://core.svn.wordpress.org/trunk@33020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 17:16:26 +00:00
Sergey Biryukov 4cba374f44 Make "Preformatted" string in TinyMCE translatable.
props iseulde.
fixes #32862.
Built from https://develop.svn.wordpress.org/trunk@33048


git-svn-id: http://core.svn.wordpress.org/trunk@33019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 12:01:24 +00:00
Sergey Biryukov f59f2a8e4f Restore `rel='nofollow'` for comment reply links to reduce extra crawling by search engines.
This reverts [16230], which didn't have enough review at the time of commit.

props joostdevalk.
see #22889, #18547, #16881.
Built from https://develop.svn.wordpress.org/trunk@33047


git-svn-id: http://core.svn.wordpress.org/trunk@33018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 11:09:25 +00:00
Konstantin Obenland c919a1c1e9 4.3-beta1-33046
Built from https://develop.svn.wordpress.org/trunk@33046


git-svn-id: http://core.svn.wordpress.org/trunk@33017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 01:36:26 +00:00
Helen Hou-Sandí d0e47d56ee Customizer: Build flips the panel arrow for RTL on our behalf.
see #31336.

Built from https://develop.svn.wordpress.org/trunk@33045


git-svn-id: http://core.svn.wordpress.org/trunk@33016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 01:29:25 +00:00
Konstantin Obenland 5aba96c3b4 4.3-beta1
Built from https://develop.svn.wordpress.org/trunk@33044


git-svn-id: http://core.svn.wordpress.org/trunk@33015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 01:22:24 +00:00
Sergey Biryukov da2745369a Update `test_filter_wp_nav_menu_args()` after [33035].
see #32781.
Built from https://develop.svn.wordpress.org/trunk@33043


git-svn-id: http://core.svn.wordpress.org/trunk@33014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 01:18:24 +00:00
Mark Jaquith cf38b016e8 Revert [33038] because of objections raised on #22889 and #31590
Built from https://develop.svn.wordpress.org/trunk@33042


git-svn-id: http://core.svn.wordpress.org/trunk@33013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 00:47:24 +00:00
Konstantin Obenland edffcb0bcd Turn of comments for pages by default.
Pages are static content, for which comments are not expected out of the box.

Props valendesigns, rachelbaker.
Fixes #31168.


Built from https://develop.svn.wordpress.org/trunk@33041


git-svn-id: http://core.svn.wordpress.org/trunk@33012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 00:22:24 +00:00
Konstantin Obenland a193eb3ec7 Prevent link to customizer from wrpping on small screens.
Fixes #32808.

Built from https://develop.svn.wordpress.org/trunk@33040


git-svn-id: http://core.svn.wordpress.org/trunk@33011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 23:36:26 +00:00
Mark Jaquith d51f1c1a0f Restore `$noreplytext` default value in `comment_form_title()`
props ocean90
see #22889
Built from https://develop.svn.wordpress.org/trunk@33039


git-svn-id: http://core.svn.wordpress.org/trunk@33010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 21:51:25 +00:00
Mark Jaquith 9d11efe23c Say goodbye to ?replytocom=123 links and their URL pollution.
* Comment reply links continue to use JS as before.
* ?replytocom=123 links are deprecated.

props joostdevalk
fixes #22889
Built from https://develop.svn.wordpress.org/trunk@33038


git-svn-id: http://core.svn.wordpress.org/trunk@33009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 21:42:25 +00:00
Dominik Schilling 85d7261305 Site icon: Remove option name from `$whitelist_options` for the general options screen.
The option gets saved in `WP_Site_Icon->set_site_icon()`.

fixes #32859.
Built from https://develop.svn.wordpress.org/trunk@33037


git-svn-id: http://core.svn.wordpress.org/trunk@33008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 21:41:26 +00:00
Weston Ruter 8f03622640 Customizer: Add link to Widgets panel from Menus panel description.
Props celloexpressions.
Fixes #32742.


Built from https://develop.svn.wordpress.org/trunk@33036


git-svn-id: http://core.svn.wordpress.org/trunk@33007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 19:35:25 +00:00
Sergey Biryukov 52db28396c Customizer: Avoid PHP notices after [32806].
props adamsilverstein, westonruter.
fixes #32781.
Built from https://develop.svn.wordpress.org/trunk@33035


git-svn-id: http://core.svn.wordpress.org/trunk@33006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 19:08:24 +00:00
Mark Jaquith 04793dce34 Fix small typo from [33019].
see #32429
Built from https://develop.svn.wordpress.org/trunk@33034


git-svn-id: http://core.svn.wordpress.org/trunk@33005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 18:16:24 +00:00
Mark Jaquith 504101460f Slow down on calling zxcvbn if it isn't loaded.
see #32589
Built from https://develop.svn.wordpress.org/trunk@33033


git-svn-id: http://core.svn.wordpress.org/trunk@33004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 18:13:24 +00:00
Konstantin Obenland b4a86c0f50 Add additional escaping to credits page.
Props Viper007Bond, gtuk for initial patch.
Fixes #21523.


Built from https://develop.svn.wordpress.org/trunk@33032


git-svn-id: http://core.svn.wordpress.org/trunk@33003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 17:22:24 +00:00
Mark Jaquith cb93e24c62 Add a missing "var". see #32589
Built from https://develop.svn.wordpress.org/trunk@33031


git-svn-id: http://core.svn.wordpress.org/trunk@33002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 17:16:25 +00:00
Dominik Schilling 78167b8a4c Customizer: Make reordering menu items via drag and drop easier.
Introduce `wpNavMenu.options.targetTolerance` to define a tolerance when dragging items where no margins between the sortable items exists.

props adamsilverstein.
fixes #32821.
Built from https://develop.svn.wordpress.org/trunk@33030


git-svn-id: http://core.svn.wordpress.org/trunk@33001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 16:44:24 +00:00
Jeremy Felt b837d374bf Trim trailing space from string in site delete confirmation
Props yoavf.
Fixes #32853.

Built from https://develop.svn.wordpress.org/trunk@33029


git-svn-id: http://core.svn.wordpress.org/trunk@33000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 16:31:25 +00:00
Dominik Schilling 8430848b6d Customizer: Fix height calculation of placeholders when dragging menu items.
props adamsilverstein.
fixes #32857.
Built from https://develop.svn.wordpress.org/trunk@33028


git-svn-id: http://core.svn.wordpress.org/trunk@32999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 16:20:26 +00:00
Dominik Schilling 699dbedb03 l10n: Update `wp_get_installed_translations()` to support variants of a language.
* A variant of a language has its own locale, for example the locale of the formal variant of German is `de_DE_formal`.
* Update `remove_accents()` and some CSS rules to support `de_DE_formal`.
* Add tests for `get_bloginfo( 'language' )`.
* API changes will be deployed over the next few days.

see #28303.
Built from https://develop.svn.wordpress.org/trunk@33027


git-svn-id: http://core.svn.wordpress.org/trunk@32998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 15:43:24 +00:00
Konstantin Obenland d9c5529d30 Improve the tone of key/salts recommendation message.
Also adds some inline comments to make it easier to understand how it
is determined whether to show the message or not.

Props helen.
Fixes #20779.


Built from https://develop.svn.wordpress.org/trunk@33026


git-svn-id: http://core.svn.wordpress.org/trunk@32997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 15:39:26 +00:00
Scott Taylor 2b513bf60a `wp_audio|video_shortcode()` doesn't allow you to pass `id`, the docs shall reflect that.
Props thorbrink.
See #32855.

Built from https://develop.svn.wordpress.org/trunk@33025


git-svn-id: http://core.svn.wordpress.org/trunk@32996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 15:01:26 +00:00
Konstantin Obenland d03ff4b3d9 Close comment quick edit before updating a post.
Fixes a bug where the user gets redirected to the All Posts screen, after
updating a post while quick editing a comment.

Props polevaultweb.
Fixes #29457.


Built from https://develop.svn.wordpress.org/trunk@33024


git-svn-id: http://core.svn.wordpress.org/trunk@32995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 14:54:24 +00:00
Mark Jaquith 423a1a7ca4 New password change/set UI.
* Generate the password for the user
* More tightly integrate password strength meter
* Warn on weak passwords

see #32589

props MikeHansenMe, adamsilverstein, binarykitten
Built from https://develop.svn.wordpress.org/trunk@33023


git-svn-id: http://core.svn.wordpress.org/trunk@32994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 14:48:24 +00:00
Boone Gorges b1bd2e699d Don't allow `$field` param to be passed to `get_term_link()`.
The new parameter creates inconsistencies in the signatures of the various
functions for fetching term links (`get_term_feed_link()`,
`get_edit_term_link()`, etc.).

Reverts [32553].

See #14156.
Built from https://develop.svn.wordpress.org/trunk@33022


git-svn-id: http://core.svn.wordpress.org/trunk@32993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 12:54:25 +00:00
Boone Gorges ca390b2fb5 Allow 'comment_agent' and 'comment_author_IP' to be set via `wp_new_comment()`.
Props mrutz, wonderboymusic, rachelbaker.
Fixes #14601.
Built from https://develop.svn.wordpress.org/trunk@33021


git-svn-id: http://core.svn.wordpress.org/trunk@32992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 12:08:25 +00:00
Dion Hulse ebb6aa1d4a Split `upgrade_430()` into two so that `split_all_shared_terms()` runs when `upgrade_430_fix_comments()` bails early.
See [32814], #30261, [32364], #32165

Built from https://develop.svn.wordpress.org/trunk@33020


git-svn-id: http://core.svn.wordpress.org/trunk@32991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 07:35:24 +00:00
Dion Hulse c261ad2c57 Expire password reset links after 24 hours (by default). This causes existing password reset links to become invalid.
Props markjaquith, voldemortensen, johnbillion, MikeHansenMe, dd32
See #32429

Built from https://develop.svn.wordpress.org/trunk@33019


git-svn-id: http://core.svn.wordpress.org/trunk@32990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 06:33:26 +00:00
Konstantin Obenland 8e57bef0ee After [32866], change filter name.
While filter names generally don't have to be tied to the function in which they 
are applied, the API for media display generally seems to use the
`wp_get_attachment_*` pattern.

Props DrewAPicture.
Fixes #32363.


Built from https://develop.svn.wordpress.org/trunk@33018


git-svn-id: http://core.svn.wordpress.org/trunk@32989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 03:47:24 +00:00
Helen Hou-Sandí 275bff1895 Fire the `check_admin_referer` action on failure as well as success.
This enables things like logging nonce failures in the admin.

props markjaquith.
fixes #32207.

Built from https://develop.svn.wordpress.org/trunk@33017


git-svn-id: http://core.svn.wordpress.org/trunk@32988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 03:37:23 +00:00
Helen Hou-Sandí 8eb7f71e6b List tables: A better responsive view.
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.

Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.

props Michael Arestad, helen.
see #32395.

Built from https://develop.svn.wordpress.org/trunk@33016


git-svn-id: http://core.svn.wordpress.org/trunk@32987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 01:31:25 +00:00
Helen Hou-Sandí 8f85bb1ac5 Bulk/quick edit: Set the correct colspan.
`thead` can contain `td`s now, too.

props afercia.
fixes #31654.

Built from https://develop.svn.wordpress.org/trunk@33015


git-svn-id: http://core.svn.wordpress.org/trunk@32986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 01:06:25 +00:00
Konstantin Obenland e460d37da0 Open closed widget areas when dragging onto them.
Allows dropping Widgets into the correct spot of a given sidebar, no matter
whether that sidebar is open or closed. Removes a step from the setup process
for closed sidebars.

Props polevaultweb.
Fixes #13524.


Built from https://develop.svn.wordpress.org/trunk@33014


git-svn-id: http://core.svn.wordpress.org/trunk@32985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 00:58:24 +00:00
Andrew Ozz 5919fdd4c9 TinyMCE: update to 4.2.1. Changelog: https://github.com/tinymce/tinymce-dist/blob/master/changelog.txt.
Fixes #32801.
Built from https://develop.svn.wordpress.org/trunk@33013


git-svn-id: http://core.svn.wordpress.org/trunk@32984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 00:52:25 +00:00
Konstantin Obenland ec407bc971 Customizer: Fresh colors for Reorder Done button.
When reordering Widgets or Menus, the red colorcould suggest
it would cancel the changes, rather than save them. The blue
suggests it's clickable and is more in line with the Close
link on open Widgets.

Fixes #32811.


Built from https://develop.svn.wordpress.org/trunk@33012


git-svn-id: http://core.svn.wordpress.org/trunk@32983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 00:19:24 +00:00
Konstantin Obenland f18fabc300 Site Icon: Move admin icon filter to its rightful place.
The action is unrelated to `WP_Site_Icon` itself.

Props kraftbj.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33011


git-svn-id: http://core.svn.wordpress.org/trunk@32982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 23:26:25 +00:00
Dominik Schilling 7cc9a4c092 Plugins list table: Sort plugins by `Name` by default so translated plugin names get correctly sorted.
props swissspidy.
fixes #32735.
Built from https://develop.svn.wordpress.org/trunk@33010


git-svn-id: http://core.svn.wordpress.org/trunk@32981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 22:31:25 +00:00
Andrew Ozz d986bbbf42 Squish that .png a bit more. See [32994].
Built from https://develop.svn.wordpress.org/trunk@33009


git-svn-id: http://core.svn.wordpress.org/trunk@32980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 22:04:25 +00:00
Dominik Schilling 86ebc13446 Remove unnecessary feedback message from `WP_Importer::is_user_over_quota()`.
fixes #32021.
Built from https://develop.svn.wordpress.org/trunk@33008


git-svn-id: http://core.svn.wordpress.org/trunk@32979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 20:32:25 +00:00
Dominik Schilling b214be20ad Make `WP_Locale::rtl_src_admin_notice()` translatable.
props jrf.
see #32021.
Built from https://develop.svn.wordpress.org/trunk@33007


git-svn-id: http://core.svn.wordpress.org/trunk@32978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 20:21:24 +00:00
Dominik Schilling 54424e9755 wpdb: Make "WordPress database error:" translatable.
props jrf.
see #32021.
Built from https://develop.svn.wordpress.org/trunk@33006


git-svn-id: http://core.svn.wordpress.org/trunk@32977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 20:00:25 +00:00