Gary Pendergast
f6120877df
If the URL being visited has non-breaking spaces at the end of it, they were probably inserted by an errant URL copy/paste. Instead of showing a 404 for no obvious reason, let's just trim them.
...
Fixes #31499
Built from https://develop.svn.wordpress.org/trunk@31838
git-svn-id: http://core.svn.wordpress.org/trunk@31820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 01:02:28 +00:00
Sergey Biryukov
612b9e8ffd
Replace hardcoded usage of `comment-page` with the comment pagination base.
...
props johnbillion, SergeyBiryukov, webord.
fixes #18084 .
Built from https://develop.svn.wordpress.org/trunk@31459
git-svn-id: http://core.svn.wordpress.org/trunk@31440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-14 03:48:27 +00:00
Scott Taylor
fc843ce4d0
There are some random `add_action()` and `add_filter()` calls littered around some files in `wp-includes/`. These should be moved to `wp-includes/default-filters.php` with the rest of the registered hooks. It seems like this was the best practice for awhile and then we randomly stopped. This file loads way before any of the includes, so the hooks will be registered for any request that loads WordPress, even `SHORTINIT` - a lot of the hooks registered won't run anyways (that's already the case).
...
See #30947 .
Built from https://develop.svn.wordpress.org/trunk@31168
git-svn-id: http://core.svn.wordpress.org/trunk@31149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:40:23 +00:00
Scott Taylor
e619abda6e
Improve various `@param` docs for `src/wp-includes/*`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30681
git-svn-id: http://core.svn.wordpress.org/trunk@30671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 01:34:24 +00:00
Drew Jaynes
66c47f29bb
Correct references of `@uses $wpdb` in core documentation to use `@global`.
...
See #30191 , [30105].
Fixes #30217 .
Built from https://develop.svn.wordpress.org/trunk@30122
git-svn-id: http://core.svn.wordpress.org/trunk@30122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-31 17:56:22 +00:00
John Blackbourn
9a16b52018
Revert [28610] in order to avoid infinite redirect loops on reverse proxies which proxy from HTTPS to HTTP. This will be revisited at some point, possibly as an option via a filter.
...
Fixes #28610 .
Built from https://develop.svn.wordpress.org/trunk@30090
git-svn-id: http://core.svn.wordpress.org/trunk@30090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 18:37:25 +00:00
Boone Gorges
295f5fc9de
Support nested tax query syntax in redirect_canonical().
...
The proper place to look for a list of queried terms is in the flat
queried_terms array, not in tax_query->queries.
See #29738 .
Built from https://develop.svn.wordpress.org/trunk@29901
git-svn-id: http://core.svn.wordpress.org/trunk@29656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 15:43:19 +00:00
Mark Jaquith
e1f2b3b9e2
Use HTTPS URLs for trac.wordpress.org (and use core.trac.wordpress.org)
...
see #27115
Built from https://develop.svn.wordpress.org/trunk@29789
git-svn-id: http://core.svn.wordpress.org/trunk@29561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 13:37:16 +00:00
Andrew Nacin
4417e75e2c
Canonical: Apply redirects to HEAD requests too. Adjusts [28958].
...
props SergeyBiryukov.
fixes #27498 .
Built from https://develop.svn.wordpress.org/trunk@29663
git-svn-id: http://core.svn.wordpress.org/trunk@29437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 04:48:17 +00:00
Sergey Biryukov
f84ef60b52
Canonical redirects should only be applied for GET requests.
...
props c.axelsson.
fixes #27498 .
Built from https://develop.svn.wordpress.org/trunk@28958
git-svn-id: http://core.svn.wordpress.org/trunk@28754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-02 14:11:14 +00:00
Sergey Biryukov
ca650bd79c
Replace a redundant ! is_preview() check with a more appropriate one.
...
fixes #20496 .
Built from https://develop.svn.wordpress.org/trunk@28928
git-svn-id: http://core.svn.wordpress.org/trunk@28726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-30 17:19:14 +00:00
Sergey Biryukov
a6a2183bf6
Fix typo in a comment.
...
props JustinSainton.
see #20496 .
Built from https://develop.svn.wordpress.org/trunk@28878
git-svn-id: http://core.svn.wordpress.org/trunk@28677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-28 03:30:16 +00:00
Scott Taylor
a60b01b138
Perform a canonical redirect for posts that are published but are visited at a `?p=123&preview=true` URL.
...
Props amit, joostdevalk.
Fixes #20496 .
Built from https://develop.svn.wordpress.org/trunk@28874
git-svn-id: http://core.svn.wordpress.org/trunk@28673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-28 02:13:15 +00:00
Scott Taylor
05eeb16e30
Replace all uses of `like_escape()` with `$wpdb->esc_like()`.
...
Props miqrogroove.
See #10041 .
Built from https://develop.svn.wordpress.org/trunk@28712
git-svn-id: http://core.svn.wordpress.org/trunk@28528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-10 00:44:15 +00:00
Andrew Nacin
801df52e51
Force SSL on the frontend via canonical when the home URL uses the https scheme.
...
fixes #27954 .
Built from https://develop.svn.wordpress.org/trunk@28610
git-svn-id: http://core.svn.wordpress.org/trunk@28434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-29 04:13:13 +00:00
Drew Jaynes
d77e78d685
Clean up duplicate hook notations and adjacency for calls to the `wp_signup_location` filter.
...
Also adds braces missed in [25535].
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28215
git-svn-id: http://core.svn.wordpress.org/trunk@28045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 07:12:14 +00:00
Drew Jaynes
cd8cedc40d
First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
...
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713 .
Built from https://develop.svn.wordpress.org/trunk@26868
git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-24 18:57:12 +00:00
Andrew Nacin
5361a8abca
Spell out duplicate hook locations.
...
props DrewAPicture.
fixes #25658 .
Built from https://develop.svn.wordpress.org/trunk@25868
git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:20 +00:00
Andrew Nacin
8ae8e01b67
Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
...
see #27704 .
Built from https://develop.svn.wordpress.org/trunk@25825
git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin
74488bdcb0
Spell out duplicate hook locations.
...
props DrewAPicture.
fixes #25658 .
Built from https://develop.svn.wordpress.org/trunk@25868
git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
Drew Jaynes
0931266fc2
Inline documentation for hooks in wp-includes/canonical.php.
...
Props dustyf for the initial patch.
See #25229 .
Built from https://develop.svn.wordpress.org/trunk@25535
git-svn-id: http://core.svn.wordpress.org/trunk@25455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-20 23:31:10 +00:00
Scott Taylor
b22bc5e389
Check bad dates and redirect, instead of 404ing, as necessary and appropriate.
...
Adds query, conditional, and canonical Unit Tests.
Props kovshenin, SergeyBiryukov, DrewAPicture.
Fixes #10935 .
Built from https://develop.svn.wordpress.org/trunk@25280
git-svn-id: http://core.svn.wordpress.org/trunk@25244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 16:36:09 +00:00
Andrew Nacin
740d141e1d
Support IIS 8 and above.
...
props hurtige for initial patch.
fixes #23533 .
git-svn-id: http://core.svn.wordpress.org/trunk@24594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 20:27:06 +00:00
Sergey Biryukov
8792da0820
Use correct backreference in obsolete feed redirection code. props sweetie089. fixes #24623 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-22 12:09:28 +00:00
Mark Jaquith
a24c40fb00
Consistently use $wp_rewrite->index instead of hardcoding "index.php".
...
props wonderboymusic. fixes #7337
git-svn-id: http://core.svn.wordpress.org/trunk@23305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-18 13:44:22 +00:00
Andrew Nacin
87c947a987
Use network_site_url() for wp-signup.php. props markjaquith. see #19796 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 12:27:25 +00:00
markjaquith
c7029bb742
Also switch back the @uses annotation for [21215]. props duck_. see #20484 . see #16639
...
git-svn-id: http://core.svn.wordpress.org/trunk@21217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-05 20:09:28 +00:00
markjaquith
9b8ca25445
Implement the IIS logic test that #16639 should have gotten back in the day, before it was disabled altogether. IIS canonical redirects now only supported for pretty permalink–supporting IIS7 installs. props nacin. fixes #20484 . see #16639
...
git-svn-id: http://core.svn.wordpress.org/trunk@21215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-05 19:59:35 +00:00
markjaquith
7b66f555a4
Reënable canonical redirects for IIS. Let's work out any remaining bugs in this cycle. fixes #20484 . reverts [17492]. see #16639
...
git-svn-id: http://core.svn.wordpress.org/trunk@21207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-05 13:23:39 +00:00
duck_
176317abcf
Set $walk_dirs = true for post rewrite rule generation. See #21020 for trunk.
...
Partial revert of r19737 and r19778 as some users were relying on this behaviour.
git-svn-id: http://core.svn.wordpress.org/trunk@21112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-25 20:41:14 +00:00
nacin
4144452598
Only look for public post types in redirect_guess_404_permalink() when no post type query var is present. props jeremyfelt. fixes #19693 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@20688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-02 17:39:43 +00:00
duck_
6fd24edbec
Prevent a notice: don't attempt to parse the query string if it doesn't exist. Props johnjamesjacoby. Fixes #20528 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-01 18:26:38 +00:00
nacin
3f51df65e0
Run rawurlencode_deep() through the parsed query in canonical. (Introduces rawurlencode_deep().) props toppa for the initial patch. fixes #20143 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-27 15:40:00 +00:00
nacin
548baad816
Remove wp-register.php.
...
* Don't remove it on update. If you have it now, you'll keep it. New installs won't get it.
* Peform a redirect using rewrite + canonical to the new location, if the file doesn't exist.
props SergeyBiryukov.
fixes #18544 .
git-svn-id: http://svn.automattic.com/wordpress/trunk@20596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-25 20:49:57 +00:00
ryan
1b65e28f8f
Don't do a canonical redirect for singular paged pages when on the front-page. This was breaking pagination on sites with a static home page. Props batmoo. see #20385
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-11 21:18:40 +00:00
markjaquith
170ce91194
Handle page= and feed= query strings in redirect_guess_404_permalink(). fixes #20387
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-07 05:39:08 +00:00
markjaquith
5ccce3d681
Properly handle paged permalink URLs even when we are not already 301ing. fixes #20385
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-07 05:18:50 +00:00
markjaquith
a2b1c52214
Fix a bunch of individual post comments feeds canonical redirects. Fixes three unit tests. fixes #20384
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-07 05:02:45 +00:00
markjaquith
446a67449f
Better removal of query args in canonical redirects. Only remove them when they are not present in the redirect_url. fixes #20374
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-07 01:03:55 +00:00
markjaquith
2c87af1983
Be a bit more conservative in which args are stripped after redirect_guess_404_permalink(). see #20380 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-06 21:19:28 +00:00
markjaquith
2bca2af5fd
Strip p, page_id, attachment_id, post_type, pagename, and name from redirect query if we get a hit on a 404-guessed permalink. fixes #20374
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-06 19:49:34 +00:00
duck_
7a6b978b7f
Ensure that a category is part of the query before redirecting permalink structures containing %category%. Fixes #19241 .
...
This fixes incorrect canonical redirects for singular queries using custom rewrite rules.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-21 19:00:06 +00:00
nacin
d06722b8ac
In case of 404, redirect /login, /dashboard, /admin to corresponding WP equivalents. fixes #19607 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 20:11:52 +00:00
nacin
6300514de7
Let wp-admin work as well as wp-admin/ for the canonical redirect. see #19607 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 18:03:25 +00:00
nacin
71c82d0eaf
Use correct variable. see #19607 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 17:14:52 +00:00
nacin
ef1e76a833
When WordPress is in a subdirectory (home URL != site URL), let home/wp-admin and home/wp-login.php redirect to their proper locations. props greuben for initial patch, fixes #19607 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 17:08:13 +00:00
duck_
779cf2bad5
Redirect bare category URLs for permalink structures starting with %category%. Fixes #19876 .
...
When using a structure like /%category%/%postname%/ it might be thought that /uncategorized/
(missing the "/category/" base) results in the category archive. Previously this worked due to
$walk_dirs = true for the post permalink structure, but canonical didn't redirect it. Now
there is no rewrite rule to match => 404. The fix is to use a canonical redirect.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-28 20:40:55 +00:00
ryan
e3b46b25d3
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan
83b131f8e3
User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:50:54 +00:00
nacin
15ff65a694
Restore RDF feed. fixes #4967 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-20 18:32:42 +00:00