Scott Taylor
52516a68ab
After the `global` churn in [33964], also set `$post` to `null` at the end of `WP_Comments_List_Table::single_row()` to ensure that an orphaned comment doesn't inherit the previous row's `$post` context.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@33986
git-svn-id: http://core.svn.wordpress.org/trunk@33955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 03:12:23 +00:00
Scott Taylor
2c21d12232
Implement a priority system for Help Tabs to add them at specific positions.
...
Adds unit tests.
Props swissspidy.
Fixes #19828 .
Built from https://develop.svn.wordpress.org/trunk@33985
git-svn-id: http://core.svn.wordpress.org/trunk@33954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 01:27:23 +00:00
Scott Taylor
b8c37073d8
Add `@access` docs to `class-wp-filesystem-*` files.
...
Props wenthemes.
Fixes #33725 .
Built from https://develop.svn.wordpress.org/trunk@33984
git-svn-id: http://core.svn.wordpress.org/trunk@33953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 01:21:24 +00:00
Drew Jaynes
55f3b892fb
Docs: Add a changelog entry to the DocBlock for `touch_time()` to mention the shift from accessing the global `$comment` to using `get_comment()`.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@33979
git-svn-id: http://core.svn.wordpress.org/trunk@33948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 15:48:25 +00:00
Scott Taylor
02ae926dfd
Round 2 of: We should use ellipses … / … instead of three dots/periods ... e.g Loading… not Loading...
...
Props yoavf.
Fixes #32875 .
Built from https://develop.svn.wordpress.org/trunk@33970
git-svn-id: http://core.svn.wordpress.org/trunk@33939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 04:39:25 +00:00
Scott Taylor
246f2a6bd9
Use `get_comment()` instead of a global in `touch_time()`.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@33965
git-svn-id: http://core.svn.wordpress.org/trunk@33934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 03:05:24 +00:00
Scott Taylor
71f955dc84
In `WP_Comments_List_Table`, favor passing `WP_Comment` instances instead of `$comment_ID` to template functions. This allows us to bypass unnecessary cache lookups and simply pass the object through when it is set.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@33964
git-svn-id: http://core.svn.wordpress.org/trunk@33933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 03:00:24 +00:00
Scott Taylor
d973339738
After [33891], `get_comment()` returns `global $comment` if no args are passed and the global is set (after setting the default to `null` here). This allows us to ditch global comment imports.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@33963
git-svn-id: http://core.svn.wordpress.org/trunk@33932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 02:51:24 +00:00
Scott Taylor
8879565c0a
In `WP_User`, add `@property` docs for `description`, `first_name`, and `last_name`. `user_firstname` and `user_lastname` only exist for back-compat.
...
See #33491 .
Built from https://develop.svn.wordpress.org/trunk@33958
git-svn-id: http://core.svn.wordpress.org/trunk@33927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 01:13:24 +00:00
Sergey Biryukov
a3f82f92f1
Widgets: Don't display sidebar description container if it's empty.
...
Props paulwilde.
Fixes #32448 .
Built from https://develop.svn.wordpress.org/trunk@33934
git-svn-id: http://core.svn.wordpress.org/trunk@33903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-06 07:59:24 +00:00
Sergey Biryukov
c177344508
Merge two permission error strings.
...
Props pavelevap.
Fixes #33745 .
Built from https://develop.svn.wordpress.org/trunk@33933
git-svn-id: http://core.svn.wordpress.org/trunk@33902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-06 06:42:26 +00:00
Sergey Biryukov
c65f37f892
Correct description for `version` and `current_version` parameters in `wp_check_browser_version()` response.
...
Props extendwings.
Fixes #33753 .
Built from https://develop.svn.wordpress.org/trunk@33932
git-svn-id: http://core.svn.wordpress.org/trunk@33901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-06 00:17:24 +00:00
Sergey Biryukov
4b5ef333a0
Correct the docblock for `wp_list_widget_controls()`.
...
Props swissspidy.
Fixes #33751 .
Built from https://develop.svn.wordpress.org/trunk@33930
git-svn-id: http://core.svn.wordpress.org/trunk@33899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 23:38:25 +00:00
Sergey Biryukov
465e348c12
Fix closing div in `wp_print_request_filesystem_credentials_modal()`.
...
Props trepmal.
Fixes #33737 .
Built from https://develop.svn.wordpress.org/trunk@33908
git-svn-id: http://core.svn.wordpress.org/trunk@33877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 15:17:24 +00:00
Boone Gorges
cc5eddda74
Allow `wp_terms_checklist()` to return markup rather than echoing it.
...
Props kevinlangleyjr.
Fixes #33720 .
Built from https://develop.svn.wordpress.org/trunk@33904
git-svn-id: http://core.svn.wordpress.org/trunk@33873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 21:25:25 +00:00
Scott Taylor
80a20e5c3d
Handle more cases (`untrailingslashit`, HTTPS urls) for sanitizing an author URL for display in the comments list table.
...
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291 .
Built from https://develop.svn.wordpress.org/trunk@33894
git-svn-id: http://core.svn.wordpress.org/trunk@33863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 23:23:24 +00:00
Scott Taylor
e73ee5ac98
Introduce `WP_Comment` class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity.
...
* Takes inspiration from `WP_Post` and adds sanity to comment caching.
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now
Props wonderboymusic, nacin.
See #32619 .
Built from https://develop.svn.wordpress.org/trunk@33891
git-svn-id: http://core.svn.wordpress.org/trunk@33860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 18:17:24 +00:00
Sergey Biryukov
771b29455b
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/includes/bookmark.php`.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33682 . see #14530 .
Built from https://develop.svn.wordpress.org/trunk@33887
git-svn-id: http://core.svn.wordpress.org/trunk@33856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 08:59:24 +00:00
John Blackbourn
606b6d15f1
Introduce `wp_removable_query_args()`, which returns an array of single-use query variables which can be removed from a URL.
...
Also applies the function to the return URL when the Customizer is closed.
Fixes #32692
Props swissspidy, Mte90
Built from https://develop.svn.wordpress.org/trunk@33849
git-svn-id: http://core.svn.wordpress.org/trunk@33817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 11:29:23 +00:00
Jeremy Felt
9666aec8d1
Multisite: Remove duplicate span element output from row actions
...
Fixes #32961 .
Built from https://develop.svn.wordpress.org/trunk@33848
git-svn-id: http://core.svn.wordpress.org/trunk@33816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 21:51:21 +00:00
Sergey Biryukov
43194cea1c
Add `'dashboard_secondary_items'` filter for the number of secondary link items in the 'WordPress News' dashboard widget.
...
props MikeHansenMe, DrewAPicture.
fixes #31434 .
Built from https://develop.svn.wordpress.org/trunk@33833
git-svn-id: http://core.svn.wordpress.org/trunk@33801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:57:21 +00:00
Sergey Biryukov
a53d6b471f
Add `'update_right_now_text'` filter for the text displayed in the 'At a Glance' dashboard widget.
...
props obenland.
fixes #33355 .
Built from https://develop.svn.wordpress.org/trunk@33832
git-svn-id: http://core.svn.wordpress.org/trunk@33800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:45:21 +00:00
Drew Jaynes
375d30f699
Docs: Add a duplicate filter comment to the `comment_email` filter call in `WP_Comments_List_Table`, introduced in [33829].
...
See #11566 .
Built from https://develop.svn.wordpress.org/trunk@33830
git-svn-id: http://core.svn.wordpress.org/trunk@33798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:22:21 +00:00
Scott Taylor
a5b157ffde
Remove the hamburger global'ing from [33828]: since no args are passed to `comment_author_email_link()`, the internals can be simplified and applied inline.
...
See #11566 .
Built from https://develop.svn.wordpress.org/trunk@33829
git-svn-id: http://core.svn.wordpress.org/trunk@33797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:09:21 +00:00
Scott Taylor
d0a1a47708
Fix warnings after [33826]. Only only one function call needs a global `$comment`, we shall hamburger it.
...
See #11566 .
Built from https://develop.svn.wordpress.org/trunk@33828
git-svn-id: http://core.svn.wordpress.org/trunk@33796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:59:21 +00:00
Scott Taylor
7ab015c5ab
`WP_Comments_List_Table::single_row()` has no reason to set the `$comment` global. No other methods use it, and we are not in template/loop context. This can mess with the response of `get_comment()` elsewhere, since `get_comment()` internally bypasses the cache/db when a global is set.
...
See #11566 .
Built from https://develop.svn.wordpress.org/trunk@33826
git-svn-id: http://core.svn.wordpress.org/trunk@33794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:42:21 +00:00
Sergey Biryukov
8b1fe986c3
Use `wp_html_excerpt()` to properly cut comment author URL for display on Comments screen.
...
props brettz95, solarissmoke.
fixes #15659 .
Built from https://develop.svn.wordpress.org/trunk@33825
git-svn-id: http://core.svn.wordpress.org/trunk@33793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:41:21 +00:00
Sergey Biryukov
5a97ff5206
Bump H3 headings to H2 on Themes screen for better accessibility.
...
props joehills.
fixes #33560 .
Built from https://develop.svn.wordpress.org/trunk@33820
git-svn-id: http://core.svn.wordpress.org/trunk@33788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:51:21 +00:00
Scott Taylor
db11b48627
Favor using the consistent and agnostic string 'Attach' over 'Attach to a post' in the media list table.
...
Props pavelevap.
Fixes #33515 .
Built from https://develop.svn.wordpress.org/trunk@33810
git-svn-id: http://core.svn.wordpress.org/trunk@33778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 03:10:21 +00:00
John Blackbourn
6ee45a9606
Bring network admin user searching to parity with single site user searching by wrapping search terms in asterisks. This means that searches don't require an exact match and therefore significantly reduces friction when searching for users on the network admin screens.
...
Fixes #32913
Built from https://develop.svn.wordpress.org/trunk@33801
git-svn-id: http://core.svn.wordpress.org/trunk@33769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-29 00:19:24 +00:00
Sergey Biryukov
d10fc64ab5
Network Admin: Hide the bulk actions checkbox for super admins.
...
See [25125] for hiding the checkbox for the main site in Sites table.
props bordoni.
fixes #28529 .
Built from https://develop.svn.wordpress.org/trunk@33777
git-svn-id: http://core.svn.wordpress.org/trunk@33745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 03:49:21 +00:00
Helen Hou-Sandí
1f500055a6
Drop the hyphen from e-mail and standardize on email.
...
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.
props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156 .
Built from https://develop.svn.wordpress.org/trunk@33774
git-svn-id: http://core.svn.wordpress.org/trunk@33742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 03:17:21 +00:00
John Blackbourn
6d7aeeac03
Don't change the View Post button permalink in the sample permalink HTML when updating the slug on a published or future post.
...
Fixes #32954
Props boonebgorges, johnbillion
Built from https://develop.svn.wordpress.org/trunk@33773
git-svn-id: http://core.svn.wordpress.org/trunk@33741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-27 20:57:22 +00:00
Sergey Biryukov
4ae4d94dbb
Remove `wp-includes/comment-functions.php` from the `$_old_files` array. See [33750].
...
props rachelbaker.
fixes #33569 .
Built from https://develop.svn.wordpress.org/trunk@33772
git-svn-id: http://core.svn.wordpress.org/trunk@33740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-27 20:40:24 +00:00
John Blackbourn
b9ec4136d9
Remove `error` from the query variables when cleaning up a URL in `wp_admin_canonical_url()`.
...
Fixes #32847
Built from https://develop.svn.wordpress.org/trunk@33770
git-svn-id: http://core.svn.wordpress.org/trunk@33738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-27 17:26:21 +00:00
John Blackbourn
a60d143f7b
Correct the hook docs for the `user_profile_update_errors` action.
...
Fixes #33537
Props yamchhetri
Built from https://develop.svn.wordpress.org/trunk@33769
git-svn-id: http://core.svn.wordpress.org/trunk@33737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-27 17:16:21 +00:00
Sergey Biryukov
fc9961ca22
Make post meta box toggles accessible.
...
props joedolson.
fixes #33544 .
Built from https://develop.svn.wordpress.org/trunk@33762
git-svn-id: http://core.svn.wordpress.org/trunk@33730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-26 15:23:24 +00:00
Scott Taylor
93f745fd9b
In `WP_Users_List_Table::single_row()`, `$actions` is not always set before being used.
...
See #33491 .
Built from https://develop.svn.wordpress.org/trunk@33735
git-svn-id: http://core.svn.wordpress.org/trunk@33703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-25 20:38:20 +00:00
Scott Taylor
ef87172270
`foreach` is a statement, not a function.
...
See #33491 .
Built from https://develop.svn.wordpress.org/trunk@33734
git-svn-id: http://core.svn.wordpress.org/trunk@33702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-25 20:28:22 +00:00
Scott Taylor
c2a0336d22
Instead of [33713], allow `WP_Posts_List_Table::get_bulk_actions()` to check `edit_posts` AND `delete_posts`.
...
Props DeBAAT.
Fixes #29789 .
Built from https://develop.svn.wordpress.org/trunk@33733
git-svn-id: http://core.svn.wordpress.org/trunk@33701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-25 20:12:22 +00:00
Drew Jaynes
e8283a6f88
Docs: The type for the `$t_time` parameter in the `post_date_column_time` filter docs should be `string`, not `array`.
...
Props jjeaton
Fixes #33540 .
Built from https://develop.svn.wordpress.org/trunk@33731
git-svn-id: http://core.svn.wordpress.org/trunk@33699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-25 17:15:21 +00:00
Scott Taylor
767dd35a47
Media:
...
When inserting an image into a post, the values in `wp.media.controller.Library` should not default to linking the image when no user settings are present.
The default display setting value for `link` is now `none`. User settings persist and will override or confirm this value based on user actions.
Props liljimmi, janhenckens, eherman24, wonderboymusic.
Fixes #31467 .
Built from https://develop.svn.wordpress.org/trunk@33729
git-svn-id: http://core.svn.wordpress.org/trunk@33697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-25 12:13:23 +00:00
Dion Hulse
4f8ce1c232
Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler.
...
Props Otto42, dd32, peterwilsoncc
See #33423
Built from https://develop.svn.wordpress.org/trunk@33727
git-svn-id: http://core.svn.wordpress.org/trunk@33695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-25 04:32:21 +00:00
Scott Taylor
b1c00f2653
Posts List Table:
...
Don't show bulk actions if the user can't edit posts.
Props DrewAPicture.
Fixes #29789 .
Built from https://develop.svn.wordpress.org/trunk@33713
git-svn-id: http://core.svn.wordpress.org/trunk@33680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-23 16:28:28 +00:00
Scott Taylor
0fa7f817c4
In `wp_ajax_add_meta()`, do not juggle the value of `$_POST` and alter it directly. This was done so that `edit_post()` could pull `$_POST` out of the air by-reference and alter it (equally as bad). `edit_post()` accepts a `$post_data` array. Do that instead.
...
See #33491 .
Built from https://develop.svn.wordpress.org/trunk@33697
git-svn-id: http://core.svn.wordpress.org/trunk@33664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 18:13:24 +00:00
Scott Taylor
e9305edbce
When createing "Sample Page" on install, comments should be `closed`.
...
Props macmanx.
Fixes #33490 .
Built from https://develop.svn.wordpress.org/trunk@33693
git-svn-id: http://core.svn.wordpress.org/trunk@33660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 17:42:25 +00:00
Scott Taylor
fa2d0a2d55
Comment List Tables:
...
* Toggle visibility of pending bubble when a comment is dynamically moderated
* Add a CSS class to the pending bubble to hide it / remove to show it
See #11200 .
Built from https://develop.svn.wordpress.org/trunk@33692
git-svn-id: http://core.svn.wordpress.org/trunk@33659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 17:26:26 +00:00
Drew Jaynes
54b2e39fdd
Docs: Add a changelog entry for the `$post_type` parameter added to the `restrict_manage_posts` hook in [33644].
...
Props pavelevap
Fixes #17891 .
Built from https://develop.svn.wordpress.org/trunk@33691
git-svn-id: http://core.svn.wordpress.org/trunk@33658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 16:12:25 +00:00
Helen Hou-Sandí
514caf0120
List tables: Allow filtering of hidden and default hidden columns.
...
Similar to `get_hidden_meta_boxes()`, there are now filters named `default_hidden_columns` and `hidden_columns`.
props Compute, MikeHansenMe, chriscct7.
fixes #32499 .
Built from https://develop.svn.wordpress.org/trunk@33689
git-svn-id: http://core.svn.wordpress.org/trunk@33656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 15:32:29 +00:00
Dion Hulse
09da29102b
WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user.
...
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.
Props jobst.
Fixes #33480 for trunk
Built from https://develop.svn.wordpress.org/trunk@33688
git-svn-id: http://core.svn.wordpress.org/trunk@33655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 11:43:25 +00:00
Drew Jaynes
93009543bc
Docs: Fix some minor inline documentation syntax issues in the hook docs for the `post_edit_category_parent_dropdown_args` filter, introduced in [33682].
...
See #32246 . See #33026 .
Built from https://develop.svn.wordpress.org/trunk@33686
git-svn-id: http://core.svn.wordpress.org/trunk@33653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 04:54:26 +00:00
Drew Jaynes
416df545ba
Docs: Fix a variety of inline documentation syntax issues and add some strategic spacing.
...
Fixes #29086 .
Built from https://develop.svn.wordpress.org/trunk@33685
git-svn-id: http://core.svn.wordpress.org/trunk@33652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 04:13:24 +00:00
Drew Jaynes
3bb87e08e4
Docs: Add missing `@access` tags to properties and methods in wp-admin/includes/class-wp-upgrader.
...
See #29086 .
Built from https://develop.svn.wordpress.org/trunk@33684
git-svn-id: http://core.svn.wordpress.org/trunk@33651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 04:05:25 +00:00
Drew Jaynes
73d6dec8eb
Docs: Correct a typo in the summary for the `Theme_Upgrader->bulk` property.
...
Also adds a couple of missing `@access` tags.
Props kraftbj
See #29086 .
Built from https://develop.svn.wordpress.org/trunk@33683
git-svn-id: http://core.svn.wordpress.org/trunk@33650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 03:15:25 +00:00
Boone Gorges
52614b491a
Filter the arguments passed to `wp_dropdown_categories()` in the Categories post edit metabox.
...
The new 'post_edit_category_parent_dropdown_args' provides parity with other
places in wp-admin where `wp_dropdown_categories()` args are filtered, such as
'taxonomy_parent_dropdown_args'.
Props theMikeD.
Fixes #33026 .
Built from https://develop.svn.wordpress.org/trunk@33682
git-svn-id: http://core.svn.wordpress.org/trunk@33649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 01:28:25 +00:00
Drew Jaynes
c8638a285a
Docs: Standardize `@deprecated` tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php.
...
Props Alphawolf for the initial patch
Props DrewAPicture
See #28806 .
Built from https://develop.svn.wordpress.org/trunk@33675
git-svn-id: http://core.svn.wordpress.org/trunk@33642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 22:26:24 +00:00
Drew Jaynes
bac6e69b3c
Docs: Standardize `@deprecated` tag formatting and add missing DocBlocks to deprecated functions in wp-admin/includes/deprecated.php.
...
Opted not to use the multi-function DocBlock syntax in the name of not taking shortcuts in documentation for the sake of brevity.
Props Alphawolf for the initial patch.
See #28806
Built from https://develop.svn.wordpress.org/trunk@33671
git-svn-id: http://core.svn.wordpress.org/trunk@33638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 21:23:25 +00:00
Drew Jaynes
c36c4efea6
Docs: Add a missing summary to the DocBlock for `wp_media_upload_handler()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@33670
git-svn-id: http://core.svn.wordpress.org/trunk@33637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 21:01:25 +00:00
Drew Jaynes
89c39e7eab
Docs: Clarify the different return conditions in the DocBlock for `WP_List_Table->handle_row_actions()`.
...
This clarification follows the introduction of primary columns in 4.3. See #33313 .
Props morganestes.
Fixes #33436 .
Built from https://develop.svn.wordpress.org/trunk@33668
git-svn-id: http://core.svn.wordpress.org/trunk@33635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 20:22:25 +00:00
Scott Taylor
4254f22c2d
In `WP_Posts_List_Table::inline_edit()`, check that `$post_formats[0]` is an array before traversing.
...
Props DrewAPicture.
Fixes #33025 .
Built from https://develop.svn.wordpress.org/trunk@33667
git-svn-id: http://core.svn.wordpress.org/trunk@33634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 20:19:25 +00:00
Scott Taylor
4694c477d3
Custom Post Types:
...
* Introduce `is_post_type_viewable( $post_type_object )`
* Separate the HTML bits from the translatable bits in the `post` messages array in `edit-form-advanced.php`
* Don't show certain UI pieces when a post is not viewable on the front end
When a custom post type item is not viewable on the front end, we don't want to show links to View it (on the front end) all over the admin. We also want to hide the Preview link, et al. We also want our admin messages to not contain said links.
Custom post types with `public_queryable` set to `false` are not viewable on the front end.
`'page'` is viewable on the front end, but `'page'` is a `_builtin` type, and `public_queryable` is set to `false` when it is registered - see `WP::parse_request()` for when `public_queryable` gets used.
This is confusing, but also somewhat straightforward: to determine if a post type is viewable on the front end, we can check one way for `_builtin => true` and another way for `_builtin => false`:
`$post_type->publicly_queryable || ( $post_type->_builtin && $post_type->public )`
If a post type is `publicly_queryable`, it's viewable. If that value is `false`, it is viewable if it's a `_builtin` type that is also `public`.
I am in search of edge cases, so this shall land.
Props wonderboymusic, DrewAPicture.
See #17609 .
Built from https://develop.svn.wordpress.org/trunk@33666
git-svn-id: http://core.svn.wordpress.org/trunk@33633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 19:40:25 +00:00
Scott Taylor
20f6db2b18
Comment List Tables:
...
* Ensure that dynamic bubble counts are in sync by `comment_post_ID`
* Scope `:animated` to `#the-comment-list`
See #11200 .
Built from https://develop.svn.wordpress.org/trunk@33662
git-svn-id: http://core.svn.wordpress.org/trunk@33629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 16:36:25 +00:00
Scott Taylor
2e2223ae74
Comments List Table:
...
* In a view that initially has comments, but they get removed due to user actions: show the `No Items` row instead of bombing out and showing nothing (which looks broken)
* To accomplish this, in `WP_Comments_List_Table::display()`: call `->display_rows_or_placeholder()` instead of `->display()`
* Listen for the end of row `.fadeOut()`s if necessary using jQuery Promises
Fixes #11200 .
Built from https://develop.svn.wordpress.org/trunk@33657
git-svn-id: http://core.svn.wordpress.org/trunk@33624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 05:54:25 +00:00
Scott Taylor
df618f3461
Comments List Table:
...
* Show count next to "Approved"
* Properly increment/decrement counts when row actions are clicked
* In `_wp_ajax_delete_comment_response()`, return the comment's `status` with the `supplemental` data
* Handle counts properly on each scenario of `undo`
See #11200 .
Built from https://develop.svn.wordpress.org/trunk@33655
git-svn-id: http://core.svn.wordpress.org/trunk@33622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 02:51:25 +00:00
Dion Hulse
a32d83586e
Upgrades: When upgrading via FTP, use `LIST -a` to detect if a file exists.
...
`LIST` & `NLST` by default on some servers require the `-a` flag to view hidden files (ie. `.maintenance`)
Although we could simply pass the `-a` flag to `NLST`, opting to use `LIST` which we use elsewhere should mean less chance of server incompatibilities.
Props jcroucher.
Fixes #28013 .
Built from https://develop.svn.wordpress.org/trunk@33648
git-svn-id: http://core.svn.wordpress.org/trunk@33615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 12:38:25 +00:00
Dion Hulse
25c5d372d3
Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621].
...
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.
Props mechter for noticing!
See #30261 .
Fixes #33423 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33646
git-svn-id: http://core.svn.wordpress.org/trunk@33613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 11:31:26 +00:00
Dion Hulse
096b2f58fa
Fix PHP notice after [33492] when updating themes.
...
Props bobbingwide.
See #33208 .
Fixes #33427 .
Built from https://develop.svn.wordpress.org/trunk@33645
git-svn-id: http://core.svn.wordpress.org/trunk@33612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 10:35:25 +00:00
Scott Taylor
3923017f82
The `'restrict_manage_posts'` hook currently fires on the Post and Media list tables, but is passed zero arguments. Pass `$post_type`.
...
Props sunnyratilal, scribu.
Fixes #17891 .
Built from https://develop.svn.wordpress.org/trunk@33644
git-svn-id: http://core.svn.wordpress.org/trunk@33611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-19 06:23:25 +00:00
Scott Taylor
23f62a59da
Correct typo in doc block for `WP_Filesystem_ftpsockets::rmdir`
...
Props Toro_Unit.
Fixes #33255 .
Built from https://develop.svn.wordpress.org/trunk@33639
git-svn-id: http://core.svn.wordpress.org/trunk@33606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-18 23:33:24 +00:00
Dominik Schilling
96a6f0ac1f
Pinking shears.
...
Built from https://develop.svn.wordpress.org/trunk@33627
git-svn-id: http://core.svn.wordpress.org/trunk@33594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 21:39:25 +00:00
Dominik Schilling
ce557062f4
Upgrade: Update `$_old_files` for 4.3.
...
fixes #33394 .
Built from https://develop.svn.wordpress.org/trunk@33626
git-svn-id: http://core.svn.wordpress.org/trunk@33593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 20:24:26 +00:00
Helen Hou-Sandí
50e42e8a07
List tables: Yet more primary column fallbacks.
...
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.
props Chouby, obenland, ocean90.
fixes #33313 .
Built from https://develop.svn.wordpress.org/trunk@33623
git-svn-id: http://core.svn.wordpress.org/trunk@33590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 15:38:25 +00:00
Boone Gorges
dba7c50d29
Don't run term-splitting routine on new installations.
...
Props pento.
Fixes #30261 .
Built from https://develop.svn.wordpress.org/trunk@33621
git-svn-id: http://core.svn.wordpress.org/trunk@33588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 14:29:25 +00:00
Konstantin Obenland
e6bc6242ad
Passwords: Restore second parameter for `wp_new_user_notification()`.
...
After [33023] users would always be notified, this restores previous behavior.
Props markjaquith, ocean90.
Fixes #33358 .
Built from https://develop.svn.wordpress.org/trunk@33620
git-svn-id: http://core.svn.wordpress.org/trunk@33587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 14:25:27 +00:00
Boone Gorges
151d27369d
Term splitting routine should be run in a separate process, triggered via wp-cron.
...
[32814] introduced a routine to split shared terms, which was run during the
regular WP database upgrade. This turned out to be problematic because plugins
are not loaded during the db upgrade (due to `WP_INSTALLING`), with the result
that plugins were not able to hook into the 'split_shared_term' action during
the bulk split. We work around this limitation by moving the term splitting
routine to a separate process, triggered by a wp-cron hook.
Props boonebgorges, Chouby, peterwilsoncc, pento, dd32.
Fixes #30261 .
Built from https://develop.svn.wordpress.org/trunk@33615
git-svn-id: http://core.svn.wordpress.org/trunk@33582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-14 03:59:26 +00:00
Dominik Schilling
f74a907eac
Capabilities: Fall back to the `edit_posts` capability for orphaned comments.
...
Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.
props pento, dd32.
fixes #33154 .
Built from https://develop.svn.wordpress.org/trunk@33614
git-svn-id: http://core.svn.wordpress.org/trunk@33581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-13 22:31:24 +00:00
Andrew Ozz
3bfd096440
Fix paste typos in upgrade.php.
...
Props tellyworth. Fixes #33206 .
Built from https://develop.svn.wordpress.org/trunk@33609
git-svn-id: http://core.svn.wordpress.org/trunk@33576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-11 23:44:24 +00:00
Dion Hulse
aace7c2c8d
Function documentation: Fix a broken docbock introduced with [32642].
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@33601
git-svn-id: http://core.svn.wordpress.org/trunk@33568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-10 10:50:26 +00:00
Dion Hulse
e2b10dad49
Upgrade: Skip the sitecategories table when it doesn't exist (Global Terms is disabled).
...
Props nofearinc, obenland, SergeyBiryukov, and pento.
Fixes #33206
Built from https://develop.svn.wordpress.org/trunk@33597
git-svn-id: http://core.svn.wordpress.org/trunk@33564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-09 02:22:26 +00:00
John Blackbourn
6bd6069fc0
Remove all existing internal feature pointers.
...
Fixes #33289
Props obenland, ocean90, SergeyBiryukov
Built from https://develop.svn.wordpress.org/trunk@33593
git-svn-id: http://core.svn.wordpress.org/trunk@33560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-07 00:59:24 +00:00
Mark Jaquith
309516a6c1
Move media hooks out of `admin-filters.php` as sometimes editors are used on the front end.
...
fixes #33257
props wonderboymusic
Built from https://develop.svn.wordpress.org/trunk@33590
git-svn-id: http://core.svn.wordpress.org/trunk@33557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-06 20:40:26 +00:00
Dominik Schilling
198cdb1dde
Multisite mails: Initialize `$current_user` before accessing `$current_user->user_login`.
...
props Toro_Unit.
see #31217 .
fixes #33254 .
Built from https://develop.svn.wordpress.org/trunk@33569
git-svn-id: http://core.svn.wordpress.org/trunk@33536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-04 11:39:25 +00:00
Dominik Schilling
a9b3f12826
Heartbeat: Ensure post locks are released.
...
Built from https://develop.svn.wordpress.org/trunk@33542
git-svn-id: http://core.svn.wordpress.org/trunk@33509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-04 04:54:34 +00:00
Dominik Schilling
8b91700d5b
Fix PHP notice after [33492].
...
props jesin.
see #33178 .
fixes #33208 .
Built from https://develop.svn.wordpress.org/trunk@33519
git-svn-id: http://core.svn.wordpress.org/trunk@33486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-30 19:59:25 +00:00
Andrew Ozz
7ace03443a
Press This: properly add Open Sans to the editor, using the `mce_css` filter.
...
See #26072 . Fixes #33189 .
Built from https://develop.svn.wordpress.org/trunk@33497
git-svn-id: http://core.svn.wordpress.org/trunk@33464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 19:38:25 +00:00
Dominik Schilling
8679a93f16
Themes: Remove legacy theme preview.
...
The pre-3.4 theme previewer doesn't work when using a static front page.
We kept the old theme preview for no-JS and some browsers that were less capable. But since browsers are doing a better job today we don't need to continue fixing/shipping this legacy code. Bye!
fixes #33178 .
Built from https://develop.svn.wordpress.org/trunk@33492
git-svn-id: http://core.svn.wordpress.org/trunk@33459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 18:36:26 +00:00
Helen Hou-Sandí
7b7ae2ee25
Comments list table: Display that cute lil comment bubble.
...
The comments list table suffers from "wall of text" problems, which the two plain text links compounded.
props obenland. fixes #33149 .
Built from https://develop.svn.wordpress.org/trunk@33490
git-svn-id: http://core.svn.wordpress.org/trunk@33457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 18:08:25 +00:00
Dominik Schilling
dc4c2fa0bf
Upgrade: Lowercase the "s" in `remove_all_filters()`.
...
props afragen.
fixes #33173 .
Built from https://develop.svn.wordpress.org/trunk@33487
git-svn-id: http://core.svn.wordpress.org/trunk@33454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 14:57:25 +00:00
Mark Jaquith
c5719ba15a
Make the "using default password" nag more accurate.
...
"Easy to remember" isn't necessarily what we want to encourage.
fixes #33168
props arjunskumar
Built from https://develop.svn.wordpress.org/trunk@33485
git-svn-id: http://core.svn.wordpress.org/trunk@33452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 14:06:25 +00:00
Andrew Ozz
fa25fe82ef
Fix updating of nonces on the Edit Post screen after the log in expires and the user logs in again.
...
Props iseulde, azaozz. Fixes #33098 .
Built from https://develop.svn.wordpress.org/trunk@33468
git-svn-id: http://core.svn.wordpress.org/trunk@33435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-28 22:07:25 +00:00
Mark Jaquith
4965581097
Don't blindly trust the output of `glob()` to be an array.
...
props kitchin
fixes #33093
Built from https://develop.svn.wordpress.org/trunk@33447
git-svn-id: http://core.svn.wordpress.org/trunk@33414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-27 18:05:24 +00:00
Konstantin Obenland
0b0c456a44
Site Icon: Minor cleanup for `WP_Site_Icon` after [33329].
...
Built from https://develop.svn.wordpress.org/trunk@33446
git-svn-id: http://core.svn.wordpress.org/trunk@33413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-27 16:09:25 +00:00
Sergey Biryukov
48a1c86245
Comment string tweaks:
...
* Merge two strings about an invalid comment ID.
* Add missing context to 'Mark as Spam' string.
* Merge two 'In Response To' strings, replace redundant context with a translator comment.
props pavelevap.
fixes #32334 .
Built from https://develop.svn.wordpress.org/trunk@33436
git-svn-id: http://core.svn.wordpress.org/trunk@33403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-26 23:36:24 +00:00
Sergey Biryukov
fbd8a43b5d
Merge two duplicate strings.
...
props pavelevap.
fixes #31730 .
Built from https://develop.svn.wordpress.org/trunk@33433
git-svn-id: http://core.svn.wordpress.org/trunk@33400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-26 23:04:25 +00:00
Sergey Biryukov
67618d5cc0
Merge similar strings for plugin update permissions.
...
props pavelevap.
fixes #32388 .
Built from https://develop.svn.wordpress.org/trunk@33432
git-svn-id: http://core.svn.wordpress.org/trunk@33399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-26 23:01:25 +00:00
Dion Hulse
765714ac0b
Switch to a more performant query in meta_form().
...
Props lumaraf, swissspidy, rarylson, pento
Fixes #24498
Built from https://develop.svn.wordpress.org/trunk@33390
git-svn-id: http://core.svn.wordpress.org/trunk@33358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-23 05:17:25 +00:00
Gary Pendergast
fe5a844be5
Capabilities: When creating an auto-draft, ensure that the current user still has permission to do so.
...
Built from https://develop.svn.wordpress.org/trunk@33357
git-svn-id: http://core.svn.wordpress.org/trunk@33329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 04:02:25 +00:00
Konstantin Obenland
0f61e187b6
Site Icon: Create custom sizes for images that don't need cropping.
...
This will duplicate an image that doesn't need cropping once and will skip
creating new images and custom sizes if the selected image has the `site-icon`
context.
Fixes #33011 .
Built from https://develop.svn.wordpress.org/trunk@33356
git-svn-id: http://core.svn.wordpress.org/trunk@33328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 02:30:25 +00:00
Ella Iseulde Van Dorpe
262c1a7e54
Publish box: fix strange date format after change
...
Part props tyxla.
Fixes #30716 .
Built from https://develop.svn.wordpress.org/trunk@33340
git-svn-id: http://core.svn.wordpress.org/trunk@33312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 11:40:25 +00:00
Konstantin Obenland
3248497cf3
Site Icon: Add crop preview to the media modal.
...
* Monkey patches imgAreaSelect library to support touch events.
* Removes Settings version of Site Icon since it would have been the same flow.
* Removes default value for Customizer setting - there is no default favicon.
Fixes #16434 .
Built from https://develop.svn.wordpress.org/trunk@33329
git-svn-id: http://core.svn.wordpress.org/trunk@33301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 15:57:25 +00:00