Commit Graph

43025 Commits

Author SHA1 Message Date
desrosj c587415c86 WordPress 5.6.6.
Built from https://develop.svn.wordpress.org/branches/5.6@52115


git-svn-id: http://core.svn.wordpress.org/branches/5.6@51707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-10 17:07:58 +00:00
desrosj 50aad15dbc HTTP: Remove the DST Root CA X3 certificate expired on September 30, 2021.
> The currently recommended certificate chain as presented to Let’s Encrypt ACME clients when new certificates are issued contains an intermediate certificate (ISRG Root X1) that is signed by an old DST Root CA X3 certificate that expires on 2021-09-30. In some cases the OpenSSL 1.0.2 version will regard the certificates issued by the Let’s Encrypt CA as having an expired trust chain.
> 
> Most up-to-date CA cert trusted bundles, as provided by operating systems, contain this soon-to-be-expired certificate. The current CA cert bundles also contain an ISRG Root X1 self-signed certificate. This means that clients verifying certificate chains can find the alternative non-expired path to the ISRG Root X1 self-signed certificate in their trust store.
> 
> Unfortunately this does not apply to OpenSSL 1.0.2 which always prefers the untrusted chain and if that chain contains a path that leads to an expired trusted root certificate (DST Root CA X3), it will be selected for the certificate verification and the expiration will be reported.

References:
* [https://www.openssl.org/blog/blog/2021/09/13/LetsEncryptRootCertExpire/ Old Let’s Encrypt Root Certificate Expiration and OpenSSL 1.0.2]
* [https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/ DST Root CA X3 Expiration (September 2021)]

Follow-up to [25224], [25426], [25569], [27307], [30491], [30765], [34283], [35919], [36570], [46094].

Props bradleyt, fierevere, SergeyBiryukov, peterwilsoncc.
Merges [51883] to the 5.6 branch.
Fixes #54207. See #50828.
Built from https://develop.svn.wordpress.org/branches/5.6@52098


git-svn-id: http://core.svn.wordpress.org/branches/5.6@51690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-10 02:11:58 +00:00
desrosj b0324d5d01 WordPress 5.6.5.
Built from https://develop.svn.wordpress.org/branches/5.6@51760


git-svn-id: http://core.svn.wordpress.org/branches/5.6@51367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-08 21:29:55 +00:00
desrosj 48a23d35e3 Grouped merges for 5.6.5.
- Update `lodash` to the latest version `4.17.21`.
- Disable some attributes for rich text.
- Use hashed/deterministic moduleIDs in webpack config.

Props ellatrix, peterwilsoncc, get_dave, mcsf, talldanwp, youknowriad, desrosj, nerrad, gziolo.
Merges [50940-50941,50984-50985,51426] to the 5.6 branch.
Built from https://develop.svn.wordpress.org/branches/5.6@51751


git-svn-id: http://core.svn.wordpress.org/branches/5.6@51359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-08 21:13:23 +00:00
Sergey Biryukov c6ee3b4c8d General: Only use `_jsonp_wp_die_handler()` for JSONP REST API requests.
Props mdawaffe, peterwilsoncc.
Merges [51740] to the 5.6 branch.
Built from https://develop.svn.wordpress.org/branches/5.6@51743


git-svn-id: http://core.svn.wordpress.org/branches/5.6@51351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-08 17:25:00 +00:00
Peter Wilson 0bd759511d WordPress 5.6.4.
Built from https://develop.svn.wordpress.org/branches/5.6@50870


git-svn-id: http://core.svn.wordpress.org/branches/5.6@50479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-05-12 23:12:56 +00:00
Peter Wilson d54768332c External libraries: Improve attachment handling in PHPMailer
Props: audrasjb, ayeshrajans, desrosj, peterwilsoncc, xknown.
Partially merges [50799] to the 5.6 branch.


Built from https://develop.svn.wordpress.org/branches/5.6@50848


git-svn-id: http://core.svn.wordpress.org/branches/5.6@50457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-05-12 22:25:58 +00:00
Peter Wilson 8eea4444d9 Version bump for 5.6.3.
Built from https://develop.svn.wordpress.org/branches/5.6@50737


git-svn-id: http://core.svn.wordpress.org/branches/5.6@50346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-15 01:34:01 +00:00
desrosj c9370870af Grouped merges for 5.6.3.
* REST API: Allow authors to read their own password protected posts.
* About page update.

Merges [50717] to the 5.6 branch.

Built from https://develop.svn.wordpress.org/branches/5.6@50726


git-svn-id: http://core.svn.wordpress.org/branches/5.6@50335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-15 01:08:03 +00:00
Peter Wilson d433acb528 Editor: Update of @wordpress npm packages for 5.6.3.
Built from https://develop.svn.wordpress.org/branches/5.6@50721


git-svn-id: http://core.svn.wordpress.org/branches/5.6@50330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-15 00:05:23 +00:00
desrosj 768f1d858c External libraries: Include upstream GetID3 fix for PHP 8.
Merges [50714] to the 5.6 branch.
Props jrf, xknown.
Built from https://develop.svn.wordpress.org/branches/5.6@50716


git-svn-id: http://core.svn.wordpress.org/branches/5.6@50325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-14 23:18:03 +00:00
desrosj 794f4d7e5f Build/Test Tools: Prevent PHPUnit tests on `push` for forks/private mirrors.
The reorganization of the PHPUnit workflow in [50441] unintentionally caused the tests to be run for every `push` event, even for forks and private mirrors.

Previously, the second job required the first one to pass, and the conditional check on the first prevented both from running. Because the first job is no longer required for the second, both jobs must have the appropriate conditional check.

Merges [50670] to the 5.6 branch.
Fixes #52983.
Built from https://develop.svn.wordpress.org/branches/5.6@50672


git-svn-id: http://core.svn.wordpress.org/branches/5.6@50284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-04-06 15:28:03 +00:00
desrosj e34fbe755d Build/Test Tools: Backport GitHub Action and build improvements to the 5.6 branch.
This backports several build and test tool improvements to the 5.6 branch. Most notably, this includes:

- The changes required to allow each workflow to be triggered by the `workflow_dispatch` event so that tests can be run on a schedule [50590].
- The ability to run PHPUnit tests from `src` instead of `build` [50441-50443].
- Splitting single site and multisite tests into parallel jobs [50379].
- Split slow tests into separate, parallel jobs for PHP 5.6 [50444].
- Better branch and path scoping for GitHub Action workflows when running on `pull_request` [50432,50479].
- Several `devDependency` updates.

Merges [50267,50299,50379,50387,50413,50416,50432,50435-50436,50441-50444,50446,50473-50474,50476,50479,50485-50487,50545,50579,50590,50592,50598] to the 5.6 branch.
See #50401, #51734, #51801, #51802, #52548, #52608, #52612, #52623, #52624, #52625, #52645, #52653, #52658, #52660, #52667, #52786.
Built from https://develop.svn.wordpress.org/branches/5.6@50602


git-svn-id: http://core.svn.wordpress.org/branches/5.6@50215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-26 17:23:20 +00:00
Sergey Biryukov 071a41414a External Libraries: Install jQuery via NPM.
Previously, jQuery 1.12.4 was added to the WordPress SVN repo in order to backport an upstream security patch from jQuery 3.4.0.

Now that WordPress includes an unmodified version of jQuery 3.5.1 and no longer needs to maintain a fork, it can be removed from the SVN repo and installed via NPM again as part of the build.

Follow-up to [45342], [49101].

Props peterwilsoncc, SergeyBiryukov.
Merges [50445] to the 5.6 branch.
Fixes #52647.
Built from https://develop.svn.wordpress.org/branches/5.6@50459


git-svn-id: http://core.svn.wordpress.org/branches/5.6@50070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-01 08:29:20 +00:00
desrosj f85b6a6b06 Post WordPress 5.6.2 version bump.
The 5.6 branch is now 5.6.3 alpha.
Built from https://develop.svn.wordpress.org/branches/5.6@50405


git-svn-id: http://core.svn.wordpress.org/branches/5.6@50016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-22 15:42:58 +00:00
desrosj 0d574c649b WordPress 5.6.2.
Built from https://develop.svn.wordpress.org/branches/5.6@50403


git-svn-id: http://core.svn.wordpress.org/branches/5.6@50014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-22 15:07:59 +00:00
Sergey Biryukov a69e8f07e8 Help/About: Update the About page for 5.6.2.
Props audrasjb, desrosj, mukesh27.
Reviewed by desrosj, SergeyBiryukov.
Fixes #52557.
Built from https://develop.svn.wordpress.org/branches/5.6@50402


git-svn-id: http://core.svn.wordpress.org/branches/5.6@50013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-22 14:15:01 +00:00
desrosj 66db4a8be3 Post WordPress 5.6.2 RC1 version bump.
Built from https://develop.svn.wordpress.org/branches/5.6@50378


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 15:35:03 +00:00
desrosj bf3ff07819 WordPress 5.6.2 RC1.
Built from https://develop.svn.wordpress.org/branches/5.6@50377


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 15:07:01 +00:00
desrosj be0f960323 Editor: Update block editor dependencies for 5.6.2.
This updates several packages to their latest patch versions to fix bugs discovered in the 5.6 branch.

`@wordpress/block-directory` to `1.17.8`
`@wordpress/block-editor` to `5.1.7`
`@wordpress/block-library` to `2.26.8`
`@wordpress/components` to `11.1.5`
`@wordpress/core-data` to `2.24.4`
`@wordpress/edit-post` to `3.25.8`
`@wordpress/editor` to `9.24.7`
`@wordpress/format-library` to `1.25.7`
`@wordpress/list-reusable-blocks` to `1.24.5`
`@wordpress/media-utils` to `1.18.1`
`@wordpress/nux` to `3.23.5`
`@wordpress/reusable-blocks` to `1.0.7`
`@wordpress/server-side-render` to `1.19.5`

Props isabel_brison, talldanwp, youknowriad, freewebmentor, sterndata, inc2734, itsjonq, jorgefilipecosta, aristath, nosolosw, mattwiebe, addiestavlo, kevin940726, noisysocks, aaronrobertshaw, glendaviesnz, gwwar, bernhard-reiter, paaljoachim.
Fixes #52396, #52449, #52553.
Built from https://develop.svn.wordpress.org/branches/5.6@50376


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 14:16:26 +00:00
desrosj 757e0dc15b Editor: Correct the check for unsaved content in `wp.autosave.server.postChanged()`.
This fixes improper triggering of the "Are you sure?" prompt when navigating away from the old, "classic" Edit Post screen and there are no changes.

The previous check did not account for Pages or any custom post types that don't have a Title, Content, or Excerpt field.

Follow-up to [50031].

Props hwk-fr, mukesh27, audrasjb, archon810, Clorith, ibiza69, tonysandwich, roger995, bartosz777, viablethought, dbtedg, worldedu, hmabpera, magnuswebdesign.
Merges [50232] to the 5.6 branch.
Fixes #52440.
Built from https://develop.svn.wordpress.org/branches/5.6@50366


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 20:23:59 +00:00
Sergey Biryukov 6ae20f561e Filesystem API: Make sure to only call `fread()` on non-empty files in the PclZip library.
This avoids a fatal error on PHP 8 caused by passing a zero value to `fread()` as the `$length` argument, which must be greater than zero.

Props yakimun, fierevere, jrf, DavidAnderson, SergeyBiryukov.
Merges [50355] to the 5.6 branch.
Fixes #52018.
Built from https://develop.svn.wordpress.org/branches/5.6@50356


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 18:48:01 +00:00
desrosj 5669d987a2 Build/Test Tools: Run automated testing when tags are created.
This expands the list of events that triggers automated testing to include tags.

It also refines the matched version ranges for several workflows.

Merges [50298] to the 5.6 branch.
See #50401.
Built from https://develop.svn.wordpress.org/branches/5.6@50301


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 17:31:58 +00:00
desrosj 7e5e2a9d3a Build/Test Tools: Merge several automated testing improvements to the 5.6 branch.
This merges several refinements to GitHub Action workflow files to the 5.6 branch.

It also includes [49836], which added the ability to replace `mysql` with `mariadb` when using the local Docker environment to ensure consistency of the tools across branches.

Props johnbillion.
Merges [49781-49784,49786,49836,49938,50268,50285] to the 5.6 branch.
See #50401.
Built from https://develop.svn.wordpress.org/branches/5.6@50296


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 14:55:01 +00:00
desrosj fbcb15876e Build/Test Tools: Change the version of NodeJS tested on Windows to 14.
Merges [49782] to the 5.6 branch.
See #50401.
Built from https://develop.svn.wordpress.org/branches/5.6@50198


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 03:50:58 +00:00
desrosj 4ae31d77a1 Build/Test Tools: Fix tests after [50186].
This removes a test assertion defending against version ranges in the `node` value in `package.json` files. This is now supported.

Props peterwilsoncc.
Merges [50192] to the 5.6 branch.
See #52341.
Built from https://develop.svn.wordpress.org/branches/5.6@50193


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 03:40:02 +00:00
desrosj 8554914aef Build/Test Tools: Pin NodeJS 14.x in the `.nvmrc` file for the 5.6 branch.
See #52341.
Built from https://develop.svn.wordpress.org/branches/5.6@50187


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 02:59:01 +00:00
desrosj 4dd299f775 Build/Test Tools: Specify a version range within `engines` for `node` and `npm`.
This makes it more clear what versions of `node` and `npm` will successfully build WordPress.

Props dd32, mkaz.
Merges [50185] to the 5.6 branch.
Fixes #52455. See #51749.
Built from https://develop.svn.wordpress.org/branches/5.6@50186


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 02:50:58 +00:00
desrosj 8cfd634243 Build/Test Tools: Replace node-sass with Dart Sass
Switch the Sass implementation used by Grunt to sass (the Dart version), since LibSass & node-sass have been deprecated.

Additionally, this updates the `uglify-js` dependency.

Merges [50126] and [50176] to the 5.6 branch.
See #51763, #51801.
Built from https://develop.svn.wordpress.org/branches/5.6@50184


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 02:23:18 +00:00
desrosj 30561a3c9e Post WordPress 5.6.1 version bump.
The 5.6 branch is now 5.6.2 alpha.
Built from https://develop.svn.wordpress.org/branches/5.6@50180


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-03 21:33:59 +00:00
desrosj ba872ff3c0 WordPress 5.6.1.
Built from https://develop.svn.wordpress.org/branches/5.6@50178


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-03 21:09:58 +00:00
whyisjake d140645c95 Help/About: About page changes for 5.6.1.
Props ryelle, audrasjb.

Fixes #52346.

Built from https://develop.svn.wordpress.org/branches/5.6@50177


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-03 17:20:03 +00:00
Peter Wilson 06b29ed7f6 Build/Test Tools: Update built files committed to src following [50023].
See #51801, #52341.


Built from https://develop.svn.wordpress.org/branches/5.6@50173


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-03 01:55:02 +00:00
Sergey Biryukov d47aadaaff Tests: Set up the plugin download in multisite plugin tests to come locally.
This brings consistency between single site and multisite in REST API plugin installation tests.

Previously, multisite tests were unnecessarily downloading the plugin from WordPress.org on each test run, causing external HTTP requests and leading to failures in case of a timeout.

Follow-up to [48242], [49491], [49913].

Merges [49951] to the 5.6 branch.
See #51669.
Built from https://develop.svn.wordpress.org/branches/5.6@50085


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-30 10:40:59 +00:00
Sergey Biryukov dc34d22c36 Tests: Disable update checks while running REST API plugin installation tests.
This prevents external HTTP requests that are not required for the tests in question and may interfere with the results in case of a timeout.

Follow-up to [48242], [49491].

Merges [49913] to the 5.6 branch.
See #51669.
Built from https://develop.svn.wordpress.org/branches/5.6@50083


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-30 10:37:59 +00:00
desrosj 4713b6b932 Post WordPress 5.6.1 RC1 version bump.
Built from https://develop.svn.wordpress.org/branches/5.6@50064


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 19:43:58 +00:00
desrosj a5fd491441 WordPress 5.6.1 RC1.
Built from https://develop.svn.wordpress.org/branches/5.6@50063


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 19:30:58 +00:00
desrosj e0864925ac Twenty Twenty-One: Revert [50043] from the 5.6 branch.
Since a new version of Twenty Twenty-One will not be published in coordination with 5.6.1, this will prevent slight differences between the version of the theme that ships with 5.6.1 and the one users received when updating the theme to version `1.1`.

See #52212.
Built from https://develop.svn.wordpress.org/branches/5.6@50062


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 18:57:00 +00:00
whyisjake 34b9667a38 Editor: Update WordPress editor npm packages.
These are backports coming for the 5.6.1 release.

Summary of the following issues: 


* [#27970](https://github.com/WordPress/gutenberg/pull/27970) - Fix editor crash when registering a block pattern without `categories`  Backport to WP Minor Release [Feature] Inserter [Feature] Patterns [Type] Bug
* [#27733](https://github.com/WordPress/gutenberg/pull/27733) - [Embed block]: Add html and reusable support back  Backport to WP Minor Release [Block] Embed [Type] Regression
* [#27727](https://github.com/WordPress/gutenberg/pull/27727) - Add aria labels to box control component inputs/button  Backport to WP Minor Release [Feature] UI Components [Package] Components [Type] Bug [a11y] Labelling
* [#27627](https://github.com/WordPress/gutenberg/pull/27627) - HTML Block: Fix editor styles  Backport to WP Minor Release [Block] HTML [Type] Regression
* [#27526](https://github.com/WordPress/gutenberg/pull/27526) - Core Data: Normalize `_fields` value for use in `stableKey`  Backport to WP Minor Release [Package] Core data [Type] Bug
* [#26705](https://github.com/WordPress/gutenberg/pull/26705) - Fix: Font size picker does not correctly handles big font sizes.  Backport to WP Minor Release [Type] Bug
* [#26432](https://github.com/WordPress/gutenberg/pull/26432) - Edit Site: prevent inserter overscroll  Backport to WP Minor Release First-time Contributor [Feature] Full Site Editing [Type] Bug


Packages updated:

@wordpress/block-directory@1.17.7
@wordpress/block-editor@5.1.6
@wordpress/block-library@2.26.7
@wordpress/components@11.1.4
@wordpress/core-data@2.24.3
@wordpress/edit-post@3.25.7
@wordpress/edit-site@1.15.7
@wordpress/edit-widgets@1.1.7
@wordpress/editor@9.24.6
@wordpress/format-library@1.25.6
@wordpress/interface@0.10.7
@wordpress/list-reusable-blocks@1.24.4
@wordpress/nux@3.23.4
@wordpress/reusable-blocks@1.0.6
@wordpress/server-side-render@1.19.4

Fixes #52391.

Props gziolo, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.6@50061


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 18:22:20 +00:00
whyisjake 3563d72455 Site Health: Update the language around how PHP should be updated.
Follow-up to [50042].

This is a backport of [50058] to the 5.6 branch.

Props SergeyBiryukov.

See #52327.

Built from https://develop.svn.wordpress.org/branches/5.6@50059


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 17:24:59 +00:00
Sergey Biryukov 746b34ecd5 Privacy: Add newlines to the `index.php` file in `wp-personal-data-exports` directory, for consistency with other similar files.
Follow-up to [50037].

Merges [50055] to the 5.6 branch.
See #52299.
Built from https://develop.svn.wordpress.org/branches/5.6@50056


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 13:00:59 +00:00
Sergey Biryukov dfb8d47c85 Docs: Update documentation for `wp_is_site_protected_by_basic_auth()` per the documentation standards.
Follow-up to [49752], [50006].

Merges [50053] to the 5.6 branch.
See #52066.
Built from https://develop.svn.wordpress.org/branches/5.6@50054


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 11:06:58 +00:00
Sergey Biryukov c08b929a9e Docs: Revert documentation change for `wp_get_attachment_metadata()`.
This more accurately describes the behavior of the function, and is more consistent with the documentation for other post and attachment functions.

Follow-up to [50039].

Props Mista-Flo.
Merges [50051] to the 5.6 branch.
See #52196.
Built from https://develop.svn.wordpress.org/branches/5.6@50052


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 10:44:08 +00:00
Sergey Biryukov 5ede137834 Coding Standards: Simplify a long condition in `WP_Site_Health_Auto_Updates::test_wp_version_check_attached()` for better readability.
Follow-up to [50035].

Merges [50049] to the 5.6 branch.
See #52135.
Built from https://develop.svn.wordpress.org/branches/5.6@50050


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 10:38:00 +00:00
whyisjake 49ffe91b72 REST API: Only include the controller's own taxonomy in it's schema.
Previously, all taxonomies were incorrectly exposed as possible values.

This commit brings the changes from [49922] to the 5.6 branch.

Props johnbillion, TimothyBlynJacobs.

Fixes #51940.

Built from https://develop.svn.wordpress.org/branches/5.6@50047


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 00:53:02 +00:00
whyisjake ed54a900e3 REST API: Fix fatal error on multisite when calling the single item plugin routes.
The `is_network_only_plugin` and `is_plugin_active` functions are not available in a front-end context and must be specifically loaded.

This commit brings the changes from [49952] to the 5.6 branch.

Props oakesjosh, johnbillion, TimothyBlynJacobs.

Fixes #52205.

Built from https://develop.svn.wordpress.org/branches/5.6@50046


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 00:34:59 +00:00
whyisjake 5e3f9c3b31 App Passwords: Only attempt auth if the username and password are set.
Previously, only the username was checked which caused a PHP warning in some server setups, for instance Shibboleth SSO, where the server only populates the PHP_AUTH_USER field.

This brings the changes from [49919] to the 5.6 branch.

Props MadtownLems, johnbillion, richard.tape, engahmeds3ed, TimothyBlynJacobs.

Fixes #52003.

Built from https://develop.svn.wordpress.org/branches/5.6@50045


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 00:32:58 +00:00
whyisjake 8cf894710b App Passwords: Extract Basic Auth check into a reusable filterable function.
In [49752] a check was added to prevent creating new Application Passwords if Basic Auth credentials were detected to prevent conflicts. This check takes place in WP-Admin, though a conflict would only arise if Basic Auth was used on the website's front-end.

This commit extracts the Basic Auth check into a reusable function, wp_is_site_protected_by_basic_auth(), which can be adjusted using a filter of the same name. This way, a site that uses Basic Auth to protect WP-Admin can still use the Application Passwords feature.

In the future, instead of requiring the use of a filter, WordPress could make a loopback request and check for a WWW-Authenticate header to make this detection more robust out of the box.

This brings the changes from [50006] to the 5.6 branch.

Props SeBsZ, archon810, aaroncampbell, ocean90, SergeyBiryukov, TimothyBlynJacobs.

Fixes #52066.

Built from https://develop.svn.wordpress.org/branches/5.6@50044


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 00:28:58 +00:00
whyisjake 4ac068c40f Twenty Twenty-One: Make sure filtering attachment image attributes only affects front end and not the admin area.
This brings the changes from [49930] to the 5.6 branch.

Props denisco, SergeyBiryukov.

Fixes #52212.

Built from https://develop.svn.wordpress.org/branches/5.6@50043


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 00:22:57 +00:00
whyisjake 955c7aaf24 Site Health: Update php update strings to not overpromise performance.
This commit brings the changes from [40041] to the 5.6 branch.

Fixes #52327.

Props chanthaboune, SergeyBiryukov, audrasjb, Clorith, whyisjake.

Built from https://develop.svn.wordpress.org/branches/5.6@50042


git-svn-id: http://core.svn.wordpress.org/branches/5.6@49743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-28 00:18:56 +00:00