Commit Graph

14369 Commits

Author SHA1 Message Date
Dominik Schilling 41a8b24a8f List tables: Remove a black colored separator in Quick Edit for pages.
fixes #32842.
Built from https://develop.svn.wordpress.org/trunk@33149


git-svn-id: http://core.svn.wordpress.org/trunk@33121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 20:57:24 +00:00
Helen Hou-Sandí 70a8c3e83d List tables: Better focus styling for the row toggle.
This circular focus styling could probably be expanded to other areas of the admin.

props hugobaeta.
see #32395.

Built from https://develop.svn.wordpress.org/trunk@33146


git-svn-id: http://core.svn.wordpress.org/trunk@33118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 19:12:25 +00:00
Jeremy Felt 8431399e2e Fix missing period in missing site error.
Props @ocean90.
See #32934.

Built from https://develop.svn.wordpress.org/trunk@33145


git-svn-id: http://core.svn.wordpress.org/trunk@33116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 16:33:25 +00:00
Jeremy Felt eb26a74073 Avoid PHP notice when attempting to edit a site that does not exist.
Show a more explicit error - "The requested site does not exist."

Fixes #32934.

Built from https://develop.svn.wordpress.org/trunk@33144


git-svn-id: http://core.svn.wordpress.org/trunk@33115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 16:29:24 +00:00
Jeremy Felt 0bc0b0c917 Do not allow deletion of a super admin user through `wpmu_delete_user()`.
In step with the UI provided by `wp-admin/network/users.php`, super admin privileges must be removed before a user can be deleted through the API.

Props @johnjamesjacoby, @jeremyfelt.
Fixes #32935.

Built from https://develop.svn.wordpress.org/trunk@33143


git-svn-id: http://core.svn.wordpress.org/trunk@33114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 16:16:25 +00:00
Dominik Schilling 73d57e6c86 Add/Edit User: Move weak password label to the checkbox.
props paulwilde.
fixes #32908.
Built from https://develop.svn.wordpress.org/trunk@33137


git-svn-id: http://core.svn.wordpress.org/trunk@33108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 21:28:25 +00:00
Dominik Schilling 5fff9d1ef7 Customizer: Use `visibility` to hide available widgets and menu items panels from screen readers and to move them out of tab order.
props afercia.
fixes #32883.
Built from https://develop.svn.wordpress.org/trunk@33136


git-svn-id: http://core.svn.wordpress.org/trunk@33107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 21:21:25 +00:00
Boone Gorges e8c6340f67 Improvements to responsive styling on my-sites.php.
* Ensure that floated elements break to a new line at the end of a row.
* Allow enough vertical space for long site titles.
* Give more breathing room to cells at narrow widths.

Fixes #31685.
Built from https://develop.svn.wordpress.org/trunk@33135


git-svn-id: http://core.svn.wordpress.org/trunk@33106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 21:02:24 +00:00
Dominik Schilling 28ecfd83c6 Updates: Select All should not be a column header.
See #31654.

props tywayne.
fixes #32905.
Built from https://develop.svn.wordpress.org/trunk@33133


git-svn-id: http://core.svn.wordpress.org/trunk@33104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 20:38:25 +00:00
Helen Hou-Sandí 54428b546e Spinners: Ensure one appears in the lost connection notice.
fixes #32914.

Built from https://develop.svn.wordpress.org/trunk@33132


git-svn-id: http://core.svn.wordpress.org/trunk@33103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 20:20:24 +00:00
Andrew Ozz 4cd790906f TinyMCE, Press This: add the `wptextpattern` plugin to the Press This editor.
See #31441.
Built from https://develop.svn.wordpress.org/trunk@33128


git-svn-id: http://core.svn.wordpress.org/trunk@33099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 19:53:25 +00:00
Sergey Biryukov 1276096e3a Menus: Restore visibility of up/down arrows for reordering menu items with JS disabled.
props afercia.
fixes #32916.
Built from https://develop.svn.wordpress.org/trunk@33121


git-svn-id: http://core.svn.wordpress.org/trunk@33092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 06:48:24 +00:00
Helen Hou-Sandí 9c3bc85649 Ensure error messages look like, well, errors.
props obenland, rachelbaker.
fixes #32475.

Built from https://develop.svn.wordpress.org/trunk@33117


git-svn-id: http://core.svn.wordpress.org/trunk@33088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 23:11:24 +00:00
Scott Taylor 0deed4b842 In `install_dashboard()` (`plugin-install`, FWIW), make sure `slug` is populated and degrease the unfortunate whitespace that was present.
Props tyxla.
Fixes #32889.

Built from https://develop.svn.wordpress.org/trunk@33114


git-svn-id: http://core.svn.wordpress.org/trunk@33085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 19:19:24 +00:00
Konstantin Obenland 2cc8269741 Hide notices introduced in [30505] on about page.
See #19237.

Props jadpm.
Fixes #32625.


Built from https://develop.svn.wordpress.org/trunk@33113


git-svn-id: http://core.svn.wordpress.org/trunk@33084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 18:47:25 +00:00
Konstantin Obenland 52c2567424 Menus: Respect context when linking to the Customizer.
`Manage in Customizer` will now link to menu locations or the menus panel in
the customizer, depending on whether the user is editing menus or managing
locations.

Props rabmalin for initial patch.
Fixes #32852.


Built from https://develop.svn.wordpress.org/trunk@33112


git-svn-id: http://core.svn.wordpress.org/trunk@33083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 17:49:24 +00:00
Konstantin Obenland ee9cb55e1a Respect the special case of having only one theme.
If there is only one theme, the Pointer won't show and the overlay is active by
default. In that case the overlay covered submenu flyouts, after [33068].
Without the Pointer active, there is no need to bump the `z-index`, so it can
remain at 10.

Fixes #31544.


Built from https://develop.svn.wordpress.org/trunk@33111


git-svn-id: http://core.svn.wordpress.org/trunk@33082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 17:14:25 +00:00
Helen Hou-Sandí acad0e2008 Better styling for `.form-invalid` inputs.
props liljimmi.
fixes #32490.

Built from https://develop.svn.wordpress.org/trunk@33109


git-svn-id: http://core.svn.wordpress.org/trunk@33080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 16:41:25 +00:00
Helen Hou-Sandí e5c6186dd4 Menu customizer: Ensure item type doesn't collide with the handle focus glow.
props andg, metodiew.
fixes #32813.

Built from https://develop.svn.wordpress.org/trunk@33107


git-svn-id: http://core.svn.wordpress.org/trunk@33078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:52:25 +00:00
Helen Hou-Sandí 0b046085ae Show row actions on focus for the dashboard comment list.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@33106


git-svn-id: http://core.svn.wordpress.org/trunk@33077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:26:24 +00:00
Helen Hou-Sandí 958cde5134 List tables: Ensure special CSS for the title column gets applied.
This could have some side effects if a custom list table has a title column with a strong element inside that is not the post title, but that is fairly edge and we can address that if it comes up. Also moves the rules into `list-tables.css`.

see #25408.

Built from https://develop.svn.wordpress.org/trunk@33105


git-svn-id: http://core.svn.wordpress.org/trunk@33076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:21:25 +00:00
Helen Hou-Sandí 81c2f541b0 List tables: Add a fallback for the primary column.
Without a primary column defined, nothing shows in the responsive view at all, which is bad.

props mordauk.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@33104


git-svn-id: http://core.svn.wordpress.org/trunk@33075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:12:27 +00:00
Helen Hou-Sandí df220685a0 List tables: Account for comments being reused on the post edit screen.
Adding the `.wp-list-table` class gets us a few responsive goodies for free. And now it won't show a strange button outline.

see #32395.

Built from https://develop.svn.wordpress.org/trunk@33101


git-svn-id: http://core.svn.wordpress.org/trunk@33072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 00:09:24 +00:00
Jeremy Felt c9027b00ba Assign proper active class when showing plugin updates in network admin
Previously, a plugin would trigger an active class if it was active on the network's main site.

Fixes #32901.

Built from https://develop.svn.wordpress.org/trunk@33100


git-svn-id: http://core.svn.wordpress.org/trunk@33071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 00:02:24 +00:00
Helen Hou-Sandí 2d6edf0fe8 List tables: Get rid of double borders for plugins and themes on narrow screens.
see #32395.

Built from https://develop.svn.wordpress.org/trunk@33099


git-svn-id: http://core.svn.wordpress.org/trunk@33070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 23:49:24 +00:00
Helen Hou-Sandí 6fff730706 List tables: Ensure the no items message appears on narrow screens.
fixes #32900. see #32395.

Built from https://develop.svn.wordpress.org/trunk@33098


git-svn-id: http://core.svn.wordpress.org/trunk@33069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 23:30:24 +00:00
Jeremy Felt 3faebf40a6 Remove unused `$current_site` global in MS Sites list table
Found itself unused after [32719].

See #32434.

Built from https://develop.svn.wordpress.org/trunk@33097


git-svn-id: http://core.svn.wordpress.org/trunk@33068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 22:51:25 +00:00
Konstantin Obenland c9a29b0123 Check for all required caps before (un)sticking a post.
In cases where a user has the `edit_others_posts` capability but not
`publish_posts`, it was possible for that user to unstick a post after editing,
since the input field was never made available in that context.

Props ericmann, chriscct7.
Fixes #24153.


Built from https://develop.svn.wordpress.org/trunk@33096


git-svn-id: http://core.svn.wordpress.org/trunk@33067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 22:41:25 +00:00
Weston Ruter a62cc940ea Customizer: Register controls and settings for `nav_menu_locations` even when there are no menus yet.
This change ensures that the first menu created can be assigned to a location without first saving and reloading the Customizer.

Props markoheijnen.
Fixes #32858.

Built from https://develop.svn.wordpress.org/trunk@33094


git-svn-id: http://core.svn.wordpress.org/trunk@33065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 19:13:25 +00:00
Andrew Ozz b2e725eb27 Fix opening closed widget areas when dragging a widget over them.
Props polevaultweb. Fixes #13524.
Built from https://develop.svn.wordpress.org/trunk@33088


git-svn-id: http://core.svn.wordpress.org/trunk@33059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-05 18:20:24 +00:00
Sergey Biryukov c543f98ee6 Plugins list table: Add an `aria-label` attribute with the plugin name to plugin action links to provide context for screen reader users.
props bramd, rianrietveld, afercia.
fixes #26167.
Built from https://develop.svn.wordpress.org/trunk@33087


git-svn-id: http://core.svn.wordpress.org/trunk@33058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-05 15:03:25 +00:00
Konstantin Obenland 664b0373dc Site Icon: Switch to using H1 headings.
See #31650.

Props afercia.
Fixes #32885.


Built from https://develop.svn.wordpress.org/trunk@33084


git-svn-id: http://core.svn.wordpress.org/trunk@33055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 18:49:27 +00:00
Jeremy Felt 67142f5a2f Don't autocapitalize or autocorrect domain or path when adding a new site in iOS.
Props @ohryan.
Fixes #32646.

Built from https://develop.svn.wordpress.org/trunk@33082


git-svn-id: http://core.svn.wordpress.org/trunk@33053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 04:40:25 +00:00
Jeremy Felt 767ed1e9b1 Use the full site URL in `choose_primary_blog()` when a user is a member of only one site.
Aligns with the output used when a user is a member of multiple sites.

Fixes #32884.

Built from https://develop.svn.wordpress.org/trunk@33081


git-svn-id: http://core.svn.wordpress.org/trunk@33052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 04:21:24 +00:00
Jeremy Felt 5ab785b054 Only output Save Changes in My Sites when a user is a member of more than one site.
The conditional also checks for the existence of filters that may otherwise alter the HTML in My Sites to include extra form inputs for these users. If a filter is in use, the Save Changes button will display.

Props @Oxymoron, @obenland.
Fixes #32645.

Built from https://develop.svn.wordpress.org/trunk@33080


git-svn-id: http://core.svn.wordpress.org/trunk@33051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 04:01:26 +00:00
Sergey Biryukov ddff6fe471 Don't capitalize words in a sentence after comma.
props bjornjohansen, netweb.
fixes #31927.
Built from https://develop.svn.wordpress.org/trunk@33079


git-svn-id: http://core.svn.wordpress.org/trunk@33050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 00:50:25 +00:00
Dominik Schilling 340f1e121e Customizer: Fix `tabindex` of reorder buttons for menu items with depth 1 and 10.
props celloexpressions.
fixes #32767.
Built from https://develop.svn.wordpress.org/trunk@33077


git-svn-id: http://core.svn.wordpress.org/trunk@33048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 22:21:24 +00:00
Sergey Biryukov b2299463b6 Plugins list table: Use case-insensitive sorting.
props GaryJ.
fixes #32735.
Built from https://develop.svn.wordpress.org/trunk@33076


git-svn-id: http://core.svn.wordpress.org/trunk@33047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 21:53:25 +00:00
Konstantin Obenland cf22cd7d72 Site Icon: Remove date dropdown from media modal.
This also allows us to leverage the builtin `suggestedWidth` and
`suggestedHeight` parameters to convey the expected image size.

Props ocean90.
Fixes #32860.


Built from https://develop.svn.wordpress.org/trunk@33075


git-svn-id: http://core.svn.wordpress.org/trunk@33046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 21:28:24 +00:00
Dominik Schilling 200463d781 Customizer: Improve descriptive text and focus for menu items reorder button.
props afercia.
fixes #32725.
Built from https://develop.svn.wordpress.org/trunk@33074


git-svn-id: http://core.svn.wordpress.org/trunk@33045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 21:24:25 +00:00
Konstantin Obenland 86499fc07d Synchronize star ratings of themes and plugins.
Makes themes ratings look like plugins ratings already do.

Props helen.
Fixes #32782.
 

Built from https://develop.svn.wordpress.org/trunk@33073


git-svn-id: http://core.svn.wordpress.org/trunk@33044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 20:54:24 +00:00
Boone Gorges 27885cc561 Improve the display of my-sites.php on small screens.
Props tryon.
Fixes #31685.
Built from https://develop.svn.wordpress.org/trunk@33072


git-svn-id: http://core.svn.wordpress.org/trunk@33043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 20:47:49 +00:00
Weston Ruter 912b434198 Customizer: Fix saving menus with empty names or names that are already used.
Adds validation for initially-supplied nav menu name, blocking empty names from being supplied. If later an empty name is supplied and the nav menu is saved, the name "(unnamed)" will be supplied instead and supplied back to the client. If a name is supplied for the menu which is currently used by another menu, then the name conflict is resolved by adding a numerical counter similar to how `post_name` conflicts are resolved. Includes unit tests.

Fixes #32760.


Built from https://develop.svn.wordpress.org/trunk@33071


git-svn-id: http://core.svn.wordpress.org/trunk@33042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 20:47:25 +00:00
Dominik Schilling 93a334b361 Customizer: Remove some non-functional code.
props afercia.
fixes #32839.
Built from https://develop.svn.wordpress.org/trunk@33070


git-svn-id: http://core.svn.wordpress.org/trunk@33041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 20:37:25 +00:00
Dominik Schilling 2ce8d2eea2 Customizer: Accessibility enhancements.
* Move tabindex/focus code into `onChangeExpanded` so that it works for cases where `expand()` is called directly.
* Use `visibility: hidden` to hide hidden elements from keyboard focus and screen readers.

props celloexpressions.
fixes #31336.
Built from https://develop.svn.wordpress.org/trunk@33069


git-svn-id: http://core.svn.wordpress.org/trunk@33040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 20:19:25 +00:00
Konstantin Obenland 492853a64e Don't let wp-pointers cover the theme detail modal.
Fixes #31544.

Built from https://develop.svn.wordpress.org/trunk@33068


git-svn-id: http://core.svn.wordpress.org/trunk@33039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 17:05:24 +00:00
Konstantin Obenland bd974d7bf2 Use a less element-specific class name for links within page titles.
After [32974] these links are no longer within an `h2`, making the class name
inaccurate. `add-new-h1` has the potential to expose the same problem for in a
possible future change.

Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@33067


git-svn-id: http://core.svn.wordpress.org/trunk@33038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 16:42:24 +00:00
Konstantin Obenland 2f383536fc Check if `commentReply` exists before trying to work with it.
Fixes a bug that caused the save/publish flow to be interrupted by an AYS.

Introduced in [33024].
See #29457.


Built from https://develop.svn.wordpress.org/trunk@33066


git-svn-id: http://core.svn.wordpress.org/trunk@33037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 15:32:25 +00:00
Aaron Jorbin 903a12530b Remove accidental change to embed
Reverts about.php change from [33064]



Built from https://develop.svn.wordpress.org/trunk@33065


git-svn-id: http://core.svn.wordpress.org/trunk@33036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 14:30:25 +00:00
Aaron Jorbin 91712711eb Don't strip newline in esc_url() when protocol is mailto:
The mailto protocol is a bit different than the other protocols in that new lines are something you might realistically want to include. Includes tests to make sure that http protocol urls that contain mailto: aren't affected. Tests for stripping newlines in general already exist.

Fixes #31632
Props danielbachhuber


Built from https://develop.svn.wordpress.org/trunk@33064


git-svn-id: http://core.svn.wordpress.org/trunk@33035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 14:28:23 +00:00
Dion Hulse ceaec85751 Press This: Rewrite `WP_Press_This::fetch_source_html()` to utilise the HTTP API better without the need for a local temporary file.
This reverts [33061] but keeps it's custom UA string.

See #32864

Built from https://develop.svn.wordpress.org/trunk@33062


git-svn-id: http://core.svn.wordpress.org/trunk@33033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 12:01:25 +00:00
Sergey Biryukov fc8c36eb97 Press This: Set explicit user agent.
props kraftbj.
fixes #32864.
Built from https://develop.svn.wordpress.org/trunk@33061


git-svn-id: http://core.svn.wordpress.org/trunk@33032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 11:17:24 +00:00
Ella Iseulde Van Dorpe 12fba44414 Editor: refresh word count quicker
2 seconds is a bit slow. Debouncing with 1 second means it can only run maximum once per second. In reality it won't run us much. Even people who type slow will usually type faster than 1 character per second.

See #30966.


Built from https://develop.svn.wordpress.org/trunk@33060


git-svn-id: http://core.svn.wordpress.org/trunk@33031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 09:15:24 +00:00
Dion Hulse 36de491d68 Don't upgrade global tables to utf8mb4 when `wp_should_upgrade_global_tables()` says not to.
Additionally fixes an incorrect conditional in [33057] which would result in the usermeta index being altered twice on Multisite updates.

See #32154

Built from https://develop.svn.wordpress.org/trunk@33058


git-svn-id: http://core.svn.wordpress.org/trunk@33029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 05:44:24 +00:00
Dion Hulse d651de0dac Introduce `wp_should_upgrade_global_tables()` to determine if global tables should be upgraded automatically. Use it throughout the existing upgrade routines.
Props johnjamesjacoby for initial patch
Fixes #32154 for trunk

Built from https://develop.svn.wordpress.org/trunk@33057


git-svn-id: http://core.svn.wordpress.org/trunk@33028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 04:34:24 +00:00
Helen Hou-Sandí f85306c65a Toolbar: Allow submenus to be closed with a second tap on touch devices.
Also closes submenus when the admin menu is toggled open, as it opens below and thus can be obscured.

props stephdau, seanchayes.
see #29906.

Built from https://develop.svn.wordpress.org/trunk@33056


git-svn-id: http://core.svn.wordpress.org/trunk@33027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 03:29:25 +00:00
Dion Hulse cbacb92dae Enable utf8mb4 for MySQL extension users. Previously utf8mb4 was limited to MySQLi users only unintentionally.
This change does the following things
 * Allows utf8mb4 for the MySQL extension
 * Re-runs the utf8->utf8mb4 conversion for single sites, this will do nothing for tables already converted
 * Re-runs the utf8->utf8mb4 conversion for global tables in multisite when the environment supports utf8mb4
 * Removes upgrade_420() calling as upgrade_430() will perform those changes now instead

The index shortenings should have still taken place on utf8 sites previously, so there's no need to run those again. 

Props kovshenin, pento, dd32
Fixes #32127 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33055


git-svn-id: http://core.svn.wordpress.org/trunk@33026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 03:26:24 +00:00
Konstantin Obenland a4e803fbd4 Use `get_default_comment_status()` globally.
Also makes the filter name static and passes the post type for context.

Props valendesigns.
Fixes #31168.


Built from https://develop.svn.wordpress.org/trunk@33054


git-svn-id: http://core.svn.wordpress.org/trunk@33025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 22:32:25 +00:00
Konstantin Obenland cd7a40bdc7 Site Icon: Improve responsiveness for small screen devices.
Using Jcrop's `trueSize` argument also allows us to get rid of all that behind
the scenes temp image creating and back and forth calculating of image sizes.

Props tyxla for initial patch.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33053


git-svn-id: http://core.svn.wordpress.org/trunk@33024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 21:16:24 +00:00
Sergey Biryukov 3fb3d2a762 Replace `@returns` with `@return` in PHP docblocks.
props kraftbj.
fixes #32865.
Built from https://develop.svn.wordpress.org/trunk@33052


git-svn-id: http://core.svn.wordpress.org/trunk@33023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 21:05:24 +00:00
Konstantin Obenland 0d270f67c2 Site Icon: Skip cropping if image has the correct size.
Props jipmoors for initial patch.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33051


git-svn-id: http://core.svn.wordpress.org/trunk@33022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 20:40:25 +00:00
Konstantin Obenland f2ce96004a Add missing prefixed attributes, introduced in [33023].
See ##32589.

Built from https://develop.svn.wordpress.org/trunk@33050


git-svn-id: http://core.svn.wordpress.org/trunk@33021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 17:40:25 +00:00
Konstantin Obenland bcf488fc23 Site Icon: Show correct background preview for transparent images.
iOS will show transparent parts as black, where as the icon itself stays
transparent when used as a favicon.

See #16434.

Built from https://develop.svn.wordpress.org/trunk@33049


git-svn-id: http://core.svn.wordpress.org/trunk@33020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 17:16:26 +00:00
Helen Hou-Sandí d0e47d56ee Customizer: Build flips the panel arrow for RTL on our behalf.
see #31336.

Built from https://develop.svn.wordpress.org/trunk@33045


git-svn-id: http://core.svn.wordpress.org/trunk@33016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 01:29:25 +00:00
Konstantin Obenland a193eb3ec7 Prevent link to customizer from wrpping on small screens.
Fixes #32808.

Built from https://develop.svn.wordpress.org/trunk@33040


git-svn-id: http://core.svn.wordpress.org/trunk@33011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 23:36:26 +00:00
Dominik Schilling 85d7261305 Site icon: Remove option name from `$whitelist_options` for the general options screen.
The option gets saved in `WP_Site_Icon->set_site_icon()`.

fixes #32859.
Built from https://develop.svn.wordpress.org/trunk@33037


git-svn-id: http://core.svn.wordpress.org/trunk@33008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 21:41:26 +00:00
Mark Jaquith 504101460f Slow down on calling zxcvbn if it isn't loaded.
see #32589
Built from https://develop.svn.wordpress.org/trunk@33033


git-svn-id: http://core.svn.wordpress.org/trunk@33004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 18:13:24 +00:00
Konstantin Obenland b4a86c0f50 Add additional escaping to credits page.
Props Viper007Bond, gtuk for initial patch.
Fixes #21523.


Built from https://develop.svn.wordpress.org/trunk@33032


git-svn-id: http://core.svn.wordpress.org/trunk@33003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 17:22:24 +00:00
Mark Jaquith cb93e24c62 Add a missing "var". see #32589
Built from https://develop.svn.wordpress.org/trunk@33031


git-svn-id: http://core.svn.wordpress.org/trunk@33002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 17:16:25 +00:00
Dominik Schilling 78167b8a4c Customizer: Make reordering menu items via drag and drop easier.
Introduce `wpNavMenu.options.targetTolerance` to define a tolerance when dragging items where no margins between the sortable items exists.

props adamsilverstein.
fixes #32821.
Built from https://develop.svn.wordpress.org/trunk@33030


git-svn-id: http://core.svn.wordpress.org/trunk@33001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 16:44:24 +00:00
Jeremy Felt b837d374bf Trim trailing space from string in site delete confirmation
Props yoavf.
Fixes #32853.

Built from https://develop.svn.wordpress.org/trunk@33029


git-svn-id: http://core.svn.wordpress.org/trunk@33000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 16:31:25 +00:00
Dominik Schilling 8430848b6d Customizer: Fix height calculation of placeholders when dragging menu items.
props adamsilverstein.
fixes #32857.
Built from https://develop.svn.wordpress.org/trunk@33028


git-svn-id: http://core.svn.wordpress.org/trunk@32999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 16:20:26 +00:00
Dominik Schilling 699dbedb03 l10n: Update `wp_get_installed_translations()` to support variants of a language.
* A variant of a language has its own locale, for example the locale of the formal variant of German is `de_DE_formal`.
* Update `remove_accents()` and some CSS rules to support `de_DE_formal`.
* Add tests for `get_bloginfo( 'language' )`.
* API changes will be deployed over the next few days.

see #28303.
Built from https://develop.svn.wordpress.org/trunk@33027


git-svn-id: http://core.svn.wordpress.org/trunk@32998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 15:43:24 +00:00
Konstantin Obenland d9c5529d30 Improve the tone of key/salts recommendation message.
Also adds some inline comments to make it easier to understand how it
is determined whether to show the message or not.

Props helen.
Fixes #20779.


Built from https://develop.svn.wordpress.org/trunk@33026


git-svn-id: http://core.svn.wordpress.org/trunk@32997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 15:39:26 +00:00
Konstantin Obenland d03ff4b3d9 Close comment quick edit before updating a post.
Fixes a bug where the user gets redirected to the All Posts screen, after
updating a post while quick editing a comment.

Props polevaultweb.
Fixes #29457.


Built from https://develop.svn.wordpress.org/trunk@33024


git-svn-id: http://core.svn.wordpress.org/trunk@32995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 14:54:24 +00:00
Mark Jaquith 423a1a7ca4 New password change/set UI.
* Generate the password for the user
* More tightly integrate password strength meter
* Warn on weak passwords

see #32589

props MikeHansenMe, adamsilverstein, binarykitten
Built from https://develop.svn.wordpress.org/trunk@33023


git-svn-id: http://core.svn.wordpress.org/trunk@32994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 14:48:24 +00:00
Dion Hulse ebb6aa1d4a Split `upgrade_430()` into two so that `split_all_shared_terms()` runs when `upgrade_430_fix_comments()` bails early.
See [32814], #30261, [32364], #32165

Built from https://develop.svn.wordpress.org/trunk@33020


git-svn-id: http://core.svn.wordpress.org/trunk@32991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 07:35:24 +00:00
Helen Hou-Sandí 8eb7f71e6b List tables: A better responsive view.
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.

Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.

props Michael Arestad, helen.
see #32395.

Built from https://develop.svn.wordpress.org/trunk@33016


git-svn-id: http://core.svn.wordpress.org/trunk@32987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 01:31:25 +00:00
Helen Hou-Sandí 8f85bb1ac5 Bulk/quick edit: Set the correct colspan.
`thead` can contain `td`s now, too.

props afercia.
fixes #31654.

Built from https://develop.svn.wordpress.org/trunk@33015


git-svn-id: http://core.svn.wordpress.org/trunk@32986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 01:06:25 +00:00
Konstantin Obenland e460d37da0 Open closed widget areas when dragging onto them.
Allows dropping Widgets into the correct spot of a given sidebar, no matter
whether that sidebar is open or closed. Removes a step from the setup process
for closed sidebars.

Props polevaultweb.
Fixes #13524.


Built from https://develop.svn.wordpress.org/trunk@33014


git-svn-id: http://core.svn.wordpress.org/trunk@32985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 00:58:24 +00:00
Konstantin Obenland ec407bc971 Customizer: Fresh colors for Reorder Done button.
When reordering Widgets or Menus, the red colorcould suggest
it would cancel the changes, rather than save them. The blue
suggests it's clickable and is more in line with the Close
link on open Widgets.

Fixes #32811.


Built from https://develop.svn.wordpress.org/trunk@33012


git-svn-id: http://core.svn.wordpress.org/trunk@32983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 00:19:24 +00:00
Konstantin Obenland f18fabc300 Site Icon: Move admin icon filter to its rightful place.
The action is unrelated to `WP_Site_Icon` itself.

Props kraftbj.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@33011


git-svn-id: http://core.svn.wordpress.org/trunk@32982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 23:26:25 +00:00
Dominik Schilling 7cc9a4c092 Plugins list table: Sort plugins by `Name` by default so translated plugin names get correctly sorted.
props swissspidy.
fixes #32735.
Built from https://develop.svn.wordpress.org/trunk@33010


git-svn-id: http://core.svn.wordpress.org/trunk@32981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 22:31:25 +00:00
Andrew Ozz d986bbbf42 Squish that .png a bit more. See [32994].
Built from https://develop.svn.wordpress.org/trunk@33009


git-svn-id: http://core.svn.wordpress.org/trunk@32980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 22:04:25 +00:00
Dominik Schilling 86ebc13446 Remove unnecessary feedback message from `WP_Importer::is_user_over_quota()`.
fixes #32021.
Built from https://develop.svn.wordpress.org/trunk@33008


git-svn-id: http://core.svn.wordpress.org/trunk@32979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 20:32:25 +00:00
Konstantin Obenland aa3cb4ab1d Use correct panel id for menus when linking to the customizer.
Props swissspidy.
Fixes #32808.


Built from https://develop.svn.wordpress.org/trunk@33004


git-svn-id: http://core.svn.wordpress.org/trunk@32975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 16:24:24 +00:00
Helen Hou-Sandí e41b7b4f75 Image edit: Consistent whitespace for the side boxes.
props tyxla.
fixes #31845.

Built from https://develop.svn.wordpress.org/trunk@33002


git-svn-id: http://core.svn.wordpress.org/trunk@32973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 15:19:25 +00:00
Konstantin Obenland 38e4211efb Use existing nomenclature pattern for Site Icon class.
Props kraftbj.
Fixes #32834.


Built from https://develop.svn.wordpress.org/trunk@33001


git-svn-id: http://core.svn.wordpress.org/trunk@32972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 14:37:27 +00:00
Andrew Ozz b092defb17 Press This:
- Add support for the Text editor.
- Add auto-scrolling when the caret moves out of the viewport while the user is typing (similarly to editor-expand).
- Add auto-resize for the textarea.
See #32706.
Built from https://develop.svn.wordpress.org/trunk@32999


git-svn-id: http://core.svn.wordpress.org/trunk@32970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 03:58:27 +00:00
Konstantin Obenland 36b24b073d Provide alt text for uploaded header images.
The custom header screen will use it rather then the description,
if an alt text is set.

Props francoeurdavid, voldemortensen, valendesigns.
Fixes #27959.


Built from https://develop.svn.wordpress.org/trunk@32998


git-svn-id: http://core.svn.wordpress.org/trunk@32969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-29 21:32:26 +00:00
Konstantin Obenland c56a8ae0f7 Introducing Site Icon, favicon management for WordPress.
This v1 marries Jetpack's Site Icon module with the Media Modal, reusing code
from the Custom Header admin. For now, the core-provided icons will be limited
to a favicon, an iOS app icon, and a Windows tile icon, leaving `.ico` support
and additional icons to plugins to add.

Props obenland, tyxla, flixos90, jancbeck, markjaquith, scruffian.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@32994


git-svn-id: http://core.svn.wordpress.org/trunk@32965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-29 12:58:25 +00:00
Helen Hou-Sandí 83e33a2ca0 List tables: Bring screen reader text for comments column title to media.
see #32152, [31513].

Built from https://develop.svn.wordpress.org/trunk@32991


git-svn-id: http://core.svn.wordpress.org/trunk@32962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 15:44:25 +00:00
Aaron Jorbin 1525010f74 Deprecate php4 style constructors
PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors.  The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used.  In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982


Built from https://develop.svn.wordpress.org/trunk@32990


git-svn-id: http://core.svn.wordpress.org/trunk@32961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 15:27:24 +00:00
Aaron Jorbin c9307fc95a Update Grunt dev-dependencies
grunt-browserify : minor version update
grunt-contrib-cssmin : minor version update
grunt-contrib-imagemin : patch version update
grunt-contrib-jshint : patch version update
grunt-contrib-uglify : minor version update (causes some changes to minified JS)
grunt-includes : minor version update
grunt-sass : major version update ( underlying libsass update ).

Props wonderboymusic
See #31700


Built from https://develop.svn.wordpress.org/trunk@32988


git-svn-id: http://core.svn.wordpress.org/trunk@32959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 14:51:30 +00:00
Konstantin Obenland 0704de88ea Customizer: Correct position for menu item delete icon in IE8.
Props valendesigns.
Fixes #32675.


Built from https://develop.svn.wordpress.org/trunk@32987


git-svn-id: http://core.svn.wordpress.org/trunk@32958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 11:49:24 +00:00
Aaron Jorbin 4bbf254375 Add missing semicolon
Introduced in [32983].

see #32757.

Built from https://develop.svn.wordpress.org/trunk@32986


git-svn-id: http://core.svn.wordpress.org/trunk@32957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 11:41:24 +00:00
Sergey Biryukov bff91cfa5b Menus: Add a Manage in Customizer link, like we did for Widgets screen in [30459].
props celloexpressions.
fixes #32808.
Built from https://develop.svn.wordpress.org/trunk@32985


git-svn-id: http://core.svn.wordpress.org/trunk@32956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 06:08:24 +00:00
Sergey Biryukov b26accf35a List tables: Select All should not be a column header.
It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.

props afercia, valendesigns.
see #31654.
Built from https://develop.svn.wordpress.org/trunk@32984


git-svn-id: http://core.svn.wordpress.org/trunk@32955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 05:46:25 +00:00
Andrew Ozz 275fc220ef Press This:
- Save a draft before opening the standard editor window.
- While saving a post show Saving... instead of Publish for the main visible part of the split button (same as the Save Draft button before).
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32983


git-svn-id: http://core.svn.wordpress.org/trunk@32954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 04:59:24 +00:00
Sergey Biryukov 9665259675 Customizer: Increase color contrast ratio for menu locations text.
props celloexpressions.
fixes #32727.
Built from https://develop.svn.wordpress.org/trunk@32982


git-svn-id: http://core.svn.wordpress.org/trunk@32953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 04:45:25 +00:00