Sergey Biryukov
7932193708
Coding Standards: Use strict comparison where static strings are involved.
...
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47808
git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
Sergey Biryukov
001ffe81fb
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47122
git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Andrew Ozz
1ce44564aa
Twenty Twelve: menu on touch devices: fix jQuery selector for menu items with submenus. props babbardel, fixes #24767 .
...
Built from https://develop.svn.wordpress.org/trunk@30746
git-svn-id: http://core.svn.wordpress.org/trunk@30736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-05 22:59:23 +00:00
Lance Willett
7d95c83257
Twenty Twelve and Thirteen: Use proper way to get customizer settings values.
...
Props obenland, kdoran. Fixes #29577 .
Built from https://develop.svn.wordpress.org/trunk@30482
git-svn-id: http://core.svn.wordpress.org/trunk@30470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 17:06:23 +00:00
Dominik Schilling
61819a36ea
Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific.
...
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/ .
props studionashvegas, tareq1988.
fixes #29947 .
Built from https://develop.svn.wordpress.org/trunk@29903
git-svn-id: http://core.svn.wordpress.org/trunk@29658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:21:19 +00:00
Lance Willett
8a0a5ce1d2
Twenty Twelve: make small-screen menu accessible to keyboard commands and voice-driven software by using a focusable button element rather than `h3` for the toggle element. Fixes #28224 , props rclations.
...
Built from https://develop.svn.wordpress.org/trunk@29095
git-svn-id: http://core.svn.wordpress.org/trunk@28881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 17:47:14 +00:00
Lance Willett
3c9d69fa90
Twenty Twelve: make submenu links work correctly on tablets. Props tar.gz, purzlbaum, DavidTheMachine. See #24767 .
...
Built from https://develop.svn.wordpress.org/trunk@28700
git-svn-id: http://core.svn.wordpress.org/trunk@28517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-08 19:00:14 +00:00
Lance Willett
393381d3e4
Twenty Twelve: improve menu navigation for keyboard and voice-over interactions by properly focusing on submenu items when they are open. See #24839 , props dannydehaan, joedolson, lancewillett.
...
Built from https://develop.svn.wordpress.org/trunk@27606
git-svn-id: http://core.svn.wordpress.org/trunk@27449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 05:29:16 +00:00
Andrew Nacin
00bb092d31
Update the HTML5 Shiv across the default themes to 3.7.0.
...
props rickalee.
fixes #26491 .
Built from https://develop.svn.wordpress.org/trunk@27263
git-svn-id: http://core.svn.wordpress.org/trunk@27120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:18:14 +00:00
Lance Willett
f41b21f4f6
Twenty Twelve: fix regression introduced in r23572, allow hide/show of Header Text in Customizer. Fixes #23600 .
...
Also remove another `!important` -- and there was much rejoicing.
Props SergeyBiryukov and obenland.
git-svn-id: http://core.svn.wordpress.org/trunk@23711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 16:42:10 +00:00
Lance Willett
76e80eaa86
Twenty Twelve: enable live preview for Header Text Color in Theme Customizer. Change also removes an `!important` declaration (yay) in Custom Header CSS rules.
...
Props SriniG, fixes #23600 .
git-svn-id: http://core.svn.wordpress.org/trunk@23572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:45:59 +00:00
Lance Willett
5fb24acd2b
Twenty Twelve: better handling for cases where a background color is set to white or an empty value (like first run with no `theme_mods` set) and a background image is enabled, which resulted previously in a broken layout. Fixes #23586 , props obenland.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:14:59 +00:00
Lance Willett
0c69e9f00d
Twenty Eleven and Twenty Twelve: use `.text()` instead of `.html()` for `blogname` and `blogdescription` in Theme Customizer JavaScript handlers. Fixes #23435 , props mfields.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-15 16:53:58 +00:00
Lance Willett
8f17fa783a
Twenty Twelve: avoid JavaScript errors if navigation wrapper markup is removed from header. Fixes #22307 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 20:21:01 +00:00
Lance Willett
ce1fc87461
Twenty Twelve: remove a duplicate/misplaced condition in theme-customizer.js, props DrewAPicture. Closes #21685 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-10 20:47:07 +00:00
Lance Willett
b5853fcd19
Twenty Twelve: fix comments in two files, for accuracy.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 15:23:15 +00:00
Lance Willett
e538b8c697
Twenty Twelve: update navigation script to check for missing button and menu children earlier; allows an empty menu to be set without showing the button. See #21678 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 16:28:27 +00:00
Lance Willett
5beee34612
Twenty Twelve: simplify custom font loading behavior, see #21694 .
...
* Remove theme options code and support from theme.
* Keep Open Sans font first in the stack and make it always loaded.
* Move Customizer pieces from Theme Options out of class structure and into functions.php.
git-svn-id: http://core.svn.wordpress.org/trunk@21639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-28 02:18:43 +00:00
Lance Willett
fe87773446
Twenty Twelve: JavaScript fix props obenland; no need to put the selector in a variable as it will be called only once anyway. See #21685 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-25 17:47:34 +00:00
Lance Willett
8932111b07
Twenty Twelve: spaces to tabs in navigation.js, props obenland. See #21685 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-25 16:50:05 +00:00
Lance Willett
a1d39f1e1e
Twenty Twelve: rework navigation to remove need for jQuery and support wp_page_menu markup better. Fixes #21562 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-24 21:07:19 +00:00
Lance Willett
feb752da92
Twenty Twelve: remove matchMedia JS polyfill now that older browsers are getting mobile-first navigation styles. Props Jayjdk, see #21562 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 23:39:57 +00:00
Lance Willett
64afcc0dea
Twenty Twelve: include links to source code for html5 shiv and matchmedia polyfil, props jorbin. Fixes #21671 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 20:52:07 +00:00
Lance Willett
1dabc15e34
Twenty Twelve: re-implement the hiding of toggle element when empty menu is present, see #21562 and r21520 props cfinke.
...
git-svn-id: http://core.svn.wordpress.org/trunk@21557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-20 19:14:51 +00:00
Lance Willett
6de0e77fd4
Twenty Twelve: improve navigation to be mobile-first and not rely on JS for hiding and showing, props obenland for patches. See #21562 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-20 18:35:33 +00:00
Lance Willett
5f1392a175
Twenty Twelve: selector for navigation menu should style the menu list element, props obenland, see #21562 .
...
Also remove duplicate line-height rule, props bradthomas127. See #21577 .
git-svn-id: http://core.svn.wordpress.org/trunk@21520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-15 05:56:24 +00:00
Lance Willett
934101fd65
Twenty Twelve: stop nav slide animation when clicking the button multiple times in a row. Props Jayjdk, fixes #21531 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-15 05:37:36 +00:00
lancewillett
2099053853
Twenty Twelve: add polyfill JS for matchMedia rules, avoids JS error in older IE versions. See #21440 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 16:13:32 +00:00
lancewillett
ffc2e121fc
Twenty Twelve: Add postMessage support in Customizer for fonts, site title and description, and background color body_class value updates.
...
Props obenland for first patch and testing. Fixes #21443 .
git-svn-id: http://core.svn.wordpress.org/trunk@21411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-02 22:10:03 +00:00
lancewillett
29b95be1b5
Twenty Twelve: fix navigation selectors as the change in r21404 broke the small navigation menu behavior.
...
git-svn-id: http://core.svn.wordpress.org/trunk@21405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-02 19:53:45 +00:00
lancewillett
1d9662043e
Twenty Twelve: CSS and markup improvements for better child theme support, part 3. See #21379 .
...
* Add classes like `.site` and `.site-content` in addition to the set of IDs already present, making things much better for child themes to have more than one generic element like `nav` inside the content container.
* Bump JS version after selector change.
* Move `image-attachment` to `post_class()` output
More exhaustive notes in the ticket on each id and class change.
git-svn-id: http://core.svn.wordpress.org/trunk@21404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-02 19:12:11 +00:00
lancewillett
7f29970ebd
Twenty Twelve: update comment header in html5 JS file.
...
Related to #20640 .
git-svn-id: http://core.svn.wordpress.org/trunk@21388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-01 15:06:24 +00:00
lancewillett
9f5310274b
Twenty Twelve: enable async body class value changes for custom background color changes in Theme Customizer. See #21226 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 19:42:55 +00:00
nacin
741876a148
The Twenty Twelve for WordPress.
...
props drewstrojny, lancewillett.
also props corvannoorloos, jeffsebring, kobenland, iandstewart, mfields,
mtdesign, op12no2, philiparthurmoore, sixhours, mamaduka.
see #19978 .
git-svn-id: http://core.svn.wordpress.org/trunk@21261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-12 04:20:46 +00:00
nacin
edb6c96b9f
Remove Twenty Twelve from 3.4. see #19978 . see http://wp.me/pbNCB-yA .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-20 18:41:54 +00:00
lancewillett
e3813d7b68
Twenty Twelve: make proper use of the cached jQuery collection in navigation.js, props mattwiebe. Fixes #20131 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 19:17:04 +00:00
lancewillett
a044beab6a
Twenty Twelve: add support for toggling the navigation menu in small screens. See #19978 .
...
Triggered when a viewport is under 600 pixels wide. This functionality depends on JS being enabled, and will naturally fall back to a normal, expanded menu for a client without JS.
Props iandstewart for the original JS file and concept.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 03:59:47 +00:00
matt
a577a1faf8
Initial import of the Twenty Twelve theme, by Drew Strojny. This time around we're trying something different than the previous twenty-something themes, a much more minimalist approach that affords easy use as a CMS in addition to being blog-forward. More information will be on wpdevel soon. Props drewstrojny and lancewillett.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-06 22:23:41 +00:00