1050613168
Coding standards: Modify escaping functions to avoid potential false positives.
...
Props xknown, zieladam, peterwilsoncc.
Merges [49375] to trunk.
Built from https://develop.svn.wordpress.org/trunk@49384
git-svn-id: http://core.svn.wordpress.org/trunk@49143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 18:03:11 +00:00
025f5a62a2
Embeds: Disable embeds on deactivated Multisite sites.
...
Props xknown, whyisjake, zieladam, peterwilsoncc.
Merges [49374] to trunk.
Built from https://develop.svn.wordpress.org/trunk@49383
git-svn-id: http://core.svn.wordpress.org/trunk@49142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 18:02:05 +00:00
cad4a1a3d7
External Libraries: Disable deserialization in Requests_Utility_FilteredIterator
...
Props xknown, peterwilsoncc, desrosj, dd32, whyisjake.
Merges [49373] to trunk.
Built from https://develop.svn.wordpress.org/trunk@49382
git-svn-id: http://core.svn.wordpress.org/trunk@49141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 18:00:08 +00:00
fcc970a1cf
XML-RPC: Improve error messages for unprivileged users.
...
Add specific permission checks to avoid ambiguous failure messages.
Props zieladam, peterwilsoncc, xknown, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@49380
git-svn-id: http://core.svn.wordpress.org/trunk@49139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 17:44:07 +00:00
019d838b6c
Build/Test Tools: Avoid logging the same debug info twice in the PHPUnit workflow.
...
Also includes some inline documentation fixes for workflow files.
See #50401 .
Built from https://develop.svn.wordpress.org/trunk@49371
git-svn-id: http://core.svn.wordpress.org/trunk@49130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 01:48:04 +00:00
a9a1146a71
REST API: Remove accidentally duplicated key in test fixtures.
...
Follow-up to [49334], [49368].
See #51638 .
Built from https://develop.svn.wordpress.org/trunk@49370
git-svn-id: http://core.svn.wordpress.org/trunk@49129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 01:34:05 +00:00
813fb756ae
Build/Test Tools: Use `install-changed` to install NPM dependencies in GitHub Action workflows.
...
The `install-changed` package records a hash of the `package.json` file locally in a text file and only runs `npm install` when there are changes to account for.
This builds on [47497], which only hashes the `package.json` file after a Grunt task is called. By using `npx install-changed` within the workflow files, the package is hashed before the first Grunt task is run.
Props ocean90.
See #50401 , #49594 .
Built from https://develop.svn.wordpress.org/trunk@49369
git-svn-id: http://core.svn.wordpress.org/trunk@49128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 01:22:04 +00:00
36dcf727f4
REST API: Regenerate test fixtures after [49334].
...
Props garrett-eclipse.
Fixes #51638 .
Built from https://develop.svn.wordpress.org/trunk@49368
git-svn-id: http://core.svn.wordpress.org/trunk@49127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 01:02:06 +00:00
bb0b36a905
Themes: Clarify the `_doing_it_wrong()` message for post formats in `add_theme_support()`.
...
Follow-up to [49344], [49354], [49365].
See #51390 .
Built from https://develop.svn.wordpress.org/trunk@49367
git-svn-id: http://core.svn.wordpress.org/trunk@49126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 00:08:06 +00:00
99e83a11d0
Tests: Correct post formats registration in `WP_REST_Search_Controller` tests.
...
When declaring theme support for the `post-formats` feature, an array of supported post formats needs to be specified.
Follow-up to [49344], [49354].
Props garrett-eclipse.
Fixes #51390 .
Built from https://develop.svn.wordpress.org/trunk@49365
git-svn-id: http://core.svn.wordpress.org/trunk@49125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-29 00:03:05 +00:00
9b8fe28242
Build/Test Tools: Allow the desired version of PHPUnit to be passed to the local Docker environment.
...
This reintroduces [49358] with a modification to the `.travis.yml` file to avoid an issue with `dotenv-expand` being unable to expand variables into `process.env` only on Travis.
The `LOCAL_PHPUNIT` environment variabl allows the desired version of PHPUnit to be specified when running the PHP tests within the local Docker environment.
Because support for newer versions of PHPUnit is not backported, some versions of PHP need the ability to run multiple versions of PHPUnit for different branches. This adds the flexibility needed to use the Docker environment within those older branches to run the PHP tests.
Props johnbillion, SergeyBiryukov.
See #50042 .
Built from https://develop.svn.wordpress.org/trunk@49362
git-svn-id: http://core.svn.wordpress.org/trunk@49122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-28 23:17:23 +00:00
76f6f20d41
Build/Test Tools: Revert [49358] to investigate failures.
...
Unprops desrosj.
See #50042 .
Built from https://develop.svn.wordpress.org/trunk@49360
git-svn-id: http://core.svn.wordpress.org/trunk@49120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-28 19:44:21 +00:00
dbae445997
Embeds: Remove Facebook and Instagram as an oEmbed Source
...
Facebook has depracated all non-authenticated endpoints for Facebook and Instagram.
See: https://developers.facebook.com/docs/plugins/oembed-legacy
See also: https://make.wordpress.org/core/2020/09/22/facebook-and-instagram-embeds-to-be-deprecated-october-24th/
With this change, endpoints are being removed. If a site is dependent on this feature, they need to pass either an app or client token. There are a few plugins that add this functionality.
Fixes #50861 .
Props johnbillion, joyously, mkaz, dimadin, ayeshrajans, davisshaver, paaljoachim, Clorith, bridgetwillard, jb510, sippis, Clorith, TimothyBlynJacobs, desrosj, smub, audrasjb, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@49359
git-svn-id: http://core.svn.wordpress.org/trunk@49119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-28 19:11:06 +00:00
41d5f153c5
Build/Test Tools: Allow the desired version of PHPUnit to be passed to the local Docker environment.
...
This change introduces the `LOCAL_PHPUNIT` environment variable that allows the desired version of PHPUnit to be specified when running the PHP tests within the local Docker environment.
Because support for newer versions of PHPUnit is not backported, some versions of PHP need the ability to run multiple versions of PHPUnit for different branches. This adds the flexibility needed to use the Docker environment within those older branches to run the PHP tests.
Props johnbillion.
Fixes #50042 .
Built from https://develop.svn.wordpress.org/trunk@49358
git-svn-id: http://core.svn.wordpress.org/trunk@49118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-28 19:03:25 +00:00
1aafbf6c6f
Cron API: Improve the inline documentation for the args passed to the cron event scheduling functions.
...
Props chadreitsma, peterwilsoncc
Fixes #51605
Built from https://develop.svn.wordpress.org/trunk@49357
git-svn-id: http://core.svn.wordpress.org/trunk@49117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-28 18:37:07 +00:00
e569358678
General: Ensure that filtered arguments in `get_search_form()` contain all required default values.
...
Props kellybleck, davidbaumwald, whyisjake, SergeyBiryukov.
Fixes #51645 .
Built from https://develop.svn.wordpress.org/trunk@49355
git-svn-id: http://core.svn.wordpress.org/trunk@49115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-28 16:57:08 +00:00
d0268b2b69
Themes: Move the test for `post-formats` theme support to a more appropriate place.
...
Follow-up to [49344].
See #51390 .
Built from https://develop.svn.wordpress.org/trunk@49354
git-svn-id: http://core.svn.wordpress.org/trunk@49114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-28 15:14:10 +00:00
e37d1acc1c
Customize: Update parameter name in `api.Class.extend()`.
...
This makes the name consistent with the documentation and the `inherits()` function signature.
Props ribaricplusplus, davidbaumwald.
Fixes #51652 .
Built from https://develop.svn.wordpress.org/trunk@49353
git-svn-id: http://core.svn.wordpress.org/trunk@49113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-28 00:45:06 +00:00
a33d6305d1
Twenty Twenty: Correct some textdomains in block patterns.
...
Props justinahinon.
Fixes #51648 . See #51098 .
Built from https://develop.svn.wordpress.org/trunk@49352
git-svn-id: http://core.svn.wordpress.org/trunk@49112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 22:14:05 +00:00
4ca6722c41
Post WordPress 5.6 beta 2 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@49351
git-svn-id: http://core.svn.wordpress.org/trunk@49111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 22:02:08 +00:00
21f3cc781e
WordPress 5.6 Beta 2.
...
Built from https://develop.svn.wordpress.org/trunk@49350
git-svn-id: http://core.svn.wordpress.org/trunk@49110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 21:42:07 +00:00
14558efa83
PHPCS fixes after [49347].
...
See #51098 .
Built from https://develop.svn.wordpress.org/trunk@49349
git-svn-id: http://core.svn.wordpress.org/trunk@49109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 21:23:07 +00:00
bf02276a17
Bundled Themes: Introduce block patterns for Twenty Nineteen.
...
Including some props I missed on the commit for Twenty Twenty, I am sorry.
Props: kjellr, beafialho, melchoyce, ryelle, jffng, bridgetwillard.
Fixes #51099 .
Built from https://develop.svn.wordpress.org/trunk@49348
git-svn-id: http://core.svn.wordpress.org/trunk@49108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 21:15:12 +00:00
6d3300b437
Bundled Themes: Introduce block patterns for Twenty Twenty.
...
Props melchoyce, Anlino, kjellr, ryelle.
Fixes #51098 .
Built from https://develop.svn.wordpress.org/trunk@49347
git-svn-id: http://core.svn.wordpress.org/trunk@49107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 21:01:07 +00:00
9241624e6c
Menus: Better responsive display for accordion items.
...
This only applies to the standalone menu screen; fixes for the customizer will be handled separately.
Props audrasjb, garrett-eclipse.
See #49375 .
Built from https://develop.svn.wordpress.org/trunk@49346
git-svn-id: http://core.svn.wordpress.org/trunk@49106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 20:18:06 +00:00
a6db16fad0
Upgrade/Install: Adjust a string in `core_auto_updates_settings()` for consistency.
...
Props audrasjb, desrosj.
See #50907 .
Built from https://develop.svn.wordpress.org/trunk@49345
git-svn-id: http://core.svn.wordpress.org/trunk@49105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 20:12:06 +00:00
3fc623c202
Post Formats: You have to pass an array of supported post formats.
...
This shows a `_doing_it_wrong()` message and also returns false instead of true if no array of formats is passed in `add_theme_support()`, avoiding a PHP error.
Post formats maintainership comes full circle. 🙃
Props Mista-Flo, sproutchris, garrett-eclipse.
Fixes #51390 .
Built from https://develop.svn.wordpress.org/trunk@49344
git-svn-id: http://core.svn.wordpress.org/trunk@49104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 20:00:06 +00:00
7636806a52
Media: Fix styling for MediaElement player in media modal.
...
Fixes #43640 .
Built from https://develop.svn.wordpress.org/trunk@49343
git-svn-id: http://core.svn.wordpress.org/trunk@49103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 19:40:04 +00:00
cbc1404589
External Libraries: Update jQuery Migrate to 3.3.2-pre.
...
This is a prerelease version to avoid some errors in 5.6 beta 2. We need to be sure that we ship with a released version by 5.6 RC.
Props mweichert.
Fixes #51621 . See #50564 .
Built from https://develop.svn.wordpress.org/trunk@49338
git-svn-id: http://core.svn.wordpress.org/trunk@49099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 18:59:08 +00:00
85e954aa37
Login: Avoid AJAX error on login screen.
...
This has to do with the password generator, which does not need to generate and cache passwords in JS as that's already done in PHP.
Props adamsilverstein, sarahricker.
Fixes #51613 .
Built from https://develop.svn.wordpress.org/trunk@49337
git-svn-id: http://core.svn.wordpress.org/trunk@49098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 18:43:07 +00:00
769b29f962
Build/Test Tools: Add `Authorization` headers support to `local-env`.
...
This ensures that basic authorization is passed from nginx to PHP.
Props Clorith.
Fixes #51646 .
Built from https://develop.svn.wordpress.org/trunk@49336
git-svn-id: http://core.svn.wordpress.org/trunk@49097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 18:35:12 +00:00
1dcdd946c6
Build/Test Tools: Specify a type when using `wp config set`.
...
This prevents an error if constants are not predefined when running the Docker install script while using older combinations of WordPress/PHP/WP-CLI.
See #48301 .
Built from https://develop.svn.wordpress.org/trunk@49335
git-svn-id: http://core.svn.wordpress.org/trunk@49096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 18:34:06 +00:00
2df94804d4
Site Health, App Passwords: Test if the Authorization header is populated correctly.
...
App Passwords rely on the Authorization header to transport the Basic Auth credentials. For Apache web servers, WordPress automatically includes a RewriteRule to populate the value for servers running in CGI or FastCGI that wouldn't ordinarily populate the value.
This tests if the header is being filled with the expected values. For Apache users, we direct the user to visit the Permalinks settings to flush their permalinks. For all other users, we direct them to a help document on developer.wordpress.org.
Props Clorith, marybaum, TimothyBlynJacobs.
Fixes #51638 .
Built from https://develop.svn.wordpress.org/trunk@49334
git-svn-id: http://core.svn.wordpress.org/trunk@49095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 18:32:07 +00:00
219079f7a3
Privacy: Show failures before successes for all bulk actions.
...
Props garrett-eclipse.
See #44081 , [49331].
Built from https://develop.svn.wordpress.org/trunk@49333
git-svn-id: http://core.svn.wordpress.org/trunk@49094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 18:19:06 +00:00
f4f72498c0
Privacy: Show notices for both failed and successful bulk actions.
...
Props javorszky, garrett-eclipse, hellofromTonya.
Fixes #44081 .
Built from https://develop.svn.wordpress.org/trunk@49331
git-svn-id: http://core.svn.wordpress.org/trunk@49092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 17:47:08 +00:00
24f6f56a71
Twenty Twenty-One: Import the latest changes.
...
For a full list of changes since [49320], see 461dcf9cd...5759e96#51526 .
Built from https://develop.svn.wordpress.org/trunk@49330
git-svn-id: http://core.svn.wordpress.org/trunk@49091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 17:07:05 +00:00
5df8bf60aa
REST API: Support a broader range of JSON media types.
...
Previously, we only supported `application/json` which prevented using subtypes like `application/activity+json`. This allows for the REST API to `json_decode` the body of requests using a JSON subtype `Content-Type`. Additionally, `wp_die()` now properly sends the error as JSON when a JSON subtype is specified in the `Accept` header.
Props pfefferle.
Fixes #49404 .
Built from https://develop.svn.wordpress.org/trunk@49329
git-svn-id: http://core.svn.wordpress.org/trunk@49090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 16:44:06 +00:00
72cff29cb6
Posts, Post Types: Check if taxonomy is set for the `tax_input` parameter of `wp_insert_post()`.
...
This avoids a PHP notice when creating a post with multiple taxonomies both having a default term.
Props yakimun, szaqal21, hareesh-pillai, audrasjb.
Fixes #51320 .
Built from https://develop.svn.wordpress.org/trunk@49328
git-svn-id: http://core.svn.wordpress.org/trunk@49089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 16:42:05 +00:00
0a4f041f2a
Tests: Rename some files and classes in `phpunit/tests/post/` per the naming conventions.
...
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization
Follow-up to [47780].
See #51344 .
Built from https://develop.svn.wordpress.org/trunk@49327
git-svn-id: http://core.svn.wordpress.org/trunk@49088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 16:09:07 +00:00
919f1cf461
Docs: Fix typo in `{$old_status}_to_{$new_status}` hook description.
...
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@49326
git-svn-id: http://core.svn.wordpress.org/trunk@49087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 15:42:09 +00:00
7c32cbf990
Revert the improvenents to arranging of postboxes/metaboxes, [49179]. The current patch fixes about half a dozen problems, but seems more general improvements are needed to how Screen Options work.
...
See #50699 .
Built from https://develop.svn.wordpress.org/trunk@49325
git-svn-id: http://core.svn.wordpress.org/trunk@49086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 10:47:12 +00:00
3c554f366d
Block Editor: Update the WordPress packages for 5.6 beta 2
...
It contains:
- Fix drop zone indicators for non blocks.
- Fix archives block render function.
- Code block: preserve indentation on paste.
- Turn off autocomplete for token input.
- Fix parent post selector: ensure initial value available, search performed, all results shown.
- Fix gallery block undo issue.
Props isabel_brison.
Fixes #51640 .
Built from https://develop.svn.wordpress.org/trunk@49324
git-svn-id: http://core.svn.wordpress.org/trunk@49085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 09:34:46 +00:00
18ee84c5c2
Customize: Ensure the New Menu section is properly rendered.
...
Follow-up to [30102], [49101].
Props david.binda, boldgrid, dlh, azaozz, Clorith, westonruter, hellofromTonya.
Fixes #51592 .
Built from https://develop.svn.wordpress.org/trunk@49323
git-svn-id: http://core.svn.wordpress.org/trunk@49084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 02:48:06 +00:00
6275885400
Bundled Themes: Update latest version for `Tested up to:` in `readme.txt` files.
...
Props mukesh27.
Fixes #51501 .
Built from https://develop.svn.wordpress.org/trunk@49322
git-svn-id: http://core.svn.wordpress.org/trunk@49083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 02:18:05 +00:00
0fb5ccd4d0
Docs: Add a `@global` tag for `$user_id` in `WP_Application_Passwords_List_Table::prepare_items()`.
...
Props mukesh27.
Fixes #51633 .
Built from https://develop.svn.wordpress.org/trunk@49321
git-svn-id: http://core.svn.wordpress.org/trunk@49082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 02:12:06 +00:00
87b6c253b5
Twenty Twenty-One: Import the latest changes for 5.6 beta 2.
...
For a full list of changes since beta 1, see 9e34dca...e580895#51526 .
Built from https://develop.svn.wordpress.org/trunk@49320
git-svn-id: http://core.svn.wordpress.org/trunk@49081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-27 02:00:07 +00:00
8b3071bc1a
Administration: Accommodate long translations for "Posts" in list table headers.
...
This stems from longer translations on the User table, but this will apply to any posts column in a list table. Hyphenation should typically just apply to the column header, as the cell contents are just a count.
This does appear to have some browser inconsistencies, so may need further adjustment in the future.
Props audrasjb, justinahinon.
Fixes #50838 .
Built from https://develop.svn.wordpress.org/trunk@49317
git-svn-id: http://core.svn.wordpress.org/trunk@49079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-26 23:16:05 +00:00
6c92704e10
Taxonomy: Fix values passed to actions in `wp_modify_term_count_by_now()`.
...
Replace the `WP_Taxonomy` object with the taxonomy slug in the values passed to the actions `edit_term_taxonomy` and `edited_term_taxonomy` within `wp_modify_term_count_by_now()`.
Follow up to [49141], [49171].
Props Chouby, lcyh78.
Fixes #40351 .
Built from https://develop.svn.wordpress.org/trunk@49316
git-svn-id: http://core.svn.wordpress.org/trunk@49078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-26 23:07:06 +00:00
1ce2f12eaf
Docs: Correct description for `wp_pre_insert_user_data` filter.
...
Props audrasjb.
Fixes #51637 .
Built from https://develop.svn.wordpress.org/trunk@49314
git-svn-id: http://core.svn.wordpress.org/trunk@49076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-26 22:53:06 +00:00
cc7ba27c37
Docs: Correct DocBlock formatting for `render_block()`.
...
Follow-up to [49310].
See #51606 .
Built from https://develop.svn.wordpress.org/trunk@49312
git-svn-id: http://core.svn.wordpress.org/trunk@49074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-26 21:55:10 +00:00
483b75e682
Docs: Add missing `@since` tags for properties in some block editor classes:
...
* `WP_Block_Pattern_Categories_Registry`
* `WP_Block_Patterns_Registry`
* `WP_Block_Supports`
Follow-up to [48156], [49226].
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@49311
git-svn-id: http://core.svn.wordpress.org/trunk@49073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-26 21:51:08 +00:00
bf5917edf3
Block Editor: Fix WP_Block_Supports class compatibility with Gutenberg-provided class.
...
When using WordPress trunk with Gutenberg master, there's an incompatibility causing
the dynamic block generated classes to be omitted.
This commit refactors the block supports to fix that problem.
Props nosolosw.
Fixes #51606 .
Built from https://develop.svn.wordpress.org/trunk@49310
git-svn-id: http://core.svn.wordpress.org/trunk@49072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-26 08:31:11 +00:00
4bb4107f50
General: Use correct value for the `speak` property in various CSS files.
...
Follow-up to [49263].
Props hareesh-pillai.
Fixes #51622 .
Built from https://develop.svn.wordpress.org/trunk@49309
git-svn-id: http://core.svn.wordpress.org/trunk@49071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-26 02:25:09 +00:00
367c97df67
REST API: Prevent PHP warning when metadata schema is missing properties.
...
This switches to the new `rest_default_additional_properties_to_false()` function which doesn't have this issue and deprecates the `WP_REST_Meta_Fields::default_additional_properties_to_false()` method.
Props austin880625.
Fixes #51389 .
Built from https://develop.svn.wordpress.org/trunk@49308
git-svn-id: http://core.svn.wordpress.org/trunk@49070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-25 20:30:08 +00:00
5f5457dff2
Build Tools: Fix running installing composer dependencies using composer 2.0.
...
This updates the `dealerdirect/phpcodesniffer-composer-installer` package to allow installing version `0.7.0` which supports composer 2.0.
Props itowhid06, jrf.
Fixes #51624 .
Built from https://develop.svn.wordpress.org/trunk@49306
git-svn-id: http://core.svn.wordpress.org/trunk@49068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-25 01:14:07 +00:00
7b2c3a006e
Tests: Correct newly introduced `@covers` tags.
...
When global functions are covered, they need to be prefixed with `::` (double colon) to distinguish them from class name.
See https://phpunit.readthedocs.io/en/7.0/annotations.html#covers for more details.
Follow-up to [49000], [49171].
Props jrf.
See #39265 .
Built from https://develop.svn.wordpress.org/trunk@49305
git-svn-id: http://core.svn.wordpress.org/trunk@49067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-25 00:33:04 +00:00
5770b676b0
Docs: Correct an example in `wp_kses_normalize_entities()` description.
...
Props ediamin.
Fixes #51620 .
Built from https://develop.svn.wordpress.org/trunk@49304
git-svn-id: http://core.svn.wordpress.org/trunk@49066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-25 00:14:05 +00:00
19c72d58e7
REST API, XML-RPC: Synchronise empty comment content checks.
...
The REST API and XML-RPC now uses the same detection methodology for empty comment content as `wp_handle_comment_submission()`. Specifically, comments now have their content trimmed and '0' is allowed.
Props jaswrks, rmccue, dd32, rachelbaker, Cawa-93, aduth, TimothyBlynJacobs.
Fixes #43177 .
Built from https://develop.svn.wordpress.org/trunk@49303
git-svn-id: http://core.svn.wordpress.org/trunk@49065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-24 22:46:09 +00:00
36c4c943ba
REST API: Don't validate status if it hasn't changed.
...
In particular, this allows for sending `status=inherit` to an attachment if it's current status is `inherit`. This status would be rejected because it is an "internal" post status which isn't exposed.
As a general rule, a developer should always be able to PUT back a GET response without error.
Props dfenton, pputzer, TimothyBlynJacobs.
Fixes #40399 .
Built from https://develop.svn.wordpress.org/trunk@49302
git-svn-id: http://core.svn.wordpress.org/trunk@49064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-24 16:04:05 +00:00
abbc108d19
REST API: Make template handling resilient against plugins setting the global post.
...
Plugins shouldn't be setting the global post object during a REST API request, but if they did this could cause unexpected errors when creating a post with a template.
Props Kipperlenny, TimothyBlynJacobs.
Fixes #49695 .
Built from https://develop.svn.wordpress.org/trunk@49301
git-svn-id: http://core.svn.wordpress.org/trunk@49063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-24 14:12:05 +00:00
3a01517c90
REST API: Reuse `namespace` property instead of the undeclared `rest_namespace`.
...
Props itowhid06.
Fixes #48297 .
Built from https://develop.svn.wordpress.org/trunk@49300
git-svn-id: http://core.svn.wordpress.org/trunk@49062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-24 13:54:06 +00:00
9baba12f00
REST API: Support generating comment up links to custom posts controllers.
...
The comments controller now uses the `rest_get_route_for_post` function introduced in WordPress 5.5 to generate the link. This function is filterable to allow for custom controllers to properly define their REST API route.
Props dsifford, TimothyBlynJacobs.
Fixes #44152 .
Built from https://develop.svn.wordpress.org/trunk@49299
git-svn-id: http://core.svn.wordpress.org/trunk@49061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-24 13:20:07 +00:00
4d695ba6b3
Coding Standards: Remove unused `$current_role` variable from Add New User form.
...
Follow-up to [9614], [28296].
Props ravipatel.
Fixes #51619 .
Built from https://develop.svn.wordpress.org/trunk@49298
git-svn-id: http://core.svn.wordpress.org/trunk@49060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-24 12:49:05 +00:00
10091823f1
Coding Standards: Use consistent formatting for `<div class="wrap">` sections in `wp-admin/update-core.php`.
...
Follow-up to [28500], [28530].
Props ravipatel.
Fixes #51618 .
Built from https://develop.svn.wordpress.org/trunk@49297
git-svn-id: http://core.svn.wordpress.org/trunk@49059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-24 12:33:07 +00:00
4aca25b296
REST API: Regenerate wp-api-generated.js after [49276].
...
See #51583 .
Built from https://develop.svn.wordpress.org/trunk@49296
git-svn-id: http://core.svn.wordpress.org/trunk@49058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-24 04:29:10 +00:00
2d5d7a2aaa
REST API: Deprecate `WP_REST_Meta_Fields::register_field()`.
...
This method never worked properly and cannot be fixed due to incompatible method signatures.
Props flixos90, kadamwhite, jnylen0, TimothyBlynJacobs.
Fixes #39959 .
Built from https://develop.svn.wordpress.org/trunk@49295
git-svn-id: http://core.svn.wordpress.org/trunk@49057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-24 04:27:09 +00:00
f6d39d1c51
App Passwords: Improve accessibility.
...
- Make form inputs stacked instead of inline.
- Provide a visible label for the app name.
- Add screen reader text to dismiss button.
- Make "Revoke" button label more descriptive.
- Use aria-disabled instead of disabled to avoid focus loss.
- Display password in a readonly input to assist copy and paste.
- Remove large sections of italic text.
- Use `.form-wrap` and `.form-field` to give consistent form styling.
- Improve labeling and placeholder text.
Props alexstine, georgestephanis, afercia, TimothyBlynJacobs.
Fixes #51580 .
Built from https://develop.svn.wordpress.org/trunk@49294
git-svn-id: http://core.svn.wordpress.org/trunk@49056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-24 03:34:06 +00:00
d195b0dfbb
Docs: Add missing duplicate hook references for `allow_(dev|minor|major)_auto_core_updates` filters.
...
Follow-up to [49254].
See #50907 .
Built from https://develop.svn.wordpress.org/trunk@49293
git-svn-id: http://core.svn.wordpress.org/trunk@49055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-24 00:31:05 +00:00
bb63c1cbd9
Upgrade/Install: Account for new `WP_AUTO_UPDATE_CORE` values in auto-updates settings form.
...
This updates `core_auto_updates_settings()` to account for the new `beta` and `rc` values for the `WP_AUTO_UPDATE_CORE` constant.
Additionally, recognize these new values as acceptable in Site Health tests.
Follow-up to [48804], [49245], [49254].
Fixes #51319 . See #50907 .
Built from https://develop.svn.wordpress.org/trunk@49292
git-svn-id: http://core.svn.wordpress.org/trunk@49054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-24 00:26:05 +00:00
e992757e5b
App Passwords: Include site_url in the success redirect payload.
...
Props georgestephanis.
Fixes #51602 .
Built from https://develop.svn.wordpress.org/trunk@49291
git-svn-id: http://core.svn.wordpress.org/trunk@49053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-24 00:07:08 +00:00
ce4b1cc8ba
Toolbar: Keep IE 11 scrollbar on the side instead of overlapping the toolbar.
...
Props sabernhardt, shital-patel, y_kolev.
Fixes #48545 .
Built from https://develop.svn.wordpress.org/trunk@49290
git-svn-id: http://core.svn.wordpress.org/trunk@49052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-23 19:49:08 +00:00
ee3dac88f0
Privacy: Use more appropriate verbiage when downloading personal data export file from a row action.
...
Props garrett-eclipse, bridgetwillard.
Fixes #49319 .
Built from https://develop.svn.wordpress.org/trunk@49289
git-svn-id: http://core.svn.wordpress.org/trunk@49051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-23 19:33:07 +00:00
d9838eed62
Posts, Post Types: Set better default title for custom post types without title support.
...
The default title is now set to "(no title supported)" instead of "Auto Draft".
Props garrett-eclipse, rajanit2000, bridgetwillard, donmhico, nrqsnchz.
Fixes #45516 .
Built from https://develop.svn.wordpress.org/trunk@49288
git-svn-id: http://core.svn.wordpress.org/trunk@49050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-23 19:09:10 +00:00
36d58abc8e
Help/About: Clarify that discouraging search engines does not prevent them from crawling the site.
...
Props carike, garrett-eclipse, hellofromTonya.
Fixes #51274 .
Built from https://develop.svn.wordpress.org/trunk@49287
git-svn-id: http://core.svn.wordpress.org/trunk@49049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-23 18:07:13 +00:00
f83aa63730
Coding Standards: Split long `printf()` calls for search results for better readability.
...
Follow-up to [49284].
See #37353 .
Built from https://develop.svn.wordpress.org/trunk@49286
git-svn-id: http://core.svn.wordpress.org/trunk@49048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-23 17:19:14 +00:00
608ba462dd
Upgrade/Install: Improve copy for opt-in to automatic major version updates.
...
Props marybaum, kebbet.
See #50907 .
Built from https://develop.svn.wordpress.org/trunk@49285
git-svn-id: http://core.svn.wordpress.org/trunk@49047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-23 16:36:14 +00:00
e0c12cc818
Administration: Unify search results message on list tables.
...
This wraps the search string in a `<strong>` tag, which makes easier to parse visually especially when your search string also contains double quotes.
Props Mista-Flo, mapk, sergeybiryukov.
Fixes #37353 .
Built from https://develop.svn.wordpress.org/trunk@49284
git-svn-id: http://core.svn.wordpress.org/trunk@49046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-23 16:01:15 +00:00
4847fb4263
Administration: Better targeting for required form field highlighting.
...
Previously, any `input` or `select` inside of a `.form-invalid` wrapper would get the red border highlighting, including submit buttons which was not visually correct. This now only applies to form elements with a class of `.form-required` inside of the `.form-invalid` wrapper. It also continues to apply the border to elements with both classes (`.form-invalid.form-required`) as that is how some of the admin markup is structured.
Plugin authors may need to do the same sort of class application seen in this commit, i.e. add `.form-required` to certain form elements.
Props sabernhardt, dilipbheda, helen.
Fixes #50686 .
Built from https://develop.svn.wordpress.org/trunk@49283
git-svn-id: http://core.svn.wordpress.org/trunk@49045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-23 15:05:09 +00:00
298cd04a63
Coding Standards: Update some alignment in `wp-admin/authorize-application.php` for consistency.
...
Save blogs count to a variable for reusing.
Follow-up to [49270].
See #51489 .
Built from https://develop.svn.wordpress.org/trunk@49282
git-svn-id: http://core.svn.wordpress.org/trunk@49042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-23 01:19:06 +00:00
0a70f9b004
Docs: Document the return value of `wp_prepare_attachment_for_js()` using hash notation.
...
Props stevenlinx, Mista-Flo, johnbillion.
Fixes #50835 .
Built from https://develop.svn.wordpress.org/trunk@49281
git-svn-id: http://core.svn.wordpress.org/trunk@49041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-23 00:43:07 +00:00
57ae91be78
Build/Test Tools: Remove debug text included in [49267].
...
See #50401 .
Built from https://develop.svn.wordpress.org/trunk@49280
git-svn-id: http://core.svn.wordpress.org/trunk@49040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-22 18:12:01 +00:00
ce34d0ab00
App Passwords: Support an app_id to uniquely identify instances of an app.
...
Apps may now optionally include an `app_id` parameter when directing the user to the Authorize Application screen. This allows for instances of an application to be identified and potentially revoked or blocked.
Props TimothyBlynJacobs, georgestephanis.
Fixes #51583 .
Built from https://develop.svn.wordpress.org/trunk@49276
git-svn-id: http://core.svn.wordpress.org/trunk@49038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-22 15:06:09 +00:00
83c900e8b3
Upgrade/Install: Add missing `</form>` tag in auto-updates settings form.
...
Props imath, ahortin, dd32, afragen.
Fixes #51598 . See #50907 .
Built from https://develop.svn.wordpress.org/trunk@49274
git-svn-id: http://core.svn.wordpress.org/trunk@49036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-22 03:38:10 +00:00
fe8bb3ea58
App Passwords: Fix success=false not being appended to fallback reject url.
...
Props TimothyBlynJacobs, georgestephanis.
Fixes #51581 .
Built from https://develop.svn.wordpress.org/trunk@49272
git-svn-id: http://core.svn.wordpress.org/trunk@49034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-22 02:44:05 +00:00
9dc6d6147a
XML-RPC: Fix length validation of anonymous commenter's email address.
...
Fix the first step of validating an anonymous commenters in which the length is checked prior to running regular expressions.
Follow up to [47808].
Fixes #51595 .
Built from https://develop.svn.wordpress.org/trunk@49271
git-svn-id: http://core.svn.wordpress.org/trunk@49033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-22 02:42:06 +00:00
85c49351af
App Passwords: Explain that apps can access to all sites in a network.
...
Props georgestephanis, spacedmonkey, johnjamesjacoby, SergeyBiryukov, marybaum.
Fixes #51489 .
Built from https://develop.svn.wordpress.org/trunk@49270
git-svn-id: http://core.svn.wordpress.org/trunk@49032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-22 02:36:11 +00:00
cd04c0d68b
Build/Test Tools: Only define `WP_PLUGIN_DIR` in when running core tests.
...
This takes into account non-core plugins that rely on `WP_PLUGIN_DIR` being set to the expected plugin's directory in `WP_CONTENT_DIR`, or already have the constant defined.
Follow-up to [49236].
Props pierlo.
Fixes #51594 .
Built from https://develop.svn.wordpress.org/trunk@49269
git-svn-id: http://core.svn.wordpress.org/trunk@49031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-22 00:44:05 +00:00
f8e9df7a95
Tests: Use shared fixtures in XML-RPC new comment unit tests.
...
See #51344 .
Built from https://develop.svn.wordpress.org/trunk@49268
git-svn-id: http://core.svn.wordpress.org/trunk@49030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-22 00:19:08 +00:00
a8abe177a4
Build/Test Tools: Pass GitHub Action related environment variables to the Docker container.
...
This ensures that `WP_UnitTestCase::skipOnAutomatedBranches()` has access to these variables so that time sensitive tests can be skipped when appropriate.
This also updates that logic to be more clear.
Follow up to [49264].
Props ocean90, johnbillion.
See #50401 , #49050 , #47767 .
Built from https://develop.svn.wordpress.org/trunk@49267
git-svn-id: http://core.svn.wordpress.org/trunk@49029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-21 19:57:10 +00:00
ecf8e59918
Docs: Add a `@since` note about `async_direct_test` key to the `site_status_tests` filter.
...
Follow-up to [49232].
See #51547 .
Built from https://develop.svn.wordpress.org/trunk@49266
git-svn-id: http://core.svn.wordpress.org/trunk@49028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-21 14:55:09 +00:00
bbfc20ee44
Coding Standards: Rename a variable in `wp-login.php` for consistency with other instances.
...
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@49265
git-svn-id: http://core.svn.wordpress.org/trunk@49027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-21 14:46:05 +00:00
f9902dc742
Build/Test Tools: Skip some tests when not in the primary branch.
...
This skips time sensitive tests when GitHub Actions workflows are not being run on `master` branch.
See #50401 , #39486 .
Built from https://develop.svn.wordpress.org/trunk@49264
git-svn-id: http://core.svn.wordpress.org/trunk@49026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-21 14:07:09 +00:00
a7d6e929c9
Administration: Fix an invalid property in the Dashicons CSS file.
...
Props komagain.
Fixes #51587 .
Built from https://develop.svn.wordpress.org/trunk@49263
git-svn-id: http://core.svn.wordpress.org/trunk@49025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-21 13:16:07 +00:00
990875a7ae
Post-post WordPress 5.6 beta 1 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@49262
git-svn-id: http://core.svn.wordpress.org/trunk@49024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-20 22:23:05 +00:00
a0f350b597
Post-WordPress 5.6 Beta 1 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@49261
git-svn-id: http://core.svn.wordpress.org/trunk@49023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-20 22:19:06 +00:00
7e29e531bd
WordPress 5.6 Beta 1.
...
Built from https://develop.svn.wordpress.org/trunk@49260
git-svn-id: http://core.svn.wordpress.org/trunk@49022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-20 21:47:06 +00:00
fcc04a6a37
Coding Standards: Fix WPCS issues in [49258].
...
See #46619 .
Built from https://develop.svn.wordpress.org/trunk@49259
git-svn-id: http://core.svn.wordpress.org/trunk@49021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-20 21:20:07 +00:00
e1e6e949ff
Privacy: Add "Mark as completed" action.
...
Props garrett-eclipse, ocean90, joostdevalk, mista-flo, helen.
Fixes #46619 .
Built from https://develop.svn.wordpress.org/trunk@49258
git-svn-id: http://core.svn.wordpress.org/trunk@49020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-20 21:07:07 +00:00
7fe78e2f18
REST API: Make sure all supported JSON Schema keywords are output in the index.
...
Previously, only a small subset of keywords were exposed which limited the utility of `OPTIONS` requests.
Props raubvogel, TimothyBlynJacobs.
Fixes #51020 .
Built from https://develop.svn.wordpress.org/trunk@49257
git-svn-id: http://core.svn.wordpress.org/trunk@49019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-20 20:19:09 +00:00
fbd8078d4e
Comments: Add a filter for top level comments query arguments in `comments_template()`.
...
Props hellofromTonya, Howdy_McGee, garrett-eclipse, davidbaumwald, thomaslhotta.
Fixes #38074 .
Built from https://develop.svn.wordpress.org/trunk@49256
git-svn-id: http://core.svn.wordpress.org/trunk@49018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-20 20:11:06 +00:00
desrosj
Sergey Biryukov
whyisjake
John Blackbourn
Helen Hou-Sandí
TimothyBlynJacobs
Andrew Ozz
youknowriad
Peter Wilson
Aaron Campbell