WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
29,551 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

73 Commits

Author SHA1 Message Date
Dominik Schilling 9b79c36713 WP_Filesystem: Change `WP_Filesystem_FTPext::exists()` and `WP_Filesystem_ftpsockets::exists()` to return true for empty directories. 
Both methods are using *nlist() which returns a list of files in a given directory or the file itself for a given file. If the result was an empty list we assumed that the file doesn't exists. This includes also cases where $file is actually an empty directory. To prevent this we now check if $file is a directory before returning the result of an empty list.
Other filesystem methods are using `file_exists()` which already checks whether a file or directory exists.

fixes #30815.
Built from https://develop.svn.wordpress.org/trunk@31815


git-svn-id: http://core.svn.wordpress.org/trunk@31797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-18 19:22:27 +00:00
Scott Taylor 6fa7021d62 Calling `->chown()` and `->chgrp()` in `WP_Filesystem_FTPext` produces no side-effects. Remove the calls. `->chgrp()` is defined in the super class, and does nothing, can be removed from the child class. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31215


git-svn-id: http://core.svn.wordpress.org/trunk@31196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 21:07:24 +00:00
Scott Taylor 895794f74d In `WP_Filesystem_Base` subclasses that set `$wp_base`, remove this dead code. 
Unused since [8009] - "Make WP_Filesystem work with new directory constants"

There is currently no declared field and no `@property` annotation.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31209


git-svn-id: http://core.svn.wordpress.org/trunk@31190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 17:23:22 +00:00
Scott Taylor b29a20b90a `WP_Filesystem_Base` should declare `$errors` and `$options` as fields for use by subclasses. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31208


git-svn-id: http://core.svn.wordpress.org/trunk@31189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 17:10:43 +00:00
Scott Taylor da99d29a59 Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31125


git-svn-id: http://core.svn.wordpress.org/trunk@31106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 06:13:22 +00:00
Scott Taylor 574fabf2bc Improve some `wp-admin/includes/class-wp-filesystem-*.php` docs for `@param`. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@30978


git-svn-id: http://core.svn.wordpress.org/trunk@30964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-20 20:40:23 +00:00
Scott Taylor 37a23b2c73 Improve various `@param` docs. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30682


git-svn-id: http://core.svn.wordpress.org/trunk@30672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 02:17:21 +00:00
Scott Taylor da4c39480f Improve various `@param` docs for `src/wp-admin/includes/class-wp-filesystem-*.php`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30678


git-svn-id: http://core.svn.wordpress.org/trunk@30668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 00:13:22 +00:00
Scott Taylor 0dbc6b37a7 Add access modifier (`public`) to members and methods in `WP_Filesystem_FTPext`. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28489


git-svn-id: http://core.svn.wordpress.org/trunk@28315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 00:12:15 +00:00
Sergey Biryukov cdba99d3b3 Being consistent is the gist, no single @since should have been missed. 
see #26713.
Built from https://develop.svn.wordpress.org/trunk@26869


git-svn-id: http://core.svn.wordpress.org/trunk@26755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-25 02:00:11 +00:00
Dion Hulse c43600ea4b First pass at documenting the WP_Filesystem methods. This also introduces stubs of the methods into the base class which are documented, which subclasses can override, some methods were cleaned up at the same time. 
See #18476 See #23122. Props kurtpayne, bananastalktome, and, DrewAPicture 

Built from https://develop.svn.wordpress.org/trunk@25560


git-svn-id: http://core.svn.wordpress.org/trunk@25478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-22 04:44:10 +00:00
Dion Hulse 26ebfca466 Make use of the mbstring.func_overload helper functions in WP_Filesystem so byte lengths are properly determined. See #25259 Fixes #25237 
Built from https://develop.svn.wordpress.org/trunk@25349


git-svn-id: http://core.svn.wordpress.org/trunk@25311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-11 08:27:10 +00:00
Dion Hulse 7a6fad844a WP_Filesystem: Let the code breathe, add some additional whitespace between method definitions and comments. 
Built from https://develop.svn.wordpress.org/trunk@25305


git-svn-id: http://core.svn.wordpress.org/trunk@25267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-09 02:55:09 +00:00
Dion Hulse 6d1ffc62ea WP_Filesystem: Ensure that all files are read/written correctly by verifying the return values from fwrite() and using FTP_BINARY mode (ASCII converts line endings as per the spec). See #25237 
Built from https://develop.svn.wordpress.org/trunk@25304


git-svn-id: http://core.svn.wordpress.org/trunk@25266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-09 02:43:08 +00:00
dd32 2a708450ec WP_Filesystem: Return symlinked directory names correctly, previously the FTP extensions would return it as 'source -> dest' instead of simply 'source'. Props kurtpayne. Fixes #17846 
git-svn-id: http://core.svn.wordpress.org/trunk@21223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-06 11:39:39 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-08 17:01:11 +00:00
dd32 53062d6414 WP_Filesystem_*::mkdir() untrailingslash path consistently, don't waste time attempting to create an "empty" path. See #15575. Props lordandrei and SergeyBiryukov for initial patches. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-13 10:43:38 +00:00
duck_ c1d1590171 Fix typos in documentation (wp-admin/). See #18560. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-03 14:18:10 +00:00
ryan 04487fc268 Constructor cleanup. Props ocean90. fixes #16768 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-29 20:05:12 +00:00
dd32 a83a2842ea Optimisations to WP_Filesystem; Pass known information to called functions. Props aldenta (John Ford) for investigation and patch. See #10913 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-03-22 00:04:15 +00:00
dd32 b9eff36d8d Reinstate the custom chmod value in FtpExt. Accidentally removed in r12998. Props reaperhulk. Fixes #13667 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-01 04:11:29 +00:00
dd32 629432887e Return false on WP_Filesystem_FTPext::dirlist() for non-existant folders. See #12232. See #12057 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-17 04:00:59 +00:00
dd32 d5ee7bca10 Replace use of tmpfile() with a safe get_temp_dir(). tmpfile() may use a temporary directly which is not writable. Add static caching to get_temp_dir() & better protect against bad server configs. Fixes #12866 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-06 11:20:51 +00:00
dd32 28b30dec84 Fix typo in r13850. See #12232 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-28 08:23:46 +00:00
dd32 a47cdd86cb Attempt to work around Mac FTP Server security implications of using '-a' in FTP. Props eoinomurchu. See #12232 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-28 01:07:03 +00:00
nacin 30d6eb32c6 Remove redundant isset() and empty() checks. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-19 21:29:21 +00:00
nacin 3dcd9176de s/existant/existent/ 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-24 20:01:37 +00:00
nacin cfa428b8d2 Use stripos() instead of strpos() with strtolower(). For PHP < 5 we have stripos() in compat.php. Fixes #11176 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-14 02:27:19 +00:00
dd32 65176075c0 Standardise return values in WP_Filesystem::dirlist(), ::chmod() and ::exists() 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-07 01:59:30 +00:00
dd32 a87c1e3ca9 Reduce code duplication, Formatting cleanups, Reduce Chmod IO calls. See #10913 for excess IO calls. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-07 01:31:40 +00:00
dd32 a8793e00c0 Fix recursive chmod for WP_Filesystem. Props reaperhulk for FtpExt. Fixes #11261 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-07 01:12:29 +00:00
ryan 6da55f7792 Trailing whitespace cleanup 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-15 22:11:12 +00:00
dd32 41e561b941 Standardise WP_Filesystem_*::put_contents() arguments to support chmod reliably across all transports. Fixes #10889 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-14 09:23:53 +00:00
ryan e2c408bfbe Pass correct number of args to ftp_chdir(). Props Denis-de-Bernardy. see #10889 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-10 23:03:25 +00:00
ryan 1ddec52d4e Fix wpfs root dir location. Props dd32. fixes #11152 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-23 21:52:13 +00:00
azaozz 103ba096a7 Include 'hidden' directories in filesystem dirlist by default, props dd32, fixes #10774 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-15 02:21:00 +00:00
ryan 8e3808bce2 Remove trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-14 14:03:32 +00:00
azaozz 5c21d67399 WP_Filesystem fixes and phpdoc, props hakre dd32, see #10304 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-16 08:34:53 +00:00
azaozz ca27f326a9 Add constants for ftp connections timeouts, props dd32, see #10522 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-15 12:01:04 +00:00
azaozz 73de56d05e Fix WP_Filesystem_FTPext->exists(), props dd32, fixes #10060 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-15 08:31:06 +00:00
westi 7a9955a64a Fix plugin/theme upgrade issues when using ftp extension. Fixes #9980 props DD32. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-30 17:14:07 +00:00
ryan 515487d39c Check if not exists and not is_dir before bailing. Props st3ff3n. fixes #9274 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-24 17:12:21 +00:00
ryan 1cd542a5e2 consolidate plugin/theme/core upgrade/install functions. Props DD32. see #7875 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-19 19:36:28 +00:00
ryan ff657986ff Revert FTP parts of [10919]. fixes #9535 see #9525 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-14 17:16:44 +00:00
ryan 31a2bbad76 WPFS cleanups. Props DD32. fixes #9525 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-13 16:11:02 +00:00
ryan e89192b1a8 Strip trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-09 18:03:31 +00:00
westi f9a218eb6b Switch the ftpext filesystem to use Passive FTP aswell. Fixes #7940 props mcs_trekkie. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-21 17:59:15 +00:00
westi 121f0754c6 Autodetect binary files for FTP filesystems. Fixes #7568 props DD32. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-09-26 06:53:57 +00:00
ryan d3abd242b0 Don't append HTTPOnly if cookie domain is empty. see #7677 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-09-05 05:35:58 +00:00
westi 7f894ae416 phpdoc for wp-admin. See #7496 props santosj. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-08-14 06:30:38 +00:00