Drew Jaynes
ed0421e7de
Add a proper return description for the `wp_xmlrpc_server->addTwoNumbers()` method.
...
See [30181]. See #30224 .
Built from https://develop.svn.wordpress.org/trunk@32557
git-svn-id: http://core.svn.wordpress.org/trunk@32527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:26:26 +00:00
Drew Jaynes
7a93dda2d2
Add proper descriptions for the `$methods`, `$blog_options`, and `$error` properties in `wp_xmlrpc_server`.
...
See [30181]. See #30224 .
Built from https://develop.svn.wordpress.org/trunk@32556
git-svn-id: http://core.svn.wordpress.org/trunk@32526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:23:25 +00:00
Scott Taylor
ecf4c668b3
Upgrade the doc blocks in `class-wp-xmlrpc-server.php`. Rehabilitate some unfortunate use of tabbing.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32550
git-svn-id: http://core.svn.wordpress.org/trunk@32520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 19:37:24 +00:00
Dominik Schilling
60c9fdf9fd
Merge similar error strings for invalid data.
...
props pavelevap.
fixes #32329 .
Built from https://develop.svn.wordpress.org/trunk@32477
git-svn-id: http://core.svn.wordpress.org/trunk@32447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 21:09:25 +00:00
Sergey Biryukov
7a6cba1308
Remove duplicate string with a typo, merge it with an existing string.
...
props pavelevap.
fixes #32020 .
Built from https://develop.svn.wordpress.org/trunk@32209
git-svn-id: http://core.svn.wordpress.org/trunk@32182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 15:27:25 +00:00
John Blackbourn
c996169c04
Correctly set the post author in `wp_xmlrpc_server::mw_editPost()` when the current user is not the author of the post.
...
Props redsweater, markoheijnen, DrewAPicture
Fixes #24916
Built from https://develop.svn.wordpress.org/trunk@31983
git-svn-id: http://core.svn.wordpress.org/trunk@31962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 15:49:30 +00:00
Sergey Biryukov
53a704a67a
Fix a typo in [30138].
...
see #30224 .
Built from https://develop.svn.wordpress.org/trunk@31279
git-svn-id: http://core.svn.wordpress.org/trunk@31260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 09:48:21 +00:00
Scott Taylor
fe6b5983df
In PHP 5.0.0, `is_a()` became deprecated in favour of the `instanceof` operator. Calling `is_a()` would result in an `E_STRICT` warning.
...
In PHP 5.3.0, `is_a()` is no longer deprecated, and will therefore no longer throw `E_STRICT` warnings.
To avoid warnings in PHP < 5.3.0, convert all `is_a()` calls to `$var instanceof WP_Class` calls.
`instanceof` does not throw any error if the variable being tested is not an object, it simply returns `false`.
Props markoheijnen, wonderboymusic.
Fixes #25672 .
Built from https://develop.svn.wordpress.org/trunk@31188
git-svn-id: http://core.svn.wordpress.org/trunk@31169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 01:06:24 +00:00
Scott Taylor
0e84d59de5
In `wp_xmlrpc_server`, only allow `__call()` to run against `->_multisite_getUsersBlogs()`.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31149
git-svn-id: http://core.svn.wordpress.org/trunk@31130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 22:31:22 +00:00
Scott Taylor
0a511680f4
Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Constructors do not have meaningful return values, anything that is returned from here is discarded.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31126
git-svn-id: http://core.svn.wordpress.org/trunk@31107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 06:54:23 +00:00
Scott Taylor
ac6fddee35
In `wp_xmlrpc_server`, remove dead code.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31092
git-svn-id: http://core.svn.wordpress.org/trunk@31073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:21:22 +00:00
Scott Taylor
60b0cd7943
The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.
...
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31090
git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:05:25 +00:00
Scott Taylor
ac4e67b82e
Perl-style comments should not be used
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31079
git-svn-id: http://core.svn.wordpress.org/trunk@31060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:52:24 +00:00
Scott Taylor
e619abda6e
Improve various `@param` docs for `src/wp-includes/*`.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30681
git-svn-id: http://core.svn.wordpress.org/trunk@30671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 01:34:24 +00:00
Scott Taylor
c598d35e41
Almost every method in `wp_xmlrpc_server` can also return `IXR_Error` and should be labeled as such. Rehabilitate some `return` syntax.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30181
git-svn-id: http://core.svn.wordpress.org/trunk@30181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 03:04:22 +00:00
Scott Taylor
be707cd614
In `wp_xmlrpc_server` methods, for comprehensibility:
...
* initialize arrays in loops, instead of overriding an uninitialized array each time
* in `->blogger_getRecentPosts()` and `->mw_getRecentPosts()`, remove the extra loops by only setting one `array`
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30153
git-svn-id: http://core.svn.wordpress.org/trunk@30153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 19:45:25 +00:00
Scott Taylor
65ab0a188e
In `wp_xmlrpc_server->pingback_ping()`, remove the internal variable `$way` each time it is set and not used.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30139
git-svn-id: http://core.svn.wordpress.org/trunk@30139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:50:21 +00:00
Scott Taylor
4f6745e9aa
In `wp_xmlrpc_server` methods, don't set `$blog_id` internally if it is never used, which is almost always. Updates the docs.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30138
git-svn-id: http://core.svn.wordpress.org/trunk@30138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:44:23 +00:00
Scott Taylor
0d3270282d
In `wp_xmlrpc_server->_prepare_comment()`, `$comment_date` is set internally but never used.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30137
git-svn-id: http://core.svn.wordpress.org/trunk@30137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 01:29:24 +00:00
Sergey Biryukov
a32a75b9f4
XML-RPC: Check if category support was added for pages before calling wp_get_post_categories() to avoid unnecessary query in wp.getPage.
...
props markoheijnen, nprasath002.
fixes #17920 .
Built from https://develop.svn.wordpress.org/trunk@29731
git-svn-id: http://core.svn.wordpress.org/trunk@29505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-11 13:56:15 +00:00
Sergey Biryukov
871d808588
XML-RPC: Avoid a PHP notice in pingback_ping() method.
...
props jesin, simonp303.
fixes #29177 .
Built from https://develop.svn.wordpress.org/trunk@29464
git-svn-id: http://core.svn.wordpress.org/trunk@29242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-11 15:19:18 +00:00
Peter Westwood
1f147d24b1
XMLRPC: Switch the file deletion alias to be deleteFile to more closely make uploadFile.
...
Fixes #5310 props SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@29255
git-svn-id: http://core.svn.wordpress.org/trunk@29038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-20 14:02:15 +00:00
Drew Jaynes
3665b5a1a1
Add periods to short descriptions for magic methods added in [28501], [28521], and [28524].
...
See #22234 and #28885 .
Built from https://develop.svn.wordpress.org/trunk@29165
git-svn-id: http://core.svn.wordpress.org/trunk@28949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 01:12:14 +00:00
Drew Jaynes
5f87736bc4
Fill out inline documentation for the `__call()` magic method added to the `wp_xmlrpc_server` class in [28515].
...
See #22234 and #28885 .
Built from https://develop.svn.wordpress.org/trunk@29161
git-svn-id: http://core.svn.wordpress.org/trunk@28945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 00:46:15 +00:00
Peter Westwood
105d9ce9cc
XMLRPC: Restore support in wp.newPost for dates to be supplied in the structured dateTime.iso8601 format as well as still supporting dates specified as strings.
...
Fixes #28601 .
Built from https://develop.svn.wordpress.org/trunk@29063
git-svn-id: http://core.svn.wordpress.org/trunk@28849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 14:17:15 +00:00
Sergey Biryukov
81b8b6cfbc
XML-RPC: Make sure wp.newPost does not produce a fatal error when a post_date field is included in the data.
...
props dllh.
fixes #28601 .
Built from https://develop.svn.wordpress.org/trunk@28854
git-svn-id: http://core.svn.wordpress.org/trunk@28657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-26 17:43:14 +00:00
Sergey Biryukov
d7f9b38c3e
XML-RPC: Add wp.deleteMediaItem as an alias to wp_deletePost.
...
props fahmiadib.
fixes #5310 .
Built from https://develop.svn.wordpress.org/trunk@28849
git-svn-id: http://core.svn.wordpress.org/trunk@28653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-26 15:21:15 +00:00
Scott Taylor
05eeb16e30
Replace all uses of `like_escape()` with `$wpdb->esc_like()`.
...
Props miqrogroove.
See #10041 .
Built from https://develop.svn.wordpress.org/trunk@28712
git-svn-id: http://core.svn.wordpress.org/trunk@28528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-10 00:44:15 +00:00
Scott Taylor
cd96841632
`wp_xmlrpc_server::wp_getPage()` should `return new IXR_Error(` instead of `return(new IXR_Error(`. One of the few places that is unparseable by static analysis.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28636
git-svn-id: http://core.svn.wordpress.org/trunk@28454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 19:22:13 +00:00
Scott Taylor
b8d469600b
These functions import `$wpdb` but do not use it.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28539
git-svn-id: http://core.svn.wordpress.org/trunk@28365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 17:37:14 +00:00
Scott Taylor
25a70283e1
Add missing access modifiers to methods in `wp_xmlrpc_server`. Add a magic `__call()` method for BC.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28515
git-svn-id: http://core.svn.wordpress.org/trunk@28341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:09:13 +00:00
Scott Taylor
a25e03f833
In `wp_xmlrpc_server::mw_editPost`, also set `$post_type = $postdata['post_type']`.
...
See #22400 , [28448].
Built from https://develop.svn.wordpress.org/trunk@28453
git-svn-id: http://core.svn.wordpress.org/trunk@28280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 18:06:15 +00:00
Scott Taylor
463b7c4620
Eliminate use of `extract()` in `wp_xmlrpc_server::mw_editPost()` (MetaWeblog API, y'all).
...
A lot of the extracted variables are overwritten by being explicitly set later.
Only set variables that would otherwise not be present with `compact()` is called.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28448
git-svn-id: http://core.svn.wordpress.org/trunk@28275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 15:19:14 +00:00
Scott Taylor
4b94efd93b
Eliminate use of `extract()` in `wp_xmlrpc_server::blogger_editPost()`.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28412
git-svn-id: http://core.svn.wordpress.org/trunk@28239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:25:15 +00:00
Drew Jaynes
5e51ea9940
Priority fixes for various existing hook documentation.
...
Props kpdesign.
See #26869
Built from https://develop.svn.wordpress.org/trunk@28083
git-svn-id: http://core.svn.wordpress.org/trunk@27914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 00:01:15 +00:00
Andrew Nacin
58ca03f8ea
XML-RPC: Fix bracing of conditionals around doc blocks.
...
props redsweater, DrewAPicture.
fixes #27506 .
Built from https://develop.svn.wordpress.org/trunk@28065
git-svn-id: http://core.svn.wordpress.org/trunk@27897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-10 21:04:14 +00:00
Andrew Nacin
a177d8bf18
Don't pass variables by reference.
...
props markjaquith.
fixes #27656 .
Built from https://develop.svn.wordpress.org/trunk@27957
git-svn-id: http://core.svn.wordpress.org/trunk@27787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 18:17:14 +00:00
Andrew Nacin
d8622b39d6
Forward pingback IP during pingback verification.
...
props tellyworth, nacin.
fixes #27613 .
Built from https://develop.svn.wordpress.org/trunk@27872
git-svn-id: http://core.svn.wordpress.org/trunk@27703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-31 20:43:18 +00:00
Drew Jaynes
c2ebd66843
Inline documentation for hooks in wp-includes/class-wp-xmlrpc-server.php.
...
Props kpdesign and DrewAPicture.
Fixes #27506 .
Built from https://develop.svn.wordpress.org/trunk@27730
git-svn-id: http://core.svn.wordpress.org/trunk@27567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 05:44:16 +00:00
Drew Jaynes
8efd225e4d
Inline documentation for hooks in wp-admin/includes/file.php.
...
Fixes #27429 .
Built from https://develop.svn.wordpress.org/trunk@27672
git-svn-id: http://core.svn.wordpress.org/trunk@27515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 02:45:15 +00:00
Andrew Nacin
5d77f8a18a
XML-RPC: In wp.editPost, Remove all terms in a taxonomy when an empty array is explicitly passed.
...
props jstraitiff, maxcutler.
fixes #26686 .
Built from https://develop.svn.wordpress.org/trunk@27554
git-svn-id: http://core.svn.wordpress.org/trunk@27397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-15 05:09:14 +00:00
Andrew Nacin
a9e69869c9
XML-RPC: Include 'sticky' in the struct returned from metaWeblog.getRecentPosts.
...
Using wp.getPosts is preferred and non-WP XML-RPC APIs are no longer actively maintained. This is simply for parity with existing MW methods.
props soulseekah.
fixes #26679 .
Built from https://develop.svn.wordpress.org/trunk@27553
git-svn-id: http://core.svn.wordpress.org/trunk@27396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-15 05:05:15 +00:00
Andrew Nacin
eb19a09f5b
Avoid saving slashed data in XML-RPC's wp.setOptions.
...
props danielbachhuber.
fixes #22936 .
Built from https://develop.svn.wordpress.org/trunk@27551
git-svn-id: http://core.svn.wordpress.org/trunk@27394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-15 04:47:13 +00:00
Drew Jaynes
cb8951b0b3
Remove all `@package` and `@subpackage` PHPDoc tags not at the file- or class-levels in core.
...
See #27200 .
Built from https://develop.svn.wordpress.org/trunk@27262
git-svn-id: http://core.svn.wordpress.org/trunk@27119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:14:14 +00:00
Drew Jaynes
cd8cedc40d
First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
...
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713 .
Built from https://develop.svn.wordpress.org/trunk@26868
git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-24 18:57:12 +00:00
Sergey Biryukov
74f77b85a6
Use get_current_site() instead of the $current_site global when possible.
...
props jeremyfelt.
fixes #25158 .
Built from https://develop.svn.wordpress.org/trunk@26120
git-svn-id: http://core.svn.wordpress.org/trunk@26032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 03:23:10 +00:00
Dominik Schilling
8688857816
Introduce show_in_menu for register_taxonomy.
...
Accepts boolean: true to show, false to hide. If not set, the default is inherited from show_ui.
fixes #20930 .
Built from https://develop.svn.wordpress.org/trunk@25133
git-svn-id: http://core.svn.wordpress.org/trunk@25113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-26 22:35:10 +00:00
Andrew Nacin
21a1fe8d4b
Use wp_safe_remote_request() and friends instead of reject_unsafe_urls = true.
...
fixes #24646 .
git-svn-id: http://core.svn.wordpress.org/trunk@24917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-31 06:52:13 +00:00
Andrew Nacin
7f12e16e47
Limit pingback response size. fixes #4137 . for trunk.
...
git-svn-id: http://core.svn.wordpress.org/trunk@24871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-29 18:00:06 +00:00
Andrew Nacin
929def2359
XML-RPC: Recursively escape arrays as before, to avoid stomping nested objects. fixes #21767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-18 14:31:25 +00:00
Andrew Nacin
44f89293f3
Update XML-RPC comment. props DrewAPicture, fixes #24751 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-17 20:19:06 +00:00
Andrew Nacin
69dbdc4951
Use wp_slash() instead of the DB layer in XML-RPC. see #21767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-16 14:38:54 +00:00
Andrew Nacin
50d0428d42
Avoid notice in XML-RPC when attaching uploads, when attachments do not have a guid in the DB. props ericmann, markoheijnen. fixes #18310 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-10 06:11:12 +00:00
Andrew Nacin
49bb647dda
XML-RPC: Save enclosures with a trailing new line. fixes #23219 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-10 03:34:35 +00:00
Andrew Nacin
b578f36b54
XML-RPC: For wp.getOptions, set readonly to true for writable options that the user does not have permission to edit.
...
props westi.
fixes #20201 .
git-svn-id: http://core.svn.wordpress.org/trunk@24597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 02:22:57 +00:00
Andrew Nacin
c2db94d10c
Use meta caps edit_post, read_post, and delete_post directly, rather than consulting the post type object. map_meta_cap() handles that for us. props markjaquith, kovshenin. fixes #23226 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 20:05:42 +00:00
Andrew Nacin
f3e96f0c60
Add strict check in wp_xmlrpc_server::set_custom_fields(). The slash strip ensures these values are the same data type, but it might not be that way forever. props xknown.
...
git-svn-id: http://core.svn.wordpress.org/trunk@24521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-27 02:46:23 +00:00
Andrew Nacin
96ee267343
Better validation of the URL used in core HTTP requests.
...
git-svn-id: http://core.svn.wordpress.org/trunk@24480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-21 06:07:47 +00:00
Peter Westwood
34001cb325
XMLRPC: Expose the admin and login urls as read-only options over xml-rpc to make it easier to write rich clients. Fixes #23446 props daniloercoli.
...
git-svn-id: http://core.svn.wordpress.org/trunk@24382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-29 11:01:32 +00:00
Sergey Biryukov
5679830030
Fix typos in comments. fixes #24337 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-14 18:22:54 +00:00
Sergey Biryukov
57c10eadbb
Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:27:31 +00:00
Sergey Biryukov
c955859738
Remove \s from regex in pingback_ping() to avoid UTF-8 issues. props tenpura. fixes #24001 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-10 16:29:00 +00:00
Mark Jaquith
acfeb6f20f
Take revision control out of the realm of a pure constant. Make it filterable.
...
* New filter: wp_revisions_to_keep
props ethitter, SergeyBiryukov. fixes #22289 .
git-svn-id: http://core.svn.wordpress.org/trunk@23818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-27 18:11:56 +00:00
Andrew Nacin
799ac18951
XML-RPC: Return an error for getRecentPosts (mw and blogger) if the user does not have edit_posts.
...
props redsweater.
fixes #22320 .
git-svn-id: http://core.svn.wordpress.org/trunk@23636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 06:52:37 +00:00
Ryan Boren
15a06a35ab
Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
...
see #WP21767
git-svn-id: http://core.svn.wordpress.org/trunk@23591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-03 16:30:38 +00:00
Ryan Boren
43a7e695e9
Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
...
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Andrew Nacin
5cd77fdb99
Revert [23359]. The post_author and comment_count post object fields will remain numeric strings for back compat. see #22324 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 19:40:26 +00:00
Ryan Boren
cc5ed3a485
Change all core API to expect unslashed rather than slashed arguments.
...
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.
Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.
Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.
Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.
Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.
Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.
Plugins should use wp_unslash() on data being passed to core API.
Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.
Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.
Remove many no longer necessary calls to $wpdb->escape() and esc_sql().
In wp_get_referer() and wp_get_original_referer(), return unslashed data.
Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.
Switch several queries over to prepare().
Expect something to break.
Props alexkingorg
see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Sergey Biryukov
1d396b8a1f
Merge two different descriptions of siteurl and home options. fixes #22771 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-01 01:35:37 +00:00
Sergey Biryukov
142f8bbe58
Cast post_author to string in XML-RPC methods. props markoheijnen. fixes #22324 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-31 01:25:26 +00:00
Andrew Nacin
82e9c40482
Validate pingback source URIs. Less verbose errors.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-22 22:30:08 +00:00
Andrew Nacin
fbf4acf638
Remove XML-RPC's blogger::getTemplate and setTemplate. They are not supported and do nothing.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 02:35:39 +00:00
Andrew Nacin
61caecfa93
Use the create_posts post type cap in more places. Remove the janky create_posts meta cap. see #16714 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 22:28:20 +00:00
Ryan Boren
55dc9d1616
Define array to avoid notice.
...
Props ericmann
fixes #22479
git-svn-id: http://core.svn.wordpress.org/trunk@22622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-16 22:14:57 +00:00
Peter Westwood
fe99b07017
XMLRPC: When Editing an existing post make sure to use wp_update_post instead of wp_insert_post so as to not perform destructive actions on the content.
...
The wp.EditPost() API will accept very limited data to only edit specific attributes of a post, if you didn't supply a category change then we would previously
overwrite the original categories with the default cat.
Fixes #22220 props nacin.
git-svn-id: http://core.svn.wordpress.org/trunk@22584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 22:58:24 +00:00
Mark Jaquith
ca7b159cc7
Squash a PHP notice in the XML-RPC server.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-13 22:35:41 +00:00
Ryan Boren
cf596d4979
In wp_xmlrpc_server::_insert_post(), preservea valid post status instead of overwriting it with 'draft'. This preserves the 'inherit' status of attachments. Props markoheijnen. fixes #22335
...
git-svn-id: http://core.svn.wordpress.org/trunk@22368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 14:44:25 +00:00
Ryan Boren
3d4470939d
In wp_xmlrpc_server::_insert_post(), don't return an error if set_post_thumbnail() returns false when the attachment ID doesn't change.
...
Props picklepete
fixes #22204
git-svn-id: http://core.svn.wordpress.org/trunk@22277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-23 14:08:20 +00:00
Andrew Nacin
64a9609aeb
Reference xmlrpc.php with the 'rpc' site_url() argument to ensure a proper scheme is applied. see #18731 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-10 21:55:36 +00:00
Andrew Nacin
dfbe93b7a5
Improve pingback text extraction by stopping at a closing block-level tag. props Otto42. see #21914 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-09 23:56:32 +00:00
Andrew Nacin
c38412a62f
Request WP_User objects when caling get_users() in XML-RPC's wp.getUsers method. see #18428 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-07 23:33:35 +00:00
Ryan Boren
7a86de87fb
Reduce use of global. Use get_blog_details() instead. fixes #22090
...
git-svn-id: http://core.svn.wordpress.org/trunk@22108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-04 12:40:09 +00:00
Andrew Nacin
8f62dfaf00
XML-RPC: Introduce wp.getRevisions and wp.restoreRevision.
...
props brandondove, koke, markoheijnen, JustinSainton, maxcutler.
fixes #21397 .
git-svn-id: http://core.svn.wordpress.org/trunk@22037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 04:17:15 +00:00
Andrew Nacin
646a4fd1e9
XML-RPC: Add an if_not_modified_since argument to wp.editPost.
...
Accepts a GMT date, which is used to compare to the current post_modified_gmt
value for the post being edited. If the post has since been edited (as in, too
old of a date was passed), the edit is rejected as overwriting a newer version.
It is rejected with a HTTP 409 Conflict status code. (Fancy.)
props koke, markoheinjen.
Tests: [UT1049]
see #21397 .
git-svn-id: http://core.svn.wordpress.org/trunk@22034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 03:39:40 +00:00
Andrew Nacin
7078e18d82
XML-RPC: Accept 'url', not 'website' in wp.editProfile. props maxcutler. see #18428 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-23 19:36:17 +00:00
Peter Westwood
2fcdb3395d
XMLRPC: Support searching via wp.getPosts() fixes #21623 props ericmann.
...
git-svn-id: http://core.svn.wordpress.org/trunk@21936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 10:18:32 +00:00
Andrew Nacin
bf3c8017a8
Introduce the xmlrpc_login_error filter, applied to the IXR_Error being returned by the server when login() fails. props JustinSainton, fixes #21907 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 01:36:47 +00:00
Andrew Nacin
c178b59da3
XML-RPC: Have the deprecated login_pass_ok() method wrap login(). Move it below login() so the proper method is found first. see #21907 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 01:27:21 +00:00
Andrew Nacin
3c4460fc86
Allow wp.uploadFile to upload the attachment to a post. props djzone, josephscott, maxcutler. fixes #13917 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 19:06:27 +00:00
Andrew Nacin
f431b408da
Combine some strings. props pavelevap. fixes #21087 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-15 19:57:05 +00:00
Andrew Nacin
6a71516a85
XML-RPC: Introduce wp.getUsers, wp.getUser, wp.getProfile, wp.editProfile.
...
props maxcutler.
props nprasath002 for earlier patches.
see #18428 .
git-svn-id: http://core.svn.wordpress.org/trunk@21824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-12 00:04:21 +00:00
Andrew Nacin
f84f149445
XML-RPC: Add the 'home' option to wp.getOptons. props mrroundhill. fixes #21822 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 01:26:38 +00:00
Andrew Nacin
26dc1e74e5
Turn XML-RPC on and remove the option on the Writing Settings page.
...
props markoheijnen for the initial patch.
Introduces a new filter, xmlrpc_enabled.
Respects any current callbacks registered to the pre_option_enable_xmlrpc
and option_enable_xmlrpc filters, for anyone forcing it off via code.
fixes #21509 .
git-svn-id: http://core.svn.wordpress.org/trunk@21804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 00:37:31 +00:00
Ryan Boren
bf9cff8bfc
Fix typo in phpdoc for wp_newPost(). Props alyssonweb. fixes #21798
...
git-svn-id: http://core.svn.wordpress.org/trunk@21765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-05 15:36:59 +00:00
Ryan Boren
c55cf716da
Use set_url_scheme(). Props johnbillion, MarcusPope. see #19037 #20759
...
git-svn-id: http://core.svn.wordpress.org/trunk@21664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-30 13:33:00 +00:00
Ryan Boren
52b3f498e6
Add tags_input, page_template, and post_category get magic to WP_Post.
...
Deprecate get_post_to_edit() and wp_get_single_post().
Props scribu
see #21309
git-svn-id: http://core.svn.wordpress.org/trunk@21651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-28 19:08:28 +00:00
Ryan Boren
f56d8278bb
Remove return ref from all calls to get_post()
...
Return WP_Post from get_default_post_to_edit()
Replace all calls to get_page() with get_post()
see #21309
git-svn-id: http://core.svn.wordpress.org/trunk@21597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 20:01:10 +00:00
Ryan Boren
489924938f
Return post_parent, menu_order, guid, and post_mime_type from wp.getPost(). Props maxcutler. fixes #21308
...
git-svn-id: http://core.svn.wordpress.org/trunk@21526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-15 16:06:05 +00:00
ryan
d286875515
switch_to_blog() and restore_current_blog() housekeeping.
...
wp-includes/admin-bar.php:
* Replace get_admin_url() and get_home_url() with admin_url() and home_url() and place them inside a switch/restore. Likewise replace current_user_can_for_blog() with current_user_can(). This avoids doing multiple switch restores.
wp-includes/ms-blogs.php:
* Deprecate the $validate argument to switch_to_blog(). This avoids a not very necessary call to get_blog_details(), possibly saving a few queries.
* Use $_wp_switched and $_wp_switched_stack instead of $switched and $switched_stack to make it less likely these globals will be stomped.
* Use GLOBALS to access blog_id and other globals. I've preferred this style lately since it makes it obvious a global is being used and avoids global blog_id being stomped by a local variable.
* Lose some is_object() checks. wp_get_current_user() always returns an object, for example.
* Call the new WP_Roles::reinit() method.
wp-includes/class-wp-xmlrpc-server.php:
* Replace current_user_can_for_blog() with current_user_can() and move it inside the switch/restore pair. This eliminates a switch/restore.
wp-includes/capabilities.php:
* Use array_keys() instead of $role => $data since $data is unused. I *think* this is a bit faster.
* Introduce WP_Roles::reinit(). This reinitializes WP_Roles and is used after switch_to_blog() has already update the blog ID in the wpdb object. If a global roles array is being used instead of the db, reinit is skipped.
* current_user_can_for_blog() now does a switch/restore. It didn't before meaning it could be reinitializing the user with the wrong role information for the current blog.
wp-includes/ms-settings.php:
* Define $_wp_switched_stack and $_wp_switched. This way switch_to_blog() and restore_current_blog() can rely on it being set.
wp-settings.php:
* Instantiate the WP_Roles global. This was it is always defined during init. To remove the WP_Roles checks from WP_Role and WP_User this would probably have to move before plugins are loaded, which might not be a good thing.
wp-includes/functions.php:
* Update wp_upload_dir() to reference _wp_switched.
git-svn-id: http://core.svn.wordpress.org/trunk@21485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 16:28:15 +00:00
ryan
5ca54e7d2f
Deprecate get_blog_option(), add_blog_option(), update_blog_option(), and delete_blog_option().
...
Use the regular option functions wrapped in switch_to_blog() and restore_current_blog() instead.
Group multiple operations within a single switch where possible.
fixes #21432
git-svn-id: http://core.svn.wordpress.org/trunk@21414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-03 17:51:42 +00:00
nacin
81c22c98f8
Don't use switch_to_blog() in wp.getUsersBlogs to improve performance and memory footprint. props mohanjith for initial patch. fixes #20665 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 11:49:02 +00:00
nacin
e0012c7e67
Initialize a variable. props maxcutler. fixes #21058 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-28 19:04:42 +00:00
nacin
9b7e633336
Use set_post_format(), not wp_set_post_terms(), in XML-RPC mw_newPost and mw_editPost. props koke. see #20697 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-26 21:07:12 +00:00
nacin
1270e4cef6
Check XML-RPC cap before running the query. props maxcutler. see #20991 for trunk.
...
git-svn-id: http://core.svn.wordpress.org/trunk@21137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-26 19:04:10 +00:00
nacin
92efcbaf6d
Combine 'Invalid term ID.' into the 'Invalid term ID' string. props pavelevap. fixes #20809 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@20996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 16:25:05 +00:00
ryan
eaa419dba3
Consolodate some strings. Props pavelevap. fixes #20809
...
git-svn-id: http://core.svn.wordpress.org/trunk@20972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 19:05:30 +00:00
ryan
f35fdc678f
Introduce _prepare_comment(). Avoid repeated auth attempts. Props maxcutler. fixes #20703
...
git-svn-id: http://core.svn.wordpress.org/trunk@20856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-23 20:40:40 +00:00
ryan
4077461708
Fix post limiting in wp_getPosts(). Props djcp. fixes #20723
...
git-svn-id: http://core.svn.wordpress.org/trunk@20846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-22 22:25:17 +00:00
ryan
0983e9afcb
Fix wp.getPages response when fetching pages the current user does not have caps for. Props maxcutler, redsweater. fixes #20629
...
git-svn-id: http://core.svn.wordpress.org/trunk@20807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-16 18:06:34 +00:00
ryan
5729685cb7
Remove accidental bits in [20784]
...
git-svn-id: http://core.svn.wordpress.org/trunk@20785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-14 17:01:35 +00:00
ryan
7c3c1267ec
Call filters for default option values only as needed to reduce number of filter calls. Props Ott042. see #20448
...
git-svn-id: http://core.svn.wordpress.org/trunk@20784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-14 17:00:13 +00:00
duck_
2b6e2d287a
Minor XML-RPC documentation improvements. See #20566 .
...
Also make newly introduced _is_greater_than_one() private.
git-svn-id: http://core.svn.wordpress.org/trunk@20782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-14 10:10:01 +00:00
ryan
34a92a5f0e
Remove extra underscore from XML-RPC filter. props maxcutler. fixes #20549
...
git-svn-id: http://core.svn.wordpress.org/trunk@20775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-11 21:04:47 +00:00
ryan
8c114f0c54
Pinking shears
...
git-svn-id: http://core.svn.wordpress.org/trunk@20715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-03 16:41:59 +00:00
duck_
281ad053fc
Declare visibility of _prepare_post_type() as protected. See #20566 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@20714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-03 15:59:50 +00:00
nacin
296a97f566
We indent with spaces, not tabs. props sivel. fixes #20394 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@20703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-02 21:13:08 +00:00
nacin
778c887fef
Have the $fields argument for XML-RPC's wp.getPostType, getPostTypes, wp.getTaxonomy and wp.getTaxonomies take the names of the post type or taxonomy object keys that will be returned.
...
* capabilities becomes cap
* object_types becomes object_type
fixes #17626 .
git-svn-id: http://core.svn.wordpress.org/trunk@20696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-02 20:29:34 +00:00
nacin
9bb0b895da
Kill all notices in XML-RPC found when running the test suite with WP_DEBUG. see [UT706], [UT707]. see #20566 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@20671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-01 21:03:50 +00:00
nacin
a6b1be42b4
Fix copy-paste issues in XML-RPC's _prepare_taxonomy(). see #20566 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-01 20:33:06 +00:00
nacin
6fff51eebe
Use correct variables. props batmoo. fixes #20566 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-01 01:11:18 +00:00
nacin
f8eeababd4
Use correct variables. props batmoo. fixes #20566 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-30 23:45:01 +00:00
nacin
57488f2a54
Add @param for the $fields parameter for XML-RPC's _prepare_taxonomy(). props SergeyBiryukov, fixes #20566 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-30 00:25:14 +00:00
nacin
ede4e67046
Check for the existence of a post before calling current_user_can() with a meta cap on that object. fixes #20336 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-30 00:19:32 +00:00
nacin
ae772d3850
Introduce minimum_args() method in XML-RPC and leverage it to return errors for insufficient arguments for methods that are new in 3.4.
...
props maxcutler, markoheijnen.
fixes #20394 .
git-svn-id: http://svn.automattic.com/wordpress/trunk@20636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-28 21:25:25 +00:00
nacin
1627408d5a
Use correct variable. Caught by unit tests. see #20566 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-28 21:22:07 +00:00
nacin
f4fc857b9c
Clean up the XML-RPC 3.4 methods with regards to consistency and future compatibility.
...
* Limit returned taxonomy and post type objects to a specific type-cast whitelist of fields.
* Add $filter and $fields to wp.getTaxonomies to match the functionality of wp.getPostTypes.
* Prevent the post type from being chnaged in _insert_post().
* Don't check post_type_supports() in _insert_post().
* Align handling of sticky posts with those of core.
* Force tags and categories to go through terms and terms_names, rather than tags_input and post_category.
fixes #20566 . props nacin, maxcutler.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-28 18:48:10 +00:00
ryan
d2fbbd1649
XML-RPC featured image and media preparation cleanup.
...
* Introduce _prepare_media_item().
* Use it to prepare post_thumbnail info in _prepare_post().
* Also use _prepare_media_item() in wp_getMediaLibrary() and wp_getMediaItem() so that all media is prepared consistently and uses the same filters.
Props maxcutler
Fixes #20409
git-svn-id: http://svn.automattic.com/wordpress/trunk@20608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-26 20:56:52 +00:00
nacin
e27fb96dee
Remove duplicated do_action wp.getPosts call. props maxcutler.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-26 16:28:06 +00:00
nacin
1214aa9870
Remove extra underscore from four XML-RPC filters. props maxcutler. fixes #20549 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-25 22:28:43 +00:00
nacin
58050466eb
Do not check for a meta value in XML-RPC set_custom_fields unless we know we are editing a key. Prevents a notice when a custom field is being deleted. props scott.gonzalez. fixes #20543 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-25 14:26:31 +00:00
ryan
04a9e7a552
Revert [20568] until a publish_post cap is introduced. see #20474
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-24 16:22:12 +00:00
ryan
0bffacac50
Check the publish_post cap when publishing an already existing post.
...
Props nprasath002
Fixes #20474
git-svn-id: http://svn.automattic.com/wordpress/trunk@20568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-23 21:54:30 +00:00
ryan
9cbd3def67
Require the edit_posts capability for wp_getPostFormats.
...
Props maxcutler.
Fixes #20154
git-svn-id: http://svn.automattic.com/wordpress/trunk@20566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-23 21:41:50 +00:00
nacin
9ef37a9427
Move from $taxonomy_name to $taxonomy in XML-RPC for consistency with the rest of the core APIs. props maxcutler, fixes #20397 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-15 16:47:31 +00:00
nacin
915477e841
Move from 'featured image' to 'post thumbnail' in the XML-RPC API. props maxcutler, fixes #20396 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-13 20:23:31 +00:00
nacin
a312778602
Remove duplicated featured_image block. props koke.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-09 15:28:07 +00:00
duck_
e25e2fb081
Prevent notice "Undefined variable: struct" in mt_getRecentPostTitles when posts exist, but none of them are editable. Fixes #20393 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-08 09:40:04 +00:00
westi
65e8cf47ed
XMLRPC: Make sure that we always return valid dates when no date is currently set - for example if the post is pending. Fixes #19733 props markoheijnen and koke.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-04 21:32:28 +00:00
westi
4b31ce3cd2
XMLRPC: Add a check in mw.newPost to stop the authorID being changed to an invalid value. Fixes #20356 props maxcutler.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-04 20:11:21 +00:00
westi
1e62ff3689
XMLRPC: In mw_newPost check to see if the post_status has been supplied before trying to use it to avoid undefined array access notices. Fixes #19774 props maxcutler.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-29 13:13:13 +00:00
westi
fabdd204c0
XMLRPC: Fix bugs in mw_editPost hilighted by tests in [UT593]
...
* Feature image code did not actually set the feature image - See #18429
* This api call could trash post data - Fixes #20321 .
git-svn-id: http://svn.automattic.com/wordpress/trunk@20322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-29 11:59:51 +00:00
westi
944af3e88b
XMLRPC: Fix the featured image support in mw_newPost to use the correct variable names. See #18429 and [UT592].
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-29 11:06:17 +00:00
westi
d744ca66f0
XMLRPC: Add the object ID to the return data of wp.uploadFile/metaWeblog.newMediaObject so that it can be used in other api calls e.g. setting featured image see #15098 props maxcutler
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-28 12:00:50 +00:00
westi
79ff94923e
XMLRPC: Add new wp.getPostType and wp.getPostTypes apis. See #18436 props maxcutler, markoheijnen and nprasath002.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-23 17:53:14 +00:00
westi
4d68261f5e
XMLRPC: Add support for Feature Images to the new wp.xxxPost apis. See #18429 props maxcutler and markoheijen.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-23 15:35:44 +00:00
ryan
7faddb72bc
Consolidate some strings. Props ramiy. see #20216
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-19 19:04:49 +00:00
westi
eb04dc7d8d
XMLRPC: Start casting datatypes in _prepare_term so as to ensure consistent datatypes in our responses. See #18438 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-08 13:31:32 +00:00
westi
bb4d8c73a5
XMLRPC: Add some xmlrpc_call_success_* actions to some of the post creation/deletion calls. Fixes #14283 props ericmann, simonwheatley.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-08 13:16:26 +00:00
westi
7834e57a80
XMLRPC: Add some xmlrpc_call_success_* actions to some of the credit/edit/delete calls. Fixes #17109 props ericmann.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-08 13:12:06 +00:00
westi
787d4acef5
XMLRPC: Expose the extended more text to XMLRPC clients from metaWeblog.getPost(). Fixes #10933 props koke, ericmann.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-08 12:50:21 +00:00
westi
d1e336dee2
XMLRPC: Expose the fact that the current theme supports featured images to XMLRPC clients so they can make intelligent UI decisions.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-08 12:19:45 +00:00
westi
ba2a634b7c
XMLRPC: Remove the "Backward Compatibility" code from the new api as we don't need to support this older format and it keeps the new api cleaner.
...
The new Posts API is designed so that you can fetch a post with get, update the data structure returned and submit that with edit and so we need to ensure to only include in get data in a single form - tags and categories are returned as terms.
See #18429
git-svn-id: http://svn.automattic.com/wordpress/trunk@20154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-08 11:24:43 +00:00
westi
2281ba2229
XMLRPC: Intoduce a date generation helper method to improve the dates returned over XMLRPC when we have a 0 date stored for drafts.
...
This improves the ability of clients to work with the new wp Post APIs. See #18429 and #19733 props maxcutler.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-08 11:19:53 +00:00
westi
3bc5eff6d3
XML-RPC: Initial implementation of Taxonomy and Term APIs.
...
Implements: wp.newTerm, wp.editTerm, wp.deleteTerm, wp.getTerm, wp.getTerms, wp.getTaxonomy and wp.getTaxonomies
See: #18438 , #18439 , #18440 , #18441 , #18442 , #18443 , and #18444 props maxcutler, markoheijnen and nprasath002.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-07 17:02:22 +00:00
nacin
ae8af5d0dd
Introduce get_page_template_slug( $id = null ) to return a page's template (like "showcase.php"). Returns false if post ID is not a page, and an empty string for the default page template. Use the function across core. props billerickson for initial patch. fixes #18750 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 18:56:54 +00:00
nacin
73938cd0a9
We indent with tabs, but align with spaces.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 18:06:30 +00:00
nacin
31223d73ed
Add template and stylesheet to readonly options that can be pulled from XML-RPC. props koke, ericmann. see #17132 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 17:59:47 +00:00
ryan
d910c26182
Pinking shears 6-20000
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-27 19:46:52 +00:00
nacin
aefde50081
Deprecate ancient "debugging" tools.
...
* logIO() and the global $xmlrpc_logging in XML-RPC.
* log_app() and the global $app_logging in APP.
* debug_fwrite(), debug_fopen(), debug_fclose(), and $debug.
see #20051 .
git-svn-id: http://svn.automattic.com/wordpress/trunk@19935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-17 00:02:42 +00:00
ryan
6158ce7244
Disallow changing the post type in mw_editPost(). see #18429
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-13 21:01:55 +00:00
ryan
a856f757db
Remove unnecessary cap check in wp_newPage(). mw_newPost() will handle it. Props nprasath002. fixes #19981
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-10 20:49:27 +00:00
josephscott
bd6038ce1a
Provide the attachment_id of a media item in the XML-RPC call wp.getMediaItem.
...
Props skithund
Fixes #18683
git-svn-id: http://svn.automattic.com/wordpress/trunk@19885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 23:32:25 +00:00
josephscott
d116969cef
Expose image_default_link_type, image_default_size, and image_default_align
...
options via XML-RPC
Props koke
Fixes #18126
git-svn-id: http://svn.automattic.com/wordpress/trunk@19884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 23:28:23 +00:00
josephscott
ce4e3dc47b
Expose the post modified date (in blog TZ and GMT) via XML-RPC
...
Props ocollet
Fixes #19027
git-svn-id: http://svn.automattic.com/wordpress/trunk@19883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 23:25:11 +00:00
nacin
a0ec80fff3
Combine two strings. props kenan3008, see #18429 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 18:50:25 +00:00
ryan
391fd7003d
s/_wp_insertPost/_insert_post/. Helper funcs should follow core rather than xmlrpc style. see #18429
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 17:00:19 +00:00
ryan
4c3c859461
Formatting cleanup. see #18429
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 16:04:58 +00:00
duck_
357fc30771
Mark wp_editPost() documentation as docblock. See #18429 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 16:03:31 +00:00
ryan
7a136d0bf9
Simplify cap checking. Props nprasath002. see #18429
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 15:40:26 +00:00
ryan
afcce70613
Space between if and open paren
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-08 14:54:15 +00:00
westi
4cb4acb372
XMLRPC: Introduce new create,read,update and delete XMLRPC apis for Posts, Pages and all Custom Post Types.
...
Introduces: wp.newPost, wp.editPost, wp.deletePost, wp.getPost, and wp.getPosts
See #18429 , #18430 , #18431 , #18432 , and #18433 props maxcutler and markoheijnen.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-07 11:33:39 +00:00
duck_
81a7ad2c81
split was deprecated in PHP 5.3.0, so use explode instead. Props garyc40. Fixes #16325 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-09 21:20:51 +00:00
ryan
e3b46b25d3
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
nacin
01736fb650
Expose default_ping_status and default_comment_status via XML-RPC. props daniloercoli. fixes #18566 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-07 19:08:48 +00:00
ryan
83b131f8e3
User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:50:54 +00:00
ryan
616c35e71c
One newline is enough.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:10:39 +00:00
ryan
07ff8b216b
Use one space, not two, after trailing punctuation. fixes #19537
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
ryan
d8892db612
Cast author IDs to strings. Props yoavf. fixes #18869
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-27 18:36:49 +00:00
josephscott
d6a835521f
Follow the pattern of wp-admin a bit more for metaWeblog.newPost by using get_default_post_to_edit() to generate a post ID before the post is actually published.
...
Fixes #18812
Props koke, nacin
git-svn-id: http://svn.automattic.com/wordpress/trunk@18933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-10 21:27:05 +00:00
duck_
e4ed63fc6f
Fix typos in documentation (wp-includes/[a-h]). See #18560 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-03 16:02:41 +00:00
nacin
3ee964c10c
Check for comment existence before checking edit_comment meta cap. props xknown, fixes #18104 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-23 10:22:34 +00:00
ryan
852627fc48
Use *_metadata_by_mid() API in set_custom_fields(). Handle slashing when checking caps for key. see #18195
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-03 18:20:15 +00:00
ryan
4ad0954961
Introduce register_meta(), get_metadata_by_mid(), and *_post_meta capabilities. fixes #17850
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-20 22:04:35 +00:00
ryan
daa14c36f9
Bring out the pinking shears.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-10 23:01:45 +00:00
ryan
d92ecb674e
Revert [17663]. fixes #17131
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-02 20:03:27 +00:00
ryan
a972403a40
Use static strings. Props niallkennedy. fixes #17169
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-06 19:51:47 +00:00
ryan
04487fc268
Constructor cleanup. Props ocean90. fixes #16768
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-29 20:05:12 +00:00
josephscott
acdb6ea093
Expose the content width as a read only option via XML-RPC.
...
Fixes #17131 props koke, nacin
git-svn-id: http://svn.automattic.com/wordpress/trunk@17663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-20 15:26:38 +00:00
josephscott
03b604d309
Allow Pages to have a status of pending.
...
Fixes #17000 props mrroundhill, nprasath002
git-svn-id: http://svn.automattic.com/wordpress/trunk@17651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-18 17:30:58 +00:00
josephscott
c8aeb477bc
Add support to wp.getPostFormats to provide a list of the currently supported post formats in addition to the complete list.
...
Fixes #17094
git-svn-id: http://svn.automattic.com/wordpress/trunk@17650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-18 17:27:29 +00:00
josephscott
ca45144dd5
Include the post status in the response for mt.getRecentPostTitles calls
...
Fixes #17091 props daniloercoli
git-svn-id: http://svn.automattic.com/wordpress/trunk@17649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-18 17:16:46 +00:00
josephscott
3f4f150632
Don't reset the post slug on XML-RPC calls.
...
Fixes #12947 props cfinke, nprasath002
git-svn-id: http://svn.automattic.com/wordpress/trunk@17648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-18 16:32:26 +00:00
westi
0f7cac9f64
More better phpdoc for XMLRPC functions. See #15238 props koke.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-18 07:26:42 +00:00
westi
50299d53c0
The beginings of better phpdoc for XMLRPC functions. See #15238 props koke.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-18 07:23:47 +00:00
nacin
ec382258b3
Change this string to one that already exists. props ericmann, fixes #16806 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-03-24 16:12:47 +00:00
scribu
6151eced55
Get only required fields in wp_getAuthors(). Props duck_. See #15854
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 23:43:24 +00:00
ryan
7e25e3b363
Add like_escape() to some queries. fixes #15764
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 14:22:41 +00:00
ryan
3949ce12d0
Pink trailing whites.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-13 21:21:50 +00:00
dd32
566f62b824
Include a blank email to prevent a PHP notice when pingbacks are being added, causes XML-RPC responses to be malformed with WP_DEBUG.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-11 07:17:50 +00:00
markjaquith
e0e9dbb8eb
Work around some unset variable notices in xmlrpc.php. props redsweater. props sorich87. fixes #10665
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-08 22:00:40 +00:00