Scott Taylor
4830eeb9ad
Properly invalidate the cache for `wp_count_posts()` on insert, trash, or when transitioning `post_status` inside of `_transition_post_status()`. Introduces `_count_posts_cache_key()`. Adds unit tests.
...
Props mark8barnes, for bringing this to our attention in an initial patch.
Fixes #21879 .
Built from https://develop.svn.wordpress.org/trunk@27081
git-svn-id: http://core.svn.wordpress.org/trunk@26954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-03 19:42:13 +00:00
Drew Jaynes
edce7b88b5
Improve inline documentation for `add_post_type_support()`.
...
Props philiparthurmoore.
Fixes #26683 .
Built from https://develop.svn.wordpress.org/trunk@26911
git-svn-id: http://core.svn.wordpress.org/trunk@26792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-07 02:05:11 +00:00
Sergey Biryukov
0ddaa76f3e
Use correct example of a Dashicons helper class in add_menu_page() and register_post_type() docs.
...
props Rarst.
fixes #26617 for trunk.
Built from https://develop.svn.wordpress.org/trunk@26884
git-svn-id: http://core.svn.wordpress.org/trunk@26767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-31 10:33:11 +00:00
Andrew Nacin
9b29ad0529
Allow for Dashicons and base64-encoded data:image/svg+xml URIs when specifying menu icons.
...
Both of these icons can be colored to match the color scheme, including hover states.
Both are accepted for register_post_type()'s menu_icon argument, and also add_menu_page()'s $icon_url argument.
To use a Dashicon, pass the name of the helper class, e.g. 'dashicons-piechart'.
To use an SVG, pass a valid data URI string starting with 'data:image/svg+xml;base64,'.
props helen.
fixes #25147 .
Built from https://develop.svn.wordpress.org/trunk@26664
git-svn-id: http://core.svn.wordpress.org/trunk@26554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 06:38:09 +00:00
Andrew Nacin
6fa4ce2284
Return false from wp_delete_post() and wp_delete_attachment() if the DELETE is unsuccessful.
...
This prevents attachments from being deleted off disk when a DB is locked and the delete is otherwise unsuccessful.
fixes #25107 .
Built from https://develop.svn.wordpress.org/trunk@26543
git-svn-id: http://core.svn.wordpress.org/trunk@26435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 22:59:10 +00:00
Scott Taylor
295851d0bb
In `get_posts()`, alter the doc block and default args to make `orderby` equal to `date`, not `post_date`.
...
Props ounziw.
Fixes #26128 .
Built from https://develop.svn.wordpress.org/trunk@26329
git-svn-id: http://core.svn.wordpress.org/trunk@26231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-22 17:39:10 +00:00
Andrew Nacin
d0cfa40983
Add jshintrc to qunit.
...
props jorbin.
see #25187 .
Built from https://develop.svn.wordpress.org/trunk@25992
git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-30 14:39:10 +00:00
Andrew Nacin
5361a8abca
Spell out duplicate hook locations.
...
props DrewAPicture.
fixes #25658 .
Built from https://develop.svn.wordpress.org/trunk@25868
git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:20 +00:00
Andrew Nacin
8ae8e01b67
Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
...
see #27704 .
Built from https://develop.svn.wordpress.org/trunk@25825
git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin
74488bdcb0
Spell out duplicate hook locations.
...
props DrewAPicture.
fixes #25658 .
Built from https://develop.svn.wordpress.org/trunk@25868
git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
Andrew Nacin
5b6bcb218d
Reset "Page on Front" when such a page is trashed.
...
props danielbachhuber.
fixes #24171 .
Built from https://develop.svn.wordpress.org/trunk@25686
git-svn-id: http://core.svn.wordpress.org/trunk@25602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 03:51:09 +00:00
Dominik Schilling
e4c8d56b76
Replace use of global `$user_ID` in favor of `get_current_user_id()`. fixes #25372 .
...
Built from https://develop.svn.wordpress.org/trunk@25669
git-svn-id: http://core.svn.wordpress.org/trunk@25585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 21:10:09 +00:00
Scott Taylor
3f42db549c
`post_content` does not have a default value in the `$wpdb->posts` table. Add a default value of empty string to `wp_insert_attachment()` to avoid a tornado of database errors in PHP 5.5/MySQL 5.6, even when debug mode is turned off.
...
See #25282 .
Built from https://develop.svn.wordpress.org/trunk@25661
git-svn-id: http://core.svn.wordpress.org/trunk@25577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 19:52:09 +00:00
Drew Jaynes
82904baffd
Improve inline documentation for `wp_insert_post()` by adding a hash notation.
...
See #25412 .
Built from https://develop.svn.wordpress.org/trunk@25628
git-svn-id: http://core.svn.wordpress.org/trunk@25545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 17:34:08 +00:00
Drew Jaynes
38b7b3a1c5
Clarify inline documentation for the return in `get_attached_file()`.
...
Fixes #25409 .
Built from https://develop.svn.wordpress.org/trunk@25609
git-svn-id: http://core.svn.wordpress.org/trunk@25526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 21:29:08 +00:00
Andrew Nacin
71263c4854
Use correct variable. props helen. see #17071 .
...
Built from https://develop.svn.wordpress.org/trunk@25581
git-svn-id: http://core.svn.wordpress.org/trunk@25498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 20:18:10 +00:00
Andrew Nacin
8fa6e99edc
Introduce a wp_count_attachments filter.
...
props kevinB.
fixes #17071 .
Built from https://develop.svn.wordpress.org/trunk@25579
git-svn-id: http://core.svn.wordpress.org/trunk@25496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 19:11:09 +00:00
Andrew Nacin
a4040ea928
In wp_count_posts(), rename 'count_posts' hook to 'wp_count_posts', for clarity. see #16603 .
...
Built from https://develop.svn.wordpress.org/trunk@25578
git-svn-id: http://core.svn.wordpress.org/trunk@25495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 19:08:09 +00:00
Andrew Nacin
5febb6045f
Introduce a meta_box_cb argument for register_taxonomy().
...
The specified callback function is used as the meta box callback for the taxonomy.
props garyc40, helen.
fixes #14206 .
Built from https://develop.svn.wordpress.org/trunk@25572
git-svn-id: http://core.svn.wordpress.org/trunk@25489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 17:12:10 +00:00
Scott Taylor
8697ae572e
Add hooks to `wp_count_posts()`. Adds filter docs. Adds unit test to test `count_posts` filter.
...
Props nacin, DrewAPicture.
Fixes #16603 .
Built from https://develop.svn.wordpress.org/trunk@25554
git-svn-id: http://core.svn.wordpress.org/trunk@25474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 17:55:08 +00:00
Scott Taylor
ae4cf7665a
Add `@access private` to `_get_custom_object_labels()`, which was already implied by the dangling underscore. Cast `$labels` to `array` in `get_taxonomy_labels()` and `_get_custom_object_labels()`.
...
Props nacin, foofy.
Fixes #16310 .
Built from https://develop.svn.wordpress.org/trunk@25553
git-svn-id: http://core.svn.wordpress.org/trunk@25473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 17:44:09 +00:00
Scott Taylor
8bd9659d0d
Move checks for `post_type` being an array inline. See [25291], [25292], #18614 .
...
Built from https://develop.svn.wordpress.org/trunk@25312
git-svn-id: http://core.svn.wordpress.org/trunk@25274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 03:02:10 +00:00
Scott Taylor
d7704991b3
Check the value passed to `get_post_type_object()`. If it's an array, use the first item. `get_query_var( 'post_type' )` can be an array if the query has been altered via filters/actions. There are several places in core that pass the query var. Adds unit tests.
...
In `template-loader.php`, move `is_post_type_archive()` and `is_tax()` directly below `is_home()`.
See #18614 , [25291].
Built from https://develop.svn.wordpress.org/trunk@25292
git-svn-id: http://core.svn.wordpress.org/trunk@25256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 23:39:09 +00:00
Andrew Nacin
4b40e7a646
More adjustments and improvements for inline documentation for get_pages(). see #25186 .
...
Built from https://develop.svn.wordpress.org/trunk@25271
git-svn-id: http://core.svn.wordpress.org/trunk@25237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 01:21:09 +00:00
Scott Taylor
54c5a75e68
Simplify the check for false-y `child_of` arg.
...
Props SergeyBiryukov.
See #25230 , [25245].
Built from https://develop.svn.wordpress.org/trunk@25270
git-svn-id: http://core.svn.wordpress.org/trunk@25236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 23:36:10 +00:00
Scott Taylor
cc41e7d04a
Fix spacing in docs for `get_pages()`.
...
Props DrewAPicture.
See #25186 .
Built from https://develop.svn.wordpress.org/trunk@25268
git-svn-id: http://core.svn.wordpress.org/trunk@25234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 23:21:10 +00:00
Scott Taylor
1855f97a2c
Add docs to the woefully under-documented `get_pages()`.
...
Props DrewAPicture.
Fixes #25186 .
Built from https://develop.svn.wordpress.org/trunk@25266
git-svn-id: http://core.svn.wordpress.org/trunk@25232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 22:13:09 +00:00
Scott Taylor
d1a40562eb
Add check to make sure a valid argument was passed to `get_page_uri()`.
...
Props Viper007Bond.
Fixes #24491 .
Built from https://develop.svn.wordpress.org/trunk@25262
git-svn-id: http://core.svn.wordpress.org/trunk@25230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 21:42:10 +00:00
Scott Taylor
6253183ffc
Set `hierarchical` to `false` when `parent` is passed to `get_pages()` and `child_of` is not.
...
Fixes #25230 .
Built from https://develop.svn.wordpress.org/trunk@25245
git-svn-id: http://core.svn.wordpress.org/trunk@25213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-04 21:00:09 +00:00
Scott Taylor
bf6da40cfc
Allow `get_pages()` to accept an `array` for the arg `parent`. Adds unit tests, some will fail until the next commit.
...
Fixes #9470 .
Built from https://develop.svn.wordpress.org/trunk@25244
git-svn-id: http://core.svn.wordpress.org/trunk@25212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-04 20:56:09 +00:00
Scott Taylor
f1a33028f6
Allow `int` to be passed in lieu of `array`, add `append` arg to `wp_set_post_categories()`. Adds more extensive unit tests for `wp_set_post_categories()`.
...
Props ptahdunbar for initial patch.
Fixes #16550 .
Built from https://develop.svn.wordpress.org/trunk@25234
git-svn-id: http://core.svn.wordpress.org/trunk@25204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-04 17:42:10 +00:00
Jon Cave
93b2edbbba
Correct rewrite tag for hierarchical post types without a query_var.
...
Hierarchical rewrite rules operate via the 'pagename' query variable which is
passed to get_page_by_path(). However, the current rewrite rules use the 'name'
query variable for hierarchical types without a custom query_var.
Fixes #16323 .
Built from https://develop.svn.wordpress.org/trunk@25182
git-svn-id: http://core.svn.wordpress.org/trunk@25154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-30 08:08:09 +00:00
Scott Taylor
7c1ea6c95c
No need to re-map the return values of `wp_parse_id_list()` to int.
...
See #22074 , #11823 .
Built from https://develop.svn.wordpress.org/trunk@25169
git-svn-id: http://core.svn.wordpress.org/trunk@25145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-29 18:54:09 +00:00
Scott Taylor
0624fe960b
Improve the include / exclude SQL generation in `get_pages()` by using `IN` and `NOT IN` where applicable. Adds unit tests for include / exclude.
...
Fixes #22074 .
Built from https://develop.svn.wordpress.org/trunk@25168
git-svn-id: http://core.svn.wordpress.org/trunk@25144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-29 18:49:09 +00:00
Scott Taylor
8e6abf65a8
Respect the `fields` arg when passed to `get_children()`.
...
Fixes #22208 .
Built from https://develop.svn.wordpress.org/trunk@25160
git-svn-id: http://core.svn.wordpress.org/trunk@25139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-29 15:08:12 +00:00
Dominik Schilling
357f52eed7
Improve inline docs for register_post_type() and register_taxonomy().
...
* register_taxonomy: Use the same doc format for the associative array arg as used for register_post_type()
* register_taxonomy: Improve docs for _builtin, capabilities, hierarchical and rewrite args
* register_taxonomy: Use the same order in $defaults as in docblock
* register_taxonomy: Replace is_null with null ===, to be consistent
* register_post_type: Use the same order in $defaults as in docblock
* register_post_type: Improve docs for @uses and default fallbacks
And while we're on it: Whitespaces.
fixes #25150 .
Built from https://develop.svn.wordpress.org/trunk@25130
git-svn-id: http://core.svn.wordpress.org/trunk@25110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-26 20:24:08 +00:00
Sergey Biryukov
b86ea82b12
Fix typo in phpdoc. props jamescollins. fixes #25092 .
...
Built from https://develop.svn.wordpress.org/trunk@25097
git-svn-id: http://core.svn.wordpress.org/trunk@25079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-22 23:48:09 +00:00
Andrew Nacin
fa4c7a1feb
PHPDoc for WP_Post properties. fixes #25092 .
...
Built from https://develop.svn.wordpress.org/trunk@25086
git-svn-id: http://core.svn.wordpress.org/trunk@25070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-22 15:58:09 +00:00
Scott Taylor
a9dc60c9a8
Improve inline docs for function params that can be serialized when non-scalar. Fixes #18488 .
...
Built from https://develop.svn.wordpress.org/trunk@25076
git-svn-id: http://core.svn.wordpress.org/trunk@25061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-21 21:11:09 +00:00
Dominik Schilling
8ad024f30a
Introduce save_post_{$post_type} hook.
...
The hook is fired before the general save_post hook and has the same args as save_post.
props bmb, SergeyBiryukov, ocean90, fixes #16176 .
Built from https://develop.svn.wordpress.org/trunk@25050
git-svn-id: http://core.svn.wordpress.org/trunk@25037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-17 20:21:09 +00:00
Andrew Nacin
08c4061af7
In get_attached_file(), fix the explanation of when the filter is bypassed. props devesine, fixes #24571 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-05 22:07:42 +00:00
Andrew Nacin
487327cf4e
Pass $update = true to the save_post and wp_insert_post hooks in wp_publish_post().
...
see #21450 , [24823].
props wpsmith.
fixes #24957 .
git-svn-id: http://core.svn.wordpress.org/trunk@24977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-05 21:41:51 +00:00
Andrew Nacin
c95a24f2d9
When registering a post type, pass the correct argument for feeds to add_permastruct().
...
props butuzov, johnpbloch.
fixes #23302 .
git-svn-id: http://core.svn.wordpress.org/trunk@24830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 22:28:18 +00:00
Andrew Nacin
87f9d112c0
Return an empty stdClass from wp_count_posts() when a nonexistent post type is requested.
...
props johnpbloch.
fixes #24803 .
git-svn-id: http://core.svn.wordpress.org/trunk@24826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 21:38:00 +00:00
Andrew Nacin
aa6d93cd3e
Pass $update to the save_post and wp_insert_post hooks in wp_insert_post(). props ericmann, fixes #21450 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 21:05:25 +00:00
Michael Adams
f993cfd8e3
Fix inline docs for posts functions that no longer use `$wpdb`.
...
Props jdgrimes, JustinSainton.
git-svn-id: http://core.svn.wordpress.org/trunk@24807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 18:52:56 +00:00
Andrew Nacin
df0ac70aff
Add a default post_title value to wp_insert_attachment() to avoid a notice when there is no ID3 title.
...
props wonderboymusic.
see #24805 .
git-svn-id: http://core.svn.wordpress.org/trunk@24759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-20 20:20:47 +00:00
Andrew Nacin
ab72605607
More clear and concise escaping in get_page_by_path(). see #21767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-16 14:23:29 +00:00
Andrew Nacin
092a33115c
Remove wp_parse_post_content(), get_paged_content(), paginate_content() from 3.6, and remove the new $id parameters for get_the_content() and the_content().
...
The content parsing functions are good abstractions, but are no longer needed by core and are too closely tied to legacy globals, rather than paving a new path.
For get_the_content() and the_content(), this only worsens the function prototype. It muddies theme-specific display (more links, etc) with filtered content. `apply_filters( 'the_content', $post->post_content )` is sufficient practice for now.
see #24330 , [24301]. see #23625 , [23804].
git-svn-id: http://core.svn.wordpress.org/trunk@24598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 05:22:50 +00:00
Sergey Biryukov
58c364947f
PHPDoc fixes and additions. fixes #24616 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-21 12:45:11 +00:00