WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
39,490 Commits 50 Branches 749 Tags 982 MiB
Commit Graph

26699 Commits

Author SHA1 Message Date
Gary Pendergast 02d97f51c1 WordPress 5.2 Beta 2 
Built from https://develop.svn.wordpress.org/trunk@45151


git-svn-id: http://core.svn.wordpress.org/trunk@44960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-09 01:12:51 +00:00
Gary Pendergast ed8723fd8f UI: Remove vertical alignment from active primary buttons. 
This caused the post-plugin installation actions to jump around when the "Activate Plugin" primary button became active.

Props seedsca, pratikthink, ianbelanger, mukesh27.
Fixes #44836.


Built from https://develop.svn.wordpress.org/trunk@45150


git-svn-id: http://core.svn.wordpress.org/trunk@44959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-09 00:16:53 +00:00
Gary Pendergast d6c90ca7d7 Privacy: Add a missing `<form>` action on the Export/Erasure screens. 
This lack of action could cause an expired nonce to end up in the URL.

Props garrett-eclipse, saimonh, xkon.
Fixes #44047.


Built from https://develop.svn.wordpress.org/trunk@45149


git-svn-id: http://core.svn.wordpress.org/trunk@44958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-09 00:08:54 +00:00
Gary Pendergast cbc0240cd6 Privacy: Only mark a personal data export as complete when the user downloads it. 
An admin may download an export to check that it's all correct, but this action shouldn't mark the request as complete.

Props garrett-eclipse, JoshuaWold, birgire.
Fixes #44644.


Built from https://develop.svn.wordpress.org/trunk@45148


git-svn-id: http://core.svn.wordpress.org/trunk@44957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-09 00:04:50 +00:00
Gary Pendergast 4b1ff1c298 Media: Update the media bulk action labels for consistency. 
Props ianbelanger, garrett-eclipse, afercia, Presskopp.
Fixes #44675.


Built from https://develop.svn.wordpress.org/trunk@45147


git-svn-id: http://core.svn.wordpress.org/trunk@44956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:54:52 +00:00
Gary Pendergast 9292802d92 Twenty Seventeeen: Fix MediaElement control hover colours in the customiser. 
When selecting custom colour schemes in the customiser, the hover colour is incorrectly applied to MediaElement controls.

Props xkon, ianbelanger.
Fixes #40843.


Built from https://develop.svn.wordpress.org/trunk@45146


git-svn-id: http://core.svn.wordpress.org/trunk@44955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:38:51 +00:00
Gary Pendergast 5b8db48734 Site Health: Remove animated ellipsis from the status loading indicator. 
This animation wasn't particularly reliable across browsers.

Props Clorith, afercia.
Fixes #46684.


Built from https://develop.svn.wordpress.org/trunk@45145


git-svn-id: http://core.svn.wordpress.org/trunk@44954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:29:51 +00:00
Gary Pendergast 8c8c1f8984 Widgets: Add `rel="noopener noreferrer"` to links with `target="_blank"` in the Image widget. 
Props audrasjb, welcher, afercia.
Fixes #43280.


Built from https://develop.svn.wordpress.org/trunk@45144


git-svn-id: http://core.svn.wordpress.org/trunk@44953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:23:51 +00:00
Gary Pendergast 822e8b1a95 Widgets: Add `rel="noopener noreferrer"` to links with `target="_blank"` in the Text and HTML widgets. 
Props audrasjb, birgire, mukesh27.
Fixes #46421.


Built from https://develop.svn.wordpress.org/trunk@45143


git-svn-id: http://core.svn.wordpress.org/trunk@44952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:18:52 +00:00
Gary Pendergast f584cc2f67 Privacy: Remove the privacy changes bubble. 
This notification was a little too intrustive, and suffered from being difficult to dismiss.

Props garrett-eclipse, xkon, ianbelanger.
Fixes #46819.


Built from https://develop.svn.wordpress.org/trunk@45142


git-svn-id: http://core.svn.wordpress.org/trunk@44951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:12:51 +00:00
Gary Pendergast a932e9921b Menus: Add `rel="noopener"` to `target="_blank"` links by default in menus. 
This expands upon `rel="noopener"` being previously added to links in the content.

Props audrasjb, welcher.
Fixes #43290.


Built from https://develop.svn.wordpress.org/trunk@45141


git-svn-id: http://core.svn.wordpress.org/trunk@44950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:06:52 +00:00
Gary Pendergast 4487551344 Help: Update support forum links. 
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/.

Props jitendrabanjara1991, dilipbheda, mukesh27, ianbelanger.
Fixes #46790.


Built from https://develop.svn.wordpress.org/trunk@45140


git-svn-id: http://core.svn.wordpress.org/trunk@44949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 22:59:56 +00:00
Gary Pendergast affceae936 Blocks: Allow for nested `the_content` calls within `do_blocks()`. 
When `do_blocks()` is run, it sets up some special handling of the `wpautop` filter, as we don't want `wpautop` to run on block content, but we do want it to be available for subsequent runs of `the_content`, which may be happening on non-block content.

As we set this up before rendering dynamic blocks, however, a dynamic block choosing to run `the_content` will cause unintentially structural deficiences in this particular recursive block tower.

Moving this handling to after dynamic blocks are rendered makes our tower lean a little less.

Props aldavigdis, pento.
Fixes #45495.


Built from https://develop.svn.wordpress.org/trunk@45139


git-svn-id: http://core.svn.wordpress.org/trunk@44948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 06:54:54 +00:00
Gary Pendergast 95df8fa792 Block Editor: Update packages to bring a selection of bugfixes in. 
Props iseulde, kjellr, aduth, 0mirka00, mcsf, nosolosw, gziolo, jasmussen, talldanwp, notnownikki, swissspidy, jorgefilipecosta, noisysocks.
See https://github.com/WordPress/gutenberg/pull/14796.
Fixes #46801.


Built from https://develop.svn.wordpress.org/trunk@45138


git-svn-id: http://core.svn.wordpress.org/trunk@44947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 06:37:57 +00:00
Gary Pendergast 9a80e2095b Text Changes: Tweak the wording of email notification subjects. 
This change brings more coherence between the subject lines of the various emails WordPress will send.

Props ramiy, pento.
Fixes #37940.

Built from https://develop.svn.wordpress.org/trunk@45137


git-svn-id: http://core.svn.wordpress.org/trunk@44946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 06:17:51 +00:00
Gary Pendergast f6128eb7e6 Post Formats: Remove the post format icons from the post list table. 
Props mukesh27, melchoyce, karmatosed, afercia, mapk.
Fixes #46591.

Built from https://develop.svn.wordpress.org/trunk@45136


git-svn-id: http://core.svn.wordpress.org/trunk@44945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 06:04:50 +00:00
Gary Pendergast cbdffc4a1e HTTP: Add support for the `host-only` flag to `Wp_Http_Cookie`. 
Props soulseekah.
Fixes #43231.

Built from https://develop.svn.wordpress.org/trunk@45135


git-svn-id: http://core.svn.wordpress.org/trunk@44944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 05:32:51 +00:00
Gary Pendergast a125989772 Emoji: Update Twemoji to version 12.0.0. 
Props pento, superpoincare.
Fixes #46404, #46805.

Built from https://develop.svn.wordpress.org/trunk@45134


git-svn-id: http://core.svn.wordpress.org/trunk@44943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 05:22:51 +00:00
Gary Pendergast 625d1694a3 Canonical: Ensure redirect query keys are URL encoded. 
This prevents an infinite redirect loop when a request containing URL-encoded characters triggers `is_404()`.

Props soulseekah, wrwrwr0.
Fixes #43745.

Built from https://develop.svn.wordpress.org/trunk@45133


git-svn-id: http://core.svn.wordpress.org/trunk@44942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 01:10:55 +00:00
Sergey Biryukov 965941ab3a Twenty Nineteen: Fix inconsistent tab/space indentation in style files. 
Props iamdmitrymayorov, mukesh27.
Fixes #46821.
Built from https://develop.svn.wordpress.org/trunk@45132


git-svn-id: http://core.svn.wordpress.org/trunk@44941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 06:18:51 +00:00
Sergey Biryukov 78340f315d CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/color-picker.css`. 
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46492. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45131


git-svn-id: http://core.svn.wordpress.org/trunk@44940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 05:54:50 +00:00
Sergey Biryukov c33b18b721 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/about.css`. 
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45130


git-svn-id: http://core.svn.wordpress.org/trunk@44939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 05:51:51 +00:00
Sergey Biryukov 7eafd6d81a CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/customize-nav-menus.css`. 
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45129


git-svn-id: http://core.svn.wordpress.org/trunk@44938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 05:49:51 +00:00
Sergey Biryukov 7eecc96e2d CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/site-health.css`. 
Props mukesh27, ianbelanger, pbiron, afercia.
Fixes #46760. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45128


git-svn-id: http://core.svn.wordpress.org/trunk@44937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 05:44:50 +00:00
Sergey Biryukov 7639acc7b7 Docs: Fix typo in a comment in `editor/dfw.js`. 
Props garrett-eclipse, mattnyeus.
Fixes #46485.
Built from https://develop.svn.wordpress.org/trunk@45127


git-svn-id: http://core.svn.wordpress.org/trunk@44936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 05:39:50 +00:00
Sergey Biryukov 94b3dcc605 Bundled Themes: Link to an updated documentation on post thumbnails on developer.wordpress.org, instead of Codex. 
Props samanehmirrajabi.
Fixes #46823.
Built from https://develop.svn.wordpress.org/trunk@45126


git-svn-id: http://core.svn.wordpress.org/trunk@44935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 05:23:51 +00:00
John Blackbourn 9ab303dbdf Bootstrap/Load: Ignore `wp-content/fatal-error-handler.php` and `wp-content/php-error.php` from version control. 
See #44458

Built from https://develop.svn.wordpress.org/trunk@45125


git-svn-id: http://core.svn.wordpress.org/trunk@44934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 18:43:51 +00:00
Sergey Biryukov 3215ab96ce Twenty Twelve: Correct `linear-gradient` direction argument syntax. 
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.

Props: ianbelanger, joyously, man4toman.
Fixes #46786.
Built from https://develop.svn.wordpress.org/trunk@45124


git-svn-id: http://core.svn.wordpress.org/trunk@44933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 16:17:50 +00:00
Sergey Biryukov 95d13df56d CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/nav-menus.css`. 
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46516. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45123


git-svn-id: http://core.svn.wordpress.org/trunk@44932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 16:10:51 +00:00
Sergey Biryukov 5810543816 PHPCS: Fix WPCS violation in [45119]. 
See #46809.
Built from https://develop.svn.wordpress.org/trunk@45122


git-svn-id: http://core.svn.wordpress.org/trunk@44931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 16:02:52 +00:00
Sergey Biryukov 80e638ad0e Site Health: Update recommendation labels to highlight Performance instead of Security when using a supported and actively maintained version of WordPress, PHP, or MySQL. 
Props Clorith, earnjam.
Fixes #46789.
Built from https://develop.svn.wordpress.org/trunk@45121


git-svn-id: http://core.svn.wordpress.org/trunk@44930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 16:00:51 +00:00
Sergey Biryukov d36c01909a Site Health: Use a consistent heading and description when referring to Info and Status pages. 
Props chetan200891, afercia.
Fixes #46728.
Built from https://develop.svn.wordpress.org/trunk@45120


git-svn-id: http://core.svn.wordpress.org/trunk@44929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 15:42:52 +00:00
Sergey Biryukov 4d3fb9b22b Site Health: Restore backticks in "Copy to clipboard" functionality, accidentally removed in [45044]. 
The backticks ensure that the data is formatted accordingly on pasting whenever possible.

Props Clorith.
Fixes #46809.
Built from https://develop.svn.wordpress.org/trunk@45119


git-svn-id: http://core.svn.wordpress.org/trunk@44928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 15:36:51 +00:00
Sergey Biryukov a431028795 Site Health: Display a correct error message for a failing request in `wp_version_check()` test. 
Props Clorith, axaak.
Fixes #46814.
Built from https://develop.svn.wordpress.org/trunk@45118


git-svn-id: http://core.svn.wordpress.org/trunk@44927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 15:28:50 +00:00
Felix Arntz 5754da106b Administration: Improve user experience and clarify when in recovery mode. 
This changeset introduces several changes around usability when recovery mode is active:

* Display a notice in the admin clarifying that the user is in recovery mode.
* Use a highlight color for the admin bar link to exit recovery mode.
* Exit recovery mode automatically when logging out.
* Include a recovery mode indicator in the title tag.

Props aandrewdixon, azaozz, dhanukanuwan, flixos90, henrywright, karmatosed, mapk, melchoyce, spacedmonkey, TimothyBlynJacobs, tinkerbelly.
See #46608.

Built from https://develop.svn.wordpress.org/trunk@45117


git-svn-id: http://core.svn.wordpress.org/trunk@44926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-05 17:00:52 +00:00
Felix Arntz 52354f3f0b Bootstrap/Load: Do not redefine constants because tests don't like it. 
See #46045.

Built from https://develop.svn.wordpress.org/trunk@45116


git-svn-id: http://core.svn.wordpress.org/trunk@44925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-05 15:53:50 +00:00
Felix Arntz 5d2c761568 Bootstrap/Load: Remove extension from the list of paused extensions when it is deactivated. 
With this change, fatal errors recorded before a plugin was deactivated or a theme was switched away from do not persist. This ensures that re-enabling it re-checks for fatal errors correctly.

Props aandrewdixon, dhanukanuwan, henrywright.
Fixes #46812.

Built from https://develop.svn.wordpress.org/trunk@45115


git-svn-id: http://core.svn.wordpress.org/trunk@44924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-05 15:33:52 +00:00
Felix Arntz 6d58109b09 Bootstrap/Load: Ensure `WP_Fatal_Error_Handler` does not conflict with existing mechanisms treating fatal errors. 
Prior to this change, resuming or activating a plugin or theme that is still broken would result in a redirect loop if in recovery mode. If outside recovery mode, it would cause the error template to be displayed.

Furthermore this applies to breaking a plugin or theme when editing from the backend.

Props aandrewdixon, azaozz, dhanukanuwan, henrywright, ocean90, ohiosierra, PandelisZ, xkon.
Fixes #46045, #46751.

Built from https://develop.svn.wordpress.org/trunk@45114


git-svn-id: http://core.svn.wordpress.org/trunk@44923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-05 15:20:55 +00:00
Pascal Birchler ec05cd3168 Site Health: Remove unused `$wp_config_path` variable. 
Discovered and fixed during WordCamp London 2019 contributor day.

Props m_uysl.
Fixes #46808.

Built from https://develop.svn.wordpress.org/trunk@45113


git-svn-id: http://core.svn.wordpress.org/trunk@44922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-05 11:09:51 +00:00
tellyworth 23fe2800cc Upgrade/Install: Add more context in signature verify failures. 
This includes version numbers and signature counts in error reports, to help diagnose isolated failures that have no apparent cause.

Props dd32.
See #39309.

Built from https://develop.svn.wordpress.org/trunk@45112


git-svn-id: http://core.svn.wordpress.org/trunk@44921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-05 05:20:51 +00:00
Andrew Ozz 4601e178e5 Site health: fix usage of max_execution_time. When PHP is run from the cli the default is 0. 
Fixes #46645.
Built from https://develop.svn.wordpress.org/trunk@45111


git-svn-id: http://core.svn.wordpress.org/trunk@44920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-04 21:54:53 +00:00
desrosj adbaba7d56 Site Health: Ensure the user locale is listed in debug information. 
This change switches to using `get_user_locale()` when adding the language to the Site Health debug information to ensure the user’s locale preference is reflected.

Also, `function_exists()` checks for `switch_to_locale()` and `restore_previous_locale()` were required in the plugin to support older versions of WordPress, but they are not required in core/

Props: Clorith, desrosj.
Fixes #46694.
Built from https://develop.svn.wordpress.org/trunk@45110


git-svn-id: http://core.svn.wordpress.org/trunk@44919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-04 21:24:52 +00:00
desrosj fc2c675582 Twenty Eleven: Correct `linear-gradient` direction argument syntax. 
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.

Props: ianbelanger, Malae, man4toman.
Fixes #46770.
Built from https://develop.svn.wordpress.org/trunk@45109


git-svn-id: http://core.svn.wordpress.org/trunk@44918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-04 18:26:52 +00:00
Sergey Biryukov 4ee7d453fa Site Health: Use `wp_get_upload_dir()` instead of `wp_upload_dir()`, remove duplicate call. 
Props m_uysl.
Fixes #46729.
Built from https://develop.svn.wordpress.org/trunk@45108


git-svn-id: http://core.svn.wordpress.org/trunk@44917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-03 11:20:51 +00:00
Sergey Biryukov 991eb4258d Site Health: Use correct property for database-related messages. 
Props mukesh27, birgire.
Fixes #46783.
Built from https://develop.svn.wordpress.org/trunk@45107


git-svn-id: http://core.svn.wordpress.org/trunk@44916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-03 11:01:53 +00:00
Sergey Biryukov ef948cbfd6 PHPCS: Fix WPCS violations in [45104]. 
See #46645.
Built from https://develop.svn.wordpress.org/trunk@45106


git-svn-id: http://core.svn.wordpress.org/trunk@44915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-03 02:14:51 +00:00
Sergey Biryukov 5d0bd0ec47 Site Health: Use a consistent verbiage for the suggestion to remove inactive plugins and themes. 
Props garrett-eclipse, marybaum, Clorith.
Fixes #46735.
Built from https://develop.svn.wordpress.org/trunk@45105


git-svn-id: http://core.svn.wordpress.org/trunk@44914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-03 02:01:51 +00:00
Andrew Ozz 2cdc22aded Site health: 
- Prevent fatal errors from timeouts on the Tools => Site Health => Info tab.
- Use the `get_dirsize()` and `recurse_dirsize()` functions to calculate directory sizes. The results are cached.
- Introduce "timeout protection" in `recurse_dirsize()`.

Props pento, Clorith, xkon, afercia, jeremyfelt, azaozz.
Fixes #46645.
Built from https://develop.svn.wordpress.org/trunk@45104


git-svn-id: http://core.svn.wordpress.org/trunk@44913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 23:33:53 +00:00
Sergey Biryukov 1909df67a7 Docs: Remove an empty line between `@param` and `@return` in the tests added in [45101], per documentation coding standards. 
See #45029.
Built from https://develop.svn.wordpress.org/trunk@45103


git-svn-id: http://core.svn.wordpress.org/trunk@44912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 22:22:50 +00:00
Sergey Biryukov 0c92764023 Site Health: Use an established pattern for numbered placeholders in translator comments in `WP_Debug_Data`. 
See #46683.
Built from https://develop.svn.wordpress.org/trunk@45102


git-svn-id: http://core.svn.wordpress.org/trunk@44911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 22:18:52 +00:00
Sergey Biryukov cbbe38c09c Widgets: Make sure changes to media widgets' instance schema via `widget_{$this->id_base}_instance_schema` filter are not overridden by subclasses. 
Add unit tests missed in [45100].

Props Toro_Unit, birgire.
See #45029.
Built from https://develop.svn.wordpress.org/trunk@45101


git-svn-id: http://core.svn.wordpress.org/trunk@44910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 22:15:51 +00:00
Sergey Biryukov 2931a2d95e Widgets: Make sure changes to media widgets' instance schema via `widget_{$this->id_base}_instance_schema` filter are not overridden by subclasses. 
Previously, `WP_Widget_Media_Audio`, `WP_Widget_Media_Image`, and `WP_Widget_Media_Video` used to override the changes due to reversed arguments in `array_merge()` call.

Props Toro_Unit, birgire.
Fixes #45029.
Built from https://develop.svn.wordpress.org/trunk@45100


git-svn-id: http://core.svn.wordpress.org/trunk@44909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 22:13:52 +00:00
Sergey Biryukov f7357d3957 Site Health: i18n audit, take 1. 
* Split plural strings with multiple sentences to avoid duplicating translations.
* Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
* Use an established pattern for numbered placeholders in translator comments.
* Replace constants in translatable strings with placeholders, mark them as code.
* Make sure sentences are translated as a whole, not as separate string parts.
* Remove unnecessary context and escaping.

Props ocean90, SergeyBiryukov.
See #46683.
Built from https://develop.svn.wordpress.org/trunk@45099


git-svn-id: http://core.svn.wordpress.org/trunk@44908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 21:32:53 +00:00
Sergey Biryukov 5291f46c8a Docs: Fix typo in a comment in `unzip_file()`. 
Props mukesh27.
Fixes #46766.
Built from https://develop.svn.wordpress.org/trunk@45098


git-svn-id: http://core.svn.wordpress.org/trunk@44907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 13:34:53 +00:00
desrosj 6d1f493d1d Administration: Remove unnecessary `transition-delay` values from Dashicons. 
A unitless `0` value for a `<time>` CSS data type was reintroduced in [45040]. This is allowed for `<length>` data types, but is invalid for `<time>`.

See #43195.
Fixes #46774.
Built from https://develop.svn.wordpress.org/trunk@45097


git-svn-id: http://core.svn.wordpress.org/trunk@44906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 13:19:52 +00:00
Sergey Biryukov 45cd565be3 Twenty Fifteen: Fix typo in a comment for print styles. 
Props mukesh27.
Fixes #46767.
Built from https://develop.svn.wordpress.org/trunk@45096


git-svn-id: http://core.svn.wordpress.org/trunk@44905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 13:07:51 +00:00
Sergey Biryukov 474f57e0fa Site Health: Add missing i18n for Security and Performance badge labels. 
Props iworks.
Fixes #46755. See #46683.
Built from https://develop.svn.wordpress.org/trunk@45095


git-svn-id: http://core.svn.wordpress.org/trunk@44904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 10:08:56 +00:00
Sergey Biryukov ccbf084609 Docs: Fix more typos in `WP_Site_Health` DocBlocks. 
See #46753.
Built from https://develop.svn.wordpress.org/trunk@45094


git-svn-id: http://core.svn.wordpress.org/trunk@44903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 20:30:52 +00:00
Sergey Biryukov 12a2bf946a Docs: Fix typos in `WP_Site_Health` DocBlocks. 
Props mukesh27.
Fixes #46753.
Built from https://develop.svn.wordpress.org/trunk@45093


git-svn-id: http://core.svn.wordpress.org/trunk@44902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 20:23:50 +00:00
Sergey Biryukov 9c8e9354b1 Docs: Add missing `@since` tag for `WP_Site_Health::get_test_php_extensions()`. 
Props mukesh27.
Fixes #46752.
Built from https://develop.svn.wordpress.org/trunk@45092


git-svn-id: http://core.svn.wordpress.org/trunk@44901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 20:17:54 +00:00
Andrea Fercia 83546a04f5 Administration: Site Health: reserve some space for the admin notices. 
Props xkon, Clorith, hedgefield, mapk, karmatosed, afercia.
Fixes #46651.

Built from https://develop.svn.wordpress.org/trunk@45091


git-svn-id: http://core.svn.wordpress.org/trunk@44900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 18:01:52 +00:00
Sergey Biryukov 57a8f51e06 PHPCS: Fix WPCS violation in [45088]. 
See #38168.
Built from https://develop.svn.wordpress.org/trunk@45090


git-svn-id: http://core.svn.wordpress.org/trunk@44899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 16:49:50 +00:00
Sergey Biryukov 130495e1c4 Docs: Correct `@param` description for `remove_theme_support()`. 
Add `@return` description for `current_theme_supports()`.

See #46543.
Built from https://develop.svn.wordpress.org/trunk@45089


git-svn-id: http://core.svn.wordpress.org/trunk@44898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 16:21:50 +00:00
Sergey Biryukov 3f3593aa6c Customize: Only add `custom-background` to `body_class()` if the current theme supports custom background. 
Props wido, swissspidy, ocean90, Mte90.
Fixes #38168.
Built from https://develop.svn.wordpress.org/trunk@45088


git-svn-id: http://core.svn.wordpress.org/trunk@44897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 16:18:52 +00:00
Andrea Fercia d8b8994336 Accessibility: Improve the Site Health accordions. 
- removes the definition list and uses the markup from the ARIA Authoring Practices example
- removes incorrect ARIA roles
- avoids ARIA landmark regions proliferation

Props mukesh27 for the initial patch.
Fixes #46714.

Built from https://develop.svn.wordpress.org/trunk@45087


git-svn-id: http://core.svn.wordpress.org/trunk@44896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 15:08:58 +00:00
Sergey Biryukov 95541a86ff Docs: Correct parameter types for `the_author()`, `get_the_author_meta()`, and `the_author_meta()`. 
Props subrataemfluence.
Fixes #45596.
Built from https://develop.svn.wordpress.org/trunk@45086


git-svn-id: http://core.svn.wordpress.org/trunk@44895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 14:23:53 +00:00
Sergey Biryukov 0aedea9470 Docs: Improve documentation for `get_plugin_page_hook()` and `get_plugin_page_hookname()`. 
Props subrataemfluence, desrosj.
Fixes #44224.
Built from https://develop.svn.wordpress.org/trunk@45085


git-svn-id: http://core.svn.wordpress.org/trunk@44894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 14:09:52 +00:00
Sergey Biryukov 06d8f376ea PHPCS: Fix WPCS violation in [45082]. 
See #42223.
Built from https://develop.svn.wordpress.org/trunk@45084


git-svn-id: http://core.svn.wordpress.org/trunk@44893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 13:30:52 +00:00
Sergey Biryukov 733ec3da48 Docs: Improve documentation for `postbox_classes()`. 
Rename `$page` and `$id` variables to `$screen_id` and `$box_id` for clarity.

Props sharifkiberu, DrewAPicture.
Fixes #45179.
Built from https://develop.svn.wordpress.org/trunk@45083


git-svn-id: http://core.svn.wordpress.org/trunk@44892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 12:47:51 +00:00
Sergey Biryukov 2f5b5baa07 I18N: Merge similar strings about allowed space allocation in Multisite. 
Props ramiy, Jonathandejong, pento.
Fixes #42223.
Built from https://develop.svn.wordpress.org/trunk@45082


git-svn-id: http://core.svn.wordpress.org/trunk@44891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 12:24:51 +00:00
Sergey Biryukov 76e6cc67c2 Bundled Themes: Link to an updated documentation on child themes on developer.wordpress.org, instead of Codex. 
Props man4toman, andraganescu.
Fixes #46450.
Built from https://develop.svn.wordpress.org/trunk@45081


git-svn-id: http://core.svn.wordpress.org/trunk@44890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 11:56:52 +00:00
Sergey Biryukov de95fac19c Themes: Link to an updated documentation on child themes on developer.wordpress.org, instead of Codex. 
Props man4toman.
See #46450.
Built from https://develop.svn.wordpress.org/trunk@45080


git-svn-id: http://core.svn.wordpress.org/trunk@44889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 11:55:52 +00:00
Sergey Biryukov 5cca79f806 Site Health: If `WP_DEBUG_LOG` contains a file path, display it on Site Info tab. 
Props xkon, knutsp, ocean90.
Fixes #46692.
Built from https://develop.svn.wordpress.org/trunk@45079


git-svn-id: http://core.svn.wordpress.org/trunk@44888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 01:26:51 +00:00
Sergey Biryukov c241c16846 Site Health: Simplify the checks for constants that are always defined by default. 
Props xkon.
Fixes #46738.
Built from https://develop.svn.wordpress.org/trunk@45078


git-svn-id: http://core.svn.wordpress.org/trunk@44887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 00:10:53 +00:00
Sergey Biryukov 63d0abd5ff Administration: Fix typo in fatal error email notification. 
Props kraftbj.
Fixes #46722.
Built from https://develop.svn.wordpress.org/trunk@45077


git-svn-id: http://core.svn.wordpress.org/trunk@44886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-30 18:54:51 +00:00
Andrea Fercia 61628dbd8b Administration: Display a notice in the Site Health pages when JavaScript is off. 
- displays an error notice when JavaScript is off, consistently with other admin screens that depend on JavaScript
- keeps the main `h1` visible

Minor clean-ups:
- makes code indentation consistent in `site-health.php` and `site-health-info.php`
- removes a couple of `<div class="wp-clearfix"></div>` as that's not the intended usage of `wp-clearfix` (those divs didn't do anything anyways)

Fixes #46717.

Built from https://develop.svn.wordpress.org/trunk@45076


git-svn-id: http://core.svn.wordpress.org/trunk@44885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-30 15:38:51 +00:00
Andrea Fercia 2737a54374 Accessibility: Make sure the Site Health layout tables are correctly linearized. 
Adds `role="presentation"` to the `<table>` elements used in the Site Health reports.

Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.

Props chetan200891.
Fixes #46725.

Built from https://develop.svn.wordpress.org/trunk@45075


git-svn-id: http://core.svn.wordpress.org/trunk@44884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-30 14:42:51 +00:00
Andrea Fercia fdda9ca9dd Coding Standards: Improve the Site Health CSS for small screens. 
Amends #45071.
See #46685.

Built from https://develop.svn.wordpress.org/trunk@45074


git-svn-id: http://core.svn.wordpress.org/trunk@44883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-30 14:09:51 +00:00
Sergey Biryukov 44602b5ed9 Docs: Fix typos in `site_status_tests` filter DocBlock. 
Props kraftbj.
Fixes #46727.
Built from https://develop.svn.wordpress.org/trunk@45073


git-svn-id: http://core.svn.wordpress.org/trunk@44882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-30 10:58:52 +00:00
Andrea Fercia 0942dfc6d4 Administration: Improve the CSS for the Site Health pages header. 
Avoids the Site Health pages header layout to break when the Hello Dolly plugin or other floated content is printed out at the top of the page.

Props xkon.
Fixes #46650.

Built from https://develop.svn.wordpress.org/trunk@45072


git-svn-id: http://core.svn.wordpress.org/trunk@44881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 18:55:50 +00:00
Andrea Fercia 2a99454732 Coding Standards: Clean up the Site Health stylesheet. 
- reduces selectors specificity to avoid over-qualified selectors
- removes unused rulesets / properties
- renames some CSS classes

Fixes #46685.

Built from https://develop.svn.wordpress.org/trunk@45071


git-svn-id: http://core.svn.wordpress.org/trunk@44880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 18:44:51 +00:00
Andrea Fercia d56f81fe45 Accessibility: Make sure the Site Health pages have a unique document title. 
The document `<title>` gives a name to a web document. In the context of the WordPress admin, a unique, meaningful, title is important for various reasons:
- it allows browser's history to store meaningful entries 
- when multiple browser's tabs are open, it allows users to better identify the tab content 
- it's the first thing screen readers announce when navigating to a web page, thus helping users to identify the nature of the page content

Props chetan200891, mukesh27.
Fixes #46699.

Built from https://develop.svn.wordpress.org/trunk@45070


git-svn-id: http://core.svn.wordpress.org/trunk@44879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 18:27:51 +00:00
Andrea Fercia 9f09fcb1c2 Accessibility: Remove arrows navigation from the Site Health accordions. 
Arrows navigation on accordions is an optional keyboard interaction feature mentioned in the WAI-ARIA Authoring Practices. While it can add some value in some specific cases, it's not so discoverable and it's unlikely users, including assistive technologies users, would really "expect" this kind of interaction.

See #46573.
Fixes #46682.

Built from https://develop.svn.wordpress.org/trunk@45069


git-svn-id: http://core.svn.wordpress.org/trunk@44878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 11:27:51 +00:00
Sergey Biryukov 02983a458d Site Health: Add missing `<ul>` tags for lists on Site Info page. 
Props mukesh27, chetan200891, afercia.
Fixes #46693.
Built from https://develop.svn.wordpress.org/trunk@45068


git-svn-id: http://core.svn.wordpress.org/trunk@44877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 11:14:51 +00:00
Mike Schroder 672372d118 Media: Improve and fix rotate/flip image tests 
Fix off-by-one error in pixel color checks for rotate and flip image tests.
Change to using PNG with single pixel to ensure that errors are caught in the future, rather than lost in JPEG noise.

Props Fuegas, mikeschroder.
Fixes #46073.
Built from https://develop.svn.wordpress.org/trunk@45067


git-svn-id: http://core.svn.wordpress.org/trunk@44876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 02:49:51 +00:00
Andrew Ozz 7ab495bfed TinyMCE: 
- Fix adding the keyboard shortcuts to all button tooltips in the classic editor and classic block.
- Fix translating the aria labels for all buttons.

Fixes #35710;
Built from https://develop.svn.wordpress.org/trunk@45066


git-svn-id: http://core.svn.wordpress.org/trunk@44875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 00:49:51 +00:00
John Blackbourn 5a481ea118 Options, Meta APIs: Remove an accidental short array syntax in the tests. 
See #43561

Built from https://develop.svn.wordpress.org/trunk@45065


git-svn-id: http://core.svn.wordpress.org/trunk@44874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 22:03:52 +00:00
John Blackbourn 8f5d82df7b Options, Meta APIs: Ensure the `$object_id` parameter passed to the `delete_{$meta_type}_meta` and `deleted_{$meta_type}_meta` filters is always an integer. 
Props salcode

Fixes #43561

Built from https://develop.svn.wordpress.org/trunk@45064


git-svn-id: http://core.svn.wordpress.org/trunk@44873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:59:52 +00:00
Sergey Biryukov 2bb2af2731 PHPCS: Fix WPCS violations in [45062]. 
See #46056.
Built from https://develop.svn.wordpress.org/trunk@45063


git-svn-id: http://core.svn.wordpress.org/trunk@44872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:57:51 +00:00
Sergey Biryukov 10409c0f7c Privacy: Ensure the personal data export email is sent in the locale of the user whose data is being exported (or the site's default locale if they are not a registered user) when the administrator fulfilling the request uses a different locale. 
Props garrett-eclipse.
Fixes #46056.
Built from https://develop.svn.wordpress.org/trunk@45062


git-svn-id: http://core.svn.wordpress.org/trunk@44871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:29:50 +00:00
John Blackbourn 437285dba4 Embeds: Update the Crowdsignal embed handler so that surveys on subdomains are supported. 
Props kraftbj

Fixes #46467

Built from https://develop.svn.wordpress.org/trunk@45061


git-svn-id: http://core.svn.wordpress.org/trunk@44870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:27:51 +00:00
Sergey Biryukov 459aef1fa5 Build/Test Tools: Exclude `twentynineteen/node_modules` from `jsvalidate:build` task. 
Fixes #46706.
Built from https://develop.svn.wordpress.org/trunk@45060


git-svn-id: http://core.svn.wordpress.org/trunk@44869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:17:52 +00:00
John Blackbourn 94e4da6aec Themes: Introduce a generic action that's fired when a template part is loaded. 
This action allows debugging mechanisms to perform greater introspection into which template parts are loaded for any given request. It also exposes the array of candidate template part file names for each template part instance.

Props pcfreak30, jdeeburke

Fixes #41575

Built from https://develop.svn.wordpress.org/trunk@45059


git-svn-id: http://core.svn.wordpress.org/trunk@44868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:13:54 +00:00
Aaron Jorbin 9ca5ec97b1 PHP: Finish updating PHP Minimum version 
Previous [44982] and [44950].

This bumps the minimum version down slightly based on some research into the usage of php 5.6. This also brings the recommended version in line with https://wordpress.org/about/requirements/ . 

The travis matrix is also being reduced in order to speed up builds. This is a hard break. PHP 5.2 - 5.5 we are never ever, ever, getting back together. You go talk to your friends, talk to my friends, talk to me, But we are never ever, ever, ever getting back together.

Props DD32, afergen for research.
Fixes #46594.


Built from https://develop.svn.wordpress.org/trunk@45058


git-svn-id: http://core.svn.wordpress.org/trunk@44867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:12:52 +00:00
Sergey Biryukov 9ebc5e85fd Twenty Nineteen: Update `Theme URI` to point to the Theme Directory instead of the archived GitHub repository. 
Update `style.scss` and `style-rtl.css`, missed in [45032].

Props dimadin.
See #46668.
Built from https://develop.svn.wordpress.org/trunk@45057


git-svn-id: http://core.svn.wordpress.org/trunk@44866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 20:58:51 +00:00
Sergey Biryukov 4e4e8fa110 Bootstrap/Load: Ensure the fatal error handler is registered after `WP_CONTENT_DIR` is defined, so the custom error handler drop-in could be properly loaded. 
Props sebastian.pisula, diddledan.
Fixes #46069.
Built from https://develop.svn.wordpress.org/trunk@45056


git-svn-id: http://core.svn.wordpress.org/trunk@44865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 19:04:51 +00:00
Sergey Biryukov a2577854e6 Site Health: Declare `ClipboardJS` global to fix JSHint issue. 
See #46647.
Built from https://develop.svn.wordpress.org/trunk@45055


git-svn-id: http://core.svn.wordpress.org/trunk@44864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 18:38:51 +00:00
Sergey Biryukov 5cb984d371 Docs: Fix typo in `xmlrpc_chunk_parsing_size` filter description. 
Props lord_viper.
Fixes #46701.
Built from https://develop.svn.wordpress.org/trunk@45054


git-svn-id: http://core.svn.wordpress.org/trunk@44863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 16:53:51 +00:00
Sergey Biryukov 774ac73a1f CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/widgets.css`. 
Props ianbelanger, audrasjb.
Fixes #46531. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45053


git-svn-id: http://core.svn.wordpress.org/trunk@44862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 16:39:51 +00:00
Sergey Biryukov a02494a80f Site Health: Add description for a successful HTTPS check. 
Props Clorith, xkon.
Fixes #46617.
Built from https://develop.svn.wordpress.org/trunk@45052


git-svn-id: http://core.svn.wordpress.org/trunk@44861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 16:15:51 +00:00
Sergey Biryukov 07d5eda632 Twenty Seventeen: Make `<th>` styling in table block consistent between back end and front end. 
Props ianbelanger.
Fixes #46568.
Built from https://develop.svn.wordpress.org/trunk@45051


git-svn-id: http://core.svn.wordpress.org/trunk@44860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 15:25:50 +00:00
Sergey Biryukov e2115d62b6 Site Health: Use a consistent wording and response code for capability checks. 
Props mukesh27 for initial patch.
Fixes #46691.
Built from https://develop.svn.wordpress.org/trunk@45050


git-svn-id: http://core.svn.wordpress.org/trunk@44859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 15:11:51 +00:00
Sergey Biryukov d69165bd3b Site Health: Correct `wp_version_check()` existence verification by performing a request to the Site Health page instead of Dashboard. 
Props Clorith, audrasjb.
Fixes #46616.
Built from https://develop.svn.wordpress.org/trunk@45049


git-svn-id: http://core.svn.wordpress.org/trunk@44858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 14:31:51 +00:00
Gary Pendergast ffc064d82d Post WordPress 5.2 Beta 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@45048


git-svn-id: http://core.svn.wordpress.org/trunk@44857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 23:36:52 +00:00
Gary Pendergast d0445ead0c WordPress 5.2 Beta 1. 
Built from https://develop.svn.wordpress.org/trunk@45047


git-svn-id: http://core.svn.wordpress.org/trunk@44856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 23:20:51 +00:00
Gary Pendergast 0a4d431e11 Upgrades: Allow upgrades to proceed when a soft failure occurs on package signatures. 
In particular, this allows downgrading from WordPress 5.2 to 5.1.1, if sites wish to opt out of the beta.

Props dd32.
See #46615.


Built from https://develop.svn.wordpress.org/trunk@45046


git-svn-id: http://core.svn.wordpress.org/trunk@44855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 23:05:54 +00:00
Sergey Biryukov d5f198676b Plugins: In `wp_update_php_annotation()`, only display the annotation and the surrounding tags if it's not empty. 
Props afragen.
Fixes #46678.
Built from https://develop.svn.wordpress.org/trunk@45045


git-svn-id: http://core.svn.wordpress.org/trunk@44854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 22:37:51 +00:00
Gary Pendergast 65f7cdbce0 Site Health: Improve the "Copy to clipboard" button. 
The previous method for copying the debug report to the clipboard involved having a hidden `<textarea>`, but this shows up in screen readers and can't be reliably hidden.

To work around this, the button now uses the `clipboard.js` library, which automatically handles browser differences in the Clipboard API, and can load the text to copy from a `data-` attribute on the button.

Props pento, hedgefield, afercia.
Fixes #46647.


Built from https://develop.svn.wordpress.org/trunk@45044


git-svn-id: http://core.svn.wordpress.org/trunk@44853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 22:31:52 +00:00
Sergey Biryukov 179c2ea230 Plugins: Disable "Update Now" button for plugins that require a higher version of PHP or WordPress. 
This complements disabling the "Install Now" button in [43436].

Props afragen.
Fixes #46677. See #43986.
Built from https://develop.svn.wordpress.org/trunk@45043


git-svn-id: http://core.svn.wordpress.org/trunk@44852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 22:11:53 +00:00
Adam Silverstein 418afaa938 Bundled Theme: trigger a new `wp_body_open` action immediately after the opening `body` tag. 
* Enables inserting (asynchronous) JavaScript right after the opening `body` tag.
* Add a `wp_body_open` helper function that triggers the `wp_body_open` action.
* Call `wp_body_open` in core themes immediately after the opening `body` tag.

Props joostdevalk, valendesigns, nacin, saracup, jorbin, mikeschinkel, jonnybojangles, lgedeon, Willscrlt, Denis-de-Bernardy, lexiqueen, sky_76, welcher, westonruter, ramiy, joyously.
Fixes #12563.

Built from https://develop.svn.wordpress.org/trunk@45042


git-svn-id: http://core.svn.wordpress.org/trunk@44851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 21:59:52 +00:00
Andrea Fercia 9b15549b1c Accessibility: Simplify the Site Health score indicator. 
The Site Health score indicator isn't exactly a "progress bar" and shouldn't use ARIA roles and properties related to progress bars. Also, some browser / screen reader combinations don't announce the score properly.
- removes any ARIA
- adds a screen-reader-text "Current health score:"
- adds `role="img" aria-hidden="true" focusable="false"` to the SVG
- reduces CSS specificity simplifying unnecessary overqualified selectors
- fixes the syntax for ::after and ::before (double colon)

Fixes #46621.

Built from https://develop.svn.wordpress.org/trunk@45041


git-svn-id: http://core.svn.wordpress.org/trunk@44850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 20:39:51 +00:00
desrosj f9de2f860d Administration: Fix Dashicon backwards compatibility issues. 
In [44940], the Dashicon files in core were updated to contain the latest version of the font from the GitHub repo. This change follows that up by fixing several backwards compatibility issues caused by the new build process used to generate the font files and fixes the missing menu icon when viewing the admin on small screens.

- `buddicons-bbpress-logo (f12b)` was moved back to the correct location of `f477`.
- `editor-ltr (f129)` was moved back to the correct location of `f10c`.
- `email-alt2 (f10a)` was moved to the correct location of `f467`. 

The following icons were restored to their previous locations:

- `camera-alt (f129)`
- `edit-large (f327)`
- `editor-distractionfree (f211)`
- `update-alt (f113)`
- `twitter-alt (f302)`
- `text-page (f121)`
- `plugins-checked (f485)`
- `menu-alt3 (f349)`
- `menu-alt2 (f329)`
- `menu-alt (f228)`
- Duplicate lock icon at location `f315`
- Duplicate `editor-code` icon at location `f494`
- `arrow-up` at `f143`.

The `editor-ltr` and `editor-rtl` icons had also been switched. The arrows now point in the correct directions at the correct Unicode locations (`f10c` and `f320` respectively).

And, lastly, this change also introduces the `code-standards (f13a)` icon that was not included in the previous build.

Props afercia, earnjam, oztaser, joen, cathibosco1, ianbelanger, desrosj.
See #41074.
Fixes #46611.
Built from https://develop.svn.wordpress.org/trunk@45040


git-svn-id: http://core.svn.wordpress.org/trunk@44849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 19:59:52 +00:00
Sergey Biryukov b6a145ccb5 Privacy: Ensure the privacy data erase fulfillment email is sent in the locale of the user whose data is being erased (or the site's default locale if they are not a registered user) when the administrator fulfilling the request uses a different locale. 
Props desrosj, birgire, garrett-eclipse.
Fixes #44721.
Built from https://develop.svn.wordpress.org/trunk@45039


git-svn-id: http://core.svn.wordpress.org/trunk@44848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 19:41:53 +00:00
Andrea Fercia 7bedcf0bee Accessibility: Improve the "Alt text" description. 
Moves the word "Describe" within the link.

Amends [44900].
See #41612.

Built from https://develop.svn.wordpress.org/trunk@45038


git-svn-id: http://core.svn.wordpress.org/trunk@44847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 18:47:51 +00:00
John Blackbourn 8190f1f0f8 Docs: Correct the documentation for the oEmbed HTML filtering. 
See #46543

Built from https://develop.svn.wordpress.org/trunk@45037


git-svn-id: http://core.svn.wordpress.org/trunk@44846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 17:14:52 +00:00
John Blackbourn c155b2a833 Docs: Improve the documentation for metadata related filter parameters. 
See #46543

Built from https://develop.svn.wordpress.org/trunk@45036


git-svn-id: http://core.svn.wordpress.org/trunk@44845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 17:10:53 +00:00
John Blackbourn 9e67ba895d Docs: Correct some documentation typos. 
See #46543

Built from https://develop.svn.wordpress.org/trunk@45035


git-svn-id: http://core.svn.wordpress.org/trunk@44844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 17:09:52 +00:00
Sergey Biryukov 7807324652 Taxonomy: Initialize `$noparents` variable in `wp_ajax_add_tag()` to avoid a notice with `compact()` in PHP 7.3. 
Props pilou69.
Fixes #46670.
Built from https://develop.svn.wordpress.org/trunk@45034


git-svn-id: http://core.svn.wordpress.org/trunk@44843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 15:33:52 +00:00
Sergey Biryukov 06bb67be06 Docs: Correct back-compat reference to `$excluded_categories` in `get_adjacent_post()`. 
See #46543, #17673.
Built from https://develop.svn.wordpress.org/trunk@45033


git-svn-id: http://core.svn.wordpress.org/trunk@44842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 14:45:51 +00:00
Sergey Biryukov 8633d837ee Twenty Nineteen: Update `Theme URI` to point to the Theme Directory instead of the archived GitHub repository. 
Props dimadin.
Fixes #46668.
Built from https://develop.svn.wordpress.org/trunk@45032


git-svn-id: http://core.svn.wordpress.org/trunk@44841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 14:32:51 +00:00
Sergey Biryukov 0416de3294 General: Pass `$pagenum` argument to `get_pagenum_link` filter. 
Props dimadin.
Fixes #46667.
Built from https://develop.svn.wordpress.org/trunk@45031


git-svn-id: http://core.svn.wordpress.org/trunk@44840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 14:24:52 +00:00
Sergey Biryukov b2e3f517e1 Database: Use `wp_die()` instead of `die()` in `wp_check_mysql_version()`, for more flexibility and consistency with other error messages in core. 
Props spacedmonkey.
Fixes #45975.
Built from https://develop.svn.wordpress.org/trunk@45030


git-svn-id: http://core.svn.wordpress.org/trunk@44839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 14:03:51 +00:00
Sergey Biryukov 577dc2326a Bootstrap/Load: Restore `$wp_version` global check in `WP_Locale::init()`, previously replaced with `get_bloginfo( 'version' )` in [38459]. 
`wp_load_translations_early()` can be called in contexts where `get_bloginfo()` is not available yet, e.g. in `wp_check_php_mysql_versions()`.

Props shazdeh, parsmizban.
Fixes #41092.
Built from https://develop.svn.wordpress.org/trunk@45029


git-svn-id: http://core.svn.wordpress.org/trunk@44838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 13:27:52 +00:00
Sergey Biryukov d4d906c4d5 Themes: Remove `itemprop="url"` from `get_custom_logo()` output. 
Making incorrect assumptions about microdata used in a theme results in invalid markup.

The attribute can still be added using the `get_custom_logo` or `wp_get_attachment_image_attributes` filter, but it should not be added by default.

Props henry.wright, tfrommen, afercia, markcallen, zodiac1978.
Fixes #37305.
Built from https://develop.svn.wordpress.org/trunk@45028


git-svn-id: http://core.svn.wordpress.org/trunk@44837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 12:16:53 +00:00
Sergey Biryukov 6e2fb402e1 Build/Test Tools: Enable persistent object cache on a PHP 7.3 build instead of PHP 5.6. 
Props netweb, johnbillion.
Fixes #46633.
Built from https://develop.svn.wordpress.org/trunk@45027


git-svn-id: http://core.svn.wordpress.org/trunk@44836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 03:06:51 +00:00
Sergey Biryukov 6be19e0dab Site Health: Update "Passed tests" button label to match both expanded and collapsed state. 
Add `aria-controls` to declare what ID is being toggled.

Props Clorith, afercia.
Fixes #46663. See #46573.
Built from https://develop.svn.wordpress.org/trunk@45026


git-svn-id: http://core.svn.wordpress.org/trunk@44835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 02:57:51 +00:00
Sergey Biryukov ada13d2ffd PHPCS: Fix WPCS violations in [45023]. 
See #46620.
Built from https://develop.svn.wordpress.org/trunk@45025


git-svn-id: http://core.svn.wordpress.org/trunk@44834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 00:36:50 +00:00
Sergey Biryukov f8cfe858c9 Embeds: Scribd: Add support for `/document/` URL format, in addition to `/doc/`. 
Props manzoorwani.jk, neobabis, swissspidy.
Fixes #46444.
Built from https://develop.svn.wordpress.org/trunk@45024


git-svn-id: http://core.svn.wordpress.org/trunk@44833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 00:34:52 +00:00
Sergey Biryukov 455dccbc00 Bootstrap/Load: In fatal error handler, pass the error information through to error template and associated filters: `wp_php_error_message`, `wp_php_error_args`. 
This allows the custom error handler and default error message filters to inspect the error and perform logic based on its properties.

Props johnbillion.
Fixes #46620.
Built from https://develop.svn.wordpress.org/trunk@45023


git-svn-id: http://core.svn.wordpress.org/trunk@44832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 00:16:51 +00:00
Sergey Biryukov b4ded564ff PHPCS: Remove extra tab added in [45019]. 
See #45974.
Built from https://develop.svn.wordpress.org/trunk@45022


git-svn-id: http://core.svn.wordpress.org/trunk@44831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 00:03:51 +00:00
Sergey Biryukov 6037e5ab5e Plugins: Use correct singular for "Drop-in" in plugins list table. 
Props tobifjellner, mukesh27.
Fixes #46592.
Built from https://develop.svn.wordpress.org/trunk@45021


git-svn-id: http://core.svn.wordpress.org/trunk@44830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 00:00:50 +00:00
Sergey Biryukov a5f0cd8741 Build/Test Tools: Display an error message with a recommendation to run `grunt build` when trying to run WordPress core tests without the `/build/` directory. 
Props davidbaumwald.
Fixes #46593.
Built from https://develop.svn.wordpress.org/trunk@45020


git-svn-id: http://core.svn.wordpress.org/trunk@44829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-26 23:53:52 +00:00
Sergey Biryukov 3e5c258b74 Bootstrap/Load: Use `wp_die()` instead of hardcoded HTML in `wp_maintenance()`, so the output can be filtered by plugins. 
Props spacedmonkey.
Fixes #45974.
Built from https://develop.svn.wordpress.org/trunk@45019


git-svn-id: http://core.svn.wordpress.org/trunk@44828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-26 23:39:51 +00:00
Sergey Biryukov f6b6dc7e73 Docs: Fix typo in `wp_is_xml_request()` description. 
See #46026.
Built from https://develop.svn.wordpress.org/trunk@45018


git-svn-id: http://core.svn.wordpress.org/trunk@44827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-26 23:21:51 +00:00
Sergey Biryukov 65b1cbfd45 Docs: Improve documentation for `wp_die()` handlers after [45015] and [45016]. 
See #46543, #46025, #46026.
Built from https://develop.svn.wordpress.org/trunk@45017


git-svn-id: http://core.svn.wordpress.org/trunk@44826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-26 23:18:53 +00:00
Sergey Biryukov 546841949f Bootstrap/Load: Add support for XML requests to `wp_die()`. 
In addition to AJAX, XML-RPC, JSON, and JSONP requests, `wp_die()` now handles XML requests correctly, returning information in the expected content type.

Props spacedmonkey, birgire.
Fixes #46026. See #44458.
Built from https://develop.svn.wordpress.org/trunk@45016


git-svn-id: http://core.svn.wordpress.org/trunk@44825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-26 23:11:52 +00:00
Sergey Biryukov 4101255505 Bootstrap/Load: Add support for JSONP requests to `wp_die()`. 
In addition to AJAX, XML-RPC, and JSON requests, `wp_die()` now handles JSONP requests correctly, returning information in the expected content type.

Props spacedmonkey, TimothyBlynJacobs.
Fixes #46025. See #44458.
Built from https://develop.svn.wordpress.org/trunk@45015


git-svn-id: http://core.svn.wordpress.org/trunk@44824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-26 22:26:52 +00:00
Sergey Biryukov 3f6a9eb0e3 Bootstrap/Load: Always run the fatal error handler at shutdown, but don't display the PHP error template once headers are sent. 
If a fatal error occurs midway through a page load, or in a REST API request, it still needs to be handled internally for the recovery mode, but the custom message may conflict with already rendered output, e.g. by displaying HTML markup in an XML or JSON request.

Props spacedmonkey, flixos90, TimothyBlynJacobs.
Fixes #45989. See #44458.
Built from https://develop.svn.wordpress.org/trunk@45014


git-svn-id: http://core.svn.wordpress.org/trunk@44823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-26 20:30:53 +00:00
John Blackbourn 6b6201ed89 Build/Test tools: Reinstate fast finishing on Travis CI. 
This allows for speedier feedback for breaking changes and ongoing failures.

See #46634

Built from https://develop.svn.wordpress.org/trunk@45004


git-svn-id: http://core.svn.wordpress.org/trunk@44821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-25 16:08:50 +00:00
John Blackbourn d4d5a04075 Build/Test tools: Switch npm dependency caching strategy on Travis CI. 
This switches to caching npm's local cache instead of `node_modules` in order to prevent issues caused by modules compiled using a different version of node.

See #46632

Built from https://develop.svn.wordpress.org/trunk@44993


git-svn-id: http://core.svn.wordpress.org/trunk@44820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-25 00:52:53 +00:00
Andrea Fercia a668866f05 Admin: Site Health JavaScript minor clean-up. 
See #46573.

Built from https://develop.svn.wordpress.org/trunk@44988


git-svn-id: http://core.svn.wordpress.org/trunk@44819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-23 16:39:52 +00:00
Sergey Biryukov 8ea4da0826 Privacy: Update default privacy policy text to match the current behavior of setting a temporary cookie on visiting the login page. 
Props mechter, subrataemfluence, garrett-eclipse.
Fixes #44175.
Built from https://develop.svn.wordpress.org/trunk@44987


git-svn-id: http://core.svn.wordpress.org/trunk@44818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-23 10:54:53 +00:00
Gary Pendergast 0a9d61ab63 Admin: Introduce the Site Health screens. 
The Site Health tool serves two purposes:
- Provide site owners with information to improve the performance, reliability, and security of their site.
- Collect comprehensive debug information about the site.

By encouraging site owners to maintain their site and adhere to modern best practices, we ultimately improve the software hygeine of both the WordPress ecosystem, and the open internet as a whole.

Props Clorith, hedgefield, melchoyce, xkon, karmatosed, jordesign, earnjam, ianbelanger, wpscholar, desrosj, pedromendonca, peterbooker, jcastaneda, garyj, soean, pento, timothyblynjacobs, zodiac1978, dgroddick, garrett-eclipse, netweb, tobifjellner, pixolin, afercia, joedolson, birgire.
See #46573.

Built from https://develop.svn.wordpress.org/trunk@44986


git-svn-id: http://core.svn.wordpress.org/trunk@44817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-23 03:55:53 +00:00
Adam Silverstein cd67264bb2 Multisite: add new `sites_pre_query` and `networks_pre_query` filters to short circuit WP_Site_Query and WP_Network_Query queries. 
Similar to the `posts_pre_query` filter for WP_Query added in #36687. These filters lets you short circuit the queries to return your own results.

Add a new filter `sites_pre_query` - which returns null by default. Return a non-null value to bypass WordPress's default `get_sites` queries.

Developers should note that filtering functions that require pagination information are encouraged to set the `found_sites` property of the `WP_Site_Query` object, passed to the filter by reference. If `WP_Site_Query` does not perform a database query, it will not have enough information to generate these values itself.

Add a new filter `networks_pre_query` - which returns null by default. Return a non-null value to bypass WordPress's default `get_networks` queries.

Developers should note that filtering functions that require pagination information are encouraged to set the `found_networks` property of the `WP_Network_Query` object, passed to the filter by reference. If `WP_Network_Query` does not perform a database query, it will not have enough information to generate these values itself.

Props spacedmonkey.
Fixes #45749.


Built from https://develop.svn.wordpress.org/trunk@44983


git-svn-id: http://core.svn.wordpress.org/trunk@44814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-22 17:26:51 +00:00
Aaron Jorbin bd83b90f1e PHP: Bump minimum version 
95% of 5.6 sites are on 5.6.30 or higher, hence this specific minimum version.

Fixes #46594.



Built from https://develop.svn.wordpress.org/trunk@44982


git-svn-id: http://core.svn.wordpress.org/trunk@44813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-22 15:47:51 +00:00
Sergey Biryukov 50bb3c689f Plugins: Remove `wp_is_wp_compatible()` and `wp_is_php_compatible()` functions added in [44978] for now, to discuss use cases and better naming. 
See #46599, #43992.
Built from https://develop.svn.wordpress.org/trunk@44981


git-svn-id: http://core.svn.wordpress.org/trunk@44812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-22 13:00:52 +00:00
Sergey Biryukov 79e9aa9ed6 Plugins: Use `<em>` instead of `<span>` for PHP annotation in `wp_plugin_update_row()`, for consistency with other instances. 
Props afragen.
Fixes #46598. See #43987.
Built from https://develop.svn.wordpress.org/trunk@44980


git-svn-id: http://core.svn.wordpress.org/trunk@44811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-22 01:08:51 +00:00
Sergey Biryukov 8954465943 PHPCS: Fix WPCS violations in [44978]. 
See #43992.
Built from https://develop.svn.wordpress.org/trunk@44979


git-svn-id: http://core.svn.wordpress.org/trunk@44810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-22 01:00:52 +00:00
Sergey Biryukov 75a3e484ec Plugins: Block plugin activation if it requires a higher version of PHP or WordPress. 
Introduce `validate_plugin_requirements()` for validating a plugin's WordPress and PHP version requirements.

Introduce `wp_is_wp_compatible()` and `wp_is_php_compatible()` for checking compatibility with the current WordPress or PHP version.

Props afragen, joyously, DrewAPicture, TimothyBlynJacobs, desrosj, flixos90, SergeyBiryukov.
See #43992.
Built from https://develop.svn.wordpress.org/trunk@44978


git-svn-id: http://core.svn.wordpress.org/trunk@44809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-22 00:37:50 +00:00
desrosj 36af5473be Networks and Sites: Introduce the `ms_user_list_site_class` filter. 
In the network admin user table on multisite installs (`WP_MS_Users_List_Table`), this filter allows the classes for the `<span>` tag surrounding each site link to be modified.

Props kraftbj, flixos90, johnjamesjacoby.
Fixes #41146.
Built from https://develop.svn.wordpress.org/trunk@44977


git-svn-id: http://core.svn.wordpress.org/trunk@44808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-21 23:55:51 +00:00