WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
31,532 Commits 50 Branches 749 Tags 992 MiB
Commit Graph

127 Commits

Author SHA1 Message Date
Scott Taylor 4671e03766 Comments List Table: include count for "All". Dynamically update. 
Fixes #17275.

Built from https://develop.svn.wordpress.org/trunk@34506


git-svn-id: http://core.svn.wordpress.org/trunk@34470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 17:57:25 +00:00
Scott Taylor bc5eb3a623 Comments: add `date` column to `WP_Comments_List_Table` to allow sorting and to break out the date/time from the comment content column. 
Props jshreve.
Fixes #15520.

Built from https://develop.svn.wordpress.org/trunk@34504


git-svn-id: http://core.svn.wordpress.org/trunk@34468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-24 17:27:26 +00:00
Sergey Biryukov 8db1c75a7e Remove extra HTML from translatable strings in `WP_Comments_List_Table::get_views()`. 
Add a context and translator comments.

Props Tmeister for initial patch.
Fixes #31859.
Built from https://develop.svn.wordpress.org/trunk@34424


git-svn-id: http://core.svn.wordpress.org/trunk@34388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 14:33:25 +00:00
Scott Taylor f9c2a88a8a List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used. 
Props wonderboymusic, Viper007Bond.
Fixes #21249.

Built from https://develop.svn.wordpress.org/trunk@34383


git-svn-id: http://core.svn.wordpress.org/trunk@34347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-22 06:06:25 +00:00
Sergey Biryukov 7adaef50bb Include placeholders in translator comments. 
See #31857.
Built from https://develop.svn.wordpress.org/trunk@34304


git-svn-id: http://core.svn.wordpress.org/trunk@34268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 18:58:24 +00:00
Scott Taylor ec01716bb2 Don't use HTML tags in translation strings for "In Reply To" links for comments in the admin. 
Props ramiy.
Fixes #31857.

Built from https://develop.svn.wordpress.org/trunk@34297


git-svn-id: http://core.svn.wordpress.org/trunk@34261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 18:36:24 +00:00
Scott Taylor 5920e8eb13 Move `WP_Post_Comments_List_Table` to its own file. 
See #33413.

Built from https://develop.svn.wordpress.org/trunk@34223


git-svn-id: http://core.svn.wordpress.org/trunk@34187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-16 06:53:24 +00:00
Scott Taylor 98acab10ea Comments/PHP Notices: check that a parent comment exists before displaying an orphan's link to it in the admin. 
Props rachelbaker.
Fixes #33710.

Built from https://develop.svn.wordpress.org/trunk@34015


git-svn-id: http://core.svn.wordpress.org/trunk@33984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 20:51:23 +00:00
Scott Taylor 52516a68ab After the `global` churn in [33964], also set `$post` to `null` at the end of `WP_Comments_List_Table::single_row()` to ensure that an orphaned comment doesn't inherit the previous row's `$post` context. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33986


git-svn-id: http://core.svn.wordpress.org/trunk@33955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 03:12:23 +00:00
Scott Taylor 71f955dc84 In `WP_Comments_List_Table`, favor passing `WP_Comment` instances instead of `$comment_ID` to template functions. This allows us to bypass unnecessary cache lookups and simply pass the object through when it is set. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33964


git-svn-id: http://core.svn.wordpress.org/trunk@33933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 03:00:24 +00:00
Scott Taylor 80a20e5c3d Handle more cases (`untrailingslashit`, HTTPS urls) for sanitizing an author URL for display in the comments list table. 
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291.

Built from https://develop.svn.wordpress.org/trunk@33894


git-svn-id: http://core.svn.wordpress.org/trunk@33863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 23:23:24 +00:00
Drew Jaynes 375d30f699 Docs: Add a duplicate filter comment to the `comment_email` filter call in `WP_Comments_List_Table`, introduced in [33829]. 
See #11566.

Built from https://develop.svn.wordpress.org/trunk@33830


git-svn-id: http://core.svn.wordpress.org/trunk@33798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:22:21 +00:00
Scott Taylor a5b157ffde Remove the hamburger global'ing from [33828]: since no args are passed to `comment_author_email_link()`, the internals can be simplified and applied inline. 
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33829


git-svn-id: http://core.svn.wordpress.org/trunk@33797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:09:21 +00:00
Scott Taylor d0a1a47708 Fix warnings after [33826]. Only only one function call needs a global `$comment`, we shall hamburger it. 
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33828


git-svn-id: http://core.svn.wordpress.org/trunk@33796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 20:59:21 +00:00
Scott Taylor 7ab015c5ab `WP_Comments_List_Table::single_row()` has no reason to set the `$comment` global. No other methods use it, and we are not in template/loop context. This can mess with the response of `get_comment()` elsewhere, since `get_comment()` internally bypasses the cache/db when a global is set. 
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33826


git-svn-id: http://core.svn.wordpress.org/trunk@33794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 20:42:21 +00:00
Sergey Biryukov 8b1fe986c3 Use `wp_html_excerpt()` to properly cut comment author URL for display on Comments screen. 
props brettz95, solarissmoke.
fixes #15659.
Built from https://develop.svn.wordpress.org/trunk@33825


git-svn-id: http://core.svn.wordpress.org/trunk@33793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 20:41:21 +00:00
Scott Taylor 20f6db2b18 Comment List Tables: 
* Ensure that dynamic bubble counts are in sync by `comment_post_ID`
* Scope `:animated` to `#the-comment-list`

See #11200.


Built from https://develop.svn.wordpress.org/trunk@33662


git-svn-id: http://core.svn.wordpress.org/trunk@33629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 16:36:25 +00:00
Scott Taylor 2e2223ae74 Comments List Table: 
* In a view that initially has comments, but they get removed due to user actions: show the `No Items` row instead of bombing out and showing nothing (which looks broken)
* To accomplish this, in `WP_Comments_List_Table::display()`: call `->display_rows_or_placeholder()` instead of `->display()`
* Listen for the end of row `.fadeOut()`s if necessary using jQuery Promises

Fixes #11200.

Built from https://develop.svn.wordpress.org/trunk@33657


git-svn-id: http://core.svn.wordpress.org/trunk@33624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 05:54:25 +00:00
Scott Taylor df618f3461 Comments List Table: 
* Show count next to "Approved"
* Properly increment/decrement counts when row actions are clicked
* In `_wp_ajax_delete_comment_response()`, return the comment's `status` with the `supplemental` data
* Handle counts properly on each scenario of `undo`

See #11200.

Built from https://develop.svn.wordpress.org/trunk@33655


git-svn-id: http://core.svn.wordpress.org/trunk@33622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-20 02:51:25 +00:00
Dominik Schilling f74a907eac Capabilities: Fall back to the `edit_posts` capability for orphaned comments. 
Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.

props pento, dd32.
fixes #33154.
Built from https://develop.svn.wordpress.org/trunk@33614


git-svn-id: http://core.svn.wordpress.org/trunk@33581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-13 22:31:24 +00:00
Helen Hou-Sandí 7b7ae2ee25 Comments list table: Display that cute lil comment bubble. 
The comments list table suffers from "wall of text" problems, which the two plain text links compounded.

props obenland. fixes #33149.

Built from https://develop.svn.wordpress.org/trunk@33490


git-svn-id: http://core.svn.wordpress.org/trunk@33457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-29 18:08:25 +00:00
Sergey Biryukov 48a1c86245 Comment string tweaks: 
* Merge two strings about an invalid comment ID.
* Add missing context to 'Mark as Spam' string.
* Merge two 'In Response To' strings, replace redundant context with a translator comment.

props pavelevap.
fixes #32334.
Built from https://develop.svn.wordpress.org/trunk@33436


git-svn-id: http://core.svn.wordpress.org/trunk@33403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-26 23:36:24 +00:00
Scott Taylor 4d34e37311 List Tables: 
* In `->handle_row_actions()`, bail immediately if `$primary` and `$column_name` do not match. Saves us a nesting level and avoids declaring code that is unusable.
* In `WP_List_Table::single_row_columns()`, allow `_column_{$name}` to be called dynamically by core to avoid having to override the entirety of `->single_row_columns()` in `WP_MS_Users_List_Table` and `WP_Posts_List_Table`
* In `WP_MS_Sites_List_Table`, `id` is not a column.

Props wonderboymusic, paulwilde.
Fixes #29881.

Built from https://develop.svn.wordpress.org/trunk@33270


git-svn-id: http://core.svn.wordpress.org/trunk@33242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-14 17:47:24 +00:00
Helen Hou-Sandí 6e73f1282e List tables: Better accessibility and design for the comments bubble. 
It is now plain text in the comments list table's "In Response To" column, where it was visually a bit confusing to have the bubble. For other list tables, it now shows a little notification bubble with the number of pending comments. The bubble and notification become plain text in the responsive list table view. It also shows no bubble when there are no comments at all, reducing some of the visual noise.

props picard102, afercia, karinchristen.
fixes #32152.

Built from https://develop.svn.wordpress.org/trunk@33155


git-svn-id: http://core.svn.wordpress.org/trunk@33127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-10 21:44:25 +00:00
Helen Hou-Sandí df220685a0 List tables: Account for comments being reused on the post edit screen. 
Adding the `.wp-list-table` class gets us a few responsive goodies for free. And now it won't show a strange button outline.

see #32395.

Built from https://develop.svn.wordpress.org/trunk@33101


git-svn-id: http://core.svn.wordpress.org/trunk@33072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-07 00:09:24 +00:00
Helen Hou-Sandí 8eb7f71e6b List tables: A better responsive view. 
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.

Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.

props Michael Arestad, helen.
see #32395.

Built from https://develop.svn.wordpress.org/trunk@33016


git-svn-id: http://core.svn.wordpress.org/trunk@32987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-01 01:31:25 +00:00
Scott Taylor 5c6b63d3a6 `if` is a statment, not a function. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32800


git-svn-id: http://core.svn.wordpress.org/trunk@32771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 20:01:25 +00:00
Scott Taylor f88b42be94 In `WP_Comments_List_Table::column_comment()`, `$post` and `$the_comment_status` are unused, as is the `$comment_status` global. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32736


git-svn-id: http://core.svn.wordpress.org/trunk@32707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:39:25 +00:00
Drew Jaynes 5457eb4933 Add missing return descriptions and fix formatting of inline documentation introduced in [32644]. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32660


git-svn-id: http://core.svn.wordpress.org/trunk@32630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:18:26 +00:00
Scott Taylor 6a08b00632 Add `@access` annotations to methods that have no doc block in `wp-admin/includes/*`. 
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32656


git-svn-id: http://core.svn.wordpress.org/trunk@32626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 21:32:24 +00:00
Scott Taylor c6a4512b1b Add missing doc blocks to `wp-admin/includes/*`. 
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32654


git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 20:17:26 +00:00
Helen Hou-Sandí f5646cd9e5 Define a primary column for `WP_Post_Comments_List_Table`. 
props boonebgorges.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32651


git-svn-id: http://core.svn.wordpress.org/trunk@32621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 15:52:25 +00:00
Helen Hou-Sandí 4c0c7fd7ba List tables: introduce the concept of a "primary" column. 
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.

props stephdau, DaveAl, jesin.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32644


git-svn-id: http://core.svn.wordpress.org/trunk@32614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 02:41:25 +00:00
Scott Taylor b56b9b3e5c Add `@global` annotations for `wp-admin/*`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32642


git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 21:41:30 +00:00
Scott Taylor 19b8ef0c92 `get_comments()` can return `int`, so a few places need to check if the return value is traversable before passing what is assumed to be an `array`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32600


git-svn-id: http://core.svn.wordpress.org/trunk@32570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 17:59:25 +00:00
Scott Taylor 5a3dc2a371 In `WP_Comments_List_Table::column_comment()`, all of the nonced URLs can be defined in the same conditional block in which they are used. Not doing this causes ambiguity, and local vars are set that are not available to all execution paths. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32516


git-svn-id: http://core.svn.wordpress.org/trunk@32486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-19 20:46:25 +00:00
Gary Pendergast e3f1f8fed1 Ensure post titles are correctly escaped on the Dashboard. 
Props helen, ocean90, dd32, pento.


Built from https://develop.svn.wordpress.org/trunk@32175


git-svn-id: http://core.svn.wordpress.org/trunk@32150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-20 07:39:25 +00:00
Dominik Schilling 5ef13b688e Comments List: Don't let "Quick Edit" break on smaller screens. 
Other class-wp-*-list-table.php files already contain a non-breaking space for the Quick Edit row action.

props kraftbj.
fixes #31482.
Built from https://develop.svn.wordpress.org/trunk@31889


git-svn-id: http://core.svn.wordpress.org/trunk@31868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-25 22:15:27 +00:00
Dion Hulse cc903c3422 Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified. 
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`

These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`

Props iseulde. Fixes #31121

Built from https://develop.svn.wordpress.org/trunk@31862


git-svn-id: http://core.svn.wordpress.org/trunk@31841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-23 02:14:27 +00:00
Scott Taylor 0ec87e4584 There are a few functions that have the ability to return `false` instead of a string, so the return value should be checked before being passed to functions that expect string. 
These are trivial, but they clear out some Scrutinizer issues.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31681


git-svn-id: http://core.svn.wordpress.org/trunk@31662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-09 02:11:28 +00:00
Andrew Ozz 19dbf7b998 Improve table footer tab sequence by moving `<tfoot>` after `<tbody>`. Props afercia, rianrietveld, DrewAPicture. Fixes #30914. 
Built from https://develop.svn.wordpress.org/trunk@31513


git-svn-id: http://core.svn.wordpress.org/trunk@31494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-22 21:48:26 +00:00
Scott Taylor df09597a65 After [31146], properly declare `$user_can` as a `private` field in `WP_Comments_List_Table`. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31161


git-svn-id: http://core.svn.wordpress.org/trunk@31142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:02:24 +00:00
Scott Taylor 60b0cd7943 The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31090


git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 07:05:25 +00:00
Scott Taylor bc1341628f Comment List Tables: 
* Declare `$extra_items` property
* Since `->get_column_info()` overrides its parent's method, it doesn't need to set `_column_headers`, which is an undeclared property that is only used for caching the lookup after the first run in the parent class, which isn't called in the child class.
* `$_args` in `WP_List_Table` has to be `protected` for `WP_Post_Comments_List_Table` to legally access it. `$_args` is awkward as is and should probably be only available via a getter.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@30984


git-svn-id: http://core.svn.wordpress.org/trunk@30970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-20 23:27:25 +00:00
Sergey Biryukov 471dc2022f Add missing label to comment type filter dropdown. 
props afercia.
fixes #29922.
Built from https://develop.svn.wordpress.org/trunk@29872


git-svn-id: http://core.svn.wordpress.org/trunk@29631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-11 02:26:18 +00:00
Sergey Biryukov ebdfe06843 Don't display an empty comment author IP link on Comments screen. 
props afercia.
fixes #29766.
Built from https://develop.svn.wordpress.org/trunk@29774


git-svn-id: http://core.svn.wordpress.org/trunk@29546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-28 06:38:18 +00:00
Andrew Nacin f7392ef917 Pinking shears. 
Built from https://develop.svn.wordpress.org/trunk@29707


git-svn-id: http://core.svn.wordpress.org/trunk@29481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-04 15:23:16 +00:00
Helen Hou-Sandí b80c5d3e51 Comments: Simplify JS for inline edit and reply. 
fixes #27533.

Built from https://develop.svn.wordpress.org/trunk@29662


git-svn-id: http://core.svn.wordpress.org/trunk@29436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-02 03:57:18 +00:00
Drew Jaynes d60a081137 Add `@access` tags to constructor docblocks in list table classes. 
See #28679. See [29459].

Built from https://develop.svn.wordpress.org/trunk@29460


git-svn-id: http://core.svn.wordpress.org/trunk@29238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-10 02:22:16 +00:00
Drew Jaynes 8e86454467 Document default arguments for the `WP_List_Table` class. Also add referenced docblocks to extending class constructors. 
Props mikejolley for the initial patch.
Fixes #28679. See #28298.

Built from https://develop.svn.wordpress.org/trunk@29459


git-svn-id: http://core.svn.wordpress.org/trunk@29237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-10 02:18:17 +00:00